Commit Graph

123514 Commits

Author SHA1 Message Date
Azat Khuzhin
1e2b0c8dc4 Fix possible UB in Set skipping index for functions with incorrect args
Usually functions are validated before index analysis, however it is
not the case for parallel replicas, and it requires additional checks
before interpreting function arguments.

<details>

<summary>stack trace</summary>

```
==172==WARNING: MemorySanitizer: use-of-uninitialized-value
    0 0x55cf82aedd6c in DB::ASTFunction* typeid_cast<DB::ASTFunction*, DB::IAST>(DB::IAST*) build_docker/./src/Common/typeid_cast.h:42:73
    1 0x55cf82aedd6c in DB::TypePromotion<DB::IAST>::CastHelper<DB::ASTFunction, false, false>::value(DB::IAST*) build_docker/./src/Common/TypePromotion.h:38:43
    2 0x55cf82aedd6c in std::__1::invoke_result<decltype(&CastHelper<DB::ASTFunction, false>::value), DB::TypePromotion<DB::IAST>::CastHelper<DB::ASTFunction, false, std::is_reference_v<DB::ASTFunction>>, DB::IAST*>::type DB::TypePromotion<DB::IAST>::as<DB::ASTFunction>() build_docker/./src/>
    3 0x55cf82aedd6c in DB::MergeTreeIndexConditionSet::operatorFromAST(std::__1::shared_ptr<DB::IAST>&) build_docker/./src/Storages/MergeTree/MergeTreeIndexSet.cpp:602:25
    4 0x55cf82ae5bc1 in DB::MergeTreeIndexConditionSet::traverseAST(std::__1::shared_ptr<DB::IAST>&) const build_docker/./src/Storages/MergeTree/MergeTreeIndexSet.cpp:547:9
    5 0x55cf82ae5de6 in DB::MergeTreeIndexConditionSet::traverseAST(std::__1::shared_ptr<DB::IAST>&) const build_docker/./src/Storages/MergeTree/MergeTreeIndexSet.cpp:552:13
    6 0x55cf82ae06db in DB::MergeTreeIndexConditionSet::MergeTreeIndexConditionSet() build_docker/.>
    ...
    12 0x55cf82aef09c in DB::MergeTreeIndexSet::createIndexCondition() const build_docker/./src/Storages/MergeTree/MergeTreeIndexSet.cpp:703:12
    13 0x55cf84951cd4 in DB::buildIndexes()
    14 0x55cf84955ed3 in DB::ReadFromMergeTree::selectRangesToReadImpl()
    15 0x55cf8494caef in DB::ReadFromMergeTree::selectRangesToRead()
    16 0x55cf82a409a9 in DB::MergeTreeDataSelectExecutor::estimateNumMarksToRead()
    17 0x55cf827f728d in DB::MergeTreeData::canUseParallelReplicasBasedOnPKAnalysis()
    18 0x55cf827f627e in DB::MergeTreeData::getQueryProcessingStage()
    19 0x55cf7f2f4969 in DB::InterpreterSelectQuery::getSampleBlockImpl() build_docker/./src/Interpreters/InterpreterSelectQuery.cpp:937:31
    20 0x55cf7f2daa00 in DB::InterpreterSelectQuery::InterpreterSelectQuery()
    24 0x55cf7f520b98 in DB::InterpreterSelectWithUnionQuery::buildCurrentChildInterpreter()
    25 0x55cf7f51b6cd in DB::InterpreterSelectWithUnionQuery::InterpreterSelectWithUnionQuery()
    27 0x55cf7f1d4ea9 in DB::InterpreterFactory::get(std::__1::shared_ptr<DB::IAST>&, std::__1::shared_ptr<DB::Context>, DB::SelectQueryOptions const&) build_docker/./src/Interpreters/InterpreterFactory.cpp:162:16
    28 0x55cf8012e485 in DB::executeQueryImpl(char const*, char const*, std::__1::shared_ptr<DB::Context>, bool, DB::QueryProcessingStage::Enum, DB::ReadBuffer*) build_docker/./src/Interpreters/executeQuery.cpp:1032:31
    29 0x55cf80121bc1 in DB::executeQuery(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, std::__1::shared_ptr<DB::Context>, bool, DB::QueryProcessingStage::Enum) build_docker/./src/Interpreters/executeQuery.cpp:1229:30
    30 0x55cf8389295f in DB::TCPHandler::runImpl() build_docker/./src/Server/TCPHandler.cpp:424:24
    31 0x55cf838d7dfb in DB::TCPHandler::run() build_docker/./src/Server/TCPHandler.cpp:2050:9
```

</details>

CI: https://s3.amazonaws.com/clickhouse-test-reports/53214/d99b10c340909ed4ee2e6edf0921e8a2f8561b0d/fuzzer_astfuzzermsan/report.html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-08-18 18:02:46 +02:00
Alexander Tokmakov
334e014c2c Merge branch 'master' into ignore_on_cluster_for_replicated_entity_queries 2023-08-18 17:48:37 +02:00
Robert Schulze
87824bea74
Bump openldap to a LTS branch (v2.5.16) 2023-08-18 15:47:02 +00:00
Austin Kothig
6b42975d33
Change BE-UUID to work the same as LE-UUID. Included high and low getters to provide cleaner code when accessing undertype. 2023-08-18 08:19:46 -07:00
Yakov Olkhovskiy
84cb358c14
Merge pull request #43210 from amosbird/storage_executable_stderr
Add different reactions when external command stderr has data
2023-08-18 11:17:46 -04:00
Alexander Tokmakov
a6684f7a37
Merge pull request #53484 from azat/rmt-queue-cleanup
Remove outdated code in ReplicatedMergeTreeQueue::initialize()
2023-08-18 18:11:33 +03:00
Ryadh DAHIMENE
1a42d71514 Added instructions to enable MySQL interface in Cloud 2023-08-18 16:57:58 +02:00
Nikolay Degterinsky
4c606590a1
Fix tiny thing in Replicated database (#53496)
* Fix tiny thing in Replicated database

* empty commit

---------

Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2023-08-18 17:29:24 +03:00
Alexander Tokmakov
4c3cb273a8
Merge pull request #53505 from arenadata/ADQM-1098
Added waiting for PostgreSQL compatibility port open in integrational tests.
2023-08-18 17:21:01 +03:00
vdimir
ae96d32027
Fix crash in join on sparse column 2023-08-18 14:14:54 +00:00
Alexander Tokmakov
763db4cc26
Merge pull request #53544 from ClickHouse/tavplubix-patch-9
Follow-up to #53528
2023-08-18 16:41:40 +03:00
robot-clickhouse
f1cb8a83fe Automatic style fix 2023-08-18 13:34:20 +00:00
Nikolai Kochetov
e9d8745971
Merge branch 'master' into group_array_max_element_size 2023-08-18 15:23:01 +02:00
Nikolai Kochetov
88e81a31fa Add server setting group_array_max_element_size. 2023-08-18 13:15:27 +00:00
Robert Schulze
e09098c5a1
Update annindexes.md 2023-08-18 15:01:13 +02:00
Nikita Mikhaylov
1822012180
Merge pull request #53485 from rschu1ze/CVE-2023-36054
krb5: Fix CVE-2023-36054
2023-08-18 14:56:08 +02:00
Alexander Gololobov
50061b9cb4
Merge pull request #53452 from ClickHouse/such_much_watch
Deduplicate same watch callbacks registered multiple times
2023-08-18 14:43:03 +02:00
Robert Schulze
b8912203e4
Merge pull request #53525 from aiven-sal/aiven-sal/siphash_readd
Re-add SipHash keyed functions, try II
2023-08-18 14:14:56 +02:00
Robert Schulze
ec7c0c3dd9
Fix ppc build 2023-08-18 12:08:59 +00:00
Kruglov Pavel
3bae63e48e
Fix special build 2023-08-18 13:56:32 +02:00
Alexander Tokmakov
5395a68baa
Merge pull request #53545 from ClickHouse/tavplubix-patch-8
Update 00002_log_and_exception_messages_formatting.sql
2023-08-18 14:45:58 +03:00
Ash Vardanian
9a4254616a
Docs: Extend USearch implementation details 2023-08-18 12:45:34 +01:00
Alexander Tokmakov
0bd378afd9
Merge pull request #53381 from bakwc/bakwc-patch-2
Fixed system.data_skipping_indices for MaterializedMySQL
2023-08-18 14:22:40 +03:00
Alexander Tokmakov
59ecbd8cb1
Merge pull request #53539 from ClickHouse/pufit/fix-keeper-path-check
Fix keeper default path check
2023-08-18 13:53:56 +03:00
Alexander Tokmakov
9174bee76a
Update 00002_log_and_exception_messages_formatting.sql 2023-08-18 13:45:35 +03:00
Alexander Tokmakov
45157769a5
Merge pull request #53534 from ClickHouse/tavplubix-patch-8
Update test.py
2023-08-18 13:42:33 +03:00
Alexander Tokmakov
428810a5b2
Update setup_export_logs.sh 2023-08-18 13:37:29 +03:00
taiyang-li
4f9429d2e4 fix ut tests/queries/0_stateless/00900_null_array_orc_load.sh 2023-08-18 17:58:24 +08:00
Vasily Nemkov
55168dc075 Merge remote-tracking branch 'upstream/master' into fix-ReplacingMergeTree-do_not_merge_across_partitions_select_final 2023-08-18 11:41:56 +02:00
Duc Canh Le
506880fce3 Merge branch 'master' into timeout_overflow_break_subquery 2023-08-18 09:28:49 +00:00
Duc Canh Le
2d353f8c43 Merge branch 'master' into limit_concurent_background_optimize 2023-08-18 09:25:27 +00:00
Alexander Gololobov
d3edcaae04 Fixed for using failed_op_index before it is initialized 2023-08-18 11:19:35 +02:00
Amos Bird
1c300a31b1
Fix build 2023-08-18 15:38:48 +08:00
Amos Bird
b2dd055cdf
Use poll instead 2023-08-18 15:38:48 +08:00
Amos Bird
b6de70b042
StorageExecutable check_exit_code default to false 2023-08-18 15:38:47 +08:00
Amos Bird
69ca36bfdf
Fix black style again 2023-08-18 15:38:47 +08:00
Amos Bird
c43bf153f5
Refactor 2023-08-18 15:38:46 +08:00
Amos Bird
e49fb4f348
Fix style 2023-08-18 15:38:46 +08:00
Amos Bird
dd0c71b32a
Add error_exit_reaction 2023-08-18 15:38:46 +08:00
Amos Bird
940ba60ae0
Fix non-linux build 2023-08-18 15:38:45 +08:00
Amos Bird
476f3cedc1
Various reactions when executable stderr has data 2023-08-18 15:38:45 +08:00
taiyang-li
15720d9cef fix ut tests/queries/0_stateless/02518_parquet_arrow_orc_boolean_value.sh 2023-08-18 15:10:25 +08:00
taiyang-li
8e0d5b7ee0 fix bugs 2023-08-18 13:31:26 +08:00
Alexey Milovidov
e7d0edfce6
Merge pull request #53261 from bharatnc/ncb/truncate-db
support TRUNCATE DATABASE
2023-08-18 08:22:32 +03:00
Alexey Milovidov
5fcd775656
Merge pull request #53528 from ClickHouse/fix_the_ci
Make sending logs to the cloud less fragile (and fix an unrelated flaky test)
2023-08-18 08:17:33 +03:00
Alexey Milovidov
3bcc4884d7
Merge pull request #53533 from ClickHouse/cpy
Use long timeout for S3 copy requests
2023-08-18 08:13:32 +03:00
Alexey Milovidov
ff7eeb979b
Merge pull request #53535 from nickitat/fix_test_grpc_protocol
Fix `AddressSanitizer failed to allocate 0x0 (0) bytes of SetAlternateSignalStack` in integration tests
2023-08-18 08:12:07 +03:00
Alexey Milovidov
a882bf1bb8
Merge pull request #53495 from ClickHouse/i_hate_materialized_views
Fix a race condition between RESTART REPLICAS and DROP DATABASE
2023-08-18 06:40:04 +03:00
pufit
2e69a1d3a2 Fix keeper default path check 2023-08-17 22:07:39 -04:00
Anton Popov
b9df41d5e3
Merge pull request #53129 from CurtizJ/non-deterministic-mutations
Allow to execute constant non-deterministic functions in mutations on initiator
2023-08-18 00:26:20 +02:00