Commit Graph

4096 Commits

Author SHA1 Message Date
Nicolae Vartolomei
b0f2f23a38 Test materialized view pushing extra columns
This test exists to prevent unintended changes to existing behaviour.

Although this behaviour might not be ideal it is can be exploited for 0-downtime changes to materialized views.

Step 1: Add new column to source table.
Step 2: Create new view reading source column.
Step 3: Swap views using `RENAME TABLE`.
Step 4: Add new column to destination table as well.
2019-10-20 10:26:44 +01:00
alexey-milovidov
52bfa9927c
Merge pull request #7384 from ClickHouse/fix_ub_in_system_parts
Fix UB in StoragesInfoStream
2019-10-19 09:59:39 +03:00
VDimir
f1630b4e2e Merge branch 'master' into feature/isvalidjson-5910 2019-10-19 06:21:21 +00:00
chertus
c5a850240c better ambiguous column detection in multiple join rewriter 2019-10-18 20:09:17 +03:00
chertus
37f07213ee better test 2019-10-18 19:45:59 +03:00
chertus
1bb8174285 disable push down for CROSS JOIN tests 2019-10-18 19:34:06 +03:00
chertus
2533652847 columns match priority: table alias > table name> aliased table name 2019-10-18 19:16:57 +03:00
alesapin
a014924c19 Remove wrong tests 2019-10-18 19:04:12 +03:00
Alexander Kuzmenkov
5e2cc37381
Distinguish Array and Tuple field types when creating from array of Fields. (#7179) 2019-10-18 18:57:05 +03:00
Alexander Tokmakov
06b28f9fe3 fix uninitialized offset for Lazy db 2019-10-18 16:09:24 +03:00
Alexander Kuzmenkov
3143fa37d7
Merge pull request #7371 from CurtizJ/fix-optimize-read-in-order
Fix optimize_read_in_order with IN and a subquery.
2019-10-18 15:55:53 +03:00
hcz
502672c973 Add aggregate function combinators: -OrNull & -OrDefault (#7331) 2019-10-18 12:25:39 +03:00
hcz
b87fe27cd6 Add tests 2019-10-18 16:45:56 +08:00
chertus
0f6176cc2d throw on ambiguous qualified column 2019-10-18 00:08:28 +03:00
alesapin
b222ec1209 Fix segmentation fault 2019-10-17 20:53:08 +03:00
alesapin
c29b39002d Fix race condition, add test 2019-10-17 20:36:53 +03:00
alesapin
05392fd882 Fix deadlock, add test and refactoring 2019-10-17 20:18:54 +03:00
Alexander Kuzmenkov
b62c9e729d
Merge pull request #7215 from ClickHouse/formats_improvements
Miscellaneous formats improvements
2019-10-17 17:37:38 +03:00
CurtizJ
546414c015 fix optimize_read_in_order with in subquery 2019-10-17 16:11:27 +03:00
alesapin
6dfe5c7142 Better introspection 2019-10-17 16:05:12 +03:00
Ivan
e595df05d9
Fix CREATE TABLE AS from table with virtual columns (#7183)
* Disable undefined instrumentation for rdkafka
2019-10-17 14:12:35 +03:00
philip.han
08a348fbd1 Made IN operator support Array(LowCardinality(Nullable(String))) 2019-10-17 19:08:36 +09:00
memo
ef09cedbb8 fix test bug 2019-10-17 11:38:49 +08:00
Alexander Tokmakov
e9e8d055af null_as_default for Values 2019-10-16 22:55:24 +03:00
Alexander Tokmakov
102cbfd25a fix old bug with default values 2019-10-16 22:27:33 +03:00
alesapin
842a31be8b More tests 2019-10-16 20:59:10 +03:00
alesapin
51de7a1cd1 Better tests 2019-10-16 20:12:53 +03:00
alesapin
fa557ab80d Better tests 2019-10-16 20:11:19 +03:00
alesapin
01e23f0a22 Better load of dictionaries 2019-10-16 20:06:52 +03:00
Alexander Tokmakov
5f6703130e fixes 2019-10-16 18:28:48 +03:00
millb
19a54a59bb Created: function hex for Decimal32, Decimal64, Decimal128 2019-10-16 18:28:10 +03:00
alesapin
b4e0ded048 Almost working 2019-10-16 17:59:52 +03:00
Alexander Tokmakov
aa9d29d6ae Merge branch 'master' into formats_improvements 2019-10-16 17:15:13 +03:00
Artem Zuikov
b70ca30447
Merge pull request #7335 from 4ertus2/ast
Remove asterisk_left_columns_only setting
2019-10-16 13:57:17 +03:00
Artem Zuikov
3ceeb95145
Merge pull request #7282 from 4ertus2/asof
ASOF JOIN inequalities
2019-10-16 13:46:52 +03:00
philip.han
a2bf848e12 Made bloom_filter type of index supporting LowCardinality and Nullable 2019-10-16 15:22:56 +09:00
alesapin
e690a3ca32 Half working code 2019-10-15 21:04:17 +03:00
Artem Zuikov
cf99f88bc4 PartialMergeJoin flush data on disk (#7186) 2019-10-15 19:31:49 +03:00
chertus
9667e54201 remove asterisk_left_columns_only setting 2019-10-15 17:42:57 +03:00
memo
8b1b7f2a5f add arrayCompact test 2019-10-15 16:09:10 +08:00
alexey-milovidov
6a44336b86
Merge pull request #7304 from sundy-li/ttl_check
Check TTL in StorageFactory
2019-10-14 20:11:37 +03:00
Alexander Kuzmenkov
831fb2cbfd
Merge pull request #7283 from ClickHouse/aku/in-unconvertible
Ignore non-convertible values at any depth on the right side of the IN operator
2019-10-14 18:32:22 +03:00
Alexander Kuzmenkov
160d8a6416 Ignore non-convertible values at any depth on the right side of IN
operator.

The values that are not convertible to the left argument type can't
match anyway, so it is safe to discard them.
2019-10-14 14:25:03 +03:00
alesapin
1ce0eb6e63 Appropriate error codes numbers 2019-10-14 13:04:10 +03:00
alesapin
ecde224692 More tests 2019-10-14 12:52:43 +03:00
alexey-milovidov
f0409348a1
Merge pull request #7294 from hczhcz/patch-1013
Add arraySplit
2019-10-14 12:32:09 +03:00
alesapin
67ea66604f Fix segmentation fault in database factory 2019-10-14 12:21:29 +03:00
sundy-li
b2109e4ece Check TTL in StorageFactory 2019-10-14 17:03:39 +08:00
Danila Kutenin
19ecc3e6cf
Merge pull request #7299 from ClickHouse/multi_match_all_indices
Add multi{Fuzzy}MatchAllIndices functions
2019-10-14 10:58:27 +02:00
alesapin
155731a676 Merge branch 'master' into dictionaries_ddl_interpreter 2019-10-14 11:49:18 +03:00
alexey-milovidov
323a756115
Merge pull request #7298 from Vdimir/feature/count-arity-validation-7095
Add missing arity validation for count/counIf
2019-10-14 08:52:58 +03:00
Danila Kutenin
57f20ba17e All multi{Fuzzy}MatchAllIndices functions 2019-10-13 15:22:09 +02:00
hcz
c8c40e159d Add arraySplit 2019-10-13 16:06:57 +08:00
Nikolai Kochetov
22dfc611c9 Remove comments from test. 2019-10-12 21:49:25 +03:00
Nikolai Kochetov
51bce40d5e
Merge pull request #7284 from ClickHouse/fix-7216
Fix for #7216
2019-10-12 19:20:33 +03:00
VDimir
0230aca903 Remove tests with count accepting 2 args 2019-10-12 15:44:14 +00:00
Nikolai Kochetov
6f758babf6
Merge pull request #7289 from infinivision/fix_pull_7109
Fixed #7109 groupBitmapOr(31) segfault
2019-10-12 16:42:11 +03:00
VDimir
1174fc346b Add isValidJSON function 2019-10-12 11:42:43 +00:00
Zhichang Yu
679db35ed3 Fixed #7109 groupBitmapOr(31) segfault 2019-10-12 10:36:52 +08:00
Nikolai Kochetov
8186644562 Update test. 2019-10-11 21:04:58 +03:00
chertus
91c7ae83a3 asof join inequalities 2019-10-11 20:56:26 +03:00
Nikolai Kochetov
e5c8a62142 Fix tests. 2019-10-11 20:24:18 +03:00
Nikolai Kochetov
bf794a8260 Fix tests. 2019-10-11 18:59:27 +03:00
alesapin
653aa7c005 Fix unit tests and segfault 2019-10-11 18:41:52 +03:00
alesapin
967fe64793 Add simpliest tests 2019-10-11 18:22:30 +03:00
Nikolai Kochetov
10366f79ae Update url params in shell_config and tests.] 2019-10-11 16:34:26 +03:00
Nikolai Kochetov
2ecf7abf6c Update url params in shell_config. 2019-10-11 15:08:11 +03:00
Nikolai Kochetov
a15d8f36d5
Merge pull request #7270 from azat/uniqCombined-memory-usage-tests-fixes
uniqCombined memory usage tests fixes
2019-10-10 23:53:55 +03:00
Azat Khuzhin
e25bdc8d25 tests/00212_shard_aggregate_function_uniq: adjust values for uniqCombined(12)(String)
In e373862c83 the maxium size for HashTable in
CombinedCardinalityEstimator had been reduced for power of 2 for String
(since otherwise the size of the hashtable becames bigger then the
sizeof HLL).

Refs: https://github.com/ClickHouse/ClickHouse/pull/7236#issuecomment-540496270
Fixes: e373862c83 ("Do not use more then 98K of memory for uniqCombined*")
2019-10-10 21:47:51 +03:00
Azat Khuzhin
eb7d4797e3 tests/00212_shard_aggregate_function_uniq: break into sections 2019-10-10 21:47:51 +03:00
Alexander Kazakov
03c7b7ff8d
Prevent from using non-deterministic functions in mutations of replicated tables (#7247)
* Added isDeterministic() to IFunctionBuilder i-face
* A test for non-deterministic mutations
* In MutationsInterpreter::validate() ensure deterministic functions
* Adjusted nondeterministic mutation tests
* Moved around some code in MutationsInterpreter::validate()
* Dropped unnecessary check in findFirstNonDeterministicFuncName()
* Corrections to IFunction{Base,Builder} interface
2019-10-10 17:38:08 +03:00
alexey-milovidov
689411abe0
Merge pull request #7222 from azat/uniqCombined64
[RFC] Introduce uniqCombined64() to get sane results for cardinality > UINT_MAX
2019-10-09 20:29:56 +03:00
alexey-milovidov
81a9c81ba7
Merge pull request #7236 from azat/uniqCombined-memory-usage
Do not use more then 98K of memory for uniqCombined*
2019-10-09 20:19:30 +03:00
alexey-milovidov
01e08a23c2
Merge pull request #7240 from ClickHouse/function-get-macro
Added function `getMacro`
2019-10-09 15:28:54 +03:00
alexey-milovidov
9b2e025918
Merge pull request #7234 from ClickHouse/aku/null-field-serialization
Serialize Null Fields correctly in DataTypeNullable.
2019-10-09 04:30:37 +03:00
Alexey Milovidov
6d2a79e832 Added a test 2019-10-09 04:18:12 +03:00
Azat Khuzhin
e373862c83 Do not use more then 98K of memory for uniqCombined*
uniqCombined() uses hashtable for medium cardinality, and since
HashTable resize by the power of 2 (well actually HashTableGrower grows
double by the power of 2, hence HashTableGrower::increaseSize() should
be overwritten to change this), with 1<<13 (default for uniqCombined)
and UInt64 HashValueType, the HashTable will takes:

  getBufferSizeInBytes() == 131072

While it should be not greater then sizeof(HLL) ~= 98K, so reduce the
maximum cardinality for hashtable to 1<<12 with UInt64 HashValueType and
to 1<13 with UInt32, overwrite HashTableGrower::increaseSize() and cover
this using max_memory_usage.

Refs: https://github.com/ClickHouse/ClickHouse/pull/7221#issuecomment-539672742

v2: cover uniqCombined() with non-default K
2019-10-09 02:39:23 +03:00
alexey-milovidov
4c1f0177b6
Merge pull request #7109 from infinivision/aggBitmapAnd
added groupBitmapAnd, groupBitmapOr, groupBitmapXor
2019-10-08 22:51:46 +03:00
alexey-milovidov
b9aa5d812d
Merge pull request #7171 from nikvas0/nikvas0/lazy_db
Lazy Database
2019-10-08 22:15:55 +03:00
Azat Khuzhin
f46c5a47c0 Introduce uniqCombined64() to get sane results for cardinality > UINT_MAX
By default uniqCombined() uses 32-bit hash for all types except String,
so this means that you cannot use uniqCombined() with i.e UInt64 and
cardinality > UINT_MAX, although you can use uniqCombined(toString())
and this will lead to 64-bit hash, but will not have good performance.

So uniqCombined64() had been introduced to fix this.

Requires: #7213
2019-10-08 21:59:35 +03:00
alexey-milovidov
ddc2299901
Update 01016_null_part_minmax.sql 2019-10-08 21:52:48 +03:00
Alexander Kuzmenkov
a5b1496fe9 Serialize Null Fields correctly in DataTypeNullable. 2019-10-08 21:21:24 +03:00
Vasilyev Nikita
030aa1cf10 fix 2019-10-08 11:10:55 +03:00
Alexey Milovidov
15bba8b498 Updated test 2019-10-07 22:16:45 +03:00
alexey-milovidov
bcc4e3f0ba
Merge branch 'master' into issue-6615 2019-10-07 22:12:25 +03:00
Alexander Tokmakov
a2c83ac82e add tests 2019-10-07 19:31:30 +03:00
alexey-milovidov
d096119529
Merge pull request #7156 from ClickHouse/fix-header-for-now
Fix header for function 'now'
2019-10-05 22:35:23 +03:00
alexey-milovidov
bb8414bdeb
Merge pull request #7201 from vzakaznikov/enabling_again_live_view_tests
A quick fix to resolve crash in LIVE VIEW table and re-enabling all LIVE VIEW tests.
2019-10-05 20:47:34 +03:00
Vitaliy Zakaznikov
6b8e61737a * Fixing crash in LIVE VIEW
* Re-enabling all LIVE VIEW tests
2019-10-05 08:05:24 -04:00
alexey-milovidov
9c2f3ba41a
Merge pull request #6984 from achimbab/pr_bf
Made bloom_filter type of index supporting arrays
2019-10-04 18:08:42 +03:00
tavplubix
d73db7f779
Merge pull request #6781 from ClickHouse/merging_values_with_expressions
Merging Values with expressions
2019-10-04 12:51:22 +03:00
Nikolai Kochetov
90472293fd Added test with function randConstant. 2019-10-04 12:22:07 +03:00
alesapin
4e83f65089 Fix bug with segmentation fault in ATTACH PART query 2019-10-03 21:07:47 +03:00
Vasilyev Nikita
d6490892a7 fix metadata time 2019-10-03 17:18:17 +03:00
Alexander Tokmakov
a58996817f allow query parameters in Values 2019-10-02 22:54:40 +03:00
Alexander Tokmakov
565c273eaa Merge branch 'master' into merging_values_with_expressions 2019-10-02 20:51:44 +03:00
Alexander Tokmakov
80e5976d10 fixes after review 2019-10-02 20:51:00 +03:00
Vasilyev Nikita
136b1665a3 test rename 2019-10-02 16:06:57 +03:00
Vitaliy Zakaznikov
ffe8931cda Revert "Merge pull request #6770 from yandex/temporary-remove-live-view-tests"
This reverts commit 6cf5327269, reversing
changes made to 4155771106.
2019-10-02 06:52:40 -04:00
Vasilyev Nikita
45ecff99a1 upd test 2019-10-02 09:31:23 +03:00
Artem Zuikov
48ab9afce6
Merge pull request #7122 from 4ertus2/mjoin
Squash left-hand blocks in partial merge join (optimization)
2019-10-01 17:23:10 +03:00
Vasilyev Nikita
71a2002417 test with sleep 2019-10-01 16:57:58 +03:00
Vasilyev Nikita
c5087219c4 test 2019-10-01 16:53:55 +03:00
Alexander Tokmakov
979f235e38 Merge branch 'master' into merging_values_with_expressions 2019-09-30 18:06:58 +03:00
chertus
5212d43ae4 simplify pmj settings 2019-09-30 17:36:45 +03:00
alexey-milovidov
e50a874537
Merge pull request #7118 from ClickHouse/improve_template_format
Minor improvements of Template format
2019-09-30 15:00:27 +03:00
Alexander Kazakov
2f355d716a Corrections to tests 00992/00993:mutations to be deterministic 2019-09-27 16:38:40 +03:00
chertus
baaf0a7c5b partial_merge_join_optimisations -> partial_merge_join_optimizations 2019-09-27 15:25:02 +03:00
root
0189945ad8 Optimize empty IN subquery and empty INNER/RIGHT JOIN. 2019-09-27 19:06:20 +08:00
Zhichang Yu
8945714c27 added groupBitmapAnd, groupBitmapOr, groupBitmapXor 2019-09-27 10:21:07 +08:00
Alexander Tokmakov
004455a029 fixes 2019-09-27 00:40:14 +03:00
alexey-milovidov
a2fc7e2e9e
Merge pull request #7093 from millb/merges_counter_metric
Add merge metric
2019-09-26 21:49:43 +03:00
tavplubix
c3ed1f38a6
Merge branch 'master' into improve_template_format 2019-09-26 19:19:11 +03:00
millb
ea013cf1a2 Fixed test 2019-09-26 17:44:04 +03:00
millb
259be751ee Fixed metric name.
Add metric description.
Add test.
2019-09-26 15:06:52 +03:00
alexey-milovidov
64e889d872
Merge pull request #7070 from 4ertus2/mjoin
PartialMergeJoin optimisation (skip not intersected blocks)
2019-09-25 02:24:42 +03:00
Alexander Tokmakov
d642304b1d add CustomSeparated format 2019-09-24 22:56:45 +03:00
chertus
0467229eff fix all left partial merge join on block borders 2019-09-24 21:21:57 +03:00
Alexander Tokmakov
e197cc8a49 read settings from file 2019-09-24 17:45:04 +03:00
alexey-milovidov
c4c936c685
Merge pull request #7049 from ClickHouse/ucasFL-master
Merging function "repeat"
2019-09-23 22:52:38 +03:00
alexey-milovidov
e24d882326
Merge pull request #7024 from millb/master
Fixed Function Hex for Float32 and Float64
2019-09-23 22:52:19 +03:00
Alexey Milovidov
89f27de705 Merge branch 'master' into ucasFL-master 2019-09-23 21:05:29 +03:00
Alexey Milovidov
8579c26efb Changed repository URL 2019-09-23 19:18:19 +03:00
millb
bd29efdbbe New hex function release
Bugs and tests fixed
2019-09-23 18:47:34 +03:00
Alexander Tokmakov
769d33848b allow specifying column idx in format string 2019-09-23 18:10:48 +03:00
chertus
9261d9d970 stabilize tests (add order by) 2019-09-23 16:55:04 +03:00
Alexander Tokmakov
89280c0ca8 fix tests 2019-09-23 13:45:26 +03:00
philip.han
3c40bb86ae Clean up a test table in bloom_filter_test 2019-09-23 15:45:57 +09:00
philip.han
833b188b88 Fix a result of bloom_filter_test 2019-09-23 15:24:53 +09:00
philip.han
315fcc6ef6 Add a testcase that checks nested array type of bloom_filter 2019-09-23 12:41:23 +09:00
Alexey Milovidov
e6f1fdc011 Added another test 2019-09-23 02:56:27 +03:00
Alexey Milovidov
69c79c31bb Merging function 'repeat': improved test 2019-09-23 02:31:33 +03:00
Alexey Milovidov
454b83fcd3 Merging function 'repeat' 2019-09-23 02:30:13 +03:00
Alexey Milovidov
52272eeea9 Merge branch 'master' of https://github.com/ucasFL/ClickHouse into ucasFL-master 2019-09-23 02:04:18 +03:00
alexey-milovidov
6fa234cea4
Merge pull request #6894 from azat-archive/hashed-dict-memory-usage-v2
[RFC] Add sparsehash support for hashed dictionary (to reduce memory usage)
2019-09-22 15:55:36 +03:00
fenglv
4465fdb8bf Add test
fix

fix

fix
2019-09-22 14:25:43 +08:00
alexey-milovidov
67e02b4ea0
Merge pull request #6957 from infinivision/add_bitmapSubsetLimit
added bitmapSubsetLimit
2019-09-22 04:58:44 +03:00
Azat Khuzhin
420089c301
Add new dictionary layout (sparse_hashed) that is more memory efficient
With this new layout, sparsehash will be used over default HashMap,
sparsehash is more memory efficient but it is also slower.

So in a nutshell:
- HashMap uses ~2x more memory then sparse_hash_map
- HashMap ~2-2.5x faster then sparse_hash_map
(tested on lots of input, and the most close to production was
dictionary with 600KK hashes and UInt16 as value)

TODO:
- fix allocated memory calculation
- getBufferSizeInBytes/getBufferSizeInCells interface
- benchmarks

v0: replace HashMap with google::sparse_hash_map
v2: use google::sparse_hash_map only when <sparse> isset to true
v3: replace attributes with different layout
v4: use ch hash over std::hash
2019-09-21 02:22:40 +03:00
alexey-milovidov
f8d19f6bf3
Merge pull request #6968 from azat-archive/create_as_skip_indices
[RFC] Introduce create_as_skip_indices
2019-09-20 23:53:49 +03:00
alexey-milovidov
2432a68009
Merge pull request #7022 from 4ertus2/bugs
Fix "Unknown identifier" in ORDER BY and GROUP BY with Multiple Joins
2019-09-20 23:45:51 +03:00
alexey-milovidov
3f500aad4b
Merge pull request #6976 from sfod/issue-3571
Throw exceptions if WITH TOTALS/ROLLUP/CUBE are specified without agg…
2019-09-20 23:39:00 +03:00
Alexander Tokmakov
0080639f79 Merge branch 'master' into merging_values_with_expressions 2019-09-20 23:26:01 +03:00
alexey-milovidov
123b8cb43c
Merge pull request #6990 from Akazz/timeout_for_sync_replica_cmd
Fixed timeout mechanism for SYNC REPLICA command + simplified related code
2019-09-20 20:32:51 +03:00
alexey-milovidov
aabd6906f2
Merge pull request #6982 from 4ertus2/mjoin
PartialMergeJoin bugfixes
2019-09-20 20:19:00 +03:00
millb
4f24512ba4 Test added. 2019-09-20 19:40:06 +03:00
chertus
7726130303 fix multiple joins aliasing for order by and group by 2019-09-20 19:01:19 +03:00
sfod
bc9bcfdb7e Fix tests which use WITH TOTALS without aggregation 2019-09-20 17:42:30 +03:00
sfod
bf2654e093 Use sql file to test changes 2019-09-20 17:39:26 +03:00
Alexander Kazakov
2d807368e1 Adjusted timings in test + more verbose diagnostics 2019-09-20 00:20:58 +03:00
Azat Khuzhin
b2a3db1048
Ignore indices for CREATE TABLE .. AS .. if storage do not support them 2019-09-19 23:55:38 +03:00