Commit Graph

102336 Commits

Author SHA1 Message Date
Sema Checherinda
dd93d331c1 fix 01168_mutations_isolation 2022-11-23 15:16:08 +00:00
Sema Checherinda
9edad4a078 make test_detached_parts_metrics wait delete inactive and empty parts 2022-11-23 15:16:08 +00:00
Sema Checherinda
44a8f2f460 work with test_merge_tree_s3 and test_merge_tree_s3_restore 2022-11-23 15:16:08 +00:00
Sema Checherinda
81faf40fb4 address 01170_alter_partition_isolation and 01169_alter_partition_isolation_stress 2022-11-23 15:16:08 +00:00
Sema Checherinda
cddf44034d address test_transactions 2022-11-23 15:16:08 +00:00
Sema Checherinda
8977e499c2 address 01825_type_json_18 test 2022-11-23 15:16:08 +00:00
Sema Checherinda
dc19141d84 fix test_detached_parts_metrics 2022-11-23 15:16:08 +00:00
Sema Checherinda
f2b9f80f2f fix tidy build 2022-11-23 15:16:08 +00:00
Sema Checherinda
6d929266e0 address 01825_type_json_schema_race_long test 2022-11-23 15:16:08 +00:00
Sema Checherinda
15012c7070 address the review comments 2022-11-23 15:16:08 +00:00
Sema Checherinda
8b87c3c251 ajust test, now parts created when drop, some parts names are changed 2022-11-23 15:16:08 +00:00
Sema Checherinda
fb86019db9 Delete parts over replacing them with empty parts 2022-11-23 15:16:08 +00:00
Maksim Kita
ee9a18f0d9 Analyzer table functions untuple fix 2022-11-23 16:03:06 +01:00
Sema Checherinda
6040e35949
Merge pull request #43504 from CheSema/create-parser-fuzzer-stack-overflow
check ast limits for create_parser_fuzzer
2022-11-23 15:15:17 +01:00
Nikolai Kochetov
f7d02fbe75 Fixing special build. 2022-11-23 14:05:26 +00:00
Maksim Kita
0bc3ff1ba3 Analyzer UniqInjectiveFunctionsEliminationPass 2022-11-23 14:55:34 +01:00
Maksim Kita
d2d44c5e54 Analyzer SumIfToCountIfPass fix 2022-11-23 14:55:12 +01:00
Alexey Milovidov
0076109654
Merge pull request #43535 from bit-ranger/master
Update kafka.md to correct link address
2022-11-23 14:50:07 +01:00
Alexey Milovidov
59cd6abf7d
Merge pull request #43538 from gingerwizard/diag_sec
bump lib for diag
2022-11-23 14:48:34 +01:00
Alexander Tokmakov
52de0423bf
Merge pull request #43571 from ClickHouse/revert-43404-part.log.uuid
Revert "Add table_uuid to system.parts"
2022-11-23 16:42:16 +03:00
Alexander Tokmakov
c0133199c8
Revert "Add table_uuid to system.parts" 2022-11-23 16:41:43 +03:00
Antonio Andelic
981e8a3a27 Modifiy visitor 2022-11-23 13:32:36 +00:00
Vasily Nemkov
246c6ff320 Cleanup 2022-11-23 17:29:38 +04:00
Vasily Nemkov
aa78f1c842 Made sure SettingsProfilesInfo::profiles is a subset of SettingsProfilesInfo::profiles_with_implicit
That means SettingsProfilesInfo::profiles now:
- has default_profile_id (if enabled)
- doesn't have profiles that are not matching for current user/roles
2022-11-23 17:29:38 +04:00
Alexander Tokmakov
672b2a2325
Merge pull request #43401 from ClickHouse/revert_SingleValueDataString_followup
Fix mess with signed sizes in SingleValueDataString
2022-11-23 16:21:58 +03:00
Alexander Tokmakov
ad74961075
Merge branch 'master' into tavplubix-patch-5 2022-11-23 15:57:11 +03:00
Alexander Tokmakov
81abb2036e
Merge pull request #43514 from ClickHouse/add_test_singledatavalue
Add another test for SingleDataValueString
2022-11-23 15:05:08 +03:00
Alexander Gololobov
1dec7910c3
Merge pull request #43336 from azat/buffer/fix-rollback
Fix possible "No column to rollback" logical error during INSERT into Buffer
2022-11-23 13:00:32 +01:00
Alexander Tokmakov
72d1089745
Merge pull request #43550 from ClickHouse/tavplubix-patch-7
Disable broken 00176_bson_parallel_parsing
2022-11-23 14:58:32 +03:00
Alexander Tokmakov
a2c53a56c2
Update 00176_bson_parallel_parsing.sh 2022-11-23 14:57:13 +03:00
Igor Nikonov
6ef83f455c
Merge pull request #43410 from ClickHouse/igor/fix-distinct-limitby-limit
Fix: limit hint for DISTINCT ignores LIMIT BY
2022-11-23 12:43:15 +01:00
Alexander Tokmakov
a58e10298c
Merge pull request #43542 from ClickHouse/tavplubix-patch-7
Temporarily disable `test_hive_query`
2022-11-23 14:12:03 +03:00
Alexander Tokmakov
f44eb4e021
Update test.py 2022-11-23 14:10:49 +03:00
Nikolay Degterinsky
ad11b73218
Merge pull request #43540 from Nyantechnolog/patch-1
doc fix
2022-11-23 12:07:38 +01:00
Antonio Andelic
e84e05d849 Modify visitor 2022-11-23 10:27:38 +00:00
Kseniia Sumarokova
c81257c7e2
Merge pull request #43442 from kssenii/fix-progress-from-stdin
Show read rows for reading from stdin in client
2022-11-23 11:23:16 +01:00
Maksim Kita
43a451d55e
Merge pull request #43321 from kitaisreal/analyzer-small-fixes
Analyzer small fixes
2022-11-23 13:19:32 +03:00
Sidorov Pavel
51dac6ac7a
doc fix 2022-11-23 12:33:25 +03:00
Antonio Andelic
84884df595 Substitute UDFs in CREATE queries 2022-11-23 09:28:08 +00:00
Dale McDiarmid
60f7a40c0b bump lib for diag 2022-11-23 09:25:58 +00:00
bit-ranger
c6946d96a1
Update kafka.md 2022-11-23 16:30:53 +09:00
Sema Checherinda
4820cfbb91 check ast limits for create_parser_fuzzer 2022-11-23 00:46:27 +01:00
Maksim Kita
db1b971643
Merge pull request #43451 from ClickHouse/explain-query-tree-run
Set run_passes to 1 by default
2022-11-23 01:30:49 +03:00
Arthur Passos
79d5759da9 Add test that covers the case of data being shared across multiple chunks and offsets being monotonically increasing 2022-11-22 17:38:53 -03:00
Alexey Milovidov
26d7b234b7
Merge pull request #43166 from azat/build/libcxx-only-for-cxx
Do not include libcxx library for C
2022-11-22 20:11:07 +01:00
Alexey Milovidov
25780be0c6
Merge pull request #42265 from taofengliu/group_by_all
Support GROUP BY ALL
2022-11-22 20:08:23 +01:00
Alexey Milovidov
8cb34913a1
Merge pull request #42461 from Enmk/ldap_fix_search_limit
fix LDAP in case of many roles on user
2022-11-22 20:05:14 +01:00
Azat Khuzhin
2cfbc27f13 Fix incorrect memory accounting because of merges/mutations
In case of merges/mutations, separate MemoryTracker object is used, to
track memory separately, to report this metrics.

However, the tail of those allocations hadn't been taken into account,
and in case of lots of mutations/merges it can be significant.

100% reproducible with the following example:

Start the server w/o frequent sync with RSS:

    $ clickhouse-server -C /src/programs/server/config.xml -- --asynchronous_metrics_update_period_s=86400

Run the following snippet:

    create table data (key Int, value Nullable(Decimal(38, 0))) engine=ReplicatedMergeTree('/ch/data', '1') order by key
    insert into data values (1, -13028236692093846346337460743176821145)
    alter table data modify column value UInt256
    Code: 341. DB::Exception: Received from localhost:9000. DB::Exception: Exception happened during execution of mutation 'mutation_2.txt' with part 'all_1_1_0' reason: 'Code: 407. DB::Exception: Convert overflow: while executing 'FUNCTION _CAST(value :: 1, 'UInt256' :: 2) -> _CAST(value, 'UInt256') UInt256 : 3': (while reading from part ./store/dd9/dd9ef183-1270-4877-af22-8a000bdcc1b8/all_1_1_0/): While executing MergeTreeInOrder. (DECIMAL_OVERFLOW) (version 22.12.1.1)'. This error maybe retryable or not. In case of unretryable error, mutation can be killed with KILL MUTATION query. (UNFINISHED)

And track the memory:

    select value/1e9 from system.metrics where metric like 'MemoryTracking'

Reported-by: @filimonov
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-22 19:40:35 +01:00
Azat Khuzhin
5da2f52722 Use Int64 over UInt64 for prev_untracked_memory* in MemoryTrackerThreadSwitcher
Since those types originally is Int64

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-22 19:40:35 +01:00
Azat Khuzhin
05f30aaad4 Fix logger name for MutateFromLogEntryTask
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-22 19:40:35 +01:00