Commit Graph

90023 Commits

Author SHA1 Message Date
Azat Khuzhin
78bd47d8df Fix excessive LIST requests to coordinator for transactions
In [1] there was only few transactions, but lots of List for /test/clickhouse/txn/log:

    $ clickhouse-local --format TSVWithNamesAndTypes --file zookeeper_log.tsv.gz -q "select * except('path|session_id|event_time|thread_id|event_date|xid') apply(x->groupUniqArray(x)), path, session_id, min(event_time), max(event_time), count() from table where has_watch and type = 'Request' group by path, session_id order by count() desc limit 1 format Vertical"
    Row 1:
    ──────
    groupUniqArray(type):             ['Request']
    groupUniqArray(query_id):         ['','62d75128-9031-48a5-87ba-aec3f0b591c6']
    groupUniqArray(address):          ['::1']
    groupUniqArray(port):             [9181]
    groupUniqArray(has_watch):        [1]
    groupUniqArray(op_num):           ['List']
    groupUniqArray(data):             ['']
    groupUniqArray(is_ephemeral):     [0]
    groupUniqArray(is_sequential):    [0]
    groupUniqArray(version):          []
    groupUniqArray(requests_size):    [0]
    groupUniqArray(request_idx):      [0]
    groupUniqArray(error):            []
    groupUniqArray(watch_type):       []
    groupUniqArray(watch_state):      []
    groupUniqArray(stat_version):     [0]
    groupUniqArray(stat_cversion):    [0]
    groupUniqArray(stat_dataLength):  [0]
    groupUniqArray(stat_numChildren): [0]
    groupUniqArray(children):         [[]]
    path:                             /test/clickhouse/txn/log
    session_id:                       1
    min(event_time):                  2022-05-27 12:54:09.025897
    max(event_time):                  2022-05-27 13:37:12.846314 <!-- last transaction was at 12:54, see server log
    count():                          3673675 <-- huge

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/37593/2613149f6bf4f242bbbf2c3c8539b5176fd77286/stateless_tests__debug__actions__[1/3].html

Server log:

    $ pigz -cd clickhouse-server.log.gz | fgrep TransactionLog: | head -1
    2022.05.27 12:54:09.026852 [ 5018 ] {62d75128-9031-48a5-87ba-aec3f0b591c6} <Trace> TransactionLog: Loading 33 entries from /test/clickhouse/txn/log: csn-0000000000..csn-0000000032
    $ pigz -cd clickhouse-server.log.gz | fgrep TransactionLog: | tail -1
    2022.05.27 12:54:58.909222 [ 509 ] {} <Test> TransactionLog: Closing readonly transaction (177, 38, 41b51ff1-bcba-43bf-bcea-e97ad05f6040)
    $ pigz -cd clickhouse-server.log.gz | fgrep 62d75128-9031-48a5-87ba-aec3f0b591c6 | tail -1
    2022.05.27 12:54:09.064857 [ 5018 ] {62d75128-9031-48a5-87ba-aec3f0b591c6} <Debug> MemoryTracker: Peak memory usage (for query): 0.00 B.

Fixes: #37398 (cc @tavplubix)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-05-30 11:39:34 +03:00
mergify[bot]
7a2460233b
Merge branch 'master' into try_fix_tests 2022-05-30 08:16:29 +00:00
flynn
9ffa5f5e0d fix typo 2022-05-30 08:10:16 +00:00
Alexey Milovidov
33b2a50740
Merge pull request #37630 from wangqinghuan/add-clickcat
add clickcat intro
2022-05-30 04:25:22 +03:00
qinghuan wang
ded9f5675d
Update gui.md 2022-05-30 09:22:06 +08:00
alesapin
6f35c28592 Fix style 2022-05-30 00:29:30 +02:00
Alexey Milovidov
746ff42239
Update gui.md 2022-05-30 01:13:03 +03:00
alesapin
c32b6076fb Remove stranges from code 2022-05-30 00:12:33 +02:00
mergify[bot]
8ceafbe1fa
Merge branch 'master' into try_fix_tests 2022-05-29 18:04:44 +00:00
alesapin
753bcee954 Fix lazy mark load 2022-05-29 18:38:09 +02:00
alesapin
aecab57e17
Merge pull request #37629 from ClickHouse/fix_failure
Fix refactoring issue
2022-05-29 18:35:54 +02:00
mergify[bot]
df9f7c59a2
Merge branch 'master' into try_fix_tests 2022-05-29 15:04:48 +00:00
alesapin
59a070778d More quite logging for S3 tests 2022-05-29 14:48:04 +02:00
alesapin
0e8ab36913 Merge branch 'master' into turn_on_s3_tests 2022-05-29 14:37:10 +02:00
qinghuan wang
c14b547f00
Update gui.md 2022-05-29 20:19:23 +08:00
alesapin
d2cdbf3956 Fix refactoring issue 2022-05-29 14:09:49 +02:00
alesapin
9dc81e5cc8
Merge pull request #37598 from ClickHouse/revert-37545-revert-37424-fix_fetching_part_deadlock
Revert "Revert "(only with zero-copy replication, non-production experimental feature not recommended to use) fix possible deadlock during fetching part""
2022-05-29 13:54:34 +02:00
Alexey Milovidov
6195429020
Update star-schema.md 2022-05-29 10:01:27 +03:00
Alexey Milovidov
c8935d6e6c
Update star-schema.md 2022-05-29 10:00:34 +03:00
Alexey Milovidov
e22a79eaf2
Update star-schema.md 2022-05-29 09:58:54 +03:00
Alexander Tokmakov
579b0e3323
Merge pull request #37627 from ClickHouse/revert-37416-fix_ReplicatedMergeTree_comments
Revert "Implemented changing comment to a ReplicatedMergeTree table"
2022-05-29 09:57:12 +03:00
Alexey Milovidov
9e3242f186
Merge pull request #37617 from CurtizJ/aggregation-sparse-columns
Better performance with sparse columns in aggregate functions
2022-05-29 09:36:07 +03:00
Alexander Tokmakov
562eec591e
Revert "Implemented changing comment to a ReplicatedMergeTree table" 2022-05-29 09:28:47 +03:00
Alexey Milovidov
97606c324c
Merge pull request #37574 from azat/mt-tiny-refactor
Remove unused MergeTreeDataMergerMutator::chooseMergeAlgorithm()
2022-05-29 07:59:57 +03:00
Alexey Milovidov
975f16049e
Merge pull request #37597 from azat/fix-01317_no_password_in_command_line
tests: fix 01317_no_password_in_command_line flakiness (and make it race free)
2022-05-29 07:59:10 +03:00
Alexey Milovidov
9e0f61a74f
Merge pull request #37623 from den-crane/patch-12
Doc. Notes about UInt64 key for dictionaries layout
2022-05-29 07:58:07 +03:00
Alexey Milovidov
118b577607
Merge pull request #37626 from ClickHouse/alexey-milovidov-patch-4
Update table structure for "ontime" dataset
2022-05-29 07:42:27 +03:00
Alexey Milovidov
be586f7b33
Update ontime.md 2022-05-29 06:43:50 +03:00
Alexey Milovidov
73c89e65e6
Update ontime.md 2022-05-29 06:31:15 +03:00
Alexey Milovidov
7be278c9ff
Update table structure for "ontime" dataset 2022-05-29 06:26:13 +03:00
Alexey Milovidov
73e2e63414
Merge pull request #37612 from ClickHouse/clang-tidy-14
Fix clang-tidy-14, part 1
2022-05-29 03:16:32 +03:00
Alexey Milovidov
b2ba2533b1
Merge pull request #35231 from ClickHouse/time-zone-in-stateless-tests
Change timezone in stateless tests
2022-05-29 03:09:12 +03:00
Alexander Tokmakov
313f4833d6 fix 2022-05-28 23:21:55 +02:00
Denny Crane
d7e098fb17
Update external-dicts-dict-layout.md 2022-05-28 17:26:11 -03:00
Denny Crane
1d2cf73b81
Update external-dicts-dict-layout.md 2022-05-28 17:14:36 -03:00
Denny Crane
2395764a92
Update external-dicts-dict-layout.md 2022-05-28 17:07:39 -03:00
Denny Crane
bfc7cbaf1f
Update external-dicts-dict-layout.md 2022-05-28 17:02:27 -03:00
Denny Crane
4573c2431e
Update external-dicts-dict-layout.md 2022-05-28 16:59:55 -03:00
Alexander Tokmakov
9e3e795353 fix 2022-05-28 21:56:10 +02:00
mergify[bot]
c273568e45
Merge branch 'master' into fix-01317_no_password_in_command_line 2022-05-28 18:27:45 +00:00
Alexey Milovidov
4e60c88a27
Merge pull request #37609 from DevTeamBK/Medium-Clang-Tidy-Fix
Fix Clang-Tidy:  remove std::move() from trivially-copyable object
2022-05-28 21:27:08 +03:00
Alexey Milovidov
8d0c46a105
Merge pull request #37614 from ClickHouse/test-reports-markup
Remove margin in test reports and change the font
2022-05-28 21:25:54 +03:00
Alexey Milovidov
e48af2efe4
Update report.py 2022-05-28 21:25:42 +03:00
Alexey Milovidov
e500ec5fd8
Update run-fuzzer.sh 2022-05-28 21:25:20 +03:00
Alexander Tokmakov
be498b0658 fix test 2022-05-28 19:40:26 +02:00
Alexander Tokmakov
f3c2ca6a13 Revert "Merge pull request #36634 from azat/01502_long_log_tinylog_deadlock_race-test"
This reverts commit c04c62795e, reversing
changes made to 88f05ac14a.
2022-05-28 19:28:38 +02:00
Alexander Tokmakov
70f39e0849 Revert "Merge pull request #36731 from azat/fix-async_inserts_stress_long-test"
This reverts commit d1d2f2c1a4, reversing
changes made to 1ddb04b992.
2022-05-28 19:27:40 +02:00
Alexander Tokmakov
9af6e237e1 remove retries 2022-05-28 19:25:56 +02:00
Alexander Tokmakov
1ae919a18a Revert "Merge pull request #35865 from azat/clickhouse-test-left-queries"
This reverts commit 18d094d79d, reversing
changes made to 224f4dc620.
2022-05-28 19:23:58 +02:00
Alexander Tokmakov
e33d986cf1 Revert "Merge pull request #34924 from azat/tests-overlaps"
This reverts commit f13e436d40, reversing
changes made to aa3c05e9d4.
2022-05-28 19:20:32 +02:00