Commit Graph

5724 Commits

Author SHA1 Message Date
filipe
3861a03927 fix pvs check 2020-10-08 20:14:54 -03:00
filipe
0436e0f8f1 fix style and pvs check 2020-10-03 20:50:44 -03:00
filipe
bab7c762bc fix style and pvs check 2020-10-03 20:38:21 -03:00
filipe
146f973437 add maximum_unit arg to formatReadableTimeDelta function 2020-10-03 19:38:51 -03:00
filipe
077ee81177 add an SQL function formatReadableTimeDelta to format time delta 2020-09-30 23:55:46 -03:00
alexey-milovidov
9808d0be81
Merge pull request #15376 from excitoon-favorites/fixs3storage
Fixed compression in S3 storage
2020-10-01 04:30:32 +03:00
tavplubix
2f95609f98
Merge pull request #15448 from ClickHouse/allow_synchronous_drop_for_atomic_db
Allow synchronous DROP/DETACH TABLE for Atomic
2020-10-01 01:14:31 +03:00
Artem Zuikov
0f6a6453fe
Remove multiple_joins_rewriter v1 (#15472) 2020-09-30 23:11:49 +03:00
Artem Zuikov
0ac18a382f
Fix JOIN with GROUP BY over StorageMerge (#15242) 2020-09-30 23:11:27 +03:00
Vladimir Chebotarev
0497ce4f9c Possibly better fix. 2020-09-30 18:29:10 +03:00
Nikolai Kochetov
45618c9d4c
Merge pull request #15437 from ClickHouse/azat-ThreadPool-UAF-fixes
Destroy resources captured by lambda after `ThreadFromGlobalPool::join()`
2020-09-30 16:50:30 +03:00
Vladimir Chebotarev
b460024356 Fixed bug in GZIP compression in S3 storage. 2020-09-30 16:09:55 +03:00
Vladimir Chebotarev
a38c7ff2a8 Somehow uncompressed PUT works and gzipped PUT doesn't, in S3 storage. 2020-09-30 15:04:42 +03:00
Vladimir Chebotarev
698768add0 Fixed format argument in S3 storage when compression method is selected. 2020-09-30 13:55:44 +03:00
alesapin
01d8a36cd6
Merge pull request #15456 from ClickHouse/more-exception-safety-in-shellcommand
Fix exception safety in ShellCommand
2020-09-30 12:56:55 +03:00
tavplubix
c9eeb149fd
Merge pull request #15384 from zhang2014/fix/ISSUES-15365
ISSUES-15365 fix attach mysql database database
2020-09-30 11:27:15 +03:00
Nikolai Kochetov
0e412686bc Better comments. 2020-09-30 11:25:22 +03:00
alexey-milovidov
0c07c2d3a3
Merge pull request #15089 from ClickHouse/codecs_for_nested_types
Codecs for nested types
2020-09-30 07:18:19 +03:00
alexey-milovidov
412a54e356
Merge pull request #14693 from hustnn/zk_exist_fix2
Fix potential memory leak caused by zookeeper exist calling
2020-09-30 04:48:11 +03:00
alexey-milovidov
b6bccfc4f4
Merge pull request #14776 from Vxider/disable_set_and_join_persistency
Support memory only mode for StorageJoin and StorageSet.
2020-09-30 04:35:43 +03:00
alexey-milovidov
ac989f3a8f
Merge pull request #15285 from ucasFL/now-with-timezone
function `now` allow an argument with timezone
2020-09-30 04:32:36 +03:00
Alexey Milovidov
78dbf10c7b Fix exception safety in ShellCommand 2020-09-30 03:00:45 +03:00
Alexander Tokmakov
e156e6115e add setting 2020-09-30 01:30:34 +03:00
alexey-milovidov
b658f348a7
Update MergeTreeDataPartWriterWide.cpp 2020-09-30 01:23:42 +03:00
alexey-milovidov
9f944424cf
Merge pull request #15364 from ClickHouse/format-raw-blob
Add format RawBLOB
2020-09-30 01:14:40 +03:00
alexey-milovidov
3e99ca797b
Merge pull request #15426 from ClickHouse/format-regexp-escaping-rule-change-default-to-raw
Format Regexp: change default escaping rule to Raw
2020-09-30 01:14:08 +03:00
Nikolai Kochetov
727289cb09 Destroy resurces captured by lambda after ThreadFromGlobalPool::join(). 2020-09-29 23:43:02 +03:00
Nikolai Kochetov
a2c70c4611 Destroy resurces captured by lambda after ThreadFromGlobalPool::join(). 2020-09-29 22:11:40 +03:00
Artem Zuikov
86cfc6f914
change error code (#15452) 2020-09-29 20:36:14 +03:00
alesapin
4ab39d2bee
Fix style 2020-09-29 18:19:30 +03:00
Alexander Tokmakov
cf86e19f38 fix build 2020-09-29 17:15:05 +03:00
Alexander Tokmakov
8692c10495 add alias 2020-09-29 17:12:40 +03:00
Alexander Tokmakov
5d19ed04f6 allow synchronous drop/detach table for Atomic 2020-09-29 16:47:08 +03:00
Nikolai Kochetov
33487c0e4a
Merge pull request #15422 from ClickHouse/query-plan-header-remove-columns
Remove column from header descriotion for EXPLAIN PLAN
2020-09-29 15:51:09 +03:00
Alexander Kuzmenkov
2d456e2cd6
Merge pull request #15407 from detailyang/master
bugfix:aggregate:fix boundingratio args check
2020-09-29 14:12:54 +03:00
Nikolai Kochetov
a7e7fd084f Destroy resurces captured by lambda after ThreadFromGlobalPool::join(). 2020-09-29 13:48:11 +03:00
Azat Khuzhin
1fcc36ef80 Use ThreadPool to ensure that everything has been finished in PipelineExecutor
This will fix possible UAF, since ThreadFromGlobalPool cannot wait until
the job will be reseted, for this you need to call ThreadPool::wait()
(that waits until scheduled_jobs will be zero), and this guarantee that
the job was reseted, otherwise some variables that job is referencing
may be already destroyed, while job hasn't been destoyed yet (example
that I found PipelineExecutor -> ThreadGroupStatusPtr -> MemoryTracker
-> ~MemoryTracker -> log, while log had been destroyed already, here is
TSAN report --
https://gist.github.com/azat/d480dc3af5a0a44de4b038e20807c4b9, copied
from
https://clickhouse-test-reports.s3.yandex.net/15035/79133a426fdf042e383ea0cdccc4dc8273baa3a7/functional_stateless_tests_(thread)/test_run.txt.out.log)
2020-09-29 11:00:03 +03:00
Azat Khuzhin
789434994a Reset job on failure too in ThreadPool::worker()
job should be reseted before decrementing scheduled_jobs to
ensure that the Job destroyed before wait() returns.
2020-09-29 10:56:36 +03:00
zhang2014
9e94c077e7 IESSUES-15365 try fix integration test 2020-09-29 10:39:30 +08:00
Alexey Milovidov
dee57d7976 Format Regexp: change default escaping rule to Raw 2020-09-29 00:19:13 +03:00
Alexey Milovidov
e4800e7b35 Fix comment 2020-09-29 00:10:36 +03:00
Nikolai Kochetov
347080ff9a Remove column from header descriotion for EXPLAIN PLAN and EXPLAIN PIPELINE 2020-09-28 20:37:11 +03:00
Alexander Kuzmenkov
51b9aaf4d8
Merge pull request #15363 from ClickHouse/format-regexp-raw
Add support for "Raw" column format for Regexp format
2020-09-28 20:03:32 +03:00
tavplubix
4578d89819
Merge pull request #15348 from ClickHouse/replicate_default_args
Continuation of #14791
2020-09-28 18:53:02 +03:00
tavplubix
421d3b0b86
Merge pull request #14760 from bharatnc/ncb/event_time_microsec_p2
add event_time_microseconds field for system.{trace,text,query,query_thread}_log tables
2020-09-28 18:34:21 +03:00
zhang2014
e5a6d06820 ISSUES-15365 try fix integration test failure 2020-09-28 21:15:02 +08:00
detailyang
6e70f2ce7a bugfix:aggregate:fix boundingratio args check 2020-09-28 19:56:42 +08:00
zhang2014
e40d23cfe5 ISSUES-15365 add ya make 2020-09-28 19:11:40 +08:00
Nikita Mikhaylov
72e4b10c00
Merge pull request #14842 from hexiaoting/hxt_dev
Fix bug for LineAsString Format
2020-09-28 14:02:23 +03:00
zhang2014
d3047d0783 ISSUES-15365 fix attach mysql database failure 2020-09-28 18:02:30 +08:00