Commit Graph

108998 Commits

Author SHA1 Message Date
Pradeep Chhetri
389803ca62
Merge branch 'master' into pchhetri/fix-query-in-stress 2023-02-27 11:27:16 +08:00
Alexey Milovidov
a649311fa1
Merge pull request #46922 from ClickHouse/review-tavplubix
Code review from @tavplubix
2023-02-27 05:15:43 +03:00
Nikolay Degterinsky
a4434a3125
Merge pull request #46924 from den-crane/patch-65
Doc. asterisk_include_materialized_columns / asterisk_include_alias_columns
2023-02-27 01:49:37 +01:00
Denny Crane
fd97f7ad0a
Update settings.md 2023-02-26 19:25:13 -04:00
Alexey Milovidov
e047646c6b
Merge pull request #46917 from ClickHouse/rs/better-syntaxexception
Make SyntaxExceptions easier to understand
2023-02-27 01:01:32 +03:00
Alexey Milovidov
c32f579d67 Review from @tavplubix 2023-02-26 22:58:40 +01:00
Alexey Milovidov
73aec86f5a Change exception message 2023-02-26 21:36:26 +01:00
Alexey Milovidov
1afbf49a63
Merge pull request #46832 from HarryLeeIBM/hlee-s390x-xz
Fix http xz compression issue for s390x
2023-02-26 22:31:57 +03:00
Alexey Milovidov
df5c7c98e6
Merge pull request #46897 from ClickHouse/fix-fill-empty-block
Fix - WITH FILL would produce abort when FillingTransform processing empty block
2023-02-26 22:30:50 +03:00
Robert Schulze
db3fbc871c
Merge pull request #46803 from ClickHouse/rs/cmake-too-old-arm
CMake: Add best effort checks that the build machine isn't too old
2023-02-26 20:28:53 +01:00
Robert Schulze
61706dfa53
Merge pull request #46869 from ClickHouse/rs/like-with-trailing-percentage
Small optimization of LIKE patterns with > 1 trailing %
2023-02-26 20:14:21 +01:00
Robert Schulze
b20ac16d08
Slightly easier to read SyntaxExceptions
E.g. exception text for input '2 ':

- before:
  Syntax error: Not a valid integer: 2

- now:
  Syntax error: Not a valid integer: '2 '
2023-02-26 15:17:28 +00:00
Robert Schulze
f53d38cf85
Merge branch 'master' into rs/like-with-trailing-percentage 2023-02-26 14:43:27 +01:00
Alexey Milovidov
b5438456aa
Merge pull request #46911 from azat/tests/fix-02116_interactive_hello
tests: fix 02116_interactive_hello for "official build"
2023-02-26 11:37:34 +03:00
Alexey Milovidov
9ac48dddb8
Merge pull request #46888 from vitlibar/fix-test_async_backups_to_same_destination
Fix test test_async_backups_to_same_destination.
2023-02-26 11:36:18 +03:00
Alexey Milovidov
d448a48f16
Merge pull request #46831 from azat/merge-default-prewhere
Allow PREWHERE for Merge with different DEFAULT expression for column
2023-02-26 10:02:34 +03:00
Robert Schulze
97f2778e34
Merge pull request #46889 from ClickHouse/rs/groupby-fuzz
Make ASTSelectQuery::formatImpl() more robust
2023-02-26 07:54:01 +01:00
Robert Schulze
5e68d50b39
Merge pull request #46752 from ClickHouse/rs/periods-in-kafka-topics
Allow configuration of Kafka topics with periods
2023-02-26 07:49:28 +01:00
Azat Khuzhin
cb4d665c02 tests: fix 02116_interactive_hello for "official build"
Example of such greeting:

    2023-02-26 15:26:33 expect: does "\u001b[0J\u001b[?25hClickHouse client version 23.3.1.207 (official build).\r\nConnecting to database test_i4r0kozg at localhost:9000 as user default.\r\nConnected to ClickHouse server version 23.3.1 revision 54461.\r\n\r\nWarnings:\r\n * Server logging level is set to 'test' and performance is degraded. This cannot be used in production.\r\n * Linux is not using a fast clock source. Performance can be degraded. Check /sys/devices/system/clocksource/clocksource0/current_clocksource\r\n * The setting 'allow_remote_fs_zero_copy_replication' is enabled for MergeTree tables. But the feature of 'zero-copy replication' is under development and is not ready for production. The usage of this feature can lead to data corruption and loss. The setting should be disabled in production.\r\n * Table system.session_log is enabled. It's unreliable and may contain garbage. Do not use it for any kind of security monitoring.\r\n\r\n\u001b[?2004h\u001b[1Gfunctional-tests :) " (spawn_id exp4) match regular expression "ClickHouse client version [\d]{2}.[\d]{1,2}.[\d]{1,2}.[\d]{1,}.\r"? Gate "ClickHouse client version *\r"? gate=yes re=no

CI: https://s3.amazonaws.com/clickhouse-test-reports/0/df1e18ad4cb9b08240273169ca7dd6ca1cac617c/stateless_tests__aarch64_/run.log
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-26 07:35:38 +01:00
Alexey Milovidov
df1e18ad4c
Merge pull request #46909 from ClickHouse/revert-45911-mutations_rename_hang
Revert "Fix several `RENAME COLUMN` bugs."
2023-02-26 05:47:48 +03:00
Alexey Milovidov
8f40bbd5b4
Revert "Fix several RENAME COLUMN bugs." 2023-02-26 05:47:05 +03:00
Yakov Olkhovskiy
dd25d8955e test is added 2023-02-26 02:30:54 +00:00
Alexey Milovidov
936f57e7b2
Merge pull request #46887 from ClickHouse/fix-flaky-test-12
Fix flaky `test_concurrent_queries_restriction_by_query_kind`
2023-02-26 04:30:51 +03:00
Alexey Milovidov
2472eeaefd
Update 02575_merge_prewhere_materialized.sql 2023-02-26 02:58:32 +03:00
Alexey Milovidov
3a3a2f352c
Merge pull request #46653 from aiven-sal/aiven-sal/and_opt_pr
ActionsDAG: do not change result of and() during optimization
2023-02-26 02:56:35 +03:00
Yakov Olkhovskiy
7b8d2d716e bypass empty blocks 2023-02-25 23:26:38 +00:00
Rich Raposa
bb51da7de1
Merge pull request #46805 from den-crane/patch-63
Doc. Final setting
2023-02-25 16:05:54 -07:00
Alexey Milovidov
6e4fc79639
Merge pull request #46609 from Algunenano/fix_recurring_alias
Fix incorrect alias recursion in QueryNormalizer
2023-02-26 02:03:17 +03:00
Alexey Milovidov
eb89ab471f
Merge pull request #45911 from ClickHouse/mutations_rename_hang
Fix several `RENAME COLUMN` bugs.
2023-02-26 01:56:40 +03:00
Alexey Milovidov
656af55831
Merge pull request #46384 from ClickHouse/fixes_for_993
Fixes for 993
2023-02-26 01:55:20 +03:00
Vitaly Baranov
2d38c89e2a Fix test test_async_backups_to_same_destination. 2023-02-25 23:38:40 +01:00
Robert Schulze
c668ddd506
Make ASTSelectQuery::formatImpl() more robust
Fixes #45204

The problem is that ASTSelectQuery::group_by_with_grouping_sets == true
implies ASTSelectQuery::groupBy() but sometimes this wasn't the case. I
added a sanity check a few months ago but had no idea how the AST became
corrupt.

All crashes/exceptions were during AST fuzzing. Looking at
Client/QueryFuzzer.cpp, there is a very small chance to run into the
issue. In detail:

1. In QueryFuzzer::fuzz(), we find that the AST is a ASTSelectQuery and
   groupBy() returns true.

2. With small probability, we do
     select->group_by_with_grouping_sets = !select->group_by_with_grouping_sets;
   where the (default false) group_by_with_grouping_sets flips true.

3. With small probability, we change the expression type in the
   following WHERE or PREWHERE if-branches.

This situation is illegal. One possibility is changing the fuzzing code
to not generate it. The fuzzing code is however generic, and doesn't
really care about such details. Therefore, instead add an (theoretically
unnecessary) extra check to ASTSelectQuery::formatImpl() for robustness.
2023-02-25 22:28:00 +00:00
Alexey Milovidov
c69f8f9712
Merge pull request #46836 from den-crane/patch-64
Doc. Examples for DEFAULT/MATERIALIZED/EPHEMERAL/ALIAS
2023-02-26 00:26:11 +03:00
Alexey Milovidov
88704c4d9f Fix flaky test_concurrent_queries_restriction_by_query_kind 2023-02-25 22:23:29 +01:00
Robert Schulze
fbba9e319d
Merge branch 'master' into rs/periods-in-kafka-topics 2023-02-25 21:45:20 +01:00
Robert Schulze
a402b61ceb
Merge pull request #46819 from ClickHouse/rs/fix-slowhyperscanchecker
Fix SlowWithHyperscanChecker
2023-02-25 21:41:38 +01:00
Alexey Milovidov
1ca6156b07
Merge pull request #46853 from ClickHouse/clickhouse-local-open-files
Increase the limit on the number of opened files in `clickhouse-local`
2023-02-25 22:57:33 +03:00
Alexey Milovidov
c4bf503690
Merge pull request #46850 from ClickHouse/add-test-45214
Add a test for #45214
2023-02-25 22:56:26 +03:00
Alexey Milovidov
93dffb13c2
Merge pull request #46848 from ClickHouse/add-test-43184
Add a test for #43184
2023-02-25 22:56:05 +03:00
Alexey Milovidov
25853da4ad
Merge pull request #46846 from ClickHouse/better-fatal-handling
Better handling of fatal errors
2023-02-25 22:55:14 +03:00
Alexey Milovidov
ffd512c90e
Merge pull request #46847 from ClickHouse/max-intersections-msan
Fix MSan report in `maxIntersections` function
2023-02-25 22:53:55 +03:00
Alexey Milovidov
c0de7be37c
Merge pull request #46845 from ClickHouse/a-new-trap
Add a trap
2023-02-25 22:53:08 +03:00
Alexey Milovidov
b3c6a33a4d
Merge pull request #46844 from ClickHouse/fix-strange-code
Non-significant change
2023-02-25 22:52:50 +03:00
Alexey Milovidov
1a604f834c
Merge pull request #46857 from azat/tests/final-expect-fixes
Final fixes for expect tests
2023-02-25 22:49:08 +03:00
Alexey Milovidov
d09025fc40
Merge pull request #46868 from DanRoscigno/add-prod-note
add note about prod install
2023-02-25 22:47:00 +03:00
SmitaRKulkarni
4109fbd7cf
Merge pull request #46517 from azat/tests/fix-backup-restore-flakiness
Fix flakiness of test_backup_restore_on_cluster/test_disallow_concurrency
2023-02-25 19:54:21 +01:00
Robert Schulze
cf062f0c5b
Small optimization of LIKE patterns with > 1 trailing %
Previously, LIKE pattern '%%%ab' became '.*.*ab'. Now, it becomes 'ab'
which is a bit faster (perhaps).

+ minor code cleanup + a minor doc update
2023-02-25 18:50:32 +00:00
Robert Schulze
2fd28b9eac
Merge pull request #46867 from ClickHouse/rs/escaping-docs
Fix escaping description in LIKE function docs
2023-02-25 18:44:20 +01:00
Rich Raposa
9e6c6e86e2
Merge pull request #46866 from ClickHouse/rfraposa-patch-2
Update tuple-map-functions.md
2023-02-25 10:33:48 -07:00
DanRoscigno
138a050e13 fix section name 2023-02-25 12:22:02 -05:00