thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-18 20:32:43 +00:00
Code Issues Packages Projects Releases Wiki Activity
72,187 Commits 9,336 Branches 1,783 Tags 2.2 GiB
39d73c01b2
Commit Graph

72187 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
alesapin
a949329830 Review fixes 2021-09-02 23:37:34 +03:00
alesapin
3a3c3acd18
Update src/Coordination/SessionExpiryQueue.h 
Co-authored-by: tavplubix <avtokmakov@yandex-team.ru>
 2021-09-02 23:19:44 +03:00
Azat Khuzhin
6d5f01a56b Cover MySQL setting connection_wait_timeout 2021-09-02 22:39:07 +03:00
Azat Khuzhin
ed70ed6f71 Introduce connection_no_wait setting for MySQL engine. 
This will allow to avoid superfluous sleep during query execution, since
this not only not desired behavoiur, but also may hang the server, since
if you will execute enough queries that will use MySQL database but will
not allow enough connections (or your MySQL server is too slow) then you
may run out of threads in the global thread pool.

Also note that right now it is possible to get deadlock when the mysql
pool is full, consider the following scenario:

- you have m1 and m2 mysql tables
- you have q1 and q2 queries, bot queries join m1 and m2
- q1 allocated connection for m1 but cannot allocate connection for m2
- q2 allocated connection for m2 but cannot allocate connection for m1
- but to resolve the lock one should give up on the locking while it is not possible right now...

And then you got no free threads and this:

    # grep -h ^202 /proc/$(pgrep clickhouse-serv)/task/*/syscall  | cut -d' ' -f2 | sort | uniq -c | sort -nr | head
       1554 0x7ffb60b92fe8 # mutex in mysqlxx::PoolWithFailover::get
       1375 0x7ffb9f1c4748 # mutex in ::PoolEntryHelper::~PoolEntryHelper from DB::MultiplexedConnections::invalidateReplica
       1160 0x7ffb612918b8 # mutex in mysqlxx::PoolWithFailover::get
         42 0x7ffb9f057984 # mutex in ThreadPoolImpl<std::__1::thread>::worker

    *NOTE: 202 is a `futex` with WAIT*

(Went with `syscall` because debugging 10k+ threads is not easy, and
eventually it may TRAP)
 2021-09-02 22:23:37 +03:00
Nikita Mikhaylov
6624fa12ba deleted set 2021-09-02 18:49:37 +00:00
Alexey
7667a20936 Russian fixes 2021-09-02 18:44:37 +00:00
Anton Popov
db77349957 add unit test for NestedUtils 2021-09-02 20:43:42 +03:00
Nikita Mikhaylov
a6fe91ca47 get rid of half of allocations 2021-09-02 17:40:29 +00:00
Anton Popov
ee7f50396b fix nested and scalar columns with dot 2021-09-02 20:22:01 +03:00
alesapin
9bad77f806 Fix clang tidy 2021-09-02 19:16:29 +03:00
Maksim Kita
8fbef6c69d Function dictGet default implementation for nulls 2021-09-02 18:30:55 +03:00
Maksim Kita
027c531243
Merge pull request #28503 from kitaisreal/executable-multiple-pipes-added-test 
Executable multiple pipes added test
 2021-09-02 18:30:03 +03:00
alesapin
464b8167d1 Update comment 2021-09-02 18:29:26 +03:00
robot-clickhouse
2ecfc06fbc Update version_date.tsv after release 21.8.5.7 2021-09-02 18:18:36 +03:00
alesapin
ba78a737dc Fix detach/attach for ReplicatedVersionedCollapsingMergeTree after alter 2021-09-02 17:47:00 +03:00
robot-clickhouse
c832a41dff Update version_date.tsv after release 21.7.9.7 2021-09-02 17:37:47 +03:00
Nikolai Kochetov
af0da33147
Merge pull request #27827 from ClickHouse/more-checks-for-lv-and-native 
Add more checks for LC in native protocol.
 2021-09-02 17:27:42 +03:00
alesapin
f1bc3d7720 Add test for keeper 2 node configuration 2021-09-02 16:54:30 +03:00
Maksim Kita
f9ca726bf7 PageArena updated implementation 2021-09-02 16:31:50 +03:00
alexey-milovidov
ab3e005e6a
Merge pull request #28411 from kssenii/fix-web-disk 
Fix disk with static files a little
 2021-09-02 16:23:35 +03:00
Alexey Milovidov
03ae73a91a Drop arcadia_skip_list.txt 2021-09-02 16:19:36 +03:00
Maksim Kita
958174192b
Merge pull request #28523 from kitaisreal/borrowed-object-pool-fix-style 
BorrowedObjectPool fix style
 2021-09-02 16:18:48 +03:00
Maksim Kita
e5ee3752ef BorrowedObjectPool fix style 2021-09-02 16:18:10 +03:00
alesapin
bc818dea4b Merge branch 'master' into debug_keeper_lost_logs 2021-09-02 15:07:08 +03:00
alesapin
010985ce87 Add comment 2021-09-02 14:54:32 +03:00
Maksim Kita
abda2a636e Added ExecutablePool storage 2021-09-02 14:53:20 +03:00
alesapin
c5470864e8 Fixup 2021-09-02 14:43:34 +03:00
alesapin
4c613f30b3 Simplier sessions expiration in Keeper 2021-09-02 14:40:54 +03:00
Maksim Kita
83c70a8a65
Merge pull request #28516 from kitaisreal/user-defined-function-factory-added-comments 
UserDefinedFunctionFactory added comments
 2021-09-02 14:37:25 +03:00
Maksim Kita
0a12592b50 UserDefinedFunctionFactory added comments 2021-09-02 14:37:06 +03:00
Amos Bird
163a416366
Refactor 2021-09-02 19:29:14 +08:00
alesapin
b592400e54
Merge pull request #28404 from ClickHouse/remove_outdated_settings 
Remove obsolete settings for replicated fetches.
 2021-09-02 14:03:12 +03:00
alesapin
9b1b3ec916 Fix style check 2021-09-02 14:02:37 +03:00
Nikita Mikhaylov
7f21cd7f3d save 2021-09-02 10:39:27 +00:00
Nikolai Kochetov
5f0b1bc4e3
Merge pull request #26286 from amosbird/projection-improve2 
Virtual projection for min max indices.
 2021-09-02 13:03:30 +03:00
alesapin
78a0cefafd
Merge pull request #28437 from ClickHouse/remove_some_tests 
Remove some rename tests
 2021-09-02 12:26:28 +03:00
alesapin
d681ffabf8 Comment 2021-09-02 12:22:51 +03:00
alesapin
a8003e444b Review fixes 2021-09-02 12:20:46 +03:00
Maksim Kita
3286b32499 Executable multiple pipes added test 2021-09-02 10:47:21 +03:00
Maksim Kita
befb82e441
Merge pull request #28433 from kssenii/fix-materialized-postgresql 
Fix cannot use non-ordinary table names in materialized postgresql
 2021-09-02 09:49:33 +03:00
Maksim Kita
be4c9102d8
Merge pull request #28438 from azat/udf-race-fix-v2 
Fix race in UDF (follow up)
 2021-09-01 23:57:05 +03:00
tavplubix
b5b9fd8663
Merge pull request #28446 from ClickHouse/ddlworker_fix_watch_leak 
Fix watch leak in DDLWorker
 2021-09-01 22:44:39 +03:00
Alexey
d9aee1bf7b Merge branch 'alexey-sm-DOCSUP-13375-document-CREATE-DROP-FUNCTION' of https://github.com/lehasm/ClickHouse into alexey-sm-DOCSUP-13375-document-CREATE-DROP-FUNCTION 2021-09-01 18:37:42 +00:00
Alexey
610257dcd2 Translated to Russian 2021-09-01 18:36:47 +00:00
Alexey
299fc2604a Example fixed 2021-09-01 18:36:35 +00:00
Nikolay Degterinsky
53b6d918eb
Merge pull request #25310 from bharatnc/ncb/import-export-lz4 
LZ4 compression for import/export
 2021-09-01 21:12:50 +03:00
romanzhukov
f0414ed7f9 Fix err arg. 2021-09-01 21:05:22 +03:00
alexey-milovidov
ff0b332c24
Update custom-partitioning-key.md 2021-09-01 20:53:06 +03:00
alexey-milovidov
4699386470
Update mergetree.md 2021-09-01 20:52:05 +03:00
Roman Zhukov
81a3ee6584 Fix PR comments. 2021-09-01 14:41:05 +00:00