Commit Graph

23 Commits

Author SHA1 Message Date
Azat Khuzhin
498c8b3c52 Fix clang-tidy in utils/examples
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-29 11:36:51 +03:00
Robert Schulze
1a7727a254
Prefix overridden add_executable() command with "clickhouse_"
A simple HelloWorld program with zero includes except iostream triggers
a build of ca. 2000 source files. The reason is that ClickHouse's
top-level CMakeLists.txt overrides "add_executable()" to link all
binaries against "clickhouse_new_delete". This links against
"clickhouse_common_io", which in turn has lots of 3rd party library
dependencies ... Without linking "clickhouse_new_delete", the number of
compiled files for "HelloWorld" goes down to ca. 70.

As an example, the self-extracting-executable needs none of its current
dependencies but other programs may also benefit.

In order to restore access to the original "add_executable()", the
overriding version is now prefixed. There is precedence for a
"clickhouse_" prefix (as opposed to "ch_"), for example
"clickhouse_split_debug_symbols". In general prefixing makes sense also
because overriding CMake commands relies on undocumented behavior and is
considered not-so-great practice (*).

(*) https://crascit.com/2018/09/14/do-not-redefine-cmake-commands/
2022-07-11 19:36:18 +02:00
Memo
956d525840 fix conflict 2022-04-22 11:22:50 +08:00
Memo
39aadf0975 replaced toStartOfFiveMinute to toStartOfFiveMinutes 2022-04-22 10:49:59 +08:00
Robert Schulze
118e94523c
Activate clang-tidy warning "readability-container-contains"
This check suggests replacing <Container>.count() by
<Container>.contains() which is more speaking and in case of
multimaps/multisets also faster.
2022-04-18 23:53:11 +02:00
Alexey Milovidov
d9e5ca2119
Merge pull request #34394 from holadepo/last_day
Add toLastDayOfMonth function
2022-04-04 07:02:08 +03:00
Maksim Kita
1f5837359e clang-tidy check performance-noexcept-move-constructor fix 2022-03-02 18:15:27 +00:00
Habibullah Oladepo
57ff05b6e6 Add new function toLastDayOfMonth 2022-02-08 23:48:44 +01:00
Alexey Milovidov
447d7bb8cd Minor changes 2021-06-14 07:13:35 +03:00
Yatsishin Ilya
f07df76c59 fix ans 2020-12-29 17:57:12 +03:00
Nikolai Kochetov
d96ca3fb8d Fixing build. 2020-12-16 20:11:32 +03:00
damozhaeva
fedefc43ff
DOCSUP-3417 translate to english (#16797)
* English translation

* Update utils/db-generator/README.md

Co-authored-by: BayoNet <da-daos@yandex.ru>

* Update utils/db-generator/README.md

Co-authored-by: BayoNet <da-daos@yandex.ru>

* Update utils/db-generator/README.md

Co-authored-by: BayoNet <da-daos@yandex.ru>

* Update utils/db-generator/README.md

Co-authored-by: BayoNet <da-daos@yandex.ru>

* Update utils/db-generator/README.md

Co-authored-by: BayoNet <da-daos@yandex.ru>

* Update utils/db-generator/README.md

Co-authored-by: BayoNet <da-daos@yandex.ru>

* Update utils/db-generator/README.md

* Update utils/db-generator/README.md

Co-authored-by: Daria Mozhaeva <dmozhaeva@yandex-team.ru>
Co-authored-by: BayoNet <da-daos@yandex.ru>
2020-11-13 13:12:06 +03:00
alexey-milovidov
2a1911d08f
Merge pull request #16859 from su-houzhen/fix_build_error
Fix build err
2020-11-12 13:45:38 +03:00
su-houzhen
e31753b4db Fix build err 2020-11-11 17:12:22 +08:00
Alexander Tokmakov
62ff00ee8b use WriteBuffer in formatAST(...) 2020-11-09 19:05:40 +03:00
Mikhail Filimonov
41971e073a
Fix typos reported by codespell 2020-10-27 12:04:03 +01:00
Ivan
1d170f5745
ASTTableIdentifier Part #1: improve internal representation of ASTIdentifier name (#16149)
* Use only |name_parts| as primary name source

* Restore legacy logic for table restoration

* Fix build

* Fix tests

* Add pytest server config

* Fix tests

* Fixes due to review
2020-10-24 21:46:10 +03:00
nikitamikhaylov
0cfb8b94cd better 2020-10-14 16:11:53 +03:00
nikitamikhaylov
c1fa34a9af done 2020-10-14 16:03:13 +03:00
hexiaoting
6ad48ade83 fix bug for building query_db_generator.cpp 2020-09-27 16:42:04 +08:00
Alexey Milovidov
ef5363b87f Fix terribly wrong code 2020-09-19 02:05:13 +03:00
nikitamikhaylov
724b78a578 better 2020-09-08 15:03:55 +03:00
Nikita Mikhaylov
ab48947305
Datasets generation (Merging #10973) (#14442)
* created program in utils

* reset test

* removed additional printings

* refactoring

* fix float generator, fix build

* add readme

* refactor readme

* fixed random int func

* clang format

* fix build

* fix build

* fix PVS, uncrustify

* newline at end of file

* refactor string_type func

* restyle func maps

* support IN operation

* support multiquery

* fix style

* change rand to pcg64

* fix array generation

* fix build

* better

* subqueries

* style

* better

* delete samples.sql

Co-authored-by: Roman Ilgovskiy <ilgovskiy@yandex-team.ru>
2020-09-04 13:39:17 +03:00