Commit Graph

104056 Commits

Author SHA1 Message Date
Anton Popov
1f7a4a94ff fix test 02015_async_inserts_2 2022-12-27 17:01:30 +00:00
Azat Khuzhin
e1ad5cee7e tests/integration: add missing kazoo client termination
pytest play games with logging output [1].

  [1]: https://github.com/pytest-dev/pytest/issues/5502

But this does not actually affect ClickHouse tests, the only reason is
that the kazoo client is not stopped correctly without calling
kazoo.client.KazooClient.stop(), and that's why you can see the
following messages:

<details>

    test_storage_rabbitmq/test.py::test_rabbitmq_big_message --- Logging error ---
    Traceback (most recent call last):
      File "/usr/local/lib/python3.8/dist-packages/kazoo/protocol/connection.py", line 179, in _socket_error_handling
        yield
      File "/usr/local/lib/python3.8/dist-packages/kazoo/protocol/connection.py", line 659, in _connect
        self._socket = self.handler.create_connection(
      File "/usr/local/lib/python3.8/dist-packages/kazoo/handlers/threading.py", line 178, in create_connection
        return utils.create_tcp_connection(socket, *args, **kwargs)
      File "/usr/local/lib/python3.8/dist-packages/kazoo/handlers/utils.py", line 265, in create_tcp_connection
        sock = module.create_connection(address, timeout_at)
      File "/usr/lib/python3.8/socket.py", line 808, in create_connection
        raise err
      File "/usr/lib/python3.8/socket.py", line 796, in create_connection
        sock.connect(sa)
    socket.timeout: timed out

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
      File "/usr/local/lib/python3.8/dist-packages/kazoo/protocol/connection.py", line 579, in _connect_attempt
        read_timeout, connect_timeout = self._connect(host, hostip, port)
      File "/usr/local/lib/python3.8/dist-packages/kazoo/protocol/connection.py", line 659, in _connect
        self._socket = self.handler.create_connection(
      File "/usr/lib/python3.8/contextlib.py", line 131, in __exit__
        self.gen.throw(type, value, traceback)
      File "/usr/local/lib/python3.8/dist-packages/kazoo/protocol/connection.py", line 182, in _socket_error_handling
        raise ConnectionDropped("socket connection error: %s" % (err,))
    kazoo.exceptions.ConnectionDropped: socket connection error: None

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
      File "/usr/lib/python3.8/logging/__init__.py", line 1088, in emit
        stream.write(msg + self.terminator)
    ValueError: I/O operation on closed file.
    Call stack:
      File "/usr/lib/python3.8/threading.py", line 890, in _bootstrap
        self._bootstrap_inner()
      File "/usr/lib/python3.8/threading.py", line 932, in _bootstrap_inner
        self.run()
      File "/usr/lib/python3.8/threading.py", line 870, in run
        self._target(*self._args, **self._kwargs)
      File "/usr/local/lib/python3.8/dist-packages/kazoo/protocol/connection.py", line 512, in zk_loop
        if retry(self._connect_loop, retry) is STOP_CONNECTING:
      File "/usr/local/lib/python3.8/dist-packages/kazoo/retry.py", line 126, in __call__
        return func(*args, **kwargs)
      File "/usr/local/lib/python3.8/dist-packages/kazoo/protocol/connection.py", line 552, in _connect_loop
        status = self._connect_attempt(host, hostip, port, retry)
      File "/usr/local/lib/python3.8/dist-packages/kazoo/protocol/connection.py", line 622, in _connect_attempt
        self.logger.warning('Connection dropped: %s', e)
    Message: 'Connection dropped: %s'
    Arguments: (ConnectionDropped('socket connection error: None'),)

</details>

Which eventually leads to incorrectly parsed report.

This patch is an addition to the `logging.raiseExceptions=False` - #44618

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-27 17:01:06 +01:00
Kruglov Pavel
ac162a2c49
Merge pull request #44522 from Avogar/zero-numbers
Infer numbers starting from zero as strings in TSV
2022-12-27 17:00:10 +01:00
Kruglov Pavel
f95eabc192
Merge pull request #44469 from Avogar/low-card-if
Don't execute and/or/if/multiIf on LowCardinality dictionary
2022-12-27 16:59:42 +01:00
Kruglov Pavel
6dea7336f7
Merge pull request #44405 from Avogar/fix-parquet-orc
Fix reading columns that are not presented in input data in Parquet/ORC formats
2022-12-27 16:58:35 +01:00
Kruglov Pavel
e981b2e78b
Merge pull request #43813 from Avogar/fix-sum-if
Better handling of NULL in aggregate combinators, fix possible segfault/logical error
2022-12-27 16:50:48 +01:00
alesapin
3a7f26ff3a Split test into two 2022-12-27 16:15:23 +01:00
Azat Khuzhin
c9c590071d Add ability to disable deduplication for BACKUP
Right now BACKUP omit similar files, and will not allow to use this
backup as a regular table, and usually those similar files are quite
small (i.e. columns.txt).

So by using `BACKUP TO S3() deduplicate_files=0` you will be possible to
use `ATTACH TABLE` directly from S3.

P.S. right now it is possible only for the table with one part, since,
usually, there is nothing to deduplicate (if the columns are different).

v2: Add deduplicate_files into metadata
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-27 15:56:06 +01:00
Azat Khuzhin
7d81c39207 backups: ignore file not found error for S3 (similar to Disk)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-27 15:56:05 +01:00
Azat Khuzhin
998bf444e6 backups: remove IBackupCoordination::getFileSizeAndChecksum() (in favor of getFileInfo())
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-27 15:56:05 +01:00
Alexey Milovidov
c27f90c8ed
Update src/Parsers/ParserDataType.cpp
Co-authored-by: Nikolay Degterinsky <43110995+evillique@users.noreply.github.com>
2022-12-27 17:16:31 +03:00
Alexey Milovidov
4ce9732502
Update AggregateFunctionSumMap.h 2022-12-27 17:15:48 +03:00
Alexey Milovidov
611bb44288
Merge branch 'master' into fix-30975 2022-12-27 17:15:12 +03:00
Alexey Milovidov
c26ce8a629
Merge pull request #44338 from ClickHouse/mysql-compat-test
Add a test for PowerBI
2022-12-27 17:12:51 +03:00
Alexey Milovidov
ed3d70f7c0
Merge pull request #44623 from azat/build/rust-fix
Fix rust modules rebuild (previously ignores changes in cargo config.toml)
2022-12-27 17:10:33 +03:00
Sergei Trifonov
56b3c6c68f
Merge pull request #44308 from ZhiguoZh/20221216-threadpool-notify
Call std::condition_variable::notify_* without lock in ThreadPool
2022-12-27 15:02:49 +01:00
Mikhail f. Shiryaev
93af1f3f7c
Restart failing workflows up to 30 times 2022-12-27 14:50:37 +01:00
Raúl Marín
948ce8db93 Revert "Merge pull request #38953 from ClickHouse/add-allocation-ptr-to-trace-log"
This reverts commit e99849d031, reversing
changes made to 7ad3ff8a9e.
2022-12-27 14:28:13 +01:00
Azat Khuzhin
e719fd218d Add excludes for std::cout usage in LineReader
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-27 14:23:51 +01:00
Azat Khuzhin
1f9a6076b9 Use DB::ReadBufferFromFile over std::ifstream in ReplxxLineReader
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-27 14:23:51 +01:00
Azat Khuzhin
b7f92454bf Move LineReader/ReplxxLineReader out from base
This will simplify linking dependencies, and anyway this classes are not
base in any sense.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-27 14:23:51 +01:00
Azat Khuzhin
83cad3625b Remove unused setTerminalEcho()
It had been replaced with readpassphrase in #5092

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-27 14:23:51 +01:00
Mikhail f. Shiryaev
d6ebb5fca8
Merge pull request #44399 from ClickHouse/checkout-action
Implement a custom central checkout action
2022-12-27 14:15:22 +01:00
Alexey Milovidov
4e8aec11bc Whitespace 2022-12-27 14:11:28 +01:00
Alexey Milovidov
514ff2ba20
Merge pull request #44570 from ClickHouse/clickhouse-benchmark-better-arguments
Better command line argument name in `clickhouse-benchmark`
2022-12-27 16:10:21 +03:00
Alexey Milovidov
e1115828d0
Merge pull request #44593 from ClickHouse/better-diagnostic-in-stress-test
Better diagnostics on server stop for the stress test
2022-12-27 16:07:43 +03:00
Alexey Milovidov
735fe5b189
Merge pull request #44282 from nickitat/set_mem_limit_for_fuzz_tests
Set memory limit for server in AST fuzz tests
2022-12-27 16:05:26 +03:00
Alexey Milovidov
1c8fa6eb26
Merge pull request #44595 from ClickHouse/wrong-place-of-log-message
The position of the log message about the server environment was wrong
2022-12-27 16:00:37 +03:00
alesapin
560223ac19 Merge branch 'fix-restart-after-quorum-insert' of github.com:CurtizJ/ClickHouse into CurtizJ-fix-restart-after-quorum-insert 2022-12-27 13:48:55 +01:00
Alexey Milovidov
1cb7d4e46e
Merge pull request #44598 from ClickHouse/fix-wrong-log-message
Fix misleading log message
2022-12-27 15:47:27 +03:00
Alexey Milovidov
42415d49ac
Merge pull request #44607 from ClickHouse/fix-log-messages-coordination
Fix log messages in Coordination
2022-12-27 15:46:14 +03:00
Alexey Milovidov
d68c5c24ca
Merge pull request #44610 from ClickHouse/better-log-meesage
Better log message
2022-12-27 15:45:38 +03:00
Alexey Milovidov
c612e2ff60
Merge pull request #44580 from ClickHouse/fix-fuzzer-html
Fuzzer HTML: fix trash
2022-12-27 15:36:03 +03:00
Alexey Milovidov
44de7195d1
Merge branch 'master' into fix-fuzzer-html 2022-12-27 15:35:54 +03:00
Alexey Milovidov
bfe895975e
Merge pull request #44575 from ClickHouse/minimal-changes
Non-significant changes
2022-12-27 15:34:27 +03:00
Alexey Milovidov
464a513f0e
Merge pull request #44615 from ClickHouse/projection-grouping-sets
Disable projections in presense of any grouping sets, including WITH ROLLUP, WITH CUBE and WITH TOTALS
2022-12-27 15:31:03 +03:00
Alexey Milovidov
9645941cdf
Merge pull request #44616 from ClickHouse/sanitizer-out-of-memory
Do not fail the AST fuzzer if sanitizer is out of memory
2022-12-27 15:15:26 +03:00
Alexey Milovidov
43376af340
Merge branch 'master' into alexey-milovidov-patch-5 2022-12-27 15:14:37 +03:00
Alexey Milovidov
05c27f4e15
Merge pull request #44603 from ClickHouse/runlog
Rename `runlog.log` to `run.log` in tests
2022-12-27 15:14:05 +03:00
Alexey Milovidov
2c5485b86e
Merge pull request #44617 from ClickHouse/fix-create_drop_replicated_db_stress
Fix test `01111_create_drop_replicated_db_stress`
2022-12-27 15:12:54 +03:00
Alexey Milovidov
c37fc45d07
Merge pull request #44611 from ClickHouse/maybe-fix-bogus-msan-error
Maybe fix a bogus MSan error
2022-12-27 15:08:42 +03:00
Alexey Milovidov
cb0a91d865
Sometimes spot instances fail more than 20 times in a row 2022-12-27 15:05:11 +03:00
Alexey Milovidov
2e315b55f2
Merge pull request #44600 from azat/fuzzy-search-prefix
Use already written part of the query for fuzzy search (pass to skim)
2022-12-27 15:03:30 +03:00
alesapin
338c554525 Push 2022-12-27 13:00:14 +01:00
alesapin
e4e6cccbf8 Remove garbage 2022-12-27 12:59:09 +01:00
Alexey Milovidov
4e53ddb2e1
Merge pull request #44340 from ClickHouse/add-test-29386
Add a test for #29386
2022-12-27 14:58:59 +03:00
Alexey Milovidov
55131f7ae8
Merge pull request #44341 from ClickHouse/add-test-22929
Add a test for #22929
2022-12-27 14:58:28 +03:00
Alexey Milovidov
1b21cc018e
Merge pull request #44342 from ClickHouse/add-test-29883
Add a test for #29883
2022-12-27 14:55:14 +03:00
Alexey Milovidov
31348a0c2b
Merge pull request #44355 from ClickHouse/add-test-22160
Add a test for #22160
2022-12-27 14:53:46 +03:00
Alexey Milovidov
21d9e7ebc3
Merge pull request #44360 from ClickHouse/add-test-34724
Add a test for #34724
2022-12-27 14:53:34 +03:00