Commit Graph

4085 Commits

Author SHA1 Message Date
Alexey Milovidov
de58339c3b Merge branch 'fix-perf-tests-jemalloc' of github.com:azat/ClickHouse into many-fixes 2023-06-27 05:35:26 +02:00
Alexey Milovidov
4ee74ec213 Two tests are twice longer in average with Analyzer and sometimes failing 2023-06-26 02:19:52 +02:00
Azat Khuzhin
5871ca0836 Fix performance tests due to warnings from jemalloc about Per-CPU arena disabled
jemalloc can show the following warning:

    Number of CPUs detected is not deterministic. Per-CPU arena disabled

It will be shown if one of the following returns different number of
CPUs:
- _SC_NPROCESSORS_ONLN
- _SC_NPROCESSORS_CONF
- sched_getaffinity()

And actually for my CPU linux returns different numbers, because there
are more possible CPUs then online, from dmesg:

    smpboot: Allowing 128 CPUs, 64 hotplug CPUs

And from sysfs:

    # grep . /sys/devices/system/cpu/{possible,online,offline}
    /sys/devices/system/cpu/possible:0-127
    /sys/devices/system/cpu/online:0-63
    /sys/devices/system/cpu/offline:64-127

From ACPI:

    # acpidump -o acpi
    # acpixtract -a acpi
    # iasl -d *.dat
    # grep -e 'Processor Enabled' apic.dsl | sort | uniq -c
        64                            Processor Enabled : 0
        64                            Processor Enabled : 1

So I guess this is the same as what happened in this perf run [1].

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/51360/5d43a64112711b339b82b1c0e8df7882546a1a3c/performance_comparison_[4_4]/report.html

P.S. personally I, just use cmdline=possible_cpus=64 to fix this for my
setup.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-06-25 09:37:37 +02:00
Alexander Tokmakov
f973bd7516 suppress check for covered parts in zk 2023-06-20 23:53:32 +02:00
Alexander Tokmakov
bca0d76cbf
Merge pull request #50107 from ClickHouse/rmt_better_background_tasks_scheduling
Improve scheduling of background tasks in ReplicatedMergeTree
2023-06-20 16:25:19 +03:00
Alexander Tokmakov
5dd9b10c8e fix 2023-06-19 20:14:28 +02:00
Yatsishin Ilya
b472480d48 Fix branch name 2023-06-19 10:06:56 +00:00
robot-clickhouse
fbcec61aec Update version_date.tsv and changelogs after v22.8.19.10-lts 2023-06-17 14:01:58 +00:00
Mikhail f. Shiryaev
5d4a3ac0c6
Do not spam sqlancer build log 2023-06-16 00:44:42 +02:00
Mikhail f. Shiryaev
60ab05e86f
Sqlancer has changed master to main 2023-06-16 00:28:09 +02:00
Denny Crane
c142ed8a06
Merge branch 'master' into patch-51 2023-06-14 17:39:00 -03:00
Alexander Tokmakov
ffde5affeb
Merge pull request #50929 from ClickHouse/fix_illegal_column_timezone
Fix 'Illegal column timezone' in stress tests
2023-06-14 17:56:57 +03:00
Denny Crane
404a52432c
Update README.md 2023-06-13 19:39:23 -03:00
Denny Crane
d8d5700810
Update README.md 2023-06-13 19:24:36 -03:00
Denny Crane
a570b00bdf
Update README.md 2023-06-13 19:19:34 -03:00
Mikhail f. Shiryaev
0bc624dc02
Fix the statless tests image for old commits 2023-06-13 17:53:19 +02:00
Alexander Tokmakov
5368fa72ca
Merge pull request #50487 from Avogar/add-gdb-to-stateless-tests
Attach gdb in stateless tests
2023-06-13 17:04:17 +03:00
Alexander Tokmakov
3a2fa65075 fix 'Illegal column timezone' in stress tests 2023-06-13 16:02:54 +02:00
Mikhail f. Shiryaev
a7408170c8
Use H3 2023-06-12 11:21:43 +02:00
Robert Schulze
6b2c33b1e4
Document x86 / ARM prerequisites for Docker image 2023-06-12 09:16:22 +00:00
robot-clickhouse
296b11a1ae Update version_date.tsv and changelogs after v23.5.2.7-stable 2023-06-10 20:56:54 +00:00
alesapin
a614aa3b03 More leftovers 2023-06-10 16:06:37 +02:00
alesapin
20b66689f3 Fix test 2023-06-10 13:34:51 +02:00
robot-clickhouse
61a20468f7 Update version_date.tsv and changelogs after v23.5.1.3174-stable 2023-06-09 11:53:29 +00:00
Kruglov Pavel
5b3cece42e
Fix shellcheck 2023-06-06 12:23:00 +02:00
Sema Checherinda
990652119e
Merge pull request #50361 from nickitat/fail_perf_on_too_many_slow
Fail perf tests when too many queries slowed down
2023-06-06 11:33:04 +02:00
avogar
e8c6c7967b Move attaching gdb to separate lib 2023-06-05 18:21:40 +00:00
Alexey Milovidov
5d26b0cf7c
Merge pull request #50550 from cmsxbc/misc-darwin-build
skip extracting darwin toolchain in builder when unncessary
2023-06-05 11:11:34 +03:00
Alexey Milovidov
47379ac039
Update build.sh 2023-06-05 03:58:42 +03:00
Azat Khuzhin
bf127f4e1e MSan support for Rust
Previously you have to unpoison memory from the Rust, however Rust does
supports MSan, so let's simply use it.

But for this we need nightly Rust and recompile standard library.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-06-04 23:04:55 +02:00
cmsxbc
4bb44c7c72
1. skip extract darwin toolchain in builder when uncessary
2. update MacOSX SDK version in toolchain readme to match in builder
2023-06-04 23:06:21 +08:00
Nikita Taranov
4506299d73 impl 2023-06-02 23:14:09 +02:00
avogar
8973259678 Test attach gdb in stateless tests 2023-06-02 15:00:24 +00:00
Alexander Tokmakov
1544067fb3
Update run.sh 2023-06-01 23:28:19 +03:00
何李夫
e4c8c4cecf
Add zookeeper name in endpoint id (#49780)
* Add zookeeper name in endpoint id

When we migrate a replicated table from one zookeeper cluster to
another (the reason why we migration is that zookeeper's load is
too high), we will create a new table with the same zpath, but it
will fail and the old table will be in trouble.

Here is some infomation:
1.old table:
  CREATE TABLE a1 (`id` UInt64)
  ENGINE = ReplicatedMergeTree('/clickhouse/tables/default/a1/{shard}', '{replica}')
  ORDER BY (id);
2.new table:
  CREATE TABLE a2 (`id` UInt64)
  ENGINE = ReplicatedMergeTree('aux1:/clickhouse/tables/default/a1/{shard}', '{replica}')
  ORDER BY (id);
3.error info:
  <Error> executeQuery: Code: 220. DB::Exception: Duplicate interserver IO endpoint:
          DataPartsExchange:/clickhouse/tables/default/a1/01/replicas/02.
          (DUPLICATE_INTERSERVER_IO_ENDPOINT)
  <Error> InterserverIOHTTPHandler: Code: 221. DB::Exception: No interserver IO endpoint
          named DataPartsExchange:/clickhouse/tables/default/a1/01/replicas/02.
          (NO_SUCH_INTERSERVER_IO_ENDPOINT)

* Revert "Add zookeeper name in endpoint id"

This reverts commit 9deb75b249619b7abdd38e3949ca8b3a76c9df8e.

* Add zookeeper name in endpoint id

When we migrate a replicated table from one zookeeper cluster to
another (the reason why we migration is that zookeeper's load is
too high), we will create a new table with the same zpath, but it
will fail and the old table will be in trouble.

* Fix incompatible with a new setting

* add a test, fix other issues

* Update 02442_auxiliary_zookeeper_endpoint_id.sql

* Update 02735_system_zookeeper_connection.reference

* Update 02735_system_zookeeper_connection.sql

* Update run.sh

* Remove the 'no-fasttest' tag

* Update 02442_auxiliary_zookeeper_endpoint_id.sql

---------

Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
Co-authored-by: Alexander Tokmakov <tavplubix@gmail.com>
2023-05-25 12:50:14 +03:00
Azat Khuzhin
73661c3a46 Move tunnings for woboq codebrowser to cmake out from build.sh
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-18 18:18:30 +02:00
Mikhail f. Shiryaev
e79c1cdb1a
Attempt to increas parallelism for codebrowser_generator 2023-05-12 19:22:51 +02:00
Mikhail f. Shiryaev
65d1ae77ee
Use updated upstream woboq 2023-05-12 19:22:49 +02:00
Mikhail f. Shiryaev
eb122487ad
Add logs to the report, do not chown unnecessary 2023-05-12 19:22:48 +02:00
Mikhail f. Shiryaev
ec701d96c7
Rework the codebrowser build directories structure 2023-05-12 19:22:47 +02:00
Mikhail f. Shiryaev
7614c1c848
Move the command for codebrowser into a script 2023-05-12 19:22:45 +02:00
Azat Khuzhin
a0cc5b7e47 Merge remote-tracking branch 'u/master' into build/llvm-16 2023-05-10 16:28:36 +02:00
Han Fei
d17aa828b3
Merge pull request #49361 from hanfei1991/hanfei/fiu
support named fault injection and add a simple test
2023-05-10 15:51:51 +02:00
Han Fei
505d9be7b2 address comments 2023-05-10 13:56:17 +02:00
Azat Khuzhin
be39e8e566 Merge remote-tracking branch 'u/master' into build/llvm-16
Conflicts:
	docker/test/codebrowser/Dockerfile
2023-05-09 20:40:43 +02:00
Mikhail f. Shiryaev
780b5a6f97
Fix a wrong built generator removal, use depth=1 2023-05-09 12:36:02 +02:00
Azat Khuzhin
bf17c819c3 docker: fix path to clang builtin headers for woboq code browser
By default woboq uses $version.$minor.$patch, while clang simply uses
$version:

    CMake Error at generator/CMakeLists.txt:77 (message):
      Could not find any clang builtins headers in
      /usr/lib/llvm-16/lib/clang/16.0.4/include

    # ls -d /usr/lib/llvm-16/lib/clang/16/include
    /usr/lib/llvm-16/lib/clang/16/include

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-09 10:31:55 +02:00
Azat Khuzhin
08b8b7e587 docker: remove symlink for libclang (not required anymore)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-09 10:30:02 +02:00
Azat Khuzhin
82536fedde docker: install libclang-16-dev for woboq code browser
Otherwise you will get the following error:

    CMake Error at /usr/lib/llvm-16/lib/cmake/clang/ClangTargets.cmake:792 (message):
      The imported target "clangBasic" references the file

         "/usr/lib/llvm-16/lib/libclangBasic.a"

      but this file does not exist.  Possible reasons include:

      * The file was deleted, renamed, or moved to another location.

      * An install or uninstall procedure did not complete successfully.

      * The installation package was faulty and contained

         "/usr/lib/llvm-16/lib/cmake/clang/ClangTargets.cmake"

      but not all the files it references.

    Call Stack (most recent call first):
      /usr/lib/llvm-16/lib/cmake/clang/ClangConfig.cmake:20 (include)
      generator/CMakeLists.txt:7 (Find_Package)

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-09 10:25:50 +02:00
Han Fei
64b67b9a37 Merge branch 'master' into hanfei/fiu 2023-05-09 01:14:30 +02:00