Commit Graph

31988 Commits

Author SHA1 Message Date
alesapin
1d9e126f94
Merge pull request #41856 from ClickHouse/fix_possible_no_such_key
Remove two redundant lines
2022-09-28 15:05:55 +02:00
Nikolai Kochetov
da375f27c5
Merge pull request #41740 from ClickHouse/fix-41269
Fix possible crash for SELECT from Merge table
2022-09-28 14:45:02 +02:00
Kseniia Sumarokova
6037da1ca8
Update CachedOnDiskReadBufferFromFile.cpp 2022-09-28 14:04:39 +02:00
Nikolai Kochetov
9564b8b3fa Add comment. 2022-09-28 11:30:09 +00:00
Alexey Milovidov
1dd5dc8c3e
Merge pull request #41858 from Avogar/json-object-schema
Infer Object type only when allow_experimental_object_type is enabled
2022-09-28 14:25:37 +03:00
Nikita Mikhaylov
bf4d675830
Fix backward incompatibility in Replicated database creation (#41875) 2022-09-28 13:22:19 +02:00
alesapin
2eef384807 Add comments and test 2022-09-28 13:09:48 +02:00
Alexey Milovidov
1653482406
Merge pull request #41823 from ClickHouse/trying_to_fix_compressed_marks
Fix compressed marks read for compact parts
2022-09-28 14:06:56 +03:00
alesapin
9e77d520d4 Merge branch 'master' into make_copy_instead_of_hardlink 2022-09-28 12:10:00 +02:00
Kseniia Sumarokova
b0a362e403
Merge pull request #41839 from ClickHouse/kssenii-patch-5
Remove unused variable in registerStorageMergeTree.cpp
2022-09-28 11:58:01 +02:00
Antonio Andelic
a9f73d344d
Merge pull request #41784 from ClickHouse/fix-drop-keeper-map-again
Possible fix for KeeperMap drop
2022-09-28 10:28:50 +02:00
Robert Schulze
0a4862f177
Fix style 2022-09-28 07:48:36 +00:00
Robert Schulze
de3264691c
Merge pull request #41790 from ClickHouse/print-git-hash
Log git hash during startup
2022-09-28 09:43:17 +02:00
Nikolay Degterinsky
1626aba16e Add default UNION/EXCEPT/INTERSECT to the echo query text 2022-09-28 00:59:50 +00:00
Alexey Milovidov
e5ffd74a56
Merge branch 'master' into trying_to_fix_compressed_marks 2022-09-28 02:30:10 +03:00
avogar
76be0d2ee1 Infer Object type only when allow_experimental_object_type is enabled 2022-09-27 23:07:36 +00:00
Alexey Milovidov
683b7e5e95
Merge branch 'master' into add_function_java_int_hash 2022-09-28 01:30:26 +03:00
Alexey Milovidov
be6689ef08
Merge pull request #41372 from HarryLeeIBM/hlee-s390x-siphash
Another fix for SipHash Endian issue on s390x
2022-09-28 01:05:05 +03:00
alesapin
57614b6869 Remove two redundant lines 2022-09-27 23:16:16 +02:00
Alexander Tokmakov
127fc9ce3c
Merge branch 'master' into fix_metadata_version_creation 2022-09-27 23:09:23 +03:00
Yakov Olkhovskiy
7c94f98f6a
Merge pull request #37961 from ClibMouse/Kusto-phase1
Kusto phase1
2022-09-27 12:42:15 -04:00
alesapin
a75ab3c74d
Merge pull request #41789 from ClickHouse/fix_drop_completely_dropped_table
Fix drop of completely dropped table
2022-09-27 18:24:40 +02:00
Kseniia Sumarokova
85b44c909a
Update MergeTreeDataPartCompact.cpp 2022-09-27 18:16:58 +02:00
Antonio Andelic
d0457addbd Support filtered list 2022-09-27 15:02:26 +00:00
Alexander Tokmakov
287fe40173 Merge branch 'master' into fix_intersecting_parts 2022-09-27 16:55:39 +02:00
Salvatore Mesoraca
fc73b74379 Improve feedback when replacing partition with different primary key 2022-09-27 16:31:47 +02:00
Antonio Andelic
728fe5d06f
Change log level 2022-09-27 16:00:44 +02:00
alesapin
a20a9242a1 Fix order of arguments 2022-09-27 15:50:25 +02:00
Kseniia Sumarokova
2f237a8a2c
Update registerStorageMergeTree.cpp 2022-09-27 15:30:18 +02:00
alesapin
695133cc5b Better mutations 2022-09-27 15:23:02 +02:00
Antonio Andelic
036d1c8cbc
Merge pull request #40991 from ClickHouse/start-embedded-keeper-async
Always start embedded Keeper in async mode
2022-09-27 14:44:19 +02:00
alesapin
d4d4f92976 Use copy for some operations instead of hardlinks 2022-09-27 14:38:13 +02:00
Antonio Andelic
265c8b3d26 Merge branch 'master' into keeper-multiread 2022-09-27 12:37:22 +00:00
Antonio Andelic
7a9afc4bdd Fix zookeeper_log 2022-09-27 12:36:59 +00:00
kssenii
ce422052b0 Fix CANNOT_READ_ALL_DATA for compact parts in case compressed_marks=1 2022-09-27 14:27:56 +02:00
Alexander Tokmakov
3d4a5a493b
Merge pull request #41484 from FrankChen021/on_cluster_dll
Add OpenTelemetry support to ON CLUSTER DDL
2022-09-27 15:15:52 +03:00
Robert Schulze
06493a0062
Fix style 2022-09-27 11:54:55 +00:00
Alexey Milovidov
69b13d9f31
Merge pull request #41797 from ClickHouse/revert-41247
Revert "ColumnVector: optimize UInt8 index with AVX512VBMI (#41247)"
2022-09-27 14:35:18 +03:00
Alexander Tokmakov
19062e9d97
Update src/Storages/MergeTree/ReplicatedMergeTreeAttachThread.cpp
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
2022-09-27 14:26:45 +03:00
Alexander Gololobov
1719e000ea
Merge pull request #41763 from zhangjmruc/fix/disable_mergetree_table_with_lwd_virtual_column
Disable merge tree table with lightweight delete virtual column name _row_exists
2022-09-27 12:20:19 +02:00
Robert Schulze
aa7e62ad5f
Add functio ntryBase58Decode()
- makes it consistent with tryBase64Decode(), follow-up to #39292

- additionally the following minor changes:

  - rename Common/base58.h|cpp to Common/Base58.h|cpp for constency with
    Common/Base64.h|cpp

  - check that (encode|decode|tryDecode)Base64() gets just one argument
2022-09-27 10:18:36 +00:00
Kseniia Sumarokova
caf6a99f41
Merge pull request #41011 from kssenii/fix-thread-status
Fix incorrect attach query in threadpool readers, get rid of static threadpools for reads/writes, make threadpool size for reads/writes configurable
2022-09-27 11:35:07 +02:00
Kseniia Sumarokova
e4f9d311c3
Merge pull request #41731 from kssenii/fix-azure-tests
Try fix azure tests
2022-09-27 11:01:19 +02:00
Robert Schulze
a5311fb976
Fix tests (hopefully), pt. II 2022-09-27 08:07:42 +00:00
Robert Schulze
588a5e5a42
Simplify a bit 2022-09-27 07:47:18 +00:00
Antonio Andelic
3206a20681
Merge branch 'master' into fix-drop-keeper-map-again 2022-09-27 08:57:48 +02:00
Alexander Gololobov
f21f933da7
Merge branch 'master' into fix/disable_mergetree_table_with_lwd_virtual_column 2022-09-26 23:44:45 +02:00
Nikolay Degterinsky
e0f8200ff6 Fix build 2022-09-26 21:20:43 +00:00
Alexey Milovidov
a3b28b441b
Merge pull request #34892 from evillique/new_parser
Implement operator precedence parser
2022-09-27 00:07:04 +03:00
Alexey Milovidov
5407291191 Revert "ColumnVector: optimize UInt8 index with AVX512VBMI (#41247)"
This reverts commit 8de524cb73.
2022-09-26 22:36:12 +02:00
Robert Schulze
3efd42ae2e
Fix tests (hopefully)
- LLVM migrates to opaque pointers
  (https://llvm.org/docs/OpaquePointers.html). In LLVM 13, opaque
  pointers are WIP and not recommended for use.

- But as preparation, they already changed some API, specifically
  they expect that IRBuilder::CreateConstGEP*() no longer get nullptr as
  first argument.

- We are now passing explicitly the value which was in LLVM 12 figured
  out automatically under the hood.

- Since the passed pointer is still non-opaque, I don't think this will
  work in LLVM 15 but it could be okay for a migration.
2022-09-26 19:43:28 +00:00
Alexander Tokmakov
0f6a44efef fix missing metadata_version for old tables 2022-09-26 20:11:30 +02:00
Alexander Tokmakov
922834ccde minor fixes 2022-09-26 19:31:08 +02:00
Alexander Tokmakov
9501f88f8c
Merge branch 'master' into fix_intersecting_parts 2022-09-26 19:53:59 +03:00
Alexander Tokmakov
49983dafeb fix 2022-09-26 17:13:10 +02:00
alesapin
31f6636a47 Fix endless remove 2022-09-26 16:33:25 +02:00
Antonio Andelic
5c8ce2f543 More correct 2022-09-26 14:30:29 +00:00
kssenii
921776625e Fix integration tests 2022-09-26 16:20:00 +02:00
Robert Schulze
ec35ff9cd6
Log git hash during startup
We currently only log a compiler-generated "build id" at startup which
is different for each build. That makes it useless to determine the
exact source code state in tests (e.g. BC test) and from user log files
(e.g. if someone compiled an intermediate version of ClickHouse).

Current log message:
  Starting ClickHouse 22.10.1.1 with revision 54467, build id: 6F35820328F89C9F36E91C447FF9E61CAF0EF019, PID 42633

New log message:
  Starting ClickHouse 22.10.1.1 (revision 54467, git hash: b6b1f7f763f94ffa12133679a6f80342dd1c3afe, build id: 47B12BE61151926FBBD230DE42F3B7A6652AC482), PID 981813
2022-09-26 14:12:36 +00:00
alesapin
e20d3803c4 Better fix 2022-09-26 15:40:25 +02:00
alesapin
2384761063 Fix drop of completely dropped table 2022-09-26 15:38:10 +02:00
Roman Vasin
36274baba9 Code cleanup 2022-09-26 15:36:32 +03:00
Sergei Trifonov
060402cab7
Merge pull request #41675 from ZhiguoZh/20220922-lock-opt
Optimize the lock contentions for ThreadGroupStatus::mutex
2022-09-26 14:33:47 +02:00
Roman Vasin
2a92c2aae9 Fix timeSlot() for DateTime64 argument 2022-09-26 15:26:07 +03:00
Antonio Andelic
287d1e68b1 Fix KeeperMap drop again 2022-09-26 12:23:41 +00:00
Alexey Milovidov
7bb245720a
Merge pull request #41752 from ClickHouse/revert-revert-revert
Revert of "Revert the revert of "ColumnVector: optimize filter with AVX512 VBMI2 compress store" #40033"
2022-09-26 15:16:02 +03:00
Alexander Tokmakov
fdc10a9b39
Merge pull request #41728 from ClickHouse/fix_part_removal_retries
Fix part removal retries
2022-09-26 15:02:28 +03:00
kssenii
a02354458a Review fixes 2022-09-26 12:27:29 +02:00
Antonio Andelic
97385ca861 Format 2022-09-26 09:33:50 +00:00
Antonio Andelic
56cc3c7137 Better TransactionLog with multiread 2022-09-26 09:31:27 +00:00
Antonio Andelic
cc3719e463 Use multiread 2022-09-26 09:07:34 +00:00
Antonio Andelic
937d534cd4 Add support for simple list 2022-09-26 08:05:02 +00:00
jianmei zhang
cf40c57562 Disable mergetree table with lightweight delete column name 2022-09-26 15:33:43 +08:00
Antonio Andelic
f833366555 Merge branch 'master' into keeper-multiread 2022-09-26 07:16:45 +00:00
Robert Schulze
9c62797d28
Bump LLVM from 12 to 13 2022-09-26 07:13:46 +00:00
Nikolay Degterinsky
bf48dd5a27 Fix SET query parameters formatting 2022-09-25 23:34:07 +00:00
Alexey Milovidov
e3a6f2381b Revert "Merge pull request #40033 from ClickHouse/reenable-avx512-vbmi-columnvector-filter"
This reverts commit 70f63d2aae, reversing
changes made to a0693c3a84.
2022-09-25 17:03:52 +02:00
Kseniia Sumarokova
c53f463d2d
Update S3ObjectStorage.cpp 2022-09-25 15:15:59 +02:00
Nikita Mikhaylov
e897816572
Evict stale DNS entries from cache in case of network errors (#41707) 2022-09-25 14:06:13 +02:00
Igor Nikonov
c721c6dc0c
Merge pull request #41014 from ClickHouse/distinct_in_order_wo_order_by
Reading in order for DISTINCT without ORDER BY
2022-09-24 18:49:52 +02:00
Kseniia Sumarokova
50f7ce6107
Merge branch 'master' into fix-thread-status 2022-09-24 17:22:45 +02:00
Kseniia Sumarokova
21e09f3e1f
Merge pull request #41733 from kssenii/cache-logging-level-reduce
Change logging levels in cache
2022-09-24 17:20:46 +02:00
alesapin
5852df7f65
Merge branch 'master' into fix_part_removal_retries 2022-09-24 17:06:32 +02:00
alesapin
ce2c2b5310 Merge branch 'master' into fix_intersecting_parts 2022-09-24 17:00:54 +02:00
alesapin
34d9794ab7
Merge pull request #41653 from ClickHouse/investigating_more_bugs
Add very explicit logging on disk choice for fetch
2022-09-24 16:15:02 +02:00
Kseniia Sumarokova
c41275b715
Merge branch 'master' into fix-azure-tests 2022-09-24 13:45:04 +02:00
Kseniia Sumarokova
307314e1bd
Update CachedOnDiskReadBufferFromFile.cpp 2022-09-24 13:42:58 +02:00
Frank Chen
a999212082 Update test cases to support both Replicated and non-Replicated database engine
Signed-off-by: Frank Chen <frank.chen021@outlook.com>
2022-09-24 11:34:42 +08:00
Alexander Tokmakov
a2b8c4926e fix intersecting parts 2022-09-23 20:51:44 +02:00
Nikolai Kochetov
1c67437aa4 Fix possible crash for SELECT from Merge table with optimize_monotonous_functions_in_order_by eanbled. 2022-09-23 18:37:25 +00:00
kssenii
0a801dad2a Merge remote-tracking branch 'upstream/master' into fix-thread-status 2022-09-23 19:39:07 +02:00
kssenii
30726721ad Fix threadpool reader (for local fs) 2022-09-23 19:35:16 +02:00
Igor Nikonov
f77660ed2a
Merge branch 'master' into distinct_in_order_wo_order_by 2022-09-23 18:39:20 +02:00
Anton Popov
41fc531ac6
Merge branch 'master' into fix-monotonic-order-by 2022-09-23 17:12:36 +02:00
Kseniia Sumarokova
b205824670
Merge branch 'master' into cache-config-allow-readable-format-settings 2022-09-23 15:40:07 +02:00
Kseniia Sumarokova
a0b064fc99
Merge pull request #41732 from ClickHouse/fix-test-build
Fix test build
2022-09-23 15:39:10 +02:00
Kseniia Sumarokova
81aa9b9199
Update WriteBufferFromAzureBlobStorage.cpp 2022-09-23 15:34:39 +02:00
Nikolay Degterinsky
9efa4bf766
Merge pull request #41587 from evillique/better-s3-logs
Better S3 logs
2022-09-23 15:32:27 +02:00
kssenii
c122e4dd1f Refactor log levels 2022-09-23 15:32:05 +02:00
Robert Schulze
2b2b058693
Fix build
Fallout of #41186
2022-09-23 13:26:15 +00:00
kssenii
3725397040 Try fix azure tests 2022-09-23 15:24:10 +02:00
kssenii
ab702e43fc Merge remote-tracking branch 'upstream/master' into fix-thread-status 2022-09-23 15:21:33 +02:00
Alexander Tokmakov
0eeb2de074
Merge pull request #41699 from ClickHouse/tavplubix-patch-5
Check if part mutation is cancelled
2022-09-23 15:46:28 +03:00
Nikita Mikhaylov
dbcba1490c
Try to make MergeTreeRestartingThread more reactive in case of expired sessions (#41092) 2022-09-23 14:40:04 +02:00
Alexander Tokmakov
2c16232b02 fix part removal retries 2022-09-23 14:39:05 +02:00
alesapin
148f018eae Fix style: 2022-09-23 14:32:19 +02:00
alesapin
dff61267b4 More explicit logs 2022-09-23 14:31:05 +02:00
Kseniia Sumarokova
ea43cb5648
Merge pull request #41261 from kssenii/s3-header-auth
Support s3 authorisation headers from ast arguments
2022-09-23 12:48:08 +02:00
Kseniia Sumarokova
a0c5da3459
Merge pull request #41652 from kssenii/fix-disk-web
Fixes for disk web
2022-09-23 12:43:50 +02:00
Igor Nikonov
5aa92e470a
Merge branch 'master' into distinct_in_order_wo_order_by 2022-09-23 11:34:54 +02:00
Frank Chen
34bcb6a82b Fix style
Signed-off-by: Frank Chen <frank.chen021@outlook.com>
2022-09-23 11:48:50 +08:00
Frank Chen
45e3d7d788 Update name/comments 2022-09-23 11:36:06 +08:00
Frank Chen
2344e0738e Keep compatibility during upgrading 2022-09-23 11:32:21 +08:00
Frank Chen
40f9e0b69a Address review comments
Signed-off-by: Frank Chen <frank.chen021@outlook.com>
2022-09-23 10:08:42 +08:00
Guo Wangyang
8de524cb73
ColumnVector: optimize UInt8 index with AVX512VBMI (#41247)
* ColumnVector: optimize UInt8 index with AVX512VBMI

* ColumnVector: coding style fix

* ColumnVector: add index test

* ColumnVector: refactory to use default impl for index

* ColumnVector: add more comments

* ColumnVector: more precise and simple type declaration

* Fix style check failure

Co-authored-by: Nikita Taranov <nikita.taranov@clickhouse.com>
2022-09-23 01:59:49 +02:00
Nikolay Degterinsky
6edf8ec3f2 Better S3 logs 2022-09-22 22:34:13 +00:00
Dmitry Novik
177013fdc5
Merge branch 'master' into fix-errors-recording 2022-09-22 23:17:55 +02:00
Igor Nikonov
6551966dc7 Change the way reading in order is requested from plan optimizations 2022-09-22 20:47:00 +00:00
Igor Nikonov
9ea277c047 Remove unnecessary method from ReadFromMergeTree 2022-09-22 19:52:02 +00:00
Igor Nikonov
6f7d0fec52 Merge remote-tracking branch 'origin/master' into distinct_in_order_wo_order_by 2022-09-22 19:38:34 +00:00
Nikolai Kochetov
00965ce17a Fixing race. 2022-09-22 17:57:04 +00:00
Anton Popov
4c7a820685 fix order by monotonic functions 2022-09-22 16:21:28 +00:00
Kseniia Sumarokova
9e97ca1df7
Update src/Storages/StorageS3.h
Co-authored-by: Nikolay Degterinsky <43110995+evillique@users.noreply.github.com>
2022-09-22 17:59:26 +02:00
kssenii
0e8343e6f3 Revert "Better config for cache"
This reverts commit 0ca6aadbdb.
2022-09-22 17:57:44 +02:00
Alexander Tokmakov
981c1e95c6
Update MutateTask.cpp 2022-09-22 18:51:27 +03:00
kssenii
7b8c63b4e4 Merge remote-tracking branch 'origin/fix-disk-web' into fix-disk-web 2022-09-22 16:24:13 +02:00
kssenii
109d2ad022 Better 2022-09-22 16:22:05 +02:00
avogar
f23a77156f Check file path for path traversal attacks in errors logger for input formats 2022-09-22 13:56:51 +00:00
Antonio Andelic
e36a53a762
Merge pull request #41616 from ClickHouse/fix-keeper-map-drop
Fix drop for KeeperMap
2022-09-22 15:43:23 +02:00
Roman Vasin
348f28a3e7 Fix toStartOfFiveMinutes, toStartOfTenMinutes, toStartOfFifteenMinutes 2022-09-22 13:30:40 +00:00
Nikolay Degterinsky
a7f3c7086c
Merge pull request #41341 from evillique/mandatory-identification
Add a setting requiring no_password to be explicitly specified when creating a user
2022-09-22 15:19:43 +02:00
Roman Vasin
cdd20241bf Finish toStartOfDay; fix toStartOfMinute 2022-09-22 13:16:46 +00:00
kssenii
f038c7ea00 Better config for cache 2022-09-22 14:50:29 +02:00
kssenii
0ca6aadbdb Better config for cache 2022-09-22 14:49:35 +02:00
Nikolai Kochetov
63e757a659
Merge pull request #36379 from amosbird/projection-compatibility-fix
Make minmax_count projection backward compatible
2022-09-22 14:15:35 +02:00
Kseniia Sumarokova
b11aa0dd0e
Merge pull request #41680 from ClickHouse/kssenii-patch-5
Fix error message
2022-09-22 13:26:42 +02:00
Nikolai Kochetov
3b63719ece
Merge pull request #41619 from den-crane/patch-50
increase default max_suspicious_broken_parts to 100
2022-09-22 13:25:22 +02:00
Kseniia Sumarokova
5caac39328
Merge pull request #41508 from kssenii/rename-some-cache-commands
Rename: `show caches` -> `show filesystem caches`, `describe cache` -> `describe filesystem cache`
2022-09-22 13:09:14 +02:00
alesapin
ca410b7a0b
Merge pull request #41147 from ClickHouse/enable_projections_and_zero_copy
Enable projections and zero copy replication
2022-09-22 13:05:09 +02:00
Alexander Tokmakov
021b882455 Revert "Disable parallel s3 multipart upload for part moves. (#41268)"
This reverts commit 0414d95878.
2022-09-22 13:59:25 +03:00
Kseniia Sumarokova
73ccf94778
Update FileCacheSettings.cpp 2022-09-22 12:53:26 +02:00
alesapin
a95e291474
Merge branch 'master' into investigating_more_bugs 2022-09-22 12:51:55 +02:00
alesapin
57be648984
Merge pull request #41649 from ClickHouse/supress_one_more_key_doesnt_exists
Release AWS SDK log level + replace one exception
2022-09-22 12:38:03 +02:00
Roman Vasin
4ddd6f3c60 Fix timeSlot(); partial fix StartOfDay 2022-09-22 09:19:22 +00:00
Kruglov Pavel
2c83abaaba
Merge pull request #41614 from ClickHouse/Avogar-patch-1
Fix typos in JSON formats after #40910
2022-09-22 10:58:47 +02:00
Zhiguo Zhou
223c1230b6 Optimize the lock contentions for ThreadGroupStatus::mutex
The release of ThreadGroupStatus::finished_threads_counters_memory
via the getProfileEventsCountersAndMemoryForThreads method brings
lots of lock contentions for ThreadGroupStatus::mutex and lowers
the overall performance. This commit optimizes this performance
issue by replacing the method call with an equivalent but more
lightweight code block.
2022-09-22 16:23:16 +08:00
Igor Nikonov
8c93a9adda Merge remote-tracking branch 'origin/master' into distinct_in_order_wo_order_by 2022-09-22 07:40:14 +00:00
Alexey Milovidov
93ed8e0c7b Update version to 22.10.1.1 2022-09-22 09:32:38 +02:00
Roman Vasin
49b0da0273 Add date32IsNotSupported() 2022-09-22 07:15:03 +00:00
Roman Vasin
f6ebd94ce1 Add execute_extended_result for Date32 argument 2022-09-22 07:07:04 +00:00