Commit Graph

18 Commits

Author SHA1 Message Date
Alexey Milovidov
feae36636c Simplify code around TraceCollector, alternative to #24829 2021-06-01 11:54:05 +03:00
Alexander Kuzmenkov
308c4657ce support longer query ids in trace log for perf tests 2021-05-08 18:20:42 +03:00
Azat Khuzhin
6b39e61d09 Decrease QUERY_ID_MAX_LEN for freebsd/osx (PIPE_BUF=512) 2021-02-23 07:47:58 +03:00
Azat Khuzhin
89c311981d Fix buffer size for trace collection
[1]: https://clickhouse-test-reports.s3.yandex.net/0/a860e3e7582f489a640c42db3bd4bd320f97a5bc/stress_test_(debug).html#fail1
2021-02-22 22:45:04 +03:00
alesapin
89c292f5b7 Fix response pipe read 2020-11-27 13:12:11 +03:00
Azat Khuzhin
8c482b978b Set thread name for the TraceCollector 2020-11-11 21:30:17 +03:00
Mikhail Filimonov
41971e073a
Fix typos reported by codespell 2020-10-27 12:04:03 +01:00
Azat Khuzhin
72d7b6117e Use total_memory_tracker when there is no other MemoryTracker object.
This should significantly reduce the MemoryTracking drift, test shows
that there is 0 drift after query storm (100 queries, via http/tcp/tcp
in one session).

TL;DR;

To track memory, clickhouse creates memory tracker object for each
thread **explicitly**, but until it is not created the memory
allocations are not under account.
There should not be lot of allocations w/o memory tracker, since most of
the time it is created early enough, but even this maybe enough to
trigger some problems.

Plus sometimes it is not possible to create it, for example some 3d
party library does not allow to do this explicitly:
- for example before #15740 allocations from librdkafka threads,
- or even worse, poco threads, they don't have any routines to do this.
This won't be a problem for `MemoryTracking` metric if the deallocation
will be done from the same thread w/o memory tracker (or vise versa),
but this is not always true.

NOTE, that this will slow down per-thread allocations w/o memory
tracker, since before this patch there were no memory tracking for them
while now they will be accounted in total_memory_tracker, and for
total_memory_tracker max_untracked_memory is always reached.
But this should not be significant.
2020-10-23 21:07:52 +03:00
bharatnc
24ea6b2380 TraceCollector - time s&us using same timespec 2020-09-25 10:39:37 -07:00
bharatnc
b0d4fe5114 TraceLog - add field event_time_microseconds 2020-09-25 10:39:37 -07:00
Alexey Milovidov
64d91d0f90 Fix build; fix errors 2020-08-01 18:54:44 +03:00
Alexey Milovidov
9ef9d31f03 Crash log: development 2020-07-31 23:16:31 +03:00
alexey-milovidov
e8f5bbd05f
Update TraceCollector.cpp 2020-07-31 02:29:54 +03:00
Nikita Mikhaylov
4d49d2c671 another removes 2020-07-30 13:31:14 +03:00
Ivan Blinkov
709b4f42c8 Prototype sending crash reports on segfaults 2020-05-27 22:11:04 +03:00
Alexey Milovidov
293ae88e7f Add sampling memory profiler 2020-04-30 16:25:17 +03:00
Alexey Milovidov
07dcf40a6a Simple server wide memory profiler 2020-04-22 20:52:21 +03:00
Ivan Lezhankin
06446b4f08 dbms/ → src/ 2020-04-03 18:14:31 +03:00