Commit Graph

134949 Commits

Author SHA1 Message Date
Mikhail f. Shiryaev
f5a71455b8
Do not rebuild a lambda package if it is updated 2024-02-12 18:12:25 +01:00
János Benjamin Antal
69273b4645 Fix parsing of partition expressions surrounded by parens 2024-02-12 17:10:10 +00:00
kssenii
0628ae6268 S3 queue fix uninitialized value 2024-02-12 17:13:30 +01:00
Max K
40d39e6efa
Merge pull request #59890 from ClickHouse/ci_fix_build_jobs_issue
CI: Fix job failures due to jepsen artifacts
2024-02-12 16:33:13 +01:00
Azat Khuzhin
c7c05c9881 Do not pull mutations if pulling replication log had been stopped
Right now, mutations can be pulled even after:

    SYSTEM STOP PULLING REPLICATION LOG

Since they pulled from two places:
- StorageReplicatedMergeTree::mutationsUpdatingTask()
- ReplicatedMergeTreeQueue::pullLogsToQueue()

And only the last one checks action blocker.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 16:28:08 +01:00
János Benjamin Antal
b094ab9763 Add comment 2024-02-12 15:27:20 +00:00
Max Kainov
c880739311 CI: Fix build job failures due to jepsen artifacts 2024-02-12 15:10:43 +00:00
Raúl Marín
407b7a4651
Merge pull request #59737 from Algunenano/more_asserts_memory
Add assertions around FixedString code
2024-02-12 16:01:02 +01:00
Antonio Andelic
5872ca520c
Merge pull request #59592 from ClickHouse/keeper-more-reduce
Reduce size of node in Keeper even more
2024-02-12 15:59:39 +01:00
vdimir
2d7fdc896a
Add test 02988_join_using_prewhere_pushdown 2024-02-12 14:03:45 +00:00
Dmitry Novik
00136b8f65
Merge pull request #59121 from ClickHouse/analyzer-fix-const-fold
Analyzer: Add cast for ConstantNode from constant folding
2024-02-12 15:01:15 +01:00
Nikolai Kochetov
87b6d65b9b Remove outdated comment. 2024-02-12 13:46:30 +00:00
Dmitry Novik
727e0bbf6a
Merge pull request #59750 from ClickHouse/fix-analyzer-integration-server-version
Analyzer: Fix test_replicating_constants/test.py::test_different_versions
2024-02-12 14:40:16 +01:00
Dmitry Novik
584d197e52
Merge pull request #59801 from ClickHouse/analyzer-fix-test_access_for_functions
Analyzer: fix test_access_for_functions/test.py::test_access_rights_for_function
2024-02-12 14:37:48 +01:00
Nikolai Kochetov
fd2ee19f65 Follow up for #58554. Cleanup. 2024-02-12 13:37:25 +00:00
Azat Khuzhin
13e3877254 Add chc/chl/ch into clickhouse-bundle target
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 14:32:15 +01:00
Azat Khuzhin
bc2921d1f1 tests: fix 02322_sql_insert_format flakiness
02322_sql_insert_format failed from time to time [1] and I found only
one reason - structure cache, I guess it may fail when the mtime was the
same.

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/59857/46a9ced0f9031153538446f4b625e0cc34532a90/fast_test.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 13:49:46 +01:00
Nikolai Kochetov
09d3b3c0d0
Merge pull request #58554 from ClickHouse/try-to-always-push-down-prewhere-from-query-plan
Simplify optimize-push-to-prewhere from query plan
2024-02-12 12:52:39 +01:00
Mikhail f. Shiryaev
1285bdbef1
Merge pull request #59808 from AlexNik/always-initdb-option
Option to run init db scripts every time
2024-02-12 12:09:54 +01:00
Azat Khuzhin
11fddc8d63 Unify binary aliases
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 12:06:33 +01:00
Azat Khuzhin
3145c5d5f5 Add missing install target for ch/chc/chl
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 12:02:42 +01:00
Raúl Marín
fc964d6ddd
Merge pull request #59851 from azat/tests/initial_query_start_time
Reintroduce 02590_interserver_mode_client_info_initial_query_start_time
2024-02-12 11:52:38 +01:00
Azat Khuzhin
67b73c3e49 Fix long shutdown of FileLog storage
Previously it was possible to wait up to
poll_directory_watch_events_backoff_max (default is 32000) on shutdown,
because it was not possible to stop poll of inotify.

Before (takes 3 seconds):

    2024.02.12 11:27:55.058192 [ 10134 ] {} <Trace> StorageFileLog (file_log): Waiting for cleanup
    2024.02.12 11:27:58.178021 [ 10271 ] {} <Trace> directory_watch: Execution took 7519 ms.

After:

    2024.02.12 11:33:29.722403 [ 15866 ] {} <Trace> StorageFileLog (file_log): Waiting for cleanup
    2024.02.12 11:33:29.722473 [ 15956 ] {} <Trace> directory_watch: Execution took 6399 ms.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 11:52:09 +01:00
Igor Nikonov
0c35492ed3
Merge pull request #59858 from ClickHouse/std-exception-during-exception-handling
Fix: check if std::function is set before calling it
2024-02-12 11:36:14 +01:00
Azat Khuzhin
7fb31fe160 Remove ability to disable generic clickhouse components
Components like client/server/... are very generic, and there is no
point in disabling them, since it does not reduce amount of compiled
code a lot anyway (just a few modules for entrypoints, everything else
is already included in the clickhouse binary), and eventually they are
just symlinks to the clickhouse binary.

But there are few, that requires extra libraries, like ODBC bridge or
keeper components (and there is also standalone keeper binary compiled
with musl), those had been kept.

Also add some descriptions for some utils and change exit code to 0 for
--help.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 11:10:00 +01:00
Azat Khuzhin
504e3b0f1b Install ch/chc/chl via nfpm
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 11:10:00 +01:00
Antonio Andelic
a0507c2044 Whitespace 2024-02-12 10:36:35 +01:00
Alexander Gololobov
67bb3994ce
Merge pull request #59854 from ClickHouse/system_zk_init
Do not reinitialize ZooKeeperWithFaultInjection on each chunk
2024-02-12 10:14:54 +01:00
Antonio Andelic
36b966967b Merge branch 'master' into keeper-more-reduce 2024-02-12 10:03:07 +01:00
Antonio Andelic
c9c0e12b4c Address PR reviews 2024-02-12 09:15:40 +01:00
Alexey Milovidov
61a5696ce9
Merge pull request #59735 from ClickHouse/tavplubix-patch-13
Make ZooKeeper actually sequentialy consistent
2024-02-12 04:41:35 +01:00
Alexey Milovidov
5dbcff8048
Merge pull request #58609 from azat/binary-aliases-cmake
Create ch/chc/chl symlinks by cmake as well (for develop mode)
2024-02-11 23:45:58 +01:00
Alexey Milovidov
da452c7947
Merge pull request #59799 from ClickHouse/auto/v24.1.3.31-stable
Update version_date.tsv and changelogs after v24.1.3.31-stable
2024-02-11 23:41:17 +01:00
Alexey Milovidov
a65b9cc1f8
Merge pull request #59800 from ClickHouse/auto/v23.12.4.15-stable
Update version_date.tsv and changelogs after v23.12.4.15-stable
2024-02-11 23:41:09 +01:00
Igor Nikonov
cb812d84cf Fix: check if std::function is set before calling it 2024-02-11 22:31:33 +00:00
Nikolay Degterinsky
920a87bc62
Merge pull request #59852 from azat/build/rust-osx-versioning
Respect CMAKE_OSX_DEPLOYMENT_TARGET for Rust targets
2024-02-11 19:37:27 +01:00
Alexander Gololobov
309db427e7 Do not reinitialize ZooKeeperWithFaultInjection on each chunk 2024-02-11 13:13:49 +01:00
Robert Schulze
b1099e181d
Add check for NULL pattern argument 2024-02-11 11:38:33 +00:00
Azat Khuzhin
a3938e7df0 Respect CMAKE_OSX_DEPLOYMENT_TARGET for Rust targets
This should fix the following warnings:

    ld: warning: object file (rust/prql/Debug/lib_ch_rust_prql.a[74](aarch_aapcs64.o)) was built for newer 'macOS' version (14.0) than being linked (11.0)
    ld: warning: object file (rust/skim/Debug/lib_ch_rust_skim_rust.a[40](c0e230e4543ad627-lib.rs.o)) was built for newer 'macOS' version (14.0) than being linked (11.0)
    ld: warning: object file (rust/skim/Debug/lib_ch_rust_skim_rust.a[46](6c3a6ae2099d4914-cxx.o)) was built for newer 'macOS' version (14.0) than being linked (11.0)

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-11 10:55:14 +01:00
Azat Khuzhin
64e53fee7b Reintroduce 02590_interserver_mode_client_info_initial_query_start_time
Reintroduce the test without assumption that initial_query_start_time is
the same as query_start_time.

This reverts commit 075da5602f.
2024-02-11 10:11:49 +01:00
Alexey Milovidov
c18f713482
Merge pull request #59833 from ClickHouse/ns
Fix StorageURL doing some of the query execution in single thread
2024-02-11 07:59:52 +01:00
Michael Kolupaev
b5fd68a2b6 no-fasttest 2024-02-11 02:44:18 +00:00
Michael Kolupaev
5424f235a9 Fix StorageURL doing some of the query execution in one thread instead of max_threads 2024-02-11 02:44:18 +00:00
Alexey Milovidov
789bca11e1
Merge pull request #58792 from ClickHouse/enable-coverage-for-debug-build
Add builds and tests with coverage
2024-02-10 23:52:22 +01:00
Alexey Milovidov
ccc9637dda
Merge pull request #59814 from ClickHouse/enforce-analyzer-tests
Enforce tests with enabled analyzer in CI
2024-02-10 21:39:54 +01:00
Vitaly Baranov
40ea04faf5 Add check that recursiveRemoveLowCardinality() doesn't change the size of a column. 2024-02-10 21:07:31 +01:00
Nikolai Kochetov
306f504781 Fixing test. 2024-02-10 19:53:03 +00:00
Alexey Milovidov
61227acdc4 Merge branch 'master' of github.com:ClickHouse/ClickHouse into enable-coverage-for-debug-build 2024-02-10 19:30:22 +01:00
Alexey Milovidov
9f8f8f64c1
Merge pull request #59846 from azat/better-task_delayacct-warning
Better warning for disabled kernel.task_delayacct
2024-02-10 19:26:39 +01:00
Robert Schulze
04f6178176
Fix spellcheck, pt. II 2024-02-10 16:32:49 +00:00