Commit Graph

56636 Commits

Author SHA1 Message Date
Alexey Milovidov
11f144f589 Fix deadlock in system.text_log 2021-01-31 13:02:35 +03:00
Alexey Milovidov
b74b76f681 clickhouse-benchmark: add --reconnect option 2021-01-31 12:36:55 +03:00
Alexey Milovidov
37f88a1468 Whitespace 2021-01-31 12:02:54 +03:00
Azat Khuzhin
978f23e343 Fix SIGSEGV due to accessing GRPCServer::currentConnections() before initialization
This PR makes asynchronous metrics available just after start, and this
breaks GRPCServer, since it requires the server be started before
accessing currentConnections().

However it is possible to trigger the same SIGSEGV even without that
patch, with some timeouts during previous server initilizations and
small asynchronous_metrics_update_period_s.

Fix this by creating GRPCServer::Runner in the ctor.

Stacktrace:
    26.842505 [ 7 ] {} <Information> Application: Listening for MySQL compatibility protocol: 0.0.0.0:9004
    26.842562 [ 7 ] {} <Information> Application: Listening for gRPC protocol: 0.0.0.0:9100
    26.842600 [ 7 ] {} <Debug> AsynchronousMetrics: MemoryTracking: was 350.72 KiB, peak 5.25 MiB, will set to 232.63 MiB (RSS), difference: 232.29 MiB
    26.842834 [ 8 ] {} <Trace> BaseDaemon: Received signal 11
    26.843014 [ 39 ] {} <Fatal> BaseDaemon: ########################################
    26.843055 [ 39 ] {} <Fatal> BaseDaemon: (version 21.2.1.5858, build id: B27D5550AC34F9091BC4437D8021B752EDB34FBB) (from thread 7) (no query) Received signal Segmentation fault (11)
    26.843085 [ 39 ] {} <Fatal> BaseDaemon: Address: 0x78 Access: read. Address not mapped to object.
    26.843104 [ 39 ] {} <Fatal> BaseDaemon: Stack trace: 0x7fe8c4e6afc4 0x13683cf1 0xf52efe5 0xe7c9137 0x85596e1 0x8553635 0x11b7a313 0x8545ebc 0x8544b25 0x84e1cbe 0x7fe8c4c940b3 0x84ac22e
    26.843136 [ 39 ] {} <Fatal> BaseDaemon: 2. pthread_mutex_lock @ 0xbfc4 in /usr/lib/x86_64-linux-gnu/libpthread-2.31.so
    26.843162 [ 39 ] {} <Fatal> BaseDaemon: 3. std::__1::mutex::lock() @ 0x13683cf1 in ?
    26.843188 [ 39 ] {} <Fatal> BaseDaemon: 4. DB::GRPCServer::currentConnections() const @ 0xf52efe5 in /usr/bin/clickhouse
    26.843204 [ 39 ] {} <Fatal> BaseDaemon: 5. DB::AsynchronousMetrics::update() @ 0xe7c9137 in /usr/bin/clickhouse
    26.843228 [ 39 ] {} <Fatal> BaseDaemon: 6. DB::AsynchronousMetrics::start() @ 0x85596e1 in /usr/bin/clickhouse
    26.843248 [ 39 ] {} <Fatal> BaseDaemon: 7. DB::Server::main(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) @ 0x8553635 in /usr/bin/clickhouse
    26.843270 [ 39 ] {} <Fatal> BaseDaemon: 8. Poco::Util::Application::run() @ 0x11b7a313 in /usr/bin/clickhouse
    26.843284 [ 39 ] {} <Fatal> BaseDaemon: 9. DB::Server::run() @ 0x8545ebc in /usr/bin/clickhouse
    26.843299 [ 39 ] {} <Fatal> BaseDaemon: 10. mainEntryClickHouseServer(int, char**) @ 0x8544b25 in /usr/bin/clickhouse
    26.843313 [ 39 ] {} <Fatal> BaseDaemon: 11. main @ 0x84e1cbe in /usr/bin/clickhouse
    26.843331 [ 39 ] {} <Fatal> BaseDaemon: 12. __libc_start_main @ 0x270b3 in /usr/lib/x86_64-linux-gnu/libc-2.31.so
    26.843346 [ 39 ] {} <Fatal> BaseDaemon: 13. _start @ 0x84ac22e in /usr/bin/clickhouse
2021-01-31 11:29:46 +03:00
Amos Bird
18f3df31d5
Fix crash when pushing down predicates to union distinct subquery 2021-01-31 16:29:29 +08:00
Amos Bird
c39ee3f58c
Fix argMinMaxIf crash 2021-01-31 16:27:46 +08:00
Alexey Milovidov
5b7c437e6d Minor modification 2021-01-31 11:24:37 +03:00
Alexey Milovidov
246ed24801 Update test 2021-01-31 11:23:55 +03:00
alexey-milovidov
842c2c840c
Merge pull request #19773 from ClickHouse/tavplubix-patch-3
Fix stack overflow in FieldVisitorAccurateEquals
2021-01-31 11:09:41 +03:00
Alexey Milovidov
01a703ae50 Update test 2021-01-31 10:48:18 +03:00
Alexey Milovidov
d604cbc986 Maybe improve server latency 2021-01-31 10:41:24 +03:00
alexey-milovidov
dceb0be9ed
Merge pull request #19774 from ClickHouse/clickhouse-test-log-comment
Add log comment when running .sh tests
2021-01-31 10:14:21 +03:00
alexey-milovidov
889cebcff9
Merge pull request #19800 from ClickHouse/utf8mb4-in-mysql-client
Set charset to utf8mb4 in mariadb-connector
2021-01-31 10:13:51 +03:00
Alexey Milovidov
e23dc60e31 Fix UBSan report in GatherUtils 2021-01-31 10:12:17 +03:00
Alexey Milovidov
248540e58f Fix UBSan report in GatherUtils 2021-01-31 10:10:37 +03:00
Alexey Milovidov
ddd4a7b1b5 Add exception for fast test 2021-01-31 08:33:41 +03:00
Alexey Milovidov
40a356db74 Fix warning 2021-01-31 07:40:51 +03:00
Alexey Milovidov
e5736c4c8d Fix debug assertion in Hyperscan 2021-01-31 07:23:07 +03:00
Alexey Milovidov
ae65219525 More tests 2021-01-31 06:56:39 +03:00
Alexey Milovidov
0128d185ea Fix UBSan report in DateTimeAddInterval 2021-01-31 06:49:33 +03:00
alexey-milovidov
d93dad0ec3
Merge pull request #19722 from azat/background_message_broker_schedule_pool_size
Add separate pool for message brokers (RabbitMQ and Kafka)
2021-01-31 06:07:45 +03:00
alexey-milovidov
b247368617
Merge pull request #19834 from azat/style-check-fix
style-check tiny fixes
2021-01-31 06:07:24 +03:00
alexey-milovidov
d0bd6af49d
Merge pull request #19824 from azat/tryLogCurrentException
Avoid losing exception messages in logs under high memory pressure
2021-01-31 06:05:55 +03:00
Alexey Milovidov
921ee52ebc More tests 2021-01-31 05:47:59 +03:00
Alexey Milovidov
0fa5142715 Remove tons of garbage 2021-01-31 05:36:52 +03:00
Vitaly Baranov
cbd4bace6f Mark that test 01676_dictget_in_default_expression should not be run in parallel. 2021-01-31 05:25:29 +03:00
Alexey Milovidov
5c718c8754 Merge branch 'master' into unicode-asan 2021-01-31 02:40:24 +03:00
Alexey Milovidov
895be295a1 Fix test 2021-01-31 02:22:55 +03:00
Alexey Milovidov
a923b94bdb Merge branch 'master' into clickhouse-test-log-comment 2021-01-31 01:38:27 +03:00
alexey-milovidov
8ac39e7f56
Merge pull request #19791 from ClickHouse/format-readable-time-delta-ubsan
formatReadableTimeDelta: correctly output infinite values
2021-01-31 01:37:59 +03:00
Alexey Milovidov
7b8589dbde Merge branch 'master' into utf8mb4-in-mysql-client 2021-01-31 01:37:27 +03:00
Alexey Milovidov
282409e8a9 Add a patch from Stig Bakken 2021-01-31 01:37:12 +03:00
Alexey Milovidov
30e1db7f47 Merge branch 'master' into azat-client-complete-error-codes 2021-01-31 00:01:47 +03:00
alexey-milovidov
d9e4ea8e58
Merge pull request #19853 from azat/bit-func-forbid-floats
Forbid bit functions for floats
2021-01-31 00:00:15 +03:00
Vitaliy Zakaznikov
64261c7720 Fixing reference to LDAP role mapping specification 2021-01-30 15:24:20 -05:00
bharatnc
e967ba5f3b try fix clang-11-darwin build 2021-01-30 12:12:38 -08:00
Maksim Kita
155f6c0eb5 Function reinterpretAs updated to support big integers 2021-01-30 22:56:23 +03:00
Ilya Yatsishin
1684be296c
Merge pull request #19833 from filimonov/fixes-int-tests 2021-01-30 22:51:52 +03:00
vdimir
5cb99ae699
Use offsets in FunctionIPv6StringToNum for copying ipv4 to buffer 2021-01-30 20:20:11 +03:00
Vitaly Baranov
95177dc0de Fix access to the key as an attribute in IPAddressDictionary. 2021-01-30 19:06:54 +03:00
Vitaly Baranov
7c8deae0e1 Fix starting the server with tables having columns' default expressions containing dictGet().
Allow getting return type of dictGet() without loading dictionary.
2021-01-30 19:06:48 +03:00
Vitaliy Zakaznikov
124bd1ea19 Fixing live view refresh test.
Adding live view refresh with dictionary test.
2021-01-30 10:56:02 -05:00
Ilya Yatsishin
5afcc927ac
Merge pull request #19706 from qoega/easier-integration-no-project-dir 2021-01-30 17:22:00 +03:00
Vitaliy Zakaznikov
dc9c3c8514 Fixing styling errors.
Adding simple tests.
2021-01-30 09:00:42 -05:00
Nikolai Kochetov
f7dc83ae96
Merge pull request #19725 from ClickHouse/limit-push-down
Update QueryPlan tree optimization traverse.
2021-01-30 16:34:46 +03:00
sevirov
df28433457
Update docs/ru/sql-reference/statements/select/index.md
Co-authored-by: Anna <42538400+adevyatova@users.noreply.github.com>
2021-01-30 16:34:39 +03:00
sevirov
a46c8e0c73
Update docs/ru/sql-reference/statements/select/index.md
Co-authored-by: Anna <42538400+adevyatova@users.noreply.github.com>
2021-01-30 16:33:49 +03:00
sevirov
c7fa78be1e
Update docs/ru/sql-reference/statements/select/index.md
Co-authored-by: Anna <42538400+adevyatova@users.noreply.github.com>
2021-01-30 16:32:07 +03:00
Mikhail Filimonov
39f75ccd19
Revert changes in test_multiple_disks 2021-01-30 11:26:31 +01:00
alexey-milovidov
8d2a169e8d
Merge pull request #19821 from qoega/fix-msan-1
Fix msan warnings in cyrus-sasl and musl
2021-01-30 10:56:12 +03:00