alesapin
ba28c2c013
Merge branch 'master' into revert-34211-revert-34153-add_func_tests_over_s3
2022-02-07 12:44:56 +03:00
alesapin
fb77d7a7d5
Revert "Revert "Merge pull request #34219 from ClickHouse/revert-34212-revert-33291-add-pool-to-s3-write-buffer""
...
This reverts commit 875e5413ad
.
2022-02-07 12:36:54 +03:00
alesapin
bb361e3b01
Fix bug with existing part
2022-02-07 12:33:37 +03:00
alexey-milovidov
fb9ed9acad
Merge pull request #34175 from kitaisreal/bitset-sort-performance-check
...
bitsetsort peformance check
2022-02-07 05:34:57 +03:00
feng lv
6325d4d9b0
continue of #34317
...
fix
fix
2022-02-06 08:59:17 +00:00
Maksim Kita
e626b7b2d3
Fixed tests
2022-02-04 19:52:18 +00:00
Maksim Kita
1cd1fb9658
Fixed tests
2022-02-04 19:52:18 +00:00
Maksim Kita
f301e50b23
Fixed tests
2022-02-04 19:52:18 +00:00
alexey-milovidov
e194bf3377
Merge pull request #34317 from ucasfl/lowcard
...
use LowCardinality for _file and _path virtual columns in StorageFile
2022-02-04 21:39:44 +03:00
Nikolai Kochetov
daeeb6f3a2
Merge pull request #34316 from ClickHouse/probably-fix-data-race-in-WriteBufferFromS3
...
Probably fix data race in WriteBufferFromS3 destructor.
2022-02-04 21:04:46 +03:00
Nikolai Kochetov
6436024e08
Fix test with ttl.
2022-02-04 16:05:02 +00:00
alesapin
c028269e6f
Merge branch 'master' into revert-34211-revert-34153-add_func_tests_over_s3
2022-02-04 18:02:25 +03:00
alesapin
d4d147abab
Remove redundant
2022-02-04 18:01:49 +03:00
Azat Khuzhin
63e674280b
Decrease severity for "Reading ... ranges ..." log message to Trace
...
That way with send_logs_level='debug', you will not get verbose
information that you already has, since there is summary row:
Selected ... parts by partition key, ... parts by primary key, ... marks by primary key, ... marks to read from ... ranges
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-04 18:00:59 +03:00
tavplubix
22de534fdc
Merge pull request #34297 from ClickHouse/fix_restarting_thread
...
Try to fix race between pullLogsToQueue and RestartingThread
2022-02-04 17:30:17 +03:00
feng lv
7bf2243431
use LowCardinality for _file and _path virtual columns in StorageFile
...
fix
2022-02-04 14:15:56 +00:00
alesapin
1582c4bf24
Fix mutaion status for retryable errors
2022-02-04 16:27:59 +03:00
Maksim Kita
ab696e6b59
Merge pull request #34310 from ClickHouse/fix-parallel-loading-parts
...
Fix parallel loading of data parts
2022-02-04 13:10:24 +01:00
alesapin
875e5413ad
Revert "Merge pull request #34219 from ClickHouse/revert-34212-revert-33291-add-pool-to-s3-write-buffer"
...
This reverts commit b92efed350
, reversing
changes made to ecce006cb2
.
2022-02-04 14:30:33 +03:00
alesapin
af18905a33
Fixup
2022-02-04 13:03:13 +03:00
alesapin
2ed45b2a98
Merge branch 'master' into revert-34211-revert-34153-add_func_tests_over_s3
2022-02-04 11:23:46 +03:00
Nikolai Kochetov
b92efed350
Merge pull request #34219 from ClickHouse/revert-34212-revert-33291-add-pool-to-s3-write-buffer
...
Revert "Revert "Add pool to WriteBufferFromS3""
2022-02-04 11:00:29 +03:00
Alexey Milovidov
78eebd5c7c
Fix parallel loading of data parts
2022-02-04 02:29:46 +03:00
Alexander Tokmakov
897e94c16c
make restarting thread less bad
2022-02-03 23:29:24 +03:00
Anton Popov
9b844c6b42
Merge pull request #32748 from CurtizJ/read-in-order-fixed-prefix
...
Support `optimize_read_in_order` if prefix of sorting key is already sorted
2022-02-03 18:17:08 +03:00
alesapin
2a9bc7cba8
Merge branch 'master' into revert-34211-revert-34153-add_func_tests_over_s3
2022-02-03 16:20:06 +03:00
Nikolai Kochetov
a2a9c10617
Merge pull request #34221 from ClickHouse/revert-34201-revert-34189-less-logging-for-remote_fs_execute_merges_on_single_replica_time_threshold
...
Revert "Revert "Additionally check remote_fs_execute_merges_on_single_replica_time_threshold inside ReplicatedMergeTreeQueue""
2022-02-03 13:09:44 +03:00
alesapin
763dfd7895
Fix write ahead log
2022-02-03 12:14:00 +03:00
alesapin
25375bc76b
Remove unused param
2022-02-03 11:21:19 +03:00
alesapin
e0f640dd9f
Fix
2022-02-02 19:44:29 +03:00
alesapin
80800e051e
Merge branch 'master' into revert-34211-revert-34153-add_func_tests_over_s3
2022-02-02 19:42:04 +03:00
Nikolai Kochetov
ea044fc6b2
Merge branch 'master' into revert-34212-revert-33291-add-pool-to-s3-write-buffer
2022-02-02 19:40:41 +03:00
alesapin
b9c118524f
Fix race condition on hardlink/erase/read metadata
2022-02-02 19:40:21 +03:00
Nikolai Kochetov
1117e6095d
Update src/Storages/MergeTree/ReplicatedMergeTreeQueue.cpp
...
Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>
2022-02-02 18:34:05 +03:00
Azat Khuzhin
15993cb13b
Add missing fmt::runtime() in MergeTreeBackgroundExecutor
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-02 11:37:53 +03:00
alesapin
47d538b52f
Merge pull request #34232 from ClickHouse/cancelled-merging-parts-error-message
...
Change severity of the "Cancelled merging parts" message in logs
2022-02-02 10:29:07 +03:00
Sergei Trifonov
68bc456830
Merge pull request #34223 from azat/bump-fmt
...
Bump fmtlib from 7.0.0 to 8.1.1
2022-02-02 00:03:25 +03:00
Nikolai Kochetov
dd81eff301
Fix tests.
2022-02-01 15:28:22 +00:00
alesapin
e87ed0ff02
Fix in-memory parts
2022-02-01 14:37:12 +03:00
Azat Khuzhin
5dfafd68a7
ReplicatedMergeTreeQueue: Fix fmt:: and reduce copy-paste of logging and out reason
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-01 14:30:04 +03:00
Azat Khuzhin
5be76bc969
Use proper fmt-like logging
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-01 14:30:04 +03:00
Azat Khuzhin
3b3635c6d5
Fix formatting error in logging messages
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-01 14:30:04 +03:00
Azat Khuzhin
743096a883
Use proper fmt:: like Exception ctor in DataPartsExchange
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-01 14:30:03 +03:00
Azat Khuzhin
bedf208cbd
Use fmt::runtime() for LOG_* for non constexpr
...
Here is oneliner:
$ gg 'LOG_\(DEBUG\|TRACE\|INFO\|TEST\|WARNING\|ERROR\|FATAL\)([^,]*, [a-zA-Z]' -- :*.cpp :*.h | cut -d: -f1 | sort -u | xargs -r sed -E -i 's#(LOG_[A-Z]*)\(([^,]*), ([A-Za-z][^,)]*)#\1(\2, fmt::runtime(\3)#'
Note, that I tried to do this with coccinelle (tool for semantic
patchin), but it cannot parse C++:
$ cat fmt.cocci
@@
expression log;
expression var;
@@
-LOG_DEBUG(log, var)
+LOG_DEBUG(log, fmt::runtime(var))
I've also tried to use some macros/templates magic to do this implicitly
in logger_useful.h, but I failed to do so, and apparently it is not
possible for now.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
v2: manual fixes
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-01 14:30:03 +03:00
Nikolai Kochetov
a6cc61bd14
Revert "Revert "Additionally check remote_fs_execute_merges_on_single_replica_time_threshold inside ReplicatedMergeTreeQueue""
2022-02-01 14:17:46 +03:00
alesapin
0aebab50f5
Fix exception in destructor
2022-02-01 14:07:58 +03:00
Nikolai Kochetov
2a6eb593be
Revert "Revert "Add pool to WriteBufferFromS3""
2022-02-01 13:36:51 +03:00
alexey-milovidov
06477c2a7e
Update ReplicatedMergeTreeSink.cpp
2022-02-01 09:22:40 +01:00
Igor Nikonov
f4c0b64420
Clean up: insert_deduplication_token setting for INSERT statement
...
+ reduce number of allocations on replication merge tree path
+ bash test: move insert block settings into variable
Issue: ClickHouse#7461
2022-02-01 09:22:33 +01:00
alexey-milovidov
99392b5ca7
Merge pull request #13544 from amosbird/mdha
...
Multi-Disk auto-recovery.
2022-02-01 06:13:26 +03:00