Commit Graph

103831 Commits

Author SHA1 Message Date
Azat Khuzhin
81be20edfe Fix double-free in HashTable::clearAndShrink() with zero elements in it
Before this patch HashTable::clearAndShrink() did this:

    destroyElements();
    clearHasZero();

While destroyElements() already destroys the zero element, so it leads
to double free, like here [1].

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/40003/f09e956ddf150c1aceb210348544bc28876a2d11/stateless_tests__asan__[2/4].html

The issue is only for complex types.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-16 15:22:00 +01:00
Dan Roscigno
647077a4b0
Merge pull request #44229 from gingerwizard/cross-link-docs
cross link dictionaries + udf posts
2022-12-16 09:19:31 -05:00
Azat Khuzhin
53bac4de71 tests/perf: fix dependency check during DROP
CI [1]:

    DB::Exception: Cannot drop or rename default.hierarchical_dictionary_source_table, because some tables depend on it: default.hierarchical_hashed_array_dictionary, default.hierarchical_flat_dictionary, default.hierarchical_hashed_dictionary. Stack trace:

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/44256/8e67a361a8f14abec6717af09ee997eb25151685/performance_comparison_[1/4]/report.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-16 15:15:15 +01:00
avogar
4a51bdce86 Fix comments 2022-12-16 13:58:54 +00:00
Anton Popov
8b9b8b083c
Merge pull request #43726 from CurtizJ/optimize-storage-s3
Improve performance of storage `S3` with large number of small files
2022-12-16 14:38:10 +01:00
serxa
d4e25e0751 more fixes 2022-12-16 13:25:26 +00:00
Kruglov Pavel
3fad5c7f1f
Merge branch 'master' into refactor-schema-inference 2022-12-16 14:24:51 +01:00
Mikhail f. Shiryaev
ab0aab2c15
Fix false success rerun on similar prefix for another builds 2022-12-16 14:23:31 +01:00
Dan Roscigno
6d8df98431
Merge branch 'master' into cross-link-docs 2022-12-16 08:23:28 -05:00
avogar
59120f61d9 Better test 2022-12-16 13:17:21 +00:00
avogar
66c7018264 Merge branch 'fix-fuzz' of github.com:Avogar/ClickHouse into fix-fuzz 2022-12-16 13:16:12 +00:00
kssenii
3076b287c7 Fix tests 2022-12-16 13:16:25 +01:00
Dale Mcdiarmid
1f5e6799ec revert contents change 2022-12-16 12:03:57 +00:00
Dale Mcdiarmid
8e84928f18 Merge branch 'cross-link-docs' of github.com:gingerwizard/ClickHouse into cross-link-docs 2022-12-16 12:01:58 +00:00
Mikhail f. Shiryaev
980d5ce289
Merge pull request #44309 from ClickHouse/auto/v22.9.7.34-stable
Update version_date.tsv and changelogs after v22.9.7.34-stable
2022-12-16 13:01:57 +01:00
Dale Mcdiarmid
ba52210124 revert format issue 2022-12-16 12:00:12 +00:00
robot-clickhouse
9e7d8d2a6f Update version_date.tsv and changelogs after v22.9.7.34-stable 2022-12-16 11:57:24 +00:00
Maksim Kita
97e83eb53c
Merge pull request #44230 from kitaisreal/analyzer-storage-view-crash-fix
Analyzer storage view crash fix
2022-12-16 13:54:16 +03:00
Maksim Kita
52ad726124 Analyzer StorageView crash fix 2022-12-16 11:53:26 +01:00
Antonio Andelic
372c187773 Correctly compare get result 2022-12-16 09:48:47 +00:00
Robert Schulze
44fa78e742
Merge pull request #44122 from azat/build/toolchain-quirks
Avoid loading toolchain files multiple times
2022-12-16 10:22:52 +01:00
Kseniia Sumarokova
a9abd843e4
Merge pull request #44195 from ClickHouse/kssenii-patch-6
Try fix flaky 01072_window_view_multiple_columns_groupby
2022-12-16 10:21:19 +01:00
Kseniia Sumarokova
12153a8cff
Merge branch 'master' into kssenii-patch-6 2022-12-16 10:20:23 +01:00
Kseniia Sumarokova
ca76d2fbde
Merge pull request #44268 from kssenii/fix-logical-error-with-persistent-files-in-cache
Fix possible logical error in cache if `do_not_evict_index_and_mrk_files=1`
2022-12-16 10:11:24 +01:00
Kseniia Sumarokova
8e1e431316
Merge pull request #44204 from kssenii/use-new-named-collections-code
Apply new code of named collections (from #43147) to external table engines part 1
2022-12-16 10:09:01 +01:00
Anton Popov
b7e76e3539 do not hold data parts during insert 2022-12-15 23:57:10 +00:00
Kseniia Sumarokova
8d8def63d5
Update 02503_cache_on_write_with_small_segment_size.sh 2022-12-15 22:41:02 +01:00
Kseniia Sumarokova
d3fed3b96a
Update storage_conf.xml 2022-12-15 22:40:04 +01:00
Mikhail f. Shiryaev
d250b00a60
Merge pull request #44275 from ClickHouse/22.13-prepare
Update version after release
2022-12-15 22:15:46 +01:00
Nikolay Degterinsky
1861e670e9
Merge branch 'master' into fix_settings_constraints 2022-12-15 21:54:02 +01:00
avogar
b7b7579eea Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-fuzz 2022-12-15 20:33:13 +00:00
Kruglov Pavel
29407a2292
Try fix tests 2022-12-15 21:32:28 +01:00
Alexander Tokmakov
be5a294aef
Merge pull request #44272 from ClickHouse/tavplubix-patch-1
Fix deadlock in StorageSystemDatabases
2022-12-15 23:13:28 +03:00
avogar
cfcb444699 Merge branch 'master' of github.com:ClickHouse/ClickHouse into better-capn-proto 2022-12-15 20:04:43 +00:00
Kruglov Pavel
25f199dd89
Merge pull request #43332 from Avogar/csv-custom-delimiter
Improve reading CSV field in CustomSeparated/Template format
2022-12-15 21:03:29 +01:00
Dmitry Novik
12be51b416 Fix FunctionNode::getResultType usage 2022-12-15 19:47:35 +00:00
Alexander Tokmakov
4588962661
Merge branch 'master' into tavplubix-patch-1 2022-12-15 22:28:01 +03:00
Mikhail f. Shiryaev
1b4859ff54
Merge pull request #44273 from ClickHouse/fix-mark-release-ready
Get rid of global Git object
2022-12-15 19:59:19 +01:00
kssenii
dfefd8dfcd Fix write-throw-cache possible write finish 2022-12-15 19:58:54 +01:00
Mikhail f. Shiryaev
c80781411f
Merge pull request #44281 from ClickHouse/auto/v22.12.1.1752-stable
Update version_date.tsv and changelogs after v22.12.1.1752-stable
2022-12-15 18:52:05 +01:00
Nikita Taranov
7058a5e7ed impl 2022-12-15 18:37:04 +01:00
Zhiguo Zhou
8b20e9f505
Vectorize AssociativeGenericApplierImpl::apply (#43669)
* Vectorize AssociativeGenericApplierImpl::apply

This commit achieved the auto-vectorization by redefining numerical
values of ternary representations and corresponding implementations
of And/Or operators, caching the intermediate ternary values in a
continuous range of memory for the SIMD instructions to consume,
and removing the short-circuit for the ternary logic evaluation.

* Optimize TernaryValueBuilder for ColumnNullable

The numerical representation of a ColumnNullable is calculated from
the data column of any data type and the null map column of UInt8
with a bitwise operation expression, which is efficient for auto-
vectorization. However, when this expression is applied to a data
column of a type other than UInt8, the SIMD register is not fully
utilized due to the mismatch of data types, and the data throughput
regresses.

To optimize the SIMD register usage, the has_value flag is firstly
evaluated from the data column and stored in a UInt8 array. Then it
is loaded from memory before the calculation of bitwise operation
expression, so that the types of the operands are both UInt8.
2022-12-15 18:27:19 +01:00
Nikolai Kochetov
e99849d031
Merge pull request #38953 from ClickHouse/add-allocation-ptr-to-trace-log
Track allocation ptr in system.trace_log. Add aggregate function flamegraph
2022-12-15 18:16:05 +01:00
robot-clickhouse
f4fbdfa93d Update version_date.tsv and changelogs after v22.12.1.1752-stable 2022-12-15 17:07:16 +00:00
Dmitry Novik
7ad3ff8a9e
Merge pull request #44244 from ClickHouse/part-log-removal-info
Add more information about part removal into system.parts table
2022-12-15 18:06:55 +01:00
Mikhail f. Shiryaev
8a145f7000
Update version to 22.13.1.1 2022-12-15 18:00:42 +01:00
Kseniia Sumarokova
d211ec943b
Merge branch 'master' into kssenii-patch-6 2022-12-15 17:54:14 +01:00
Mikhail f. Shiryaev
3907b64d09
Get rid of global Git object 2022-12-15 17:43:48 +01:00
Alexander Tokmakov
bd8b272ea4
Merge pull request #44233 from ClickHouse/threads-in-overcommit-tracker-metric
Add ThreadsInOvercommitTracker metric
2022-12-15 19:23:21 +03:00
Alexander Tokmakov
ec36ce7bb3
Merge branch 'master' into threads-in-overcommit-tracker-metric 2022-12-15 19:18:03 +03:00