Commit Graph

1458 Commits

Author SHA1 Message Date
alexey-milovidov
ac6deaf8ec
Merge pull request #11036 from excitoon-favorites/s3fixes
Fixed parsing of S3 URL
2020-05-23 17:06:59 +03:00
alexey-milovidov
1d0043892b
Merge pull request #11155 from azat/dist-logging
Add table name into logs for StorageDistributed
2020-05-23 16:53:41 +03:00
alexey-milovidov
34eb533842
Merge pull request #10981 from g-arslan/master
Try to remove redundant data move in radix sort
2020-05-23 15:55:35 +03:00
Azat Khuzhin
0e12edb895 Fix max_threads simple query optimization for SELECT with subqueries
Fixes: 01245_limit_infinite_sources
2020-05-23 15:14:27 +03:00
Alexey Milovidov
2df7813177 Whitespaces 2020-05-23 14:52:45 +03:00
Alexey Milovidov
3e87b5fe72 Remove old TODO 2020-05-23 14:50:21 +03:00
Alexey Milovidov
8c63886ba6 Added a comment 2020-05-23 14:26:40 +03:00
Alexey Milovidov
6f39ac27d1 Comments and clarifications 2020-05-23 14:04:29 +03:00
Alexey Milovidov
3b7088262f Comments and clarifications 2020-05-23 14:03:21 +03:00
Alexey Milovidov
146d8253ce Comments and clarifications 2020-05-23 13:57:30 +03:00
Alexey Milovidov
f14b5c02e2 Added a comment 2020-05-23 13:41:49 +03:00
Azat Khuzhin
d4804e070f Do not reserve extra threads after max threads optimization for simple queries
Before this patch pipeline.setMaxThreads() was called with 0 (since
streams.size() == 0, while pipes.size() == 1), which leads that
pipeline.getMaxThreads() returns max_streams.

While this threads were not used, they were reserved, which should not
happens either.
2020-05-23 13:19:09 +03:00
Azat Khuzhin
bc4b75dead Add table name into logs for StorageDistributed 2020-05-23 11:57:14 +03:00
Nikita Orlov
09255b7c46
issue-7224 Codestyle changes 2020-05-23 02:37:14 +03:00
Alexey Milovidov
91b8659b4d Avoid data movement 2020-05-23 02:14:14 +03:00
Alexey Milovidov
ba5d0a9793 Avoid virtual calls 2020-05-23 01:40:00 +03:00
Nikita Orlov
dffd15f643
issue-7224 Add failed Insert and Select query counters to ProfileEvents 2020-05-23 01:00:15 +03:00
Alexey Milovidov
d2cd941f47 Changed strategy to "Franklin" 2020-05-23 00:47:31 +03:00
Alexey Milovidov
5e21a06559 Added bounding box 2020-05-23 00:36:44 +03:00
Alexey Milovidov
4deb69599e Improve performance for non-const polygons 2020-05-23 00:27:06 +03:00
Alexey Milovidov
84dd802ba9 Improve performance for non-const polygons 2020-05-23 00:23:49 +03:00
Alexey Milovidov
a39f1d8bdc Preparation 2020-05-22 23:29:28 +03:00
Alexey Milovidov
ad54b83563 Fix clang-tidy 2020-05-22 22:58:08 +03:00
Alexey Milovidov
a309e1050a Finally fix performance issue 2020-05-22 22:54:16 +03:00
Alexey Milovidov
3f31f2b9e2 Replace polygon key to hash for simplicity 2020-05-22 22:37:56 +03:00
Alexey Milovidov
de83c1129f Better "serialize" function for polygons 2020-05-22 22:27:38 +03:00
Alexey Milovidov
902fc8dd82 Fix outstandingly wrong code from #10623 2020-05-22 22:15:29 +03:00
alesapin
cd83ebc599
Merge pull request #11106 from ClickHouse/fix_deadlock_system_logs_startup
Fix deadlock in system tables during server startup
2020-05-22 20:53:07 +03:00
alesapin
e971ff627e Fix gcc-9 build 2020-05-22 17:39:49 +03:00
Alexander Tokmakov
ac54d470da Merge branch 'master' into merging_external_source_cassandra 2020-05-22 17:27:40 +03:00
Alexey Milovidov
4dd2015056 Preparation 2020-05-22 17:21:49 +03:00
Alexander Tokmakov
e6ca09e134 fix build 2020-05-22 17:19:33 +03:00
Alexey Milovidov
a9b3de8542 Remove excessive memory allocations 2020-05-22 17:07:17 +03:00
Alexey Milovidov
07a65c3090 Do not validate polygons in non-constant case 2020-05-22 16:50:12 +03:00
alesapin
a935db4169
boop CI 2020-05-22 15:34:26 +03:00
Vitaly Baranov
5a0f356cd6
Merge pull request #11038 from Enmk/parseDateTime64BestEffort_fix
Fixed parseDateTime64BestEffort implementation
2020-05-22 14:40:39 +03:00
alexey-milovidov
10fd2dd17d
Merge pull request #11118 from ClickHouse/aku/trace-log-overflow-followup
A follow-up for trace log overflow in perftests
2020-05-22 14:29:11 +03:00
alexey-milovidov
e5808c6f2f
Merge pull request #11122 from ClickHouse/aku/addr2line
Remove extra copying from addressToLine
2020-05-22 14:16:46 +03:00
alexey-milovidov
b82c633716
Merge pull request #11048 from filimonov/kafka_missed_data_during_drop
Fixes the potential missed data during termination of Kafka engine table
2020-05-22 14:11:10 +03:00
alesapin
f4b0d475af Fix system.tables output 2020-05-22 14:04:15 +03:00
alesapin
70fe119426 Add clear names 2020-05-22 13:33:57 +03:00
alesapin
98ffefd90c Fix bug with return type 2020-05-22 13:09:24 +03:00
Vladimir Chebotarev
98f31374d5 Added improved S3 URL parsing to DiskS3. 2020-05-22 11:18:34 +03:00
alesapin
cbcdb6219e Slighty more verbose comment 2020-05-22 11:17:57 +03:00
Vladimir Chebotarev
02cb08ea2f Fixed parsing of S3 URL. 2020-05-22 11:17:10 +03:00
alesapin
b9dfa61774
Merge pull request #11042 from CurtizJ/modify-ttl
Apply TTL for old data, after ALTER MODIFY TTL query
2020-05-22 11:12:14 +03:00
Nikolai Kochetov
f7456f8320
Merge pull request #11004 from ClickHouse/remove-experimental-use-processors-flag-2
Remove allow_processors flag from executeQuery()
2020-05-22 10:47:15 +03:00
Alexander Kuzmenkov
322d731d28 Remove extra copying from addressToLine
The line is already serialized to the same arena, so there is no need to
copy it. Also add this function to query profiler test, so that it has
some coverage.
2020-05-22 03:01:35 +03:00
Alexander Kuzmenkov
087d8ab020 A follow-up for trace log overflow in perftests
The start was in https://github.com/ClickHouse/ClickHouse/pull/11026
It turned out that the problem was due to the incorrect mutate()
implementation that lead to quadratic amount of column copying. This
problem has since been fixed.

Remove the excessively verbose logging, and also change appendToBlock of
LogElement's to accept mutable columns instead of accepting a block and
mutating it on each call. It looks wasteful, even though it is almost a
noop.
2020-05-21 23:40:23 +03:00
Alexander Kuzmenkov
fecd84d3c0
Merge pull request #10915 from ClickHouse/aku/mongodb-uri
Support MongoDB URI
2020-05-21 23:02:12 +03:00
alesapin
59b3bc0c05
Merge branch 'master' into fix_deadlock_system_logs_startup 2020-05-21 22:57:52 +03:00
Nikolai Kochetov
c81dd49686 Try fix build. 2020-05-21 22:55:27 +03:00
alesapin
09034157cd Remove comments 2020-05-21 22:53:46 +03:00
alesapin
327d17ac6a Better 2020-05-21 22:46:03 +03:00
alesapin
41914588fd More clear 2020-05-21 22:07:18 +03:00
alesapin
1906762119
Merge pull request #11109 from ClickHouse/less_verbose_logging
Less verbose logging in mutation finalization task
2020-05-21 21:53:08 +03:00
alesapin
37fa26971e
boop ci 2020-05-21 21:49:31 +03:00
alexey-milovidov
655b8e1903
Merge pull request #11021 from ClickHouse/fix_10557
Remove data on DROP DATABASE for DatabaseMemory
2020-05-21 20:17:46 +03:00
Nikolai Kochetov
adfa77be9d Added another one comment. 2020-05-21 20:07:22 +03:00
Alexander Kuzmenkov
f98ffdbc4c
Merge pull request #11087 from azat/context-fwd-decl
[RFC] Forward declaration for Context as much as possible.
2020-05-21 19:43:29 +03:00
alesapin
87eab514fb Merge branch 'master' into consistent_metadata 2020-05-21 18:54:52 +03:00
alesapin
5676340f6b Less verbose logging in mutation finalization task 2020-05-21 18:52:11 +03:00
Alexander Tokmakov
f40fadc3d6 fix segfault 2020-05-21 18:29:18 +03:00
Vasily Nemkov
403aae9126 Fixed parseDateTime64BestEffort implementation
Fixed argument resolution issues.
Added tests and made sure -orNull and -orZero variants alwo work correctly.
2020-05-21 17:21:39 +03:00
alesapin
c036af0261 Fix deadlock after clickhouse-server update (with changes in one of system log tables structure) during startup between concurrent merge and table rename. 2020-05-21 17:11:56 +03:00
g-arslan
9e350bea33 replace shift array with std::rotate 2020-05-21 17:10:47 +03:00
alexey-milovidov
b480f137f3
Merge pull request #10623 from livace/master
Add point in polygon for non-const polygons
2020-05-21 15:18:24 +03:00
alexey-milovidov
765510d5c3
Merge pull request #10991 from ClickHouse/enable-clang-tidy-for-programs-and-utils
Enable clang-tidy for programs and utils
2020-05-21 15:12:07 +03:00
Alexey Milovidov
581b2358de Added comment 2020-05-21 15:07:12 +03:00
Alexey Milovidov
3c763908c3 Added comment 2020-05-21 15:04:15 +03:00
Alexey Milovidov
6669607e17 Merge branch 'master' into vectorize-sum 2020-05-21 15:02:51 +03:00
g-arslan
3267eaa498 fix style 2020-05-21 15:00:55 +03:00
g-arslan
b88d0dec1c some little improvements 2020-05-21 15:00:55 +03:00
g-arslan
c01a7ef0e2 Implement reverse in radix sort, fix style, fix build 2020-05-21 15:00:55 +03:00
g-arslan
95668def24 Try to remove redundant data move in radix sort 2020-05-21 15:00:55 +03:00
Nikolai Kochetov
d6ce1ed7b9 Added comments. 2020-05-21 14:54:26 +03:00
alexey-milovidov
c1b5d799ee
Merge pull request #11025 from ClickHouse/add-nchar-nvarchar
Add NCHAR and NVARCHAR synonims
2020-05-21 14:05:11 +03:00
Nikolai Kochetov
986dfe79a5
Merge pull request #10858 from azat/min_mv_insert_block_size
[RFC] Introduce min_insert_block_size_{rows,bytes}_for_materialized_views (for MVs)
2020-05-21 12:52:58 +03:00
Alexey Milovidov
2fa264d83e Fix style #10591 2020-05-21 12:46:00 +03:00
alexey-milovidov
b6b62dbdbc
Merge pull request #10591 from excitoon-favorites/ttl_introspection
Added `move_ttl_info` to `system.parts`
2020-05-21 12:43:49 +03:00
alexey-milovidov
4a237faede
Merge pull request #11074 from Jokser/memory-leak-in-register-disk-s3
Fix memory leak in registerDiskS3
2020-05-21 12:42:46 +03:00
Nikolai Kochetov
37e5da737c Fix ya.make. 2020-05-21 12:27:55 +03:00
BohuTANG
c9d315654c Fix Storages/MergeTree typo 2020-05-21 17:00:44 +08:00
Nikolai Kochetov
cfef21be86 Fix build. 2020-05-21 11:54:41 +03:00
Nikolai Kochetov
adac47a845 Fix build. 2020-05-21 10:47:38 +03:00
Nikolai Kochetov
f6d5961915 Fix build. 2020-05-21 10:40:01 +03:00
Nikolai Kochetov
6efc51335a Fix build. 2020-05-21 10:31:43 +03:00
Azat Khuzhin
d93b9a57f6 Forward declaration for Context as much as possible.
Now after changing Context.h 488 modules will be recompiled instead of 582.
2020-05-21 01:53:18 +03:00
Alexander Tokmakov
31b6f5f0d2 Merge branch 'master' into merging_external_source_cassandra 2020-05-20 23:44:53 +03:00
Alexander Tokmakov
4b30b3168c try fix build 2020-05-20 23:26:39 +03:00
Nikolai Kochetov
bcd38ac207 Fix build. 2020-05-20 22:08:20 +03:00
Alexander Kuzmenkov
9e410444e7 Better error messages about joins 2020-05-20 21:58:20 +03:00
Nikolai Kochetov
6f50700f35 Add PullingOutputFormat and PullingPipelineExecutor. 2020-05-20 21:53:18 +03:00
alexey-milovidov
07924f0ae1
Merge pull request #11029 from azat/system_tables_lazy_load
Disable system_tables_lazy_load by default
2020-05-20 21:15:09 +03:00
alesapin
616902a995 Sorting and primary key (broken) 2020-05-20 21:11:38 +03:00
Pavel Kovalenko
d98c1589ed Better error handling in Proxy Resolver. 2020-05-20 19:01:05 +03:00
Pavel Kovalenko
138154ba6a Fix memory-leak in registerDiskS3 during config->createView invocations. 2020-05-20 18:42:45 +03:00
alesapin
9fb28f5ac0 Add sampling key 2020-05-20 18:16:39 +03:00
Nikolai Kochetov
fcf58fa4a1 Fix clang build. 2020-05-20 17:04:24 +03:00
Anton Popov
d62fe980ef Merge remote-tracking branch 'upstream/master' into modify-ttl 2020-05-20 16:52:30 +03:00
alesapin
8bc527eecd Compile partition key 2020-05-20 15:16:55 +03:00
Vitaly Baranov
06d18a4378
Merge pull request #11050 from vitlibar/amosbird_betterdictget
dictGet with table name
2020-05-20 14:18:24 +03:00
alexey-milovidov
da33858d39 Update StorageSystemParts.cpp 2020-05-20 14:07:31 +03:00
Vladimir Chebotarev
02b52df86d Added delete_ttl_info_min and delete_ttl_info_max to system.parts. 2020-05-20 14:07:31 +03:00
Vladimir Chebotarev
6f68979662 Switched system.parts.move_ttl_info to separate arrays. 2020-05-20 14:07:31 +03:00
Vladimir Chebotarev
3ed5d9434a Added move_ttl_info to system.parts. 2020-05-20 14:07:31 +03:00
Artem Zuikov
9b38324028
fix JOIN with PREWHERE with second analyze() (#11051) 2020-05-20 12:29:23 +03:00
Mikhail Filimonov
e8a13842af Better fix, previous fix was wrong (was leaving the cycle by eof condition) 2020-05-20 11:02:02 +02:00
alesapin
dc330ca7cb
Merge pull request #11037 from ClickHouse/alter_rename_and_modify
Fix alter rename with different types of alter
2020-05-20 11:28:13 +03:00
Nikolai Kochetov
7ba5419190 Update PipelineExecutor. 2020-05-19 23:24:06 +03:00
Alexander Kuzmenkov
bc34e0ff94 fixup 2020-05-19 23:12:10 +03:00
Vitaly Baranov
57bd7afc03 Fix passing dictionary's name to dictGet() with alias. 2020-05-19 21:17:29 +03:00
Amos Bird
ce3c53a00a dictGet* with table name 2020-05-19 20:33:45 +03:00
Mikhail Filimonov
34198336ed Style 2020-05-19 19:02:37 +02:00
Mikhail Filimonov
b50480cbde Fixes the potential missed data during termination of Kafka engine table 2020-05-19 18:55:37 +02:00
alesapin
7d382cc7b5 Return missed command 2020-05-19 19:03:10 +03:00
Nikolai Kochetov
6109e87aed Try fix compatibility. 2020-05-19 18:40:15 +03:00
Nikolai Kochetov
c147badf4f Merge remote-tracking branch 'upstream/master' into min_mv_insert_block_size 2020-05-19 18:24:21 +03:00
Alexander Kuzmenkov
ef6f386ee6
Merge pull request #11026 from ClickHouse/aku/trace-log
Add more logs to debug trace_log overflow
2020-05-19 17:56:06 +03:00
Alexander Kuzmenkov
838b3e9533 fixup 2020-05-19 17:55:27 +03:00
Nikolai Kochetov
b0d9552e1e Try fix compatibility. 2020-05-19 17:06:33 +03:00
Anton Popov
35b916433a fix TTL with defaults after modify 2020-05-19 16:06:35 +03:00
alesapin
4906dbef41 Remove redundant logs 2020-05-19 13:46:56 +03:00
alesapin
2b37a418f2 More clear logic 2020-05-19 13:44:53 +03:00
alesapin
a416813597
Merge pull request #10777 from NanoBjorn/refactor-reservations
VolumePtr instead of DiskPtr in MergeTreeData*
2020-05-19 13:27:11 +03:00
alesapin
111c576579 Slightly less garbage 2020-05-19 13:03:05 +03:00
alesapin
70e5553204 At least something works 2020-05-19 12:54:56 +03:00
Gleb Novikov
665c6b7f59 Added new files to ya make 2020-05-19 12:38:43 +03:00
Nikolai Kochetov
daa519a654 Fix ya.make 2020-05-19 12:04:56 +03:00
Alexander Tokmakov
175b7aedf3 Merge branch 'master' into merging_external_source_cassandra 2020-05-19 05:21:27 +03:00
Anton Popov
58ed04dc24 materialize TTL after its modifying 2020-05-19 04:53:01 +03:00
Azat Khuzhin
e1fbf82d0c Disable system_tables_lazy_load by default
Refs: #9642
Refs: #10359
2020-05-19 02:41:18 +03:00
Artem Zuikov
97c7447130
Bitonic sort improvements (#10934) 2020-05-19 00:41:23 +03:00
Nikolai Kochetov
075ccceee9 Fix tests. 2020-05-19 00:38:28 +03:00
Nikolai Kochetov
0ec321a811 Fix ya.make 2020-05-19 00:01:33 +03:00
Alexander Kuzmenkov
a54773f947 Add more logs to debug trace_log overflow 2020-05-18 22:33:12 +03:00
Alexey Milovidov
08ff5b5966 Add NCHAR and NVARCHAR synonims 2020-05-18 22:13:13 +03:00
Nikolai Kochetov
4ce0ef6055 Fix tests. 2020-05-18 21:40:01 +03:00
Nikolai Kochetov
0ce9afd1e3 Try fix tests. 2020-05-18 19:19:43 +03:00
Nikolai Kochetov
deeae66455 Fix clang build. 2020-05-18 18:52:00 +03:00
Nikolai Kochetov
0e48cb1f80 Removed allow_processors flag from executeQuery(). 2020-05-18 16:55:07 +03:00
Alexander Tokmakov
6af9c78476 remove data on DROP DATABASE 2020-05-18 16:51:01 +03:00
alesapin
bec7d1ce93
Fix style check 2020-05-18 16:49:19 +03:00
Artem Zuikov
bfcbc08bba arcadia sync fixes 2020-05-18 15:50:23 +03:00
Nikita Mikhaylov
ebce2c7e7c only style changes 2020-05-18 14:38:22 +03:00
Artem Zuikov
62f77abbc5 add file to ya.make 2020-05-18 13:40:02 +03:00
Artem Zuikov
fcaee7dc98 add file to ya.make 2020-05-18 13:37:13 +03:00
Artem Zuikov
0fe723acc9
Try to fix arcadia sync (#10959) 2020-05-18 13:26:23 +03:00
Vasily Morozov
4688729396 fix 2020-05-18 13:16:50 +03:00
Vasily Morozov
876fff1938 fix build and style 2020-05-18 13:16:49 +03:00