- We previously compiled libcxx with _LIBCPP_DEBUG=0. In old libcxx
versions, this (surprisingly) enabled the basic debug mode [1].
- In libcxx 15 (the version we are currently using), _LIBCPP_DEBUG=0
does nothing [2], the replacement is _LIBCPP_ENABLE_DEBUG_MODE=1.
- The debug mode is only enabled in Debug builds. Their docs say the
extra check change complexity guarantees + the asserts crash which we
don't want in Release builds. The debug mode detects issues like in
[3]. Crashes look like this (for example)
```
/data/ch/contrib/llvm-project/libcxx/include/__iterator/wrap_iter.h:99: assertion ::std::__libcpp_is_constant_evaluated() || (__get_const_db()->__dereferenceable(this)) failed: Attempted to increment a non-incrementable iteratorAborted (core dumped)
```
- I had to mute some new clang-tidy warnings in places that deal with
container iterators. They got heavier and copy-by-value now yields a
warning, e.g.
for (auto it : iterators) /// <-- warning
[...]
[1] https://releases.llvm.org/12.0.0/projects/libcxx/docs/DesignDocs/DebugMode.html
[2] https://releases.llvm.org/15.0.0/projects/libcxx/docs/DesignDocs/DebugMode.html
[3] https://github.com/llvm/llvm-project/blob/main/libcxx/test/support/container_debug_tests.h
This will fix with issues like this [1]:
Aug 12 09:58:44 '/usr/bin/cmake' '--build' '/build/build_docker/native' '--target' 'pre_compressor'
Aug 12 09:58:44 sccache: error: Server startup failed: cache storage failed to read: Unexpected (temporary) at stat
Aug 12 09:58:45 ninja: build stopped: subcommand failed.
Aug 12 09:58:45 -- Configuring done (77.7s)
Aug 12 09:58:47 -- Generating done (1.8s)
Aug 12 09:58:47 -- Build files have been written to: /build/build_docker
So as you can see even if ninja fails it still wrote build files, while
it should fail.
[1]: https://s3.amazonaws.com/clickhouse-test-reports/64955/0af41e32a5822d25ac3760f1ebb2313557474701/builds/report.html
[2]: 0af41e32a5/binary_darwin_aarch64/build_log.log
Note, COMMAND_ERROR_IS_FATAL is 3.19+, and the requirement for now is
3.20
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
