Commit Graph

1639 Commits

Author SHA1 Message Date
Nikolai Kochetov
c509ba6919 Added test. 2020-07-28 15:29:49 +03:00
alexey-milovidov
7a22717180
Merge pull request #12760 from ClickHouse/sticky_mutations_bug
Sticking mutations bug
2020-07-28 14:42:54 +03:00
Nikolai Kochetov
f047194e11 Added test. 2020-07-28 13:45:10 +03:00
Nikita Mikhaylov
89d2bbed44
Merge pull request #12327 from achimbab/bayesAB
Add bayesAB function for bayesian_ab_testing
2020-07-28 13:18:26 +03:00
Nikolai Kochetov
1f2390b65e
Merge pull request #12840 from ClickHouse/remove-wrong-threads-limiting
Remove thread limiting.
2020-07-28 12:03:07 +03:00
alesapin
ef305b8b7e
Merge pull request #12951 from ClickHouse/clear_column_in_pk
Add tests for primary key clear column
2020-07-28 11:38:00 +03:00
alexey-milovidov
795c09fdbb
Merge pull request #12662 from ildus/simple_aggr_for_minmap_maxmap
Add minMap and maxMap support to SimpleAggregateFunction
2020-07-28 00:03:34 +03:00
Alexey Milovidov
d223c6802c Add missing file 2020-07-27 23:41:20 +03:00
Alexey Milovidov
ec84ed30cb Merge branch 'master' into prevent-inconsistent-merge-tree-settings 2020-07-27 21:39:25 +03:00
alesapin
0ba8ce2d25 Add tests for primary key clear column 2020-07-27 19:16:43 +03:00
Anton Ivashkin
89a59d43f2 Merge 2020-07-27 17:59:12 +03:00
Nikolai Kochetov
a59e1c2f71 Added a test. 2020-07-27 17:46:57 +03:00
nikitamikhaylov
4d8a00d25e Merge branch 'master' of github.com:ClickHouse/ClickHouse into achimbab-bayesAB 2020-07-27 17:13:27 +03:00
jakalletti
7f853c2a56 fix arcadia 2020-07-27 17:10:57 +03:00
alexey-milovidov
7dac65ce0f
Merge pull request #12659 from zhang2014/fix/ISSUES-10572
ISSUES-10572 fix bloom filter with const column
2020-07-27 14:38:56 +03:00
alesapin
e0bf5913e7 Fix sticking mutations 2020-07-26 17:21:57 +03:00
Alexander Tokmakov
6bfe88e83f Merge branch 'master' into database_atomic_improvements 2020-07-26 13:40:05 +03:00
alesapin
78d357f0d2 Add a test for sticking mutations bug 2020-07-25 17:42:20 +03:00
Azat Khuzhin
500509d9ed Add a test for CAST(Nullable(String), Enum()) 2020-07-24 20:45:07 +03:00
Nikolai Kochetov
0320b05408
Merge pull request #12746 from ClickHouse/add-test-extra-overflow-row
Added test with extra overflow row.
2020-07-24 15:29:52 +03:00
Winter Zhang
50203a5dc0
ISSUES-12293 allow push predicate when subquery contains with clause (#12663) 2020-07-24 12:00:18 +03:00
Nikolai Kochetov
a8970150b5 Added test with extra overflow row. 2020-07-24 12:00:05 +03:00
Alexey Milovidov
9bbcb67dac Merge branch 'master' into prevent-inconsistent-merge-tree-settings 2020-07-23 23:34:51 +03:00
alexey-milovidov
e7ec08615e
Merge pull request #12727 from ClickHouse/add-test-for-alter-after-freeze
Add a test for ALTER after FREEZE
2020-07-23 23:33:46 +03:00
Artem Zuikov
2041d7d0d8
Fix move_functions_out_of_any optimisation with lambda (#12664) 2020-07-23 18:15:22 +03:00
philip.han
b71fe9dab9 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into bayesAB 2020-07-23 22:21:15 +09:00
Alexey Milovidov
16f558b642 Added failing test 2020-07-23 15:37:20 +03:00
Alexey Milovidov
068905dd2d Add a test for ALTER after FREEZE #7733 2020-07-23 15:07:49 +03:00
alexey-milovidov
456bf4461b
Merge branch 'master' into br1 2020-07-23 13:26:41 +03:00
alesapin
6fdcb59df7 Merge branch 'master' into forward_alter_error_to_client 2020-07-23 10:48:58 +03:00
alesapin
c83bf1ab74
Revert "Refactor joinGet and implement multi-key lookup." 2020-07-23 10:47:17 +03:00
Alexander Tokmakov
237accd154 Merge branch 'master' into database_atomic_improvements 2020-07-23 06:33:20 +03:00
Anton Popov
fc515728f4 fix performance with large tuples, which are interpreted as functions in IN section 2020-07-23 02:33:14 +03:00
alexey-milovidov
004481f98b
Merge pull request #12418 from amosbird/jgmk
Refactor joinGet and implement multi-key lookup.
2020-07-22 21:44:24 +03:00
alexey-milovidov
f75c242491
Merge pull request #12653 from zhang2014/feature/truncate_without_table
ISSUES-4006 support truncate table without table keyword
2020-07-22 21:43:04 +03:00
alesapin
8c8bdd5070 Fix tests and work with multiple mutations 2020-07-22 18:19:54 +03:00
Nikolai Kochetov
76d784be9c
Merge pull request #12613 from ClickHouse/remove-sort-description-from-streams
Remove sort description from streams
2020-07-22 17:35:05 +03:00
Vitaly Baranov
0093425201 CREATE USER IF NOT EXISTS now doesn't throw exception if the user exists. 2020-07-22 16:41:42 +03:00
alexey-milovidov
7935b6a9f7
Merge pull request #12635 from ClickHouse/alter_non_metadata
Add setting allow_non_metadata_alters
2020-07-22 16:29:14 +03:00
alesapin
de846e5e3c Forward exception to client during alter 2020-07-22 15:36:19 +03:00
Ildus Kurbangaliev
0d82c02710 add minMap and maxMap support to SimpleAggregateFunction 2020-07-22 12:21:10 +02:00
zhang2014
580889f1e4 ISSUES-10572 fix bloom filter with const column 2020-07-22 17:42:12 +08:00
alexey-milovidov
49adaf95aa
Merge pull request #12585 from ClickHouse/mod-compatible
Make behaviour of remainder of division for floating point numbers compatible with most of DBMS
2020-07-22 08:43:45 +03:00
alexey-milovidov
a7fcdb34db
Merge pull request #12648 from ClickHouse/if-array-uuid
Add support for function if with Array(UUID) arguments
2020-07-22 08:42:08 +03:00
alexey-milovidov
c91c8608d8
Merge pull request #12633 from ClickHouse/alter-update-cast
Fix "There is no supertype" error on ALTER UPDATE #7306
2020-07-22 08:05:23 +03:00
zhang2014
f8b6054b74 ISSUES-4006 support truncate table without table keyword 2020-07-22 13:00:02 +08:00
Alexander Tokmakov
7b20c38107 try fix sync 2020-07-22 05:30:07 +03:00
Alexander Tokmakov
9bcaaea3e0 Merge branch 'master' into database_atomic_improvements 2020-07-22 05:24:48 +03:00
Alexey Milovidov
506cc6859a Added a test #11066 2020-07-22 00:16:16 +03:00
Nikolai Kochetov
c4381e8a5d
Merge pull request #12618 from ClickHouse/fix-external-sort-pipeline-stuck
Fix external sort pipeline stuck
2020-07-21 21:54:09 +03:00
Anton Ivashkin
742793be54 Add SelectedRows and SelectedBytes events 2020-07-21 17:50:02 +03:00
alesapin
1ef39839d0 Missed tests 2020-07-21 17:06:18 +03:00
alesapin
daaa5cc382 Add setting allow_non_metadata_alters 2020-07-21 17:05:30 +03:00
Alexey Milovidov
fe5fb271dc Fix "There is no supertype" error on ALTER UPDATE #7306 2020-07-21 16:31:59 +03:00
alexey-milovidov
e4e642e24f
Merge pull request #12593 from CurtizJ/fix-any-with-aliases
Fix lack of aliases with function 'any'
2020-07-21 14:37:37 +03:00
Nikolai Kochetov
3e4ed80ae7 Add test. 2020-07-21 12:24:06 +03:00
alexey-milovidov
16e8c61438
Merge pull request #12566 from ClickHouse/race_condition_cache_dictionaries
Fix race condition in clickhouse cache dictionary
2020-07-21 11:27:08 +03:00
Nikolai Kochetov
4ceee71d1f Added test. 2020-07-21 11:21:13 +03:00
Anton Popov
d4783f8f19 fix lack of aliases with function 'any' 2020-07-20 12:04:03 +03:00
Alexey Milovidov
a104934d2c Merge branch 'master' into deprecate-special-zero-datetime 2020-07-20 04:34:26 +03:00
Alexey Milovidov
10355a2850 Make behaviour of remainder of division for floating point numbers compatible with most of DBMS #7323 2020-07-20 04:03:46 +03:00
Alexey Milovidov
b8cc2bee53 Added a test from @ishirav #7404 2020-07-19 03:59:45 +03:00
alesapin
9ed420442d remove comment 2020-07-17 18:26:11 +03:00
alesapin
dc05fbcfb3 Race condition test 2020-07-17 18:18:52 +03:00
Alexey Milovidov
e207acf19a Merge branch 'master' into deprecate-special-zero-datetime 2020-07-17 17:06:31 +03:00
Alexander Tokmakov
c27de9b424 fixes 2020-07-17 16:11:44 +03:00
philip.han
3554e6c36a Replace vector with PODArray and add testcases 2020-07-17 21:06:29 +09:00
alexey-milovidov
51f539d3fb
Merge pull request #12480 from azat/fix-SETTINGS-parse-after-FORMAT
[RFC] Fix SETTINGS parse after FORMAT
2020-07-17 14:11:24 +03:00
Artem Zuikov
c6e3e9b1ff
String convertion to enum in if() and transform() (#12515) 2020-07-17 12:28:51 +03:00
Alexey Milovidov
f134d1d34e Remove race condition from test 2020-07-17 09:21:51 +03:00
Alexey Milovidov
601c45f4a5 Merge branch 'master' into add-test-for-lost-replicas-cleanup 2020-07-17 08:42:35 +03:00
alexey-milovidov
10e12c32cb
Merge pull request #12549 from ClickHouse/fix_ci_fest_tests
Fix ci fest tests
2020-07-17 08:01:23 +03:00
Alexander Tokmakov
a612080df1 Merge branch 'master' into database_atomic_improvements 2020-07-17 00:43:59 +03:00
Alexander Tokmakov
ebf98ba006 implement reneme dictionary query 2020-07-17 00:41:26 +03:00
Azat Khuzhin
a5887ff735 Add 01401_FORMAT_SETTINGS to arcadia_skip_list (to fix yandex sync check)
And also to trigger CI, since looks like perf tests hanged
2020-07-17 00:29:17 +03:00
Azat Khuzhin
781f1597f2 Fix SETTINGS parsing after FORMAT for SELECT queries
There are two possible ways to pass the SETTINGS clause:

  - SELECT 1 FORMAT Null SETTINGS max_block_size = 1
  - SELECT 1 SETTINGS max_block_size = 1[ FORMAT Null]

And when the SETTINGS goes after FORMAT it is parsed in
ParserQueryWithOutput, and these settings are not applied for the query
from the ASTSelectQuery::initSettings()

So propagate settings from the ParserQueryWithOutput to the
ASTSelectQuery settings.
2020-07-17 00:28:52 +03:00
alexey-milovidov
fde8c87a1f
Merge pull request #12426 from ClickHouse/log-engine-rollback-on-insert-error
Rollback insertion error in Log engines
2020-07-16 22:50:48 +03:00
Alexander Tokmakov
d10b4c504d rename database with dictionaries 2020-07-16 17:25:39 +03:00
alesapin
af5a9887e7 Better 1318 test 2020-07-16 16:20:38 +03:00
alesapin
00140286e8 Sync mutations 2020-07-16 14:44:14 +03:00
alesapin
52585d152c Fix final mark test 2020-07-16 14:40:55 +03:00
Vitaly Baranov
000b197ad1
Merge pull request #11234 from traceon/ldap-per-user-authentication
Add LDAP authentication support
2020-07-16 13:17:21 +03:00
Artem Zuikov
ff372ec0f0
Standard join type syntax position (#12520) 2020-07-16 11:56:45 +03:00
alesapin
f7792d0145
Merge pull request #12294 from ClickHouse/fasttest
Add image for fast tests run (with clone, build, etc.)
2020-07-16 11:21:53 +03:00
alexey-milovidov
8966c09ed6
Merge pull request #12519 from vzakaznikov/fix_data_duplication_and_tests_for_live_view
Fixing race condition in live view tables which could cause data duplication and live view tests
2020-07-16 11:03:28 +03:00
alexey-milovidov
6e9af5f179
Merge pull request #12529 from CurtizJ/fix-12521
Better exception for function 'in' with invalid number of arguments
2020-07-16 11:01:55 +03:00
Alexey Milovidov
eb7edf4586 Merge branch 'master' into add-test-for-lost-replicas-cleanup 2020-07-16 10:51:40 +03:00
Alexey Milovidov
3408b7e259 Merge branch 'master' into log-engine-rollback-on-insert-error 2020-07-16 05:34:02 +03:00
Alexey Milovidov
b335b1c774 Update test 2020-07-16 04:42:39 +03:00
Alexey Milovidov
7a8bd40c2c Merge branch 'master' into deprecate-special-zero-datetime 2020-07-16 03:21:21 +03:00
Denis Glazachev
59cb758cf7 Merge branch 'master' into ldap-per-user-authentication 2020-07-16 02:29:24 +04:00
alesapin
e35c49faa2 Merge branch 'master' into fasttest 2020-07-15 22:35:46 +03:00
Anton Popov
de7b0c2424 better exception for function 'in' with invalid number of arguments 2020-07-15 17:25:09 +03:00
Artem Zuikov
2ba23c0cfa
Update arcadia_skip_list.txt
hotfix
2020-07-15 16:56:13 +03:00
Artem Zuikov
9232caed07
Update arcadia_skip_list.txt
one more ignored test with dictionary
2020-07-15 16:55:51 +03:00
alesapin
ba05bb1b39 Better tests for parallel run 2020-07-15 14:47:51 +03:00
Vitaliy Zakaznikov
560151f6cd * Fix bug in StorageLiveView.cpp
* Fixing synchronization of the first insert in live view tests
2020-07-15 13:24:33 +02:00
Artem Zuikov
5f01a587f6
Optimize monotonous ORDER BY (#12467) 2020-07-15 13:10:21 +03:00
Artem Zuikov
f8229e0bf7 try fix test 2020-07-15 13:08:40 +03:00
Alexander Tokmakov
09abe71b60 Merge branch 'master' into database_atomic_improvements 2020-07-15 13:07:08 +03:00
alesapin
614540eddf
Merge pull request #12382 from ClickHouse/clear-all-columns
Better errors for CLEAR/DROP columns (possibly in partitions)
2020-07-15 12:52:06 +03:00
alexey-milovidov
a68310aab6
Merge pull request #12503 from ClickHouse/test-7754
Added a test for #7754
2020-07-15 06:25:32 +03:00
alexey-milovidov
e9bb46860d
Merge pull request #12443 from ClickHouse/negative-date-time-saturate-to-zero
Saturate negative unix timestamp to zero instead of overflow
2020-07-15 06:22:09 +03:00
Amos Bird
46c2bb57ec
Refactor joinGet and implement multi-key lookup. 2020-07-15 10:12:04 +08:00
Alexey Milovidov
36436eb703 Added a test to ensure that amount of ZooKeeper nodes do not grow in presense of lost replicas 2020-07-15 02:00:45 +03:00
Alexey Milovidov
cd7ed94a08 Added a test for #7754 2020-07-14 21:59:25 +03:00
Artem Zuikov
e8057387cb
Fix crash in 'JOIN dict ON expr(dict_key) = k' (#12458) 2020-07-14 17:06:11 +03:00
feng lv
767bc7a905 add doc
fix test

fix

name style fix
2020-07-14 18:50:51 +08:00
Artem Zuikov
dda2510208
Try enable multiple_joins_rewriter_version v2 by default (#12469) 2020-07-14 12:34:47 +03:00
Alexey Milovidov
ce1afcd39f Merge branch 'master' into negative-date-time-saturate-to-zero 2020-07-14 09:33:43 +03:00
alexey-milovidov
fd4adf27d6
Merge pull request #12456 from CurtizJ/fix-12437
Fix #12437
2020-07-14 09:28:31 +03:00
feng lv
f0b423e928 add test
style fix
2020-07-14 14:16:47 +08:00
Alexander Tokmakov
31e62e713e write uuid for ddl dictionaries 2020-07-14 00:21:01 +03:00
alesapin
1f576ee039 Some intermediate solution 2020-07-13 20:27:52 +03:00
tavplubix
3314a97b99
Merge pull request #12009 from hczhcz/patch-0628
Allow TabSeparatedRaw as an input format
2020-07-13 19:43:31 +03:00
Alexander Kuzmenkov
b656c43e93
fixup for #12427 -- max_block_size can't be zero 2020-07-13 18:25:48 +03:00
Alexander Kuzmenkov
c6ab1f61dc
Merge pull request #12427 from ClickHouse/fix-limit-overflow
Avoid overflow in LIMIT #10470 #11372
2020-07-13 18:20:21 +03:00
alesapin
1952be94ea Merge branch 'master' into clear-all-columns 2020-07-13 17:38:47 +03:00
Alexander Tokmakov
fdb02edc7c Merge branch 'master' into database_atomic_improvements 2020-07-13 17:28:48 +03:00
Alexander Tokmakov
15b395da51 fixes 2020-07-13 17:24:00 +03:00
Denis Glazachev
f787702922 Merge branch 'master' into ldap-per-user-authentication
* master: (27 commits)
  Whitespaces
  Fix typo
  Fix UBSan report in base64
  Correct default secure port for clickhouse-benchmark #11044
  Remove test with bug #10697
  Update in-functions.md (#12430)
  Allow nullable key in MergeTree
  Update arithmetic-functions.md
  [docs] add rabbitmq docs (#12326)
  Lower block sizes and look what will happen #9248
  Fix lifetime_bytes/lifetime_rows for Buffer direct block write
  Retrigger CI
  Fix up  test_mysql_protocol failed
  Implement lifetime_rows/lifetime_bytes for Buffer engine
  Add comment regarding proxy tunnel usage in PocoHTTPClient.cpp
  Add lifetime_rows/lifetime_bytes interface (exported via system.tables)
  Tiny IStorage refactoring
  Trigger integration-test-runner image rebuild.
  Delete log.txt
  Fix test_mysql_client/test_python_client error
  ...
2020-07-13 15:46:27 +04:00
Artem Zuikov
b5c181c24e
Optimize redundant functions in ORDER BY (#12404) 2020-07-13 13:34:25 +03:00
Anton Popov
a9530d2883 in-memory parts: fix reading from nested 2020-07-13 12:10:55 +03:00
alexey-milovidov
7108f88de5
Merge pull request #12424 from ClickHouse/lower-default-block-size
Lower block sizes and look what will happen
2020-07-13 05:32:25 +03:00
Alexey Milovidov
a31d8a4f5b Update tests 2020-07-13 05:26:22 +03:00
alexey-milovidov
ae7eff98ed
Merge pull request #12433 from amosbird/np
Allow nullable key in MergeTree
2020-07-13 04:36:00 +03:00
Alexey Milovidov
f2fe419ca9 Saturate negative unix timestamp to zero instead of overflow 2020-07-13 01:48:22 +03:00
Alexey Milovidov
f6f8421c2f Better test 2020-07-13 01:30:27 +03:00
Alexey Milovidov
8f0ec09372 Fix error; add a test 2020-07-13 01:23:21 +03:00
Alexey Milovidov
36de452fdd Merge branch 'master' into fix-limit-overflow 2020-07-13 00:24:24 +03:00
Alexey Milovidov
e8a3f0abb3 Correct default secure port for clickhouse-benchmark #11044 2020-07-12 21:54:13 +03:00
Alexey Milovidov
72ac7b008e Remove test with bug #10697 2020-07-12 21:02:06 +03:00
tavplubix
d64e51d1a7
Merge pull request #12421 from azat/lifetime-table-metrics
lifetime_rows/lifetime_bytes for Buffer engine
2020-07-12 19:00:02 +03:00
Amos Bird
cac5a89169
Allow nullable key in MergeTree 2020-07-12 22:21:51 +08:00
Alexey Milovidov
ef930df484 Avoid overflow in LIMIT #10470 #11372 2020-07-12 08:18:01 +03:00
Alexey Milovidov
204a4af394 Rollback insertion error in Log engines #12402 2020-07-12 05:32:18 +03:00
Azat Khuzhin
3bee98c6f0 Fix lifetime_bytes/lifetime_rows for Buffer direct block write 2020-07-12 01:16:05 +03:00
Denis Glazachev
b68d7b6c24
Merge branch 'master' into ldap-per-user-authentication 2020-07-11 21:37:52 +04:00
Denis Glazachev
edb6ef8c09 Merge commit 'ceac649c01b0158090cd271776f3219f5e7ff57c' into ldap-per-user-authentication
* commit 'ceac649c01b0158090cd271776f3219f5e7ff57c': (75 commits)
  [docs] split misc statements (#12403)
  Update 00405_pretty_formats.reference
  Update PrettyCompactBlockOutputFormat.cpp
  Update PrettyBlockOutputFormat.cpp
  Update DataTypeNullable.cpp
  Update 01383_remote_ambiguous_column_shard.sql
  add output_format_pretty_grid_charset setting in docs
  add setting output_format_pretty_grid_charset
  Added a test for #11135
  Update index.md
  RIGHT and FULL JOIN for MergeJoin (#12118)
  Update MergeTreeIndexFullText.cpp
  restart the tests
  [docs] add syntax highlight (#12398)
  query fuzzer
  Fix std::bad_typeid when JSON functions called with argument of wrong type.
  Allow typeid_cast() to cast nullptr to nullptr.
  fix another context-related segfault
  [security docs] actually, only admins can create advisories
  query fuzzer
  ...
2020-07-11 21:32:36 +04:00
alexey-milovidov
3c2af9653a
Merge pull request #12416 from vzakaznikov/fixing_flopping_live_view_tests
Increasing default timeout for live view tests from 20 sec to 120 sec
2020-07-11 19:38:39 +03:00
Azat Khuzhin
32a45d0dee Implement lifetime_rows/lifetime_bytes for Buffer engine
Buffer engine is usually used on INSERTs, but right now there is no way
to track number of INSERTed rows per-table, since only summary metrics
exists:
- StorageBufferRows
- StorageBufferBytes

But it can be pretty useful to track INSERTed rows rate (and it can be
exposed via http_handlers for i.e. prometheus)
2020-07-11 16:06:11 +03:00
alexey-milovidov
c615ea658b
Merge pull request #12400 from vitlibar/fix-bad_typeid
Fix std::bad_typeid when JSON functions called with argument of wrong type
2020-07-11 05:40:44 +03:00
alexey-milovidov
7bc2c83b80
Merge pull request #12372 from s-mx/issue-10429-add_setting_for_ascii_grid_symbols
add setting for ascii grid symbols
2020-07-11 05:31:41 +03:00
Vitaliy Zakaznikov
1ed7d176fc Increasing default timeout for live view tests from 20 sec to 120 sec
to account for slowdowns.
2020-07-11 04:30:53 +02:00
alexey-milovidov
4394f68e26
Merge pull request #12411 from ClickHouse/test-11135
Added a test for #11135
2020-07-11 05:29:08 +03:00
alexey-milovidov
fd46ef428a
Update 00405_pretty_formats.reference 2020-07-11 00:33:21 +03:00
alexey-milovidov
2476d3f748
Update 01383_remote_ambiguous_column_shard.sql 2020-07-11 00:21:58 +03:00
alexey-milovidov
7c2bd32c9c
Merge pull request #12401 from ClickHouse/fix_segfault_in_storage_merge
Fix another Context-related segfault
2020-07-11 00:19:00 +03:00
Maxim Sabyanin
40f7ec71d3 add setting output_format_pretty_grid_charset
This setting allows to chose charset for printing grids (either UTF-8 or
ASCII).
2020-07-10 22:25:49 +03:00
Alexey Milovidov
57a803d477 Added a test for #11135 2020-07-10 21:50:01 +03:00
Artem Zuikov
6b26842ce5
RIGHT and FULL JOIN for MergeJoin (#12118) 2020-07-10 21:10:06 +03:00
alexey-milovidov
e22547c29d
Merge pull request #12388 from ClickHouse/bloom-filter-arg-check
Check arguments of bloom filter index
2020-07-10 20:54:16 +03:00
alexey-milovidov
2d9e0ec049
Merge pull request #12376 from ClickHouse/fix-totals-state-2
Fix TOTALS/ROLLUP/CUBE for aggregate functions with -State and Nullable arguments
2020-07-10 20:18:48 +03:00
alexey-milovidov
d819624d7c
Merge pull request #12378 from ClickHouse/allow-clear-column-with-dependencies
Allow to CLEAR column even if there are depending DEFAULT expressions
2020-07-10 20:18:14 +03:00
alexey-milovidov
031c773260
Merge pull request #12384 from ClickHouse/support-negative-float-constants-in-key-condition
Avoid exception when negative or floating point constant is used in WHERE condition for indexed tables
2020-07-10 20:16:35 +03:00
Vitaly Baranov
94c858b2dc Fix std::bad_typeid when JSON functions called with argument of wrong type. 2020-07-10 17:12:57 +03:00
Alexander Tokmakov
20d95a21fc fix another context-related segfault 2020-07-10 17:00:44 +03:00
Artem Zuikov
01b5c2663c
Delete injective functions inside uniq (#12337) 2020-07-10 13:42:41 +03:00
Alexey Milovidov
47eaffbe63 Additional checks 2020-07-10 11:21:40 +03:00
Alexey Milovidov
4b86f36d37 Check arguments of bloom filter index 2020-07-10 11:13:21 +03:00
alesapin
5cae87e664
Merge pull request #12335 from ClickHouse/fix_alter_exit_codes
Fix alter rename error messages
2020-07-10 11:05:20 +03:00
Alexey Milovidov
02dea4973d Allow to parse operator NOT as a function #12262 2020-07-10 09:47:37 +03:00
Alexey Milovidov
276b3a0215 Avoid exception when negative or floating point constant is used in WHERE condition for indexed tables #11905 2020-07-10 09:30:49 +03:00
Alexey Milovidov
a4c68a47d5 Added failing test with clearing all columns 2020-07-10 08:58:16 +03:00
Alexey Milovidov
a4b35a8a6f Allow to CLEAR column even if there are depending DEFAULT expressions #12333 2020-07-10 08:54:35 +03:00
alexey-milovidov
c16d8e094b
Merge pull request #12308 from ClickHouse/fix-codec-bad-exception-code
Fix wrong exception code in codecs Delta, DoubleDelta #12110
2020-07-10 08:40:46 +03:00
Alexey Milovidov
c610a4b0a8 Fix error with ownership of aggregate function states with nested states 2020-07-10 08:28:34 +03:00
Alexey Milovidov
12e00411b4 Fix TOTALS/ROLLUP/CUBE for aggregate functions with -State and Nullable arguments #12163 2020-07-10 06:23:42 +03:00
Alexey Milovidov
f252dd94c8 Miscellaneous 2020-07-10 05:17:15 +03:00
Alexey Milovidov
afc00fa0b8 Merge branch 'master' into fix-codec-bad-exception-code 2020-07-10 04:12:24 +03:00
alexey-milovidov
7799dc2f9c
Merge pull request #12336 from ClickHouse/fix-obvious-race-condition-in-test
Fix obvious race condition in test
2020-07-10 01:53:01 +03:00
Anton Popov
c4767557f2
Merge pull request #12306 from CurtizJ/fix-with-fill
Fix order of columns in WITH FILL modifier
2020-07-10 00:12:11 +03:00
alesapin
bb46ae8246 Fix tests 2020-07-09 22:14:19 +03:00
Alexander Tokmakov
77289146ab fix tests 2020-07-09 20:47:42 +03:00
Alexey Milovidov
21449bd28c Fix obvious race condition in test 2020-07-09 17:48:46 +03:00
Alexey Milovidov
635b8f8f9a Fix tests 2020-07-09 17:44:33 +03:00
alesapin
0156f43ed3 Human readable errors in alter rename queries 2020-07-09 17:30:38 +03:00
alesapin
26293e4640 Rename test 01378 2020-07-09 17:18:50 +03:00
Alexander Tokmakov
445acd0294 Merge branch 'master' into database_atomic_improvements 2020-07-09 16:02:54 +03:00
Denis Glazachev
5a4762bb8a
Merge branch 'master' into ldap-per-user-authentication 2020-07-09 14:50:02 +04:00
alesapin
47f05dcadd
Merge pull request #12304 from CurtizJ/fix-ttl-rename
Fix TTL after renaming column.
2020-07-09 13:06:27 +03:00
Alexey Milovidov
380f748358 Fix issues 2020-07-09 08:08:41 +03:00
Alexey Milovidov
39e79cfe3e Merge branch 'master' into fix-codec-bad-exception-code 2020-07-09 07:50:18 +03:00
alexey-milovidov
827990d681
Merge pull request #12305 from ClickHouse/fix-virtual-columns-filter
Fix virtual columns filter
2020-07-09 07:06:07 +03:00
alexey-milovidov
e73c6779f8
Merge pull request #12292 from ClickHouse/fix-typo
Fix typo in setting name
2020-07-09 06:32:27 +03:00
Alexey Milovidov
dbcd0fdd3e Fix "Arcadia" build 2020-07-09 04:31:09 +03:00
alexey-milovidov
0c37fe9c75
Merge pull request #12179 from azat/GROUP-BY-injective-elimination-dictGet-fixes
Fix dictGet arguments check during GROUP BY injective functions elimination
2020-07-09 04:29:26 +03:00
alexey-milovidov
0a935dd4e8
Merge branch 'master' into fix-12030 2020-07-09 04:27:40 +03:00
alexey-milovidov
36205e3ddf
Merge pull request #12181 from azat/bump-arrow-to-0.17
Bump arrow to 0.17 (and flatbuffers to v1.12, required by arrow)
2020-07-09 04:24:47 +03:00
Alexey Milovidov
0c8e12affd Remove ridiculous code 2020-07-09 03:46:00 +03:00
Alexey Milovidov
9dc91e3ee4 Fix outstandingly wrong code 2020-07-09 03:35:14 +03:00
Alexey Milovidov
bb18ce9341 Added a test 2020-07-09 03:27:49 +03:00
Anton Popov
1122d99ba8 fix order of columns in WITH FILL modifier 2020-07-09 02:56:44 +03:00
Alexey Milovidov
c46ca164dd Added a test 2020-07-09 02:54:15 +03:00
Anton Popov
0e4871eec2 fix TTL after renaming column 2020-07-09 02:25:31 +03:00
Alexander Tokmakov
9c4efa1f36 fix, add test 2020-07-09 01:50:15 +03:00
Alexey Milovidov
35f0e68892 Added a test 2020-07-09 01:41:25 +03:00
tavplubix
33c3545125
Merge pull request #12197 from nikitamikhaylov/csv-file-bugfix
Headers for CSVWithNames in StorageFile
2020-07-08 20:42:49 +03:00
alexey-milovidov
df8cde7b54
Merge pull request #12279 from ClickHouse/fix-array-fill
Fix arrayFill for empty arrays.
2020-07-08 14:28:15 +03:00
alexey-milovidov
3f0c257389
Merge pull request #12275 from ClickHouse/supertype-low-cardinality
Supertype for LowCardinality
2020-07-08 14:27:48 +03:00
alesapin
84f8bf1e14
Merge pull request #10697 from CurtizJ/polymorphic-parts
Polymorphic parts (in-memory format)
2020-07-08 13:25:45 +03:00
alexey-milovidov
d0d1590d0d
Merge pull request #12271 from ClickHouse/fix-logical-functions-review
Fix minor issues in ternary logic
2020-07-08 05:33:37 +03:00
Alexey Milovidov
cea3de5243 Added a test 2020-07-08 04:58:32 +03:00
alexey-milovidov
b4c2c4906e
Merge pull request #11873 from ClickHouse/initial-explain
Initial explain
2020-07-08 01:59:27 +03:00
Alexey Milovidov
3a1ed562db Merge branch 'master' into initial-explain 2020-07-08 01:58:25 +03:00
Alexey Milovidov
454b0a2678 Update test 2020-07-08 01:58:22 +03:00
alexey-milovidov
ffdd6e1af6
Merge pull request #12173 from nikitamikhaylov/summing-bug-fix
Exclude partition key columns from SummingMergeTree
2020-07-08 01:46:12 +03:00
Alexey Milovidov
60c1ffc892 Implement supertype for LowCardinality 2020-07-08 01:26:43 +03:00
Alexey Milovidov
5ef4e90dfb Fix minor issues after #12196 2020-07-07 23:56:40 +03:00
Azat Khuzhin
fd5e08884a Bump arrow to 0.17 (and flatbuffers to v1.12, required by arrow)
MOTIVATION:
- remove double-conversion external dependency
- remove flatc (but flatbuffers is still required, arrow just shipped
  with generated files and that's it)

CHANGED:
- remove pre-generated headers, it is shipped with the arrow
- remove flatc (see above)

NOTES (see tests changes):
- and snappy error is reported as unsupported compression.
2020-07-07 23:54:32 +03:00
Denis Glazachev
917b56c094
Merge branch 'master' into ldap-per-user-authentication 2020-07-08 00:51:44 +04:00
Denis Glazachev
9effacfbc1 Merge branch 'master' into ldap-per-user-authentication
* master: (1102 commits)
  Update README.md
  Update README.md
  Update README.md
  Update index.md
  [docs] add intrdocution for statements page (#12189)
  Revert "Run perf tests with memory sampling (for allocations >1M)"
  Sanitize LINK_LIBRARIES property for the directories (#12160)
  [docs] refactor Domains overview (#12186)
  DOCS-647: toStartOfSecond (#12190)
  [docs] add intrdocution for commercial page (#12187)
  DOCSUP-1348 Russian translation for new functions (#133) (#12194)
  changelog fixes
  Update index.md (#12191)
  Update zh kafka.md title (#12192)
  Added test for #3767
  style fix for #12152
  Tests for fixed issues #10846 and #7347
  changelog fixes
  [docs] introduction for special table engines (#12170)
  [docs] introduction for third-party interfaces (#12175)
  ...

# Conflicts:
#	src/Access/ya.make
#	src/Common/ErrorCodes.cpp
2020-07-08 00:42:09 +04:00
alexey-milovidov
0fdc29be1e
Merge pull request #12196 from ClickHouse/akz/logical-functions-normalized-uint8
Fixed logical functions for UInt8 values when they are not equal to 0 or 1.
2020-07-07 23:19:35 +03:00
Nikolai Kochetov
fd7fcb28d4 Merge branch 'master' into initial-explain 2020-07-07 22:52:09 +03:00
Nikita Mikhaylov
ffad7eb966
fix test 2020-07-07 17:07:56 +03:00
Nikita Mikhaylov
270551e599 done 2020-07-07 14:45:20 +03:00
Mikhail Filimonov
6170bfd668 Added test for #3767 2020-07-07 12:33:43 +02:00
Mikhail Filimonov
c8f51bdc8a Tests for fixed issues #10846 and #7347 2020-07-07 12:00:39 +02:00
Alexander Kazakov
66128acd11 Included const uint8 values in test 2020-07-07 12:17:35 +03:00
Alexander Kazakov
a449f3e9ff A test for UInt8 as bool 2020-07-07 12:03:37 +03:00
tavplubix
488a8cbc9f
Merge pull request #12120 from filimonov/query_context_for_system_logs
Add query context for system logs and to Buffer
2020-07-07 09:55:20 +03:00
Mikhail Filimonov
c78d44cb55 Sync reference file with changes in sql file 2020-07-06 23:24:11 +02:00
Azat Khuzhin
128dd4fa8a Fix dictGet arguments check during GROUP BY injective functions elimination
This patch changes the place where the dictionary will be loaded (during
syntax analysis), but I guess this is fine, it will be loaded anyway.

Fixes: #10342
2020-07-06 22:53:17 +03:00
Azat Khuzhin
6310e49032 Fix dictGet with bad arguments during GROUP BY injective functions elimination 2020-07-06 22:53:17 +03:00
Nikita Mikhailov
1b93e21db1 add select final to test 2020-07-06 21:38:58 +03:00
alesapin
3f90f65678 Merge remote-tracking branch 'origin' into CurtizJ-polymorphic-parts 2020-07-06 21:34:17 +03:00
Mikhail Filimonov
8038383f06 Fix #10437, CR fixes 2020-07-06 19:24:33 +02:00
alexey-milovidov
3059be55a3
Merge branch 'master' into fix-test-under-thread-fuzzer 2020-07-06 19:49:25 +03:00
alexey-milovidov
4e0e8cdaac
Merge pull request #12157 from ClickHouse/fix-flaky-test-721
Attempt to fix flaky test 00721_force_by_identical_result_after_merge
2020-07-06 18:15:59 +03:00
Nikita Mikhaylov
53522c728b
Merge pull request #11662 from Avogar/orc_output_format
Add ORCBlockOutputFormat
2020-07-06 18:51:35 +04:00
Nikita Mikhaylov
d31ed58f01 done 2020-07-06 17:33:31 +03:00
Alexander Tokmakov
d1be5ec641 fix symlinks, add short syntax of attach database 2020-07-06 16:41:43 +03:00
Anton Popov
66bed10ec1
Merge pull request #12109 from PerformanceVision/initialize_aggregation
Create initializeAggregation to initialize an aggregation function
2020-07-06 15:12:30 +03:00
alesapin
8e767bf5d0
Merge pull request #12153 from ClickHouse/fix-mutations-interpreter
Fix wrong logic in MutationsInterpreter
2020-07-06 14:43:54 +03:00
alexey-milovidov
b6a19b5eff
Merge pull request #12148 from ClickHouse/fix-bad-redundant-order-by-optimization
Fix bad code in redundant ORDER BY optimization
2020-07-06 09:21:45 +03:00
alexey-milovidov
4ec787ce48
Merge pull request #12147 from ClickHouse/fix-logical-error-table-function-remote
Change exception code from LOGICAL_ERROR to BAD_ARGUMENTS when the name of remote table is empty.
2020-07-06 09:21:23 +03:00
Alexey Milovidov
63e1e2303b Attempt to fix flaky test 00721_force_by_identical_result_after_merge_zookeeper 2020-07-06 09:13:26 +03:00
Alexey Milovidov
7df372cb1d Fix flaky test 2020-07-06 09:09:23 +03:00
Alexey Milovidov
1650bf90b9 Fix test 2020-07-06 09:05:48 +03:00
alexey-milovidov
ced1272368 Update 01358_mutation_delete_null_rows.sql 2020-07-06 09:05:48 +03:00
Alexey Milovidov
d8ae9c571c Added yet another test just in case 2020-07-06 09:05:48 +03:00
Alexey Milovidov
4508876008 Added another test just in case 2020-07-06 09:05:48 +03:00
Alexey Milovidov
eb2cffab37 Added a test 2020-07-06 09:05:48 +03:00
Mikhail Filimonov
935b943703 Test for issue #9088
ALTER DELETE unexpectedly deletes NULL rows
2020-07-06 09:05:48 +03:00
alexey-milovidov
4f63af957d
Merge pull request #12145 from ClickHouse/fix-suggest-word-break-chars
Remove underscore as word-break character.
2020-07-06 08:51:35 +03:00
Alexey Milovidov
2a026ee902 Merge branch 'master' into fix-test-under-thread-fuzzer 2020-07-06 08:49:20 +03:00
alexey-milovidov
3aad122153
Merge pull request #12092 from CurtizJ/fix-state-resample
Fix segfault with -StateResample combinators
2020-07-06 08:47:42 +03:00
Alexey Milovidov
8179b34857 Fix test under ThreadFuzzer 2020-07-06 06:22:23 +03:00
Alexey Milovidov
bd523a0aff Autocomplete does not have to work in "Unbundled" build 2020-07-06 04:30:03 +03:00
Alexey Milovidov
752b0218db Add a test 2020-07-06 03:00:48 +03:00
Alexey Milovidov
3ae9d3c9f3 Change exception code from LOGICAL_ERROR to BAD_ARGUMENTS when the name of remote table is empty 2020-07-06 02:13:44 +03:00
Alexey Milovidov
f2672233d9 Added a test 2020-07-06 01:45:28 +03:00
Alexey Milovidov
05ee63b7f5 Fix bad test number 2020-07-06 01:18:20 +03:00
flynn
5816858403
add parseDateTimeBestEffortUS function (#12028)
* add function parseDateTimeBestEffortUS
* add test
* add doc

Co-authored-by: alexey-milovidov <milovidov@yandex-team.ru>
2020-07-05 21:09:20 +03:00
alexey-milovidov
c08e24d9ab
Merge pull request #12136 from vivarum/vivarum-04659-new-ISO8601-year-modificators-for-formatDateTime
New ISO8601 year modificators for formatDateTime() function
2020-07-05 19:10:06 +03:00
alexey-milovidov
ab15c8d6ca
Merge pull request #12021 from ClickHouse/fix-if-fixed-string
Fix function if with FixedString arguments of different sizes
2020-07-05 19:02:21 +03:00
alexey-milovidov
0f1bfa5b19
Merge pull request #12042 from ClickHouse/fix-constraints
Fix constraints check for constant columns, step 1.
2020-07-05 19:01:33 +03:00
alexey-milovidov
eecf7ae3ee
Merge pull request #12140 from ClickHouse/fix-division
Fix potential overflow in integer division
2020-07-05 19:00:41 +03:00
myrrc
8c3417fbf7
ILIKE operator (#12125)
* Integrated CachingAllocator into MarkCache

* fixed build errors

* reset func hotfix

* upd: Fixing build

* updated submodules links

* fix 2

* updating grabber allocator proto

* updating lost work

* updating CMake to use concepts

* some other changes to get it building (integration into MarkCache)

* further integration into caches

* updated Async metrics, fixed some build errors

* and some other errors revealing

* added perfect forwarding to some functions

* fix: forward template

* fix: constexpr modifier

* fix: FakePODAllocator missing member func

* updated PODArray constructor taking alloc params

* fix: PODArray overload with n restored

* fix: FakePODAlloc duplicating alloc() func

* added constexpr variable for alloc_tag_t

* split cache values by allocators, provided updates

* fix: memcpy

* fix: constexpr modifier

* fix: noexcept modifier

* fix: alloc_tag_t for PODArray constructor

* fix: PODArray copy ctor with different alloc

* fix: resize() signature

* updating to lastest working master

* syncing with 273267

* first draft version

* fix: update Searcher to case-insensitive

* added ILIKE test

* fixed style errors, updated test, split like and ilike,  added notILike

* replaced inconsistent comments

* fixed show tables ilike

* updated missing test cases

* regenerated ya.make

* Update 01355_ilike.sql

Co-authored-by: myrrc <me-clickhouse@myrrec.space>
Co-authored-by: alexey-milovidov <milovidov@yandex-team.ru>
2020-07-05 18:57:59 +03:00
alexey-milovidov
ec563e54dc
Merge pull request #12138 from ClickHouse/codeql
Fix warnings from CodeQL
2020-07-05 18:22:49 +03:00
alexey-milovidov
5902718330
Merge pull request #12141 from ClickHouse/test-for-remote-failover-num-tries
Added a test for #4211
2020-07-05 18:22:32 +03:00
Alexey Milovidov
e83df36bc0 Rename test 2020-07-05 04:34:45 +03:00
Alexey Milovidov
66e810fc23 Added a test for #4211 2020-07-05 03:44:26 +03:00
Alexey Milovidov
63a88de161 Added a test 2020-07-05 03:29:03 +03:00
Alexey Milovidov
55f9ddbeb4 Added a test 2020-07-05 02:39:13 +03:00
Alexey Milovidov
731d92657d Remove harmful code from "geoDistance" #12117 2020-07-05 00:57:57 +03:00
Alexey Milovidov
d10856cf07 Added a test 2020-07-05 00:44:29 +03:00
alexey-milovidov
e05283d5d3
Merge pull request #12060 from ClickHouse/fix-12053
Check wrong type for filter.
2020-07-04 23:46:34 +03:00
alexey-milovidov
cf1967bb29
Merge pull request #12089 from ClickHouse/fix-11595
Fix result_rows and result_bytes metrics for selects.
2020-07-04 23:41:51 +03:00
alexey-milovidov
c6def5f14b
Merge pull request #12108 from ClickHouse/fix-12086
Fix Parquet for LowCardinality
2020-07-04 23:39:38 +03:00
Alexey Milovidov
918e979449 Merge branch 'master' into fix-if-fixed-string 2020-07-04 22:00:27 +03:00
vivarum
d387fa719e New ISO8601 year modificators for formatDateTime 2020-07-04 21:54:42 +03:00
alesapin
8dc204350f
Fix version column in replicated version collapsing merge tree (#12121) 2020-07-04 10:35:17 +03:00
alexey-milovidov
6677e0a503
Merge pull request #12073 from zhang2014/feature/atfer_column_modify_column
ISSUES-4006 support first for ALTER ADD|MODIFY COLUMN
2020-07-03 22:54:05 +03:00
tavplubix
4d9cfe4cf2
Update 01355_CSV_input_format_allow_errors.sh 2020-07-03 22:37:10 +03:00
Mikhail Filimonov
6e599533a7 Add missing query context for system logs
Needed to allow attaching materialized views with joins or with
subqueries to system.logs.
2020-07-03 19:19:32 +02:00
Nikita Mikhaylov
5c97106ea3 Merge branch 'master' of github.com:ClickHouse/ClickHouse into Avogar_orc_output_format 2020-07-03 18:00:28 +03:00
Guillaume Tassery
027c6b705f Create initializeAggregation to initialize an aggregation function based on a value 2020-07-03 19:18:47 +07:00
Nikolai Kochetov
8ec70c2c3c Added test. 2020-07-03 14:45:57 +03:00
Mikhail Filimonov
0ce2d48af6 Test for a fixed issue #10668, related to input_format_allow_errors_num in CSV 2020-07-03 11:24:03 +02:00
alesapin
b3ec449e35
Fix test (#12088) 2020-07-03 12:18:59 +03:00
Nikolai Kochetov
8cfe5f137a Added test. 2020-07-03 11:22:21 +03:00
Nikolai Kochetov
17c89f3fe0
Merge pull request #12085 from ClickHouse/fix-11937
Fix limiting the number of threads for VIEW.
2020-07-03 10:35:04 +03:00
Nikolai Kochetov
3c717d4aca Added test. 2020-07-03 10:34:08 +03:00
Anton Popov
4422df2e37 Merge remote-tracking branch 'upstream/master' into HEAD 2020-07-02 20:18:21 +03:00
Anton Popov
a5cbeda1e3 fix segfault with -StateResample combinators 2020-07-02 19:13:42 +03:00
Nikolai Kochetov
aca1d8ac77 Added test. 2020-07-02 16:06:10 +03:00
Anton Popov
71059e4dff
Merge pull request #12062 from nvartolomei/nv/set-index-tuple-types
Try fix pk in tuple performance
2020-07-02 15:51:03 +03:00
alesapin
f87c3af097
Merge pull request #12055 from ClickHouse/fix-9766
Fix arrayMap with Tuple(LowCardinality) argument
2020-07-02 13:40:05 +03:00
alesapin
65dae99c12
Merge pull request #12056 from ClickHouse/fix-11808
Fix defaultValueOfArgumentType
2020-07-02 13:35:38 +03:00
Nikolai Kochetov
79cd33a567 Fix tests. 2020-07-02 10:44:47 +03:00
zhang2014
9ed5c6d925 ISSUES-4006 support first for ALTER ADD|MODIFY COLUMN 2020-07-01 22:58:52 +08:00
Vitaly Baranov
811d124a82
Merge pull request #12002 from vitlibar/fix-partial-revokes
Fix partial revokes
2020-07-01 17:15:01 +03:00
Nicolae Vartolomei
64bbccb42e Add force_primary_key to a pk in tuple test 2020-07-01 14:25:14 +01:00
Nicolae Vartolomei
c95d09aed0 Add a test to cover non-const tuple elemenets (just in case) 2020-07-01 11:01:47 +01:00
hcz
e284bf83d0 Optimize and fix 2020-07-01 11:21:53 +08:00
alexey-milovidov
948af0bfc5
Merge pull request #12045 from ClickHouse/fix_loading_of_tables
Parse metadata in parallel when loading tables
2020-06-30 21:16:40 +03:00
Nicolae Vartolomei
b1d2d55cba Add explicit test for a case where AST hashes collide for different prepared sets 2020-06-30 18:19:20 +01:00
Vitaly Baranov
c39eb8f71b Fix partial revokes (complex cases). 2020-06-30 18:47:02 +03:00
Nicolae Vartolomei
8f1845185e Try fix pk in tuple performance
Possible approach for fixing #10574

The problem is that prepared sets are built correctly, it is a hash map of key -> set
where key is a hash of AST and list of data types (when we a list of
tuples of literals).

However, when the key is built from the index to try and find if there
exists a prepared set that would match it looks for data types of the
primary key (see how data_types is populated) because the primary key
has only one field (v in my example) it can not find the prepared set.

The patch looks for any prepared indexes where data types match for the
subset of fields found in primary key, we are not interested in other
fields anyway for the purpose of primary key pruning.
2020-06-30 16:33:38 +01:00