Commit Graph

2646 Commits

Author SHA1 Message Date
Nikita Mikhaylov
fa22fdc097 Merge branch 'master' of github.com:ClickHouse/ClickHouse into get_fuzz_data 2021-12-06 14:30:49 +00:00
Azat Khuzhin
f8bf3b1993 stress: use max_memory_usage_for_user as a soft limit to avoid memory limit exceeded
By using max_memory_usage_for_user as a soft limit, and after
max_server_memory_usage as a hard, we can allow normal overcommit, using
max_memory_usage_for_user=0 instead of relying on max_untracked_memory.
2021-12-06 09:05:34 +03:00
Azat Khuzhin
f9a95fce13 stress: allow memory overcommit for SELECT 1 query 2021-12-06 09:02:56 +03:00
Azat Khuzhin
1167313961 stress: allow memory overcommit for one more query 2021-12-06 09:02:56 +03:00
Azat Khuzhin
7063ea3ee2 stress: add make_query_command() helper 2021-12-06 09:02:56 +03:00
Azat Khuzhin
adec690166 stress: SYSTEM DROP MARK CACHE 2021-12-06 09:02:56 +03:00
Azat Khuzhin
d3a7aed005 stress: tune memory_profiler_step too 2021-12-06 09:02:56 +03:00
Azat Khuzhin
169941c5d0 stress: allow 100MiB of memory to overcommit for SHOW/DROP DATABASE
CI: https://s3.amazonaws.com/clickhouse-test-reports/32019/b6290ae00223fc91d514b82de25e195ab34f8bca/stress_test__thread__actions_.html
2021-12-06 09:02:56 +03:00
Azat Khuzhin
445b0983ea stress: ignore server memory limits for hung check
In [1] hung check failed because the server was under memory pressure.

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/32019/b6290ae00223fc91d514b82de25e195ab34f8bca/stress_test__undefined__actions_.html
2021-12-06 09:02:56 +03:00
Azat Khuzhin
3e96b28843 perf: convert killall to pkill (since killall has some magic, see -e option) 2021-12-03 10:56:42 +03:00
Azat Khuzhin
fb0cc62509 perf: fix waiting of the server after running tests
killall requires strict match, i.e. "clickhouse-server" not
"clickhouse":

    2021-12-03 05:24:56      + env kill -- -21700
    2021-12-03 05:24:56      kill: (-21700): No such process
    2021-12-03 05:24:56      + killall clickhouse
    2021-12-03 05:24:56      clickhouse: no process found
    2021-12-03 05:24:56      + echo Servers stopped.
    2021-12-03 05:24:56      Servers stopped.
    2021-12-03 05:24:56      + analyze_queries

    $ tail -n1 *-server-log.log
    ==> left-server-log.log <==
    2021.12.03 05:26:59.530647 [ 450 ] {} <Trace> SystemLog (system.asynchronous_metric_log): Flushed system log up to offset 1668052

    ==> right-server-log.log <==
    2021.12.03 05:27:20.873136 [ 466 ] {} <Trace> SystemLog (system.metric_log): Flushed system log up to offset 9605

    ==> setup-server-log.log <==
    2021.12.03 02:47:14.844395 [ 96 ] {} <Information> Application: Child process exited normally with code 0.

As you can see killall instantly fails with no such process, while this
cannot be true since it was there, and also according to logs there were
messages after running analyze_queries() from compare.sh

This should fix problems like in [1].

  [1]: https://clickhouse-test-reports.s3.yandex.net/32080/344298f4037f88b114b8e798bb30036b24be8f16/performance_comparison/report.html#fail1
2021-12-03 10:55:35 +03:00
Azat Khuzhin
e976cd8691 Provide clickhouse binary w/o debug symbols (stripped) in fasttest
- regular binary: 1.8G
- stripped: 343M (5x less)
- gzipped stripped: 92M (20x less)

This can be useful to check something fast.
2021-12-01 21:50:03 +03:00
alesapin
b4d4295c16 Followup 2021-11-30 13:24:04 +03:00
alesapin
085a30b98e Fixup 2021-11-30 13:22:50 +03:00
alesapin
bccd927aec Make stress tests slightly more stable 2021-11-30 13:19:03 +03:00
Raúl Marín
6a04dcb492 Remove libc-headers 2021-11-29 19:55:57 +01:00
Mikhail f. Shiryaev
e97e172dd8
Merge pull request #31822 from ClickHouse/rollback-28016
Rollback changes from #28016: ru.archive.ubuntu.com
2021-11-29 10:27:59 +01:00
Alexey Milovidov
0f465a971e Remove some old options 2021-11-27 03:36:29 +03:00
Mikhail f. Shiryaev
5408d6232f
Make archive.ubuntu.com mirror configurable for build 2021-11-26 10:55:41 +01:00
alesapin
3562264404
Merge pull request #31803 from ClickHouse/faster_tests
Shorter stress and fuzzer tests
2021-11-26 10:17:26 +03:00
alexey-milovidov
6b8f7ad03f
Merge pull request #31798 from ClickHouse/fix-31748
Fix stylecheck for tests/ci/push_to_artifactory.py
2021-11-26 00:11:32 +03:00
alexey-milovidov
6017b982d9
Merge pull request #31780 from Algunenano/fix_performance_report_queries
Improve how queries are output in the performance dashboard
2021-11-25 22:57:29 +03:00
alesapin
71ae890c59
Merge pull request #31544 from azat/ci-actions-fixes
Remove duplicated not compressed logs from CI (actions)
2021-11-25 18:43:44 +03:00
alesapin
5815429059 Shorter stress and fuzzer tests 2021-11-25 17:54:50 +03:00
Mikhail f. Shiryaev
16703c2824
Fix stylecheck for tests/ci/push_to_artifactory.py 2021-11-25 14:41:08 +01:00
alexey-milovidov
e8b29cab6e
Update report.py 2021-11-25 15:37:00 +03:00
Raúl Marín
a6c34fdbc9 Improve how queries are output in the performance dashboard 2021-11-25 11:22:47 +01:00
alesapin
c86b43c7ef
Merge pull request #31685 from ClickHouse/tavplubix-patch-5
Try fix OOMs with TSAN
2021-11-25 11:34:05 +03:00
alesapin
58fad90351
Merge branch 'master' into add_performance_tests 2021-11-25 10:53:10 +03:00
alesapin
cf2f019caa Disable full run in perf tests 2021-11-24 23:05:27 +03:00
Alexey Milovidov
21f112b30e Merge branch 'better-crosscompiling-freebsd' into hermetic-builds 2021-11-24 22:43:30 +03:00
Alexey Milovidov
92031e6b31 Fix PVS-Studio 2021-11-24 20:25:11 +03:00
tavplubix
82e4f941a4
Update Dockerfile 2021-11-24 16:00:15 +03:00
tavplubix
556ccd0bc9
Update Dockerfile 2021-11-24 12:47:44 +03:00
Alexey Milovidov
51ee8fdbb0 More easy cross-compiling for FreeBSD 2021-11-24 00:32:04 +03:00
alexey-milovidov
61454ffbcb
Merge branch 'master' into hermetic-builds 2021-11-24 00:25:16 +03:00
alesapin
42c77323e8
Merge branch 'master' into add_performance_tests 2021-11-23 22:14:32 +03:00
alexey-milovidov
341f705419
Merge pull request #30599 from ClickHouse/zlib-ng-own-cmake
Use our own CMakeLists for `zlib-ng`, `cassandra`, `mariadb-connector-c` and `xz`, `re2`, `sentry`, `gsasl`, `arrow`, `protobuf`.
2021-11-23 13:33:29 +03:00
alesapin
2396f73e08 Fix performance tests comparison 2021-11-23 11:34:10 +03:00
alesapin
62b2eb6694 Merge branch 'master' into add_performance_tests 2021-11-23 11:26:45 +03:00
Constantine Peresypkin
fd551ad94c fix kerberized_hadoop image
current image uses non-existing centos6 repos
added direct fetch of actual rpm packages

fixed a typo in docker/images.json: duplicate entry
2021-11-22 17:32:19 +02:00
Alexey Milovidov
d604cf5573 Remove the infamous "unbundled" build 2021-11-21 13:58:26 +03:00
Azat Khuzhin
d0ecdb617e Remove duplicated not compressed logs from CI (actions)
Right now we cannot remove that compression since non-github actions
check will upload non compressed files then, but once old CI will be
removed it seems to be possible to remove that manual compression.
2021-11-19 21:33:48 +03:00
alesapin
9e440988cf Add datasets 2021-11-19 16:10:49 +03:00
alesapin
130c09f348 Fix search for old version 2021-11-18 13:38:59 +03:00
alesapin
d0ec0c5dc8 Merge branch 'master' into add_performance_tests 2021-11-18 10:17:20 +03:00
alesapin
b74f9e7047 Merge branch 'master' into add_performance_tests 2021-11-18 10:12:46 +03:00
Nikolay Degterinsky
fc9ef14a73
Merge pull request #29219 from evillique/log_lz4_streaming
Add LZ4 stream compression of logs
2021-11-17 21:22:57 +03:00
Nikolay Degterinsky
eafd3ddfac Add lz4 stream compression 2021-11-16 22:30:29 +00:00
tavplubix
b1079ae309
Update run.sh 2021-11-16 20:03:50 +03:00
tavplubix
224a4c1b6b
Update run.sh 2021-11-16 17:45:37 +03:00
alesapin
7f09941c72 Add performance comparison check 2021-11-16 14:16:10 +03:00
alexey-milovidov
f4fda976ef
Merge pull request #31063 from azat/perf-spikes
perf: switch *_log tables to Memory engine (attempt to reduce cache misses)
2021-11-14 05:13:12 +03:00
Azat Khuzhin
48b1b7b7ec Fix test_kafka_insert_avro by pinning avro version
New avro version has a code that does not allow to use BytesIO [1].

  [1]: https://github.com/apache/avro/commit/e8c61ba4f0#diff-ca721cc66db80ff81dcd7b8ad1bb0e83b2e5c2de80c207ebec79f5495d38db98R318-R319
2021-11-13 12:01:13 +03:00
Azat Khuzhin
40be97c1dd Improve fuzzer report in case of fuzzer killed
This will avoid Exception from fuzzer in description like in [1], that
someone may think that is related to the failure, which is obviously
don't in case it was KILLed.

  [1]: https://clickhouse-test-reports.s3.yandex.net/31259/a49e10c78860a451ff9cc39df6049c88234d507a/fuzzer_ubsan/report.html#fail1
2021-11-12 01:01:10 +03:00
mergify[bot]
045bd40070
Merge branch 'master' into perf-spikes 2021-11-11 07:07:28 +00:00
alesapin
0b28474f09
Merge pull request #31244 from nikitamikhaylov/disable-fuzz-builds
Disable fuzzer builds in CI
2021-11-10 16:42:08 +03:00
Nikita Mikhaylov
99f78472bc Disabled 2021-11-10 11:38:26 +00:00
Kseniia Sumarokova
5f9b35b982
Update docker_compose_postgres.yml 2021-11-10 10:36:59 +03:00
Kseniia Sumarokova
5eef7e0e45
Update docker_compose_postgres.yml 2021-11-09 15:13:01 +03:00
Azat Khuzhin
9e622b5add perf: switch *_log tables to Memory engine (attempt to reduce cache misses)
trace_log/query_log from performance tests shows (for
cases when prewarm query fails with timeout, 15sec) excessive
writeTraceInfo() in trace_log and QueryProfilerRuns in query_log, but
this is not the root cause of the timeout, but consequence.

Also query_log shows that on failures the following profile events has
significantly higher values:
- PerfLocalMemoryMisses (6.3x more)
- PerfLocalMemoryReferences (7x more)
- PerfDataTLBMisses (6.9x more)
- PerfInstructionTLBMisses (6.4x more)

During looking at performance tests logs I noticed that once the prewarm
query fails other server (left/right) was merging (MergeTree) something
in *_log tables.

But, using MergeTree for *_log in performance tests is useless, since
anyway environment for performance tests uses ramdrive.

And so MergeTree merges just increase overhead.

Eventually I expect that this should decrease extra memory referencing
and so this should decrease cache/TLB misses.

CI: https://clickhouse-test-reports.s3.yandex.net/30886/c504e0c08df7a926bb479a1d297f326f5c48a32f/performance_comparison/report.html#fail1

v2: <partition_by remove="remove"/>
2021-11-04 09:26:46 +03:00
Azat Khuzhin
ff19d22305 perf: remove over *_log tables that does not exported into artifacts 2021-11-03 08:29:18 +03:00
Azat Khuzhin
837fe8554f perf: remove zookeeper to avoid configuring DDLWorker 2021-11-03 08:29:18 +03:00
Azat Khuzhin
acef85b17d perf: cleanup server overrides 2021-11-03 08:29:18 +03:00
Azat Khuzhin
afd960db4e perf: remove redundant query profiler set queries 2021-11-03 08:09:43 +03:00
robot-clickhouse
4289336c27 Auto version update to [21.12.1.1] [54457] 2021-11-02 00:56:45 +03:00
Kruglov Pavel
9a1275cb10
Merge pull request #30178 from Avogar/tsv-csv
Refactor and improve TSV, CSV, JSONCompactEachRow, RowBinary formats. Fix bugs in formats
2021-11-02 00:38:30 +03:00
alesapin
dbfa17aabf Add correct S3 2021-11-01 13:32:56 +03:00
avogar
4e63311bb6 Try fix perf test 2021-11-01 12:13:29 +03:00
alesapin
54e404de32 Add github to known hosts in docs release 2021-11-01 10:33:52 +03:00
alesapin
ed3d707513
Merge pull request #30839 from ClickHouse/qoega-docker-docs
Docs check on github actions
2021-10-31 20:29:04 +03:00
alexey-milovidov
15b9d65221
Merge pull request #30662 from azat/conf-clickhouse
Switch everything left from `<yandex>` to `<clickhouse>`
2021-10-31 14:56:51 +03:00
alesapin
d872eae809 Better 2021-10-29 21:43:03 +03:00
alesapin
4c645f3ef6 Add docs release 2021-10-29 21:43:03 +03:00
alesapin
1a13a741f9 Fixes in docs 2021-10-29 21:43:03 +03:00
alesapin
6c8ba21c52 Add docs check image 2021-10-29 21:43:03 +03:00
alesapin
11f71fffe1 Tabs to spaces 2021-10-29 21:43:03 +03:00
alesapin
afcadc95a7 Add docs check to documentation 2021-10-29 21:43:03 +03:00
Yatsishin Ilya
faeb4ef869 Add docker container to build docs 2021-10-29 21:43:03 +03:00
tavplubix
059c1ebf36
Merge pull request #30847 from ClickHouse/fix_30802
Disable check for ZooKeeper session uptime by default
2021-10-29 20:18:25 +03:00
Alexander Tokmakov
d095cfe4c1 disable check for zk session uptime by default 2021-10-29 14:45:09 +03:00
alesapin
4eca493ab8 Fix fuzzer on master 2021-10-29 13:47:29 +03:00
alesapin
11b70a285c
Merge pull request #30795 from ClickHouse/make_fuzzer_check_less_hardcoded
Trying to make fuzzer check less hardcoded
2021-10-29 10:21:36 +03:00
alesapin
ddac7a51e2
Merge pull request #30729 from ClickHouse/trying_actions
Add functional tests to github actions
2021-10-29 09:49:31 +03:00
mergify[bot]
65df198e9b
Merge branch 'master' into conf-clickhouse 2021-10-28 22:19:42 +00:00
alesapin
ffc8dbd085
Update run-fuzzer.sh 2021-10-28 23:06:04 +03:00
alesapin
313584e553
Update run-fuzzer.sh 2021-10-28 19:12:47 +03:00
mergify[bot]
a94b8902dd
Merge branch 'master' into trying_actions 2021-10-28 15:57:28 +00:00
alesapin
0651a1f0e9
Update run-fuzzer.sh 2021-10-28 17:03:40 +03:00
alesapin
542196128b Trying to make fuzzer check less hardcoded 2021-10-28 12:29:50 +03:00
alesapin
c0b2f92123 Add stateful test 2021-10-28 12:26:59 +03:00
Azat Khuzhin
9eef2ad0c2 perf: reduce number of times the query will run
Before this patch:

- upstream/master and PR's *with* perf tests or pef scripts changes:
  --runs=13 --max-queries=0

- PRs *without* perf changes:
  --runs=7 --max-queries=20

- PRs w/ only perf tests changes:
  --runs-13 --max-queries=0 <list of perf tests>

After:

- upstream/master and PR's *with* perf tests changes:
  --runs=13 --max-queries=0

- PRs *without* perf changes:
  --runs=7 --max-queries=10

- PRs w/ only perf tests changes:
  --runs-13 --max-queries=0 <list of perf tests>

So to underline, now we will not look at perf scripts changes anymore,
and we will also decrease number of random queries to run to 10.
2021-10-27 23:20:51 +03:00
Azat Khuzhin
7957079f95 perf: disable query/memory profiling for non prewarm queries 2021-10-27 23:20:51 +03:00
Azat Khuzhin
190459db33 perf: add queries with errors during process too to the perf artifacts
Sometimes queries fails with timeout, and you will not get any perf
metrics for it before this patch.

Example: https://clickhouse-test-reports.s3.yandex.net/30611/5ff6c5536558821824d5fdf25a75729e5b82060d/performance_comparison/report.html#partial-queries.flat_dictionary.5
2021-10-27 23:20:51 +03:00
Azat Khuzhin
722d528218 perf: pin clickhouse-driver to 0.2.1 for tzlocal <0.3 to avoid warning
CI report [1]:

    /usr/local/lib/python3.6/dist-packages/clickhouse_driver/columns/datetimecolumn.py:199: PytzUsageWarning: The zone attribute is specific to pytz's interface; please migrate to a new time zone provider. For more details on how to do so, see https://pytz-deprecation-shim.readthedocs.io/en/latest/migration.html

  [1]: https://clickhouse-test-reports.s3.yandex.net/30626/dfc85841134aa96b4e04c401462898eb305e8657/performance_comparison/report.html#changes-in-performance.format_date_time.1
2021-10-27 23:20:51 +03:00
Azat Khuzhin
90ea2de9bb Add unidiff into style image 2021-10-27 10:03:24 +03:00
Azat Khuzhin
b41c77f4f8 Add boto3 to style image 2021-10-27 10:03:24 +03:00
Azat Khuzhin
944437caf6 Add PyGithub into style image 2021-10-27 10:03:23 +03:00
Nikita Mikhaylov
a4100cc980 Build local in CI in fuzz mode 2021-10-26 17:45:41 +00:00
Nikita Mikhaylov
aae30a9e37
Fix fuzzer build (#30344) 2021-10-26 20:30:34 +03:00