Commit Graph

103880 Commits

Author SHA1 Message Date
Alexey Milovidov
4311e6c147
Merge pull request #44683 from CurtizJ/fix-flaky-test-4
Fix test `01130_in_memory_parts`
2022-12-29 01:53:24 +03:00
Raúl Marín
5de11979ce
Unify query elapsed time measurements (#43455)
* Unify query elapsed time reporting

* add-test: Make shell tests executable

* Add some tests around query elapsed time

* Style and ubsan
2022-12-28 21:01:41 +01:00
Alexey Milovidov
4fce10940e
Merge pull request #44629 from Algunenano/revert_flamegraph
Revert "Merge pull request #38953 from ClickHouse/add-allocation-ptr-to-trace-log
2022-12-28 22:56:50 +03:00
Alexey Milovidov
4b8b5e0f95
Merge pull request #44601 from azat/move-line-readers
Slightly cleanup interactive line reader code
2022-12-28 22:44:47 +03:00
alesapin
6d27e2ddbc
Merge pull request #44606 from ClickHouse/faster-startup-bc-check
Faster server startup after stress test
2022-12-28 19:41:45 +01:00
Alexey Milovidov
0263499b0c
Merge pull request #44666 from azat/tests/integration/kazoo-stop
tests/integration: add missing kazoo client termination
2022-12-28 21:20:14 +03:00
Han Fei
cd0624e846
Merge pull request #44413 from save-my-heart/fix_explain_insert_query
fix explain ast insert with data
2022-12-28 18:08:49 +01:00
Anton Popov
38f0cf9b10 fix test 01130_in_memory_parts 2022-12-28 16:40:31 +00:00
Nikolay Degterinsky
a8c9851110
Merge pull request #44639 from evillique/fix_parser
Fix lambdas parsing
2022-12-28 17:39:22 +01:00
Anton Popov
80a18df09f
Merge pull request #44642 from CurtizJ/fix-async-insert-test
Fix test `02015_async_inserts_2`
2022-12-28 16:11:38 +01:00
Vitaly Baranov
8a2fbbe88c
Merge pull request #43947 from azat/backups/dedup
RFC: Add ability to disable deduplication for BACKUP
2022-12-28 15:24:53 +01:00
Alexey Milovidov
ab719f4432
Merge pull request #44358 from ClickHouse/fix-30975
Fix support for complex parameters of parametric aggregate functions, #30975
2022-12-28 16:38:41 +03:00
Alexey Milovidov
1b4121459d
Merge pull request #44645 from ClickHouse/keeper-test-fix
Fix flaky test `test_keeper_multinode_simple`
2022-12-28 16:38:17 +03:00
Alexey Milovidov
9f74843b17
Merge pull request #44660 from vitlibar/fix-flaky-test_backup_restore_on_cluster
Fix flaky test test_backup_restore_on_cluster
2022-12-28 16:33:36 +03:00
alesapin
3eda778707 Better 2022-12-28 14:29:27 +01:00
Kruglov Pavel
d42d9f70c8
Merge pull request #44225 from Avogar/fix-datetime-timezone
Forbid paths in timezone names
2022-12-28 13:57:39 +01:00
Azat Khuzhin
bc6adc88c8 tests/integration: add workaround for a bug in kazoo driver
Refs: python-zk/kazoo#688
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-28 10:52:49 +01:00
Vitaly Baranov
b211dff013 Increase the create table timeout in test "test_backup_restore_on_cluster". 2022-12-28 00:17:19 +01:00
Nikita Mikhaylov
9d10550b66
Merge branch 'master' into keeper-test-fix 2022-12-27 22:51:47 +01:00
Alexey Milovidov
5d6266c33e
Merge branch 'master' into fix_parser 2022-12-28 00:45:53 +03:00
Alexey Milovidov
14d7266e70
Merge branch 'master' into fix-30975 2022-12-27 23:21:10 +03:00
Alexey Milovidov
2892d447d4
Merge pull request #44626 from ClickHouse/alexey-milovidov-patch-5
Sometimes spot instances fail more than 20 times in a row
2022-12-27 23:20:05 +03:00
Alexey Milovidov
135a32c606
Merge branch 'master' into faster-startup-bc-check 2022-12-27 23:17:24 +03:00
alesapin
a3bb3c0172
Merge pull request #44649 from ClickHouse/add_chmod_to_run_fuzzer
Add +x flag for run-fuzzer.sh
2022-12-27 19:50:27 +01:00
alesapin
f93c52ac69 Add +x flag for run-fuzzer.sh 2022-12-27 19:48:58 +01:00
avogar
5c42b78766 Forbid paths in timezones in cctz lib 2022-12-27 17:52:38 +00:00
Kruglov Pavel
05c37365df
Merge branch 'master' into fix-datetime-timezone 2022-12-27 18:46:57 +01:00
Nikolay Degterinsky
29371745bd Fix lambdas parsing 2022-12-27 17:42:38 +00:00
Kruglov Pavel
819e7a3008
Merge pull request #44550 from Avogar/better-json-tuples-to-arrays-inference
Improve inferring arrays with nulls in JSON formats
2022-12-27 18:22:13 +01:00
Nikita Mikhaylov
00ecf6dd05 Better 2022-12-27 17:04:47 +00:00
Nikita Mikhaylov
ce6264b684 Done 2022-12-27 17:03:57 +00:00
Anton Popov
1f7a4a94ff fix test 02015_async_inserts_2 2022-12-27 17:01:30 +00:00
Azat Khuzhin
e1ad5cee7e tests/integration: add missing kazoo client termination
pytest play games with logging output [1].

  [1]: https://github.com/pytest-dev/pytest/issues/5502

But this does not actually affect ClickHouse tests, the only reason is
that the kazoo client is not stopped correctly without calling
kazoo.client.KazooClient.stop(), and that's why you can see the
following messages:

<details>

    test_storage_rabbitmq/test.py::test_rabbitmq_big_message --- Logging error ---
    Traceback (most recent call last):
      File "/usr/local/lib/python3.8/dist-packages/kazoo/protocol/connection.py", line 179, in _socket_error_handling
        yield
      File "/usr/local/lib/python3.8/dist-packages/kazoo/protocol/connection.py", line 659, in _connect
        self._socket = self.handler.create_connection(
      File "/usr/local/lib/python3.8/dist-packages/kazoo/handlers/threading.py", line 178, in create_connection
        return utils.create_tcp_connection(socket, *args, **kwargs)
      File "/usr/local/lib/python3.8/dist-packages/kazoo/handlers/utils.py", line 265, in create_tcp_connection
        sock = module.create_connection(address, timeout_at)
      File "/usr/lib/python3.8/socket.py", line 808, in create_connection
        raise err
      File "/usr/lib/python3.8/socket.py", line 796, in create_connection
        sock.connect(sa)
    socket.timeout: timed out

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
      File "/usr/local/lib/python3.8/dist-packages/kazoo/protocol/connection.py", line 579, in _connect_attempt
        read_timeout, connect_timeout = self._connect(host, hostip, port)
      File "/usr/local/lib/python3.8/dist-packages/kazoo/protocol/connection.py", line 659, in _connect
        self._socket = self.handler.create_connection(
      File "/usr/lib/python3.8/contextlib.py", line 131, in __exit__
        self.gen.throw(type, value, traceback)
      File "/usr/local/lib/python3.8/dist-packages/kazoo/protocol/connection.py", line 182, in _socket_error_handling
        raise ConnectionDropped("socket connection error: %s" % (err,))
    kazoo.exceptions.ConnectionDropped: socket connection error: None

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
      File "/usr/lib/python3.8/logging/__init__.py", line 1088, in emit
        stream.write(msg + self.terminator)
    ValueError: I/O operation on closed file.
    Call stack:
      File "/usr/lib/python3.8/threading.py", line 890, in _bootstrap
        self._bootstrap_inner()
      File "/usr/lib/python3.8/threading.py", line 932, in _bootstrap_inner
        self.run()
      File "/usr/lib/python3.8/threading.py", line 870, in run
        self._target(*self._args, **self._kwargs)
      File "/usr/local/lib/python3.8/dist-packages/kazoo/protocol/connection.py", line 512, in zk_loop
        if retry(self._connect_loop, retry) is STOP_CONNECTING:
      File "/usr/local/lib/python3.8/dist-packages/kazoo/retry.py", line 126, in __call__
        return func(*args, **kwargs)
      File "/usr/local/lib/python3.8/dist-packages/kazoo/protocol/connection.py", line 552, in _connect_loop
        status = self._connect_attempt(host, hostip, port, retry)
      File "/usr/local/lib/python3.8/dist-packages/kazoo/protocol/connection.py", line 622, in _connect_attempt
        self.logger.warning('Connection dropped: %s', e)
    Message: 'Connection dropped: %s'
    Arguments: (ConnectionDropped('socket connection error: None'),)

</details>

Which eventually leads to incorrectly parsed report.

This patch is an addition to the `logging.raiseExceptions=False` - #44618

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-27 17:01:06 +01:00
Kruglov Pavel
ac162a2c49
Merge pull request #44522 from Avogar/zero-numbers
Infer numbers starting from zero as strings in TSV
2022-12-27 17:00:10 +01:00
Kruglov Pavel
f95eabc192
Merge pull request #44469 from Avogar/low-card-if
Don't execute and/or/if/multiIf on LowCardinality dictionary
2022-12-27 16:59:42 +01:00
Kruglov Pavel
6dea7336f7
Merge pull request #44405 from Avogar/fix-parquet-orc
Fix reading columns that are not presented in input data in Parquet/ORC formats
2022-12-27 16:58:35 +01:00
Kruglov Pavel
e981b2e78b
Merge pull request #43813 from Avogar/fix-sum-if
Better handling of NULL in aggregate combinators, fix possible segfault/logical error
2022-12-27 16:50:48 +01:00
Azat Khuzhin
c9c590071d Add ability to disable deduplication for BACKUP
Right now BACKUP omit similar files, and will not allow to use this
backup as a regular table, and usually those similar files are quite
small (i.e. columns.txt).

So by using `BACKUP TO S3() deduplicate_files=0` you will be possible to
use `ATTACH TABLE` directly from S3.

P.S. right now it is possible only for the table with one part, since,
usually, there is nothing to deduplicate (if the columns are different).

v2: Add deduplicate_files into metadata
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-27 15:56:06 +01:00
Azat Khuzhin
7d81c39207 backups: ignore file not found error for S3 (similar to Disk)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-27 15:56:05 +01:00
Azat Khuzhin
998bf444e6 backups: remove IBackupCoordination::getFileSizeAndChecksum() (in favor of getFileInfo())
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-27 15:56:05 +01:00
Alexey Milovidov
c27f90c8ed
Update src/Parsers/ParserDataType.cpp
Co-authored-by: Nikolay Degterinsky <43110995+evillique@users.noreply.github.com>
2022-12-27 17:16:31 +03:00
Alexey Milovidov
4ce9732502
Update AggregateFunctionSumMap.h 2022-12-27 17:15:48 +03:00
Alexey Milovidov
611bb44288
Merge branch 'master' into fix-30975 2022-12-27 17:15:12 +03:00
Alexey Milovidov
c26ce8a629
Merge pull request #44338 from ClickHouse/mysql-compat-test
Add a test for PowerBI
2022-12-27 17:12:51 +03:00
Alexey Milovidov
ed3d70f7c0
Merge pull request #44623 from azat/build/rust-fix
Fix rust modules rebuild (previously ignores changes in cargo config.toml)
2022-12-27 17:10:33 +03:00
Sergei Trifonov
56b3c6c68f
Merge pull request #44308 from ZhiguoZh/20221216-threadpool-notify
Call std::condition_variable::notify_* without lock in ThreadPool
2022-12-27 15:02:49 +01:00
Mikhail f. Shiryaev
93af1f3f7c
Restart failing workflows up to 30 times 2022-12-27 14:50:37 +01:00
Raúl Marín
948ce8db93 Revert "Merge pull request #38953 from ClickHouse/add-allocation-ptr-to-trace-log"
This reverts commit e99849d031, reversing
changes made to 7ad3ff8a9e.
2022-12-27 14:28:13 +01:00
Azat Khuzhin
e719fd218d Add excludes for std::cout usage in LineReader
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-27 14:23:51 +01:00
Azat Khuzhin
1f9a6076b9 Use DB::ReadBufferFromFile over std::ifstream in ReplxxLineReader
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-27 14:23:51 +01:00