Robert Schulze
330212e0f4
Remove inherited create() method + disallow copying
...
The original motivation for this commit was that shared_ptr_helper used
std::shared_ptr<>() which does two heap allocations instead of
make_shared<>() which does a single allocation. Turned out that
1. the affected code (--> Storages/) is not on a hot path (rendering the
performance argument moot ...)
2. yet copying Storage objects is potentially dangerous and was
previously allowed.
Hence, this change
- removes shared_ptr_helper and as a result all inherited create() methods,
- instead, Storage objects are now created using make_shared<>() by the
caller (for that to work, many constructors had to be made public), and
- all Storage classes were marked as noncopyable using boost::noncopyable.
In sum, we are (likely) not making things faster but the code becomes
cleaner and harder to misuse.
2022-05-02 08:46:52 +02:00
Anton Popov
e8ce091e68
Merge remote-tracking branch 'upstream/master' into HEAD
2022-01-21 20:11:18 +03:00
hexiaoting
5c847264f7
Fix bug for select from VIEW with format and limit settings
2022-01-11 20:19:41 +08:00
Anton Popov
6f4d9a53b2
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-12-01 15:54:33 +03:00
Raúl Marín
b2cfa70541
Reduce dependencies on ASTFunction.h
...
481 -> 230
2021-11-26 18:21:54 +01:00
Raúl Marín
051dddd8df
Reduce dependencies on ASTIdentifier.h
...
Goes from rebuilding 483 objects to 165 when it's modified
2021-11-26 16:49:40 +01:00
Anton Popov
a20922b2d3
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-11-09 15:36:25 +03:00
Nikolai Kochetov
a08c98d760
Move some files.
2021-10-16 17:03:50 +03:00
Nikolai Kochetov
998d29ebc7
Merge branch 'master' into rewrite-pushing-to-views
2021-09-23 13:10:27 +03:00
hhell
fc166570d8
Fix typo in an error message
...
Related: https://github.com/ClickHouse/ClickHouse/issues/20551
2021-09-22 21:33:15 +03:00
Nikolai Kochetov
999a4fe831
Fix other tests.
2021-09-08 21:29:38 +03:00
Anton Popov
61239343e3
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-08-20 16:33:30 +03:00
vdimir
ffab19caad
Fix hasJoin in StorageView.cpp
2021-08-06 13:48:47 +03:00
vdimir
76ca40857a
Better error message for changed json_use_nulls in StorageView, check ast
2021-08-06 12:16:26 +03:00
vdimir
a427b19d3a
Check join_use_nulls changed in StorageView::read
2021-08-05 18:38:52 +03:00
Nikolai Kochetov
fc12310ee8
Revert #24095 . User-level settings will affect queries from view.
2021-08-05 17:17:22 +03:00
Anton Popov
3ed7f5a6cc
dynamic subcolumns: add snapshot for storage
2021-07-09 06:15:41 +03:00
Anton Popov
072e65b728
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-07-07 17:20:38 +03:00
vdimir
80a001ab0c
Use settings from global context in StorageView
2021-06-22 17:39:09 +03:00
vdimir
85bcf8a1dc
Merge branch 'master' into view-join-settings
2021-06-22 17:36:44 +03:00
Anton Popov
0bdf9d207c
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-05-26 00:25:47 +03:00
mergify[bot]
970243850f
Merge branch 'master' into ast-table-identifier-2
2021-05-21 12:56:49 +00:00
vdimir
346dc65140
Save join_use_nulls in SETTINGS section for storage View
2021-05-20 16:47:09 +03:00
vdimir
7e39e8474f
Merge branch 'master' into view-join-settings
2021-05-20 12:08:50 +03:00
vdimir
3193e5358f
Save all changed settings in StorageView
2021-05-14 13:22:56 +03:00
vdimir
701ff6d17d
Save join settings for view
2021-05-13 17:21:55 +03:00
Anton Popov
e44706911e
dynamic columns: better getting of sample block
2021-05-05 02:02:54 +03:00
feng lv
4ffe199d39
Implement table comments
2021-04-23 12:18:23 +00:00
Ivan
a73483751f
Merge branch 'master' into ast-table-identifier-2
2021-04-12 20:23:28 +03:00
Ivan
495c6e03aa
Replace all Context references with std::weak_ptr ( #22297 )
...
* Replace all Context references with std::weak_ptr
* Fix shared context captured by value
* Fix build
* Fix Context with named sessions
* Fix copy context
* Fix gcc build
* Merge with master and fix build
* Fix gcc-9 build
2021-04-11 02:33:54 +03:00
Ivan Lezhankin
3da3250bfd
Merge branch 'master' into ast-table-identifier-2
2021-04-09 17:56:15 +03:00
Nikolai Kochetov
9a39459888
Refactor ActionsDAG
2021-03-04 20:38:12 +03:00
Nikolai Kochetov
15921fbfcb
Remove index by name from ActionsDAG
2021-03-03 23:01:07 +03:00
Nikolai Kochetov
d91b8a3acb
Merge branch 'master' into filter-push-down
2021-02-26 19:33:27 +03:00
Nikolai Kochetov
d328bfa41f
Review fixes. Add setting max_optimizations_to_apply.
2021-02-26 19:29:56 +03:00
alesapin
653d962cdd
Fix style and add low-level check
2021-02-25 17:43:58 +03:00
Nikolai Kochetov
7231a97085
Remove MaterializingStep
2021-02-18 14:15:16 +03:00
Ivan Lezhankin
1002148886
Merge remote-tracking branch 'upstream/master' into ast-table-identifier-2
2020-11-22 22:34:36 +03:00
Nikolai Kochetov
13eceff55c
Remove Converting transform and step.
2020-11-17 20:16:55 +03:00
Ivan Lezhankin
9250d5c4e9
Merge remote-tracking branch 'upstream/master' into ast-table-identifier-2
2020-11-12 16:25:46 +03:00
Nikolai Kochetov
195c941c4e
Merge branch 'master' into storage-read-query-plan
2020-11-10 15:02:22 +03:00
Ivan Lezhankin
4083406f54
Introduce ASTTableIdentifier
2020-10-26 18:49:00 +03:00
Nikolai Kochetov
c5cb05f5f3
Try fix tests.
2020-10-07 14:26:29 +03:00
Azat Khuzhin
b838214a35
Pass non-const SelectQueryInfo (and drop mutable qualifiers)
2020-10-02 22:42:35 +03:00
Nikolai Kochetov
50674a320f
Refactor IStorage::read with query plan.
2020-09-18 14:39:07 +03:00
Nikolai Kochetov
0bf4e8e6e9
Support reading with QueryPlan for StorageView.
2020-09-17 16:22:24 +03:00
Amos Bird
6bd753d85d
TableFunction view.
2020-09-02 16:02:10 +08:00
Nikolai Kochetov
20e63d2271
Refactor Pipe [part 6]
2020-08-06 15:24:05 +03:00
Nikolai Kochetov
2cca4d5fcf
Refactor Pipe [part 2].
2020-08-03 16:54:14 +03:00
alesapin
4c0879ae30
Better logging in storages
2020-06-19 20:17:13 +03:00
