Commit Graph

21215 Commits

Author SHA1 Message Date
alexey-milovidov
2ffc99b893
Merge pull request #6846 from yandex/aku/fixed-hash-table
Cosmetic change: remove redundant functions from FixedHashTable
2019-09-06 20:20:26 +03:00
alexey-milovidov
71ed9477dc
Update FixedHashTable.h 2019-09-06 20:20:19 +03:00
alexey-milovidov
c90dfc1e48
Merge pull request #6837 from filimonov/fix_some_pvs_reported_issues
Fix some pvs reported issues
2019-09-06 20:15:14 +03:00
Alexey Milovidov
1c3fab8f2c Returned support for very old Linux kernels (that lack of F_GETPIPE_SZ fcntl) 2019-09-06 20:10:28 +03:00
Nikolai Kochetov
3bd5d84ecc Update PipelineExecutor. 2019-09-06 19:04:18 +03:00
akazz
f511337028 Fixing minor things 2019-09-06 18:54:33 +03:00
akazz
0f9b91a663 Cosmetic stuff 2019-09-06 18:45:49 +03:00
akazz
e7235cdcfd Minor changes 2019-09-06 18:13:22 +03:00
Alexander Kuzmenkov
cacf6d3282 Key memory management for compound hash tables.
Some aggregation methods initially emplace a temporary StringRef key
into a hash table. Then, if the key was not seen before, they make a
persistent copy of the key and update the hash table with it. This
approach is not suitable for compound hash tables, because the logic of
when the persistent key is needed is more complex, and is contained
within the hash table itself.

In this commit, we switch to managing key memory with callbacks passed
to the hash table, that allow it to request a persistent copy of the key
if it is needed. This should be more appropriate for compound hash
tables.

This commit prepares for StringHashMap PR #5417.
2019-09-06 18:05:28 +03:00
robot-clickhouse
04d2bb9cfd Auto version update to [19.15.1.1] [54426] 2019-09-06 17:58:33 +03:00
robot-clickhouse
f2b775b02e Auto version update to [19.14.1.1274] [54425] 2019-09-06 17:58:04 +03:00
Alexander Kuzmenkov
05095111a1 Cosmetic change: remove redundant functions from FixedHashTable 2019-09-06 17:47:32 +03:00
akazz
13631d2da3 Removed some garbage 2019-09-06 16:58:37 +03:00
Nikolai Kochetov
32cc3a4bee Revert enumerate streams. 2019-09-06 16:28:49 +03:00
Anton Popov
69da4f30b3
Merge branch 'master' into merging_input_function 2019-09-06 16:20:00 +03:00
filimonov
f505549b43
changed wrong pvs suppression code 2019-09-06 14:46:42 +02:00
Nikolai Kochetov
52305cefbc Merge branch 'merging-aggregated-processors' into processors-2 2019-09-06 15:21:17 +03:00
Nikolai Kochetov
d10b7d7a2b Added ConvertingAggregatedToChunksTransform. 2019-09-06 15:19:59 +03:00
alesapin
571ed1bb25
Merge pull request #6840 from filimonov/history_file_from_env
Ability to change history path by changing env
2019-09-06 13:22:49 +03:00
alexey-milovidov
3d8ec8fb33
Merge pull request #6823 from yandex/fancyqlx-master
Merge #6167
2019-09-06 03:18:26 +03:00
alexey-milovidov
05a1a7ac71
Update InterpreterSelectQuery.cpp 2019-09-06 03:18:06 +03:00
alexey-milovidov
18dcb3753d
Merge pull request #6824 from 4ertus2/mjoin
Refactoring (ExpressionAnalyzer & SubqueryForSet)
2019-09-06 03:17:16 +03:00
Mikhail Filimonov
34f393c17e Ability to change history path by changing env 2019-09-06 01:35:25 +02:00
Denis Zhuravlev
50c32490be
Update arrayElement.cpp
Typo in error message ( is -> are )
2019-09-05 19:41:27 -03:00
Olga Khvostikova
4129d8cf60
Merge pull request #6092 from yandex/globs-in-file-one-more-attempt
Globs in storage file and HDFS
2019-09-05 23:05:37 +03:00
Olga Khvostikova
f90642ce23
Merge pull request #6610 from CurtizJ/merging_with_ties_and_with_fill
WITH TIES modifier for LIMIT and WITH FILL modifier for ORDER BY. (continuation of #5069)
2019-09-05 22:45:48 +03:00
akazz
32c77cd933 Dropped weak_ptrs! 2019-09-05 21:09:33 +03:00
stavrolia
5e37510aae Better 2019-09-05 21:09:19 +03:00
Mikhail Filimonov
b40204a360 PVS https://clickhouse-test-reports.s3.yandex.net/0/2cda8f1563e9b2d11f75c68db817c3f68ace1160/pvs_studio_report/pvs-studio-html-report/sources/InterpreterSelectQuery.cpp_24.html#ln430 2019-09-05 19:23:36 +02:00
Mikhail Filimonov
622ea38b21 PVS false positive https://clickhouse-test-reports.s3.yandex.net/0/2cda8f1563e9b2d11f75c68db817c3f68ace1160/pvs_studio_report/pvs-studio-html-report/sources/Context.cpp_21.html#ln1226 2019-09-05 18:59:15 +02:00
Mikhail Filimonov
cfb0431994 PVS https://clickhouse-test-reports.s3.yandex.net/0/2cda8f1563e9b2d11f75c68db817c3f68ace1160/pvs_studio_report/pvs-studio-html-report/sources/executeQuery.cpp_26.html#ln33 2019-09-05 18:57:13 +02:00
akazz
9b55e66755 WIP - About to give up storing weak_ptrs! 2019-09-05 18:19:36 +03:00
akazz
ab6ae7c82b Refactored Clients -> Referers 2019-09-05 18:14:17 +03:00
stavrolia
587a780ba2 Better 2019-09-05 17:42:17 +03:00
CurtizJ
b04cea7463 minor fixes of table function input 2019-09-05 16:17:01 +03:00
akazz
d374a6fb58 Better 2019-09-05 15:49:20 +03:00
akazz
838957f0e2 Cosmetics 2019-09-05 15:45:44 +03:00
akazz
54b4db36eb Changed FastPath + better diagnostics 2019-09-05 15:20:10 +03:00
Vasily Nemkov
c2fc71b5e5 Post-PR fixes
Renamed settings, updated docs.
2019-09-05 13:35:36 +03:00
Nikolai Kochetov
e1e600b8b3 Update test with sample and prewhere. 2019-09-05 10:42:14 +03:00
Alexey Milovidov
a4c1d64aba Allowed to run test with the server run from source tree 2019-09-05 07:50:08 +03:00
Ivan
ab7df6b6dd
Fix kafka tests (#6805)
* Commit offsets more precisely
* Get rid of DelimitedReadBuffer since read buffers don't line up well
* Increase timeouts
2019-09-05 00:25:33 +03:00
stavrolia
5d6959173c Improvement 2019-09-04 22:55:56 +03:00
alexey-milovidov
b310d755fe
Merge pull request #6819 from infinivision/fix_6761_bitmap_mem_leak
fix bitmapSubsetInRange memory leak
2019-09-04 19:58:49 +03:00
Nikolai Kochetov
0d1846baab Update test create table if not exists sample_prewhere 2019-09-04 19:46:10 +03:00
chertus
a395be3e91 minor changes 2019-09-04 19:37:05 +03:00
chertus
b854c945ad some more ExpressionAnalyzer refactoring 2019-09-04 19:20:02 +03:00
Alexey Milovidov
f2c2a2a9ea Fixed unit test 2019-09-04 19:13:05 +03:00
Nikolai Kochetov
3bd453985b Merge branch 'master' of https://github.com/fancyqlx/ClickHouse into fancyqlx-master 2019-09-04 18:48:12 +03:00
alesapin
544dd33b9a
Merge pull request #6816 from yandex/fix_mutations_granularity_bug
Fix bug with mutations after granularity change
2019-09-04 17:49:52 +03:00
Nikolai Kochetov
30155f92bf Try to enumerate streams again. 2019-09-04 17:16:32 +03:00
Nikolai Kochetov
b98676836e Try to enumerate streams again. 2019-09-04 17:06:41 +03:00
Zhichang Yu
cfac445144 fix bitmapSubsetInRange memory leak 2019-09-04 22:05:32 +08:00
Nikolai Kochetov
b9e26d15de Try to enumerate streams again. 2019-09-04 16:17:50 +03:00
Nikolai Kochetov
3a7e7287c0 Update PipelineExecutor. 2019-09-04 15:34:15 +03:00
CurtizJ
7accc09066 Merge branch 'palasonic-add-input-function' of https://github.com/palasonic1/ClickHouse into merging_input_function 2019-09-04 15:25:20 +03:00
alesapin
18ef235a3f Fix indices mrk file extension 2019-09-04 15:22:20 +03:00
alesapin
16a544f300 Fix bug with mutations after granularity change 2019-09-04 15:19:42 +03:00
stavrolia
32bf915610 More docs 2019-09-04 14:11:30 +03:00
chertus
904cfed046 better includes 2019-09-04 13:15:34 +03:00
Nikolai Kochetov
5246be8a17 Update PipelineExecutor. 2019-09-04 12:37:56 +03:00
Alexey Milovidov
6176041935 Fixed style 2019-09-04 02:08:46 +03:00
Alexey Milovidov
ece7a05cec Added an example of query masking rules for developers 2019-09-04 02:07:08 +03:00
CurtizJ
9cfcbd6649 fix bug in FillingBlockInputStream 2019-09-04 01:01:09 +03:00
Alexey Milovidov
843f8303b0 Minor modifications 2019-09-03 23:27:46 +03:00
Alexey Milovidov
9959e8d3e1 Fixed build 2019-09-03 23:07:27 +03:00
alexey-milovidov
b2e80b0cd9
Merge branch 'master' into query_masking 2019-09-03 22:58:15 +03:00
alexey-milovidov
1ae8150f28
Update Context.cpp 2019-09-03 22:53:59 +03:00
alexey-milovidov
4f7d472cb7
Merge pull request #6048 from Akazz/ternary-logic-light
Correct implementation of ternary logic for AND/OR
2019-09-03 22:09:56 +03:00
alexey-milovidov
5f33fd946f
Merge pull request #6711 from dimarub2000/exception_while_insert
Exception check added in client when sending insertion data.
2019-09-03 21:47:48 +03:00
akuzm
357f59cc48
Merge pull request #6667 from yandex/aku/mmap-populate
Pre-fault pages when allocating memory with mmap().
2019-09-03 21:41:53 +03:00
alexey-milovidov
152dba1b2e
Merge pull request #6796 from CurtizJ/fix-flappy-ttl-test
Fix column TTL with user defaults.
2019-09-03 21:35:00 +03:00
Alexey Milovidov
9cf0c780fb Better code 2019-09-03 21:23:13 +03:00
alexey-milovidov
845a612b95
Merge pull request #6773 from infinivision/fix_issue_6575
fix DataTypeAggregateFunction deserialization
2019-09-03 21:19:41 +03:00
Nikolai Kochetov
73c052f576 Revert PipelineExecutor changes. 2019-09-03 21:05:44 +03:00
Artem Zuikov
0a998fddce
Merge pull request #6801 from 4ertus2/mjoin
Refactoring: wrap Join logic via AnalyzedJoin iface
2019-09-03 19:53:49 +03:00
Zhichang Yu
fd0947899d fix 00980_shard_aggregation_state_deserialization.sql 2019-09-03 23:47:09 +08:00
chertus
bb3dedf1dc move Join object from ExpressionAction into AnalyzedJoin 2019-09-03 17:36:02 +03:00
stavrolia
97ac979645 Add docs for hdfs and fix some review comments 2019-09-03 17:23:51 +03:00
Dmitry Rubashkin
40a056c79b Better naming. 2019-09-03 16:55:26 +03:00
alex-zaitsev
9032d8a196
Fixed tcp_keep_alive_timeout description 2019-09-03 16:30:15 +03:00
Nikolai Kochetov
16284b98b5 Disable 00963_achimbab for processors pipeline. 2019-09-03 15:42:24 +03:00
Nikolai Kochetov
5113bd3650 Add task stilling to PipelineExecutor. 2019-09-03 15:06:45 +03:00
alexey-milovidov
87e061d0e1
Merge pull request #6733 from 4ertus2/some
Add subquery_requires_alias setting (disabled by default)
2019-09-03 14:34:28 +03:00
alexey-milovidov
ab75e8c26d
Merge pull request #6205 from zhang2014/fix/some_mutation
fix some mutation bug
2019-09-03 14:33:20 +03:00
Nikolai Kochetov
aa9481e76e Add task stilling to PipelineExecutor. 2019-09-03 14:22:34 +03:00
alexey-milovidov
7847de1947
Merge pull request #6629 from CurtizJ/read-in-order-2
Implement 'read in order' optimization with processors.
2019-09-03 14:21:19 +03:00
Nikolai Kochetov
99476d0039 Add task stilling to PipelineExecutor. 2019-09-03 14:15:37 +03:00
CurtizJ
22badef1a2 Merge remote-tracking branch 'upstream/master' into merging_with_ties_and_with_fill 2019-09-03 13:47:18 +03:00
Anton Popov
aeb1860e62
Update 01006_ttl_with_default_2.sql 2019-09-03 13:31:52 +03:00
CurtizJ
ba98c038ab fix column ttl with user defaults 2019-09-03 13:27:02 +03:00
Nikolai Kochetov
e55647eee9 Force add resize befor aggregating transform. 2019-09-03 13:14:13 +03:00
CurtizJ
6d821c4877 fix build 2019-09-03 13:07:31 +03:00
Zhichang Yu
fb5c11146a added functional test for shard bitmap deserialization 2019-09-03 17:39:15 +08:00
Dmitry Rubashkin
ede0077df6 fix 2019-09-03 12:38:50 +03:00
Dmitry Rubashkin
d2b9990a2a Unexpected packets received in a better way now. 2019-09-03 12:36:16 +03:00
Nikolai Kochetov
702c1b03da Revert to LFStack. 2019-09-03 11:42:26 +03:00
zhang2014
9c50c7c718 fix crash when touches all rows alter 2019-09-03 13:48:02 +08:00
alexey-milovidov
cda9ac7385
Merge pull request #6780 from yandex/fix_mergex_column_only_stream
Move initialization of MergedColumnOnlyStream to constructor
2019-09-03 01:37:51 +03:00
alexey-milovidov
a52874b203
Merge pull request #6709 from yandex/time-zone-configuration
Fixed error with processing "timezone" in server configuration file.
2019-09-03 01:37:26 +03:00
alexey-milovidov
7447d89f1f
Merge pull request #6785 from 4ertus2/mjoin
More JOINs refactoring
2019-09-03 01:36:59 +03:00
CurtizJ
973b533377 Merge remote-tracking branch 'upstream/master' into read-in-order-2 2019-09-03 00:59:51 +03:00
Alexey Milovidov
1903053aa1 Fixed error in test 2019-09-02 22:58:48 +03:00
chertus
fce1b47250 more JOIN refactoring: move logic out of ExpressionAnalyzer/ExpressionAction 2019-09-02 22:58:45 +03:00
Alexey Milovidov
89e86e1d41 Slightly better config management in integration tests 2019-09-02 22:57:09 +03:00
alesapin
04a3db5857 Better test 2019-09-02 22:32:08 +03:00
Alexey Milovidov
5dbafdefdb Merge branch 'master' into time-zone-configuration 2019-09-02 22:15:52 +03:00
Alexey Milovidov
457bc541ee Merge branch 'master' of github.com:yandex/ClickHouse 2019-09-02 22:13:22 +03:00
Alexey Milovidov
2b0af524cb Added a test #2282 2019-09-02 22:13:12 +03:00
alexey-milovidov
5042780423
Merge pull request #6776 from vitlibar/split-test-dictionaries
Split the integration test `test_dictionaries` into 4 separate tests.
2019-09-02 22:07:46 +03:00
alexey-milovidov
f180f7dd3d
Merge pull request #6779 from proller/fix27
CLICKHOUSE-4644 function arrayEnumerateUniqRanked: fix for empty arrays
2019-09-02 21:40:35 +03:00
CurtizJ
257df66b02 fix flappy ttl test 2019-09-02 21:29:56 +03:00
CurtizJ
4fea3e9688 style fixes 2019-09-02 20:18:44 +03:00
Nikolai Kochetov
52ca3f2b4c Add stream enumeration to Processors. 2019-09-02 20:01:03 +03:00
Nikolai Kochetov
cfbb3ce6f9 Add stream enumeration to Processors. 2019-09-02 19:58:24 +03:00
Nikolai Kochetov
5352ac9145 Add stream enumeration to Processors. 2019-09-02 19:57:06 +03:00
Nikolai Kochetov
1f70aee2e6 Add stream enumeration to Processors. 2019-09-02 19:55:01 +03:00
alesapin
5af8c196bd Move initialization of MergedColumnOnlyStream to constructor 2019-09-02 19:31:09 +03:00
proller
184e2ef9ab CLICKHOUSE-4644 arrayEnumerateUniqRanked: fix for empty arrays 2019-09-02 18:49:25 +03:00
Nikolai Kochetov
88044fdc16 Add stream enumeration to Processors. 2019-09-02 18:49:18 +03:00
Alexander Kuzmenkov
fd00889981 Pre-fault mmapped buffers for hash tables.
Mmaped pages are copy-on-write references to the zero page, and are
faulted in on the first write. Hash table resize touches most of the
newly allocated buffer, so it's faster to pre-fault all pages after
allocation, instead of having the resize loop interrupted by page
faults.
2019-09-02 18:38:29 +03:00
Alexander Kuzmenkov
ce120ebc0d Cosmetic change: Remove unused template parameters from Allocator. 2019-09-02 18:38:29 +03:00
CurtizJ
e122d54dcb update comments 2019-09-02 18:22:27 +03:00
Nikolai Kochetov
464595a548 Add allow_processors flag to executeQuery. 2019-09-02 18:19:01 +03:00
Alexey Milovidov
402599a38c Merge branch 'master' into time-zone-configuration 2019-09-02 18:13:54 +03:00
Alexey Milovidov
7bf411548f Merge branch 'master' of github.com:yandex/ClickHouse into add-test-for-deadlock-system-tables 2019-09-02 18:04:15 +03:00
Nikolai Kochetov
52eae3a242 Add stream enumeration to Processors. 2019-09-02 17:55:43 +03:00
alexey-milovidov
a71a1693f0
Merge pull request #6777 from yandex/fix-pvs-warning-in-pipeline-executor
Fix PVS warning in PipelineExecutor.
2019-09-02 17:53:28 +03:00
alexey-milovidov
3f5d0ef2a8
Merge pull request #6775 from yandex/aku/pvs-warning
Remove a redundant condition (found by PVS Studio).
2019-09-02 17:52:25 +03:00
Vitaly Baranov
d64d75eb6d Split the integration test test_dictionaries into 4 separate tests. 2019-09-02 17:50:57 +03:00
Nikolai Kochetov
0016d99f5e Add stream enumeration to Processors. 2019-09-02 17:49:05 +03:00
CurtizJ
de5e2b4d6b Merge remote-tracking branch 'upstream/master' into merging_with_ties_and_with_fill 2019-09-02 17:34:49 +03:00
CurtizJ
da11fb86b7 implement 'with fill' modifier with processors 2019-09-02 17:29:51 +03:00
Vasily Nemkov
f98c488834 Post-review fixes
* Actually using the replica recovery settings for cluster
* A bit of doc on DBMS_CONNECTION_POOL_WITH_FAILOVER_MAX_ERROR_COUNT
* StorageDistributedDirectoryMonitor using settings for ConnectionPoolWithFailover
* Using SettingSeconds instead of SettingUInt64 for replica_error_decrease_period
2019-09-02 17:26:25 +03:00
Vasily Nemkov
84fc4ba4c8 Replica recovery fixes
* Added a limit on how many errors can replica accumulate
* Decreased default error halving time to 60 seconds
* Made both configurable via settings
* Showing errors count and estimated recovery time for each replica in system.clusters
2019-09-02 17:26:25 +03:00
alexey-milovidov
0967ecf03b
Merge pull request #6727 from yandex/merging_template_format
Merging Template format
2019-09-02 17:25:43 +03:00
Alexey Milovidov
dcdd8c6e3c Merge branch 'master' into add-test-for-deadlock-system-tables 2019-09-02 16:39:26 +03:00
Nikolai Kochetov
2eecd35d27 Fix PVS warning in PipelineExecutor. 2019-09-02 16:30:51 +03:00
Alexander Kuzmenkov
ab2bd54022 Remove a redundant condition (found by PVS-Studio). 2019-09-02 16:17:14 +03:00
Nikolai Kochetov
bf0c0ed4f1 Merge branch 'master' into processors-2 2019-09-02 16:02:09 +03:00
chertus
bc95027cee better setting name: joined_subquery_requires_alias 2019-09-02 15:53:31 +03:00
Nikolai Kochetov
278e33cfa3 Try add LFStack. 2019-09-02 15:48:58 +03:00
Nikolai Kochetov
5005c0006c Try add LFStack. 2019-09-02 15:34:18 +03:00
chertus
2c0d569fa8 Merge branch 'master' into some 2019-09-02 15:32:24 +03:00
Zhichang Yu
9e587fb139 fix DataTypeAggregateFunction deserialization 2019-09-02 20:09:40 +08:00
Nikolai Kochetov
6221a42fcc Comment out all stopwatchs in PipelineExecutor. 2019-09-02 14:02:08 +03:00
Alexander Tokmakov
3da233ef42 fix build 2019-09-02 13:47:06 +03:00
Alexander Tokmakov
e2928481a3 Merge branch 'master' into merging_template_format 2019-09-02 12:41:34 +03:00
Alexey Milovidov
85f45747a5 Fixed test 2019-09-02 04:04:41 +03:00
Alexey Milovidov
951079c457 Updated test 2019-09-02 04:00:58 +03:00