Commit Graph

57328 Commits

Author SHA1 Message Date
hexiaoting
a379779f87 Merge remote-tracking branch 'origin/master' into dev_mod and add more test cases 2021-02-05 17:09:14 +08:00
zhangxiao871
e00e7ae56e add test. 2021-02-05 17:08:13 +08:00
zhangxiao871
7738f86ec8 add test. 2021-02-05 17:02:27 +08:00
Vitaly Baranov
1c51b4a4e4 MongoDB table engine now establishes connection only when it reads data. 2021-02-05 11:47:31 +03:00
gyuton
29c01ed9d0
Update docs/en/engines/table-engines/mergetree-family/mergetree.md
Co-authored-by: Anna <42538400+adevyatova@users.noreply.github.com>
2021-02-05 11:41:57 +03:00
gyuton
fd74aca6c5
Update docs/en/operations/settings/merge-tree-settings.md
Co-authored-by: Anna <42538400+adevyatova@users.noreply.github.com>
2021-02-05 11:41:49 +03:00
George
75c6bc9233 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into gyuton-DOCSUP-6295-Update_isIPv4String-andisIPv6String-functions 2021-02-05 11:39:30 +03:00
George
932589744c Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into gyuton-DOCSUP-5788-Document_the_optimize_on_insert_setting 2021-02-05 11:36:25 +03:00
George
38c2add4f7 Added translation 2021-02-05 11:15:11 +03:00
George
5ca0007255 Updated description 2021-02-05 11:14:51 +03:00
bharatnc
8c60e84067 Docs - minor fixes 2021-02-05 00:10:10 -08:00
bharatnc
606c914bb5 Docs - timestamp_add|sub 2021-02-05 00:03:45 -08:00
vdimir
1e2c302248
Merge pull request #18377 from Jokser/disk-s3-backup-restore-metadata 2021-02-05 10:44:59 +03:00
bharatnc
3becb80c13 Docs - date_add, date_diff 2021-02-04 23:43:03 -08:00
alesapin
ab98040003 More logs 2021-02-05 10:15:28 +03:00
Alexander Kuzmenkov
7bca563e5a
Merge pull request #20068 from ClickHouse/aku/long-flaky
detect unmarked long tests in flaky check
2021-02-05 10:07:19 +03:00
Alexander Kuzmenkov
cb791dbc7f
Update 01443_merge_truncate_long.sh 2021-02-05 10:06:53 +03:00
Alexander Kuzmenkov
a1bcd4b128
Update 01232_preparing_sets_race_condition_long.sh 2021-02-05 10:06:39 +03:00
Alexander Kuzmenkov
52b52ede22
Update 00840_long_concurrent_select_and_drop_deadlock.sh 2021-02-05 10:06:17 +03:00
zhangxiao871
581495ae23 Supports system.zookeeper path IN query. 2021-02-05 14:45:28 +08:00
alexey-milovidov
34151eea2c
Merge pull request #20067 from ClickHouse/mod-negative-type-promotion
Add type promotion for modulo of division of negative number
2021-02-05 09:31:46 +03:00
hexiaoting
b892fff406 Add alexey's fix: using another logic and more comments 2021-02-05 10:31:16 +08:00
Russ Frank
2f31eabc13 turn off ubsan for deltasum functions 2021-02-04 21:22:05 -05:00
Ivan
d135a727e2
Merge branch 'master' into better-read-buffers-2 2021-02-05 02:17:05 +03:00
Ivan Lezhankin
d59b45e496 Fix build 2021-02-05 02:14:17 +03:00
Azat Khuzhin
64c0bf9829 TCPHandler: catch exceptions from the WriteBuffer in destructor
For TCPHandler it is safe thing todo.

Otherwise *San will report [1]:

    2021.01.24 15:33:40.103996 [ 270 ] {} <Trace> BaseDaemon: Received signal -1
    2021.01.24 15:33:40.110693 [ 270 ] {} <Fatal> BaseDaemon: (version 21.2.1.5789, build id: FF421B087D1E2EAA19FA17B5AB3AE413832744E0) (from thread 48318) Terminate called for uncaught exception:
    2021.01.24 15:33:40.114845 [ 270 ] {} <Trace> BaseDaemon: Received signal 6
    2021.01.24 15:33:40.138738 [ 218027 ] {} <Fatal> BaseDaemon: ########################################
    2021.01.24 15:33:40.138838 [ 218027 ] {} <Fatal> BaseDaemon: (version 21.2.1.5789, build id: FF421B087D1E2EAA19FA17B5AB3AE413832744E0) (from thread 48318) (no query) Received signal Aborted (6)
    2021.01.24 15:33:40.138912 [ 218027 ] {} <Fatal> BaseDaemon:
    2021.01.24 15:33:40.139277 [ 218027 ] {} <Fatal> BaseDaemon: Stack trace: 0x7f185474118b 0x7f1854720859 0xaddc0cc 0x2af9fab8 0x2af9fa04 0xa91758b 0x1e418bb5 0x20725b4f 0x20725d9e 0x266b47a3 0x269772f5 0x26971847 0x7f18548f6609 0x7f185481d293
    2021.01.24 15:33:40.139637 [ 218027 ] {} <Fatal> BaseDaemon: 3. raise @ 0x4618b in /usr/lib/x86_64-linux-gnu/libc-2.31.so
    2021.01.24 15:33:40.140113 [ 218027 ] {} <Fatal> BaseDaemon: 4. abort @ 0x25859 in /usr/lib/x86_64-linux-gnu/libc-2.31.so
    2021.01.24 15:33:40.144121 [ 218027 ] {} <Fatal> BaseDaemon: 5. ./obj-x86_64-linux-gnu/../base/daemon/BaseDaemon.cpp:0: terminate_handler() @ 0xaddc0cc in /usr/bin/clickhouse
    2021.01.24 15:33:40.151208 [ 218027 ] {} <Fatal> BaseDaemon: 6. ./obj-x86_64-linux-gnu/../contrib/libcxxabi/src/cxa_handlers.cpp:61: std::__terminate(void (*)()) @ 0x2af9fab8 in /usr/bin/clickhouse
    2021.01.24 15:33:40.153085 [ 218027 ] {} <Fatal> BaseDaemon: 7. ./obj-x86_64-linux-gnu/../contrib/libcxxabi/src/cxa_handlers.cpp:0: std::terminate() @ 0x2af9fa04 in /usr/bin/clickhouse
    2021.01.24 15:33:40.155209 [ 218027 ] {} <Fatal> BaseDaemon: 8. ? @ 0xa91758b in /usr/bin/clickhouse
    2021.01.24 15:33:40.156621 [ 218027 ] {} <Fatal> BaseDaemon: 9. ./obj-x86_64-linux-gnu/../src/IO/WriteBufferFromPocoSocket.cpp:0: DB::WriteBufferFromPocoSocket::~WriteBufferFromPocoSocket() @ 0x1e418bb5 in /usr/bin/clickhouse
    2021.01.24 15:33:40.161041 [ 218027 ] {} <Fatal> BaseDaemon: 10. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2518: DB::TCPHandler::~TCPHandler() @ 0x20725b4f in /usr/bin/clickhouse
    2021.01.24 15:33:40.164557 [ 218027 ] {} <Fatal> BaseDaemon: 11. ./obj-x86_64-linux-gnu/../src/Server/TCPHandler.h:101: DB::TCPHandler::~TCPHandler() @ 0x20725d9e in /usr/bin/clickhouse
    2021.01.24 15:33:40.165921 [ 218027 ] {} <Fatal> BaseDaemon: 12. ./obj-x86_64-linux-gnu/../contrib/poco/Foundation/include/Poco/AtomicCounter.h:314: Poco::Net::TCPServerDispatcher::run() @ 0x266b47a3 in /usr/bin/clickhouse
    2021.01.24 15:33:40.167347 [ 218027 ] {} <Fatal> BaseDaemon: 13. ./obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/ThreadPool.cpp:0: Poco::PooledThread::run() @ 0x269772f5 in /usr/bin/clickhouse
    2021.01.24 15:33:40.169401 [ 218027 ] {} <Fatal> BaseDaemon: 14. ./obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/Thread_POSIX.cpp:0: Poco::ThreadImpl::runnableEntry(void*) @ 0x26971847 in /usr/bin/clickhouse
    2021.01.24 15:33:40.169498 [ 218027 ] {} <Fatal> BaseDaemon: 15. start_thread @ 0x9609 in /usr/lib/x86_64-linux-gnu/libpthread-2.31.so
    2021.01.24 15:33:40.169566 [ 218027 ] {} <Fatal> BaseDaemon: 16. __clone @ 0x122293 in /usr/lib/x86_64-linux-gnu/libc-2.31.so
    2021.01.24 15:33:41.027601 [ 218027 ] {} <Fatal> BaseDaemon: Calculated checksum of the binary: 63D7491B39260494BA0D785E1860B427. There is no information about the reference checksum.

  [1]: https://clickhouse-test-reports.s3.yandex.net/19451/1e16bd6f337985a82fbdf4eded695dc6e663af58/stress_test_(address).html#fail1

v2: Fix catching errors in WriteBufferFromPocoSocket destructor
2021-02-05 01:32:36 +03:00
Azat Khuzhin
98e3a99a88 Do not catch exceptions during final flush in writers destructors
Since this hides real problems, since destructor does final flush and if
it fails, then data will be lost.

One of such examples if MEMORY_LIMIT_EXCEEDED exception, so lock
exceptions from destructors, by using
MemoryTracker::LockExceptionInThread to block these exception, and allow
others (so std::terminate will be called, since this is c++11 with
noexcept for destructors by default).

Here is an example, that leads to empty block in the distributed batch:

    2021.01.21 12:43:18.619739 [ 46468 ] {7bd60d75-ebcb-45d2-874d-260df9a4ddac} <Error> virtual DB::CompressedWriteBuffer::~CompressedWriteBuffer(): Code: 241, e.displayText() = DB::Exception: Memory limit (for user) exceeded: would use 332.07 GiB (attempt to allocate chunk of 4355342 bytes), maximum: 256.00 GiB, Stack trace (when copying this message, always include the lines below):

    0. DB::Exception::Exception<>() @ 0x86f7b88 in /usr/bin/clickhouse
    ...
    4. void DB::PODArrayBase<>::resize<>(unsigned long) @ 0xe9e878d in /usr/bin/clickhouse
    5. DB::CompressedWriteBuffer::nextImpl() @ 0xe9f0296 in /usr/bin/clickhouse
    6. DB::CompressedWriteBuffer::~CompressedWriteBuffer() @ 0xe9f0415 in /usr/bin/clickhouse
    7. DB::DistributedBlockOutputStream::writeToShard() @ 0xf6bed4a in /usr/bin/clickhouse
2021-02-05 01:31:45 +03:00
Azat Khuzhin
4beb5c1b8a TCPHandler: Move constructor into the module and add missing headers 2021-02-05 01:31:42 +03:00
Azat Khuzhin
a46d65f99d Fix typo in comment for memoryTrackerCanThrow() 2021-02-05 01:29:46 +03:00
Azat Khuzhin
48b415d3e4 Remove never existing insert_in_memory_parts_timeout
Fixes: a43cb93be5 ("remove questionable functionality")
Cc: @CurtizJ
2021-02-05 01:26:40 +03:00
Ivan
0db2aa3c2e
Check that position doesn't go beyond end (#20039) 2021-02-05 01:21:24 +03:00
Nikolai Kochetov
d9aa1096cf Build actions dag to evaluate missing defaults. 2021-02-04 23:36:50 +03:00
vdimir
91ea99129e
Merge pull request #19999 from kreuzerkrieg/change_the_idisk_interface
return `DiskType` instead of `String` in IDisk::getType()
2021-02-04 22:46:54 +03:00
Alexey Milovidov
d2c1a97d86 Minor modification 2021-02-04 22:41:17 +03:00
alesapin
c5312bf362 Trying to disable suspicious parameter 2021-02-04 22:29:46 +03:00
Russ Frank
bcf5a70e4f check arg type 2021-02-04 14:28:45 -05:00
Ivan Lezhankin
84b88c6802 CC 2021-02-04 22:06:43 +03:00
Alexey Milovidov
19c38c61e6 Add fuzzer for ColumnsDescription 2021-02-04 22:03:56 +03:00
Ivan Lezhankin
2b9909d396 Merge remote-tracking branch 'upstream/master' into better-read-buffers-2 2021-02-04 21:51:23 +03:00
Ivan Lezhankin
bcbe6f209c Merge branch 'better-read-buffers-1' into better-read-buffers-2 2021-02-04 21:50:31 +03:00
Ivan Lezhankin
610d7b755b Don't forget to update position of inner buffer 2021-02-04 21:50:15 +03:00
Alexander Kuzmenkov
cea2fcb18c
Update index.md 2021-02-04 21:17:25 +03:00
Alexander Kuzmenkov
6160502665
Update index.md 2021-02-04 21:16:26 +03:00
Alexander Kuzmenkov
a500bd70a4
Update index.md 2021-02-04 21:14:02 +03:00
Alexander Kuzmenkov
56087f4569
Merge pull request #20060 from ClickHouse/aku/window-prototype-2
ROWS OFFSET frame end
2021-02-04 20:59:38 +03:00
Alexander Kuzmenkov
26020daca5 Merge remote-tracking branch 'origin/master' into HEAD 2021-02-04 20:58:25 +03:00
Alexander Kuzmenkov
08691fef45
Merge pull request #20041 from ClickHouse/aku/window-prototype
CURRENT ROW frame start for RANGE frame
2021-02-04 20:55:05 +03:00
Alexander Kuzmenkov
3796a183ba Merge remote-tracking branch 'origin/master' into HEAD 2021-02-04 20:54:36 +03:00
Alexander Kuzmenkov
b0fba3dece mark as long 2021-02-04 20:51:32 +03:00
Russ Frank
43f9bfd1fe merge tests 2021-02-04 11:55:37 -05:00