Commit Graph

43817 Commits

Author SHA1 Message Date
Azat Khuzhin
4669951db5 Fix timeout for hedged requests
Reset the timeout for hedged requests after each packet (such as
Progress packets) to avoid triggering send_timeout/receive_timeout as a
total timeout for the query in some cases.

Here is a simple query that demonstrates the problem:

    select * from remote('127.2', view(select sleep(3) from system.one)) settings receive_timeout=1

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-07-16 07:48:48 +02:00
robot-ch-test-poll
3b0a4040cd
Merge pull request #51876 from evillique/fix-mongodb-inserts
Fix inserts into MongoDB tables
2023-07-16 05:28:43 +02:00
robot-clickhouse-ci-2
ac3cc1c2ff
Merge pull request #45671 from ClibMouse/feature/interval-kql-style-formatting
Implement KQL-style formatting for Interval
2023-07-16 04:06:54 +02:00
robot-ch-test-poll
67492bc2ed
Merge pull request #52122 from azat/keeper-stat-zxid
Print Zxid in keeper stat command in hex (so as ZooKeeper)
2023-07-16 03:28:53 +02:00
Alexey Milovidov
9a421369d7
Merge pull request #49709 from amosbird/fix_49695
Fix projection with optimize_aggregators_of_group_by_keys
2023-07-16 04:10:54 +03:00
Alexey Milovidov
7e6551dbd0
Merge branch 'master' into fix-mongodb-inserts 2023-07-16 01:47:52 +03:00
robot-ch-test-poll3
9e7361a0f6
Merge pull request #52135 from ucasfl/alias
Add array_agg as alias of groupArray for PostgreSQL compatibility
2023-07-15 21:14:38 +02:00
Alexey Milovidov
0eab3276f5
Merge branch 'master' into keeper-stat-zxid 2023-07-15 19:07:48 +03:00
robot-clickhouse
d365fade94
Merge pull request #52128 from azat/distributed-ddl-version
Bump version of the distributed_ddl_entry_format_version to 5 by default
2023-07-15 18:07:01 +02:00
flynn
290c145acf Add array_agg as alias of groupArray for PostgreSQL compatibility 2023-07-15 14:53:46 +00:00
Vitaly Baranov
2f23b6a593
Merge branch 'master' into backups-native-copy 2023-07-15 08:40:17 +02:00
Azat Khuzhin
7d3b28f9c3 Bump version of the distributed_ddl_entry_format_version to 5 by default
This will enable the following features for distributed DDL queries:
- opentelemetry support (#41484)
- initial_query_id pass through (#50015)

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-07-15 08:06:21 +02:00
Alexey Milovidov
9307e60c20
Revert "Millisecond and microsecond support in date_diff / age functions" 2023-07-14 23:21:26 +03:00
Azat Khuzhin
6abdde12ca Print Zxid in keeper stat command in hex (so as ZooKeeper)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-07-14 21:17:09 +02:00
robot-ch-test-poll1
186669a04a
Merge pull request #50365 from HarryLeeIBM/hlee-s390x-crc32
Fix CRC32(WeakHash) issue for s390x
2023-07-14 19:00:01 +02:00
robot-ch-test-poll
93b40c490f
Merge pull request #51945 from arenadata/ADQM-950-B
Implement support of date/time format specifiers in log and error log file names
2023-07-14 18:54:27 +02:00
taiyang-li
8ea3bf4ade improve ch to arrow 2023-07-14 16:09:22 +08:00
robot-clickhouse-ci-1
57c3941fa6
Merge pull request #51807 from ClickHouse/check_not_empty_header_for_remote
Make sure that we don't attempt to serialize/deserialize block with 0 columns and non-zero rows
2023-07-13 12:15:38 +02:00
Han Fei
f3684f78b7
Merge pull request #51720 from arenadata/ADQM-970
Added a crash log flush to the disk after the unexpected crash.
2023-07-13 10:49:07 +02:00
robot-ch-test-poll2
9df928eb13
Merge pull request #52028 from nicelulu/master
Update CompletedPipelineExecutor exception log name
2023-07-13 00:18:09 +02:00
robot-ch-test-poll3
484bf00c06
Merge pull request #52036 from ZhiguoZh/20230711-ontime-get128-inline
Inline SipHash::get128(char *)
2023-07-12 07:20:01 +02:00
Amos Bird
52246ab5b5
Ignore setting constraints for projection ASTs 2023-07-12 10:34:36 +08:00
pufit
12432ac582
Merge pull request #51290 from arenadata/Fix-formatDateTime-with-fractional-negative-datetime64
Fix formatDateTime() with fractional negative datetime64
2023-07-11 19:55:49 -04:00
robot-ch-test-poll3
ea7ff2f37e
Merge pull request #51723 from arenadata/ADQM-956
Added ASK_PASSWORD client constant instead of hardcoded '\n'
2023-07-12 00:37:59 +02:00
robot-ch-test-poll4
139f59f51f
Merge pull request #52038 from azat/s3-plain-send_metadata
Prohibit send_metadata for s3_plain disks
2023-07-12 00:37:50 +02:00
Alexey Gerasimchuck
7b4e7cd203
Merge branch 'master' into ADQM-970 2023-07-12 07:44:54 +10:00
robot-clickhouse-ci-1
1eef5086d4
Merge pull request #52030 from myrrc/feature/auto-reload-tls-certs
Watch for certificate files updates in ConfigReloader
2023-07-11 23:41:19 +02:00
Nikolai Kochetov
62b4b448da
Merge pull request #51954 from ClickHouse/vdimir/fix_race_in_remove_objects
Check refcount in `RemoveManyObjectStorageOperation::finalize` instead of `execute`
2023-07-11 23:17:50 +02:00
Dmitry Kardymon
2a7bbf5d48 Merge remote-tracking branch 'origin/master' into Fix-formatDateTime-with-fractional-negative-datetime64 2023-07-11 19:56:22 +00:00
HarryLeeIBM
1b403ab3e6 Fix crc32(WeakHash) issue for s390x 2023-07-11 14:15:33 -04:00
Azat Khuzhin
326d51c3fb Prohibit send_metadata for s3_plain disks
send_metadata changes the filenames (includes revision), while
s3_plain do not care about this, and expect that the file name
will not be changed.

So during initialization s3_plain will do some basic checks and will
write file clickhouse_access_check_e0f72fcc-d6f8-44fe-8997-96cb87767515, but instead
r0000000000000000000000000000000000000000000000000000000000000001-file-clickhouse_access_check_e0f72fcc-d6f8-44fe-8997-96cb87767515
will be written, later read will not find the file and it will fail:

    Application: Code: 33. DB::Exception: Cannot read all data. Bytes read: 0. Bytes expected: 4.: While checking access for disk s3_plain: Cannot attach table `system`.`crash_log` ...

And besides, send_metadata does not make sense for s3_plain.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-07-11 18:34:23 +02:00
Zhiguo Zhou
b0fb96c8b6 Inline SipHash::get128(char *)
The SipHash-128 values of the strings are calculated and stored in
a set when the UniqExact aggregate function is applied to a Column-
String, as the following snippet shows:

StringRef value = column.getDataAt(row_num);
UInt128 key;
SipHash hash;
hash.update(value.data, value.size);
hash.get128(key);

The implementation of SipHash requires an internal 8-byte buffer,
current_word (or current_bytes), for holding the input data in the
cross function calls of SipHash::update and SipHash::get128. But,
in the above situation, where the update and get128 only take place
once, the copy of input data to the buffer is unnecessary.

With get128 inlined, the compiler could optimize the code as a whole
and reduce the unexpected memory operations, and as a result, the
query performance is improved.
2023-07-11 23:17:55 +08:00
Amos Bird
a33b90c648
Projection & optimize_group_by_function_keys 2023-07-11 21:11:28 +08:00
Amos Bird
1739bb306a
Projection & optimize_aggregators_of_group_by_keys
Fix projection with optimize_aggregators_of_group_by_keys = true
2023-07-11 21:11:27 +08:00
Mike Kot
da3de04470 fix 2023-07-11 12:27:23 +00:00
Alexander Gololobov
9757e272b9 Check number of rows in the reader instead 2023-07-11 12:24:16 +02:00
Alexander Gololobov
6d712f595a Make sure that remote query has non-zero columns 2023-07-11 12:24:16 +02:00
Mike Kot
062b1c464c watch for certificate file updates in configreloader 2023-07-11 10:04:43 +00:00
Ilya Yatsishin
627e924a1b
Merge pull request #51696 from CheSema/write-to-finalized
fix write to finalized buffer
2023-07-11 11:48:49 +02:00
Nikolai Kochetov
ab6356f9bc
Merge branch 'master' into vdimir/fix_race_in_remove_objects 2023-07-11 11:22:04 +02:00
xiao
bc16531876
Update CompletedPipelineExecutor.cpp 2023-07-11 17:01:56 +08:00
Dmitry Kardymon
44550d8cdd Merge remote-tracking branch 'origin/master' into ADQM-868 2023-07-11 08:27:01 +00:00
Dmitry Kardymon
2edb529a93 Merge remote-tracking branch 'origin/master' into Fix-formatDateTime-with-fractional-negative-datetime64 2023-07-11 08:26:07 +00:00
Alexey Gerasimchuck
800807c8a2
Merge branch 'master' into ADQM-970 2023-07-11 16:02:31 +10:00
Alexey Gerasimchuck
8f882b270e
Merge branch 'master' into ADQM-956 2023-07-11 16:02:14 +10:00
vdimir
bd5f393515
Always remove blobs in MetadataStorageFromPlainObjectStorageTransaction::unlinkMetadata 2023-07-11 05:14:39 +00:00
ltrk2
9a74b97184 Improve naming 2023-07-10 13:51:49 -04:00
Alexey Milovidov
ba267f05c9 Update DataTypeInterval.cpp 2023-07-10 13:51:49 -04:00
Alexey Milovidov
8b3848affe Update DataTypeInterval.cpp 2023-07-10 13:51:49 -04:00
ltrk2
54c7e6504f Fix style issues 2023-07-10 13:51:49 -04:00