avogar
92db86b829
Merge branch 'master' of github.com:ClickHouse/ClickHouse into variant-data-type
2024-01-28 14:33:49 +00:00
Maksim Kita
07750ee949
Added AtomicLogger
2024-01-28 13:55:44 +03:00
alesapin
7022ca9ece
Fix _block_number column with non-default serializations and mutation
2024-01-27 20:24:03 +01:00
Anton Popov
9d3b4e5308
lower memory usage
2024-01-27 16:40:11 +00:00
Azat Khuzhin
d94547d338
Use fresh ZooKeeper client on DROP (to have higher chances on success)
...
In case of DROP the client can be expired, and even though
StorageReplicatedMergeTree::drop() uses getZooKeeperIfTableShutDown(),
which creates new client if current is expired, it is not enough, since
current_zookeeper (cached client) will be used implicitly from
dropAllData().
This had been found by stress tests, that leads to DROP query hang [1].
[1]: https://s3.amazonaws.com/clickhouse-test-reports/59255/94eb33ef27a9ab7c4a99af40772ea287e67efcbf/stress_test__tsan_.html
<details>
<summary>stacktrace</summary>
2024.01.26 17:41:41.138577 [ 3319 ] {} <Error> DatabaseCatalog: Cannot drop table test_vzfk1xoc.alter_table1 (455a674c-161d-44d8-abc2-fd205bad1116). Will retry later.: Code: 999. Coordination::Exception: Session expired. (KEEPER_EXCEPTION), Stack trace (when copying this message, always include the lines below):
0. ./contrib/llvm-project/libcxx/include/exception:134: Poco::Exception::Exception(String const&, int) @ 0x000000001e06a5e3 in /usr/bin/clickhouse
1. ./build_docker/./src/Common/Exception.cpp:96: DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0x000000000f697c74 in /usr/bin/clickhouse
2. ./src/Common/Exception.h:0: Coordination::Exception::Exception<char const (&) [16]>(char const (&) [16], Coordination::Error) @ 0x000000001adc298b in /usr/bin/clickhouse
3. ./src/Common/ZooKeeper/IKeeper.h:0: Coordination::ZooKeeper::pushRequest(Coordination::ZooKeeper::RequestInfo&&) @ 0x000000001adfb418 in /usr/bin/clickhouse
4. ./build_docker/./src/Common/ZooKeeper/ZooKeeperImpl.cpp:1343: Coordination::ZooKeeper::get(String const&, std::function<void (Coordination::GetResponse const&)>, std::shared_ptr<std::function<void (Coordination::WatchResponse const&)>>) @ 0x000000001adfd8e5 in /usr/bin/clickhouse
5. ./contrib/llvm-project/libcxx/include/__functional/function.h:818: ? @ 0x000000001ad890bd in /usr/bin/clickhouse
6. ./contrib/llvm-project/libcxx/include/__functional/function.h:818: ? @ 0x000000001ad88a36 in /usr/bin/clickhouse
7. ./build_docker/./src/Common/ZooKeeper/ZooKeeper.cpp:580: zkutil::ZooKeeper::tryGetWatch(String const&, String&, Coordination::Stat*, std::function<void (Coordination::WatchResponse const&)>, Coordination::Error*) @ 0x000000001ad898bf in /usr/bin/clickhouse
8. ./build_docker/./src/Common/ZooKeeper/ZooKeeper.cpp:570: zkutil::ZooKeeper::tryGet(String const&, String&, Coordination::Stat*, std::shared_ptr<Poco::Event> const&, Coordination::Error*) @ 0x000000001ad89554 in /usr/bin/clickhouse
9. ./build_docker/./src/Common/ZooKeeper/ZooKeeperWithFaultInjection.cpp:0: DB::ZooKeeperWithFaultInjection::tryGet(String const&, String&, Coordination::Stat*, std::shared_ptr<Poco::Event> const&, Coordination::Error*) @ 0x000000001ae110dc in /usr/bin/clickhouse
10. ./contrib/llvm-project/libcxx/include/__memory/shared_ptr.h:701: DB::StorageReplicatedMergeTree::unlockSharedDataByID(String, String const&, DB::MergeTreePartInfo const&, String const&, String const&, std::shared_ptr<DB::ZooKeeperWithFaultInjection> const&, DB::MergeTreeSettings const&, std::shared_ptr<Poco::Logger>, String const&, StrongTypedef<unsigned int, DB::MergeTreeDataFormatVersionTag>) @ 0x000000001975527e in /usr/bin/clickhouse
11. ./build_docker/./src/Storages/StorageReplicatedMergeTree.cpp:0: DB::StorageReplicatedMergeTree::removeSharedDetachedPart(std::shared_ptr<DB::IDisk>, String const&, String const&, String const&, String const&, String const&, std::shared_ptr<DB::Context const> const&, std::shared_ptr<zkutil::ZooKeeper> const&) @ 0x000000001976c980 in /usr/bin/clickhouse
12. ./build_docker/./src/Storages/StorageReplicatedMergeTree.cpp:10171: DB::StorageReplicatedMergeTree::removeDetachedPart(std::shared_ptr<DB::IDisk>, String const&, String const&) @ 0x000000001976bdc6 in /usr/bin/clickhouse
13. ./build_docker/./src/Storages/MergeTree/MergeTreeData.cpp:2798: DB::MergeTreeData::dropAllData() @ 0x0000000019c643c8 in /usr/bin/clickhouse
14. ./build_docker/./src/Storages/StorageReplicatedMergeTree.cpp:1117: DB::StorageReplicatedMergeTree::drop() @ 0x0000000019664e0a in /usr/bin/clickhouse
15. ./build_docker/./src/Interpreters/DatabaseCatalog.cpp:0: DB::DatabaseCatalog::dropTableFinally(DB::DatabaseCatalog::TableMarkedAsDropped const&) @ 0x0000000017bf1fac in /usr/bin/clickhouse
16. ./build_docker/./src/Interpreters/DatabaseCatalog.cpp:0: DB::DatabaseCatalog::dropTableDataTask() @ 0x0000000017bf175e in /usr/bin/clickhouse
17. ./contrib/llvm-project/libcxx/include/__functional/function.h:717: ? @ 0x0000000017bf94c2 in /usr/bin/clickhouse
18. ./contrib/llvm-project/libcxx/include/__functional/function.h:0: ? @ 0x00000000170bd0b8 in /usr/bin/clickhouse
19. ./contrib/llvm-project/libcxx/include/__memory/shared_ptr.h:701: DB::BackgroundSchedulePool::threadFunction() @ 0x00000000170c06ce in /usr/bin/clickhouse
20. ./build_docker/./src/Core/BackgroundSchedulePool.cpp:0: void std::__function::__policy_invoker<void ()>::__call_impl<std::__function::__default_alloc_func<ThreadFromGlobalPoolImpl<false>::ThreadFromGlobalPoolImpl<DB::BackgroundSchedulePool::BackgroundSchedulePool(unsigned long, StrongTypedef<unsigned long, CurrentMetrics::MetricTag>, StrongTypedef<unsigned long, CurrentMetrics::MetricTag>, char const*)::$_0>(DB::BackgroundSchedulePool::BackgroundSchedulePool(unsigned long, StrongTypedef<unsigned long, CurrentMetrics::MetricTag>, StrongTypedef<unsigned long, CurrentMetrics::MetricTag>, char const*)::$_0&&)::'lambda'(), void ()>>(std::__function::__policy_storage const*) @ 0x00000000170c0feb in /usr/bin/clickhouse
21. ./base/base/../base/wide_integer_impl.h:809: ThreadPoolImpl<std::thread>::worker(std::__list_iterator<std::thread, void*>) @ 0x000000000f7c6a2f in /usr/bin/clickhouse
22. ./contrib/llvm-project/libcxx/include/__memory/unique_ptr.h:302: void* std::__thread_proxy[abi:v15000]<std::tuple<std::unique_ptr<std::__thread_struct, std::default_delete<std::__thread_struct>>, void ThreadPoolImpl<std::thread>::scheduleImpl<void>(std::function<void ()>, Priority, std::optional<unsigned long>, bool)::'lambda0'()>>(void*) @ 0x000000000f7cc8f2 in /usr/bin/clickhouse
23. ? @ 0x000000000733904f in /usr/bin/clickhouse
24. ? @ 0x00007f28b2319ac3
25. ? @ 0x00007f28b23ab850
</details>
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-27 16:04:18 +01:00
kssenii
0a21e6aa5d
Fix
2024-01-26 19:07:30 +01:00
avogar
5833641fa5
Merge branch 'master' of github.com:ClickHouse/ClickHouse into variant-data-type
2024-01-26 16:54:02 +00:00
Kruglov Pavel
8fcedddcda
Fix abort in iceberg metadata on bad file paths
2024-01-26 17:46:49 +01:00
Azat Khuzhin
90ab986be6
Revert "Prohibit CREATE on static storages (ATTACH should be used instead)"
...
CREATE is used by Replicated database even for ATTACH, and anyway ATTACH
creates format_version.txt as well (without previuos patch).
This reverts commit 323f1f320ebe7e588d443abf78efa2c60193e7a9.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-26 16:47:36 +01:00
Azat Khuzhin
7ba31bf55c
Do not create format_version.txt on write-once storages
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-26 16:47:36 +01:00
Azat Khuzhin
66a40bda0a
Revert "Prohibit DROP from static storages"
...
It is actually OK to DROP at least from read-only disk, as for the
write-once it should be OK as well, since CREATE is prohibited anyway,
so there should be no leftovers
CI: https://s3.amazonaws.com/clickhouse-test-reports/59170/c82050d1925439f0ede2b32acb5b1b8df4acae5d/stress_test__asan_.html
CI: https://s3.amazonaws.com/clickhouse-test-reports/59170/c82050d1925439f0ede2b32acb5b1b8df4acae5d/integration_tests__asan__[3_4].html
This reverts commit 082e62712c5e2f4c48d1abc6141ccfd1249d26b4.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-26 16:47:35 +01:00
Azat Khuzhin
aafc149c1e
Prohibit CREATE on static storages (ATTACH should be used instead)
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-26 16:47:35 +01:00
Azat Khuzhin
1ee723d50d
Prohibit DROP from static storages
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-26 16:47:35 +01:00
Azat Khuzhin
f3b4f28f0d
Disable mutable operations into {Replicated,}MergeTree with static storage
...
Mutable operations includes:
- INSERT
- OPTIMIZE
- parts manipulation
- ...
But does not include DROP, since you need an ability to DROP it.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-26 16:47:35 +01:00
Azat Khuzhin
6751e01cc3
Do not drop parts for static (ro/write-once) storages for Replicated engine
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-26 16:47:35 +01:00
kssenii
5cd757dd9a
Merge remote-tracking branch 'origin/master' into s3-queue-parallelize-ordered-mode
2024-01-26 16:33:22 +01:00
Kseniia Sumarokova
99653fc778
Merge branch 'master' into broken-projections-better-handling
2024-01-26 16:27:23 +01:00
kssenii
ee15b6e646
Fix
2024-01-26 16:26:59 +01:00
Kruglov Pavel
946c4e0495
Merge branch 'master' into auto-format-detection
2024-01-26 15:51:35 +01:00
Kruglov Pavel
692d37306e
Fix build
2024-01-26 15:50:16 +01:00
Arthur Passos
ce6877cbb6
Merge branch 'ClickHouse:master' into bring_back_attach_partition_pr
2024-01-26 10:57:11 -03:00
Kruglov Pavel
46a6b84a5a
Merge branch 'master' into auto-format-detection
2024-01-25 22:11:07 +01:00
Maksim Kita
5bb734a4bb
ActionsDAG buildFilterActionsDAG refactoring
2024-01-25 18:24:14 +03:00
Maksim Kita
2a327107b6
Updated implementation
2024-01-25 14:31:49 +03:00
Maksim Kita
42029f42e7
Table CREATE DROP Poco::Logger memory leak fix
2024-01-25 14:31:18 +03:00
Kseniia Sumarokova
951c874aa9
Merge pull request #59080 from ClickHouse/data-lakes-survive-restart
...
Allow server to start with broken data lake table and fix itself lazily
2024-01-25 11:50:16 +01:00
Nikita Taranov
1e3f6894a3
Merge pull request #59089 from nickitat/sort_res_ranges_before_sending_to_replica
...
Coordinator returns ranges for reading in sorted order
2024-01-24 21:04:53 +01:00
avogar
11f1ea50d7
Fix tests
2024-01-24 17:55:31 +00:00
kssenii
5ecf36f275
Fix style check
2024-01-24 17:19:52 +01:00
Dmitry Novik
95e2a3d6da
Merge pull request #58911 from ClickHouse/fix-index-hint-crash
...
Fix crash when indexHint() is used
2024-01-24 17:16:22 +01:00
kssenii
7f8f379d7f
Parallel & disrtibuted processing for ordered mode
2024-01-24 16:32:15 +01:00
Kruglov Pavel
89bafbcda6
Merge pull request #59133 from Avogar/allow-to-ignore-schema-evolution-in-iceberg
...
Allow to ignore schema evolution in Iceberg table engine under a setting
2024-01-24 13:19:09 +01:00
Smita Kulkarni
4d92eba316
Merge branch 'master' into Azure_backup
2024-01-24 11:13:57 +01:00
avogar
f05174e441
Fix style
2024-01-23 18:59:40 +00:00
avogar
617cc514b7
Try to detect file format automatically during schema inference if it's unknown
2024-01-23 18:59:39 +00:00
Arthur Passos
dba792dff0
Remove duplicate includ
2024-01-23 15:03:31 -03:00
Arthur Passos
e6b17377d0
Merge branch 'master' into bring_back_attach_partition_pr
2024-01-23 14:52:47 -03:00
avogar
be3b5dc45f
Allow to ignore schema evolution in Iceberg table engine under a setting
2024-01-23 17:45:41 +00:00
Nikolai Kochetov
d64b491b45
Fixing build
2024-01-23 17:00:21 +00:00
Nikolai Kochetov
a26f8f5425
Merge pull request #59076 from ClickHouse/revert-59059-revert-58838-allow-parallel-replicas-for-join-with-analyzer
...
Revert "Revert "Allow parallel replicas for JOIN with analyzer [part 1].""
2024-01-23 17:01:19 +01:00
Arthur Passos
5179891aef
remove static log
2024-01-23 11:43:08 -03:00
Arthur Passos
799a94081b
Revert "Revert "Allow to attach partition from table with different partition expression when destination partition expression doesn't re-partition""
...
This reverts commit a1c83e2f51
2024-01-23 11:40:42 -03:00
Robert Schulze
a1c83e2f51
Revert "Allow to attach partition from table with different partition expression when destination partition expression doesn't re-partition"
2024-01-23 15:26:04 +01:00
Anton Popov
4292ee7d51
Merge pull request #58886 from CurtizJ/better-read-buffers
...
Less error prone interface of read buffers
2024-01-23 14:59:27 +01:00
Alexander Gololobov
9a0e5d0aac
Merge pull request #58914 from ClickHouse/ot_spans_in_insert
...
Opentelemetry spans to analyze CPU and S3 bottlenecks on inserts
2024-01-23 13:53:13 +01:00
Nikolai Kochetov
fcbab407b8
Merge branch 'master' into revert-59059-revert-58838-allow-parallel-replicas-for-join-with-analyzer
2024-01-23 12:21:44 +01:00
kssenii
bca73d4b0a
Fix
2024-01-23 11:51:21 +01:00
kssenii
b76630c955
Merge remote-tracking branch 'origin/master' into broken-projections-better-handling
2024-01-23 11:34:58 +01:00
Robert Schulze
e67076ea2b
Merge pull request #55201 from canhld94/column_level_compress_block
...
Column-level compression block sizes
2024-01-23 11:22:03 +01:00
Robert Schulze
bfec324b28
Some fixups + test
2024-01-23 10:17:16 +00:00
Robert Schulze
81543c0a46
Merge remote-tracking branch 'rschu1ze/master' into fix_remove_inverted_index_files
2024-01-23 09:45:09 +00:00
Nikita Taranov
09e24ed6c5
Merge pull request #58068 from zhongyuankai/limit_materialized_view_size
...
A limit on the number of materialized views attached to a table.
2024-01-22 22:50:56 +01:00
Nikita Taranov
b161921825
impl
2024-01-22 22:33:23 +01:00
Max K
4932b1cad9
Merge branch 'master' into better-read-buffers
2024-01-22 21:52:55 +01:00
Arthur Passos
24b8bbe9fa
Allow to attach partition from table with different partition expression when destination partition expression doesn't re-partition ( #39507 )
...
* temp commit
* temp commit
* draft impl for feedback
* fix weird style changes
* fix weird style changes
* fix weird style changes
* fix weird style changes
* fix weird style changes
* aa
* aa
* Add integ tests and remove partition key restriction
* fix small incosistency in partition id
* style fix
* style fix
* style fix
* use existing DataPartStorageBuilder instead of new one
* Refactor part clone to make it more readable and maintainable
* Add MergeTreeDataPartCloner docs
* define ErrorCodes::BAD_ARGUMENTS
* Rebase
* camel case methods
* address some comments
* yet another rebase?
* Move from integ tests to stateless tests
* address more comments
* add finalize on min_max_idx files
* Add sync option to DistinctPartitionExpCloner
* just a temp test
* revert temp change
* Use echoOn to distinguish test queries
* remove comment
* fix build issue during rebase
* atempt to fix build after rebase
* finally fix build
* clear minmaxidx hyperrectangle before loading it
* Fix error on min_max files deletion where it was being assumed that partition expression contained all columns
* get it to the state it was previously
* add missing include
* getting functional?
* refactoring and renaming
* some more refactoring
* extern bad arguments
* try to fix style
* improvements and docs
* remove duplicate includes
* fix crash
* make tests more stable by ordering
* rebase once again..
* fix
* make ci happy?
* fix rebase issues
* docs
* rebase, but prolly needs to be improved
* refactor out from nasty inheritance to static methods
* fix style
* work around optional
* refactor & integrate some changes
* update column_type
* add tests by dencrane
* set utc
* fix ref file
* fix tests
* use MergeTree instead of SummingMergeTree
* mark MergeTreeDataPart::getBlock as const
* address a few comments
* compute module function name size at compile time
* simplify branching in getPartitionAstFieldsCount
* remove column_indexes argument
* merge getBlock with buildBlock
* add some const specifiers
* small adjustments
* remove no longer needed isNull check
* use std::min and max to update global min max idx
* add some assertions
* forward declare some symbols
* fix grammar
* forward decl
* try to fix build..
* remove IFunction forward decl
* Revert "use std::min and max to update global min max idx"
This reverts commit b2fe79dda7129db2610f9416087dd820246d4416
2024-01-22 21:00:04 +01:00
kssenii
1aa8e62bb7
Fix
2024-01-22 18:26:44 +01:00
Nikolai Kochetov
65c5ea31a8
Revert "Revert "Allow parallel replicas for JOIN with analyzer [part 1].""
2024-01-22 17:09:34 +01:00
Dmitry Novik
4e5249275e
Do not resolve remote table id on initiator
2024-01-22 16:45:25 +01:00
Smita Kulkarni
2e7ce5b0e2
Updated settings ptr and fetching of client from Disk & ObjectStorage
2024-01-22 16:24:43 +01:00
Anton Popov
e1e7a9cd45
Merge branch 'master' into better-read-buffers
2024-01-22 15:50:48 +01:00
Alexander Tokmakov
c2202ff347
Skip unavailable replicas in parallel distributed insert select ( #58931 )
...
* Update StorageDistributed.cpp
* Update StorageDistributed.cpp
* Update StorageDistributed.cpp
* add a test
* Update 01099_parallel_distributed_insert_select.sql
2024-01-22 15:34:46 +01:00
mochi
0606a77267
Update src/Storages/MergeTree/MutateTask.cpp
...
Co-authored-by: Dmitry Novik <mrnovikd@gmail.com>
2024-01-22 22:02:50 +08:00
Alexander Tokmakov
4315d44517
Revert "Allow parallel replicas for JOIN with analyzer [part 1]."
2024-01-22 13:30:35 +01:00
Kseniia Sumarokova
aec76d6653
Merge pull request #58877 from ClickHouse/multiple-read-file-log-storage-in-mv
...
Multiple read file log storage in mv
2024-01-22 12:02:41 +01:00
MochiXu
02b178cc9c
fix drop inverted index
2024-01-22 11:10:58 +08:00
Vitaly Baranov
01aafda27b
Merge pull request #58804 from vitlibar/allow-kill-query-for-backups
...
Allow KILL QUERY for backups
2024-01-20 23:48:18 +01:00
Igor Nikonov
4be068c73b
Merge pull request #58993 from ClickHouse/revert-58992-revert_flaky
...
Revive: Parallel replicas custom key: skip unavailable replicas
2024-01-20 19:44:56 +01:00
robot-clickhouse
273a06856a
Merge pull request #59025 from ClickHouse/cpu-scheduler
...
Split resource scheduler off `IO/` into `Common/Scheduler/`
2024-01-20 15:43:50 +01:00
Kseniia Sumarokova
5d67e26fc4
Merge pull request #58869 from ClickHouse/force-check-for-cached-custom-disk
...
Fix for custom cached disk creation
2024-01-20 14:47:36 +01:00
Kseniia Sumarokova
689e617c12
Merge pull request #58963 from ClickHouse/follow-up-disk-configuration
...
Follow up to #58357
2024-01-20 14:41:34 +01:00
serxa
824deab761
split resource scheduler off IO/ into Common/Scheduler/
2024-01-20 12:06:26 +00:00
Igor Nikonov
59025b2d3a
Merge remote-tracking branch 'origin/master' into revert-58992-revert_flaky
2024-01-19 23:38:24 +00:00
Kruglov Pavel
20379d34d5
Merge branch 'master' into variant-data-type
2024-01-19 23:17:42 +01:00
Michael Kolupaev
fd361273f0
Fix StorageURL forgetting headers on server restart
2024-01-19 11:35:12 -08:00
Alexey Milovidov
decdb62cef
Merge pull request #58800 from ZhiguoZh/20240115-combine-filter-bmi2
...
Optimize DB::combineFilters with BMI2/SSE intrinsics
2024-01-19 16:50:04 +01:00
Dmitry Novik
728276ab3f
Fix crash when indexHint() is used
2024-01-19 14:59:33 +00:00
zhongyuankai
cbb51659f6
Merge branch 'master' into limit_materialized_view_size
2024-01-19 22:00:12 +08:00
Igor Nikonov
131f71b50a
Revert "Revert flaky"
2024-01-19 13:51:30 +01:00
Raúl Marín
477489a05d
Revert "Merge pull request #57235 from ClickHouse/pr-custom-key-failover"
...
This reverts commit 8ba9b4a7ef0f39245cb8
2024-01-19 12:46:05 +00:00
kssenii
2f34ef6ff8
Follow up
2024-01-19 11:19:59 +01:00
kssenii
48e489682b
Merge remote-tracking branch 'origin/master' into broken-projections-better-handling
2024-01-19 10:49:27 +01:00
Kseniia Sumarokova
1c74e7fa08
Merge pull request #58902 from ClickHouse/fs-cache-refactorings
...
fs cache: minor refactoring
2024-01-19 10:25:45 +01:00
Robert Schulze
1bfeee1954
Some fixups
2024-01-18 20:49:50 +00:00
Robert Schulze
15700592f7
Merge remote-tracking branch 'ClickHouse/master' into column_level_compress_block
2024-01-18 19:12:57 +00:00
Kruglov Pavel
5444cde408
Merge branch 'master' into variant-data-type
2024-01-18 18:31:27 +01:00
avogar
f202d71371
Make alter with variant espansion as no-op, add tests for alters
2024-01-18 17:29:36 +00:00
Dmitry Novik
ba2dad98bb
Merge pull request #58913 from ClickHouse/fix-style
...
Style fix
2024-01-18 14:24:39 +01:00
Nikolai Kochetov
9db8b50753
Merge pull request #58838 from ClickHouse/allow-parallel-replicas-for-join-with-analyzer
...
Allow parallel replicas for JOIN with analyzer [part 1].
2024-01-18 14:01:08 +01:00
János Benjamin Antal
f34d1ae647
Use WithContext
2024-01-18 11:47:59 +00:00
Smita Kulkarni
e71977b724
Merge branch 'master' into Azure_backup
2024-01-18 08:29:01 +01:00
Duc Canh Le
22afcd46f4
add ALTER COLUMN MODIFY/RESET SETTING
...
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2024-01-18 05:17:07 +00:00
Alexander Gololobov
0a42dbafe8
Add attributes
2024-01-17 17:46:15 +01:00
Anton Popov
72b0fed4ef
Merge pull request #58729 from CurtizJ/nested-size0
...
Fix reading of offsets subcolumn (`size0`) from `Nested`
2024-01-17 17:16:27 +01:00
Alexander Gololobov
7dda18c209
Spans in mergeBlock and finalizeImpl
2024-01-17 16:07:53 +01:00
Dmitry Novik
3a1c3638e8
Style fix
2024-01-17 15:04:50 +00:00
Anton Popov
245e1cbd5c
Merge remote-tracking branch 'upstream/master' into better-read-buffers
2024-01-17 13:46:48 +00:00
kssenii
c905937ef6
Refactoring
2024-01-17 13:22:59 +01:00
Dmitry Novik
a5e0be484a
Merge pull request #58875 from ClickHouse/fix-indexhint-rpn-builder
...
Fix RPN construction for indexHint
2024-01-17 12:24:28 +01:00
Smita Kulkarni
8d88f4cf87
Update setting is_parameterized_view & settings columns for view
2024-01-17 09:42:53 +01:00
Anton Popov
299293c088
better interface in read buffers
2024-01-16 23:26:20 +00:00
János Benjamin Antal
c9b6d53948
Unify naming
2024-01-16 16:16:08 +00:00
Dmitry Novik
80291ec3f2
Add comments
2024-01-16 16:59:04 +01:00
Dmitry Novik
c325f08e79
Fix RPN construction for indexHint
2024-01-16 15:34:45 +00:00
János Benjamin Antal
1d34f4a304
Merge pull request #58809 from ClickHouse/print-entries-to-be-processed-in-trace
...
Increase log level to trace to help debug `00993_system_parts_race_condition_drop_zookeeper`
2024-01-16 16:14:22 +01:00
Kruglov Pavel
74973c1b41
Merge pull request #58537 from sunny19930321/fix/hive-threadpool-query
...
Fix hive threadpool read ORC/Parquet/... Failed
2024-01-16 14:46:22 +01:00
kssenii
8decf5039a
Fix for custom cached disk
2024-01-16 14:41:12 +01:00
Nikita Taranov
7d03ccd8db
Merge pull request #58844 from nickitat/fixxxx
...
Fix reading from an invisible part in new (not released yet) parallel replicas coordinator
2024-01-16 14:09:21 +01:00
Nikolai Kochetov
534e086a5d
Update StorageMergeTree.cpp
2024-01-16 13:50:39 +01:00
Smita Kulkarni
76ba60aa24
Merge branch 'master' into Support_parameterized_view_with_analyzer
2024-01-16 11:26:41 +01:00
zhongyuankai
cca2fa6976
fix test
2024-01-16 15:39:33 +08:00
Zhiguo Zhou
7450c35189
Optimize DB::combineFilters with BMI2/SSE intrinsics
...
The DB::combineFilters combines two UInt8 columns (filters) by
scanning the first column for non-zero elements and replacing them
with elements in the second column contiguously.
As a follow-up of #56079 , the function is optimized with the BMI2
and SSE intrinsics so that the x86 devices without AVX512 support
could also accelerate the column combinations via data parallelism.
2024-01-16 15:33:27 +08:00
Nikita Taranov
b9132f7f69
add check in read pool
2024-01-16 00:57:10 +01:00
Nikita Taranov
90d30b6d11
impl
2024-01-15 23:56:53 +01:00
alesapin
f1b1096eb4
Fix isRetry method
2024-01-15 20:10:21 +01:00
Nikolai Kochetov
733ceaa775
Allow parallel replicas for JOIN with analyzer.
2024-01-15 18:48:12 +00:00
Anton Popov
b430f3094e
fix nested size0 for storage Log
2024-01-15 17:26:44 +00:00
Kseniia Sumarokova
7ded82e51f
Merge pull request #58297 from azat/qp-alter-part
...
Support query parameters in ALTER TABLE ... PART
2024-01-15 18:18:34 +01:00
János Benjamin Antal
b04e8b11ae
Delay reading from StorageFileLog by creating a query plan step
2024-01-15 11:39:43 +00:00
János Benjamin Antal
3e1d7bf685
Merge pull request #58477 from ClickHouse/multiple-read-kafka-storage-in-mv
...
Delay reading from StorageKafka to allow multiple reads in materialized views
2024-01-15 12:31:59 +01:00
Azat Khuzhin
48a700edba
Support query parameters in ALTER TABLE ... PART
...
But, to make this happen it is not enough to simply fix the parser, the
whole ASTs for ALTER should be fixed as well, since they store `ASTPtr`
instead of `IAST *`, and so because of `ReplaceQueryParameterVisitor`
does not work for ALTER query.
So this patch converts ASTPtr to `IAST *` for ASTAlterQuery and
ASTAlterCommand (plus it also fixes when the children for
ASTAlterCommand had not been updated sometimes).
And only after this it is possible to adjust the parser (see
places with `parser_string_and_substituion` in the parser code).
v2: also fix ASTAlterCommand::clone (add missing components) and ParserAlterCommand::parseImpl
v3: fix APPLY DELETED MASK
v4: fix mutations_execute_nondeterministic_on_initiator/mutations_execute_subqueries_on_initiator
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-15 14:16:54 +03:00
János Benjamin Antal
f4e8e47c7a
Increase log level to trace
2024-01-15 10:44:40 +00:00
Robert Schulze
9cfdff2ddb
Merge pull request #58284 from lingtaolf/Improvement/inverted_index_support_match
...
Utilize inverted index by function `match()`
2024-01-15 11:37:23 +01:00
zhongyuankai
826b29ef4d
Max materialized views size for table
2024-01-15 10:02:57 +08:00
Alexey Milovidov
a471a54987
Merge pull request #55528 from ClickHouse/insert-quorum-host-name-check
...
Insert quorum: check host node version in addition
2024-01-15 02:23:15 +01:00
Vitaly Baranov
3d7a17af08
Allow KILL QUERY to cancel backups/restores.
2024-01-15 02:22:35 +01:00
Alexander Tokmakov
5128607995
Merge pull request #58393 from jaymebrd/feat/add-from-modifier-sync-replica-lightweight
...
add `from srcreplicas` modifier for `SYSTEM SYNC REPLICA LIGHTWEIGHT`
2024-01-14 20:53:16 +01:00
Nikita Taranov
df0c6cc029
Fix bug in new (not released yet) parallel replicas coordinator ( #58722 )
2024-01-14 16:16:20 +01:00
Duc Canh Le
ac76eecb1e
Merge branch 'master' into column_level_compress_block
...
Resolve conflicts
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2024-01-14 09:32:43 +00:00
Alexey Milovidov
65ac905032
Merge pull request #54366 from canhld94/final_no_copy
...
Implement vertical replacing FINAL
2024-01-14 04:21:07 +01:00
Alexey Milovidov
e92e3615e3
Merge branch 'master' into non-ready-set-ttl
2024-01-13 21:11:51 +01:00
Alexey Milovidov
12585ea0e4
Update TTLDescription.cpp
2024-01-13 23:10:27 +03:00
Alexey Milovidov
211c285a0b
Merge pull request #58657 from ClickHouse/analyzer-fix-index-set
...
Analyzer: Correctly handle constant set in index
2024-01-13 19:23:28 +01:00
Alexey Milovidov
d10a6e91af
Merge pull request #58770 from hdnpth/add-missing-includes
...
Add missing includes when _LIBCPP_REMOVE_TRANSITIVE_INCLUDES enabled
2024-01-13 19:22:49 +01:00
Alexey Milovidov
af8c8923cb
Merge branch 'master' into analyzer-fix-index-set
2024-01-13 04:15:10 +01:00
Alexey Milovidov
d112492c56
Remove some code
2024-01-13 03:48:04 +01:00
Artem Alperin
4139cb24ee
Add missing includes
2024-01-13 01:48:55 +03:00
Nikita Mikhaylov
8edab24189
Add comments to all columns of system tables ( #58356 )
2024-01-12 16:39:22 +01:00
Robert Schulze
b183e1f048
Merge remote-tracking branch 'rschu1ze/master' into Improvement/inverted_index_support_match
2024-01-12 14:10:11 +00:00
Robert Schulze
d11ed921be
Some fixups
2024-01-12 14:05:19 +00:00
Anton Popov
8e88605a7c
Merge remote-tracking branch 'upstream/master' into HEAD
2024-01-12 03:55:15 +00:00
Konstantin Bogdanov
633ef126c7
Merge pull request #57550 from ClickHouse/nickitat-patch-15
...
Small change in log message in MergeTreeDataMergerMutator
2024-01-12 02:02:10 +03:00
Anton Popov
eb6647d4e8
fix reading of offsets subcolumn from Nested
2024-01-11 21:55:22 +00:00
Robert Schulze
790f5890a0
Merge pull request #58611 from rschu1ze/qc-isolation
...
Improve isolation of query cache entries under re-created users or role switches
2024-01-11 17:30:24 +01:00
Nikolai Kochetov
f83cf1a6b7
Merge pull request #58638 from amosbird/fix-58620
...
Fix broken partition key analysis when doing projection optimization
2024-01-11 14:17:48 +01:00
Nikita Mikhaylov
baf4e5e894
Added comments for system tables ( #48350 )
2024-01-11 12:50:00 +01:00
Duc Canh Le
6331d8a6f2
Merge branch 'master' into final_no_copy
...
Resolve conflicts
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2024-01-11 02:55:14 +00:00
Igor Nikonov
8d4a395afa
Merge remote-tracking branch 'origin/master' into pr-custom-key-failover
2024-01-10 20:28:04 +00:00
Robert Schulze
52d75ab68f
Merge pull request #58458 from rschu1ze/replace-std_regexp-by-re2
...
Replace `std::regex` by re2
2024-01-10 17:46:54 +01:00
Kseniia Sumarokova
a6b5b7460b
Merge branch 'master' into broken-projections-better-handling
2024-01-10 16:46:18 +01:00
Dmitry Novik
ddbdd89904
Analyzer: Correctly handle constant set in index
2024-01-10 14:34:56 +00:00
Anton Popov
e87c62eead
Merge pull request #58628 from CurtizJ/remove-projections-code-2
...
Remove more projections code
2024-01-10 15:29:15 +01:00
Robert Schulze
fee98994d4
Fix tokenization in DataPartsExchange (it missed the last element)
2024-01-10 11:44:01 +00:00
Robert Schulze
499227b9cf
Merge remote-tracking branch 'rschu1ze/master' into replace-std_regexp-by-re2
2024-01-10 10:02:53 +00:00
Robert Schulze
36173bbb7b
Merge remote-tracking branch 'rschu1ze/master' into qc_isolation
2024-01-10 09:57:13 +00:00
Robert Schulze
4cacfa6b43
Merge pull request #57509 from jinjunzh/qatzstd_main
...
Add Intel-QAT-based `ZSTD_QAT` compression codec
2024-01-10 10:31:39 +01:00
Kseniia Sumarokova
1b517105db
Merge pull request #57323 from valbok/mysql-binlog-client
...
MaterializedMySQL: Introduce MySQL Binlog Client
2024-01-10 09:08:13 +01:00
Alexey Milovidov
4c1841e475
Merge branch 'master' into insert-quorum-host-name-check
2024-01-10 05:17:37 +01:00
Robert Schulze
ced9e93ac6
Merge remote-tracking branch 'rschu1ze/master' into qatzstd_main
2024-01-09 20:36:02 +00:00
Amos Bird
29afac61cc
Fix partition key analysis
2024-01-10 03:13:03 +08:00
pufit
6cf55b82f4
Merge pull request #58539 from canhld94/file_custom_compress_level
...
Allow explicitly set compression level in output format
2024-01-09 13:43:38 -05:00
Robert Schulze
c04e4eb162
Merge remote-tracking branch 'rschu1ze/master' into qc-isolation
2024-01-09 16:30:20 +00:00
Anton Popov
e0d469b0e0
remove more projections code
2024-01-09 15:48:08 +00:00
Dmitry Novik
629d4b921e
Fix style
2024-01-09 15:38:04 +00:00
Dmitry Novik
11280cbde1
Merge remote-tracking branch 'origin/master' into storage-merge-aliases-analyzer
2024-01-09 15:10:59 +00:00
Anton Popov
2fd0f7be7b
Merge pull request #55579 from CurtizJ/remove-old-projections-code
...
Remove more old code of projection analysis
2024-01-09 15:51:12 +01:00
Jayme Bird
b451c04e75
fixup wait for all replicas if no src_replicas are specified
2024-01-09 14:02:48 +00:00
Sema Checherinda
7c7e72c4b7
Merge pull request #58573 from ClickHouse/chesema-s3-client-creation
...
fix and test that S3Clients are reused
2024-01-09 13:28:20 +01:00
Robert Schulze
e9b6f413b8
Get rid of QueryCache::user_name
2024-01-09 12:24:12 +00:00
Igor Nikonov
f566423e19
Merge remote-tracking branch 'origin/master' into pr-custom-key-failover
2024-01-09 10:38:43 +00:00
Yakov Olkhovskiy
cfa41e7dc6
Merge pull request #58038 from ClickHouse/revert-58022-revert-57555-ft-dropped_tables_parts
...
Add system.dropped_tables_parts table - second attempt
2024-01-09 00:47:07 -05:00
Robert Schulze
fabc06995e
Improve isolation of query results in query cache
...
Fixes #58054
2024-01-08 20:52:30 +00:00
Igor Nikonov
7fd851b4e9
Merge remote-tracking branch 'origin/master' into pr-custom-key-failover
2024-01-08 20:43:20 +00:00
jinjunzh
cf53d9a17c
add USE_QAT into build_options
2024-01-08 11:05:36 -05:00
Anton Popov
3e933c9099
Merge remote-tracking branch 'upstream/master' into HEAD
2024-01-08 15:33:38 +00:00
Smita Kulkarni
f421e74402
Merge branch 'master' into Support_parameterized_view_with_analyzer
2024-01-08 14:10:31 +01:00
Jayme Bird
f67e283968
review fixup: simplify conditions and add meaningful comment on why we have these conditions
2024-01-08 10:02:09 +00:00
Jayme Bird
9734934d84
review fixup: don't pass in zookeeper
2024-01-08 10:02:09 +00:00
Jayme Bird
382f6404bf
fix getChildren from Keeper
2024-01-08 10:02:09 +00:00
Jayme Bird
5221b4f9bc
switch to contains to be more readable
2024-01-08 10:02:09 +00:00
Jayme Bird
18b7f1de5f
various fixups
2024-01-08 10:02:09 +00:00
Jayme Bird
b1580efffa
switch to use comma join seperated list of srcReplicas
2024-01-08 10:02:09 +00:00
Jayme Bird
128a421d84
add from <srcReplica> modified to SYSTEM SYNC REPLICA LIGHTWEIGHT
2024-01-08 10:02:09 +00:00
Raúl Marín
8f998eaa82
Merge pull request #58447 from canhld94/fix_symlink_in_user_files
...
Allow users to work with symlinks in user_files_path (again)
2024-01-08 10:40:36 +01:00
Robert Schulze
6665d23243
Merge pull request #58029 from skyoct/feat/server_settings
...
Add `changeable_without_restart` column to `system.server_settings`
2024-01-08 10:09:51 +01:00
Robert Schulze
c11a2fcb7f
Fix style
2024-01-08 08:50:34 +00:00
Duc Canh Le
149de9aa93
discard fs::canonical return
...
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2024-01-08 03:40:48 +00:00
Robert Schulze
f553b55e3a
Merge remote-tracking branch 'rschu1ze/master' into regex-std-re2
2024-01-07 22:31:35 +00:00
Robert Schulze
8e804487f3
Some fixups
2024-01-07 22:28:08 +00:00
Sema Checherinda
6f626d8294
fix auth_settings.hasUpdates function
2024-01-07 23:00:26 +01:00
Alexander Tokmakov
371d664667
Update MergeTreeData.cpp
2024-01-07 17:27:22 +01:00
Smita Kulkarni
16e682e0ae
Merge branch 'master' into Support_parameterized_view_with_analyzer
2024-01-07 16:38:01 +01:00
Robert Schulze
53965bb9f1
Merge remote-tracking branch 'rschu1ze/master' into qatzstd_main
2024-01-07 14:11:22 +00:00
Smita Kulkarni
356fc0aadb
Fix tests
2024-01-07 14:49:24 +01:00
Robert Schulze
e947ed710b
Hijack and document 'update' map to represent reload status
2024-01-07 13:09:27 +00:00
Sema Checherinda
d5f86f671d
fix and test that S3Clients reused
2024-01-07 02:19:06 +01:00
Anton Popov
8c9cf394b3
Merge remote-tracking branch 'upstream/master' into HEAD
2024-01-06 20:58:17 +00:00
Nikolai Kochetov
105789b936
Merge pull request #53705 from ClickHouse/analyzer-execution-names
...
Analyzer: always qualify execution names
2024-01-06 17:39:58 +01:00
Anton Popov
48a7402b34
fix build
2024-01-06 16:39:27 +00:00
Nikolai Kochetov
c2f00bc75a
Merge pull request #58480 from ClickHouse/try-to-remove-pk-analysis-on-ast
...
Check if I can remove KeyCondition analysis on AST.
2024-01-06 12:40:46 +01:00
Anton Popov
f252412915
Merge remote-tracking branch 'upstream/master' into HEAD
2024-01-06 03:08:52 +00:00
