Commit Graph

6522 Commits

Author SHA1 Message Date
Amos Bird
0a3d986e42
Fix reporting projection broken part 2023-05-21 20:58:58 +08:00
Antonio Andelic
4af8187464 Activate restarting thread in both cases 2023-05-19 15:06:02 +00:00
Antonio Andelic
7f60af11cb
Merge branch 'master' into write-buffer-from-s3 2023-05-19 15:17:05 +02:00
robot-clickhouse
f947d1cc0a Automatic style fix 2023-05-19 13:00:26 +00:00
Antonio Andelic
3107070e76 Avoid deadlock when starting table in attach thread 2023-05-19 12:48:19 +00:00
Sergei Trifonov
5db5f6e44b
Merge branch 'master' into fix-throttlers 2023-05-19 14:08:36 +02:00
alesapin
6676285f02
Merge pull request #49921 from azat/tests/fix-test_distributed_load_balancing
Fix flakiness of test_distributed_load_balancing test
2023-05-19 13:00:38 +02:00
alesapin
632ab8a3d1
Merge pull request #49996 from ClickHouse/az
Fix test_insert_same_partition_and_merge failing if one Azure request attempt fails
2023-05-19 12:58:47 +02:00
alesapin
e5b001abda
Merge branch 'master' into fix_some_tests4 2023-05-19 12:34:03 +02:00
Alexey Milovidov
c1b96fd2f5
Merge branch 'master' into Fix_flaky_test_ssl_cert_authentication 2023-05-19 12:37:55 +03:00
Azat Khuzhin
dc353faf44 Simplify obtaining query shard in test_distributed_load_balancing
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-19 06:07:58 +02:00
Azat Khuzhin
e37e8f83bb Fix flakiness of test_distributed_load_balancing
I saw the following in the logs for the failed test:

    2023.05.16 07:12:12.894051 [ 262 ] {74575ac0-b296-4fdc-bc8e-3476a305e6ea} <Warning> ConnectionPoolWithFailover: Connection failed at try №1, reason: Timeout exceeded while reading from socket (socket (172.16.3.2:9000), receive timeout 2000 ms)

And I think that the culprit is the
test_distributed_replica_max_ignored_errors for which it is normal,
however not for others, and this should not affect other tests.

So fix this by calling SYSTEM RELOAD CONFIG, which should reset error
count.

CI: https://s3.amazonaws.com/clickhouse-test-reports/49380/5abc1a1c68ee204c9024493be1d19835cf5630f7/integration_tests__release__[3_4].html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-19 06:07:58 +02:00
Michael Kolupaev
e84f0895e7 Support hardlinking parts transactionally 2023-05-18 21:05:56 -07:00
Nikolay Degterinsky
b8be714830 Add schema inference to more table engines 2023-05-19 00:44:27 +00:00
Michael Kolupaev
8dc59c1efe Fix test_insert_same_partition_and_merge failing if one Azure request attempt fails 2023-05-18 21:40:24 +00:00
robot-clickhouse
378beb20e8 Automatic style fix 2023-05-18 07:46:02 +00:00
SmitaRKulkarni
b7c9964710
Merge branch 'master' into Fix_flaky_test_ssl_cert_authentication 2023-05-18 09:27:32 +02:00
Smita Kulkarni
2893f14c54 Updated test_ssl_cert_authentication to use urllib3 2023-05-18 09:20:38 +02:00
alesapin
a7c179e401
Merge branch 'master' into make_test_less_flaky 2023-05-17 15:44:24 +02:00
Kruglov Pavel
0f26a82000
Fix style 2023-05-17 15:32:40 +02:00
Kruglov Pavel
b5cc77512a
Fix style 2023-05-17 15:02:15 +02:00
AVMusorin
7df4820af7
Fix metrics WriteBufferFromS3Bytes, WriteBufferFromS3Microseconds and WriteBufferFromS3RequestsErrors
Ref: https://github.com/ClickHouse/ClickHouse/pull/45188
2023-05-17 14:50:38 +02:00
Alexander Tokmakov
1e529263d0
Merge branch 'master' into Follow_up_Backup_Restore_concurrency_check_node_2 2023-05-17 13:57:50 +03:00
Vitaly Baranov
6c8a923c9d
Merge branch 'master' into write-encrypted-to-backup 2023-05-17 12:37:05 +02:00
Azat Khuzhin
9fe4f1a934 Extensive coverage for bandwidth limiting settings
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-17 12:12:39 +02:00
Azat Khuzhin
3c80e30f02 Fix per-query IO/BACKUPs throttling settings (when default profile has them)
When some of this settings was set for default profile (in
users.xml/users.yml), then it will be always used regardless of what
user passed.

Fix this by not inherit per-query throttlers, for this they should be
reset before making query context and they should not be initialized as
before in Context::makeQueryContext(), since makeQueryContext() called
too early, when user settings was not read yet.

But there we had also initialization of per-server throttling, move this
into the ContextSharedPart::configureServerWideThrottling(), and call it
once we have ServerSettings set.

Also note, that this patch makes the following settings - server
settings:
- max_replicated_fetches_network_bandwidth_for_server
- max_replicated_sends_network_bandwidth_for_server
But this change should not affect anybody, since it is done with
compatiblity (i.e. if this setting is set in users profile it will be
read from it as well as a fallback).

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-17 12:12:39 +02:00
Kruglov Pavel
353791b2dd
Try to fix flaky test_distributed_load_balancing tests (#49912)
* Try to fix flaky test_distributed_load_balancing tests

* Automatic style fix

---------

Co-authored-by: robot-clickhouse <robot-clickhouse@users.noreply.github.com>
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2023-05-16 18:26:22 +03:00
avogar
633c37e3e1 Update tests 2023-05-16 14:54:52 +00:00
Kruglov Pavel
4530f38fdf
Merge branch 'master' into urlCluster 2023-05-16 16:21:23 +02:00
Alexander Tokmakov
b6716a8f0f Merge branch 'master' into fix_some_tests4 2023-05-16 14:46:27 +02:00
Vitaly Baranov
943707963f Add backup setting "decrypt_files_from_encrypted_disks" 2023-05-16 14:27:27 +02:00
Vitaly Baranov
d0fd81fa27 Add tests. 2023-05-16 14:27:27 +02:00
Vitaly Baranov
c48c20fac8 Use combined checksums for encrypted immutable files. 2023-05-16 14:27:27 +02:00
Vitaly Baranov
101aa6eff0 Add function copyS3FileFromDisk(). 2023-05-16 14:25:37 +02:00
Vitaly Baranov
fd2731845c Simplify interface of IBackupWriter: Remove supportNativeCopy() function. 2023-05-16 14:25:36 +02:00
robot-clickhouse
b3fc7d1a86 Automatic style fix 2023-05-16 11:15:15 +00:00
alesapin
a4f84cecfd Retry connection expired in test_rename_column/test.py 2023-05-16 13:05:36 +02:00
avogar
f9e0eb47d7 Merge branch 'master' of github.com:ClickHouse/ClickHouse into urlCluster 2023-05-15 16:35:24 +00:00
Alexander Tokmakov
05ae7b2c2d fix some tests 2023-05-15 18:28:12 +02:00
AVMusorin
418a61a68c
Allow using Alias column type for KafkaEngine
```
create table kafka
(
 a UInt32,
 a_str String Alias toString(a)
) engine = Kafka;

create table data
(
  a UInt32;
  a_str String
) engine = MergeTree
order by tuple();

create materialized view data_mv to data
(
  a UInt32,
  a_str String
) as
select a, a_str from kafka;
```
Alias type works as expected in comparison with MATERIALIZED/EPHEMERAL
or column with default expression.

Ref: https://github.com/ClickHouse/ClickHouse/pull/47138

Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>
2023-05-15 15:39:58 +02:00
Sema Checherinda
a1ee7d52e1
Merge pull request #49432 from CheSema/lost-blobs
all s3-blobs removed when merge aborted, remove part from failed fetch without unlock keper
2023-05-12 13:19:27 +02:00
Nikita Mikhaylov
66badcd59c
Merge pull request #49725 from vitlibar/incremental-backup-append-table-def
Fix writing appended files to incremental backups
2023-05-12 11:37:49 +02:00
Vitaly Baranov
478140f8b4 Fix LimitSeekableReadBuffer. 2023-05-11 22:58:05 +02:00
Vitaly Baranov
ec011b9113
Merge branch 'master' into user-grants-from-config 2023-05-11 17:08:06 +02:00
avogar
3ee8de792c Merge branch 'master' of github.com:ClickHouse/ClickHouse into urlCluster 2023-05-11 12:46:20 +00:00
Sema Checherinda
66e3712dca
Merge branch 'master' into lost-blobs 2023-05-11 08:23:25 +02:00
Nikolay Degterinsky
39deaf4f2a
Merge pull request #49632 from evillique/fix-ssl-test
Try to fix integration test 'test_ssl_cert_authentication'
2023-05-09 11:53:21 +02:00
Alexey Milovidov
a8bdb20fc4
Merge pull request #48787 from ClickHouse/background-memory-tracker
Add MemoryTracker for the background tasks [Resubmit]
2023-05-09 07:58:36 +03:00
Alexey Milovidov
9a73a04fe3
Merge pull request #42587 from ClickHouse/compress-marks-primary-key-by-default
Compress marks and primary key by default
2023-05-09 06:43:10 +03:00
Alexander Tokmakov
5629d73bdb
Merge pull request #49560 from ClickHouse/fix_dictionaries_loading_order
Fix dictionaries loading order
2023-05-08 16:07:40 +03:00
Nikolay Degterinsky
ee4ce7db47 Fix style 2023-05-08 12:33:24 +00:00
Smita Kulkarni
f20901d9d3 Merge branch 'master' into Follow_up_Backup_Restore_concurrency_check_node_2 2023-05-08 13:53:19 +02:00
Alexey Milovidov
e083acc361 Merge branch 'compress-marks-primary-key-by-default' of github.com:ClickHouse/ClickHouse into compress-marks-primary-key-by-default 2023-05-08 07:02:55 +02:00
Alexey Milovidov
88d0d94933 Update test 2023-05-08 07:02:41 +02:00
Alexey Milovidov
3cf1da7bf3
Merge branch 'master' into deprecate-in-memory-parts 2023-05-08 01:38:00 +03:00
Alexander Tokmakov
abf6c60ad2 Merge branch 'master' into fix_dictionaries_loading_order 2023-05-08 00:31:03 +02:00
Nikolay Degterinsky
c841a187ab Try to fix integration test 'test_ssl_cert_authentication' 2023-05-07 18:34:34 +00:00
robot-clickhouse
fe76bde5b5 Automatic style fix 2023-05-07 16:33:07 +00:00
Alexey Milovidov
a2daeb849e Merge branch 'master' into compress-marks-primary-key-by-default 2023-05-07 18:25:01 +02:00
Alexey Milovidov
ea9249b0ac Merge branch 'compress-marks-primary-key-by-default' of github.com:ClickHouse/ClickHouse into compress-marks-primary-key-by-default 2023-05-07 18:24:51 +02:00
Alexey Milovidov
1ae8a5be3b Update a test 2023-05-07 18:24:38 +02:00
Alexey Milovidov
9eba74c1e1
Update test_vertical_merges_from_compact_parts.py 2023-05-07 17:45:45 +03:00
Alexey Milovidov
27e1357ee6
Update test_in_memory_parts_still_read.py 2023-05-07 17:42:18 +03:00
robot-clickhouse
fd82979961 Automatic style fix 2023-05-07 02:00:24 +00:00
Alexey Milovidov
d8f5667ba6 Follow-up for #49576 2023-05-07 03:59:35 +02:00
Alexey Milovidov
6e46a4e0ea
Update test_in_memory_parts_still_read.py 2023-05-07 04:56:09 +03:00
Alexey Milovidov
3b6edbacab Update tests 2023-05-07 03:45:17 +02:00
Alexey Milovidov
de3e66385c Merge branch 'master' into compress-marks-primary-key-by-default 2023-05-07 02:40:25 +02:00
Alexey Milovidov
e8228cb0d2
Merge pull request #49530 from ClickHouse/optimize-query-log
Optimize the system.query_log and system.query_thread_log tables by applying LowCardinality when appropriate
2023-05-07 03:36:30 +03:00
Alexey Milovidov
07027be872
Update test_in_memory_parts_still_read.py 2023-05-07 02:09:37 +03:00
Alexey Milovidov
8f1123dfb8
Update test_in_memory_parts_still_read.py 2023-05-06 18:23:54 +03:00
Alexey Milovidov
bffc441b84
Merge pull request #49576 from ClickHouse/remove-test_merge_tree_s3_restore
Remove `test_merge_tree_s3_restore`
2023-05-06 18:13:47 +03:00
Alexey Milovidov
fe00e668f1
Merge pull request #49579 from ClickHouse/remove-obsolete-test
Remove obsolete test about deprecated feature
2023-05-06 18:11:05 +03:00
Alexey Milovidov
846f2d57af Fix error found by AST Fuzzer 2023-05-06 00:55:56 +02:00
Alexey Milovidov
be2834da58 Remove obsolete test about deprecated feature 2023-05-06 00:02:45 +02:00
Alexey Milovidov
75a2589a42
Merge branch 'master' into deprecate-in-memory-parts 2023-05-06 00:49:59 +03:00
Alexey Milovidov
e4d122323f Add a new test 2023-05-05 23:43:22 +02:00
Alexey Milovidov
290bf0ae58 Remove a test for in-memory parts 2023-05-05 23:29:48 +02:00
Alexey Milovidov
8a548170f8 Remove obsolete test 2023-05-05 23:25:47 +02:00
Alexey Milovidov
9436aef893 Remove test_merge_tree_s3_restore 2023-05-05 22:44:07 +02:00
Alexey Milovidov
79ad150454
Merge pull request #49323 from ClickHouse/low-cardinality-fix-progress
Fix progress bar for LowCardinality fields with shared dictionaries
2023-05-05 23:34:27 +03:00
Smita Kulkarni
b0c408faa4 Merge branch 'master' into Follow_up_Backup_Restore_concurrency_check_node_2 2023-05-05 17:51:33 +02:00
Alexander Tokmakov
dd1bbf7c78 fix another issue with dependencies 2023-05-05 16:27:12 +02:00
Nikolay Degterinsky
9934eae315
Merge pull request #48983 from evillique/mongodb-array-type
Add `Array` data type to MongoDB
2023-05-05 16:02:07 +02:00
Nikolay Degterinsky
7a727bbbe3
Merge pull request #49520 from IvanTakarlikov-st/it-grammar-fixes
Fix some grammar mistakes in documentation, code and tests
2023-05-05 15:45:58 +02:00
Alexander Tokmakov
6cf3e5b77a fix race on loading dictionaries 2023-05-05 15:25:18 +02:00
wangxiaobo
f704c0dfec
Implement SYSTEM DROP REPLICA from auxillary ZooKeeper clusters (#48932)
* multiple zookeeper drop replica bug fix.

* add an integration test.

* format code.

* set stay_alive=True for test.

* style check bug fix.

* add check for is_active

* format code

* remove table_settings and has_metadata_out param.
2023-05-05 14:11:11 +03:00
Kseniia Sumarokova
7c203dbcd2
Merge pull request #49481 from snikch/master
Fix postgres database setting
2023-05-05 12:53:51 +02:00
Alexey Milovidov
f77d087404 Merge branch 'master' into low-cardinality-fix-progress 2023-05-05 06:43:37 +02:00
Alexey Milovidov
09f171822e Merge branch 'master' into deprecate-in-memory-parts 2023-05-05 06:43:23 +02:00
Alexey Milovidov
6b809a1829 Remove a test 2023-05-05 06:43:21 +02:00
Alexey Milovidov
14f5e785d6 Fix test 2023-05-05 06:42:40 +02:00
Alexey Milovidov
ab1a1ea5b7
Merge pull request #49490 from ClickHouse/fix-s3cluster-with-headers
Correctly handle s3Cluster arguments
2023-05-05 05:31:23 +03:00
Ivan Takarlikov
339fb0c2c1
Merge branch 'master' into it-grammar-fixes 2023-05-04 15:57:09 -03:00
Sema Checherinda
93c1209ea5 fix black style 2023-05-04 19:40:41 +02:00
Ivan Takarlikov
8873856ce5 Fix some grammar mistakes in documentation, code and tests 2023-05-04 13:35:18 -03:00
Konstantin Bogdanov
c93a131019
Add an integration test for shutdown_wait_unfinished_queries (#49469) 2023-05-04 17:21:08 +02:00
Dmitry Novik
befcdbcc6d
Merge pull request #47630 from ClickHouse/revert-47476-revert_46622
Fix user MemoryTracker counter in async inserts
2023-05-04 16:57:41 +02:00
Alexander Gololobov
f77cc89464
Merge pull request #49470 from ClickHouse/remove_no_delay_flag
Replace `NO DELAY` with `SYNC` in tests
2023-05-04 11:57:01 +02:00
alesapin
412b161104
Merge pull request #48791 from kssenii/better-local-object-storage
Make local object storage work consistently with s3 object storage, fix problem with append, make it configurable as independent storage
2023-05-04 11:47:43 +02:00