thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-10 01:25:21 +00:00
Code Issues Packages Projects Releases Wiki Activity
140,651 Commits 9,099 Branches 1,774 Tags 2 GiB
48836afcf7
Commit Graph

140651 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
kssenii
6dc48de031 Fix 2024-04-25 14:55:09 +02:00
Azat Khuzhin
5d72a34561 Add some comments for getAlterMutationCommandsForPart() 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-04-25 14:35:21 +02:00
Azat Khuzhin
e5650f8af3 Move add_to_result() out from loop 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-04-25 14:35:21 +02:00
Azat Khuzhin
e0b83bde50 Consider alter_conversions_mutations as valid only if part metadata version matches 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-04-25 14:35:21 +02:00
Azat Khuzhin
d2a922bd44 Revert "Fix processing INSERT after metadata mutations that had not been applied yet" 
The problem is that the atomic counter (alter_conversions_mutations) is
not accounted correctly for IMergeTreeDataPart::getMetadataVersion()

This reverts commit 0124642b39f538eaf2b1c7cfab9a0a917b1b12f6.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-04-25 14:35:21 +02:00
Azat Khuzhin
c048ab9d6d Fix processing INSERT after metadata mutations that had not been applied yet 
The problem is that right now INSERT may write old columns even after
metadata mutation (i.e. RENAME), because it will simply write the new
block number that is bigger then metadata version, and so this part
won't be mutated.

To fix this, it should get the mutation version from metadata - this is
quite a major change!

Fixes: 2555_davengers_rename_chain
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-04-25 14:35:21 +02:00
Azat Khuzhin
be6777bc86 Reduce overhead of the mutations for SELECTs (v2) 
SELECTs are affected by the mutations, since it tries to apply them on
fly, and scanning over existing mutations can take significant amount of
time (for simple queries, i.e. count())

And also even after mutation had been finished, it still a problem,
because mutations are not removed instantly.

So instead introduce an atomic counter alter_conversions_mutations, that
is incremented for new mutations and decremented once mutation
finished/killed, that way once the mutation finished they will not
affect queries.

Here are some numbers for non-RENAME mutations:

    rmt vanilla w/o mutations | queries: 3693, QPS: 494.813
    rmt vanilla w/ mutations  | queries: 2190, QPS: 388.256
    rmt patched w/o mutations | queries: 3168, QPS: 620.061
    rmt patched w/ mutations  | queries: 3155, QPS: 614.424
    mt vanilla w/o mutations  | queries: 3498, QPS: 656.399
    mt vanilla w/ mutations   | queries: 3821, QPS: 600.425
    mt patched w/o mutations  | queries: 5732, QPS: 745.585
    mt patched w/ mutations   | queries: 4719, QPS: 715.034

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-04-25 14:35:21 +02:00
kssenii
773fac5214 Update test 2024-04-25 14:27:42 +02:00
Azat Khuzhin
de2e9f8983 tests: preserve table on exit in 02555_davengers_rename_chain 
Rely on clickhouse-test random database cleanup, for debugging

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-04-25 14:15:01 +02:00
Azat Khuzhin
e3218af9e6 tests: make wait_for_all_mutations faster 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-04-25 14:15:01 +02:00
Azat Khuzhin
d1ba0f64bb tests: make 02555_davengers_rename_chain deterministic (by properly waiting for mutations) 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-04-25 14:15:01 +02:00
Azat Khuzhin
6d462c8874 tests: make output better for 02555_davengers_rename_chain 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-04-25 14:15:01 +02:00
Azat Khuzhin
ba5b9380d9 tests: simplify 02555_davengers_rename_chain 
- reduce copy-paste
- better bash

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2024-04-25 14:15:01 +02:00
Robert Schulze
d2c1dfff09
Merge pull request #62543 from tomershafir/cow-examples-assert 
Add asserts to COW example programs
 2024-04-25 12:07:47 +00:00
Raúl Marín
115103b238 Fix flaky 03128_argMin_combinator_projection 2024-04-25 14:03:58 +02:00
Nikita Mikhaylov
6fe4203d44 Merge branch 'master' of github.com:ClickHouse/ClickHouse into keywords-2 2024-04-25 11:59:06 +00:00
Nikita Mikhaylov
c98b9c350a
Merge pull request #62923 from Blargian/document_lengthUTF8 
[Docs] update `length` and `lengthUTF8`
 2024-04-25 11:37:32 +00:00
Nikita Mikhaylov
7fef1d728d
Merge pull request #62592 from peter279k/add_try_base_usage 
Document functions tryBase58Decode and  tryBase64Decode
 2024-04-25 11:30:37 +00:00
Igor Nikonov
ee7f862155 Merge remote-tracking branch 'origin/master' into fix-msan-uuid-string-to-num 2024-04-25 11:22:11 +00:00
Nikita Mikhaylov
5ea95cbbec
Merge branch 'master' into access-controls-enable-by-default 2024-04-25 13:21:23 +02:00
Alexander Tokmakov
e752ebdf9c
Merge pull request #62658 from ClickHouse/install_path 
Don't allow relative paths when installing
 2024-04-25 11:18:00 +00:00
Nikita Mikhaylov
9b51476399
Merge pull request #61910 from peter279k/fix_pr_60656_install_tests 
Fix PR #60656 for install check tests
 2024-04-25 11:16:22 +00:00
Alexander Tokmakov
8420f2f861
Merge pull request #62908 from nickitat/try_fix_00993_system_parts_race_condition_drop_zookeeper 
Fix `00993_system_parts_race_condition_drop_zookeeper`
 2024-04-25 10:52:43 +00:00
Nikita Mikhaylov
0543312542
Merge pull request #62954 from ClickHouse/mac-clang-18 
Fix build on Mac using clang-18
 2024-04-25 10:42:28 +00:00
Alexander Sapin
adfe2f78a9 Try to make error more clear 2024-04-25 12:35:08 +02:00
Kruglov Pavel
e1941202b2
Merge pull request #62866 from amosbird/fix-62848 
Fix LowCardinality(Nullable) key in hyperrectangle
 2024-04-25 10:25:56 +00:00
Chandre Van Der Westhuizen
3c3cfae8b3
updated mindsdb 2024-04-25 12:04:34 +02:00
alesapin
8a82277a03
Merge pull request #62920 from ClickHouse/some_keeper_changes 
Add some functions to zookeeper client
 2024-04-25 10:04:27 +00:00
Nikita Mikhaylov
d1c8f0af82 Better 2024-04-25 11:33:36 +02:00
Kseniia Sumarokova
8cea79ac91
Merge pull request #62868 from kitaisreal/system-drop-uninitialized-cache-fix 
SYSTEM DROP uninitialized cache fix
 2024-04-25 09:28:44 +00:00
Robert Schulze
6eb33bd9ef
Merge pull request #62932 from rschu1ze/unflake-02813_func_now_and_alias 
Unflake 02813_func_now_and_alias
 2024-04-25 09:26:15 +00:00
Raúl Marín
921073d848
Merge pull request #62912 from Algunenano/sum_if_nullable 
Disable optimize_rewrite_aggregate_function_with_if for sum(nullable)
 2024-04-25 09:25:09 +00:00
Mikhail f. Shiryaev
800449e20e
Merge branch 'master' into kerberized_hadoop_dockerfile 2024-04-25 11:22:25 +02:00
Robert Schulze
ef6585adf5
Fix compiler warnings 2024-04-25 07:48:57 +00:00
tomershafir
1cbba5c0e2
fix style 2024-04-25 07:37:49 +00:00
tomershafir
7a25e186bb
COW: assert in examples 2024-04-25 07:37:45 +00:00
kevinyhzou
e455f16660 ci fix 2024-04-25 12:28:35 +08:00
kevinyhzou
cd2ad69101 review fix 2024-04-25 12:13:08 +08:00
kevinyhzou
797788c474 modify test 2024-04-25 09:43:47 +08:00
kevinyhzou
a5d85398f9 Fix bug in from_unixtimestamp by joda syntax 2024-04-25 09:43:47 +08:00
Nikita Taranov
f0462efb73 impl 2024-04-24 22:40:29 +01:00
Justin de Guzman
620f9d64b5
[Docs] Remove experimental tag from Replicated database engine 2024-04-24 14:17:00 -07:00
Nikolay Degterinsky
bf3d33b61c Fix data race 2024-04-24 21:08:49 +00:00
alesapin
3df9c385a3 Switch back to asan 2024-04-24 22:28:43 +02:00
Nikita Mikhaylov
2ff562ebe2
Merge pull request #62899 from liuneng1994/fix-build-failed-on-clang-18 
Fix build failed on clang-18
 2024-04-24 20:22:53 +00:00
Nikita Taranov
63911cebec
Merge pull request #62911 from ClickHouse/nickitat-patch-22 
Fix 03015_optimize_final_rmt in private
 2024-04-24 18:56:53 +00:00
Nikita Taranov
09a678b927
Merge pull request #62909 from ClickHouse/nickitat-patch-20 
Fix 03013_forbid_attach_table_if_active_replica_already_exists for private
 2024-04-24 18:56:34 +00:00
Robert Schulze
c91f8ffc39
Unflake 02813_func_now_and_alias.sql 2024-04-24 18:34:59 +00:00
Alexander Tokmakov
26b9c99328
Merge pull request #59619 from alexkats/add-values-to-text-log 
Add columns for values used in the formatting message into system.text_log
 2024-04-24 18:20:30 +00:00
Robert Schulze
9c27cb61ab
Merge pull request #62888 from HarryLeeIBM/hlee-fix-openssl-build 
Fix build errors when linking OpenSSL dynamically
 2024-04-24 18:19:20 +00:00