Commit Graph

58 Commits

Author SHA1 Message Date
Vitaly Baranov
4af36ee5a4 Fix updating of the access rights after changing of the readonly setting. Remove non-const function Context::getSettingsRef(). 2020-03-22 11:08:08 +03:00
Alexey Milovidov
93466ce097 Added even more clang-tidy checks 2020-03-18 19:51:20 +03:00
Alexey Milovidov
1bd7e594b0 clang-tidy, part 2 2020-03-18 03:57:00 +03:00
Alexey Milovidov
029bcc7cd3 Fixed ErrorCodes, part 4 2020-02-25 21:58:28 +03:00
Alexey Milovidov
cb6cd2ffbb Added missing ErrorCodes, part 2 2020-02-25 21:10:48 +03:00
Nikita Mikhaylov
24cbd0d6d1 squashed commits 2020-02-19 18:01:08 +03:00
Pradeep Chhetri
4941fdfe4b Fix some spelling mistakes 2020-01-11 17:51:33 +08:00
kreuzerkrieg
9612bb0e79 More GCC warnings 2019-12-16 23:19:50 +02:00
alexey-milovidov
d354628010
Merge pull request #8088 from dingxiangfei2009/ClusterCopier/refine-zxid-def
ClusterCopier: refine zxid definition
2019-12-13 02:25:41 +03:00
alexey-milovidov
d2c7a10340
Update ClusterCopier.cpp 2019-12-13 02:25:12 +03:00
Ding Xiang Fei
21c571c5b5
Add reference to Zookeeper Internals manual 2019-12-12 18:16:14 +08:00
alexey-milovidov
3540dd5c53
Update ClusterCopier.cpp 2019-12-11 04:53:29 +03:00
Ding Xiang Fei
0f22f90ee5
refine zxid definition: it has two warping uint32 counters 2019-12-10 09:44:06 +08:00
Alexander Burmak
3e5ef56644 Filesystem abstraction layer 2019-11-27 14:33:27 +03:00
Ding Xiang Fei
8330a09575
apply style guide and fix CI warnings 2019-11-22 09:48:58 +08:00
Ding Xiang Fei
608aa276ab
add safeguard against contention to check target partition row counts 2019-11-22 09:48:57 +08:00
tavplubix
0046b9f137 Wait for jobs to finish on exception (fixes rare segfaults) (#7350) 2019-10-17 17:41:27 +03:00
proller
4f1c9ee197 CLICKHOUSE-3885 copier: use partition_key in check query 2019-08-20 21:05:01 +03:00
kreuzerkrieg
112fc71276 adding -Wshadow for GCC 2019-08-09 23:58:16 +03:00
Alexey Milovidov
f40b70884f Two more fixes for PVS-Studio 2019-07-08 05:14:32 +03:00
Alexey Milovidov
553e6a273e Two more fixes for PVS-Studio 2019-07-08 03:51:43 +03:00
Nikolai Kochetov
72afe9b842 Fix heap-use-after-free in ClusterCopier caused by watch which try to use already removed copier object. 2019-07-04 17:48:40 +03:00
alexey-milovidov
7ce4cd7861
Merge pull request #5745 from nvartolomei/nv/clickhouse-copier-cross-replication
clickhouse-copier: Allow empty database name
2019-06-27 21:09:00 +03:00
proller
aeb7eb42d1 clickhouse-copier: Fix use-after free on shutdown (#5752)
* release script: convert .deb to .rpm and .tgz

* clickhouse-copier: Fix use-after free on shutdown

* Revert "Disable cluster copier tests"

This reverts commit 71872fc3c3.
2019-06-27 15:29:49 +03:00
Nicolae Vartolomei
59d66bb1d5 clickhouse-copier: Allow empty database name
This is needed to make clickhouse-copier work with cross-replication
setups (also known as [circular replication][1]).

When database name is not specified we rely on `<default_database>`
element from replica stanza.

Example:

```xml
<source_cluster>
    <shard>
        <replica>
            <host>localhost</host>
            <port>9000</port>
            <default_database>r0</default_database>
        </replica>
        <replica>
            <host>localhost</host>
            <port>666</port>
            <default_database>r1</default_database>
        </replica>
    </shard>
    <shard>
        <replica>
            <host>localhost</host>
            <port>666</port>
            <default_database>r0</default_database>
        </replica>
        <replica>
            <host>localhost</host>
            <port>9000</port>
            <default_database>r1</default_database>
        </replica>
    </shard>
</source_cluster>
```

[1]: https://www.altinity.com/blog/2018/5/10/circular-replication-cluster-topology-in-clickhouse
2019-06-25 22:09:11 +00:00
alesapin
e45d727e9d
Merge pull request #4558 from podshumok/distributred-timeout
Distributed and remote timeouts
2019-06-17 13:58:17 +03:00
proller
09f3d68f6e Use logging in clickhouse-local. Use config options in command line in clickhouse-client (#5540)
* Try fix macos server run

* Doc macos build
 # Please enter the commit message for your changes. Lines starting

* CLICKHOUSE-3957 start wip

* tests wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* fix

* fix

* Making logger for clickhouse-local

* fixes

* wip

* wip

* wip

* wip

* clean

*      cf

* wip

* fix

* Update CMakeLists.txt

* Update argsToConfig.h

* Update argsToConfig.cpp

* Update ExtendedLogChannel.h

* Update OwnPatternFormatter.cpp
2019-06-14 17:00:37 +03:00
Konstantin Podshumok
d688203029 set timeouts in copier 2019-06-02 12:43:20 +03:00
proller
0da7463a6b
CLICKHOUSE-4519 Support dictionaries in clickhouse-copier (#5270) 2019-05-15 12:16:09 +03:00
Alexey Milovidov
58d7d1e451 Resolved some of PVS-Studio warnings 2019-04-22 19:07:09 +03:00
proller
eaffca28dd Copier: auto upload task configuration from --task-file option (#4876)
* Copier: auto upload task configuration from --task-file option

* task-upload-force

* doc

* Update ClusterCopier.cpp

* Requested changes
2019-04-05 19:10:52 +03:00
proller
236f2a4354
clickhouse-copier - fix another segfault (#4900) 2019-04-04 12:22:54 +03:00
proller
edaec2353c
CLICKHOUSE-4421 Fix segfault in copier (#4835)
* Fix segfault in copier

* add test

* better runner
2019-04-01 17:58:04 +03:00
Ivan Lezhankin
61954d855d More reverts 2019-03-15 20:09:14 +03:00
Ivan Lezhankin
4f6a494af8 Revert references where they were before refactoring. 2019-03-15 19:14:13 +03:00
Ivan Lezhankin
67eefa7b12 Revert wrong replacements of dynamic_cast.
dynamic_cast to intermediate type is not equivalent to typeid_cast
2019-03-12 15:41:57 +03:00
Ivan Lezhankin
d1ead22073 Rename As<…> → as<…> 2019-03-11 16:22:51 +03:00
Ivan Lezhankin
a7e838e328 Replace all other casts to method IAST::As<Derived>
Also remove some redundant methods like IsIdentifier() et. al.
2019-03-11 15:49:39 +03:00
Ivan Lezhankin
0e325c7a4a Replace const typeid_casts with As<Derived>() method invocations 2019-03-08 12:48:20 +03:00
chertus
ddf0f11e51 fix ClusterCopier crash cause of ThreadStatus not created 2019-02-28 18:49:03 +03:00
Alexey Milovidov
ba3cb83a84 Removed duplicate includes 2019-02-10 20:12:22 +03:00
KochetovNicolai
9f971c276f
Merge pull request #3669 from Enmk/ipv4_and_ipv6_domains
Ipv4 and ipv6 domains
2019-02-06 18:16:58 +03:00
Nikita Vasilev
a1b0dede07 Data Skipping Indices (#4143)
* made index parser

* added index parsing

* some fixes

* added index interface and factory

* fixed compilation

* ptrs

* added indexParts

* indextypes

* index condition

* IndexCondition

* added indexes in selectexecutor

* fix

* changed comment

* fix

* added granularity

* comments

* fix

* fix

* added writing indexes

* removed indexpart class

* fix

* added setSkipIndexes

* add rw for MergeTreeIndexes

* fixes

* upd error

* fix

* fix

* reading

* test index

* fixed nullptr error

* fixed

* fix

* unique names

* asts -> exprlist

* minmax index

* fix

* fixed select

* fixed merging

* fixed mutation

* working minmax

* removed test index

* fixed style

* added indexes to checkDataPart

* added tests for minmax index

* fixed constructor

* fix style

* fixed includes

* fixed setSkipIndexes

* added indexes meta to zookeeper

* added parsing

* removed throw

* alter cmds parse

* fix

* added alter

* fix

* alters fix

* fix alters

* fix "after"

* fixed alter

* alter fix + test

* fixes

* upd setSkipIndexes

* fixed alter bug with drop all indices

* fix metadata editing

* new test and repl fix

* rm test files

* fixed repl alter

* fix

* fix

* indices

* MTReadStream

* upd test for bug

* fix

* added useful parsers and ast classes

* fix

* fix comments

* replaced columns

* fix

* fixed parsing

* fixed printing

* fix err

* basic IndicesDescription

* go to IndicesDescr

* moved indices

* go to indicesDescr

* fix test minmax_index*

* fixed MT alter

* fixed bug with replMT indices storing in zk

* rename

* refactoring

* docs ru

* docs ru

* docs en

* refactor

* rename tests

* fix docs

* refactoring

* fix

* fix

* fix

* fixed style

* unique idx

* unique

* fix

* better minmax calculation

* upd

* added getBlock

* unique_condition

* added termForAST

* unique

* fixed not

* uniqueCondition::mayBeTrueOnGranule

* fix

* fixed bug with double column

* is always true

* fix

* key set

* spaces

* test

* tests

* fix

* unique

* fix

* fix

* fixed bug with duplicate column

* removed unused data

* fix

* fixes

* __bitSwapLastTwo

* fix
2019-02-05 17:50:25 +03:00
Vasily Nemkov
2716df8ab2 IPv4 and IPv6 Domain implementation.
Added:
 * IDataTypeDomain interface;
 * method DataTypeFactory::registerDataTypeDomain for registering domains;
 * DataTypeDomainWithSimpleSerialization domain base class with simple serialization/deserialization;
 * Concrete IPv4 and IPv6 domain implementations: DataTypeDomanIPv6 and DataTypeDomanIPv4;

Updated:
 * IDataType text serialization/deserialization methods;
 * IDataType implementation to use domain for text serialization/deserialization;
 * Refactored implementation of the IPv4/IPv6 functions to use formatIPv4/v6 and parseIPv4/v6 from Common/formatIPv6.h;

Tests:
 * Added test cases for IPv4 and IPv6 domains.
 * Updated IPv4/v6 functions tests to validate more cases;
 * Added performance tests for IPv4 and IPv6 related functions;
2019-02-04 12:37:46 +03:00
Alexey Milovidov
abcd5a2a49 Attempt to implemnt global thread pool #4018 2019-01-11 22:12:36 +03:00
proller
497b6ec2ad
Better compile with low memory; Fix macos build, add utils/build/build_debian_unbundled_split.sh test script (#4030) 2019-01-11 15:40:19 +03:00
Alexey Milovidov
19f4652959 Fixed bugs found by PVS-Studio 2019-01-09 18:44:20 +03:00
Daniel Dao
9a676329c2
Fix simple typo in ClusterCopier
Signed-off-by: Daniel Dao <dqminh89@gmail.com>
2018-12-17 16:45:44 +00:00
Alexey Milovidov
c77930fe30 Whitespaces [#CLICKHOUSE-2] 2018-11-26 03:56:50 +03:00
Alexey Milovidov
7d6fffff48 More style checks [#CLICKHOUSE-3] 2018-11-24 04:48:06 +03:00