Commit Graph

156021 Commits

Author SHA1 Message Date
avogar
2b735896ea Better comments 2024-10-09 03:28:46 +00:00
pufit
03962be4d3
Merge pull request #70459 from davidtsuk/cli-implicit-bool
Command-line arguments with no value that are Bool settings should be implicitly set to true.
2024-10-09 03:28:31 +00:00
János Benjamin Antal
88133f513d Use logging instead of print 2024-10-09 03:23:15 +00:00
Pavel Kruglov
26f9aec1a5
Merge pull request #70288 from Avogar/json-as-string-row-binary
Allow to read/write JSON type as binary string in RowBinary format
2024-10-09 03:15:38 +00:00
Robert Schulze
eefe70472e
Merge pull request #70418 from Blargian/docs_connectionId
[Docs] update `connectionId` alias
2024-10-09 02:14:41 +00:00
Robert Schulze
df8568c446
Merge pull request #70421 from Blargian/docs_extract
[Docs] Updates `extract`, adds `extractGroups` documentation
2024-10-09 01:46:01 +00:00
Robert Schulze
6307267ba2
Merge pull request #70419 from Blargian/docs_current_schemas
[Docs] Document `currentSchemas` function
2024-10-09 01:43:15 +00:00
Robert Schulze
703382776c
Merge pull request #70416 from Blargian/docs_ignore
[Docs] Update `ignore` documentation
2024-10-09 01:42:20 +00:00
Robert Schulze
7569d6917e
Update other-functions.md 2024-10-09 03:41:18 +02:00
Nikolay Degterinsky
5642f786b8
Merge pull request #70499 from singhksandeep25/docs_memory_setting_example
[Docs] Added example in docs for setting user level memory restriction
2024-10-08 22:29:11 +00:00
Michael Kolupaev
ab06938478
Merge pull request #70460 from ClickHouse/dep
Fix refreshable MV in system database breaking server startup
2024-10-08 21:17:12 +00:00
singhksandeep25
3a41316977 changed username 2024-10-09 02:21:52 +05:30
singhksandeep25
6ad3cf433f added example on how to set this setting for a user 2024-10-09 02:19:01 +05:30
David Tsukernik
a576fc32f5 Merge remote-tracking branch 'origin/master' into cli-implicit-bool 2024-10-08 17:55:28 +00:00
Sharath K S
6d308b31c0 Updated log_query_settings description in Settings.cpp 2024-10-08 10:11:16 -07:00
Vladimir
775308f869
Fixed typo YSQL in grant.md 2024-10-08 20:08:57 +03:00
vdimir
a23e8071db
Merge pull request #70374 from Avogar/fix-json-sub-object-subcolumn-group-by
Fix crash during GROUP BY JSON sub-object subcolumn
2024-10-08 17:02:48 +00:00
sharathks118
88671d8265
Merge branch 'master' into setting-opentelemetry 2024-10-08 21:53:20 +05:30
Blargian
6b56ca4e10 update toFixedString and toISOWeek 2024-10-08 18:22:52 +02:00
robot-clickhouse
cf34ba81a3
Merge pull request #70485 from ClickHouse/auto/v24.3.12.75-lts
Update version_date.tsv and changelog after v24.3.12.75-lts
2024-10-08 16:02:38 +00:00
Shaun Struwig
9bd36d2367
Merge branch 'master' into docs_toIP 2024-10-08 17:58:32 +02:00
Blargian
c35c812edf review changes 2024-10-08 17:56:52 +02:00
Alexey Milovidov
d60dd68759
Merge pull request #70422 from azat/completion-warning-fix
Ignore "Invalid multibyte data detected" error during completion
2024-10-08 15:54:26 +00:00
vdimir
024851b0f0
Truncate and escape HTTP body in logs 2024-10-08 15:41:57 +00:00
johnnyfish
124970bf40 spelling fixes 2024-10-08 18:39:10 +03:00
Blargian
f151d4f4b5 link to UInt64 page 2024-10-08 17:31:33 +02:00
Blargian
62374ac645 undo accidental change on wrong branch 2024-10-08 17:30:24 +02:00
Blargian
ce4d6c81b8 link UInt64 to relevant page 2024-10-08 17:29:19 +02:00
Blargian
5703b5409a review changes and fix style-heck 2024-10-08 17:23:30 +02:00
Blargian
fccd1cf822 review changes: change instances of value to string, add syntax and argument to toIPv4 2024-10-08 17:15:19 +02:00
Arthur Passos
fadaef4742 trigger ci 2024-10-08 12:05:09 -03:00
robot-clickhouse
f920f957d6 Update version_date.tsv and changelogs after v24.3.12.75-lts 2024-10-08 15:03:12 +00:00
Alexander Gololobov
a261c0a77e
Merge pull request #70453 from ClickHouse/fix_flaky_03249_dynamic_alter_consistency
Fix order in 03249_dynamic_alter_consistency
2024-10-08 14:36:42 +00:00
Sharath K S
15a86aeaf6 Add prefix "clickhouse.setting." to query setting names in span log
Updated relevant documentation and setting descriptions to reflect this change.
2024-10-08 07:33:33 -07:00
Alexey Milovidov
3ab6b8b621
Merge pull request #70473 from azat/tests/00913_many_threads
Decrease probability of "Server died" due to 00913_many_threads
2024-10-08 14:28:54 +00:00
Blargian
78e57ebe04 update aspell-ignore 2024-10-08 16:25:26 +02:00
Blargian
fce6df5e93 review changes 2024-10-08 16:17:26 +02:00
Arthur Passos
514fa6febf add new test file 2024-10-08 10:55:43 -03:00
Arthur Passos
e5188d4212 rmv ssh key 2024-10-08 10:55:19 -03:00
Arthur Passos
73cba7fbdc add test for ipv6 2024-10-08 10:54:17 -03:00
Antonio Andelic
2e6bd082a6
Merge pull request #70452 from ClickHouse/fix-vertical-merge-prefetch
Don't prefetch parts with no rows
2024-10-08 13:28:31 +00:00
Arthur Passos
2b5eef39a9 move setting to 24.10 2024-10-08 09:09:04 -03:00
Azat Khuzhin
5e33f2d714 tests/clickhouse-test: fix pylint warning about unused vars in signal handler
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-10-08 12:57:29 +02:00
Azat Khuzhin
9fd9ed40bb Ignore ESRCH while obtaining process group
Should fix the following [1]:

    2024-10-07 21:13:38 02784_connection_string:                                                [ OK ] 9.69 sec.
    2024-10-07 21:13:38 Process Process-5:
    2024-10-07 21:13:38 Traceback (most recent call last):
    2024-10-07 21:13:38   File "/usr/lib/python3.10/multiprocessing/process.py", line 314, in _bootstrap
    2024-10-07 21:13:38     self.run()
    2024-10-07 21:13:38   File "/usr/lib/python3.10/multiprocessing/process.py", line 108, in run
    2024-10-07 21:13:38     self._target(*self._args, **self._kwargs)
    2024-10-07 21:13:38   File "/usr/bin/clickhouse-test", line 2609, in run_tests_process
    2024-10-07 21:13:38     return run_tests_array(*args, **kwargs)
    2024-10-07 21:13:38   File "/usr/bin/clickhouse-test", line 2327, in run_tests_array
    2024-10-07 21:13:38     stop_tests()
    2024-10-07 21:13:38   File "/usr/bin/clickhouse-test", line 445, in stop_tests
    2024-10-07 21:13:38     cleanup_child_processes(os.getpid())
    2024-10-07 21:13:38   File "/usr/bin/clickhouse-test", line 433, in cleanup_child_processes
    2024-10-07 21:13:38     child_pgid = os.getpgid(child)
    2024-10-07 21:13:38 ProcessLookupError: [Errno 3] No such process

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/70448/cd826389e90065466ddfef140fc344b30e8c6de0/stateless_tests__aarch64_.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-10-08 12:40:50 +02:00
Azat Khuzhin
95f3d2e4e9 Kill tests leftovers in case of timeout
Though now there are oddities with multiprocessing_manager.list():

    Having 1 errors! 0 tests passed. 0 tests skipped. 2.20 s elapsed (MainProcess).
    Won't run stateful tests because test data wasn't loaded.
    Traceback (most recent call last):
      File "/usr/lib/python3.12/multiprocessing/managers.py", line 813, in _callmethod
        conn = self._tls.connection
               ^^^^^^^^^^^^^^^^^^^^
    AttributeError: 'ForkAwareLocal' object has no attribute 'connection'

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
      File "/src/ch/clickhouse/.cmake/../tests/clickhouse-test", line 3707, in <module>
        main(args)
      File "/src/ch/clickhouse/.cmake/../tests/clickhouse-test", line 3126, in main
        if len(restarted_tests) > 0:
           ^^^^^^^^^^^^^^^^^^^^
      File "<string>", line 2, in __len__
      File "/usr/lib/python3.12/multiprocessing/managers.py", line 817, in _callmethod
        self._connect()
      File "/usr/lib/python3.12/multiprocessing/managers.py", line 804, in _connect
        conn = self._Client(self._token.address, authkey=self._authkey)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "/usr/lib/python3.12/multiprocessing/connection.py", line 519, in Client
        c = SocketClient(address)
            ^^^^^^^^^^^^^^^^^^^^^
      File "/usr/lib/python3.12/multiprocessing/connection.py", line 647, in SocketClient
        s.connect(address)
    ConnectionRefusedError: [Errno 111] Connection refused

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-10-08 12:35:07 +02:00
Azat Khuzhin
94df71fdc2 Add exception message into "Hung check failed" message
Here [1] the hung query failed:

    2024.10.07 21:13:29.044675 [ 16750 ] {484a1200-d576-4c03-a82b-2d389b8e773f} <Debug> executeQuery: (from [::1]:43374) SELECT 1 /*hung check*/
      (stage: Complete)
    2024.10.07 21:13:29.047252 [ 16750 ] {484a1200-d576-4c03-a82b-2d389b8e773f} <Error> executeQuery: Code: 210. DB::Exception: I/O error: Broken pipe, while writing to socket ([::1]:8123 -> [::1]:43374): While executing TabSeparatedRowOutputFormat. (NETWORK_ERROR) (version 24.10.1.1368) (from [::1]:43374) (in query: SELECT 1 /*hung check*/

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/70448/cd826389e90065466ddfef140fc344b30e8c6de0/stateless_tests__aarch64_.html

But I don't see any possible reasons for this, only if the client closes
the connection, but I bet that the query had been sent long time ago,
but due to VM stall (#70473) it was not accepted.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-10-08 12:22:08 +02:00
Azat Khuzhin
8d4036760c Decrease probability of "Server died" due to 00913_many_threads
This test creates too much threads (1500), and sometimes there are some
stalls on arm64 [1]:

    2024.10.07 21:06:38.768974 [ 4479 ] {3041e49a-89c3-4991-a59f-6ae221a5afd0} <Debug> executeQuery: (from [::1]:52210) (comment: 00913_many_threads.sql) SELECT count() FROM t; (stage: Complete)
    ...
    2024.10.07 21:07:37.028725 [ 15271 ] {3041e49a-89c3-4991-a59f-6ae221a5afd0} <Trace> AggregatingTransform: Aggregated. 1 to 1 rows (from 0.00 B) in 58.247881431 sec. (0.017 rows/sec., 0.00 B/sec.)
    2024.10.07 21:11:20.662232 [ 15270 ] {3041e49a-89c3-4991-a59f-6ae221a5afd0} <Trace> AggregatingTransform: Aggregating
    ...

As you can see there are zero logs for almost 4 minutes, and trace_log
contains zero records for the interval event_time between '2024.10.07
21:07:37' and '2024.10.07 21:11:20'.

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/70448/cd826389e90065466ddfef140fc344b30e8c6de0/stateless_tests__aarch64_.html

At first I thought about adding some new metrics like
GlobalThreadPoolThreadSlowCreationMicroseconds, but it will unlikely
help with understading the root cause.

Then I thought about exposing CPU steal metric, but the problem is that
AWS uses Nitro instead of Xen for this instances (r6g.2xlarge), and
Nitro does not expose this metric.

So let's just disable parallel execution of this test to stabilize the
CI.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-10-08 12:20:57 +02:00
Robert Schulze
6f88ada7a9
Merge pull request #70467 from rschu1ze/docs-grammar
[Docs] Fix grammar and consistency
2024-10-08 10:11:49 +00:00
kssenii
250e8c6119 Fix setting description 2024-10-08 10:43:44 +02:00
Raúl Marín
d57f0a9d37 More consistent error codes 2024-10-08 16:35:08 +08:00