Commit Graph

4110 Commits

Author SHA1 Message Date
Anton Popov
7f31196606 fix LOGICAL_ERROR in async inserts 2023-02-13 14:59:14 +00:00
Vladimir C
89cb55aa1f
whitespace 2023-02-13 12:19:31 +01:00
Vladimir C
1a89ecd386 Apply suggestions from code review
Co-authored-by: Nikita Taranov <nikita.taranov@clickhouse.com>
2023-02-13 12:17:56 +01:00
vdimir
e4c0afcc3e Do not build filtering set for sorting join with const columns 2023-02-13 12:17:56 +01:00
kssenii
3067c1d723 Merge remote-tracking branch 'upstream/master' into resubmit-prefetches 2023-02-11 11:36:23 +01:00
Alexander Gololobov
f2a975f548
Merge pull request #46270 from Avogar/fix-arrow-lc
Fix possible out of bounds error while reading LowCardinality(Nullable) in Arrow format
2023-02-11 10:03:00 +01:00
Vladimir C
ea670acb72
Add comment to requestReadingInOrder 2023-02-10 20:05:18 +01:00
Kruglov Pavel
2a3cb8b4ee
Merge pull request #45340 from Avogar/parquet-fixed-binary
Support FixedSizeBinary type in Parquet/Arrow
2023-02-10 18:31:20 +01:00
Alexey Milovidov
d5d87bc6b7
Merge pull request #46152 from ClickHouse/with-fill-bigint
More convenient usage of big integers and ORDER BY WITH FILL.
2023-02-10 20:05:32 +03:00
avogar
deda940d87 Fix possible out of bounds error while reading LowCardinality(Nullable) in Arrow format 2023-02-10 12:57:47 +00:00
Geoff Genz
99c3ff53c5 Merge remote-tracking branch 'origin/master' into http_client_version
# Conflicts:
#	src/Interpreters/Context.cpp
#	src/Interpreters/Context.h
2023-02-10 04:35:53 -07:00
Geoff Genz
db982695fa Simplify NativeOutputFormat constructors 2023-02-10 04:30:08 -07:00
Geoff Genz
7ed8ed0284 Add support for client_protocol_version sent with HTTP 2023-02-10 03:47:06 -07:00
flynn
37a850bd36 Merge branch 'master' of github.com:ClickHouse/ClickHouse into iceberg 2023-02-10 08:47:14 +00:00
flynn
db15634a01 fix conflict 2023-02-10 08:41:04 +00:00
Igor Nikonov
df23731061 Removing DISTINCT on top of aggregation if possible 2023-02-09 11:37:15 +00:00
vdimir
45f7ef6c8f
Do not apply read in reverse order for queries with final 2023-02-09 11:00:22 +00:00
vdimir
a179528ea4
Revert "Fix read in order optimization for DESC sorting with FINAL"
This reverts commit cf762347d5.
2023-02-09 10:47:45 +00:00
Robert Schulze
e490ec91d9
Merge branch 'master' into rs/fix-fragile-linking 2023-02-09 11:33:59 +01:00
Kruglov Pavel
b5f90c608a
Merge branch 'master' into parquet-fixed-binary 2023-02-09 11:26:38 +01:00
vdimir
cf762347d5
Fix read in order optimization for DESC sorting with FINAL 2023-02-09 10:26:37 +00:00
Vladimir C
0042c20770
Merge pull request #46054 from alexX512/bug_fix_pulling_pipeline 2023-02-09 10:50:46 +01:00
Alexey Milovidov
3a75ede60a Implement #16733 2023-02-09 08:41:47 +01:00
Alexey Milovidov
cb847172ea Fix something 2023-02-09 08:39:46 +01:00
Alexey Milovidov
a40ef2bf18 Make it better 2023-02-09 08:09:19 +01:00
Alexey Milovidov
292a5abbc9 Merge remote-tracking branch 'origin/master' into with-fill-bigint 2023-02-09 01:47:51 +01:00
Alexander Tokmakov
8101b044fa
Merge pull request #46091 from azat/sanity-assertions
Sanity assertions for closing file descriptors
2023-02-09 01:02:03 +03:00
kssenii
b0b865c32e Resubmit prefetches 2023-02-08 21:26:24 +01:00
Robert Schulze
6ff232d782
Merge branch 'master' into rs/fix-fragile-linking 2023-02-08 12:51:12 +01:00
Kruglov Pavel
4e2918cee3
Merge branch 'master' into parquet-fixed-binary 2023-02-08 12:31:13 +01:00
Igor Nikonov
72c393e7c4
Merge pull request #46014 from ClickHouse/inorder-optimization-update-sorting-properties
Update sorting properties after reading in order applied
2023-02-08 10:19:47 +01:00
Alexey Milovidov
a9ec73a209 Fix strange trash 2023-02-08 08:26:27 +01:00
Igor Nikonov
5709c9832c Merge remote-tracking branch 'origin/master' into igor/remove_redundant_distinct 2023-02-07 11:49:25 +00:00
Igor Nikonov
14f8eff290 Fixes: checking if steps between DISTINCTs can generate new rows 2023-02-07 11:48:23 +00:00
Robert Schulze
08c1f8346e
Merge remote-tracking branch 'origin/master' into rs/fix-fragile-linking 2023-02-07 11:22:00 +00:00
Azat Khuzhin
8cc41b7f41 Check return value of ::close()
Note, that according close(2), EINTR should not be retriable for close()

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 11:28:22 +01:00
Anton Popov
3ad5a085da
Merge pull request #45987 from CurtizJ/fix-sparse-columns-crash
Fix `INTERSECT` and `EXCEPT` with sparse columns
2023-02-06 23:01:02 +01:00
Alexey Perevyshin
7a4d658a46
Merge branch 'master' into bug_fix_pulling_pipeline 2023-02-06 14:24:26 +03:00
flynn
0dd8a61a8e fix conflict 2023-02-06 03:25:12 +00:00
Robert Schulze
84b9ff450f
Fix terribly broken, fragile and potentially cyclic linking
Sorry for the clickbaity title. This is about static method
ConnectionTimeouts::getHTTPTimeouts(). It was be declared in header
IO/ConnectionTimeouts.h, and defined in header
IO/ConnectionTimeoutsContext.h (!). This is weird and caused issues with
linking on s390x (##45520). There was an attempt to fix some
inconsistencies (#45848) but neither did @Algunenano nor me at first
really understand why the definition is in the header.

Turns out that ConnectionTimeoutsContext.h is only #include'd from
source files which are part of the normal server build BUT NOT part of
the keeper standalone build (which must be enabled via CMake
-DBUILD_STANDALONE_KEEPER=1). This dependency was not documented and as
a result, some misguided workarounds were introduced earlier, e.g.
0341c6c54b

The deeper cause was that getHTTPTimeouts() is passed a "Context". This
class is part of the "dbms" libary which is deliberately not linked by
the standalone build of clickhouse-keeper. The context is only used to
read the settings and the "Settings" class is part of the
clickhouse_common library which is linked by clickhouse-keeper already.

To resolve this mess, this PR

- creates source file IO/ConnectionTimeouts.cpp and moves all
  ConnectionTimeouts definitions into it, including getHTTPTimeouts().

- breaks the wrong dependency by passing "Settings" instead of "Context"
  into getHTTPTimeouts().

- resolves the previous hacks
2023-02-05 20:49:34 +00:00
Igor Nikonov
089a0009ad Polishing
+ try to stabilize distinct in order perf test
2023-02-05 13:38:20 +00:00
alexX512
ea07f08f75 Fix bug with wrong checking of execution finish in PullingAsyncPipeline 2023-02-05 13:23:26 +00:00
flynn
f89a6cf68d Improve format JSONColumns when result is empty 2023-02-05 13:13:21 +00:00
Nikita Taranov
1f1be6195e fix 2023-02-04 21:54:48 +00:00
Nikita Taranov
750933d265 fix 2023-02-04 21:09:44 +00:00
Nikita Taranov
b983b363f8 Merge branch 'master' into aggr_partitions_independently 2023-02-04 18:24:31 +00:00
Nikita Taranov
5183cc6ee5 fix 2023-02-04 16:14:53 +00:00
Igor Nikonov
f49f5d7091 Update tests
+ updadte sorting properties after applying aggregation in order
2023-02-03 17:10:31 +00:00
Igor Nikonov
38a0ef8743 Merge remote-tracking branch 'origin/master' into igor/remove_redundant_distinct 2023-02-03 15:13:06 +00:00
Igor Nikonov
82e50fc211 Fix review comments 2023-02-03 15:12:20 +00:00
Anton Popov
88f2068bfb
Merge branch 'master' into fix-sparse-columns-crash 2023-02-03 16:01:11 +01:00
Nikita Mikhaylov
33877b5e00
Parallel replicas. Part [2] (#43772) 2023-02-03 14:34:18 +01:00
Igor Nikonov
ed00db7580 Update sorting properties after reading in order applied 2023-02-03 13:15:06 +00:00
Igor Nikonov
7b922784e8 Merge remote-tracking branch 'origin/master' into igor/remove_redundant_distinct 2023-02-03 10:29:37 +00:00
Robert Schulze
6908093787
Merge pull request #45973 from ClickHouse/final-codecs
Add "final" specifier to some classes
2023-02-03 10:52:59 +01:00
Anton Popov
ca20b1e32f fix INTERSECT and EXCEPT with sparse columns 2023-02-03 00:17:55 +00:00
Igor Nikonov
46ed757472 Fix review comments 2023-02-02 20:07:47 +00:00
Robert Schulze
3472ed4f0d
Make some classes 'final' 2023-02-02 15:59:39 +00:00
Antonio Andelic
a39e4e24c6
Merge branch 'master' into optimize_parquet_reader 2023-02-02 14:18:00 +01:00
Igor Nikonov
32ab4dc693 Fix review comments 2023-02-02 11:46:13 +00:00
Igor Nikonov
996b833faa Some polishing 2023-02-02 11:14:26 +00:00
Alexey Milovidov
97b6934ed6
Update ParquetBlockInputFormat.cpp 2023-02-02 02:42:21 +03:00
Nikita Taranov
4fbbca075b review fixes 2023-02-01 23:01:02 +00:00
Igor Nikonov
8f873d5682 Disable optimize_duplicate_order_by_and_distinct
+ tests
2023-02-01 21:13:44 +00:00
Igor Nikonov
fc71acc768 Fix DISTINCT with intersect/except 2023-02-01 13:06:34 +00:00
Igor Nikonov
d3d5e67a36 Merge remote-tracking branch 'origin/master' into igor/remove_redundant_distinct 2023-02-01 12:03:06 +00:00
liuneng
17fc22a21e add parquet max_block_size setting 2023-02-01 18:29:20 +08:00
Robert Schulze
b512316586
Merge pull request #45682 from ClickHouse/rename-qrc-to-qc
Rename "Query Result Cache" to "Query Cache"
2023-02-01 11:23:29 +01:00
liuneng
cda9b0beea optimize parquet reader 2023-02-01 15:54:10 +08:00
Alexey Milovidov
075dfe9005
Merge pull request #45750 from ucasfl/arrow-duration
Arrow support duration type
2023-01-31 20:34:38 +03:00
flynn
ffddc0dcce fix conflict 2023-01-31 10:28:58 +00:00
Robert Schulze
325c6bdf3d
Renaming: "Query Result Cache" --> "Query Cache"
Reasons:

- The cache will at some point store intermediate results as opposed to
  only query results. We should change the terminology now without
  having to worry about backward compat.

- Equivalent caches in MySQL (1) and Starrocks (2) are called "query
  cache".

- The new name is ca. 13.8% more catchy.

(1) https://dev.mysql.com/doc/refman/5.6/en/query-cache.html
(2) https://docs.starrocks.io/en-us/2.5/using_starrocks/query_cache
2023-01-31 09:54:34 +00:00
Igor Nikonov
f8bcf78593 Merge remote-tracking branch 'origin/master' into igor/remove_redundant_distinct 2023-01-30 23:12:09 +00:00
Igor Nikonov
fdb9336b02 Respect aliases when compare DISTINCT columns 2023-01-30 23:08:26 +00:00
Nikita Taranov
8223fc6ab9 stash 2023-01-30 23:02:27 +00:00
Nikita Taranov
8b51bd84c0 improve perf 2023-01-30 17:11:56 +00:00
Nikita Taranov
3e3d1d15a8 properly handle case when there is nondeterministic functions 2023-01-30 17:11:56 +00:00
Nikita Taranov
581f31ad3d better 2023-01-30 17:11:56 +00:00
Nikita Taranov
a18343773f improve perf 2023-01-30 17:11:56 +00:00
Nikita Taranov
0d393c7a7f cosmetics 2023-01-30 17:11:56 +00:00
Nikita Taranov
47f57b7a5d few heuristics to disable optimisation 2023-01-30 17:11:56 +00:00
Nikita Taranov
3ce725023c fix style & build 2023-01-30 17:11:56 +00:00
Nikita Taranov
52fe7edbd9 better key analysis 2023-01-30 17:11:56 +00:00
Nikita Taranov
962f163dbd add settings 2023-01-30 17:11:52 +00:00
Nikita Taranov
b59ba628a9 do not group buckets w/o need 2023-01-30 17:10:45 +00:00
Nikita Taranov
abe9ab2dff small fix for matchTrees 2023-01-30 17:10:45 +00:00
Nikita Taranov
d7e1e6314c move matchTrees to separate file 2023-01-30 17:10:45 +00:00
Nikita Taranov
2057db68a2 cosmetics 2023-01-30 17:10:45 +00:00
Nikita Taranov
1d45cce03c support for aggr in order 2023-01-30 17:10:45 +00:00
Nikita Taranov
a2c9aeb7c9 stash 2023-01-30 17:10:45 +00:00
flynn
801d6db486 Arrow support duration type 2023-01-29 10:55:31 +00:00
flynn
9b517cdc76 fix conflict 2023-01-29 08:34:56 +00:00
Alexey Milovidov
9ad87f9917 Fix style and typo 2023-01-29 03:51:42 +01:00
Igor Nikonov
101a0cc90b Merge remote-tracking branch 'origin/master' into igor/remove_redundant_distinct 2023-01-27 19:08:38 +00:00
Igor Nikonov
300f78df96
Merge pull request #45567 from ClickHouse/enable-remove-redundant-sorting
Enable query_plan_remove_redundant_sorting optimization by default
2023-01-27 19:14:36 +01:00
Igor Nikonov
4480d8ae60 Merge remote-tracking branch 'origin/master' into igor/remove_redundant_distinct 2023-01-26 22:16:24 +00:00
Igor Nikonov
60a69d4689 Fix distinct after JOIN or UNION 2023-01-26 21:53:08 +00:00
Igor Nikonov
211edc054e Fix check for sum*(Float) 2023-01-26 19:26:53 +00:00
Alexander Tokmakov
067b1f5f13 Merge branch 'master' into exception_message_patterns4 2023-01-26 15:20:58 +01:00
Igor Nikonov
105d72e299 Fix: sum*() with Nullable(Float) 2023-01-26 13:17:06 +00:00