Commit Graph

22343 Commits

Author SHA1 Message Date
alesapin
d3461f9d46 TODO comments 2019-10-22 14:03:16 +03:00
alesapin
99fac92b1d Fix comment 2019-10-22 13:49:11 +03:00
alesapin
4c5d150d7a Review fixes 2019-10-22 13:47:43 +03:00
Alexander Kuzmenkov
dfd9f26652 Port the latest dispatch() improvements. 2019-10-22 13:44:08 +03:00
Ivan
7ba4e36e73
Don't push to MVs when inserting into Kafka table (#7265)
* Do not insert values into MV when inserting directly to Kafka
* Add method noPushingToViews() to IStorage interface
  To separate InterpreterInsertQuery and StorageKafka
2019-10-22 13:31:28 +03:00
Vladimir Chebotarev
395e63ddf1
Fixed erroneous warning max_data_part_size is too low #7414 2019-10-22 12:24:30 +03:00
Alexander Kuzmenkov
be4618dd05
Merge pull request #7339 from amosbird/f10
Fix preciseExp10
2019-10-22 12:00:53 +03:00
Amos Bird
88834bd75a
Resolve DUMP overload resolution ambiguity. 2019-10-22 15:10:59 +08:00
Amos Bird
82d0dfa629
Better add_globs 2019-10-22 15:09:49 +08:00
hcz
d877ef6098 Merge remote-tracking branch 'hcz/patch-1018' into patch-1018 2019-10-22 11:31:23 +08:00
memo
645bcdacae add docs and simplify the code 2019-10-22 10:23:07 +08:00
Nikolai Kochetov
dad1e397e2 Fix build. 2019-10-22 02:51:36 +03:00
Nikolai Kochetov
e7ba48ee84 Fix build. 2019-10-22 02:49:44 +03:00
Artem Zuikov
21e4535fbd
Merge pull request #7411 from 4ertus2/some
Minor Visitors Improvement
2019-10-21 23:17:05 +03:00
Vitaly Baranov
f611fd4dfa
Merge pull request #7293 from Vdimir/feature/isvalidjson-5910
Add function isValidJSON
2019-10-21 21:24:18 +03:00
chertus
f024b007a2 default_merge_block_size setting 2019-10-21 20:57:26 +03:00
alesapin
83dbfe9634 New tests and fixes for them 2019-10-21 20:09:41 +03:00
Nikolai Kochetov
2b334a4adb Review fixes. 2019-10-21 19:26:29 +03:00
chertus
851b00c99f minor visitors improvement 2019-10-21 19:22:54 +03:00
Alexander Kuzmenkov
9c1f8109c7
Merge pull request #7402 from Enmk/odbc_bridge_nullable_fix
Fixed NULL-values in nullable columns through ODBC-bridge
2019-10-21 19:09:27 +03:00
Amos Bird
a860ee7891
Fix preciseExp10 2019-10-22 00:05:57 +08:00
alesapin
10f69eef03 Add tests for non standart dictionaries and fix bugs 2019-10-21 19:05:45 +03:00
Nikolai Kochetov
2893c35930 Merged with master. 2019-10-21 18:33:44 +03:00
Nikolai Kochetov
4ca83a8eb5 Disable processors by default. 2019-10-21 18:24:15 +03:00
Nikolai Kochetov
f7d2e1b758 Added Pipe class. Updated MergeTreeDataSelectExecutor. 2019-10-21 18:16:08 +03:00
alesapin
ff7850cfbd Remove strange code in favor of less strange code 2019-10-21 17:59:35 +03:00
Alexander Kuzmenkov
d865aeba9b Review fixes. 2019-10-21 17:54:53 +03:00
alesapin
307f711500 Fix db mysql dictionaries iterator 2019-10-21 17:25:21 +03:00
alesapin
f7043c38bd Less diff 2019-10-21 17:20:42 +03:00
alesapin
fc05110d66 Better naming 2019-10-21 17:07:47 +03:00
alesapin
17c2f301e2 Remove accident cerr 2019-10-21 17:00:18 +03:00
alesapin
e4a936cf41 Fix add and reload 2019-10-21 16:54:23 +03:00
Vitaly Baranov
a0ca932035
Fix build and add comments. 2019-10-21 16:39:55 +03:00
Amos Bird
a864447802 Introduce String Hash Map.
It speeds up aggregation over short string keys. Use it as a default
aggregation method for string keys.
2019-10-21 16:27:35 +03:00
akonyaev
f6bb52637d return for empty avg result over decimal 0 in ResultT type 2019-10-21 16:05:32 +03:00
robot-clickhouse
7381489d5d Auto version update to [19.17.1.1] [54428] 2019-10-21 15:48:00 +03:00
robot-clickhouse
c70cd3dd17 Auto version update to [19.16.1.1532] [54427] 2019-10-21 15:47:27 +03:00
akonyaev
28710b7e42 unexpected behaviour for avg and quantile functions over empty decimal column without group by 2019-10-21 15:46:47 +03:00
chertus
4f0859a5fa Merge branch 'master' into ast 2019-10-21 15:08:05 +03:00
chertus
0d708569e3 fix test result (disabled push down) 2019-10-21 14:31:16 +03:00
chertus
5ef7376cbf fix distributed join on 2019-10-21 14:22:22 +03:00
Vasily Nemkov
e080324fd0 Fixed NULL-values in nullable columns through ODBC-bridge 2019-10-21 12:13:33 +03:00
alesapin
26c87e46c9 Merge branch 'master' into dictionaries_ddl_loader 2019-10-21 11:46:49 +03:00
alesapin
35e66d6696 Merge with master 2019-10-21 11:46:11 +03:00
millb
2a183c3d07 Merge branch 'master' into decimal_hex_function 2019-10-21 11:13:51 +03:00
hcz
79a27ece1a Flip the condition column in arrayFill 2019-10-21 11:19:11 +08:00
alexey-milovidov
61125e536b
Update 01019_materialized_view_select_extra_columns.sql 2019-10-20 17:59:26 +03:00
alexey-milovidov
8b8cc67873
Merge pull request #7390 from azat/processlist-log-queue_max_wait_ms
Add a message in case of queue_wait_max_ms wait takes place
2019-10-20 17:55:36 +03:00
Nicolae Vartolomei
b0f2f23a38 Test materialized view pushing extra columns
This test exists to prevent unintended changes to existing behaviour.

Although this behaviour might not be ideal it is can be exploited for 0-downtime changes to materialized views.

Step 1: Add new column to source table.
Step 2: Create new view reading source column.
Step 3: Swap views using `RENAME TABLE`.
Step 4: Add new column to destination table as well.
2019-10-20 10:26:44 +01:00
Aleksey Akulovich
a019e45093 fix typos in docs and comment (#7385) 2019-10-20 12:43:54 +08:00
philip.han
5e32bf1ae7 Removed unchecked type-casting 2019-10-19 21:42:08 +09:00
VDimir
797f76a187 Separate class for IsValidJSONImpl 2019-10-19 07:26:19 +00:00
alexey-milovidov
52bfa9927c
Merge pull request #7384 from ClickHouse/fix_ub_in_system_parts
Fix UB in StoragesInfoStream
2019-10-19 09:59:39 +03:00
VDimir
f1630b4e2e Merge branch 'master' into feature/isvalidjson-5910 2019-10-19 06:21:21 +00:00
Azat Khuzhin
260a9fba2b StorageDistributed: Drop extra inclusion of materializeBlock.h 2019-10-18 23:38:33 +03:00
Azat Khuzhin
94948c2579 Add a message in case of queue_wait_max_ms wait takes place
Since there no information about this, while this can be interesting,
for example to tune max_concurrent_queries in some cases.
2019-10-18 23:36:12 +03:00
chertus
c5a850240c better ambiguous column detection in multiple join rewriter 2019-10-18 20:09:17 +03:00
chertus
37f07213ee better test 2019-10-18 19:45:59 +03:00
chertus
1bb8174285 disable push down for CROSS JOIN tests 2019-10-18 19:34:06 +03:00
chertus
2533652847 columns match priority: table alias > table name> aliased table name 2019-10-18 19:16:57 +03:00
alesapin
a014924c19 Remove wrong tests 2019-10-18 19:04:12 +03:00
alesapin
cdc195727e Fix some races from lazy load and add ugly interface to loader (need to be refactored) 2019-10-18 19:04:09 +03:00
Alexander Kuzmenkov
5e2cc37381
Distinguish Array and Tuple field types when creating from array of Fields. (#7179) 2019-10-18 18:57:05 +03:00
hcz
2be06255b1
Update arrayFill.cpp 2019-10-18 21:31:18 +08:00
Alexander Tokmakov
06b28f9fe3 fix uninitialized offset for Lazy db 2019-10-18 16:09:24 +03:00
Alexander Kuzmenkov
3143fa37d7
Merge pull request #7371 from CurtizJ/fix-optimize-read-in-order
Fix optimize_read_in_order with IN and a subquery.
2019-10-18 15:55:53 +03:00
philip.han
5f1b14e313 Remove a dynamically sized array in BloomFilterHash.h 2019-10-18 19:39:10 +09:00
hcz
502672c973 Add aggregate function combinators: -OrNull & -OrDefault (#7331) 2019-10-18 12:25:39 +03:00
alesapin
71cbe878fc
Merge pull request #7374 from millb/fixed_getMultipleValuesFromConfig
Fixed function getMultipleValuesFromConfig
2019-10-18 11:55:41 +03:00
hcz
b87fe27cd6 Add tests 2019-10-18 16:45:56 +08:00
hcz
124ea9699a Add arrayFill 2019-10-18 16:45:39 +08:00
hcz
decd555317 Cleanup, keep function names consistent 2019-10-18 15:30:41 +08:00
alexey-milovidov
3803d94db6
Merge pull request #7376 from amosbird/helpakuzm
Fix ubsan introduced by Field refactoring.
2019-10-18 06:29:27 +03:00
philip.han
1d423fad73 Blocked "nested-array-type" for the bloom_filter 2019-10-18 11:55:01 +09:00
chertus
0f6176cc2d throw on ambiguous qualified column 2019-10-18 00:08:28 +03:00
Mikhail Korotov
a1f417a537
Update gtest_getMultipleValuesFromConfig.cpp 2019-10-18 00:07:27 +03:00
Amos Bird
16d1b4472e Fix ubsan introduced by Field refactoring. 2019-10-18 04:30:33 +08:00
alesapin
b222ec1209 Fix segmentation fault 2019-10-17 20:53:08 +03:00
alesapin
c29b39002d Fix race condition, add test 2019-10-17 20:36:53 +03:00
alesapin
05392fd882 Fix deadlock, add test and refactoring 2019-10-17 20:18:54 +03:00
millb
26d9ee3ae5 Fixed bug with function getMultipleValuesFromConfig and added test which confirms this. 2019-10-17 19:52:47 +03:00
vzakaznikov
66675edf2d Fixing data race with no_users_thread. (#7353) 2019-10-17 17:47:36 +03:00
vzakaznikov
ee1a2ce027 Fixing AddressSanitizer error in the LIVE VIEW getHeader() method. (#7271) 2019-10-17 17:43:11 +03:00
tavplubix
0046b9f137 Wait for jobs to finish on exception (fixes rare segfaults) (#7350) 2019-10-17 17:41:27 +03:00
Alexander Kuzmenkov
b62c9e729d
Merge pull request #7215 from ClickHouse/formats_improvements
Miscellaneous formats improvements
2019-10-17 17:37:38 +03:00
Alexander Kuzmenkov
3e662da6f4
Merge pull request #7351 from Enmk/http_keep_alive_timeout
Fixed issue of using HTTP timeout as TCP timeout value.
2019-10-17 16:14:29 +03:00
CurtizJ
546414c015 fix optimize_read_in_order with in subquery 2019-10-17 16:11:27 +03:00
akonyaev
22429a699e unexpected behaviour for avg over empty decimal column without group by 2019-10-17 16:08:04 +03:00
alesapin
6dfe5c7142 Better introspection 2019-10-17 16:05:12 +03:00
Ivan
e595df05d9
Fix CREATE TABLE AS from table with virtual columns (#7183)
* Disable undefined instrumentation for rdkafka
2019-10-17 14:12:35 +03:00
philip.han
8aac4d04de Fixed weird type-casting for IN-operator in bloom_filter 2019-10-17 19:53:41 +09:00
Alexander Kuzmenkov
e9d7da3dd4
Merge pull request #7359 from amosbird/joingetconst
Constness-aware JoinGet.
2019-10-17 13:35:37 +03:00
philip.han
08a348fbd1 Made IN operator support Array(LowCardinality(Nullable(String))) 2019-10-17 19:08:36 +09:00
alesapin
3987a45ea2 Fix build and style 2019-10-17 12:05:48 +03:00
memo
ef09cedbb8 fix test bug 2019-10-17 11:38:49 +08:00
Amos Bird
89247deb64 Constness-aware JoinGet. 2019-10-17 08:52:28 +08:00
tavplubix
c4b46e113e
Merge branch 'master' into formats_improvements 2019-10-16 23:00:17 +03:00
Alexander Tokmakov
e9e8d055af null_as_default for Values 2019-10-16 22:55:24 +03:00
Alexander Tokmakov
102cbfd25a fix old bug with default values 2019-10-16 22:27:33 +03:00
Vladimir Chebotarev
512e97ddb3
Improved readability a little bit (MergeTreeData::getActiveContainingPart). 2019-10-16 22:01:50 +03:00
alesapin
842a31be8b More tests 2019-10-16 20:59:10 +03:00
alesapin
a19a699bef Fix confused variables 2019-10-16 20:52:56 +03:00
chertus
483108f46f column to table matching refactoring 2019-10-16 20:33:53 +03:00
alesapin
51de7a1cd1 Better tests 2019-10-16 20:12:53 +03:00
alesapin
fa557ab80d Better tests 2019-10-16 20:11:19 +03:00
alesapin
01e23f0a22 Better load of dictionaries 2019-10-16 20:06:52 +03:00
Alexander Tokmakov
5f6703130e fixes 2019-10-16 18:28:48 +03:00
millb
19a54a59bb Created: function hex for Decimal32, Decimal64, Decimal128 2019-10-16 18:28:10 +03:00
alesapin
b4e0ded048 Almost working 2019-10-16 17:59:52 +03:00
chertus
e6e88241fc SyntaxAnalyzer refactoring: better getTablesWithColumns() 2019-10-16 17:47:58 +03:00
Alexander Tokmakov
aa9d29d6ae Merge branch 'master' into formats_improvements 2019-10-16 17:15:13 +03:00
Alexander Kuzmenkov
91b995212f
Merge pull request #7343 from amosbird/bf10
Build fix
2019-10-16 16:59:46 +03:00
Vasily Nemkov
94095fcb92 Fixed issue of using HTTP timeout as TCP timeout value. 2019-10-16 16:04:26 +03:00
Alexander Kuzmenkov
16f252dce9
Merge pull request #7332 from Enmk/More_Date_and_DateTime_performance_tests
More performance test for Date and DateTime
2019-10-16 16:03:54 +03:00
Artem Zuikov
b70ca30447
Merge pull request #7335 from 4ertus2/ast
Remove asterisk_left_columns_only setting
2019-10-16 13:57:17 +03:00
Artem Zuikov
3ceeb95145
Merge pull request #7282 from 4ertus2/asof
ASOF JOIN inequalities
2019-10-16 13:46:52 +03:00
philip.han
a2bf848e12 Made bloom_filter type of index supporting LowCardinality and Nullable 2019-10-16 15:22:56 +09:00
memo
947c345eda style: Normalize the format 2019-10-16 14:05:43 +08:00
Amos Bird
dd128e9e1d Build fix 2019-10-16 10:49:29 +08:00
alesapin
e690a3ca32 Half working code 2019-10-15 21:04:17 +03:00
chertus
ccc8c1ad2a restore logic for array join (it's probably a hidden error) 2019-10-15 20:39:23 +03:00
Artem Zuikov
cf99f88bc4 PartialMergeJoin flush data on disk (#7186) 2019-10-15 19:31:49 +03:00
chertus
c727777a9c resolve some for review sentences 2019-10-15 18:49:00 +03:00
chertus
9667e54201 remove asterisk_left_columns_only setting 2019-10-15 17:42:57 +03:00
alesapin
3e068b81de Add loading of external dictionaries 2019-10-15 17:09:57 +03:00
Vasily Nemkov
48b3c21aaa More performance test for Date and DateTime
Added cases for:
 * binary operations: -,+,>,>=,<,<=,==,!=
 * previously-missing functions: timeSlot, toRelativeQuarterNum, toStartOfTenMinutes, toUnixTimestamp, addYears (and alike).
2019-10-15 15:20:54 +03:00
alesapin
f850408ae4 Convert AST to Abstract configuration 2019-10-15 15:16:19 +03:00
memo
8b1b7f2a5f add arrayCompact test 2019-10-15 16:09:10 +08:00
memo
d1fb238820 implement arrayCompact 2019-10-15 15:50:10 +08:00
alexey-milovidov
6a44336b86
Merge pull request #7304 from sundy-li/ttl_check
Check TTL in StorageFactory
2019-10-14 20:11:37 +03:00
Alexander Kuzmenkov
831fb2cbfd
Merge pull request #7283 from ClickHouse/aku/in-unconvertible
Ignore non-convertible values at any depth on the right side of the IN operator
2019-10-14 18:32:22 +03:00
Nikolai Kochetov
5364f76625 Fix build. 2019-10-14 16:50:16 +03:00
Alexander Kuzmenkov
160d8a6416 Ignore non-convertible values at any depth on the right side of IN
operator.

The values that are not convertible to the left argument type can't
match anyway, so it is safe to discard them.
2019-10-14 14:25:03 +03:00
alesapin
1ce0eb6e63 Appropriate error codes numbers 2019-10-14 13:04:10 +03:00
alesapin
ecde224692 More tests 2019-10-14 12:52:43 +03:00
alexey-milovidov
f0409348a1
Merge pull request #7294 from hczhcz/patch-1013
Add arraySplit
2019-10-14 12:32:09 +03:00
alesapin
67ea66604f Fix segmentation fault in database factory 2019-10-14 12:21:29 +03:00
sundy-li
b2109e4ece Check TTL in StorageFactory 2019-10-14 17:03:39 +08:00
Danila Kutenin
19ecc3e6cf
Merge pull request #7299 from ClickHouse/multi_match_all_indices
Add multi{Fuzzy}MatchAllIndices functions
2019-10-14 10:58:27 +02:00
Danila Kutenin
60d273a65d Get better message for non hyperscan supported platforms 2019-10-14 10:58:05 +02:00
alesapin
155731a676 Merge branch 'master' into dictionaries_ddl_interpreter 2019-10-14 11:49:18 +03:00
alexey-milovidov
323a756115
Merge pull request #7298 from Vdimir/feature/count-arity-validation-7095
Add missing arity validation for count/counIf
2019-10-14 08:52:58 +03:00
Danila Kutenin
7527896f1a Unused variables 2019-10-13 21:40:07 +02:00
VDimir
7adad4251f Remove AggregateFunctionCountNotNullVariadic 2019-10-13 18:42:39 +00:00
VDimir
99f531c58f Fix spelling require -> requires 2019-10-13 18:37:01 +00:00
Danila Kutenin
57f20ba17e All multi{Fuzzy}MatchAllIndices functions 2019-10-13 15:22:09 +02:00
hcz
c8c40e159d Add arraySplit 2019-10-13 16:06:57 +08:00
Nikolai Kochetov
7c2575542b Fix build. 2019-10-12 21:52:20 +03:00
Nikolai Kochetov
22dfc611c9 Remove comments from test. 2019-10-12 21:49:25 +03:00
alexey-milovidov
4dffc67434
Merge pull request #7291 from sundy-li/FQDN
Function FQDN, fullHostName
2019-10-12 20:02:22 +03:00
alexey-milovidov
62c7c50aba
Update FunctionsJSON.h 2019-10-12 20:00:32 +03:00
Nikolai Kochetov
757488369f Merge branch 'master' into processors-3 2019-10-12 19:24:02 +03:00
Nikolai Kochetov
51bce40d5e
Merge pull request #7284 from ClickHouse/fix-7216
Fix for #7216
2019-10-12 19:20:33 +03:00
VDimir
0230aca903 Remove tests with count accepting 2 args 2019-10-12 15:44:14 +00:00
VDimir
853322503f Allow count function arity at most one 2019-10-12 15:15:16 +00:00
Nikolai Kochetov
6f758babf6
Merge pull request #7289 from infinivision/fix_pull_7109
Fixed #7109 groupBitmapOr(31) segfault
2019-10-12 16:42:11 +03:00
Alexander Kuzmenkov
31bd359100
Merge pull request #7231 from ClickHouse/aku/podarray-includes
Include PODArray.h into fewer files.
2019-10-12 15:08:41 +03:00
VDimir
1174fc346b Add isValidJSON function 2019-10-12 11:42:43 +00:00
Nikolai Kochetov
25510e3d38 Try to fix perftests. 2019-10-12 13:06:07 +03:00
sundy-li
4e48992397 fullHostName by function getFQDNOrHostName 2019-10-12 17:21:30 +08:00
sundy-li
59d2989826 Function FQDN,fullHostName 2019-10-12 15:17:30 +08:00
Zhichang Yu
679db35ed3 Fixed #7109 groupBitmapOr(31) segfault 2019-10-12 10:36:52 +08:00
alesapin
aeb7504570
Merge pull request #7277 from ClickHouse/client-params-for-tests
Client parameters for clickhouse-test
2019-10-11 22:33:32 +03:00
Nikolai Kochetov
8186644562 Update test. 2019-10-11 21:04:58 +03:00
Nikolai Kochetov
4967bcdbd0 Fix test. 2019-10-11 21:02:34 +03:00
chertus
91c7ae83a3 asof join inequalities 2019-10-11 20:56:26 +03:00
Nikolai Kochetov
217eab0cfa Fix test. 2019-10-11 20:55:33 +03:00
Nikolai Kochetov
2684bd0d5e Fixes for 7216 2019-10-11 20:27:54 +03:00
Nikolai Kochetov
e5c8a62142 Fix tests. 2019-10-11 20:24:18 +03:00
Nikolai Kochetov
bf794a8260 Fix tests. 2019-10-11 18:59:27 +03:00
alesapin
653aa7c005 Fix unit tests and segfault 2019-10-11 18:41:52 +03:00
alesapin
967fe64793 Add simpliest tests 2019-10-11 18:22:30 +03:00
Vitaly Baranov
8c24d5e66a
Merge pull request #7235 from vitlibar/RBAC-1
RBAC-1
2019-10-11 17:16:32 +03:00
alesapin
dca0798d4d Compilable code 2019-10-11 16:51:31 +03:00
Nikolai Kochetov
10366f79ae Update url params in shell_config and tests.] 2019-10-11 16:34:26 +03:00
alesapin
ae42dc0d4c Attach detach and introspection queries for dictionaries 2019-10-11 16:21:52 +03:00
Nikolai Kochetov
2ecf7abf6c Update url params in shell_config. 2019-10-11 15:08:11 +03:00
Alexander Kuzmenkov
57b5592236 Work around garbage in roaring.h to fix Mac OS build. 2019-10-11 14:28:16 +03:00
Alexander Kuzmenkov
8a1d57bddb Include PODArray.h into fewer files. 2019-10-11 14:28:16 +03:00
Nikolai Kochetov
48bfcab428 Add ability to specify arguments to client in functional tests. 2019-10-11 13:30:32 +03:00
Vitaly Baranov
9e3815ccef Fix ubsan issue. 2019-10-11 12:53:10 +03:00
alesapin
3dfe961291 Merge branch 'master' into dictionaries_ddl_interpreter 2019-10-11 12:14:07 +03:00
alesapin
7159cde160 Remove accident change 2019-10-11 12:07:44 +03:00
alesapin
77c6d4d48f Changes 2019-10-11 12:05:12 +03:00
Nikolai Kochetov
89dfe7882d Enable processors by default. 2019-10-11 11:55:00 +03:00
Vitaly Baranov
060257c8c5 Remove Authentication::setType() function and fix comments. 2019-10-11 00:48:36 +03:00
Nikolai Kochetov
e48755d045 Merge branch 'master' into processors-and-storages 2019-10-11 00:46:37 +03:00
Nikolai Kochetov
9a89ee8eab
Merge pull request #7264 from ClickHouse/disable-memory-tracker-for-stack-trace
Disable memory tracker for exception stack.
2019-10-11 00:45:36 +03:00
Vitaly Baranov
18ccb4d64d Move backQuote() and quoteString() to a separate file, use StringRefs. 2019-10-11 00:18:52 +03:00
Vitaly Baranov
9f6d9d6130 Move the code which checks client host to a separate class. 2019-10-11 00:18:52 +03:00
Vitaly Baranov
12d1d87d64 Move authentication code to a separate class. 2019-10-11 00:18:52 +03:00
Nikolai Kochetov
a15d8f36d5
Merge pull request #7270 from azat/uniqCombined-memory-usage-tests-fixes
uniqCombined memory usage tests fixes
2019-10-10 23:53:55 +03:00
alesapin
2a5713e6e4 Compilable code 2019-10-10 23:47:47 +03:00
Nikolai Kochetov
0ce86e1f8f Disable memory tracker for exception stack. 2019-10-10 21:55:16 +03:00
Azat Khuzhin
e25bdc8d25 tests/00212_shard_aggregate_function_uniq: adjust values for uniqCombined(12)(String)
In e373862c83 the maxium size for HashTable in
CombinedCardinalityEstimator had been reduced for power of 2 for String
(since otherwise the size of the hashtable becames bigger then the
sizeof HLL).

Refs: https://github.com/ClickHouse/ClickHouse/pull/7236#issuecomment-540496270
Fixes: e373862c83 ("Do not use more then 98K of memory for uniqCombined*")
2019-10-10 21:47:51 +03:00
Azat Khuzhin
eb7d4797e3 tests/00212_shard_aggregate_function_uniq: break into sections 2019-10-10 21:47:51 +03:00
Azat Khuzhin
495d1de46f clickhouse-test: introduce -U/--unified option (pass to diff(1)) 2019-10-10 21:47:51 +03:00
alexey-milovidov
9c1c596146
Merge pull request #7252 from ClickHouse/fix-bad-code-in-transform-query-for-external-database
Fix bad code in transforming query for external database.
2019-10-10 21:10:36 +03:00
Nikolai Kochetov
f011c1020e Disable memory tracker for exception stack. 2019-10-10 20:37:34 +03:00
alesapin
67fc3347c2 Preparing databases for dictionaries 2019-10-10 20:33:01 +03:00
Nikolai Kochetov
742b948156 Disable memory tracker for exception stack. 2019-10-10 19:30:33 +03:00
Alexander Kazakov
03c7b7ff8d
Prevent from using non-deterministic functions in mutations of replicated tables (#7247)
* Added isDeterministic() to IFunctionBuilder i-face
* A test for non-deterministic mutations
* In MutationsInterpreter::validate() ensure deterministic functions
* Adjusted nondeterministic mutation tests
* Moved around some code in MutationsInterpreter::validate()
* Dropped unnecessary check in findFirstNonDeterministicFuncName()
* Corrections to IFunction{Base,Builder} interface
2019-10-10 17:38:08 +03:00
Nikolai Kochetov
ef14df4632 Added more comments. 2019-10-10 17:16:15 +03:00
Nikolai Kochetov
378052743d Fix MergeTreeSequentialBlockInputStream. 2019-10-10 14:24:29 +03:00
Nikolai Kochetov
4728bdfccd Fix MergeTreeSequentialBlockInputStream. 2019-10-10 14:20:25 +03:00
alesapin
51c8188903
Merge pull request #7253 from ClickHouse/dictionaries_ddl_parser
Refactor parser create query
2019-10-10 11:34:21 +03:00
alesapin
777ba2e47e Remove some code 2019-10-10 00:31:29 +03:00
Alexey Milovidov
3fbac60328 Added a test 2019-10-09 23:16:17 +03:00
Alexey Milovidov
e65b57369e transformQueryForExternalDatabase: fixed constant folding for Date and DateTime 2019-10-09 23:13:34 +03:00
alesapin
fae3f85a0f Refactor parser create query 2019-10-09 23:09:10 +03:00
Alexey Milovidov
b302fec362 Fixed bad code in transformQueryForExternalDatabase 2019-10-09 22:58:50 +03:00
alexey-milovidov
689411abe0
Merge pull request #7222 from azat/uniqCombined64
[RFC] Introduce uniqCombined64() to get sane results for cardinality > UINT_MAX
2019-10-09 20:29:56 +03:00
alexey-milovidov
6cd3e9a458
Update AggregateFunctionUniqCombined.h 2019-10-09 20:26:01 +03:00
alexey-milovidov
81a9c81ba7
Merge pull request #7236 from azat/uniqCombined-memory-usage
Do not use more then 98K of memory for uniqCombined*
2019-10-09 20:19:30 +03:00
alexey-milovidov
e3861e0e88
Merge pull request #7242 from azat/sparse_hashed-name
Return SparseHashed name (system.dictionaries:type) for the sparse_hashed layout
2019-10-09 20:12:24 +03:00
Nikolai Kochetov
dea89cfc11 Disable processors by default. 2019-10-09 19:42:13 +03:00
alexey-milovidov
01e08a23c2
Merge pull request #7240 from ClickHouse/function-get-macro
Added function `getMacro`
2019-10-09 15:28:54 +03:00
Alexander Kuzmenkov
1965c612ab Fix sorting in clickhouse-test. 2019-10-09 14:56:51 +03:00
Nikolai Kochetov
9c5ae5f536 Merge branch 'master' into processors-and-storages 2019-10-09 14:12:47 +03:00
Alexander Kuzmenkov
89ebd4885f Fix test filtering in clickhouse-test. 2019-10-09 13:51:59 +03:00
alesapin
ef0b2f5936
Merge pull request #7209 from ClickHouse/dictionaries_ddl_parser
Dictionaries ddl parser
2019-10-09 12:51:08 +03:00
Nikolai Kochetov
eb2677c94e Try fix progressbar. 2019-10-09 12:44:24 +03:00
Nikolai Kochetov
ea27918de8 Try fix progressbar. 2019-10-09 12:40:30 +03:00
Nikolai Kochetov
c7bb83262e Fix progress callback for processors pipeline. 2019-10-09 12:33:16 +03:00
Azat Khuzhin
0ff823b574 Return SparseHashed name (system.dictionaries:type) for the sparse_hashed layout
Due to tons of rebasing this bit had been forgotten.

Refs: 420089c301 ("Add new dictionary layout (sparse_hashed) that is more memory efficient")
2019-10-09 11:11:41 +03:00
alexey-milovidov
9b2e025918
Merge pull request #7234 from ClickHouse/aku/null-field-serialization
Serialize Null Fields correctly in DataTypeNullable.
2019-10-09 04:30:37 +03:00
Alexey Milovidov
6d2a79e832 Added a test 2019-10-09 04:18:12 +03:00
Alexey Milovidov
552e4b4be2 Added example config with macros for tests 2019-10-09 04:16:34 +03:00
Alexey Milovidov
a19f6513ce Added example config with macros 2019-10-09 04:15:23 +03:00
Alexey Milovidov
9f8d562543 Add function "getMacro" #7239 2019-10-09 04:14:57 +03:00
Azat Khuzhin
e373862c83 Do not use more then 98K of memory for uniqCombined*
uniqCombined() uses hashtable for medium cardinality, and since
HashTable resize by the power of 2 (well actually HashTableGrower grows
double by the power of 2, hence HashTableGrower::increaseSize() should
be overwritten to change this), with 1<<13 (default for uniqCombined)
and UInt64 HashValueType, the HashTable will takes:

  getBufferSizeInBytes() == 131072

While it should be not greater then sizeof(HLL) ~= 98K, so reduce the
maximum cardinality for hashtable to 1<<12 with UInt64 HashValueType and
to 1<13 with UInt32, overwrite HashTableGrower::increaseSize() and cover
this using max_memory_usage.

Refs: https://github.com/ClickHouse/ClickHouse/pull/7221#issuecomment-539672742

v2: cover uniqCombined() with non-default K
2019-10-09 02:39:23 +03:00
alexey-milovidov
4c1f0177b6
Merge pull request #7109 from infinivision/aggBitmapAnd
added groupBitmapAnd, groupBitmapOr, groupBitmapXor
2019-10-08 22:51:46 +03:00
alexey-milovidov
5c2d478543
Merge pull request #7212 from ClickHouse/aku/field-includes
Include Field.h and FieldVisitor.h into fewer files.
2019-10-08 22:40:30 +03:00
alesapin
5296be18f3 Fix desc table query 2019-10-08 22:39:20 +03:00
alexey-milovidov
b9aa5d812d
Merge pull request #7171 from nikvas0/nikvas0/lazy_db
Lazy Database
2019-10-08 22:15:55 +03:00
Azat Khuzhin
f46c5a47c0 Introduce uniqCombined64() to get sane results for cardinality > UINT_MAX
By default uniqCombined() uses 32-bit hash for all types except String,
so this means that you cannot use uniqCombined() with i.e UInt64 and
cardinality > UINT_MAX, although you can use uniqCombined(toString())
and this will lead to 64-bit hash, but will not have good performance.

So uniqCombined64() had been introduced to fix this.

Requires: #7213
2019-10-08 21:59:35 +03:00
alexey-milovidov
ddc2299901
Update 01016_null_part_minmax.sql 2019-10-08 21:52:48 +03:00
alexey-milovidov
d8b3db65f7
Merge pull request #7213 from azat/fix-uniqCombined-approximation
Fix uniqCombined() result for >UINT_MAX values (return UInt64 to avoid overflow)
2019-10-08 21:45:23 +03:00
alexey-milovidov
e619304b2c
Merge pull request #7216 from ClickHouse/nicelulu-issue-6615
Merging "Optimize empty IN subquery and empty INNER/RIGHT JOIN"
2019-10-08 21:36:57 +03:00
Alexander Kuzmenkov
a5b1496fe9 Serialize Null Fields correctly in DataTypeNullable. 2019-10-08 21:21:24 +03:00
alesapin
5ea1a12c05 Refactoring and comments 2019-10-08 16:26:15 +03:00
Alexander Kuzmenkov
2b30f2696c Include Field.h in less files. 2019-10-08 16:23:24 +03:00
alesapin
7b545f9b18 Fix style 2019-10-08 15:35:17 +03:00
alesapin
cd05564b17 Add show create dictionary 2019-10-08 15:34:04 +03:00
Alexander Kuzmenkov
46f5115601 Accept many test name regexes in clickhouse-test.
Sometimes it is more convenient to supply space-separated test names
without having to concatenate them into one regex with pipes.
2019-10-08 14:32:03 +03:00
alesapin
0883b3f8a9 Parser for drop dictionary query 2019-10-08 14:10:29 +03:00
alesapin
db20681207 Better declaration and lifetime parser 2019-10-08 13:50:57 +03:00
alesapin
5f81f47637 Add recursive parsing of pairs 2019-10-08 12:47:17 +03:00
Vasilyev Nikita
21b2b20729 Merge branch 'nikvas0/lazy_db' of https://github.com/nikvas0/ClickHouse into nikvas0/lazy_db 2019-10-08 11:15:12 +03:00
Vasilyev Nikita
030aa1cf10 fix 2019-10-08 11:10:55 +03:00