Commit Graph

132755 Commits

Author SHA1 Message Date
Nikolai Kochetov
53d24af9ec Fix possilbe race in ManyAggregatedData dtor. 2024-01-09 11:26:54 +00:00
Kruglov Pavel
22a0e085b7
Merge pull request #58597 from rschu1ze/makedatetime64-nonconst-fraction
`makeDateTime64()`: Allow non-const fraction argument
2024-01-09 12:17:12 +01:00
Jayme Bird
32337556a3 fix test 2024-01-09 11:13:32 +00:00
vdimir
21e4e0537d
Merge pull request #58607 from azat/stacktrace-fix-inline-frames
Fix possible NULL dereference during symbolizing inline frames
2024-01-09 12:10:35 +01:00
vdimir
23e3ad1179
Add join keys convertion for nested lowcardinality 2024-01-09 10:59:57 +00:00
Igor Nikonov
f566423e19 Merge remote-tracking branch 'origin/master' into pr-custom-key-failover 2024-01-09 10:38:43 +00:00
Robert Schulze
bca0f144e2
Fix style 2024-01-09 10:36:18 +00:00
vdimir
b4bfd01322
Merge pull request #58246 from ClickHouse/vdimir/util_format_values
clickhouse-format improvements: support VALUES, comments, max_line_length
2024-01-09 11:24:42 +01:00
Robert Schulze
64ab30f446
Merge pull request #57078 from ClibMouse/seriesDecompose
Seasonal decompose of time series into seasonal, trend and residue components
2024-01-09 11:18:13 +01:00
Raúl Marín
ed8eb8f497 Add sorting to 02366_kql_summarize.sql 2024-01-09 11:04:10 +01:00
Raúl Marín
803d8d6320
Merge pull request #58594 from Algunenano/missing_includes
Add some missing LLVM includes
2024-01-09 11:01:44 +01:00
Duc Canh Le
0e10356b95 randomize filename to avoid flaky test
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2024-01-09 09:46:31 +00:00
taiyang-li
e5b4bc8f45 Merge branch 'master' into ch_opt_array_element 2024-01-09 17:17:38 +08:00
Duc Canh Le
37a7ce2950
Apply suggestions from code review
Co-authored-by: pufit <pufit@yandex.ru>
2024-01-09 17:17:30 +08:00
Bharat Nallan
ee37f551a2
independent registration of interpreters (#58443)
* make interpreter factory an instance

* add registerInterpreter

* register interpreters individually

* try wire everything up

* fix style

* fix test
2024-01-08 22:33:48 -08:00
Yakov Olkhovskiy
cfa41e7dc6
Merge pull request #58038 from ClickHouse/revert-58022-revert-57555-ft-dropped_tables_parts
Add system.dropped_tables_parts table - second attempt
2024-01-09 00:47:07 -05:00
李扬
f6691ec334
Update tests/performance/array_element.xml
Co-authored-by: Kruglov Pavel <48961922+Avogar@users.noreply.github.com>
2024-01-09 10:15:37 +08:00
Alexey Milovidov
5210bbc587
Update ConstantExpressionTemplate.cpp 2024-01-09 05:13:52 +03:00
Alexey Milovidov
d3e73ff6e6
Merge pull request #58584 from ClickHouse/enable-all-access-control-improvements
Enable all access control improvements by default
2024-01-08 23:05:47 +01:00
Robert Schulze
fabc06995e
Improve isolation of query results in query cache
Fixes #58054
2024-01-08 20:52:30 +00:00
Igor Nikonov
7fd851b4e9 Merge remote-tracking branch 'origin/master' into pr-custom-key-failover 2024-01-08 20:43:20 +00:00
Alexander Tokmakov
b05211cc34
Update 02947_dropped_tables_parts.sql 2024-01-08 20:16:21 +01:00
Bhavna Jindal
b2434d0c10 minor refactoring and cosmetic changes 2024-01-08 10:49:09 -08:00
Yarik Briukhovetskyi
f1f729d5b3
style check 2024-01-08 19:47:02 +01:00
Joanna Hulboj
f67edfb397 Consume leading zeroes - use find_first_not_symbols 2024-01-08 18:42:33 +00:00
yariks5s
7417238579 init 2024-01-08 18:21:03 +00:00
Azat Khuzhin
9b6c8cd44f Fix possible NULL dereference during symbolizing inline frames
It is possible sometimes:

<details>

```
2024.01.02 15:18:49.542342 [ 102142 ] {} <Fatal> BaseDaemon: Address: NULL pointer. Access: read. Address not mapped to object.
2024.01.02 15:18:49.542356 [ 102142 ] {} <Fatal> BaseDaemon: Stack trace: 0x0000000012817007 0x00000000120b3e88 0x000000001209c3e8 0x000000001209b7f3 0x000000001213d936 0x0000000011f71042 0x0000000011f6dd22 0x0000
000012496116 0x000000001249181c 0x00000000133197ec 0x000000001332bc79 0x0000000015d0eb14 0x0000000015d0fd11 0x0000000015e1b367 0x0000000015e195fc 0x00007f011cb31fa3 0x00007f011ca624cf
2024.01.02 15:18:50.052773 [ 102142 ] {} <Fatal> BaseDaemon: 2.1. inlined from ./build_docker/./contrib/llvm-project/libcxx/include/__memory/shared_ptr.h:603: shared_ptr<DB::Context, void>
2024.01.02 15:18:50.052829 [ 102142 ] {} <Fatal> BaseDaemon: 2.2. inlined from ./build_docker/./src/Planner/PlannerContext.h:56: DB::PlannerContext::getQueryContext() const
2024.01.02 15:18:50.052853 [ 102142 ] {} <Fatal> BaseDaemon: 2.3. inlined from ./build_docker/./src/Storages/StorageDistributed.cpp:666: DB::(anonymous namespace)::buildQueryTreeDistributed(DB::SelectQueryInfo&, s
td::shared_ptr<DB::StorageSnapshot> const&, DB::StorageID const&, std::shared_ptr<DB::IAST> const&)
2024.01.02 15:18:50.052872 [ 102142 ] {} <Fatal> BaseDaemon: 2. ./build_docker/./src/Storages/StorageDistributed.cpp:743: DB::StorageDistributed::read(DB::QueryPlan&, std::vector<String, std::allocator<String>> co
nst&, std::shared_ptr<DB::StorageSnapshot> const&, DB::SelectQueryInfo&, std::shared_ptr<DB::Context const>, DB::QueryProcessingStage::Enum, unsigned long, unsigned long) @ 0x0000000012817007 in /usr/lib/debug/usr
/bin/clickhouse.debug
2024.01.02 15:18:50.211769 [ 102142 ] {} <Fatal> BaseDaemon: 3.1. inlined from ./build_docker/./contrib/llvm-project/libcxx/include/__memory/shared_ptr.h:815: std::shared_ptr<DB::Context>::operator->[abi:v15000]()
 const
2024.01.02 15:18:50.211815 [ 102142 ] {} <Fatal> BaseDaemon: 3. ./build_docker/./src/Interpreters/InterpreterSelectQuery.cpp:2488: DB::InterpreterSelectQuery::executeFetchColumns(DB::QueryProcessingStage::Enum, DB
::QueryPlan&) @ 0x00000000120b3e88 in /usr/lib/debug/usr/bin/clickhouse.debug
2024.01.02 15:18:50.295382 [ 102142 ] {} <Fatal> BaseDaemon: 4. ./build_docker/./src/Interpreters/InterpreterSelectQuery.cpp:1444: DB::InterpreterSelectQuery::executeImpl(DB::QueryPlan&, std::optional<DB::Pipe>) @
 0x000000001209c3e8 in /usr/lib/debug/usr/bin/clickhouse.debug
2024.01.02 15:18:50.375779 [ 102142 ] {} <Fatal> BaseDaemon: 5.1. inlined from ./build_docker/./contrib/llvm-project/libcxx/include/optional:260: ~__optional_destruct_base
2024.01.02 15:18:50.375820 [ 102142 ] {} <Fatal> BaseDaemon: 5. ./build_docker/./src/Interpreters/InterpreterSelectQuery.cpp:868: DB::InterpreterSelectQuery::buildQueryPlan(DB::QueryPlan&) @ 0x000000001209b7f3 in
/usr/lib/debug/usr/bin/clickhouse.debug
2024.01.02 15:18:50.403975 [ 102142 ] {} <Fatal> BaseDaemon: 6. ./build_docker/./src/Interpreters/InterpreterSelectWithUnionQuery.cpp:0: DB::InterpreterSelectWithUnionQuery::buildQueryPlan(DB::QueryPlan&) @ 0x0000
00001213d936 in /usr/lib/debug/usr/bin/clickhouse.debug
2024.01.02 15:18:50.432051 [ 102142 ] {} <Fatal> BaseDaemon: 7.1. inlined from ./build_docker/./contrib/llvm-project/libcxx/include/__memory/shared_ptr.h:603: shared_ptr<DB::Context, void>
2024.01.02 15:18:50.432472 [ 102143 ] {} <Fatal> BaseDaemon: ########## Short fault info ############
2024.01.02 15:18:50.432500 [ 102143 ] {} <Fatal> BaseDaemon: (version 23.9.2.56 (official build), build id: 76109A79FA62B9BC630A6C39438DEA7D28147B68, git hash: a1bf3f1de5) (from threa
d 102142) Received signal 11
2024.01.02 15:18:50.432516 [ 102143 ] {} <Fatal> BaseDaemon: Signal description: Segmentation fault
2024.01.02 15:18:50.432526 [ 102143 ] {} <Fatal> BaseDaemon: Address: NULL pointer. Access: read. Address not mapped to object.
2024.01.02 15:18:50.432539 [ 102143 ] {} <Fatal> BaseDaemon: Stack trace: 0x00007f011cac5181 0x0000000015ccd934 0x000000000c76771e 0x000000000ca0fe32 0x000000000ca0ccf5 0x00007f011cb31fa3 0x00007f011ca624cf
2024.01.02 15:18:50.432547 [ 102143 ] {} <Fatal> BaseDaemon: ########################################
2024.01.02 15:18:50.432565 [ 102143 ] {} <Fatal> BaseDaemon: (version 23.9.2.56 (official build), build id: 76109A79FA62B9BC630A6C39438DEA7D28147B68, git hash: a1bf3f1de5) (from threa
d 102142) (no query) Received signal Segmentation fault (11)
```

```
2024.01.02 15:18:50.432588 [ 102143 ] {} <Fatal> BaseDaemon: Address: NULL pointer. Access: read. Address not mapped to object.
2024.01.02 15:18:50.432601 [ 102143 ] {} <Fatal> BaseDaemon: Stack trace: 0x00007f011cac5181 0x0000000015ccd934 0x000000000c76771e 0x000000000ca0fe32 0x000000000ca0ccf5 0x00007f011cb31fa3 0x00007f011ca624cf
2024.01.02 15:18:50.432638 [ 102143 ] {} <Fatal> BaseDaemon: 2. ? @ 0x000000000015c181 in /usr/lib/x86_64-linux-gnu/libc-2.28.so
2024.01.02 15:18:50.446953 [ 102143 ] {} <Fatal> BaseDaemon: 3.1. inlined from ./build_docker/./contrib/llvm-project/libcxx/include/string:1955: String::__init(char const*, unsigned long)
2024.01.02 15:18:50.446981 [ 102143 ] {} <Fatal> BaseDaemon: 3.2. inlined from ./build_docker/./contrib/llvm-project/libcxx/include/string:843: basic_string<std::nullptr_t>
2024.01.02 15:18:50.446998 [ 102143 ] {} <Fatal> BaseDaemon: 3. ./build_docker/./base/base/demangle.cpp:25: demangle(char const*, int&) @ 0x0000000015ccd934 in /usr/lib/debug/usr/bin/clickhouse.debug
2024.01.02 15:18:50.458431 [ 102143 ] {} <Fatal> BaseDaemon: 4. ./build_docker/./src/Common/StackTrace.cpp:389: void toStringEveryLineImpl<std::function<void (std::basic_string_view<char, std::char_traits<char>>)>>(bool, StackTraceRefTriple const&, std::function<void (std::basic_string_view<char, std::char_traits<char>>)>&&) (.llvm.10713299015003964940) @ 0x000000000c76771e in /usr/lib/debug/usr/bin/clickhouse.debug
2024.01.02 15:18:50.474955 [ 102143 ] {} <Fatal> BaseDaemon: 5.1. inlined from ./build_docker/./contrib/llvm-project/libcxx/include/__functional/function.h:818: ~__policy_func
2024.01.02 15:18:50.474997 [ 102143 ] {} <Fatal> BaseDaemon: 5.2. inlined from ./build_docker/./contrib/llvm-project/libcxx/include/__functional/function.h:1174: ~function
2024.01.02 15:18:50.475010 [ 102143 ] {} <Fatal> BaseDaemon: 5. ./build_docker/./src/Daemon/BaseDaemon.cpp:415: SignalListener::onFault(int, siginfo_t const&, ucontext_t*, StackTrace const&, std::vector<std::array<void*, 45ul>, std::allocator<std::array<void*, 45ul>>> const&, unsigned int, DB::ThreadStatus*) const @ 0x000000000ca0fe32 in /usr/lib/debug/usr/bin/clickhouse.debug
2024.01.02 15:18:50.512270 [ 102143 ] {} <Fatal> BaseDaemon: 6.1. inlined from ./build_docker/./src/Daemon/BaseDaemon.cpp:284: operator()
2024.01.02 15:18:50.512591 [ 102143 ] {} <Fatal> BaseDaemon: 6.2. inlined from ./build_docker/./contrib/llvm-project/libcxx/include/__functional/invoke.h:394: decltype(std::declval<SignalListener::run()::'lambda'()>()()) std::__invoke[abi:v15000]<SignalListener::run()::'lambda'()>(SignalListener::run()::'lambda'()&&)
2024.01.02 15:18:50.512648 [ 102143 ] {} <Fatal> BaseDaemon: 6.3. inlined from ./build_docker/./contrib/llvm-project/libcxx/include/thread:284: void std::__thread_execute[abi:v15000]<std::unique_ptr<std::__thread_struct, std::default_delete<std::__thread_struct>>, SignalListener::run()::'lambda'()>(std::tuple<std::unique_ptr<std::__thread_struct, std::default_delete<std::__thread_struct>>, SignalListener::run()::'lambda'()>&, std::__tuple_indices<>)
2024.01.02 15:18:50.512664 [ 102143 ] {} <Fatal> BaseDaemon: 6. ./build_docker/./contrib/llvm-project/libcxx/include/thread:295: void* std::__thread_proxy[abi:v15000]<std::tuple<std::unique_ptr<std::__thread_struct, std::default_delete<std::__thread_struct>>, SignalListener::run()::'lambda'()>>(void*) @ 0x000000000ca0ccf5 in /usr/lib/debug/usr/bin/clickhouse.debug
2024.01.02 15:18:50.512698 [ 102143 ] {} <Fatal> BaseDaemon: 7. start_thread @ 0x0000000000007fa3 in /usr/lib/x86_64-linux-gnu/libpthread-2.28.so
2024.01.02 15:18:50.512721 [ 102143 ] {} <Fatal> BaseDaemon: 8. ? @ 0x00000000000f94cf in /usr/lib/x86_64-linux-gnu/libc-2.28.so
2024.01.02 15:18:50.666148 [ 102143 ] {} <Fatal> BaseDaemon: Integrity check of the executable successfully passed (checksum: 3A99FBFAA2DA54D46975E9ABC04E53E0)
2024.01.02 15:18:50.746677 [ 102143 ] {} <Fatal> BaseDaemon: Report this error to https://github.com/ClickHouse/ClickHouse/issues
```

**The problem is actually here** - [1].
Though to be precise here - [2].
See also - [3].

  [1]: 5e467b69c8/src/Common/StackTrace.cpp (L405)
  [2]: 4d734cf1e5/src/Common/StackTrace.cpp (L389)
  [3]: 5e467b69c8/src/Common/Dwarf.cpp (L1161)

_(It is not obvious from the patch, so will post a snippet)_

</details>

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-08 21:16:49 +03:00
Sema Checherinda
378602e1c8
Update 02675_profile_events_from_query_log_and_client.reference 2024-01-08 18:29:41 +01:00
Mikhail f. Shiryaev
5e467b69c8
Merge pull request #58600 from ClickHouse/release-script-simplify
Simplify release.py script
2024-01-08 21:12:45 +04:00
Antonio Andelic
4640049b4a
Merge pull request #58598 from ClickHouse/keeper-small-fix
Small fix in Keeper
2024-01-08 17:07:16 +01:00
jinjunzh
cf53d9a17c add USE_QAT into build_options 2024-01-08 11:05:36 -05:00
Robert Schulze
08e687c847
Incorporate review feedback 2024-01-08 15:55:27 +00:00
Anton Popov
3e933c9099 Merge remote-tracking branch 'upstream/master' into HEAD 2024-01-08 15:33:38 +00:00
Sema Checherinda
55ec1a17e7 remove debug logging 2024-01-08 15:58:47 +01:00
Sema Checherinda
9bd4851223 fix 02675_profile_events_from_query_log_and_client 2024-01-08 15:35:18 +01:00
Mikhail f. Shiryaev
a2a3783366
Small renaming to reflect the current release process 2024-01-08 15:31:59 +01:00
Mikhail f. Shiryaev
fe19f45974
Simplify --type argument for release.py 2024-01-08 15:31:58 +01:00
Mikhail f. Shiryaev
2232663216
Insignificant typing improvements 2024-01-08 15:31:57 +01:00
Mikhail f. Shiryaev
90a64ae5b8
Merge pull request #58384 from ClickHouse/reliable-tokens
Do not fail the CI on an expired token
2024-01-08 18:26:18 +04:00
Nikolai Kochetov
564847f9cf
Merge pull request #58602 from ClickHouse/KochetovNicolai-patch-1
Update analyzer_tech_debt.txt
2024-01-08 14:48:31 +01:00
Nikolai Kochetov
7abb850757
Update analyzer_tech_debt.txt 2024-01-08 14:46:22 +01:00
Robert Schulze
a2a86caf0f
Fix style, pt. II 2024-01-08 13:45:46 +00:00
Nikolai Kochetov
9f50b43dd8
Merge pull request #58599 from ClickHouse/KochetovNicolai-patch-1
Update analyzer_tech_debt.txt
2024-01-08 14:40:04 +01:00
Nikolai Kochetov
2e7a0bfd1c
Update analyzer_tech_debt.txt 2024-01-08 14:27:05 +01:00
Nikolai Kochetov
7f84b76993
Update analyzer_tech_debt.txt 2024-01-08 14:26:18 +01:00
Robert Schulze
fb4fd29110
Merge pull request #58454 from rschu1ze/punycode-revert-revert
Implement IDNA and punycode encoding/decoding (2nd attempt)
2024-01-08 14:26:03 +01:00
Jayme Bird
4f7e4fef40 ignore spelling srcReplicas 2024-01-08 12:58:26 +00:00
Jayme Bird
f7173004cc update docs 2024-01-08 12:40:05 +00:00
Nikolai Kochetov
77b349b136
Update analyzer_tech_debt.txt 2024-01-08 13:25:28 +01:00
vdimir
e68fc2df7a
Remove spaces after insert in clickhouse-format 2024-01-08 12:16:53 +00:00