Commit Graph

2535 Commits

Author SHA1 Message Date
Yatsishin Ilya
24e77083b3 Commit tests 2023-07-06 09:50:44 +00:00
Alexey Milovidov
d59f68b600 Remove useless code 2023-07-06 04:55:46 +02:00
Yatsishin Ilya
fd4f738502 Merge remote-tracking branch 'origin' into per-column-pk-syntax 2023-07-05 12:30:26 +00:00
Yatsishin Ilya
e957600d5c wip 2023-07-05 12:28:27 +00:00
kssenii
e6422f8144 Delete comment, rename variable 2023-07-05 13:08:11 +02:00
Kseniia Sumarokova
f2d942fbb5
Merge branch 'master' into more-flexible-drop-cache 2023-07-05 11:43:57 +02:00
Alexey Milovidov
289d9849d4 Allow SQL standard FETCH without OFFSET 2023-07-04 20:56:17 +02:00
Nikita Mikhaylov
673c30f717
Merge branch 'master' into oss-fuzz-fixes 2023-07-04 19:52:41 +02:00
Raúl Marín
7262433068
Merge branch 'master' into async_to_query_log 2023-07-04 12:59:04 +02:00
Nikita Mikhaylov
811ba86a20 Remove garbage 2023-07-04 00:24:35 +02:00
Nikita Mikhaylov
2e245f4a43 Even better 2023-07-04 00:23:00 +02:00
Sema Checherinda
bd3d6d4976
Merge pull request #51404 from CheSema/no-finalize-WriteBufferFromOStream
no finalize in d-tor WriteBufferFromOStream
2023-07-01 19:37:54 +02:00
kssenii
39f8b92e24 Allow to add disk name for custom disk 2023-06-28 19:05:35 +02:00
kssenii
1d78bafa82 Flexible drop cache 2023-06-28 18:44:47 +02:00
Sema Checherinda
047f656980 add explicit finalize calls 2023-06-26 15:04:50 +02:00
Raúl Marín
2d860302d9
Merge branch 'master' into async_to_query_log 2023-06-26 13:57:04 +02:00
Raúl Marín
b1cedf0e42 Simplify handling of AsyncInsertFlush 2023-06-20 11:38:19 +02:00
Raúl Marín
cf74aee6c9 Log async query flushes to query_log 2023-06-20 11:38:19 +02:00
alekar
b70803c71b
Merge branch 'master' into improve-outfile 2023-06-16 01:08:48 -07:00
Val Doroshchuk
e7c5991b39 MaterializedMySQL: Keep parenthesises for empty table overrides
Empty table overrides are formatted without any parenthesises,
but they are required by a parser,
and it is not possible to parse empty table overrides without it.

:) CREATE DATABASE db ... TABLE OVERRIDE t1()

CREATE DATABASE db
...
TABLE OVERRIDE `t1`

This query will be saved to metadata and ClickHouse will not be able to start up, since
table overrides require ().
2023-06-14 13:37:49 +02:00
Manas Alekar
bf69755ada Address some usability issues with INTO OUTFILE usage. 2023-06-13 01:26:11 -07:00
Robert Schulze
4f39ee51ae
Update Annoy docs 2023-06-12 20:06:57 +00:00
Robert Schulze
7745f7da73
Merge branch 'master' into annoy-misc 2023-06-12 21:46:27 +02:00
Robert Schulze
42914484b3
Merge pull request #50713 from rschu1ze/show-indices
Add SHOW INDICES as alias for statement SHOW INDEX/INDEXES/KEYS
2023-06-09 00:37:29 +02:00
Robert Schulze
b8178088d0
Misc Annoy fixes 2023-06-08 15:06:17 +00:00
Robert Schulze
6fcc4158d2
Add SHOW INDICES as alias for statement SHOW INDEX/INDEXES/KEYS 2023-06-08 12:51:33 +00:00
Val Doroshchuk
c37b80593c
MaterializedMySQL: Add support of TRUNCATE db.table (#50624)
Additional to `TRUNCATE TABLE db.table`.

Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2023-06-08 14:22:55 +03:00
Robert Schulze
c12c62a7fb
Update src/Parsers/ParserCreateIndexQuery.cpp
Co-authored-by: Nikolay Degterinsky <43110995+evillique@users.noreply.github.com>
2023-06-07 18:22:53 +02:00
Anton Popov
c980771c22 Merge remote-tracking branch 'upstream/master' into HEAD 2023-06-07 11:23:13 +00:00
Robert Schulze
4050b637f1
ALTER TABLE ADD INDEX: Add default GRANULARITY argument for secondary indexes
- Related to #45451, which provides a default GRANULARITY when the
  skipping index is created in CREATE TABLE.
2023-06-07 09:04:24 +00:00
Alexey Milovidov
091d6d02f7
Merge pull request #50536 from ClickHouse/fix-incorrect-constant-folding
Fix incorrect constant folding
2023-06-05 04:35:53 +03:00
Alexey Milovidov
6f01e2ad9f Fix incorrect constant folding 2023-06-04 02:49:45 +02:00
pufit
1aaac69e13
Merge branch 'master' into roles_in_config 2023-06-03 14:42:10 -04:00
Nikita Mikhaylov
362055ce60
Merge branch 'master' into 46229-repl-clickhouse-keeper 2023-06-02 23:58:07 +02:00
Alexey Milovidov
379c573db0
Merge branch 'master' into isnull-operator-priority 2023-06-01 03:20:22 +03:00
pufit
dbd3766f5f Specify roles in users.xml 2023-05-30 20:42:49 -04:00
Nikita Mikhaylov
31829f7cfc
Merge branch 'master' into 46229-repl-clickhouse-keeper 2023-05-31 02:29:08 +02:00
Nikolay Degterinsky
1a6517d4a0 Fix priority of the operators after IS NULL 2023-05-30 17:13:39 +00:00
Nikolay Degterinsky
391e61549d Fixes 2023-05-30 12:18:56 +00:00
Nikolay Degterinsky
e10f951467 Fix IS (NOT) NULL operator priority 2023-05-29 19:11:09 +00:00
Nikita Mikhaylov
0580859e6f Better 2023-05-25 14:05:44 +00:00
Nikita Mikhaylov
cf6ff7ab32 Merge branch 'master' of github.com:ClickHouse/ClickHouse into 46229-repl-clickhouse-keeper 2023-05-25 13:41:25 +00:00
Azat Khuzhin
b680697cce Initialize POD members of ASTs to make it less error-prone
The cost of initializing members is insignificant in compare to parsing,
while the cost of the error is high.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-25 10:18:55 +02:00
Azat Khuzhin
b30cfe5503 Fix UB in ASTWatchQuery for is_watch_events
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-25 10:15:30 +02:00
Azat Khuzhin
c053d75741 Fix formatting of INTO OUTFILE extensions (APPEND / AND STDOUT)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-25 10:15:30 +02:00
Azat Khuzhin
9582d9e892 Fix UB for INTO OUTFILE extensions (APPEND / AND STDOUT)
MSAn report:

==38627==WARNING: MemorySanitizer: use-of-uninitialized-value
    0 0x555599f5e114 in std::__1::__unique_if<DB::WriteBufferFromFile>::__unique_single std::__1::make_unique[abi:v15000]<> build_docker/./contrib/llvm-project/libcxx/include/__memory/unique_ptr.h:714:32
    1 0x555599f5e114 in DB::ClientBase::initOutputFormat() build_docker/./src/Client/ClientBase.cpp:604:21
    2 0x555599f590a8 in DB::ClientBase::onData() build_docker/./src/Client/ClientBase.cpp:446:5
    3 0x555599f6f36e in DB::ClientBase::receiveAndProcessPacket() build_docker/./src/Client/ClientBase.cpp:1019:17
    4 0x555599f6e863 in DB::ClientBase::receiveResult() build_docker/./src/Client/ClientBase.cpp:987:18
    5 0x555599f6c05b in DB::ClientBase::processOrdinaryQuery() build_docker/./src/Client/ClientBase.cpp:905:13
    6 0x555599f67e05 in DB::ClientBase::processParsedSingleQuery() build_docker/./src/Client/ClientBase.cpp:1711:13
    7 0x555599f86fb6 in DB::ClientBase::executeMultiQuery(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) build_docker/./src/Client/ClientBase.cpp:1975:21

  Uninitialized value was created by a heap allocation
    8 0x55559bd3e038 in DB::ParserExplainQuery::parseImpl(DB::IParser::Pos&, std::__1::shared_ptr<DB::IAST>&, DB::Expected&) build_docker/./src/Parsers/ParserExplainQuery.cpp:53:26
    9 0x55559bce31f4 in DB::IParserBase::parse(DB::IParser::Pos&, std::__1::shared_ptr<DB::IAST>&, DB::Expected&)::$_0::operator()() const build_docker/./src/Parsers/IParserBase.cpp:13:20
    ..
    21 0x55559be13b5c in DB::parseQueryAndMovePosition(DB::IParser&, char const*&, char const*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool, unsigned long, unsigned long) build_docker/./src/Parsers/parseQuery.cpp:357:18
    22 0x555599f5673a in DB::ClientBase::parseQuery(char const*&, char const*, bool) const build_docker/./src/Client/ClientBase.cpp:362:15
    23 0x555599f84a4f in DB::ClientBase::analyzeMultiQueryText() build_docker/./src/Client/ClientBase.cpp:1821:24
    24 0x555599f867b3 in DB::ClientBase::executeMultiQuery(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) build_docker/./src/Client/ClientBase.cpp:1910:22
    25 0x555599f8a2fd in DB::ClientBase::processQueryText(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) build_docker/./src/Client/ClientBase.cpp:2120:12
    26 0x555599f94aee in DB::ClientBase::runNonInteractive() build_docker/./src/Client/ClientBase.cpp:2403:9

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-25 10:15:23 +02:00
Anton Popov
69ec65ab33 Merge remote-tracking branch 'upstream/master' into HEAD 2023-05-16 10:30:47 +00:00
Vitaly Baranov
801cacc13f
Merge pull request #49831 from vitlibar/fix-setting-null-in-profile-def
Fix setting NULL in profile definition
2023-05-15 22:24:49 +02:00
Ilya Golshtein
9ef610040f row_policy_template - table * is respected 2023-05-13 22:30:02 +00:00
Ilya Golshtein
7fa6ea4ccc row policy template: tests and code cleanup, code review changes 2023-05-13 22:30:02 +00:00
Ilya Golshtein
f0d21a9100 row policy template: initial, works, restrictive rules fix 2023-05-13 22:30:02 +00:00
Alexey Milovidov
c306deb1ae
Merge pull request #49087 from Eridanus117/suffix_size
improvement(parser): size suffixes in quota creation parameters
2023-05-13 01:56:10 +03:00
Robert Schulze
b9c185af44
Merge pull request #49678 from azat/build/llvm-16
Switch to LLVM/clang 16 (16.0.3)
2023-05-12 13:47:36 +02:00
Vitaly Baranov
eb62030fa4 Fix assigning a setting to NULL in settings profile's definition. 2023-05-12 11:04:30 +02:00
Vitaly Baranov
ec011b9113
Merge branch 'master' into user-grants-from-config 2023-05-11 17:08:06 +02:00
Eridanus
990c224540 improvement(parser): add support for size suffixes in quota creation
statement parameters

This commit adds support for creating quotas with size suffixes in the
parameter list of a quota creation statement. The parser now recognizes
size suffixes such as "KB", "MB", and "GB" and correctly converts them
to their corresponding values in bytes. This feature improves the
usability of the quota creation statement and makes it more flexible.
The commit also includes additional tests to ensure that the new syntax
is parsed correctly.
Attention: we did not support string literal with double like
execute_time = '1.5'
2023-05-11 20:04:53 +08:00
Azat Khuzhin
a0cc5b7e47 Merge remote-tracking branch 'u/master' into build/llvm-16 2023-05-10 16:28:36 +02:00
Han Fei
d17aa828b3
Merge pull request #49361 from hanfei1991/hanfei/fiu
support named fault injection and add a simple test
2023-05-10 15:51:51 +02:00
vdimir
1b7f54e886
Merge pull request #46467 from bigo-sg/first_value 2023-05-10 14:56:14 +02:00
alekar
605991d4d5
Merge branch 'master' into 48716 2023-05-09 13:38:11 -07:00
Azat Khuzhin
0610865811 Fix readability-redundant-string-cstr clang-tidy warning
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-09 21:22:05 +02:00
Han Fei
64b67b9a37 Merge branch 'master' into hanfei/fiu 2023-05-09 01:14:30 +02:00
Robert Schulze
7137c8811a
Merge pull request #49158 from ClickHouse/rs/show-indexes
Implement SHOW INDEX
2023-05-06 15:30:29 +02:00
pufit
04a829b554 Fix PR issues 2023-05-05 22:41:44 -04:00
Eridanus
d428c461fc
Merge branch 'master' into suffix_size 2023-05-04 17:39:27 +08:00
alesapin
89caf40840
Merge pull request #46528 from myrrc/feature/show-secrets-option
Show secrets in `SHOW` and `SELECT` queries
2023-05-04 11:21:30 +02:00
Eridanus
72b35729ae
Merge branch 'master' into suffix_size 2023-05-04 13:55:40 +08:00
alekar
af81f056b4
Merge branch 'master' into 48716 2023-05-03 18:35:54 -07:00
Alexander Tokmakov
e399903030
Merge pull request #48548 from ClickHouse/clusters_is_active_column
Add some columns to system.clusters
2023-05-03 17:42:40 +03:00
Nikolay Degterinsky
4c038ef538
Merge branch 'master' into bcrypt 2023-05-02 21:52:21 +02:00
Nikolay Degterinsky
46c86dce93 Fix bcrypt enum value 2023-05-02 14:36:48 +00:00
Robert Schulze
7e5fded3cf
A little less clutter 2023-05-02 13:16:15 +00:00
Nikolay Degterinsky
f87c418fc8
Merge pull request #49360 from evillique/alias-restricted-keywords
Allow restricted keywords if alias is quoted
2023-05-02 15:02:05 +02:00
Robert Schulze
6bdbee33ee
Incorporate review feedback 2023-05-02 12:29:56 +00:00
pufit
2964ca5c84 Specify grants for users in users.xml 2023-05-01 20:24:02 -04:00
Han Fei
d608ba41e7 try to fix 2023-05-02 00:05:36 +02:00
Han Fei
4d18a4f8d3
Merge branch 'master' into hanfei/fiu 2023-05-01 17:51:41 +02:00
Han Fei
b701293d46 support named fault injection and add a simple test 2023-05-01 17:44:37 +02:00
Nikolay Degterinsky
76a591fa5e Allow restricted keywords if alias is quoted 2023-05-01 15:16:12 +00:00
alekar
29d96afae8
Merge branch 'master' into 48716 2023-04-28 14:24:46 -07:00
Mike Kot
2d20658885
Merge branch 'master' into feature/show-secrets-option 2023-04-28 20:19:35 +03:00
Nikolay Degterinsky
54c8f63a33 Fixes 2023-04-28 15:12:06 +00:00
Alexey Milovidov
6dcfdbfaf2
Merge branch 'master' into clusters_is_active_column 2023-04-28 16:16:25 +03:00
Eridanus
d479404318 improvement(parser): size suffixes in quota creation parameters
This commit adds support for creating quotas with size suffixes in the
parameter list of a quota creation statement. The parser now recognizes
size suffixes such as "KB", "MB", and "GB" and correctly converts them
to their corresponding values in bytes. This feature improves the
usability of the quota creation statement and makes it more flexible.
The commit also includes additional tests to ensure that the new syntax
is parsed correctly.
2023-04-28 14:05:16 +08:00
Mike Kot
357cde95e9 Merge branch 'master' into feature/show-secrets-option 2023-04-27 20:19:40 +00:00
Nikolay Degterinsky
df1e56b985 Merge remote-tracking branch 'upstream/master' into bcrypt 2023-04-27 17:01:58 +00:00
Robert Schulze
c58e0e347c
Various cleanups 2023-04-26 09:46:35 +00:00
pufit
8bef8fc1de Parsing Keeper commands via ClickHouse Parser 2023-04-26 00:54:28 -04:00
Anton Popov
125e5c50b8 allow to flush async insert queue 2023-04-25 21:30:03 +00:00
Robert Schulze
c4ab1e12f1
Initial version of SHOW INDEXES 2023-04-25 20:48:11 +00:00
alekar
d717f007d7
Merge branch 'master' into 48716 2023-04-24 23:44:03 -07:00
Nikolay Degterinsky
2fe3a69ba1 Merge remote-tracking branch 'upstream/master' into add_default_password_type 2023-04-24 18:51:32 +00:00
Nikolay Degterinsky
12ad5b710a Separate AuthenticationData and AuthenticationType, small fixes 2023-04-24 15:12:45 +00:00
pufit
1985fb785e
Merge pull request #48262 from ClickHouse/42497-inherit-grant
GRANT CURRENT GRANTS implementation
2023-04-24 11:11:10 -04:00
Alexander Tokmakov
332a736a59 Merge branch 'master' into clusters_is_active_column 2023-04-24 15:54:03 +02:00
Nikolay Degterinsky
b599d0bd01 Better 2023-04-21 22:03:56 +00:00
pufit
544972bcda Solve PR issues 2023-04-20 18:31:35 -04:00
lgbo-ustc
10daacb18f updated 2023-04-20 09:28:49 +08:00
lgbo-ustc
bd84b7a87a support syntax, respect nulls/ignore nulls 2023-04-20 09:28:49 +08:00
Manas Alekar
8cc425cd29 INTO OUTFILE enhancements 2023-04-18 00:20:55 -07:00
kssenii
0517de58d1 Simplify FileCacheFactory 2023-04-15 16:15:20 +02:00
Robert Schulze
8eabc43068
Merge pull request #48591 from ucasfl/show-table
support show table
2023-04-14 18:42:29 +02:00
Robert Schulze
adb15b7033
Merge branch 'master' into show-table 2023-04-14 09:52:56 +02:00
Dmitry Novik
5cc9b46f78 Merge remote-tracking branch 'origin/master' into optimize-compilation 2023-04-13 16:04:09 +02:00
Robert Schulze
f6b24fe058
Merge pull request #48509 from ClibMouse/feature/no-more-strlen-plz
Use std::string_view to get rid of strlen
2023-04-13 10:59:05 +02:00
pufit
aa0f3bc994 Solve pr issues 2023-04-12 20:28:17 -04:00
Robert Schulze
3f7ce60e03
Merge branch 'master' into rs/gcc-removal 2023-04-12 22:17:04 +02:00
ltrk2
c3f5da3343 Remove element that used to serve as a sentinel 2023-04-12 12:15:53 -07:00
ltrk2
65e08781a6 Use std::string_view to get rid of strlen 2023-04-12 11:33:11 -07:00
pufit
078b8f5399 Small refactor, additional tests 2023-04-11 19:55:59 -04:00
Robert Schulze
05606a8835
Clean up GCC warning pragmas 2023-04-11 18:21:08 +00:00
Alexander Tokmakov
dfff30e1a9 Merge branch 'master' into clusters_is_active_column 2023-04-11 16:32:15 +02:00
Nikolay Degterinsky
0621222737 Fix crashes with incorrect query parameters 2023-04-11 14:22:55 +00:00
robot-ch-test-poll1
028ccfdc87
Merge pull request #48438 from evillique/add-trailing-commas
Allow trailing commas in expression list of SELECT query
2023-04-11 14:21:28 +02:00
Nikolay Degterinsky
908be1e324 Fix tests 2023-04-10 22:04:10 +00:00
Nikolay Degterinsky
6f57a952d9 Improvements 2023-04-10 16:40:49 +00:00
flynn
5a8d10c0e0 fix 2023-04-10 10:46:47 +00:00
flynn
dfe9ce6ec4 fix 2023-04-10 08:27:55 +00:00
flynn
f87782b6b5 support show table 2023-04-10 06:37:47 +00:00
Nikolay Degterinsky
dbc620f7e2 Fix style 2023-04-10 02:59:42 +00:00
Nikolay Degterinsky
7957752128 Merge remote-tracking branch 'upstream/master' into add_default_password_type 2023-04-10 02:25:46 +00:00
Nikolay Degterinsky
64dc60a8d1 Better version, introduce ASTAuthenticationData 2023-04-10 02:20:57 +00:00
Nikolay Degterinsky
10883d8af5 Allow commas with subqueries, add comments 2023-04-09 12:52:23 +00:00
Alexander Tokmakov
9ec91acef3 add some columns to system.clusters 2023-04-07 18:26:23 +02:00
pufit
144ee7aed4 Fix logic, additional tests 2023-04-05 22:52:31 -04:00
Nikolay Degterinsky
061be7c9ad Add trailing commas to expression list in SELECT query 2023-04-05 18:08:56 +00:00
Vitaly Baranov
82373890e5
Merge branch 'master' into fix-forgotten-showsecrets-in-semi-copy-ctor 2023-04-05 18:17:33 +02:00
pufit
8441b0a3e1 Fix comments, tests, docs 2023-04-04 20:43:15 -04:00
Robert Schulze
e031783ae5
More CMake fixes 2023-04-04 15:39:16 +00:00
natasha
c3acaecce6 fix style - missed tab 2023-04-04 16:04:33 +01:00
natasha
647fb63b83 rm unneeded parentheses 2023-04-04 16:01:15 +01:00
natasha
a1d3ea92b9 Merge remote-tracking branch 'origin/master' into format-hiliting-fix 2023-04-04 15:55:40 +01:00
natasha
95d77193af add comment re excessive copying in are_equal_with_hilites_removed 2023-04-04 15:54:42 +01:00
natasha
46691ef705 add check that all strings end without any hilite 2023-04-04 15:51:12 +01:00
natasha
a1d718c601 update docstring for consume_hilites 2023-04-04 15:12:52 +01:00
natasha
cba124f99c fix while in consume_hilites 2023-04-04 15:04:50 +01:00
natasha
f6db4fa466 avoid explicit check if strings are_equal_without_hilites in are_equal_with_hilites
if anyone needs it, they can call it themselves
2023-04-04 15:00:14 +01:00
natasha
0a021d3378 refactor consume_hilites to assign last_hilite to an argument, rather than return it, to avoid code duplication in are_equal_with_hilites 2023-04-04 14:58:39 +01:00
natasha
f3560a295d accept the pointer by & in consume_hilites, rather than by a pointer to the pointer 2023-04-04 14:39:03 +01:00
natasha
2e9607f9c1 Fix style 2023-04-04 14:33:50 +01:00
natasha
86edd48096 HiliteComparator: add Hilite alias for const char * representing hilites 2023-04-04 14:29:02 +01:00
natasha
2ff5d60509 change compare argument order to be expected, query (=actual) 2023-04-04 14:20:13 +01:00
natasha
ebb8899a3d restructure format hiliting tests to avoid code duplication 2023-04-04 14:19:06 +01:00
natasha
3e11c06976 extract HiliteComparator tests into an own test suit 2023-04-04 12:41:08 +01:00
natasha
3452e1927e move const var definition in HiliteComparator 2023-04-04 12:36:41 +01:00
natasha
880e44132f fix hilite comparator tests 2023-04-04 12:36:22 +01:00
natasha
779bd3bf4d move hilite comparator tests as well 2023-04-04 11:27:02 +01:00
Alexey Milovidov
de8f7a5ad6
Merge pull request #48189 from vitlibar/backup-all
Support BACKUP ALL command
2023-04-04 01:57:23 +03:00
Robert Schulze
c8ef87f984
Fix build 2023-04-03 13:57:16 +00:00
natasha
14b4fde1b4 extract hilite comparator tests 2023-04-03 13:49:43 +01:00