Commit Graph

28578 Commits

Author SHA1 Message Date
kssenii
9973fb2f1d Fix merge 2022-07-13 11:19:14 +02:00
Wangyang Guo
f275b35bba Dynamic dispatching for best_variant selection 2022-07-13 15:20:15 +08:00
Yakov Olkhovskiy
1f57f92bf7 prewhere action should preserve sorting columns 2022-07-13 03:01:23 -04:00
Yakov Olkhovskiy
334b3f3c73
Merge pull request #38864 from azat/fix-rwlock
Fix waiting of shared lock after exclusive lock failure
2022-07-13 02:10:35 -04:00
Amos Bird
0595c50c92
Fix trivial count with empty set 2022-07-13 12:54:52 +08:00
Amos Bird
0795cdd36a
Slightly better interface of waitForMutation 2022-07-13 12:34:12 +08:00
Nikolay Degterinsky
daae55b4ac Better 2022-07-13 01:41:27 +00:00
Anton Popov
df190b14b2
Merge pull request #39113 from CurtizJ/tuple-lowcardinality
Keep `LowCardinality` type in `tuple()` function
2022-07-13 02:28:56 +02:00
Kruglov Pavel
da24f93445
Merge pull request #39101 from Avogar/fix-try-get-least-supertype
Fix code in getLeastSupertype function
2022-07-12 22:59:29 +02:00
Dmitry Novik
66ade34508
Merge branch 'master' into window-expressions-fix 2022-07-12 22:36:19 +02:00
vdimir
af55f1c1e3 Update toPowerOfTwo in ConcurrentHashJoin 2022-07-12 20:22:35 +02:00
vdimir
b4cb2a847e Default join algorithm set to hash 2022-07-12 20:22:35 +02:00
vdimir
b4176828c6 Apply intHash64 on top of WeakHash32 for parallel join 2022-07-12 20:22:35 +02:00
vdimir
63aebd17b2 Remove TabSeparatedSorted 2022-07-12 20:22:35 +02:00
vdimir
218288ee6c upd ConcurrentHashJoin 2022-07-12 20:22:35 +02:00
vdimir
2ec373c6a7 Number of shards in parallel hash join is always power of two 2022-07-12 20:22:35 +02:00
vdimir
46df417c2e Fix empty line sorting in TabSeparatedSorted 2022-07-12 20:22:35 +02:00
vdimir
f51b25b262 clickhouse test ignore order via special format 2022-07-12 20:22:35 +02:00
vdimir
f3e84d8fc6 fix order in 01913_join_push_down_bug 00952_input_function 2022-07-12 20:22:35 +02:00
vdimir
a7ea163e3b Fix parallel hash join to lowcard keys 2022-07-12 20:22:35 +02:00
vdimir
9f5e30a5d3 Set default join_algorithm = parallel_hash 2022-07-12 20:22:35 +02:00
vdimir
9e0cb37bd7 Disable parallel hash join for asof 2022-07-12 20:22:35 +02:00
Nikolai Kochetov
ec24f730b1
Merge pull request #39125 from ClickHouse/fix-insert-into-mv-with-extremes-enabled
Fix insert into MV with enabled extremes.
2022-07-12 20:19:41 +02:00
Nikolai Kochetov
93bf22f585 Fix data race in CompletedPipelineExecutor. 2022-07-12 17:59:31 +00:00
kssenii
6f29eada80 Merge master 2022-07-12 19:28:18 +02:00
Robert Schulze
8b6e31cc61
Merge pull request #37882 from excitoon-favorites/nodeleteobjects
Fixes for objects removal in `S3ObjectStorage`
2022-07-12 19:09:55 +02:00
Kseniia Sumarokova
0fb35b773f
Update StorageMongoDB.cpp 2022-07-12 18:37:19 +02:00
kssenii
c38f726537 Remove redundant code 2022-07-12 18:28:20 +02:00
kssenii
4d48d6e713 STUPID BUG 2022-07-12 18:27:22 +02:00
Kseniia Sumarokova
5468a2fde9
Update StorageMongoDB.cpp 2022-07-12 17:20:20 +02:00
Kseniia Sumarokova
869da0d923
Update StorageMongoDB.cpp 2022-07-12 17:19:49 +02:00
kssenii
f46d641440 Fix style check and black check
t:wq# Date:      Tue Jul 12 14:02:09 2022 +0200
2022-07-12 16:29:11 +02:00
Nikolai Kochetov
8efbe6d44d
Merge pull request #39119 from ClickHouse/removed-projection-and-old-part
Properly remove projection from part in case it was removed from table metadata.
2022-07-12 16:24:30 +02:00
Amos Bird
982e1a73d3
Better 2022-07-12 22:21:46 +08:00
Amos Bird
d3709c6c26
Avoid redundant join block transformation. 2022-07-12 22:20:10 +08:00
Amos Bird
b9d9ca5194
style fix 2022-07-12 22:20:08 +08:00
Nikolai Kochetov
75c3926cbb Fix insert into MV with enabled extremes. 2022-07-12 13:57:36 +00:00
Anton Popov
81da0bb9f5 keep LowCardinality type in array() and map() functions 2022-07-12 13:31:00 +00:00
Robert Schulze
69de9ee0e8
Merge pull request #39108 from ClickHouse/prefix_cmake_commands
Prefix overridden add_executable() command with "clickhouse_"
2022-07-12 15:05:48 +02:00
alesapin
215166912c
Merge pull request #39069 from ClickHouse/keeper-persist-state
Persist state of ClickHouse Keeper
2022-07-12 13:32:02 +02:00
Alexander Tokmakov
c99fe6e6c8
Merge branch 'master' into removed-projection-and-old-part 2022-07-12 14:00:55 +03:00
Alexander Tokmakov
b35ad0dbdc
Merge pull request #39091 from ClickHouse/tavplubix-patch-1
Follow-up to #39036
2022-07-12 13:47:37 +03:00
Nikolai Kochetov
945b5d4b3f
Merge pull request #38993 from azat/fix-fsync_part_directory-on-fetch
Fix fsync_part_directory for fetches
2022-07-12 11:48:42 +02:00
Nikolai Kochetov
cd4211298e Fix typo. 2022-07-12 09:37:00 +00:00
Nikolai Kochetov
03d9301425 Fix log. 2022-07-12 08:31:09 +00:00
Nikolai Kochetov
631be9219b Properly remove projection from part in case it was removed from table metadata. 2022-07-12 08:28:22 +00:00
Antonio Andelic
6dcdf0fcb1 Throw CORRUPTED_DATA in debug mode for invalid checksum 2022-07-12 06:41:58 +00:00
Anton Popov
72fe4ce680 fix function toColumnTypeName with LowCardinality 2022-07-12 03:12:42 +00:00
Anton Popov
b67405915e keep LowCardinality type in tuple() function 2022-07-12 02:01:41 +00:00
Dmitry Novik
d046132265 Allow to use higher-order functions in window expressions 2022-07-11 23:47:46 +00:00
Dmitry Novik
fd9d897df2 Fix ActionsDAG for window expressions 2022-07-11 23:18:44 +00:00
kssenii
112a764794 Process no disk space left
:wq# Please enter the commit message for your changes. Lines starting
2022-07-11 22:12:40 +02:00
kssenii
dd7ca4995d t p:wq
Small improvement
2022-07-11 22:05:48 +02:00
Yakov Olkhovskiy
5887deac99
Merge branch 'master' into fix-rwlock 2022-07-11 16:01:16 -04:00
aaapetrenko
aabf0ed67f refactor Storage 2022-07-11 22:00:57 +02:00
aaapetrenko
d950b9c965 add TableFunctionMongoDB and tests 2022-07-11 22:00:49 +02:00
kssenii
e8daa50bad Fix tests 2022-07-11 21:24:18 +02:00
Robert Schulze
1a7727a254
Prefix overridden add_executable() command with "clickhouse_"
A simple HelloWorld program with zero includes except iostream triggers
a build of ca. 2000 source files. The reason is that ClickHouse's
top-level CMakeLists.txt overrides "add_executable()" to link all
binaries against "clickhouse_new_delete". This links against
"clickhouse_common_io", which in turn has lots of 3rd party library
dependencies ... Without linking "clickhouse_new_delete", the number of
compiled files for "HelloWorld" goes down to ca. 70.

As an example, the self-extracting-executable needs none of its current
dependencies but other programs may also benefit.

In order to restore access to the original "add_executable()", the
overriding version is now prefixed. There is precedence for a
"clickhouse_" prefix (as opposed to "ch_"), for example
"clickhouse_split_debug_symbols". In general prefixing makes sense also
because overriding CMake commands relies on undocumented behavior and is
considered not-so-great practice (*).

(*) https://crascit.com/2018/09/14/do-not-redefine-cmake-commands/
2022-07-11 19:36:18 +02:00
Sergei Trifonov
6ed777d2a8 add azure support 2022-07-11 19:19:57 +02:00
Kseniia Sumarokova
00dedc4e00
Merge pull request #39092 from ClickHouse/kssenii-patch-4
Update registerDiskS3.cpp
2022-07-11 18:05:28 +02:00
Sergei Trifonov
add0d1698e respect new limits in HDFS 2022-07-11 17:30:23 +02:00
Kseniia Sumarokova
e82485f65a
Update DiskObjectStorageTransaction.cpp 2022-07-11 16:50:09 +02:00
avogar
fca9d75e82 Fix code in getLeastSupertype function 2022-07-11 14:47:51 +00:00
mergify[bot]
62c62a2df7
Merge branch 'master' into lz4-decompress-vbmi 2022-07-11 14:23:17 +00:00
Sergei Trifonov
43779ec280 add max_remote_{read,write}_network_bandwidth_for_server settings 2022-07-11 14:59:39 +02:00
Antonio Andelic
568ba5d3cc Address PR comments 2022-07-11 12:56:09 +00:00
Antonio Andelic
efc7f5c534 Merge branch 'master' into keeper-persist-state 2022-07-11 12:43:06 +00:00
Kseniia Sumarokova
24f933cf75
Update registerDiskS3.cpp 2022-07-11 14:21:18 +02:00
Kseniia Sumarokova
3998a10c01
Update registerDiskS3.cpp 2022-07-11 14:19:09 +02:00
Alexander Tokmakov
e9ddbc247f
Merge pull request #39016 from Algunenano/clearOldLogs_zkerror
clearOldLogs: Don't report KEEPER_EXCEPTION on concurrent deletes
2022-07-11 15:16:18 +03:00
Alexander Tokmakov
048d27189e
Update MergeTreeData.cpp 2022-07-11 15:07:31 +03:00
Kruglov Pavel
57a719bafd
Merge pull request #39037 from amosbird/index-fix-1-again
Fix toHour() monotonicity which can lead to incorrect query result (incorrect index analysis) (second try)
2022-07-11 13:36:01 +02:00
Vladimir C
ca2e27aaa2
Merge pull request #37841 from vdimir/perf-save-to-stat
Send perf tests results to ci database
2022-07-11 13:07:40 +02:00
Robert Schulze
5b8e448c7e
Merge pull request #39012 from ClickHouse/fix-crashing-stringsearch-with-empty-needle
Don't throw Logical error in functions multiMatch[Fuzzy](AllIndices/Any/AnyIndex)() with empty needle
2022-07-11 08:13:52 +02:00
Vladimir Chebotarev
92880d7840 Fixed test. 2022-07-11 08:31:58 +03:00
kssenii
dd9651a6ca Better 2022-07-10 22:42:16 +02:00
Antonio Andelic
e4f7635df7 Format 2022-07-10 19:10:27 +00:00
Antonio Andelic
183f5cc940 Add checksum to the state file 2022-07-10 15:01:38 +00:00
Kseniia Sumarokova
18f93b15fc
Merge pull request #39070 from kssenii/fix-cache-bug
Fix for fs cache
2022-07-10 16:54:08 +02:00
Antonio Andelic
2b26865f90 Unit test fixes 2022-07-10 14:40:08 +00:00
Vitaly Baranov
6fce17584c
Merge pull request #39046 from vitlibar/restore-on-cluster-async-on-replicas
BACKUP/RESTORE ON CLUSTER use async mode on replicas now.
2022-07-10 15:54:51 +02:00
kssenii
7501d5e59c Fix 2022-07-10 12:42:43 +02:00
Antonio Andelic
4622084d2a Add test for persisted state 2022-07-10 09:47:04 +00:00
Antonio Andelic
f60074e9ec Make state durable 2022-07-10 09:33:49 +00:00
Antonio Andelic
37f799550b
Merge pull request #38072 from lingpeng0314/master
Add Keeper related monitoring data
2022-07-10 09:39:57 +02:00
Kseniia Sumarokova
3eb8c7f158
Merge pull request #38792 from xiedeyantu/fix-support-parallel-write
Fixed parallel writes for S3 does not work
2022-07-09 23:15:56 +02:00
kssenii
4c88527c8e Review fixes 2022-07-09 19:35:07 +02:00
alesapin
d222f238f0
Merge pull request #39030 from ClickHouse/fix-overcommit-logging
Remove logging from OvercommitTracker to avoid deadlocks
2022-07-09 13:47:29 +02:00
alesapin
f00069fdb6
Merge pull request #39036 from ClickHouse/tavplubix-patch-1
Fix 'Tried to lock part ... for removal second time'
2022-07-09 13:45:40 +02:00
kssenii
6d3471ad69 Merge master 2022-07-09 13:13:51 +02:00
kssenii
bf1c99daab Refactoring of object storages, add LocalObjectStorage 2022-07-09 12:39:31 +02:00
Vitaly Baranov
847cda87f9 BACKUP/RESTORE ON CLUSTER use async mode on replicas now. 2022-07-08 22:26:01 +02:00
Vladimir C
06ce3e0b2e
Merge pull request #39014 from vdimir/fsj-fix
Fix assertion in full soring merge join
2022-07-08 21:47:22 +02:00
Alexander Tokmakov
51130d723c
Update MergeTreeData.cpp 2022-07-08 20:17:29 +03:00
Dmitry Novik
99cef119e1 Remove logging from OvercommitTracker 2022-07-08 15:34:23 +00:00
Amos Bird
28aefc33a0
Revert "Merge pull request #39001 from ClickHouse/revert-38675-index-fix-1"
This reverts commit 1cf01bb959, reversing
changes made to af1136c990.
2022-07-08 23:22:10 +08:00
Raúl Marín
a965438eea clearOldLogs: Don't report errors on concurrent deletes 2022-07-08 13:57:53 +02:00
vdimir
da523f3288
Fix assertion in full soring merge join 2022-07-08 11:31:15 +00:00
Robert Schulze
8e1a3cd194
Don't crash in functions multiMatch[Fuzzy](AllIndices/Any/AnyIndex)() with empty needle
Queries like
  "select multiMatchAnyIndex('abc', []::Array(String))"
were not properly handled and crashed.
2022-07-08 11:18:53 +00:00
Vitaly Baranov
3af50b35ae
Merge pull request #38949 from vitlibar/careful-destructor-in-backupimpl
More careful destructor in BackupImpl
2022-07-08 13:11:13 +02:00
Azat Khuzhin
b2f7f9c0f0 Fix fsync_part_directory for fetches
Before it produces the following error:

    2022.07.07 23:40:03.131044 [ 44869 ] {} <Error> default.rep_data: auto DB::StorageReplicatedMergeTree::processQueueEntry(ReplicatedMergeTreeQueue::SelectedEntryPtr)::(anonymous class)::operator()(DB::StorageReplicatedMergeTree::LogEntryPtr &) const: Code: 107. DB::ErrnoException: Cannot open file /var/lib/clickhouse/data/tmp-fetch_36_25458_25458_0, errno: 2, strerror: No such file or directory. (FILE_DOESNT_EXIST), Stack trace (when copying this message, always include the lines below):

    0. Poco::Exception::Exception() @ 0x1764634c in /usr/bin/clickhouse
    1. DB::Exception::Exception() @ 0xb42caba in /usr/bin/clickhouse
    2. DB::throwFromErrnoWithPath() @ 0xb42d79b in /usr/bin/clickhouse
    3. DB::LocalDirectorySyncGuard::LocalDirectorySyncGuard() @ 0x1404bbd4 in /usr/bin/clickhouse
    4. DB::DiskLocal::getDirectorySyncGuard() const @ 0x140466a4 in /usr/bin/clickhouse
    5. DB::DataPartsExchange::Fetcher::downloadPartToDisk() @ 0x15122af1 in /usr/bin/clickhouse
    6. DB::DataPartsExchange::Fetcher::fetchPart() @ 0x1511de39 in /usr/bin/clickhouse

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-08 13:48:51 +03:00
Alexander Tokmakov
d4784203b7
Revert "Fix toHour() monotonicity which can lead to incorrect query result (incorrect index analysis)" 2022-07-08 12:51:30 +03:00
Alexey Milovidov
bd97233a4f
Merge pull request #38977 from ClickHouse/disable_instrumentation_of_death_callback
Disable instrumentation of sanitizer death callback
2022-07-08 11:04:37 +03:00
Robert Schulze
524f39551c
Merge pull request #38485 from ClickHouse/multi-match-with-non_const-patterns
Multi match with non const patterns
2022-07-08 09:29:10 +02:00
Alexey Milovidov
89fdcbf08c
Merge pull request #38675 from amosbird/index-fix-1
Fix toHour() monotonicity which can lead to incorrect query result (incorrect index analysis)
2022-07-08 00:32:27 +03:00
Nikolay Degterinsky
5cd06ac488
Merge pull request #38947 from soyayaos/master
Rename NUMBER_OF_DIMENSIONS_MISMATHED const to NUMBER_OF_DIMENSIONS_MISMATCHED
2022-07-07 22:25:42 +02:00
Robert Schulze
49348b833a
Simplify 2022-07-07 20:25:26 +00:00
Alexander Tokmakov
b0f8970d07
Merge pull request #38961 from Algunenano/reduce_zk_eexists
Stop reporting Zookeeper "Node exists" exceptions in system.errors when they are expected
2022-07-07 23:16:46 +03:00
Alexander Tokmakov
c45482d6c6 disable instrumentation of sanitizer death callback 2022-07-07 22:10:12 +02:00
Alexey Milovidov
74d02aeca7
Merge pull request #38907 from evillique/compression_level
Add compression level for data export
2022-07-07 22:27:21 +03:00
Alexander Tokmakov
1d93dc1c9a
Merge pull request #38963 from ClickHouse/fix_38962
Avoid weird exception in Keeper
2022-07-07 22:01:35 +03:00
Robert Schulze
f15d9ca59c
Merge pull request #38774 from zvonand/zvonand-nnd
Reintroduce nonNegativeDerivative()
2022-07-07 20:39:13 +02:00
Vladimir C
db838f1343
Merge pull request #35796 from vdimir/full-sorting-merge-join 2022-07-07 19:16:49 +02:00
Igor Nikonov
fac42db380
Merge pull request #38873 from ClickHouse/order_by_with_braces
Order by tuple
2022-07-07 19:16:06 +02:00
Kruglov Pavel
ab67838c44
Merge pull request #38816 from Avogar/fix-values-func
Allow null modifier in columns declaration for table functions
2022-07-07 17:27:18 +02:00
Alexander Tokmakov
7630fc76ae avoid weird exception 2022-07-07 17:19:05 +02:00
Raúl Marín
9b0c7714e5 Style 2022-07-07 17:15:23 +02:00
Kseniia Sumarokova
48220f64d6
Merge pull request #38214 from bigo-sg/storagehive_alter
support alter on `StorageHive` table
2022-07-07 17:06:43 +02:00
Raúl Marín
c3935000a8 Avoid reporting ZK EEXIST errors on checkPartChecksumsAndCommit 2022-07-07 16:10:05 +02:00
Raúl Marín
33ffb71453 Avoid 'Node exists' errors when creating Ephemeral Locks 2022-07-07 16:10:04 +02:00
Robert Schulze
1de5e9a7da
Avoid copy-ing array elements 2022-07-07 12:33:34 +00:00
Alexander Tokmakov
fdd2db4ace
Move check for denied allocations (#38858)
* move check for denied allocations

* remove include

* make hardening softer
2022-07-07 14:24:36 +02:00
alesapin
1bd97fa6fa
Merge pull request #38851 from Algunenano/rmarin_read_only_on_drop
Deactivate mutations_finalizing_task during shutdown
2022-07-07 12:55:50 +02:00
Kruglov Pavel
7c60714b4b
Merge pull request #38841 from lokax/isnullable
feat(Function): add isNullable function
2022-07-07 11:49:45 +02:00
Vitaly Baranov
5dcc271856 More careful destructors. 2022-07-07 11:16:44 +02:00
Nikolay Degterinsky
fcb6cfb6df Fix style issues 2022-07-07 08:31:55 +00:00
Nikolay Degterinsky
1869b7f408 Add functions translate & translateUTF8 2022-07-07 08:25:00 +00:00
Vladimir Galunshchikov
cacc833da6 Rename NUMBER_OF_DIMENSIONS_MISMATHED const to NUMBER_OF_DIMENSIONS_MISMATCHED 2022-07-07 11:15:59 +03:00
Igor Nikonov
fa0d54a3b2 Merge remote-tracking branch 'origin/master' into order_by_with_braces 2022-07-07 08:13:49 +00:00
Igor Nikonov
01bbfd86ad
Merge pull request #38910 from ClickHouse/explain_ast_after_rewrite
EXPLAIN AST rewrite option
2022-07-07 10:09:55 +02:00
lingpeng0314
079d4bd0dd rename keeper_4lw_info to keeper_info
- to make clang build successfully
2022-07-07 15:13:51 +08:00
Alexey Milovidov
02adad3f27
Merge pull request #37860 from amosbird/remove-duplicated-log
Remove duplicate peak mem log
2022-07-07 08:16:06 +03:00
Vladimir Chebotarev
367008b7fb Better objects removal in S3ObjectStorage. 2022-07-07 06:44:43 +03:00
Nikolay Degterinsky
573b81965a Fix style 2022-07-07 02:20:25 +00:00
Nikolay Degterinsky
0c783800c8 Better 2022-07-07 01:47:33 +00:00
Vitaly Baranov
ed27987646
Merge pull request #38861 from vitlibar/backup-improvements-9
Backup Improvements 9
2022-07-07 02:24:47 +02:00
Yakov Olkhovskiy
48c8bc3da9
Merge pull request #38896 from Algunenano/fix_seconds
Fix settings profile with seconds unit
2022-07-06 19:05:13 -04:00
Igor Nikonov
6be6a13c2f
Merge branch 'master' into order_by_with_braces 2022-07-07 00:36:12 +02:00
Igor Nikonov
77317c65fd
Merge pull request #38902 from ClickHouse/interpreter_cleanup_2
Interpreter cleanup: ContextPtr -> const ContextPtr & in parameters
2022-07-06 23:46:55 +02:00
Robert Schulze
dec184f61d
Add comment about const needle + const haystack 2022-07-06 17:41:15 +00:00
Igor Nikonov
810926c7fc Rename setting after_rewrite -> rewrite 2022-07-06 17:29:30 +00:00
vdimir
b27d3ec5ce
Fix build 2022-07-06 15:11:23 +00:00
Robert Schulze
8a18705729
More variable renamings for more uniformity 2022-07-06 14:55:02 +00:00
Robert Schulze
0b0d64c5ca
Don't resize output vector in each loop iteration 2022-07-06 14:45:22 +00:00
Robert Schulze
144c1edb03
Inherit default implementation of getArgumentsThatAreAlwaysConstant() 2022-07-06 14:42:19 +00:00
mergify[bot]
8cc2c3914b
Merge branch 'master' into isnullable 2022-07-06 14:40:01 +00:00
Robert Schulze
6a907b23fb
Replace typeid_cast() with checkAndGetColumnConst()
... syntactic sugar
2022-07-06 14:38:28 +00:00
Vitaly Baranov
7f84cf3968 Fix style. 2022-07-06 16:36:59 +02:00
Robert Schulze
0c4da85e75
More uniform naming 2022-07-06 14:29:42 +00:00
vdimir
2fd229448c
Fix style FullSortingMergeJoin.h 2022-07-06 14:28:06 +00:00