Commit Graph

7789 Commits

Author SHA1 Message Date
Azat Khuzhin
dee435f8f4 Add a test for data-race in CreatingSetsTransform
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-08 21:45:44 +02:00
Azat Khuzhin
2a27a8b0bf tests/test_throttling: check the maximum execution time as well
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-08 07:31:33 +02:00
Azat Khuzhin
c883da2b26 tests/test_throttling: adjust delays due to HTTPS usage
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-08 07:31:33 +02:00
Azat Khuzhin
9c8096455e tests: switch test_throttling to S3 over https to make it more production like
One interesting thing about S3 C++ SDK is that it can read file multiple
times for calculating checksums and signature, but the last is not done
for the https protocol, though the checksum "could".

And indeed it does, since default checksum algorithm (MD5) does not
support streaming, and so it always calculated, regardless of the
protocol, however everything else (CRC*/SHA*) supports streamming and
actually will not be calculated for https at all!

This will be fixed in the follow up patch.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-08 07:31:33 +02:00
Azat Khuzhin
4179ff7111 Adjust the test_storage_delta::test_multiple_log_files after MinIO upgrade
After upgrade MinIO stopped handling of objects with leading slash:

    (Pdb) p minio_client.fput_object(bucket_name='root', object_name='/test_multiple_log_files/_delta_log/00000000000000000001.json', file_path='/test_multiple_log_files/_delta_log/00000000000000000001.json').http_headers
    HTTPHeaderDict({'Accept-Ranges': 'bytes', 'Content-Length': '0', 'ETag': '"f1f3276c787b3f6724b9a8edb313c4fa"', 'Server': 'MinIO', 'Strict-Transport-Security': 'max-age=31536000; includeSubDomains', 'Vary': 'Origin, Accept-Encoding', 'X-Amz-Id-2': '7987905dee74cdeb212432486a178e511309594cee7cb75f892cd53e35f09ea4', 'X-Amz-Request-Id': '178B9B0904A9640D', 'X-Content-Type-Options': 'nosniff', 'X-Xss-Protection': '1; mode=block', 'Date': 'Fri, 06 Oct 2023 19:22:27 GMT'})
    (Pdb) p list(minio_client.list_objects('root', '/test_multiple_log_files/_delta_log/'))
    []
    (Pdb) p minio_client.get_object(bucket_name='root', object_name='/test_multiple_log_files/_delta_log/00000000000000000001.json').read()
    b'{"commitInfo":{"timestamp":1696618985577,"operation":"WRITE","operationParameters":{"mode":"Overwrite","partitionBy":"[]"},"readVersion":0,"isolationLevel":"Serializable","isBlindAppend":false,"operationMetrics":{"numFiles":"1","numOutputRows":"100","numOutputBytes":"2459"},"engineInfo":"Apache-Spark/3.3.2 Delta-Lake/2.3.0","txnId":"2a69a4c9-f72e-4ac9-9374-bdff96707edf"}}\n{"add":{"path":"part-00000-9ff4728b-d5fe-49ac-a773-e2d6e01f4139-c000.parquet","partitionValues":{},"size":2459,"modificationTime":1696618985310,"dataChange":true,"stats":"{\\"numRecords\\":100,\\"minValues\\":{\\"col-ab7641d2-f0a9-4ffb-ae37-27087d13dfc8\\":0,\\"col-6cbfced4-5921-4e3b-9226-558171c11949\\":\\"1\\"},\\"maxValues\\":{\\"col-ab7641d2-f0a9-4ffb-ae37-27087d13dfc8\\":99,\\"col-6cbfced4-5921-4e3b-9226-558171c11949\\":\\"99\\"},\\"nullCount\\":{\\"col-ab7641d2-f0a9-4ffb-ae37-27087d13dfc8\\":0,\\"col-6cbfced4-5921-4e3b-9226-558171c11949\\":0}}"}}\n{"remove":{"path":"part-00000-7c29f5d9-e14d-419a-a273-58d07775e1e9-c000.parquet","deletionTimestamp":1696618985576,"dataChange":true,"extendedFileMetadata":true,"partitionValues":{},"size":2459}}\n'
    (Pdb) p list(minio_client.list_objects(bucket_name='root', prefix='test_multiple_log_files/', recursive=True))
    [<minio.datatypes.Object object at 0x7ffff1ec2fe0>, <minio.datatypes.Object object at 0x7ffff1ec39d0>, <minio.datatypes.Object object at 0x7ffff1ec2590>, <minio.datatypes.Object object at 0x7ffff1ec3dc0>, <minio.datatypes.Object object at 0x7ffff1ec3a00>, <minio.datatypes.Object object at 0x7ffff1ec3fa0>, <minio.datatypes.Object object at 0x7ffff1ec3f40>, <minio.datatypes.Object object at 0x7ffff1ec2770>]

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-08 07:30:13 +02:00
Alexey Milovidov
b38d4b5b0f
Merge pull request #55119 from jmaicher/fix/54318/deadlock-ldap-role-update
Fix deadlock in LDAP assigned role update
2023-10-08 00:38:10 +02:00
alesapin
ec69b28386 Black 2023-10-07 21:18:54 +02:00
alesapin
77d96e67d1 Merge branch 'fix_redundant_check' of github.com:ClickHouse/ClickHouse into fix_redundant_check 2023-10-07 21:18:39 +02:00
alesapin
aa130b74e5 Fix offsets bug 2023-10-07 21:18:23 +02:00
robot-clickhouse
041a9c8180 Automatic style fix 2023-10-07 17:27:42 +00:00
alesapin
eec64ba1d9 Fix bug with inability to drop detached partition in replicated merge tree on top of S3 without zero copy 2023-10-07 19:09:47 +02:00
JackyWoo
784fe880eb Merge branch 'master' into lb_nearest_host_name 2023-10-07 09:04:26 +08:00
Arthur Passos
5e158f8a7d fix black 2023-10-04 10:57:38 -03:00
Arthur Passos
c904cd42e4 add back import os 2023-10-04 10:27:28 -03:00
Arthur Passos
fec4c392af opsy 2023-10-03 14:22:25 -03:00
Arthur Passos
3412dc89c6 rename setting 2023-10-03 13:53:38 -03:00
Arthur Passos
032a74ec3a make sure instance env variables override global ones 2023-10-03 10:33:55 -03:00
Arthur Passos
9695bf5db9 Revert "rename setting"
This reverts commit 0b97cd49e8.
2023-10-02 18:26:31 -03:00
Arthur Passos
0b97cd49e8 rename setting 2023-10-02 18:21:20 -03:00
Arthur Passos
3813e59b49 minor 2023-10-02 18:19:41 -03:00
Arthur Passos
e74e7ae19a more docs 2023-10-02 16:09:35 -03:00
Arthur Passos
23074c2c03 add comment 2023-10-02 16:04:02 -03:00
Arthur Passos
5eda3dfc39 add exclusive_environment_variables option to inte gtests 2023-10-02 15:59:15 -03:00
Alexey Milovidov
9200b121ac
Merge pull request #55189 from ClickHouse/remove-meilisearch
Remove Meilisearch
2023-10-01 01:57:04 +03:00
Alexey Milovidov
5ef68f0b36 Fix integration test 2023-09-30 23:03:35 +02:00
Julian Maicher
7db4023928 style: Apply black formatter 2023-09-30 07:04:05 +02:00
Julian Maicher
19f8f365b2 test: Add IT that reproduces deadlock 2023-09-30 07:03:25 +02:00
Alexey Milovidov
180562adfb
Merge pull request #55132 from ClickHouse/fix_deadlock_backups
Fix deadlock in backups
2023-09-30 07:20:19 +03:00
Alexey Milovidov
5ebd8ef41d Remove Meilisearch 2023-09-30 06:02:38 +02:00
Alexey Milovidov
d8b5713023 Remove the removal of broken detached parts 2023-09-30 01:47:44 +02:00
alesapin
54c48df486 Fix test 2023-09-29 14:03:58 +02:00
Nikolai Kochetov
8468e90a01
Merge pull request #55105 from ClickHouse/split-compatibility-tests
Clean data dir and always start an old server version in aggregate functions compatibility test.
2023-09-29 13:47:14 +02:00
Alexey Milovidov
8f9a227de1
Merge pull request #54931 from yariks5s/s3_style_url
s3-style URL fix
2023-09-29 07:12:01 +03:00
Nikolay Degterinsky
6539d52b9e
Merge pull request #50372 from helifu/master3
Support dynamic adjustment of log level in Keeper
2023-09-28 23:47:49 +02:00
Sema Checherinda
f73eef9ed8
Merge pull request #54697 from CheSema/s3_retry_cancelation_point
add cancelation point to s3 retries
2023-09-28 19:01:09 +02:00
robot-clickhouse
87e434304c Automatic style fix 2023-09-28 15:47:24 +00:00
Nikolai Kochetov
1326d9935f Clean data dir and always start an old server version in aggregate functions compatibility test. 2023-09-28 15:28:26 +00:00
yariks5s
ad94e08b0b made using macroses 2023-09-28 15:17:15 +00:00
Igor Nikonov
6132382044
Merge pull request #54987 from ClickHouse/fix-test-parallel-replicas-over-distributed
Fix test parallel replicas over distributed
2023-09-28 14:20:57 +02:00
Vitaly Baranov
22cdc012d1 Add test cases. 2023-09-28 13:02:07 +02:00
Sema Checherinda
013a44db94 style fix 2023-09-28 00:15:14 +02:00
Sema Checherinda
e629a17218 add cancelation point to s3 retries 2023-09-28 00:15:06 +02:00
yariks5s
d94e989391 black check 2023-09-27 20:27:48 +00:00
yariks5s
adf1af63a5 added tests, moved domains to config 2023-09-27 18:53:05 +00:00
robot-clickhouse-ci-1
7a825c1417
Merge pull request #54427 from Avogar/json-object-as-tuple-inference
Add new features to schema inference for JSON formats
2023-09-27 20:12:45 +02:00
JackyWoo
f3bf1f8da9 Fix code style 2023-09-27 12:56:06 +08:00
JackyWoo
5da03e8ba5 Add load balancing test_hostname_levenshtein_distance 2023-09-27 10:46:39 +08:00
Alexey Milovidov
9518f68683
Merge pull request #54976 from vitlibar/use-pregenerated-grpc-protocol-pb2
Use pregenerated gRPC protocol pb2 files to fix test flakyness.
2023-09-26 23:09:34 +03:00
Alexey Milovidov
29d3b34dfc
Merge pull request #54090 from ClickHouse/remove-current-status
Remove CurrentStatusInfo
2023-09-26 21:38:07 +03:00
George Gamezardashvili
0ce30ab6d5
SSH keys authentication (#41109)
Added new type of authentication based on SSH keys. It works only for Native TCP protocol.

Co-authored-by: Nikita Mikhaylov <nikitamikhaylov@clickhouse.com>
Co-authored-by: Robert Schulze <robert@clickhouse.com>
2023-09-26 17:50:19 +02:00
Vitaly Baranov
d39bd7154f Use pregenerated gRPC protocol pb2 files to fix test flakyness. 2023-09-26 17:28:19 +02:00
Antonio Andelic
e7c8363f6f
Merge pull request #48855 from ClickHouse/keeper-operation-create-if-not-exists
Implement `createIfNotExists` in Keeper natively
2023-09-26 16:04:51 +02:00
Kruglov Pavel
bea80ab5b7
Merge branch 'master' into json-object-as-tuple-inference 2023-09-26 15:23:08 +02:00
János Benjamin Antal
6d254aa557 Remove tests 2023-09-26 09:02:12 +00:00
avogar
6dcaa387b1 Fix style 2023-09-25 22:15:41 +00:00
avogar
cabb3ddaae Fix tests 2023-09-25 21:45:11 +00:00
Kruglov Pavel
92de61ca5b Use less attempts 2023-09-25 21:04:12 +02:00
avogar
4fb12f8703 Add retries to rests test_async_query_sending/test_async_connect 2023-09-25 21:04:12 +02:00
Anton Popov
0ebc22e851
Merge branch 'master' into long-column-names 2023-09-25 16:55:14 +02:00
Igor Nikonov
5a62f4cb99 Merge remote-tracking branch 'origin/master' into fix-test-parallel-replicas-over-distributed 2023-09-25 12:22:35 +00:00
Igor Nikonov
9a788c3cac Fix: sync replicas to get consisten result 2023-09-25 12:21:12 +00:00
alesapin
75b2f90923
Merge pull request #54772 from Avogar/less-flaky-async-tests
Add retries to rests test_async_query_sending/test_async_connect
2023-09-25 12:05:11 +02:00
Alexey Milovidov
580f3c1a01 Merge branch 'master' into remove-current-status 2023-09-24 20:56:17 +02:00
Alexey Milovidov
664ac27cf2
Merge pull request #54507 from ClickHouse/flush-logs-for-system-backup-logs-test
Flush logs for system.backup_log test.
2023-09-23 22:33:21 +03:00
Alexander Tokmakov
21ffbd88de
Merge pull request #54859 from ClickHouse/fix_zero_copy_locks
Fix zero copy locks with hardlinks
2023-09-22 18:27:03 +02:00
Antonio Andelic
176baa6695 Merge branch 'master' into keeper-operation-create-if-not-exists 2023-09-22 13:47:30 +00:00
Vitaly Baranov
3a2ca1f69c
Merge pull request #51261 from evillique/users-valid-until
Add VALID UNTIL clause for users
2023-09-22 12:38:30 +02:00
Antonio Andelic
316f42def6
Merge pull request #54745 from ClickHouse/keeper-reduce-batch-size
Revert default batch size for Keeper
2023-09-21 17:44:33 +02:00
Pavel Novitskiy
853e3f0aa7
Add drop table IF EMPTY (#48915) 2023-09-21 09:20:18 -04:00
Antonio Andelic
13815a96bf
Fix test 2023-09-21 09:07:40 +02:00
Alexander Tokmakov
ec80068611 add a test for no such key 2023-09-20 22:37:24 +02:00
Nikolai Kochetov
2dc2b2050e
Update test.py 2023-09-20 17:16:50 +02:00
Antonio Andelic
b65b1ee97b Merge branch 'master' into keeper-operation-create-if-not-exists 2023-09-20 13:56:36 +00:00
Alexey Milovidov
d31a6f253e
Merge pull request #54816 from azat/tests/fix-test_backup_restore_on_cluster
Fix test_backup_restore_on_cluster/test.py::test_stop_other_host_during_backup flakiness
2023-09-20 13:30:19 +03:00
alesapin
2ff36b6e0c
Merge pull request #54768 from ClickHouse/better_exception_in_check_data_part
Better exception message in checkDataPart
2023-09-20 12:04:46 +02:00
Azat Khuzhin
56dca144cc Fix test_backup_restore_on_cluster/test.py::test_stop_other_host_during_backup flakiness
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-09-20 07:09:51 +02:00
alesapin
accbe24e08 Fix test 2023-09-19 18:42:46 +02:00
Kruglov Pavel
a02b6d03d7
Use less attempts 2023-09-19 13:32:49 +02:00
Anton Popov
624782bd8f Merge remote-tracking branch 'upstream/master' into HEAD 2023-09-18 23:13:20 +00:00
avogar
838668e9df Add retries to rests test_async_query_sending/test_async_connect 2023-09-18 19:35:08 +00:00
robot-clickhouse
ca64e26994 Automatic style fix 2023-09-18 11:28:36 +00:00
Antonio Andelic
69333912d5 Merge branch 'master' into keeper-operation-create-if-not-exists 2023-09-18 10:57:11 +00:00
Igor Nikonov
fae229e3ea Merge remote-tracking branch 'origin/master' into pr-distributed-prefer-localhost-replica 2023-09-17 21:03:56 +00:00
robot-ch-test-poll1
a2ed5c2cae
Merge pull request #54174 from ClickHouse/vdimir/fix_hostname_const
Fix hostname and co result constness in new analyzer
2023-09-16 19:37:08 +02:00
robot-clickhouse
66c2ac9364 Automatic style fix 2023-09-16 00:32:32 +00:00
János Benjamin Antal
d975ee7608 Fix argument parsing bug 2023-09-16 00:07:54 +00:00
János Benjamin Antal
16e2f7f0b9 Add optional version argument to rm 2023-09-16 00:03:46 +00:00
Kruglov Pavel
8d01137d73
Merge pull request #54498 from bakam412/bugfix/local_multiquery_parameter
Bugfix/local multiquery parameter
2023-09-15 11:46:08 +02:00
vdimir
1aa18e0eb6
Analyzer: Remove constants from header in StorageDistributed 2023-09-14 16:44:18 +00:00
Kseniia Sumarokova
eeb2c5b223
Merge pull request #53220 from valbok/double-to-single
MaterializedMySQL: Introduce Character Set Introducers
2023-09-14 13:18:08 +02:00
Robert Schulze
a9ae813db0
Merge pull request #54115 from slvrtrn/simplified-prepared-statements-for-mysql
Implement the MySQL binary protocol implementation for initial support of Tableau Online
2023-09-14 12:27:11 +02:00
Antonio Andelic
6306180333
Merge pull request #53049 from ClickHouse/keeper-batch-flushes
Try batching multiple flush requests in Keeper
2023-09-14 11:39:33 +02:00
Val Doroshchuk
6cfbaf9f86 MaterializedMySQL: Introduce Character Set Introducers
If some string literals are used in DDL, they might have `Character Set Introducers`
https://dev.mysql.com/doc/refman/8.0/en/charset-introducer.html
f.e. _utf8mb4'1' which is not parsable by current ParserStringLiteral.

Since we use utf8 by default, suggesting to automatically convert the string literals to utf8
before executing the query and avoid any charset introducers there.
Conversion from utf8 to utf8 is not needed and skipped.

Also it might convert double quotes to single quotes if any
which might solve issues with COMMENT and empty string literals "" in DEFAULT expressions.

SELECT _latin1"abc"; -- might be also valid for MySQL
... DEFAULT "",
... COMMENT "abc"

Currently no DEFAULT expressions are supported, not parsable at all,
but using this MR it allows to parse the expressions together with double quotes as string literals.
2023-09-14 08:24:25 +02:00
bakam412
c5c3833a80 fix tests 2023-09-14 11:12:44 +08:00
slvrtrn
44e1f6b53d Fix LowCardinality/Nullable columns issues 2023-09-13 23:40:31 +02:00
slvrtrn
c0961d9378 Merge remote-tracking branch 'origin' into simplified-prepared-statements-for-mysql 2023-09-13 19:33:11 +02:00
Nikolay Degterinsky
0998b0bbc7 Fixes 2023-09-13 03:14:02 +00:00
Nikolay Degterinsky
268c45d900 Merge remote-tracking branch 'upstream/master' into users-valid-until 2023-09-12 23:44:22 +00:00
pufit
85b23e9403 Increase default timeout in tests for keeper-client 2023-09-12 14:06:57 -04:00
slvrtrn
dddea9219a Address the review comments 2023-09-12 18:39:03 +02:00