Right now there are couple of gdb bugs that makes CI unstable:
- https://sourceware.org/bugzilla/show_bug.cgi?id=29185
- https://bugzilla.redhat.com/show_bug.cgi?id=1492496
But ubuntu 22.04 does not have 14+ anywhere, the
~ubuntu-toolchain-r/test contains only gdb 13, so there is no other
options except for compiling it from sources.
But there also other reasons to update it - optimizations, looks like
older gdb versions does not use index fully - 5.6sec vs 56sec:
# 15.1
$ time command gdb -batch -ex 'disas main' clickhouse
...
real 0m5.692s
user 0m29.948s
sys 0m1.190s
# 12.1 (from ubuntu 22.04)
real 0m56.709s
user 0m59.307s
sys 0m0.585s
Also note, that we cannot compile gdb in the fasttest (that contains
compiler) since some images does not includes full toolchain, for
instance gdb is added in the following images:
- test-util -> test-base -> lots of other images (no toolchain)
- performance-comparison (no toolchain)
- integration-test (no toolchain)
- integration-tests-runner (no toolchain)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Right now, if you will start keeper like this:
$ cat /tmp/local.yaml
---
logger:
log:
"@remove": remove
errorlog:
"@remove": remove
console: 1
$ docker run --name keeper -v /tmp/local.yaml:/etc/clickhouse-keeper/conf.d/local.yaml --rm -it clickhouse/clickhouse-keeper
This will still not work, because the --log-file/--errorlog-file passed
explicitly.
So this patch removes this in case config is valid, but, if keeper is
launched with embedded config, this had been left as-is, to keep
previous behavior.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Right now it simply does not work due to "set -e", with it you cannot
use "foo=$(false)" since bash will break execution after, rewrite it to
a plain shell, with "if".
Also use ZSTD everywhere (ugh)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Since you don't want to fallback to addr2line:
# addr2line
$ time /bin/test
set_flag_impl: Success
set_flag_if: Success
/usr/bin/addr2line: DWARF error: invalid or unhandled FORM value: 0x23
==================
WARNING: ThreadSanitizer: data race (pid=18)
...
real 3m8.580s
user 0m21.967s
sys 0m40.628s
# llvm-symbolizer
$ time ./test
set_flag_impl: Success
set_flag_if: Success
==================
WARNING: ThreadSanitizer: data race (pid=24884)
real 0m0.028s
user 0m0.003s
sys 0m0.006s
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
