Commit Graph

7947 Commits

Author SHA1 Message Date
Antonio Andelic
5364f4e9f8 Fix test 2023-11-10 09:59:43 +00:00
Mike Kot
785183bb3c Keeper reconfig -- sleep before removing leader to avoid losing accepted
but uncommitted commands
2023-11-09 16:22:44 +00:00
Antonio Andelic
e9542e4153
Merge pull request #54957 from ClickHouse/49507_Support_compression_for_keeper_protocol
Support compression for keeper protocol
2023-11-09 10:00:19 +01:00
Alexander Tokmakov
32567e16e7
Merge pull request #56429 from ClickHouse/tavplubix-patch-9
Fix `test_attach_without_fetching`
2023-11-08 14:37:15 +01:00
Sema Checherinda
2ffd51fb36
Merge pull request #56421 from CheSema/move-to-server-settings
move storage_metadata_write_full_object_key setting to the server scope
2023-11-08 11:06:39 +01:00
Antonio Andelic
788c66027c
Merge pull request #56104 from incfly/keeper-az
Add /keeper/availability-zone node to allow server load balancing within AZ.
2023-11-08 09:46:24 +01:00
Alexander Tokmakov
fc1bd0efd5
Update test.py 2023-11-07 19:44:16 +01:00
Sema Checherinda
8216a24abe move storage_metadata_write_full_object_key setting to the server scope 2023-11-07 17:14:46 +01:00
Kseniia Sumarokova
cc3144ea2d
Merge pull request #56370 from ClickHouse/kssenii-patch-6
Update test_storage_s3_queue/test.py
2023-11-07 16:29:34 +01:00
Kseniia Sumarokova
d436414ec6
Merge pull request #56376 from ClickHouse/disable-s3-queue-test-for-ordered-mode
Update test_storage_s3_queue
2023-11-07 16:27:52 +01:00
Pradeep Chhetri
361472b29e Add 4-letter command for yielding/resigning leadership 2023-11-07 13:58:45 +08:00
Jianfei Hu
033bb19198 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into keeper-az 2023-11-07 02:50:54 +00:00
Jianfei Hu
b552bf6928 fix the test node count.
Signed-off-by: Jianfei Hu <hujianfei258@gmail.com>
2023-11-07 02:50:46 +00:00
Alexander Tokmakov
cf6ab2e110
Merge pull request #56282 from ClickHouse/fix_unexpected_parts_after_truncate
Fix unexpected parts after drop range
2023-11-06 21:03:57 +01:00
Sema Checherinda
a5e17dc919
Merge pull request #55566 from CheSema/remote-blobs-naming
feature: storage_metadata_write_full_object_key
2023-11-06 16:41:49 +01:00
kssenii
3ecce143fc Restrict modes for the test 2023-11-06 14:44:24 +01:00
Kseniia Sumarokova
036922e3b4
Update test.py 2023-11-06 12:21:13 +01:00
Sema Checherinda
cf07fd79fc remove unstable test 2023-11-06 12:00:23 +01:00
Alexander Tokmakov
155bdfcf0d fix 2023-11-04 22:50:19 +01:00
Arthur Passos
b6e205dcdf
Add ClickHouse setting to disable tunneling for HTTPS requests over HTTP proxy (#55033)
* initial commit. integ tests passing, need to re-run unit & my own personal tests

* partial refactoring to remove Protocol::ANY

* improve naming

* remove all usages of ProxyConfiguration::Protocol::ANY

* fix ut

* blabla

* support url functions as well

* support for HTTPS requests over HTTP proxy with tunneling off

* remove gtestabc

* fix silly mistake

* ...

* remove usages of httpclientsession::proxyconfig in src/

* got you

* remove stale comment

* it seems like I need reasonable defaults

* fix ut

* add some comments

* remove no longer needed header

* matrix out

* add https over http proxy with no tunneling

* soem docs

* partial refactoring

* rename to use_tunneling_for_https_requests_over_http_proxy

* improve docs

* use shorter version

* remove useless test

* rename the setting

* update

* fix typo

* fix setting docs typo

* move ); up

* move ) up
2023-11-04 13:47:52 -04:00
robot-clickhouse
6ad8e789f6 Automatic style fix 2023-11-04 14:56:15 +00:00
Alexander Tokmakov
9acd3707cb fix tests 2023-11-04 15:44:55 +01:00
Jianfei Hu
b426cfe462 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into keeper-az
Signed-off-by: Jianfei Hu <hujianfei258@gmail.com>
2023-11-03 16:42:29 +00:00
vdimir
a70d0c5203
Merge pull request #56264 from azat/rocksdb/block-based-table-options
Add ability to specify BlockBasedTableOptions for rocksdb
2023-11-03 10:15:19 +01:00
vdimir
55a1baf029
Merge pull request #56022 from ClickHouse/vdimir/check_all_tables
Add CHECK query for all the tables
2023-11-03 10:10:42 +01:00
Jianfei Hu
136efba321 integration test working and std::exception_ptr.
Signed-off-by: Jianfei Hu <hujianfei258@gmail.com>
2023-11-03 02:24:42 +00:00
Alexander Tokmakov
e88fa10aa2
Merge pull request #56142 from ClickHouse/make_replicated_start_more_robust
Better process broken parts on table start for replicated tables
2023-11-02 20:11:22 +01:00
Jianfei Hu
06ff714e2e add configuration option and integration test(wip).
Signed-off-by: Jianfei Hu <hujianfei258@gmail.com>
2023-11-02 16:21:24 +00:00
Alexander Tokmakov
76e6b75ae2
Merge pull request #56214 from ClickHouse/hide-setup-plan
Improve integrations tests
2023-11-02 16:59:40 +01:00
Azat Khuzhin
decf85baca Add ability to specify BlockBasedTableOptions for rocksdb
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-11-02 15:36:00 +01:00
Sema Checherinda
90b64bcdb9 backward compatibility and implementation feature storage_metadata_write_full_object_key 2023-11-02 15:20:55 +01:00
Raúl Marín
39163b4e31
Merge pull request #56175 from amosbird/fix-flaky-jbod-balancer
Fix flaky test of jbod balancer.
2023-11-02 13:19:21 +01:00
Mikhail f. Shiryaev
28463cdcd3
Do not print --setup-plan to integration tests logs 2023-11-02 08:50:03 +01:00
Alexander Sapin
abc1dfc203 Fix test 2023-11-01 20:38:09 +01:00
Amos Bird
aea0c8dddc
Add wait_until_fully_merged. 2023-11-02 01:50:09 +08:00
robot-clickhouse
2a24d15204 Automatic style fix 2023-11-01 16:06:24 +00:00
Alexander Sapin
bfcd8b7de5 Better logging and tests 2023-11-01 16:50:02 +01:00
Azat Khuzhin
c25d6cd624
Rename directory monitor concept into background INSERT (#55978)
* Limit log frequence for "Skipping send data over distributed table" message

After SYSTEM STOP DISTRIBUTED SENDS it will constantly print this
message.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

* Rename directory monitor concept into async INSERT

Rename the following query settings (with preserving backward
compatiblity, by keeping old name as an alias):
- distributed_directory_monitor_sleep_time_ms -> distributed_async_insert_sleep_time_ms
- distributed_directory_monitor_max_sleep_time_ms -> distributed_async_insert_max_sleep_time_ms
- distributed_directory_monitor_batch -> distributed_async_insert_batch_inserts
- distributed_directory_monitor_split_batch_on_failure -> distributed_async_insert_split_batch_on_failure

Rename the following table settings (with preserving backward
compatiblity, by keeping old name as an alias):
- monitor_batch_inserts -> async_insert_batch
- monitor_split_batch_on_failure -> async_insert_split_batch_on_failure
- directory_monitor_sleep_time_ms -> async_insert_sleep_time_ms
- directory_monitor_max_sleep_time_ms -> async_insert_max_sleep_time_ms

And also update all the references:

    $ gg -e directory_monitor_ -e monitor_ tests docs | cut -d: -f1 | sort -u | xargs sed -e 's/distributed_directory_monitor_sleep_time_ms/distributed_async_insert_sleep_time_ms/g' -e 's/distributed_directory_monitor_max_sleep_time_ms/distributed_async_insert_max_sleep_time_ms/g' -e 's/distributed_directory_monitor_batch_inserts/distributed_async_insert_batch/g' -e 's/distributed_directory_monitor_split_batch_on_failure/distributed_async_insert_split_batch_on_failure/g' -e 's/monitor_batch_inserts/async_insert_batch/g' -e 's/monitor_split_batch_on_failure/async_insert_split_batch_on_failure/g' -e 's/monitor_sleep_time_ms/async_insert_sleep_time_ms/g' -e 's/monitor_max_sleep_time_ms/async_insert_max_sleep_time_ms/g' -i

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

* Rename async_insert for Distributed into background_insert

This will avoid amigibuity between general async INSERT's and INSERT
into Distributed, which are indeed background, so new term express it
even better.

Mostly done with:

    $ git di HEAD^ --name-only | xargs sed -i -e 's/distributed_async_insert/distributed_background_insert/g' -e 's/async_insert_batch/background_insert_batch/g' -e 's/async_insert_split_batch_on_failure/background_insert_split_batch_on_failure/g' -e 's/async_insert_sleep_time_ms/background_insert_sleep_time_ms/g' -e 's/async_insert_max_sleep_time_ms/background_insert_max_sleep_time_ms/g'

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

* Mark 02417_opentelemetry_insert_on_distributed_table as long

CI: https://s3.amazonaws.com/clickhouse-test-reports/55978/7a6abb03a0b507e29e999cb7e04f246a119c6f28/stateless_tests_flaky_check__asan_.html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

---------

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-11-01 15:09:39 +01:00
Kruglov Pavel
5533258091
Merge pull request #55477 from Avogar/streaming-errors
Allow to save unparsed records and errors in RabbitMQ, NATS and FileLog engines
2023-11-01 14:35:35 +01:00
Amos Bird
c75cd615c3
Fix flaky test of jbod balancer. 2023-10-31 23:03:55 +08:00
Kseniia Sumarokova
b57906609c
Merge pull request #56011 from kssenii/fix-flaky-s3-queue-test
test_storage_s3_queue - add debug info
2023-10-31 11:25:02 +01:00
Smita Kulkarni
3fdf0daf1b Merge branch 'master' into 49507_Support_compression_for_keeper_protocol 2023-10-31 10:43:28 +01:00
Kruglov Pavel
50c53fdbfd
Increase number of attempts in test 2023-10-30 20:51:03 +01:00
Raúl Marín
19c2ad5c9b
Merge pull request #56116 from azat/tests/fix-test_format_schema_on_server
Fix test_format_schema_on_server flakiness
2023-10-30 12:02:14 +01:00
Kseniia Sumarokova
41e2111534
Merge branch 'master' into fix-flaky-s3-queue-test 2023-10-30 11:24:12 +01:00
Azat Khuzhin
b87ebb2a83 Fix test_format_schema_on_server flakiness
Sometimes the requests library detect the encoding incorrectly, and
because this test compares binary data it fails.

Here is an example of successfull attempt:

    2023-10-30 07:32:37 [ 654 ] DEBUG : http://172.16.1.2:8123 "GET /?query=SELECT+%2A+FROM+test.simple+FORMAT+Protobuf+SETTINGS+format_schema%3D%27simple%3AKeyValuePair%27 HTTP/1.1" 200 None (connectionpool.py:546, _make_request)
    2023-10-30 07:32:37 [ 654 ] DEBUG : Encoding detection: utf_8 will be used as a fallback match (api.py:480, from_bytes)
    2023-10-30 07:32:37 [ 654 ] DEBUG : Encoding detection: Found utf_8 as plausible (best-candidate) for content. With 0 alternatives. (api.py:487, from_bytes)

And here is failed [1]:

    2023-10-29 18:12:56 [ 525 ] DEBUG : http://172.16.9.2:8123 "GET /?query=SELECT+%2A+FROM+test.simple+FORMAT+Protobuf+SETTINGS+format_schema%3D%27message_tmp%3AMessageTmp%27 HTTP/1.1" 200 None (connectionpool.py:547, _make_request)
    2023-10-29 18:12:56 [ 525 ] DEBUG : Encoding detection: Found utf_16_be as plausible (best-candidate) for content. With 1 alternatives. (api.py:487, from_bytes)
    E       AssertionError: assert '܈Ē͡扣܈Ȓͤ敦' == '\x07\x08\x01\x12\x03abc\x07\x08\x02\x12\x03def'
    E         - abcdef
    E         + ܈Ē͡扣܈Ȓͤ敦

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/56030/c7f392500e93863638c9ca9bd56c93b3193091f3/integration_tests__release__[3_4].html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-30 08:45:47 +01:00
Azat Khuzhin
c7f392500e Fix incorrect free space accounting for least_used JBOD policy
Before least_used fails to detect when the disk started to have more
space, it works only when the disk starts to have less space.

The reason for this is that it uses priority_queue, and once the disk
goes at the bottom of the queue, free space will not be updated for it
until it will be selected again.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-29 17:36:31 +01:00
Alexey Milovidov
243499aad1
Merge pull request #55796 from ClickHouse/Fix_azurite_port
Fix azurite port issue
2023-10-28 00:40:24 +02:00
vdimir
60c93cefbe
Add test for CHECK ALL TABLES 2023-10-27 15:22:11 +00:00
Smita Kulkarni
960927a323 Updated name to use_compression 2023-10-27 14:53:54 +02:00