Robert Schulze
1be81db885
Fix build, pt. II
2023-04-05 11:23:09 +00:00
Robert Schulze
a59b53775c
Fix style
2023-04-05 10:43:55 +00:00
Sema Checherinda
f504cd5fed
avoid race, do not set thread_group.counters.parent from query
2023-04-05 12:36:55 +02:00
Igor Nikonov
f6c46153fb
Rename old_*_columns to input_*_columns
2023-04-05 10:22:26 +00:00
Igor Nikonov
47e7e19ca9
Move suffix generation code into one function
2023-04-05 10:12:42 +00:00
vdimir
bae1286b63
Update temp_data_on_disk in shared context
2023-04-05 10:07:44 +00:00
Kruglov Pavel
8bd997d680
Update docs/en/interfaces/formats.md
...
Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>
2023-04-05 11:57:41 +02:00
Kruglov Pavel
96a3307bda
Merge branch 'master' into fix-protobuf-abort
2023-04-05 11:57:18 +02:00
Kruglov Pavel
8d6b709f1a
Merge pull request #48257 from Avogar/capnp-more-types
...
Support more types in CapnProto format, allow integer conversions
2023-04-05 11:56:46 +02:00
avogar
f46f098c78
Better
2023-04-05 09:55:49 +00:00
Vladimir C
1f22fca3c3
Merge pull request #46428 from bigo-sg/quantile_gk
2023-04-05 11:25:48 +02:00
vdimir
7fe06f8435
Do not take lock for shared context in setTempDataOnDisk
2023-04-05 09:22:09 +00:00
Raúl Marín
2276d4feb4
Backups have no context and no process list element
2023-04-05 11:19:04 +02:00
Robert Schulze
0d5d2a9b55
Implement %f in parseDateTime()
...
Fixes : #48394
@cc OP
2023-04-05 09:13:18 +00:00
Antonio Andelic
f7586e38ed
Fix flaky test_keeper_snapshots
2023-04-05 08:56:01 +00:00
Azat Khuzhin
4008155a6e
Add max_ prefix for backup_bandwidth settings
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-05 10:54:25 +02:00
Robert Schulze
0a71656ee6
Fix build
2023-04-05 08:45:59 +00:00
Azat Khuzhin
8f06972dc5
Set index granularity settings for other two lightweight delete tests
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-05 10:35:11 +02:00
Azat Khuzhin
7f1569dd6e
Fix 02352_lightweight_delete flakiness (due to index granularity randomization)
...
CI: https://s3.amazonaws.com/clickhouse-test-reports/48242/c8da660d96bea153fa0c1dc8fbdb4a560e139a56/stateless_tests__debug__[4/5].html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-05 10:35:11 +02:00
Robert Schulze
598b050628
AST Fuzzer: Fix assertion in TopK serialization
...
Problem:
https://s3.amazonaws.com/clickhouse-test-reports/0/fa5b2bd4a5b02336bca8837c473a7124f8ecedf2/fuzzer_astfuzzerasan/report.html
The new assertion in the Varint code was introduced with (*). It rejects
values whose serialization cannot be deserialized (and this behavior
cannot be changed due to historical reasons). Such values should be
exceptionally rare in practice but AST fuzzer managers to trigger them.
The fix is similar to (**): Bypass the check by limiting the value to
the maximum allowed value.
(if AST fuzzer triggers finds more violations of the assertion, we might
consider throwing an exception instead)
(*) https://github.com/ClickHouse/ClickHouse/pull/48154
(**) https://github.com/ClickHouse/ClickHouse/pull/48154/files#diff-653c0a18dfdaa86262c78dc6b25550add0487f165b4ad053e86f530388f6203a
2023-04-05 08:07:37 +00:00
Antonio Andelic
e428ed5543
Merge pull request #48384 from ClickHouse/less-flaky-keeper-test
...
Fix flaky `test_keeper_mntr_data_size`
2023-04-05 09:59:28 +02:00
Azat Khuzhin
f0f58de79c
Remove throttler for IDisk::copyFile()
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-05 09:41:27 +02:00
Azat Khuzhin
dd9f0f409b
Remove knowledge about throttling from IBackupWriter::supportNativeCopy()
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-05 09:40:19 +02:00
Azat Khuzhin
c8597fbb9a
Do not throttle S3-S3 backups if native copy is possible
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-05 09:40:18 +02:00
Azat Khuzhin
61405b827d
Use MAKE_DEPRECATED_BY_SERVER_CONFIG() for deprecated throttle settings
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-05 09:40:18 +02:00
Azat Khuzhin
684ecc24e2
Ignore deprecated values max_remote_{read,write}_network_bandwidth_for_server
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-05 09:40:18 +02:00
Azat Khuzhin
ad96d3c249
Do not require proper Poco Application for Context
...
$ yes | head | clickhouse-obfuscator --structure 'id String' --seed foo --input-format TSV --output-format TSV
Poco::Exception. Code: 1000, e.code() = 0, Null pointer: _pInstance in file "/src/ch/clickhouse/base/poco/Util/include/Poco/Util/Application.h", line 446, Stack trace (when copying this message, always include the lines below):
0. /src/ch/clickhouse/contrib/llvm-project/libcxx/include/exception:134: std::exception::capture() @ 0x15605622 in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
1. /src/ch/clickhouse/contrib/llvm-project/libcxx/include/exception:112: std::exception::exception[abi:v15000]() @ 0x156055ed in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
2. /src/ch/clickhouse/base/poco/Foundation/src/Exception.cpp:27: Poco::Exception::Exception(String const&, int) @ 0x2ebd2d80 in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
3. /src/ch/clickhouse/base/poco/Foundation/src/Exception.cpp:132: Poco::LogicException::LogicException(String const&, int) @ 0x2ebd3667 in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
4. /src/ch/clickhouse/base/poco/Foundation/src/Exception.cpp:134: Poco::NullPointerException::NullPointerException(String const&, int) @ 0x2ebd3da7 in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
5. /src/ch/clickhouse/base/poco/Foundation/src/Bugcheck.cpp:42: Poco::Bugcheck::nullPointer(char const*, char const*, int) @ 0x2ebc5851 in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
6. /src/ch/clickhouse/base/poco/Util/include/Poco/Util/Application.h:446: Poco::Util::Application::instance() @ 0x1ee3e6cd in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
7. /src/ch/clickhouse/src/Interpreters/Context.cpp:358: DB::ContextSharedPart::ContextSharedPart() @ 0x263b0cca in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
8. /src/ch/clickhouse/contrib/llvm-project/libcxx/include/__memory/unique_ptr.h:714: std::__unique_if<DB::ContextSharedPart>::__unique_single std::make_unique[abi:v15000]<DB::ContextSharedPart>() @ 0x26387b6e in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
9. /src/ch/clickhouse/src/Interpreters/Context.cpp:652: DB::Context::createShared() @ 0x26361a3c in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
10. /src/ch/clickhouse/programs/obfuscator/Obfuscator.cpp:1293: mainEntryClickHouseObfuscator(int, char**) @ 0x1ef6eb26 in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
11. /src/ch/clickhouse/programs/main.cpp:481: main @ 0x155e569a in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
12. ? @ 0x7ffff7dd2790 in ?
13. __libc_start_main @ 0x7ffff7dd284a in ?
14. _start @ 0x155e51ae in /src/ch/clickhouse/.cmake-debug/programs/clickhouse
(version 23.3.1.2537)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-05 09:40:18 +02:00
Azat Khuzhin
a8c1407bc4
Use existing ServerSettings in Context instead of reading it again
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-05 09:40:18 +02:00
Azat Khuzhin
c332d290d8
Keep only one throttler for BACKUPs IO (instead of separate read/write)
...
There is no need in separate read/write throttling, because you cannot
write faster then read anyway, and plus this makes the code less cleaner
(and also it will allow avoid implementing throttling backups to S3,
since it does not use common S3 writer).
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-05 09:40:17 +02:00
Azat Khuzhin
218b1f9c29
Add ability to throttle BACKUPs on per-server/backup basis
...
Server settings:
- backup_read_bandwidth_for_server
- backup_write_bandwidth_for_server
Query settings:
- backup_read_bandwidth
- backup_write_bandwidth
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-05 09:39:48 +02:00
Azat Khuzhin
a25dd1d348
Add ability to throttle local IO on per-query/server basis
...
Server settings:
- max_local_read_bandwidth_for_server
- max_local_write_bandwidth_for_server
Query settings:
- max_local_read_bandwidth
- max_local_write_bandwidth
This is the preparation for adding ability to throttle BACKUPs
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-05 09:39:15 +02:00
Azat Khuzhin
b3406beeb7
Add per-query network throttling
...
Controlled with:
- max_remote_read_network_bandwidth
- max_remote_write_network_bandwidth
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-05 09:39:15 +02:00
Azat Khuzhin
abdb682048
Move some methods for Context into module part
...
This will be required later, for per-query bandwidth limiting.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-05 09:39:15 +02:00
Azat Khuzhin
40cb87c2ac
Make remote bandwidth settings server settings
...
Right now those two settings are applied only at start:
- max_remote_read_network_bandwidth_for_server
- max_remote_write_network_bandwidth_for_server
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-05 09:39:15 +02:00
robot-clickhouse-ci-1
fb3af065f4
Merge pull request #48294 from ClickHouse/update-arrow-2
...
Try to update arrow library to release 11.0.0
2023-04-05 04:43:51 +02:00
Rich Raposa
25be18c83d
Merge pull request #48408 from ClickHouse/serxa-patch-3
...
doc entry for SYSTEM WAIT LOADING PARTS
2023-04-04 19:02:36 -06:00
Alexander Tokmakov
baed245710
Merge pull request #48409 from ClickHouse/better_ci_bot
...
Make CI slack bot less noisy
2023-04-05 03:28:18 +03:00
Alexander Tokmakov
e2679ccb53
make CI slack bot less noisy
2023-04-05 02:16:03 +02:00
Sergei Trifonov
1bea16ea63
doc entry for SYSTEM WAIT LOADING PARTS
2023-04-05 01:34:25 +02:00
FFFFFFFHHHHHHH
6e8f77ee9c
Add statistical aggregate function kolmogorovSmirnovTest ( #48325 )
2023-04-05 01:18:54 +02:00
Boris Kuschel
76738017a8
Fix krb5 with openssl
2023-04-04 15:28:40 -07:00
Anton Popov
10d2b1330b
add perf test
2023-04-04 21:29:52 +00:00
kssenii
a3d69694f4
Fix build
2023-04-04 23:13:17 +02:00
Robert Schulze
db864891f8
Merge pull request #47610 from murfel/format-hiliting-fix
...
Fix minor hiliting issues in clickhouse-format
2023-04-04 22:59:46 +02:00
kssenii
c379eb7c29
Fix style check
2023-04-04 22:59:16 +02:00
kssenii
f44c53b97a
Merge remote-tracking branch 'upstream/master' into better-tests-for-data-lakes
2023-04-04 22:41:22 +02:00
kssenii
8c0be0c3be
Checkpoints
2023-04-04 22:40:05 +02:00
Dmitry Novik
96a1304730
WIP on additional_table_filters
2023-04-04 20:33:59 +00:00
robot-ch-test-poll
5eb5978813
Merge pull request #48360 from ClickHouse/fix-explain-with-changed-column-names-analyzer
...
Fix tests with explain and analyzer where names changed.
2023-04-04 22:10:10 +02:00
Dmitry Novik
673413dc9f
Merge pull request #48355 from ClickHouse/lambda-type-resolution
...
Fix lambda type resolution
2023-04-04 22:07:57 +02:00