Commit Graph

20256 Commits

Author SHA1 Message Date
Raúl Marín
5dd3cc6595 Share code between Avg and SumCount 2021-11-24 13:13:54 +01:00
tavplubix
04b98ee1d7
Revert "Fixed null pointer exception in MATERIALIZE COLUMN" 2021-11-24 14:56:12 +03:00
kssenii
980c87c466 Add named collection for kafka / rabbit 2021-11-24 14:53:01 +03:00
alesapin
646cf38213
Merge pull request #28981 from JackyWoo/add_4_letter_words_commands
Add four letter commands to keeper
2021-11-24 13:32:36 +03:00
Raúl Marín
dde264cd53 Implement batching for SumCount 2021-11-24 11:14:31 +01:00
Raúl Marín
d2dcbdd1ee Implement batch operators for avg 2021-11-24 11:14:31 +01:00
kssenii
29579962cb Update test, tiny changes 2021-11-24 12:55:36 +03:00
Maksim Kita
527480bd8e
Merge pull request #31679 from excitoon-favorites/fixmaterializecolumn
Fixed null pointer exception in `MATERIALIZE COLUMN`
2021-11-24 12:29:23 +03:00
Maksim Kita
801c6c1e99
Merge pull request #31119 from nautaa/fix-file-log
remove unnecessary assert in StorageFileLog
2021-11-24 12:28:13 +03:00
tavplubix
5eae7710ea
Update DatabaseOnDisk.cpp 2021-11-24 12:06:19 +03:00
Vladimir Chebotarev
4f7f9795a1 Fixed null pointer exception in MATERIALIZE COLUMN. 2021-11-24 09:17:43 +03:00
feng lv
89e9569ad6 fix typo 2021-11-24 04:34:25 +00:00
Alexey Milovidov
e59e833cc6 Fix build 2021-11-24 03:11:22 +03:00
Alexey Milovidov
1acbafdffe Remove outstandingly wrong code 2021-11-24 00:48:57 +03:00
Alexander Tokmakov
9237b251d5 allow rename dict in Ordrinary, fix another issue 2021-11-23 20:53:45 +03:00
avogar
4470365fb3 Fix 2021-11-23 19:56:44 +03:00
avogar
b81d8426d3 Clean up 2021-11-23 19:56:43 +03:00
avogar
a900a26691 Support parallel formatting for all text output formats 2021-11-23 19:56:43 +03:00
Kruglov Pavel
6987e5bfd0
Update SerializationDecimal.cpp 2021-11-23 17:30:52 +03:00
Kruglov Pavel
d68880754c
Merge pull request #31652 from ClickHouse/Avogar-patch-1
Try to fix possible data race in RemoteQueryExecutorReadContext
2021-11-23 16:47:29 +03:00
Kruglov Pavel
b63b47f0f0
Merge pull request #31265 from Avogar/fix-write-buffers
Fix and refactor WriteBiffer-s a little
2021-11-23 16:46:09 +03:00
Kruglov Pavel
6d942401bb
Merge pull request #31510 from azat/fix-progress-for-insert
Fix progress for short INSERT SELECT queries
2021-11-23 16:37:06 +03:00
Ilya Golshtein
ae15126d20 just more verbose comment 2021-11-23 12:56:14 +00:00
Ilya Golshtein
e27ce34cf2 get Build ID via Section headers first 2021-11-23 12:56:14 +00:00
alexey-milovidov
341f705419
Merge pull request #30599 from ClickHouse/zlib-ng-own-cmake
Use our own CMakeLists for `zlib-ng`, `cassandra`, `mariadb-connector-c` and `xz`, `re2`, `sentry`, `gsasl`, `arrow`, `protobuf`.
2021-11-23 13:33:29 +03:00
alesapin
16f034fe4c Flush bytes after 4 letter commands 2021-11-23 13:31:10 +03:00
Kruglov Pavel
65233110ae
Try to fix possible data race 2021-11-23 12:43:06 +03:00
tavplubix
7a43a87f5b
Use shard and replica name from Replicated database arguments (#31488)
* fix another issue

* use shard and replica name from Replicated database

* fix

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-11-23 12:41:54 +03:00
Vitaly Baranov
8eae84b8cf
Merge pull request #31607 from vitlibar/stop-reloading-all-configs-on-shutdown-early
Stop all periodic reloading of all the configuration files on shutdown earlier
2021-11-22 22:45:14 +03:00
kssenii
7fae3b1cc9 Update tests 2021-11-22 20:57:31 +03:00
tavplubix
d2aa56fc1f
Update DatabaseOnDisk.cpp 2021-11-22 20:44:06 +03:00
Alexander Tokmakov
5868f7590c fix race between replicas 2021-11-22 19:46:34 +03:00
Alexander Tokmakov
ba6adafae3 Merge branch 'master' into tavplubix-patch-4 2021-11-22 18:50:38 +03:00
tavplubix
667dbef4a0
Merge branch 'master' into fix_rename_dictionary 2021-11-22 18:48:22 +03:00
Alexander Tokmakov
d56950a207 fix rename dictionary 2021-11-22 18:41:35 +03:00
kssenii
4c41e719ed Add comments 2021-11-22 18:09:45 +03:00
alesapin
5825242a7d Merge branch 'add_4_letter_words_commands' of github.com:JackyWoo/ClickHouse into JackyWoo_add_4_letter_words_commands 2021-11-22 18:02:22 +03:00
alesapin
35de9e42d9
Merge branch 'master' into add_4_letter_words_commands 2021-11-22 18:02:02 +03:00
tavplubix
0772f6c215
Merge pull request #31584 from ClickHouse/debug_expired_sessions
Try to debug expired sessions
2021-11-22 17:06:46 +03:00
mergify[bot]
2adaf54d33
Merge branch 'master' into fix-whole-text-serialization 2021-11-22 14:00:51 +00:00
mergify[bot]
a9c1fd1647
Merge branch 'master' into fix-write-buffers 2021-11-22 13:59:31 +00:00
Anton Popov
43cfa4467b
Merge pull request #31476 from CurtizJ/merging-constraints
Merging #18787 (Constraints)
2021-11-22 15:57:59 +03:00
Kruglov Pavel
8391f1f315 Update ISerialization.cpp 2021-11-22 14:26:48 +03:00
avogar
9bee988e16 Fix tests 2021-11-22 14:26:48 +03:00
avogar
ec9e87aff1 Fix deserializeWholeText 2021-11-22 14:26:48 +03:00
mergify[bot]
a7ba3e23a0
Merge branch 'master' into fix-write-buffers 2021-11-22 11:24:27 +00:00
avogar
b8695e8236 Fix comments 2021-11-22 14:19:26 +03:00
tavplubix
dc6d48ff83
Merge pull request #31292 from stigsb/materialized-mysql-atomic-only
Drop support for DatabaseOrdinary in MaterializedMySQL
2021-11-22 14:03:50 +03:00
Kruglov Pavel
814a36ba69
Merge pull request #31434 from Avogar/custom-with-names-and-types
Add formats CustomSeparatedWithNames/WithNamesAndTypes
2021-11-22 13:24:00 +03:00
zhangxiao871
5f10159a7d Fix sparkbars are not aligned. 2021-11-22 18:07:08 +08:00
Nikolai Kochetov
b814f54f50
Merge pull request #31474 from amosbird/projection-improve6
Allow partition column to be used for minmax_count projection
2021-11-22 13:01:57 +03:00
Vitaly Baranov
2f8c829395 Stop all periodic reloading of all the configuration files on shutdown earlier. 2021-11-22 12:26:05 +03:00
kssenii
05c548035f Some fixes 2021-11-22 11:04:04 +03:00
Anton Popov
c034491da9 fix style check 2021-11-21 23:02:33 +03:00
Anton Popov
afe8d3c424 refactor merged index conditions 2021-11-21 22:49:34 +03:00
Alexey Milovidov
c5fcef03c3 Remove trash 2021-11-21 18:12:05 +03:00
alesapin
1cf204c581 Small changes 2021-11-21 15:28:45 +03:00
Alexey Milovidov
6246cec409 Fix build on AArch64 2021-11-21 14:30:04 +03:00
Alexey Milovidov
d604cf5573 Remove the infamous "unbundled" build 2021-11-21 13:58:26 +03:00
alexey-milovidov
faae69f631
Merge pull request #31534 from aiven/kmichel-fix-json-colum-name-encoding
Fix invalid JSON in column names
2021-11-21 11:34:33 +03:00
alexey-milovidov
4cdb40e3cd
Merge pull request #31565 from azat/fix-MySQLWire
Fix MySQLWire format (this will also fix performance tests)
2021-11-21 11:32:53 +03:00
alexey-milovidov
796c76638a
Merge pull request #31574 from ClickHouse/fix-trash
Fix broken non-x86 builds
2021-11-21 01:16:44 +03:00
tavplubix
711b738dd1
Merge pull request #31542 from ClickHouse/mutations_remove_multimap
Remove strange multimap for mutations in StorageMergeTree
2021-11-20 20:41:49 +03:00
Alexander Tokmakov
856502fa81 log long operations in Keeper 2021-11-20 20:39:31 +03:00
Vitaly Baranov
9a0d98fa6d
Merge pull request #31557 from vitlibar/better-exception-message-wrong-user-hash
Better exception message wrong user hash
2021-11-20 19:47:07 +03:00
Kruglov Pavel
d9c1a0c8ec
Merge branch 'master' into fix-write-buffers 2021-11-20 17:48:24 +03:00
Azat Khuzhin
dd7f780978 Fix Progress for short INSERT SELECT queries
Note, that we cannot send Progress for regular INSERT (w/ VALUES) w/o
breaking protocol compatibility, but it can be done by increasing
revision.
2021-11-20 16:41:35 +03:00
Azat Khuzhin
0b4d855c08 Reduce copy-paste in TCPHandler::processInsertQuery() 2021-11-20 16:41:35 +03:00
kssenii
6c8867a719 Fix style check 2021-11-20 16:21:43 +03:00
Alexey Milovidov
e898c6608c Fix broken non-x86 builds 2021-11-20 15:58:44 +03:00
Azat Khuzhin
6aa94ae032 Fix MySQLWire format (in case of multiple writes)
In case of multiple writes File() engine will set doNotWritePrefix(),
and this will avoid serializations initilization, move this to do this
always.

Fixes: #31004
2021-11-20 15:26:21 +03:00
kssenii
ff969b4605 Merge branch 'master' of github.com:ClickHouse/ClickHouse into seekable-read-buffers 2021-11-20 15:03:13 +03:00
kssenii
f29ef7d18b Add one more test 2021-11-20 15:01:45 +03:00
Kevin Michel
edbeeaf6ec
Fix invalid JSON in column names
If the column name contains invalid UTF-8 sequences
and the output data types are all considered safe,
then the output will not be sanitized and the generated
JSON will be invalid.

A minimal reproduction case is :
`SELECT length('\x80') FORMAT JSONCompact`
where we auto-generate a non-UTF-8 column name with only
integer outputs, whereas :
`SELECT '\x80' FORMAT JSONCompact`
would be sanitized because the column type is String and
will trigger UTF-8 sanitization over the entire document.
2021-11-20 12:35:41 +01:00
kssenii
fda66adf52 Correct merge with master 2021-11-20 13:47:55 +03:00
Vladimir C
4498aecaf6
Merge pull request #31528 from vdimir/disable_partial_merge_join_left_table_buffer_bytes 2021-11-20 13:11:35 +03:00
kssenii
29978f9707 Merge branch 'master' of github.com:ClickHouse/ClickHouse into vxider-window-view 2021-11-20 12:13:39 +03:00
Vitaly Baranov
57ac39f99e Add more information to exceptions raised by UsersConfigAccessStorage. 2021-11-20 12:10:45 +03:00
kssenii
5c9509d68b Fix attach 2021-11-20 12:03:39 +03:00
Alexey Milovidov
9ca5c960b7 Remove useless code 2021-11-20 10:06:28 +03:00
Alexey Milovidov
334535a4c4 Better exception message when users.xml cannot be loaded due to bad password hash 2021-11-20 10:06:20 +03:00
Vitaly Baranov
940b5edbd7
Merge pull request #31509 from vitlibar/split-row-policy-and-quota-headers
Split row policy and quota headers
2021-11-20 10:01:18 +03:00
Vitaly Baranov
0684b28377
Merge pull request #31337 from sunny19930321/fix-use-quota-bug
fix: quota limit was not reached, but the limit was exceeded
2021-11-20 09:52:24 +03:00
tavplubix
67753e5b83
Update StorageMergeTree.cpp 2021-11-19 20:05:45 +03:00
Alexander Tokmakov
8d7413b0d6 remove strange multimap from mutations 2021-11-19 19:54:43 +03:00
Kruglov Pavel
4856b50c23
Merge pull request #31409 from excitoon-favorites/s3envsegfaults
Resolve `nullptr` in STS credentials provider for S3
2021-11-19 18:45:38 +03:00
alesapin
1afef1733b Ignore overhead 2021-11-19 18:22:46 +03:00
Anton Popov
099c40d251 fix tests 2021-11-19 17:14:56 +03:00
Kruglov Pavel
fdd1f53d3a
Update CustomSeparatedRowOutputFormat.h 2021-11-19 16:52:48 +03:00
Kruglov Pavel
3070bf1e4d
Update CustomSeparatedRowOutputFormat.cpp 2021-11-19 16:52:31 +03:00
Kruglov Pavel
cded91b013
Update verbosePrintString.h 2021-11-19 16:51:49 +03:00
Kruglov Pavel
eb1cc834dc
Merge branch 'master' into custom-with-names-and-types 2021-11-19 16:51:25 +03:00
kssenii
9bdad8ab64 Rewrite from DataStreams to Processors 2021-11-19 16:09:12 +03:00
alesapin
587a1a622d Fix tests 2021-11-19 16:03:01 +03:00
alesapin
d1eba74c04 Trim string 2021-11-19 13:52:03 +03:00
SuperDJY
dd2972b8c3
return fake create query when executing show create table on system's tables. (#31391)
* clarify that cannot show create table of system's tables

* clarify that cannot show create table of system's tables in the document

* bypass test style-check for required `database=currentDatabase()` because `show create table` do not have condition

* rename supportsShowCreateTable to isSystemStorage

* build fake create query for show create table of system's tables

* fix tests for show create table on system's table:

1. only build fake create query when cannot get real query
2. only test rocksdb when it's enabled.

* fix test for show create table system.tables

* fix test for ASTCreateQuery set table and database

* change to LOGICAL_ERROR when cannot get in_memory metadata

Co-authored-by: tavplubix <tavplubix@gmail.com>

* implement common getCreateQueryFromStorage

Co-authored-by: tavplubix <tavplubix@gmail.com>
2021-11-19 13:25:55 +03:00
vdimir
2e0d3efba0
disable partial_merge_join_left_table_buffer_bytes due to bug 2021-11-19 12:59:23 +03:00
vdimir
f3d0e6d999
remove partial_merge_join_optimizations
this option is redundant because optimization is controlled by partial_merge_join_left_table_buffer_bytes
2021-11-19 12:58:46 +03:00
alesapin
7820af7cbd More compatible output format 2021-11-19 12:48:38 +03:00
alesapin
f33e93e305 Merge branch 'add_4_letter_words_commands' of github.com:JackyWoo/ClickHouse into JackyWoo_add_4_letter_words_commands 2021-11-19 12:31:03 +03:00
alesapin
3f8f08e816 Slightly better 2021-11-19 12:30:58 +03:00
JackyWoo
33396b054e fix build error 2021-11-19 15:52:35 +08:00
Amos Bird
c47ec31617
fix 2021-11-19 11:51:05 +08:00
Vitaly Baranov
af56b20da7 Rename IAccessEntity::Type -> AccessEntityType and move it to Access/Common. 2021-11-19 02:48:00 +03:00
Vitaly Baranov
06077a2952 Rename Quota::KeyType -> QuotaKeyType and move it to Access/Common. 2021-11-19 00:14:23 +03:00
Vitaly Baranov
6634fcbac7 Rename Quota::ResourceType -> QuotaType and move it to Access/Common. 2021-11-19 00:14:23 +03:00
Vitaly Baranov
33ea7a7262 Rename RowPolicy::ConditionType -> RowPolicyFilterType and move it to Access/Common. 2021-11-19 00:14:23 +03:00
Vitaly Baranov
2883ca012e Rename RowPolicy::NameParts -> RowPolicyName and move it to Access/Common. 2021-11-19 00:14:23 +03:00
alexey-milovidov
12a471507e
Merge pull request #31169 from sundy-li/notlike-fix
ISSUES-30801: Remove not like function into RPNElement
2021-11-18 23:40:57 +03:00
alexey-milovidov
b30f9124c0
Merge pull request #31008 from kssenii/sql-json-fix-2
Improve usability of JSON_VALUE
2021-11-18 23:39:17 +03:00
alesapin
04dba4c360 Merge branch 'add_4_letter_words_commands' of github.com:JackyWoo/ClickHouse into JackyWoo_add_4_letter_words_commands 2021-11-18 23:18:12 +03:00
alesapin
dcec086573 Small refactoring 2021-11-18 23:17:22 +03:00
Vitaly Baranov
f4b5d5a0d7
Update src/Access/EnabledQuota.cpp 2021-11-18 21:49:36 +03:00
Amos Bird
d1a14d76f1
fix 2021-11-19 02:29:35 +08:00
Stig Bakken
f8c53e839a fix clang13 warning 2021-11-18 16:53:41 +01:00
Amos Bird
c988a4e770
fix again 2021-11-18 23:09:17 +08:00
Anton Popov
69559a4fd9 fix convertion to CNF 2021-11-18 17:54:07 +03:00
kssenii
6a39d871b2 Merge branch 'master' of github.com:ClickHouse/ClickHouse into vxider-window-view 2021-11-18 17:29:11 +03:00
JackyWoo
0d19f2a485 ignore clang-tidy for IntNode in gtest_coordination 2021-11-18 21:27:43 +08:00
Stig Bakken
b91f21d658 Don't use setInternalQuery() when forwarding drop calls to database 2021-11-18 11:46:51 +01:00
Stig Bakken
9190a883d3 Print CREATE, not ATTACH 2021-11-18 11:46:51 +01:00
Stig Bakken
eb5115adb8 Fail when loading MaterializeMySQL database without uuid
and print instructions on how to remove and recreate.
2021-11-18 11:46:51 +01:00
Stig Bakken
18ce50fd7f Add hasReplicationThread() and stopReplication() methods to IDatabase 2021-11-18 11:46:51 +01:00
Stig Bakken
ff46e8bb51 Drop support for DatabaseOrdinary in MaterializedMySQL
1. Dropped support for DatabaseOrdinary for MaterializeMySQL. It
   is marked as experimental, and dropping support makes the code
   more maintaible, and speeds up integration tests by 50%.

2. Get rid of thread name logic for StorageMaterializeMySQL wrapping,
   use setInternalQuery instead (similar to MaterializedPostgreSQL).
2021-11-18 11:46:51 +01:00
JackyWoo
afd8a321b4 ignore explicit-constructor in gtest_coordination.cpp 2021-11-18 18:34:44 +08:00
kssenii
11ab1f1ae5 Fix 2021-11-18 08:46:31 +00:00
kssenii
4016530b99 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into sql-json-fix-2 2021-11-18 08:33:50 +00:00
Vladimir Chebotarev
8b622bd4ff Fixed a typo. 2021-11-18 10:54:59 +03:00
JackyWoo
27d50edc59 adjust log output 2021-11-18 15:49:43 +08:00
Vladimir C
0a3a43c017
Merge pull request #30984 from qieqieplus/untuple-func-alias 2021-11-18 10:42:20 +03:00
JackyWoo
007366b506 remove sizeOf method from SnapshotableHashTable 2021-11-18 12:35:32 +08:00
Kruglov Pavel
f27fcf8372
Merge pull request #31004 from Avogar/output-formats
Small refactoring in formats
2021-11-17 20:44:46 +03:00
alesapin
52cd5a3c36 Merge branch 'add_4_letter_words_commands' of github.com:JackyWoo/ClickHouse into JackyWoo_add_4_letter_words_commands 2021-11-17 19:50:33 +03:00
Anton Popov
dfb9bc2a01 minor fixes in constraints 2021-11-17 18:43:02 +03:00
Amos Bird
feb3a12d34
fix 2021-11-17 23:11:23 +08:00
Amos Bird
4cfb105d5a
better 2021-11-17 22:07:56 +08:00
Amos Bird
7b9a19f066
enhance minmax_count projection 2021-11-17 22:05:57 +08:00
JackyWoo
4438e4c778 fix stress test error 2021-11-17 21:21:12 +08:00
alesapin
45cd535839 Fix my own wrong command usage 2021-11-17 15:44:07 +03:00
alesapin
5f3eca4cd1 Merge branch 'master' into JackyWoo_add_4_letter_words_commands 2021-11-17 12:59:20 +03:00
alexey-milovidov
e5fba49947
Merge pull request #31450 from ClickHouse/tavplubix-patch-6
Change default http timeout from 1800 to 180
2021-11-17 10:33:42 +03:00
alexey-milovidov
2a5c70c5f9
Merge pull request #31400 from ClickHouse/remove-thread-local-std-string
Remove thread_local std::string
2021-11-17 10:29:34 +03:00
alexey-milovidov
1e058fb207
Merge pull request #30190 from azat/ReadBuffer-throw-on-empty
Do not allow zero-length reads
2021-11-17 10:21:08 +03:00
mergify[bot]
41fa94f482
Merge branch 'master' into notlike-fix 2021-11-17 07:14:21 +00:00
Kseniia Sumarokova
d1374481df
Merge pull request #31457 from azat/local-pager
Add --pager support for clickhouse-local
2021-11-17 09:29:56 +03:00
Azat Khuzhin
bbbbd261b8 Add --pager support for clickhouse-local 2021-11-16 22:25:32 +03:00
avogar
1ebcbf4748 Fix style 2021-11-16 17:10:30 +03:00
Kruglov Pavel
be7a358f17 Fix 2021-11-16 17:10:30 +03:00
Kruglov Pavel
4f5e731513 Try fix tests 2021-11-16 17:10:30 +03:00
avogar
8e9783388b Add formats CustomSeparatedWithNames/WithNamesAndTypes 2021-11-16 17:10:30 +03:00
avogar
73d1918410 tmp 2021-11-16 17:10:30 +03:00
Nikolay Degterinsky
d365d6c496 Fix merge 2021-11-16 14:04:33 +00:00
tavplubix
9ed97eec96
Update Defines.h 2021-11-16 15:42:37 +03:00
Nikolay Degterinsky
dd3b0e4140 Merge branch 'master' into query_parameters 2021-11-16 12:42:26 +00:00
tavplubix
33122597fe
Merge pull request #31410 from stigsb/materialized-mysql-create-table-like
Handle CREATE TABLE LIKE in MaterializedMySQL
2021-11-16 14:10:58 +03:00
Nikolay Degterinsky
2f6a565b06 Merge branch 'master' into query_parameters 2021-11-16 10:37:58 +00:00
Nikolai Kochetov
38935d91ac
Merge pull request #31317 from azat/fix-tsan-in-async_socket_for_remote
Fix possible data-race in case of query cancellation with async_socket_for_remote
2021-11-16 13:03:05 +03:00
Nikolai Kochetov
15cd3dc307
Merge pull request #31006 from vzakaznikov/fix_live_view_underusing_cpu
Fixing query performance issue in Live Views
2021-11-16 12:43:33 +03:00
Vladimir Chebotarev
1e79177ce2 Build fix. 2021-11-16 12:31:51 +03:00
Nikolay Degterinsky
64927938c6 Minor refactor 2021-11-16 08:58:28 +00:00
Kruglov Pavel
1bbe0df945
Fix perf test 2021-11-16 11:41:50 +03:00
tavplubix
710fbebafc
Merge pull request #30977 from ClickHouse/check_dependencies_on_drop
Check dependencies on DROP TABLE
2021-11-16 11:38:42 +03:00
Nikolay Degterinsky
ba50e8387d Merge branch 'master' into query_parameters 2021-11-15 19:55:54 +00:00
Nikolay Degterinsky
5d07387987 Fix INFILE tests 2021-11-15 19:55:27 +00:00
Nikolay Degterinsky
5c5897c1cd Apply suggestions from code review
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
2021-11-15 17:57:26 +00:00
Kseniia Sumarokova
b040890fcf
Merge pull request #31420 from kssenii/fix-positional-args-bug
Fix group by with positional args
2021-11-15 20:42:58 +03:00
Ilya Yatsishin
e5301ab712
Merge pull request #31286 from cfcz48/add_oss_support
Aliyun OSS Storage support
2021-11-15 17:00:27 +03:00
Stig Bakken
3eac620d4d Handle CREATE TABLE LIKE in MaterializedMySQL 2021-11-15 14:43:50 +01:00
tavplubix
c3219a00aa
Merge pull request #31333 from azat/global-ctx-tmp-tables
Do not try to resolve temporary tables from global context
2021-11-15 16:35:02 +03:00
Vitaliy Zakaznikov
63c70f6281 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into fix_live_view_underusing_cpu 2021-11-15 07:50:27 -05:00
kssenii
6fe803e31e Fix 2021-11-15 15:09:04 +03:00
avogar
8f7be52ac4 Update test, remove commented code 2021-11-15 14:58:18 +03:00
Amos Bird
30b06a969b
Cancel vertical merges (#31057)
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-11-15 14:32:53 +03:00
Alexander Tokmakov
416a82b99a Merge branch 'master' into check_dependencies_on_drop 2021-11-15 13:35:45 +03:00
alesapin
af820f85d3
Merge pull request #31259 from azat/temporary_directories_lifetime-message-fix
Print warning during old directories cleanup in MergeTree only if it is old
2021-11-15 12:56:31 +03:00
avogar
8c87f8861c Fix style 2021-11-15 12:48:28 +03:00
avogar
ba06953ee7 Fix tests 2021-11-15 12:47:00 +03:00
alesapin
a4c711ba8b
Merge pull request #31406 from ClickHouse/tavplubix-patch-5
Remove excessive debug info from the log message in DDLWorker
2021-11-15 12:38:03 +03:00
Vladimir Chebotarev
5e9710a26e Attempt to resolve nullptr in STS credentials provider for S3. 2021-11-15 10:46:43 +03:00
Azat Khuzhin
fe36884110 Convert assert(!isGlobalContext()) to LOGICAL_ERROR 2021-11-15 10:32:19 +03:00
Azat Khuzhin
68068ff71d Remove check for clickhouse-local
From #26231 clickhouse-local uses local context for query execution.
2021-11-15 10:32:19 +03:00
Azat Khuzhin
fa317e96e8 Do not try to resolve temporary tables from global context 2021-11-15 10:32:19 +03:00
kssenii
f4ffedd5f3 Better 2021-11-15 10:23:35 +03:00
alesapin
2a9ed85f23
Merge pull request #31300 from ClickHouse/fix_intersecting_parts_to_do3
Remove strange code from mutations
2021-11-15 10:08:32 +03:00
qieqieplus
b6aa781c9b add dot separator 2021-11-15 14:47:34 +08:00
JackyWoo
0991eddcd4 fix build error 2021-11-15 10:16:11 +08:00
tavplubix
b5b20f84bc
Update DDLWorker.cpp 2021-11-14 17:41:55 +03:00
Kseniia Sumarokova
846fbd059b
Merge pull request #31403 from kssenii/fix-client-output
Fix client
2021-11-14 15:01:30 +03:00
kssenii
ad1b7c83cd Fix 2021-11-14 07:19:59 +00:00
Alexey Milovidov
052a7a92e8 Whitespace 2021-11-14 10:05:20 +03:00
Alexey Milovidov
fe3ee85d80 Fix MaterializedMySQL 2021-11-14 10:04:45 +03:00
alexey-milovidov
cb6342025d
Merge pull request #31229 from zhanglistar/fsync
Change all fsync to fdatasync
2021-11-14 05:16:01 +03:00
Alexey Milovidov
bd684f02f2 Fix clang-tidy 2021-11-14 04:57:59 +03:00
Alexey Milovidov
1e4e36ff2d Remove thread_local std::string 2021-11-14 02:43:17 +03:00
alexey-milovidov
e323b83f6a
Merge pull request #30876 from pmed/backslash_letter_interactive_input
add aliases for `\<letter>` interactive client commands
2021-11-14 01:43:13 +03:00
Azat Khuzhin
f2c74a81f7 Fix QueryScope in MaterializedMySQLSyncThread
QueryScope should exist for the whole query execution time.
2021-11-13 20:06:08 +03:00
Kseniia Sumarokova
59d4eb99c2
Merge pull request #31291 from kssenii/update-async-reads-setting
Make remote_filesystem_read_method=threadpool by default
2021-11-13 19:19:35 +03:00
kssenii
f18dcd2287 Merge branch 'master' of github.com:ClickHouse/ClickHouse into seekable-read-buffers 2021-11-13 14:38:57 +03:00
Azat Khuzhin
11be942bb0 Fix possible data-race in case of query cancellation with async_socket_for_remote
RemoteQueryExecutor::cancel() (that is called in another thread), steal
the fiber, and process any pending packets, to leave the connection in
the correct state (so that it can be reused for further queries).

However this requires processing pending packets, and this will update
the RemoteQueryExecutorReadContext::packet field, which can be read in
another thread by the RemoteQueryExecutor::read().

This was pretty tricky due to fibers, but AFAICS I understand this
correctly and this should fix the race.

Note, that if you will look at the logs from the #28854, you will see,
that all those data races was triggered after query cancellation.

Fixes: #28854
Refs: #18715

v2: fix daedlock in case of duplicated parts
v3: do not hold the mutex, since was_cancelled is atomic
2021-11-13 12:44:02 +03:00
Kseniia Sumarokova
c7be79b4e7
Merge pull request #31136 from LiuYangkuan/IDiskRemote_metadata_disk
use DiskPtr instead of OS's file system API in class IDiskRemote
2021-11-13 12:16:05 +03:00