Commit Graph

140552 Commits

Author SHA1 Message Date
alesapin
78e6d62ed3
Merge branch 'master' into ci_add_azure_tests 2024-04-27 12:33:42 +02:00
alesapin
b4e3880c6b Test work without azurite 2024-04-27 12:30:28 +02:00
Azat Khuzhin
52091916dc Fix leftovers of enabling new analyzer
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-27 11:19:03 +02:00
Azat Khuzhin
03d52e7e49 Better handling of old analyzer check in intergraion tests runner
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-27 10:32:27 +02:00
Azat Khuzhin
85ea46de77 Fix integration tests with old analyzer
This reverts commit 67d39a22ac.
2024-04-27 10:29:13 +02:00
Azat Khuzhin
eb4c095077 Fix suppressions for rd_avg_calc()/rd_avg_rollover() (due to static qualifier)
The problem is that TSan still fails [1] is that ignorelist does not
work for static functions without asterisk:

    // test.cpp
    #include <thread>

    bool flag = false;

    // avoid mangling
    extern "C" {

    static void set_flag_impl()
    {
        flag = true;
    }

    void set_flag()
    {
        set_flag_impl();
    }
    void set_flag_if()
    {
        if (flag)
            flag = false;
    }

    }

    int main()
    {
        std::thread t1([]{ set_flag(); });
        std::thread t2([]{ set_flag_if(); });

        t1.join();
        t2.join();

        return 0;
    }

    // ignorelist
    [thread]
    fun:set_flag_impl

    $ clang++ -g -fno-omit-frame-pointer -fsanitize=thread -fsanitize-ignorelist=ignorelist -o test test.cpp && ./test
    SUMMARY: ThreadSanitizer: data race /tmp/test-tsan-ignorelist/test.cpp:19:9 in set_flag_if
    $ sed -i 's/set_flag_impl/*set_flag_impl*/' ignorelist
    $ clang++ -g -fno-omit-frame-pointer -fsanitize=thread -fsanitize-ignorelist=ignorelist -o test test.cpp && ./test
    OK

But, note that ignorelist is tricky, and will not work for
functions with __always_inline__ attribute for example.

P.S. set_flag_impl also has brackets in the output (i.e.
set_flag_impl()), while ther eis brackets for rd_avg_calc on CI [1].

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/63039/84bebc534ba7cf6e9dbfc1d91e8350939a84f87c/integration_tests__tsan__[6_6]//home/ubuntu/actions-runner/_work/_temp/test/output_dir/integration_run_parallel4_0.log

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-27 09:51:59 +02:00
Pablo Marcos
f6b19e143a Remove unnecessary const hinted by clang-tidy
Removing the reference for Index makes the const unnecessary.
Constness for it is still preserved correctly because Columns
are inmutable pointers to IColumn.
2024-04-27 09:30:51 +02:00
Pablo Marcos
9002d4c751 Merge branch 'master' into pamarcos/system-unload-primary-key 2024-04-27 08:57:29 +02:00
Konstantin Bogdanov
64de52397e
Merge pull request #62978 from ClickHouse/fix-grpc-ipv6-crash
gRPC: fix crash on IPv6 peer connection
2024-04-27 06:22:41 +00:00
Alexey Milovidov
8cc67f7c95
Merge pull request #62973 from yariks5s/reduce_help_messages
Reduce verbosity of `clickhouse client --help`
2024-04-27 03:43:33 +00:00
Alexey Milovidov
52f58f2fff
Merge pull request #63035 from aalexfvk/fix_flaky_test_03000_traverse_shadow_system_data_paths
Fix flaky test 03000_traverse_shadow_system_data_paths
2024-04-27 01:04:30 +00:00
Yarik Briukhovetskyi
ebad7062a8
un-flaky the test 2024-04-26 20:31:26 +02:00
Alexander Tokmakov
8c282b63ae
Update ExecutionThreadContext.cpp 2024-04-26 20:30:41 +02:00
Nikita Mikhaylov
ed7e4291ab
Merge pull request #62937 from ClickHouse/docs-remove-replicated-experimental-tag
Remove experimental tag from Replicated database engine
2024-04-26 17:56:06 +00:00
Alexander Tokmakov
87537c1303
Merge pull request #63000 from ClickHouse/tavplubix-patch-14
Remove incorrect assertion from DatabaseReplicated
2024-04-26 17:48:56 +00:00
Alexander Tokmakov
7fb78aa4d4
Merge pull request #60856 from azat/alter-select-throughtput-v2
[RFC] Reduce overhead of the mutations for SELECTs (v2)
2024-04-26 17:46:57 +00:00
Nikita Mikhaylov
8ed884d364
Merge pull request #62851 from slvrtrn/update-http-interface-role-docs
[Docs] Add ClickHouse version to the role query parameter docs
2024-04-26 17:43:16 +00:00
Konstantin Bogdanov
6d805d094c
Fix harder 2024-04-26 19:37:14 +02:00
Nikita Taranov
2dadb164c4
Merge pull request #62853 from nickitat/fix_gcd
Fix GCD codec
2024-04-26 17:26:00 +00:00
alesapin
8b050b2548 Merge branch 'ci_add_azure_tests' of github.com:ClickHouse/ClickHouse into ci_add_azure_tests 2024-04-26 19:18:18 +02:00
alesapin
349147b5b5 One more time 2024-04-26 19:16:27 +02:00
Vitaly Baranov
860c642535 fix-curl-cmake 2024-04-26 18:58:20 +02:00
Vitaly Baranov
d49fcda09e Unfork and update curl to 8.7.1 2024-04-26 18:58:13 +02:00
Nikita Mikhaylov
ec787a68e8
Merge pull request #60153 from azat/access-controls-enable-by-default
Enable all access control improvements by default (even without config.xml)
2024-04-26 16:09:30 +00:00
Konstantin Bogdanov
4c607147ba
Fix 2024-04-26 17:38:02 +02:00
Max K
ab29a5f428
Merge pull request #63045 from ClickHouse/ci_one_more_fix_for_ft_in_mq
CI: fix job config for MQ
2024-04-26 15:24:38 +00:00
Max Kainov
e0684dba6b CI: fix job config for MQ 2024-04-26 15:00:07 +00:00
Konstantin Bogdanov
07e4e7fa73
Check for protocol prefix 2024-04-26 16:45:30 +02:00
Nikita Taranov
71fdfe8c83
Enable 03015_optimize_final_rmt for SMT
Enable test for SMT after https://github.com/ClickHouse/clickhouse-private/pull/8623
2024-04-26 15:55:30 +02:00
Smita Kulkarni
f474c29b4d Fix build with new master 2024-04-26 15:33:27 +02:00
Vitaly Baranov
929f474496 Fix unhandled exception in ~RestorerFromBackup. 2024-04-26 15:18:13 +02:00
Azat Khuzhin
84bebc534b Fix suppressions for librdkafka data-race for statistics code
The problem is that ignorelist `fun` does not work recursively.

<details>

<summary>example</summary>

```c
// test.cpp

bool flag = false;

// avoid mangling
extern "C" {

void set_flag_impl()
{
    flag = true;
}
void set_flag()
{
    set_flag_impl();
}
void set_flag_if()
{
    if (flag)
        flag = false;
}

}

int main()
{
    std::thread t1([]{ set_flag(); });
    std::thread t2([]{ set_flag_if(); });

    t1.join();
    t2.join();

    return 0;
}
```

```
// ignorelist
[thread]
fun:set_flag
```

```
$ clang++ -g -fno-omit-frame-pointer -fsanitize=thread -fsanitize-ignorelist=ignorelist -o test test.cpp && ./test
SUMMARY: ThreadSanitizer: data race /tmp/tsan-test/test.cpp:18:9 in set_flag_if
$ sed -i 's/set_flag/set_flag_impl/' ignorelist
$ clang++ -g -fno-omit-frame-pointer -fsanitize=thread -fsanitize-ignorelist=ignorelist -o test test.cpp && ./test
OK
```

</details>

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-26 16:08:45 +03:00
Max K
bd0c827b78
Merge pull request #63025 from ClickHouse/ci_config_run_ft_in_mq_fix
CI: fix ci config to run FT in MQ
2024-04-26 12:54:21 +00:00
Aleksei Filatov
19a2dd3318 Fix flaky test 03000_traverse_shadow_system_data_paths 2024-04-26 15:53:48 +03:00
Nikita Mikhaylov
0af2b305b2
Merge pull request #61740 from ClickHouse/docs/adds-connectionId-function
Adds `connectionId` and `connection_id` function docs.
2024-04-26 12:52:26 +00:00
Azat Khuzhin
6e534650e4 Use sanitizer specific ignorelists
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-26 15:46:04 +03:00
Azat Khuzhin
3ecfcdfe7b Remove outdated comment about broken -fsanitize-ignorelist
See: https://github.com/ClickHouse/ClickHouse/pull/49829#issuecomment-1546704055
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-26 15:45:44 +03:00
Raúl Marín
25d7f24f0f
Merge pull request #63004 from Algunenano/remove_optimize_monotonous_functions_in_order_by
Remove optimize_monotonous_functions_in_order_by setting
2024-04-26 12:13:50 +00:00
Robert Schulze
0fd2d573ae
Move hint to system.settings up 2024-04-26 12:10:51 +00:00
alesapin
56039c91f9
Update src/Interpreters/MutationsInterpreter.cpp 2024-04-26 13:51:25 +02:00
Nikita Mikhaylov
b204e43554
Merge pull request #62000 from ClickHouse/keywords-2
Use keywords structure in all places - `obfuscateQueries.cpp` / `Suggest.cpp`
2024-04-26 11:47:14 +00:00
Yarik Briukhovetskyi
819b5aab55
Merge pull request #62901 from KevinyhZou/fix_fromUnixTimestamp_beyond_uint32
Fix fromUnixtimestamp in joda syntax while the input value beyond UInt32
2024-04-26 11:31:24 +00:00
Yarik Briukhovetskyi
e507bb274d
add link to system.tables for settings docs 2024-04-26 13:27:26 +02:00
Nikita Mikhaylov
12aac468be
Merge pull request #62657 from jus1096/patch-5
Add description for argMax function in documetation
2024-04-26 11:27:01 +00:00
Igor Nikonov
dd5dc25e65 Remove unnecessary check 2024-04-26 11:26:05 +00:00
Nikita Mikhaylov
ab7aa8c1ee
Merge pull request #62429 from peter279k/improve_recipes_dataset_doc
Validating zip and fix query result in Recipes doc
2024-04-26 11:23:32 +00:00
Yarik Briukhovetskyi
eee6fa4242
cosmetic fixes, comments for tests, user hints fixes 2024-04-26 13:19:22 +02:00
Nikita Mikhaylov
cc58408d9a
Merge branch 'master' into docs/adds-connectionId-function 2024-04-26 13:17:47 +02:00
Nikita Mikhaylov
5901f94f4d Add connectionId to spell dictionary 2024-04-26 13:16:50 +02:00
Nikita Mikhaylov
44c05dde02
Merge pull request #62810 from ClickHouse/docs-add-final-keyword-examples
[Docs] Add examples for FINAL
2024-04-26 11:11:16 +00:00