Commit Graph

8367 Commits

Author SHA1 Message Date
kssenii
e77cb18d18 Better test 2023-12-12 15:30:17 +01:00
Natalya Chizhonkova
3d51192bad Refactoring for UserDefinedSQLObjectsLoader 2023-12-12 17:03:49 +03:00
Kruglov Pavel
8a447bf57c
Merge pull request #55892 from Avogar/schema-inference-union
Add 'union' mode for schema inference
2023-12-12 15:02:06 +01:00
Kruglov Pavel
b33f124555
Merge pull request #57538 from MikhailBurdukov/ignore_on_cluster_for_grants
Ignore ON CLUSTER clause in grant/revoke queries for management of replicated access entities.
2023-12-12 14:59:58 +01:00
Konstantin Bogdanov
511cfb393d
Remove time.sleep from test 2023-12-12 12:29:00 +01:00
robot-clickhouse
b49452fb45 Automatic style fix 2023-12-12 10:44:55 +00:00
Konstantin Bogdanov
8fe2cd1a7e
Update tests 2023-12-12 11:35:17 +01:00
Igor Nikonov
fd92cb4c32
Merge pull request #57757 from ClickHouse/fix-flaky-test_parallel_replicas_distributed
Fix flaky test_parallel_replicas_distributed_read_from_all
2023-12-12 10:43:19 +01:00
Konstantin Bogdanov
1f9c7336a9
Fix test helper naming 2023-12-12 09:32:16 +01:00
robot-clickhouse
e95041a3af Automatic style fix 2023-12-11 21:40:23 +00:00
Igor Nikonov
da43d49ffc Fix: sync is failed with stopped merges 2023-12-11 21:30:25 +00:00
alesapin
cbae29d26a
Merge pull request #57699 from hanfei1991/hanfei/keeper_soft_limit_ratio
support keeper memory soft limit ratio
2023-12-11 21:43:24 +01:00
Igor Nikonov
c007025ee3 Fix flaky test_parallel_replicas_distributed_read_from_all 2023-12-11 20:05:26 +00:00
Ryan Jacobs
40da568ef9
Merge branch 'master' into fix_issue_43186_pg_quote_array_ndims 2023-12-11 11:17:38 -08:00
kssenii
05e56f76ed Merge remote-tracking branch 'origin/master' into fix-loading-dependent-table-materialized-postgresql 2023-12-11 20:17:26 +01:00
Kseniia Sumarokova
907d0a79eb
Merge pull request #57568 from ClickHouse/fix-materialized-pg-issue-with-generated-columns
MaterializedPostgreSQL: Support "generated columns" and default values
2023-12-11 19:57:41 +01:00
Kruglov Pavel
3b1ffbd77c
Merge branch 'master' into schema-inference-union 2023-12-11 18:59:15 +01:00
kssenii
48ce040621 Fix 2023-12-11 17:30:23 +01:00
kssenii
a06179da00 Merge remote-tracking branch 'origin/master' into fix-materialized-pg-issue-with-generated-columns 2023-12-11 11:15:00 +01:00
robot-clickhouse
3adb83e406
Automatic style fix 2023-12-11 10:19:49 +01:00
Konstantin Bogdanov
89ba4a8452
Add HTTP readiness endpoint 2023-12-11 10:19:42 +01:00
MikhailBurdukov
119e451967 Merge branch 'master' into native_copy_for_s3_disks 2023-12-11 07:25:20 +00:00
Vitaly Baranov
4aba3ec685 Add some comments. 2023-12-11 00:56:40 +01:00
Vitaly Baranov
e2a7f4004f Fix test test_create_or_drop_tables_during_backup. 2023-12-11 00:56:28 +01:00
Alexey Milovidov
644ef7b63f
Revert "Fix RWLock inconsistency after write lock timeout" 2023-12-10 23:51:59 +03:00
Alexey Milovidov
98f9d2a5fc
Merge pull request #57714 from azat/tests/fix-test_dictionaries_update_and_reload
Fix test_dictionaries_update_and_reload/test.py::test_reload_while_loading flakiness
2023-12-10 17:55:50 +01:00
Alexey Milovidov
d119052895
Merge pull request #51858 from ClickHouse/CurtizJ-fix-ttl-non-deterministic
Merging #37286
2023-12-10 17:50:36 +01:00
Vitaly Baranov
a058a26b7e
Merge pull request #57454 from vitlibar/fix-rwlock
Fix RWLock inconsistency after write lock timeout
2023-12-10 14:09:29 +01:00
Azat Khuzhin
ce9fd2c57a Fix test_dictionaries_update_and_reload/test.py::test_reload_while_loading flakiness
On CI this test fails due to start_time == prev_start_time:

            start_time, duration = get_loading_start_time("slow"), get_loading_duration("slow")
    >       assert start_time > prev_start_time
    E       assert time.struct_time(tm_year=2023, tm_mon=12, tm_mday=9, tm_hour=23, tm_min=42, tm_sec=2, tm_wday=5, tm_yday=343, tm_isdst=-1) > time.struct_time(tm_year=2023, tm_mon=12, tm_mday=9, tm_hour=23, tm_min=42, tm_sec=2, tm_wday=5, tm_yday=343, tm_isdst=-1)

The reason I guess is that there is sleep(0.5), while the
loading_start_time is DateTime not DateTime64, so you cannot distinguish
values if the difference is less then one second

CI: https://s3.amazonaws.com/clickhouse-test-reports/57710/7af1c0885daaf1e41470c5fdd92abfc7b6b2befc/integration_tests__asan__[3_4].html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-10 08:36:10 +01:00
Alexey Milovidov
33b0ec7d55 Merge branch 'master' into CurtizJ-fix-ttl-non-deterministic 2023-12-10 01:21:43 +01:00
Kseniia Sumarokova
69adfffa02
Merge pull request #57588 from ClickHouse/materialized-postgres-escape-publication
Add a test for #55251
2023-12-09 12:14:28 +01:00
Han Fei
881e58dfcb support soft limit ratio 2023-12-08 21:48:27 +01:00
avogar
ee7af95bc0 Merge branch 'master' of github.com:ClickHouse/ClickHouse into schema-inference-union 2023-12-08 20:29:28 +00:00
Nikolay Degterinsky
10bfd054d8 Fix style & review 2023-12-08 19:40:09 +00:00
Nikita Mikhaylov
5251548753 Fix tests and build 2023-12-08 17:28:26 +00:00
alesapin
dc7347e0ba
Merge pull request #57271 from hanfei1991/hanfei/keeper_soft_limit
support memory soft limit for keeper
2023-12-08 16:12:47 +01:00
Kseniia Sumarokova
928993f2bd
Merge branch 'master' into fix-materialized-pg-issue-with-generated-columns 2023-12-08 15:37:29 +01:00
Kseniia Sumarokova
d0c5dd3b87
Merge branch 'master' into materialized-postgres-escape-publication 2023-12-08 15:29:10 +01:00
zhongyuankai
7b0f8d44e8
Make DirectoryMonitor handle cluster node list change (#42826) 2023-12-08 14:41:51 +01:00
kssenii
0c40465fec Test 2023-12-08 12:46:59 +01:00
Kseniia Sumarokova
f41d3be4b2
Fix bad merge 2023-12-08 11:28:14 +01:00
Kseniia Sumarokova
de7abe2341
Merge branch 'master' into materialized-postgres-escape-publication 2023-12-08 10:53:39 +01:00
Kseniia Sumarokova
1ec2d29302
Merge pull request #57567 from ClickHouse/kssenii-patch-8
Fix possible segfault in PostgreSQLSource
2023-12-08 10:51:08 +01:00
vdimir
6df715f5d7
Merge pull request #57627 from ClickHouse/prometheus-all-errors
Expose the total number of errors to Prometheus endpoint
2023-12-08 10:42:01 +01:00
robot-clickhouse
129e0349b7 Automatic style fix 2023-12-08 02:33:04 +00:00
Alexey Milovidov
d810bea8e3 Fix test 2023-12-08 03:17:13 +01:00
Alexey Milovidov
01135211e9 Fix test 2023-12-08 03:12:54 +01:00
Alexey Milovidov
ce9e134043 Merge branch 'master' into CurtizJ-fix-ttl-non-deterministic 2023-12-08 03:10:09 +01:00
Vitaly Baranov
b4cac92e28 Add some comments. 2023-12-07 22:18:49 +01:00
robot-clickhouse
f7c3304045 Automatic style fix 2023-12-07 19:42:33 +00:00
Nikita Mikhaylov
0b5b042153 Add test 2023-12-07 20:09:44 +01:00
Azat Khuzhin
2c6604ec24 Allow nodes in config with from_env/from_zk and non empty element with replace=1
Such nodes in config are useful as a nodes with default values, that can
be overwritten from ZooKeeper/env.

So after this patch the following is valid, and is interpreted as
default value 86400, and can be overwritten via env:

```xml
<asynchronous_metrics_update_period_s replace="1" from_env="CH_ASYNCHRONOUS_METRICS_UPDATE_PERIOD_S">86400</asynchronous_metrics_update_period_s>
```

While the following is not:

```xml
<asynchronous_metrics_update_period_s             from_env="CH_ASYNCHRONOUS_METRICS_UPDATE_PERIOD_S">86400</asynchronous_metrics_update_period_s>
```

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-07 18:01:40 +01:00
kssenii
188d4d66c9 Merge with master 2023-12-07 12:45:36 +01:00
kssenii
0486631f4c Fxi 2023-12-07 12:44:00 +01:00
robot-clickhouse
6cf7f75fb4 Automatic style fix 2023-12-07 10:11:44 +00:00
kssenii
246eeee2df Merge remote-tracking branch 'origin/master' into materialized-postgres-escape-publication 2023-12-07 10:48:15 +01:00
kssenii
56b20b6d36 Merge remote-tracking branch 'origin/master' into add-a-test-for-issue-with-table-override 2023-12-07 10:46:08 +01:00
kssenii
bbddd330c6 Add forgotten change 2023-12-07 10:46:00 +01:00
Kseniia Sumarokova
b3f22449f6
Merge pull request #57515 from ClickHouse/fix-materialized-pg-issue-with-incorrect-connection-options
MaterializedPostgreSQL: fix issue #41922, add test for #41923
2023-12-07 10:42:14 +01:00
Nikolay Degterinsky
995b51ef73 Allow avoiding resolving hostnames in DDLWorker 2023-12-07 03:43:26 +00:00
Ryan Jacobs
ca790b6eec
apply python style check 2023-12-06 19:26:50 -08:00
Ryan Jacobs
7d41426935
test_storage_postgresql: Add test_postgres_array_ndim_error_messges()
Tests:

1. View with array column cannot be empty --> error message
2. View cannot have empty array --> error message
3. View cannot have NULL array value --> error message
4. Ensures PG identifiers that require quoting do not crash ClickHouse.

These apply to views that contain arrays.
2023-12-06 18:39:09 -08:00
kssenii
f461b5b2d0 Add a test 2023-12-06 23:39:34 +01:00
Alexey Milovidov
05bc8ef1e0
Merge pull request #57548 from ClickHouse/s3queue_production_ready
`S3Queue` is production ready
2023-12-06 22:21:08 +01:00
Ryan Jacobs
119c2864a0
test_storage_postgresql: mixed-case identifier on array column 2023-12-06 12:59:58 -08:00
robot-clickhouse
4dab2515dc Automatic style fix 2023-12-06 19:46:41 +00:00
kssenii
6321576ff8 Add a test 2023-12-06 20:27:41 +01:00
robot-clickhouse
ec5726c1e6 Automatic style fix 2023-12-06 18:58:03 +00:00
kssenii
6368d060b7 Add a test 2023-12-06 19:39:18 +01:00
vdimir
8f32293104
Merge pull request #57416 from ClickHouse/vdimir/fix_test_encrypted_disk
Change type of s3_cache in test_encrypted_disk
2023-12-06 14:37:40 +01:00
Alexey Milovidov
f8de7f6bc2 Merge branch 'master' into s3queue_production_ready 2023-12-06 12:25:29 +01:00
Kseniia Sumarokova
e02883cd4a
Merge branch 'master' into fix-materialized-pg-issue-with-incorrect-connection-options 2023-12-06 12:16:04 +01:00
Alexey Milovidov
76bbeaa676 S3Queue is production ready 2023-12-05 21:10:19 +01:00
Kseniia Sumarokova
f56fe785e8
Update test.py 2023-12-05 18:40:56 +01:00
MikhailBurdukov
c41511e51c ignore_on_cluster_for_grants 2023-12-05 15:11:32 +00:00
Nikolay Degterinsky
a776a5cac5
Merge pull request #57483 from joelynch/stop-listen-tcp-secure
bugfix: correctly parse SYSTEM STOP LISTEN TCP SECURE
2023-12-05 15:25:34 +01:00
robot-clickhouse
fee17abf7a Automatic style fix 2023-12-05 12:40:11 +00:00
kssenii
0d313acd03 Fix 2023-12-05 13:22:35 +01:00
Alexey Milovidov
1f752b79db
Merge pull request #55894 from bharatnc/ncb/hostname-system-log-tables
add hostname column to system log tables
2023-12-05 06:42:43 +01:00
Alexey Milovidov
10d65a1ade
Merge pull request #55559 from azat/s3-fix-excessive-reads
Add ability to disable checksums for S3 to avoid excessive input file read
2023-12-05 06:34:21 +01:00
Bharat Nallan Chakravarthy
942802f308 few more test cases 2023-12-04 14:01:43 -08:00
joelynch
b312a9f4ee
bugfix: parse system stop listen tcp secure 2023-12-04 19:56:35 +01:00
Alexey Milovidov
02439eee58
Merge pull request #49351 from ClickHouse/async-loader-integration
Asynchronous loading of tables
2023-12-04 17:16:12 +01:00
vdimir
a4ae90de0d
Merge pull request #57275 from ClickHouse/vdimir/merge_task_tmp_data
Background merges correctly use temporary data storage in the cache
2023-12-04 14:52:20 +01:00
vdimir
27589f5b0e
Enable temporary_data_in_cache in test_encrypted_disk 2023-12-04 10:34:17 +00:00
vdimir
b2e29d1416
Change type of s3_cache in test_encrypted_disk 2023-12-04 10:34:13 +00:00
Bharat Nallan Chakravarthy
25d1d59c6d fix tests 2023-12-03 20:16:16 -08:00
Bharat Nallan Chakravarthy
440dc66a5c Merge remote-tracking branch 'upstream/master' into ncb/hostname-system-log-tables 2023-12-03 15:19:47 -08:00
Vitaly Baranov
366095affc Fix test test_create_or_drop_tables_during_backup. 2023-12-04 00:15:31 +01:00
Sema Checherinda
32e3b2657b
Merge pull request #57205 from CheSema/zero-locks-leak
fix zero-copy locks leaking
2023-12-02 15:54:12 +01:00
Han Fei
fc0f080cb4 fix black 2023-12-01 20:39:38 +01:00
JackyWoo
8a68d51261
Add index to table system.numbers (#50909) 2023-12-01 19:59:25 +01:00
Han Fei
e4da317f05 fix test 2023-12-01 18:07:45 +01:00
Nikolai Kochetov
0b4131546a
Merge pull request #56813 from jsc0218/SystemTablesFilterEngine
Able to Filter Engine When Scanning System Tables
2023-12-01 16:02:27 +01:00
alesapin
fb98b212c5
Merge pull request #57311 from ClickHouse/make_alter_mat_view_non_experimental
Make alter materialized view non experimental
2023-12-01 12:18:43 +01:00
Sema Checherinda
60bf17ce8a fix style 2023-11-30 21:13:56 +01:00
Sema Checherinda
42f648f0d2 relock block when sessin expired 2023-11-30 21:13:56 +01:00
alesapin
17ac9e3409 Fix test 2023-11-30 19:42:12 +01:00
vdimir
b9860648c1
Remove temporary_data_in_cache from test_merge_tree_s3 2023-11-30 13:27:32 +00:00
Kruglov Pavel
575ee1e665
Merge pull request #56868 from zvonand/zvonand-fileCluster
Introduce `fileCluster` table function
2023-11-30 13:49:53 +01:00
Han Fei
a316b70917 Merge branch 'master' into hanfei/keeper_soft_limit 2023-11-30 12:29:40 +01:00
Alexander Tokmakov
a2dc2d9a53
Mark a setting obsolete (#57336)
* Update Settings.h

* Update InterpreterUndropQuery.cpp

* Update 02888_obsolete_settings.reference

* Update test.py

* Update 02681_undrop_query.sql

* Update 02681_undrop_query_uuid.sh
2023-11-29 19:24:11 +01:00
Alexander Tokmakov
97b63bbbca
Merge pull request #57339 from ClickHouse/fix_ddlworker_hostname_change
Ignore finished ON CLUSTER tasks if hostname changed
2023-11-29 17:46:17 +01:00
Nikolai Kochetov
823ba2db46
Merge pull request #57075 from yariks5s/s3_links_fix
S3-style links bug fix
2023-11-29 17:41:08 +01:00
vdimir
b5babe1692
MergeTask uses temporary data storage 2023-11-29 16:18:32 +00:00
zvonand
c329e382ab resolve conflicts 2023-11-29 16:03:07 +01:00
Han Fei
4c0efb0262
Merge pull request #53240 from hanfei1991/hanfei/statistic
use statistic to order prewhere conditions better
2023-11-29 12:26:44 +01:00
Nikolai Kochetov
731a1bfcf8 Cleanup 2023-11-29 11:11:58 +00:00
Alexander Tokmakov
84abbafcc5 ignore finished ddl tasks if hostname changed 2023-11-29 02:06:52 +01:00
Nikolai Kochetov
4d906d6e3c Cleanup 2023-11-28 18:35:19 +00:00
Yarik Briukhovetskyi
ad9583d6e9
style fix 2023-11-28 19:13:37 +01:00
Yarik Briukhovetskyi
a83a046d54 added tests 2023-11-28 17:33:46 +00:00
Nikolai Kochetov
08a7575984 Re-implement filtering a bit. 2023-11-28 16:17:35 +00:00
Han Fei
6733438adc Merge branch 'master' into hanfei/statistic 2023-11-28 16:35:00 +01:00
zvonand
c306d21b54 merge master + resolve conflicts 2023-11-28 15:51:21 +01:00
Han Fei
3aa4a6ae2c check integration test 2023-11-28 14:47:31 +01:00
Antonio Andelic
9dd4783675 Merge branch 'master' into fix-readonly-replica 2023-11-28 10:43:29 +00:00
vdimir
ae09d04578
Merge pull request #57154 from ClickHouse/vdimir/params_test_check_table
Minor changes in test_check_table
2023-11-28 11:10:26 +01:00
Han Fei
7bd2ea3add Merge branch 'master' into hanfei/statistic 2023-11-27 23:31:23 +01:00
Han Fei
8e1b61cc13 fix style 2023-11-27 22:03:05 +01:00
Nikolai Kochetov
e1b00b3ee0 Merge branch 'master' into SystemTablesFilterEngine 2023-11-27 18:54:21 +00:00
Han Fei
347efc669e support memory soft limit for keeper 2023-11-27 18:28:10 +01:00
Antonio Andelic
2ea44adefd Add test 2023-11-27 15:05:56 +00:00
Antonio Andelic
9707796869 Ignore comments when comparing column descriptions 2023-11-27 12:25:41 +00:00
MikhailBurdukov
6f19e8ebd1
Merge branch 'master' into native_copy_for_s3_disks 2023-11-27 14:25:36 +03:00
MikhailBurdukov
c10c30832c Review fix 2023-11-27 10:58:30 +00:00
Kruglov Pavel
b10e46b2bc
Merge pull request #57126 from Avogar/size-virtual-column
Add _size virtual column to s3/file/hdfs/url/azureBlobStorage engines
2023-11-27 10:12:18 +01:00
Bharat Nallan Chakravarthy
6454687fa6 Merge remote-tracking branch 'upstream/master' into ncb/hostname-system-log-tables 2023-11-26 16:24:18 -08:00
Azat Khuzhin
1168b7910b Update test_throttling with enabled s3_disable_checksum
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-11-26 20:03:33 +01:00
Vitaly Baranov
4fed61e8ca
Merge pull request #57146 from vitlibar/fix-test_replicated_merge_tree_encryption_codec_different_keys_2
Fix test test_replicated_merge_tree_encryption_codec/test.py::test_different_keys
2023-11-25 09:36:33 +01:00
Alexey Milovidov
c478acab42
Merge pull request #57206 from azat/tests/test_distributed_storage_configuration
Fix test_distributed_storage_configuration flakiness
2023-11-25 02:57:51 +01:00
Sema Checherinda
abd399705e
Merge pull request #57025 from CheSema/s3_engine_heavy_write_check_mem
test_s3_engine_heavy_write_check_mem: turn test off
2023-11-24 21:07:35 +01:00
Azat Khuzhin
d0b4917fd3 Fix test_distributed_storage_configuration flakiness
It fails [1] due to extra reservation on disk2 for some system.*_log
tables, sure we can turn them off, but better to fix it explicitly with
a separate policy.

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/0/98cddf5312722e403dcea429639ac13dc6cada33/integration_tests__tsan__[2_6].html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-11-24 20:28:18 +01:00
Alexey Milovidov
411660c267 Fix integration tests 2023-11-24 17:35:56 +01:00
Vitaly Baranov
5769a88b92
Merge pull request #57133 from vitlibar/change-default-for-wait_dictionaries_load_at_startup
Change the default for wait_dictionaries_load_at_startup to true
2023-11-24 17:09:05 +01:00
Vitaly Baranov
683827c6df Add comment. 2023-11-24 14:01:52 +01:00
vdimir
3b4f70a811
Minor changes in test_check_table 2023-11-23 16:24:11 +00:00
Vitaly Baranov
eabdc76e7c Fix test test_replicated_merge_tree_encryption_codec/test.py::test_different_keys 2023-11-23 15:36:11 +01:00
Vitaly Baranov
5f461ff780 Change the default for "wait_dictionaries_load_at_startup" to true,
and use this setting only if "dictionaries_lazy_load" is false.
2023-11-23 14:45:42 +01:00
Aleksei Filatov
1a03f5f7f4 Merge remote-tracking branch 'upstream/master' into add_cancellation_point_for_moving_background_operation 2023-11-23 16:43:33 +03:00
avogar
e3afb4182b Fix tests 2023-11-23 11:10:41 +00:00
serxa
0fc25fbda8 Merge branch 'master' into async-loader-integration 2023-11-23 09:32:43 +00:00
jsc0218
aba2f0e4b2 Fix Style 2023-11-22 20:02:15 +00:00
jsc0218
a1bde09c9c move the test from stateless to integration 2023-11-22 19:13:13 +00:00
Kruglov Pavel
b84e3cf683
Merge branch 'master' into size-virtual-column 2023-11-22 19:25:00 +01:00
avogar
193f8a5d23 Add test for azure 2023-11-22 18:12:50 +00:00
zvonand
5153798aeb Introduced fileCluster table function
Added fileCluster function
Added test and docs
2023-11-22 15:06:04 +01:00
Kruglov Pavel
9fb1acc947
Merge pull request #56810 from Avogar/iceberg-metadata-files
Iceberg metadata files
2023-11-22 14:40:04 +01:00
Sema Checherinda
adf4ade00a
Update tests/integration/test_merge_tree_s3/test.py 2023-11-22 13:38:15 +01:00
Kseniia Sumarokova
e4f66b8469
Merge pull request #55158 from kssenii/fs-cache-improvement
fs cache improvement for big reads
2023-11-21 21:50:00 +01:00