thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-30 05:30:51 +00:00
Code Issues Packages Projects Releases Wiki Activity
50,960 Commits 8,961 Branches 1,767 Tags 1.8 GiB
579f4c50ed
Commit Graph

6853 Commits

Author SHA1 Message Date
Maxim Akhmedov
3627fabfb9 Remove -g0 form Arcadia build settings. 2020-10-29 17:37:23 +03:00
tavplubix
2a66c17472
Update InterpreterDropQuery.cpp 2020-10-29 16:37:59 +03:00
alesapin
40fc512e79 Merge branch 'master' into no_background_pool_no_more 2020-10-29 12:53:34 +03:00
Azat Khuzhin
b42f77a791 Covert error codes list to lookup table and drop generation of them. 2020-10-29 10:55:41 +03:00
Azat Khuzhin
b7eac807f5 Fix readability-qualified-auto in errorCodeToName() 2020-10-29 10:55:41 +03:00
Azat Khuzhin
a81b0418ac Make errorCodeToName() return LowCardinality(String) 2020-10-29 10:55:41 +03:00
Azat Khuzhin
b2e2322895 Add system.errors table 
Contains error codes with number of times they have been triggered.

Columns:

-   `name` ([String](../../sql-reference/data-types/string.md)) — name of the error (`errorCodeToName`).
-   `code` ([Int32](../../sql-reference/data-types/int-uint.md)) — code number of the error.
-   `value` ([UInt64](../../sql-reference/data-types/int-uint.md)) - number of times this error has been happened.

**Example**

``` sql
SELECT *
FROM system.errors
WHERE value > 0
ORDER BY code ASC
LIMIT 1

┌─name─────────────┬─code─┬─value─┐
│ CANNOT_OPEN_FILE │   76 │     1 │
└──────────────────┴──────┴───────┘
 2020-10-29 10:55:38 +03:00
Azat Khuzhin
3fb8d08dd4 Add errorCodeToName() function 
This patch adds errorCode() function that will return macro name by the
exception code, useful for analyzing query_log and similar.

Later some descriptions can be added.

v2: replace hana::map/fusion::vector with external script
v3:
- use binary cmake dir for .sh
- use jump table over suboptimal std::unordered_map (with very poor hash
  function for int -- std::hash)
- cleanup errorCodeToName (drop extra templates and headers)
- rename errorCode -> errorCodeToName
- fix arcadia build (by not providing those helpers there)
- fix build on CI, by using CMAKE_CXX_COMPILER for parsing the file
 2020-10-29 10:55:00 +03:00
taichong
bb1ac2af82 Shrink sequence gtid set 
when use MySQL Master -> MySQL Slave -> ClickHouse MaterializeMySQL
Engine

and MySQL Slave enable slave_parallel_worker the gtid in .metadata won't
shrink.

Like this:

https://github.com/ClickHouse/ClickHouse/issues/15951
 2020-10-29 15:11:27 +08:00
Nikolai Kochetov
671d2b7f1b
Update MergeTreeReadPool.cpp 
Fix comment
 2020-10-29 10:04:23 +03:00
alexey-milovidov
0faf2bc7e3
Merge pull request #16332 from ClickHouse/fix-queue-processing-of-very-large-entries 
Fix processing of very large entries in queue
 2020-10-29 09:09:29 +03:00
Alexey Milovidov
2e0a979e3a Fix inconsistency in FormatFactory 2020-10-29 06:39:43 +03:00
Alexey Milovidov
1e99ce5f3a Merge branch 'master' into decimal-round-fuzz 2020-10-29 04:57:43 +03:00
alexey-milovidov
bf3acecf6f
Merge pull request #16032 from Avogar/mysql_bug 
Don't touch MySQL database if it's unnecessary
 2020-10-29 04:14:26 +03:00
Nikolai Kochetov
10bad32fb4 Refactor code a little bit. Add comment. 2020-10-29 00:52:26 +03:00
Amos Bird
f995ef9797
Balanced reading from JBOD 2020-10-29 04:05:07 +08:00
alesapin
57c3935a26
Merge pull request #16426 from kssenii/rabbit-optimize 
Optimize rabbitmq engine
 2020-10-28 22:24:22 +03:00
tavplubix
a1f1db753b
Update CompressedReadBufferBase.cpp 2020-10-28 18:23:10 +03:00
alesapin
9830ff1003
Merge pull request #16094 from nvartolomei/nv/wal-metadata-compatibility 
RFC: Add metadata section to MergeTreeWriteAheadLog
 2020-10-28 15:54:46 +03:00
alesapin
8e8bdeb5d7
Merge pull request #16434 from ClickHouse/fix_fake_race_on_merges_list 
Fix fake race condition on system.merges merge_algorithm
 2020-10-28 15:51:53 +03:00
tavplubix
cd70dc82cd
Merge pull request #16409 from azat/drop-distributed-fix 
Fix DROP TABLE for Distributed (racy with INSERT)
 2020-10-28 14:10:32 +03:00
alesapin
3c31a5134e Fix bug 2020-10-28 14:03:26 +03:00
tavplubix
4a63f1271b
Merge pull request #16244 from ClickHouse/fix_race_data_parts_exchange_endpoint 
Fix race on StorageReplicatedMergeTree::data_parts_exchange_endpoint
 2020-10-28 13:25:55 +03:00
tavplubix
22847613d1
Merge pull request #16437 from ClickHouse/addition_to_16127 
Addition to #16127
 2020-10-28 13:03:13 +03:00
alesapin
c10370f98d Merge branch 'master' into fix-queue-processing-of-very-large-entries 2020-10-28 11:19:34 +03:00
alesapin
8a6be1602b
Merge pull request #16364 from ClickHouse/fix_uuid_mapping_exists 
Minor improvements in DatabaseCatalog
 2020-10-28 10:54:39 +03:00
alesapin
617e42ddb4
Merge branch 'master' into rabbit-optimize 2020-10-28 10:24:05 +03:00
alesapin
1c9e24b5e2 Merge branch 'master' into system_fetches_table 2020-10-28 10:20:04 +03:00
alexey-milovidov
df828a6a6c
Merge pull request #16410 from ClickHouse/fix-quantile-deterministic 
Fix debug assertion in quantileDeterministic function.
 2020-10-28 09:24:46 +03:00
Alexander Kuzmenkov
ba34145817
Merge pull request #16425 from filimonov/minumum 
Fix typos reported by codespell
 2020-10-28 08:07:18 +03:00
Alexey Milovidov
7254f40ba8 Add range check for "scale" argument of decimal rounding function to prevent overflow 2020-10-28 04:16:52 +03:00
Alexey Milovidov
f573aeb97e Whitespace 2020-10-28 03:32:31 +03:00
Alexander Tokmakov
05099bebcf fix 2020-10-28 03:29:18 +03:00
alexey-milovidov
4911f334bf
Merge pull request #16429 from ClickHouse/dict-get-load-exception 
Fix another double free for shared exception message in case of dictGet from not loaded dictionary
 2020-10-28 02:07:03 +03:00
alexey-milovidov
948ac657dc
Merge pull request #16406 from ClickHouse/fix-tsan-lgamma 
Fix TSan report in lgamma
 2020-10-28 01:59:50 +03:00
Alexander Tokmakov
b5ccb5ed5b review suggestions 2020-10-27 23:52:49 +03:00
kssenii
4b59882c30 Remove redundant, add virt col 2020-10-27 20:34:31 +00:00
Alexander Tokmakov
dba8c85ae4 do not wait while holding lock 2020-10-27 22:56:54 +03:00
Alexander Kuzmenkov
6509f1eb39
Merge branch 'master' into minumum 2020-10-27 21:38:23 +03:00
Azat Khuzhin
fc14fde24a Fix DROP TABLE for Distributed (racy with INSERT) 
<details>

```

drop() on T1275:

    0  DB::StorageDistributed::drop (this=0x7f9ed34f0000) at ../contrib/libcxx/include/__hash_table:966
    1  0x000000000d557242 in DB::DatabaseOnDisk::dropTable (this=0x7f9fc22706d8, context=..., table_name=...)
       at ../contrib/libcxx/include/new:340
    2  0x000000000d6fcf7c in DB::InterpreterDropQuery::executeToTable (this=this@entry=0x7f9e42560dc0, query=...)
       at ../contrib/libcxx/include/memory:3826
    3  0x000000000d6ff5ee in DB::InterpreterDropQuery::execute (this=0x7f9e42560dc0) at ../src/Interpreters/InterpreterDropQuery.cpp:50
    4  0x000000000daa40c0 in DB::executeQueryImpl (begin=<optimized out>, end=<optimized out>, context=..., internal=<optimized out>,
       stage=DB::QueryProcessingStage::Complete, has_query_tail=false, istr=0x0) at ../src/Interpreters/executeQuery.cpp:420
    5  0x000000000daa59df in DB::executeQuery (query=..., context=..., internal=internal@entry=false, stage=<optimized out>,
       may_have_embedded_data=<optimized out>) at ../contrib/libcxx/include/string:1487
    6  0x000000000e1369e6 in DB::TCPHandler::runImpl (this=this@entry=0x7f9ddf3a9000) at ../src/Server/TCPHandler.cpp:254
    7  0x000000000e1379c9 in DB::TCPHandler::run (this=0x7f9ddf3a9000) at ../src/Server/TCPHandler.cpp:1326
    8  0x000000001086fac7 in Poco::Net::TCPServerConnection::start (this=this@entry=0x7f9ddf3a9000)
       at ../contrib/poco/Net/src/TCPServerConnection.cpp:43
    9  0x000000001086ff2b in Poco::Net::TCPServerDispatcher::run (this=0x7f9e4eba5c00)
       at ../contrib/poco/Net/src/TCPServerDispatcher.cpp:114
    10 0x00000000109dbe8e in Poco::PooledThread::run (this=0x7f9e4a2d2f80) at ../contrib/poco/Foundation/src/ThreadPool.cpp:199
    11 0x00000000109d78f9 in Poco::ThreadImpl::runnableEntry (pThread=<optimized out>)
       at ../contrib/poco/Foundation/include/Poco/SharedPtr.h:401
    12 0x00007f9fc3cccea7 in start_thread (arg=<optimized out>) at pthread_create.c:477
    13 0x00007f9fc3bebeaf in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

StorageDistributedDirectoryMonitor on T166:

    0  DB::StorageDistributedDirectoryMonitor::StorageDistributedDirectoryMonitor (this=0x7f9ea7ab1400, storage_=..., path_=...,
       pool_=..., monitor_blocker_=..., bg_pool_=...) at ../src/Storages/Distributed/DirectoryMonitor.cpp:81
    1  0x000000000dbf684e in std::__1::make_unique<> () at ../contrib/libcxx/include/memory:3474
    2  DB::StorageDistributed::requireDirectoryMonitor (this=0x7f9ed34f0000, disk=..., name=...)
       at ../src/Storages/StorageDistributed.cpp:682
    3  0x000000000de3d5fa in DB::DistributedBlockOutputStream::writeToShard (this=this@entry=0x7f9ed39c7418, block=..., dir_names=...)
       at ../src/Storages/Distributed/DistributedBlockOutputStream.cpp:634
    4  0x000000000de3e214 in DB::DistributedBlockOutputStream::writeAsyncImpl (this=this@entry=0x7f9ed39c7418, block=...,
       shard_id=shard_id@entry=79) at ../src/Storages/Distributed/DistributedBlockOutputStream.cpp:539
    5  0x000000000de3e47b in DB::DistributedBlockOutputStream::writeSplitAsync (this=this@entry=0x7f9ed39c7418, block=...)
       at ../contrib/libcxx/include/vector:1546
    6  0x000000000de3eab0 in DB::DistributedBlockOutputStream::writeAsync (block=..., this=0x7f9ed39c7418)
       at ../src/Storages/Distributed/DistributedBlockOutputStream.cpp:141
    7  DB::DistributedBlockOutputStream::write (this=0x7f9ed39c7418, block=...)
       at ../src/Storages/Distributed/DistributedBlockOutputStream.cpp:135
    8  0x000000000d73b376 in DB::PushingToViewsBlockOutputStream::write (this=this@entry=0x7f9ea7a8cf58, block=...)
       at ../src/DataStreams/PushingToViewsBlockOutputStream.cpp:157
    9  0x000000000d7853eb in DB::AddingDefaultBlockOutputStream::write (this=0x7f9ed383d118, block=...)
       at ../contrib/libcxx/include/memory:3826
    10 0x000000000d740790 in DB::SquashingBlockOutputStream::write (this=0x7f9ed383de18, block=...)
       at ../contrib/libcxx/include/memory:3826
    11 0x000000000d68c308 in DB::CountingBlockOutputStream::write (this=0x7f9ea7ac6d60, block=...)
       at ../contrib/libcxx/include/memory:3826
    12 0x000000000ddab449 in DB::StorageBuffer::writeBlockToDestination (this=this@entry=0x7f9fbd56a000, block=..., table=...)
       at ../src/Storages/StorageBuffer.cpp:747
    13 0x000000000ddabfa6 in DB::StorageBuffer::flushBuffer (this=this@entry=0x7f9fbd56a000, buffer=...,
       check_thresholds=check_thresholds@entry=true, locked=locked@entry=false, reset_block_structure=reset_block_structure@entry=false)
       at ../src/Storages/StorageBuffer.cpp:661
    14 0x000000000ddac415 in DB::StorageBuffer::flushAllBuffers (reset_blocks_structure=false, check_thresholds=true, this=0x7f9fbd56a000)
        at ../src/Storages/StorageBuffer.cpp:605

shutdown() on T1275:

    0  DB::StorageDistributed::shutdown (this=0x7f9ed34f0000) at ../contrib/libcxx/include/atomic:1612
    1  0x000000000d6fd938 in DB::InterpreterDropQuery::executeToTable (this=this@entry=0x7f98530c79a0, query=...)
       at ../src/Storages/TableLockHolder.h:12
    2  0x000000000d6ff5ee in DB::InterpreterDropQuery::execute (this=0x7f98530c79a0) at ../src/Interpreters/InterpreterDropQuery.cpp:50
    3  0x000000000daa40c0 in DB::executeQueryImpl (begin=<optimized out>, end=<optimized out>, context=..., internal=<optimized out>,
       stage=DB::QueryProcessingStage::Complete, has_query_tail=false, istr=0x0) at ../src/Interpreters/executeQuery.cpp:420
    4  0x000000000daa59df in DB::executeQuery (query=..., context=..., internal=internal@entry=false, stage=<optimized out>,
       may_have_embedded_data=<optimized out>) at ../contrib/libcxx/include/string:1487
    5  0x000000000e1369e6 in DB::TCPHandler::runImpl (this=this@entry=0x7f9ddf3a9000) at ../src/Server/TCPHandler.cpp:254
    6  0x000000000e1379c9 in DB::TCPHandler::run (this=0x7f9ddf3a9000) at ../src/Server/TCPHandler.cpp:1326
    7  0x000000001086fac7 in Poco::Net::TCPServerConnection::start (this=this@entry=0x7f9ddf3a9000)
       at ../contrib/poco/Net/src/TCPServerConnection.cpp:43
    8  0x000000001086ff2b in Poco::Net::TCPServerDispatcher::run (this=0x7f9e4eba5c00)
       at ../contrib/poco/Net/src/TCPServerDispatcher.cpp:114
    9  0x00000000109dbe8e in Poco::PooledThread::run (this=0x7f9e4a2d2f80) at ../contrib/poco/Foundation/src/ThreadPool.cpp:199
    10 0x00000000109d78f9 in Poco::ThreadImpl::runnableEntry (pThread=<optimized out>)
       at ../contrib/poco/Foundation/include/Poco/SharedPtr.h:401
    11 0x00007f9fc3cccea7 in start_thread (arg=<optimized out>) at pthread_create.c:477
    12 0x00007f9fc3bebeaf in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

```

</details>
 2020-10-27 21:19:36 +03:00
Nikolai Kochetov
c7236a9359 Try fix tests. 2020-10-27 19:12:53 +03:00
alesapin
3ec5fc7a4c Add explicit 2020-10-27 18:29:06 +03:00
alesapin
60f2d822d7 Fix fake race condition on system.merges merge_algorithm 2020-10-27 18:27:12 +03:00
alexey-milovidov
42eb784a26
Update AggregateFunctionWelchTTest.h 2020-10-27 17:55:19 +03:00
alexey-milovidov
382a6e62ec
Update AggregateFunctionStudentTTest.h 2020-10-27 17:55:03 +03:00
Nikolai Kochetov
71298ba496 Move fix to ExternalLoader::checkLoaded. 2020-10-27 17:21:51 +03:00
Alexander Kuzmenkov
60544ad46e
Merge pull request #16373 from ClickHouse/better-rethrow 
Better exceptions rethrow
 2020-10-27 16:38:32 +03:00
Alexander Kuzmenkov
e35be8eae3
Merge pull request #16407 from ClickHouse/agg-functions-case-sensitive 
Some aggregate functions were erroneously marked as case-insensitive
 2020-10-27 16:36:03 +03:00
Alexander Kuzmenkov
766560c138
Merge pull request #14195 from ClickHouse/aku/opentelemetry 
[wip] add some opentelemetry support
 2020-10-27 16:14:21 +03:00
alesapin
6253d1466a Fix comments 2020-10-27 16:09:14 +03:00
Nikolai Kochetov
afc28c84a0 Fix double free for shared exception message in case of dictGet from not loaded dictionary. 2020-10-27 16:07:58 +03:00
alesapin
3d3d246bdc Rename table 2020-10-27 16:07:50 +03:00
alesapin
e40c509392 More clear callback name 2020-10-27 16:00:40 +03:00
alesapin
f35edfb2a5 Remove some unused fields 2020-10-27 15:57:55 +03:00
alesapin
ee4e6caf70 Remove redundant metric increment 2020-10-27 15:52:49 +03:00
alesapin
db16942716 Better comment 2020-10-27 15:50:43 +03:00
alesapin
3824fcb076 Rename file and some tweaks 2020-10-27 15:47:42 +03:00
alesapin
31d63efdac Fix style 2020-10-27 15:26:10 +03:00
alesapin
dca35b1913 Add awesome test for fetch 2020-10-27 15:24:10 +03:00
kssenii
a48bc83763 Fix style 2020-10-27 12:04:07 +00:00
Pavel Kruglov
331545fe0d Fix typo 2020-10-27 14:29:36 +03:00
Mikhail Filimonov
41971e073a
Fix typos reported by codespell 2020-10-27 12:04:03 +01:00
kssenii
db03cd7dd7 Much more optimal queues setup 2020-10-27 11:00:01 +00:00
kssenii
7beddceadd Fix bug that caused awful CPU usage 2020-10-27 10:02:27 +00:00
kssenii
cd0dbcb9d8 Minimize event loop lifetime 2020-10-27 10:01:39 +00:00
alesapin
d6130f13ef Add table to system tables 2020-10-27 10:21:49 +03:00
alexey-milovidov
30325689c4
Merge pull request #16397 from CurtizJ/fix-group-by-modifiers 
Fix group by with modifiers.
 2020-10-27 02:10:44 +03:00
Alexey Milovidov
59910991b6 Fix "Darwin" 2020-10-27 00:33:46 +03:00
alexey-milovidov
a34b0880c3
Update ReservoirSamplerDeterministic.h 2020-10-27 00:21:56 +03:00
Alexey Milovidov
73f3aac663 Fix assert error in quantileDeterministic #15683 2020-10-27 00:07:24 +03:00
Alexey Milovidov
cd597bf494 Merge branch 'master' into better-rethrow 2020-10-26 22:29:49 +03:00
Alexey Milovidov
740cf8ce82 Some aggregate functions were erroneously marked as case-insensitive 2020-10-26 22:20:40 +03:00
Alexey Milovidov
32ed8c9681 Fix trailing whitespace 2020-10-26 22:12:40 +03:00
Alexey Milovidov
e449266a16 Fix TSan report in lgamma 2020-10-26 22:06:30 +03:00
alesapin
880f4bbd05 System fetches 2020-10-26 19:38:35 +03:00
Alexander Kuzmenkov
5a70e26c70 Merge remote-tracking branch 'origin/master' into HEAD 2020-10-26 19:21:13 +03:00
Alexander Kuzmenkov
6552613118
Merge pull request #16280 from filimonov/clickhouse-local-tmp-folder 
clickhouse-local can work without tmp directory
 2020-10-26 19:10:15 +03:00
Alexander Kuzmenkov
79a6be08d1
Update src/Interpreters/Context.cpp 2020-10-26 19:09:53 +03:00
Nikolai Kochetov
42836c86e2
Merge pull request #16386 from ClickHouse/more-introspection-for-exception-double-free 
Check exception message is poisoned in ExpressionActions.
 2020-10-26 18:08:54 +03:00
Anton Popov
ab4c43cb81 fix group by with totals/rollup/cube modifers and min/max functions over group by keys 2020-10-26 16:48:11 +03:00
Anton Popov
5fbca7d62d
Merge pull request #16337 from kitaisreal/uuid-safe-cast-functions-added 
UUID safe cast functions added
 2020-10-26 16:03:27 +03:00
alesapin
9ed4668dbb Refactor common part of background list 2020-10-26 15:40:55 +03:00
Nikolai Kochetov
4e8bea397b
Update ExpressionActions.cpp 2020-10-26 15:10:16 +03:00
Nikolai Kochetov
3151de1b4e Update ColumnConst include. 2020-10-26 13:26:52 +03:00
alesapin
d5d0819698 Merge branch 'master' into no_background_pool_no_more 2020-10-26 12:58:51 +03:00
Nikolai Kochetov
fe9db9866c Check exception message is poisoned in ExpressionActions. 2020-10-26 12:56:50 +03:00
Nikolai Kochetov
02bd35924e
Merge pull request #16242 from ClickHouse/another-one-untuple 
Another one untuple implementation
 2020-10-26 12:26:43 +03:00
alexey-milovidov
3aa49204d6
Update MergeTreeSettings.cpp 2020-10-26 07:39:20 +03:00
Alexey Milovidov
d5e277f080 Better exceptions rethrow 2020-10-26 06:35:57 +03:00
Alexey Milovidov
f8876fe989 Merge branch 'master' into fix-queue-processing-of-very-large-entries 2020-10-26 05:24:59 +03:00
alexey-milovidov
bfe17d7dca
Merge pull request #16358 from azat/dist-insert-fix 
Fix async Distributed INSERT w/ prefer_localhost_replica=0 and internal_replication
 2020-10-26 05:07:35 +03:00
tavplubix
934f64a2fd
Update DatabaseCatalog.cpp 2020-10-26 00:51:30 +03:00
Alexander Tokmakov
f8f2d62d70 minor improvements in DatabaseCatalog 2020-10-25 20:27:21 +03:00
alesapin
f97e6beb70 Remove message broker pool from context 2020-10-25 15:34:18 +03:00
Azat Khuzhin
edc8d6e5e7 Fix async Distributed INSERT w/ prefer_localhost_replica=0 and internal_replication 2020-10-25 14:27:06 +03:00
tavplubix
37de8727ea
Merge branch 'master' into fix/ISSUES-15883 2020-10-25 12:14:16 +03:00
Maksim Kita
440ae2bc57 UUID safe cast functions added 
1. Added readUUIDTextImpl, readUUIDText, tryReadUUIDText functions in
ReadHelpers.
2. Added toUUIDOrNull, toUUIDOrZero functions based on ReadHelpers read
implementations.
3. Updated documentation.
 2020-10-25 11:45:29 +03:00
Alexey Milovidov
22a89fca01 Fix processing very large entries in queue 2020-10-25 05:57:03 +03:00
Alexey Milovidov
a2d888f19f Fix processing very large entries in queue 2020-10-25 05:57:03 +03:00
Alexey Milovidov
79412bf0f5 Merge branch 'master' into https-sni 2020-10-25 04:45:42 +03:00
Alexey Milovidov
2613012fd1 Improve performance of FunctionsLogical a little by adding "restrict" 2020-10-25 04:43:06 +03:00
alexey-milovidov
abb9b25fa0
Merge pull request #16343 from ClickHouse/fix-perf-test-functions-logical 
Fix performance test "functions logical" after move to clang
 2020-10-25 04:04:24 +03:00
alexey-milovidov
c13ab94f91
Merge pull request #16344 from ClickHouse/exclamation-marks 
Remove excessive exclamation marks
 2020-10-25 03:13:57 +03:00
alexey-milovidov
74b37f37fb
Merge pull request #16329 from ClickHouse/better-diagnostics-when-client-dropped-connection 
Better diagnostics when client has dropped connection
 2020-10-25 01:01:12 +03:00
Alexey Milovidov
8b21ef5d4f Remove excessive exclamation marks 2020-10-25 00:50:52 +03:00
Alexey Milovidov
9d50921e52 Fix performance test "functions logical" after move to clang 2020-10-24 23:55:17 +03:00
Ivan
1d170f5745
ASTTableIdentifier Part #1: improve internal representation of ASTIdentifier name (#16149) 
* Use only |name_parts| as primary name source

* Restore legacy logic for table restoration

* Fix build

* Fix tests

* Add pytest server config

* Fix tests

* Fixes due to review
 2020-10-24 21:46:10 +03:00
Alexey Milovidov
8a98275a04 Merge branch 'master' of github.com:yandex/ClickHouse into https-sni 2020-10-24 21:43:48 +03:00
alexey-milovidov
70427bfa63
Merge pull request #16335 from kexianda/fix 
minor fix.
 2020-10-24 21:41:35 +03:00
alexey-milovidov
34b9d15b66
Update ThreadStatusExt.cpp 2020-10-24 21:34:54 +03:00
alexey-milovidov
e00f6c4a0d
Merge branch 'master' into total_memory_tracker-by-default 2020-10-24 21:17:53 +03:00
Nikita Mikhaylov
58b4342998
Merge pull request #15874 from nikitamikhaylov/welch-t-test 
Student and Welch t-test
 2020-10-24 15:13:12 +03:00
Xianda Ke
97d84dd855 minor fix. 
redundant variable, duplicated defination of the variable aad_data
compiler error: variable ‘aad_value’ set but not used [-Werror=unused-but-set-variable]
 2020-10-24 17:37:51 +08:00
alexey-milovidov
1a1a6350aa
Merge pull request #16285 from sundy-li/cmake-roaring 
try use cmake version for croaring instead of amalgamation.sh
 2020-10-24 11:07:32 +03:00
Alexey Milovidov
da6b4b29ff Merge branch 'master' into https-sni 2020-10-24 09:31:06 +03:00
alexey-milovidov
32e0de5121
Merge pull request #16071 from hczhcz/patch-1 
Change error message in function if & ifNull
 2020-10-24 07:40:22 +03:00
alexey-milovidov
7e4079dca1
Merge pull request #16286 from ClickHouse/aku/error-context 
Add more context to error messages
 2020-10-24 07:28:36 +03:00
alexey-milovidov
c579611420
Merge pull request #16306 from azat/Set-Join-total-rows-bytes 
Add total_rows/total_bytes support for Set/Join
 2020-10-24 07:26:32 +03:00
Alexey Milovidov
74558a4e27 Better diagnostics when client has dropped connection 2020-10-24 06:41:47 +03:00
alexey-milovidov
6037982343
Merge pull request #16284 from ClickHouse/primary_key_without_order_by 
Add ability to specify PRIMARY KEY without ORDER BY
 2020-10-24 06:05:04 +03:00
sundy-li
21315127a0 remove unused codes in AggregateFunctionGroupBitmapData 2020-10-24 10:05:54 +08:00
alexey-milovidov
91dc8d4cb3
Merge pull request #16264 from amosbird/ssmfix 
Fix TwoLevelStringHashTable bug
 2020-10-24 01:00:27 +03:00
Alexey Milovidov
13b8dce792 Update contributors 2020-10-24 00:26:22 +03:00
nikitamikhaylov
fe9440689a better 2020-10-24 00:05:24 +03:00
tavplubix
790950ea56
Merge pull request #15934 from ClickHouse/ddl_queries_fixes 
Fixes for DDL queries
 2020-10-23 23:52:13 +03:00
nikitamikhaylov
a949293f95 better 2020-10-23 23:27:38 +03:00
nikitamikhaylov
0064a75916 Merge branch 'master' of github.com:ClickHouse/ClickHouse into welch-t-test 2020-10-23 23:06:15 +03:00
nikitamikhaylov
d908cddb49 done 2020-10-23 22:09:02 +03:00
tavplubix
587f83b2ef
Merge branch 'master' into atomic-drop-database-sync 2020-10-23 21:54:26 +03:00
Azat Khuzhin
4d1385ef19 Add total_rows/total_bytes support for Set/Join 2020-10-23 21:11:55 +03:00
Azat Khuzhin
0cccf3049a Fix parent memory tracker during query detaching 2020-10-23 21:07:53 +03:00
Azat Khuzhin
114ea9b1eb Fix accounting for new/delete from different threads for VariableContext::Thread 
MemoryTracker assumes that for VariableContext::Thread new/delete may be
called from different threads, hence the amount of memory can go
negative.

However the MemoryTracker is nested, so even if the negative amount is
allowed for VariableContext::Thread it does not allowed for anything
upper, and hence the MemoryTracking will not be decremented properly.

Fix this, by passing initial size to the parent free.

This should fix memory drift for HTTP queries.
 2020-10-23 21:07:52 +03:00
Azat Khuzhin
72d7b6117e Use total_memory_tracker when there is no other MemoryTracker object. 
This should significantly reduce the MemoryTracking drift, test shows
that there is 0 drift after query storm (100 queries, via http/tcp/tcp
in one session).

TL;DR;

To track memory, clickhouse creates memory tracker object for each
thread **explicitly**, but until it is not created the memory
allocations are not under account.
There should not be lot of allocations w/o memory tracker, since most of
the time it is created early enough, but even this maybe enough to
trigger some problems.

Plus sometimes it is not possible to create it, for example some 3d
party library does not allow to do this explicitly:
- for example before #15740 allocations from librdkafka threads,
- or even worse, poco threads, they don't have any routines to do this.
This won't be a problem for `MemoryTracking` metric if the deallocation
will be done from the same thread w/o memory tracker (or vise versa),
but this is not always true.

NOTE, that this will slow down per-thread allocations w/o memory
tracker, since before this patch there were no memory tracking for them
while now they will be accounted in total_memory_tracker, and for
total_memory_tracker max_untracked_memory is always reached.
But this should not be significant.
 2020-10-23 21:07:52 +03:00
alexey-milovidov
840d96255e
Merge pull request #16199 from azat/clang10-build-fix 
Link dbms w/ atomic to fix undefined reference in unbundled build
 2020-10-23 20:17:37 +03:00
Nikolai Kochetov
c808ab878b Review fixed. 2020-10-23 20:15:23 +03:00
Nikolai Kochetov
a2014378fe Remove has_untuple flag 2020-10-23 19:57:22 +03:00
Nikolai Kochetov
5c791edd43 Remove ColumnNameCache 2020-10-23 19:56:11 +03:00
alesapin
bc331a8029 Better set 2020-10-23 19:34:41 +03:00
alesapin
b28894c43b More compatible way 2020-10-23 19:31:51 +03:00
Mikhail Filimonov
f3a18864d5
After CR fixes - better & simpler. Issue in Context::shutdown fixed 2020-10-23 16:57:06 +02:00
Alexander Kuzmenkov
77654eeee8 fixup 2020-10-23 17:35:03 +03:00
Alexander Kuzmenkov
b0a14a41c3 fixup 2020-10-23 17:28:55 +03:00
tavplubix
84b453f4be
Update InterpreterDropQuery.cpp 2020-10-23 17:19:02 +03:00
Alexander Tokmakov
337fe7b81f add comment 2020-10-23 15:53:58 +03:00
Nikita Mikhaylov
cb4945d8b0
Merge pull request #16205 from azat/do-not-cache-dictGet 
Do not cache dictionary for dictGet*/dictHas*
 2020-10-23 15:47:11 +03:00
Alexander Kuzmenkov
d17a49f127 Add more context to error messages 2020-10-23 15:20:07 +03:00
Alexander Kuzmenkov
28c9e66dc1
Merge pull request #15978 from ucasFL/interval-op 
INTERVAL operator support string literal
 2020-10-23 14:44:05 +03:00
sundy-li
f407504a7a try use cmake version for croaring instead of amalgamation.sh 2020-10-23 19:42:21 +08:00
alesapin
59ca0d071c Fix comment 2020-10-23 14:17:37 +03:00
alesapin
69f2f9838e Add ability to specify PRIMARY KEY without ORDER BY 2020-10-23 14:16:27 +03:00
alesapin
39e47c5338 Less strange lambdas 2020-10-23 11:54:00 +03:00
alesapin
033525e27e
Merge pull request #16267 from den-crane/patch-6 
Fix for incorrect error message
 2020-10-23 10:43:34 +03:00
alesapin
6df68d6c80 Merge branch 'master' into no_background_pool_no_more 2020-10-23 10:28:23 +03:00
alexey-milovidov
121ebfdc81
Merge pull request #16249 from traceon/access-storage-added-log 
Add a log message after an access storage is added
 2020-10-23 09:17:10 +03:00
alexey-milovidov
6cd7d46f93
Update AccessControlManager.cpp 2020-10-23 09:13:26 +03:00
Denny Crane
b310d0abb4
Fix for incorrect error message 
max_[table/partition]_size_to_drop can be changed without restart since https://github.com/ClickHouse/ClickHouse/pull/7779
 2020-10-22 15:22:17 -03:00
Alexander Kuzmenkov
5cbf645de4 Merge remote-tracking branch 'origin/master' into tmp 2020-10-22 19:48:02 +03:00
Denis Glazachev
a6439aba44 More specific log messages for each access storage type 2020-10-22 20:47:52 +04:00
Alexander Kuzmenkov
145e2b012f cleanup 2020-10-22 19:47:20 +03:00
Amos Bird
ccf59c6412
Fix definitely wrong bug 2020-10-22 22:56:45 +08:00
alesapin
3c559c699f Merge branch 'blind_fix_of_read_in_order' into no_background_pool_no_more 2020-10-22 17:16:46 +03:00
alesapin
1d07ece5d1 Fix clang tidy warning 2020-10-22 17:15:56 +03:00
alesapin
7a63b373f9 Merge branch 'blind_fix_of_read_in_order' into no_background_pool_no_more 2020-10-22 15:47:11 +03:00
alesapin
4b65d5469f Fix some unrelated performance issues in select parts for merge 2020-10-22 15:41:01 +03:00
Nikolai Kochetov
a42fd18390 Try fix tests. 2020-10-22 15:01:22 +03:00
Nikolai Kochetov
c91b453630 Try fix tests. 2020-10-22 14:08:12 +03:00
Nikolai Kochetov
0902bc96cf Fix build 2020-10-22 14:01:26 +03:00
Nikolai Kochetov
7fa045cff8 Merge branch 'master' into storage-read-query-plan 2020-10-22 13:31:10 +03:00
Nikolai Kochetov
625af670da Fix tests. 2020-10-22 12:47:24 +03:00
Nikolai Kochetov
48142df26c Fix tests. 2020-10-22 11:25:24 +03:00
alesapin
945dd3aa59 Merge branch 'master' into blind_fix_of_read_in_order 2020-10-22 10:37:37 +03:00
Nikolai Kochetov
4a250ef9c6 Fix tests. 2020-10-22 09:58:20 +03:00
alexey-milovidov
f351b52851
Update AccessControlManager.cpp 2020-10-22 07:03:17 +03:00
alexey-milovidov
0433bc2034
Merge pull request #16248 from azat/nullptr_t-build-fix 
Use std::nullptr_t over nullptr_t (build fix)
 2020-10-22 07:02:38 +03:00
Alexey Milovidov
237384bad9 Fix "Arcadia" 2020-10-22 05:26:48 +03:00
Alexey Milovidov
eb0e3a83d0 Support SNI in https connections to remote resources 2020-10-22 05:02:26 +03:00
alexey-milovidov
adeba6bdd8
Merge pull request #15074 from amosbird/btc 
Extend trivial count optimization.
 2020-10-22 02:50:57 +03:00
Denis Glazachev
691b28e98b Add a log message after a storage is added 2020-10-22 02:43:02 +04:00
Azat Khuzhin
6f78243e32 Use std::nullptr_t over nullptr_t 2020-10-22 01:21:06 +03:00
alexey-milovidov
cfaf82ba0c
Merge pull request #16135 from hexiaoting/dev_rankCorr 
Fix inconsistent behaviour of rankCorr function
 2020-10-22 01:15:50 +03:00
alexey-milovidov
222a4d2e9b
Update AggregateFunctionRankCorrelation.h 2020-10-22 01:15:24 +03:00
alexey-milovidov
2ae32e3d5c
Merge pull request #16101 from azat/http-memory-tracking-fixes 
Fix memory tracker settings (for HTTP queries)
 2020-10-22 00:00:47 +03:00
Nikolai Kochetov
69279e6d76 Fix tests. 2020-10-21 23:05:10 +03:00
tavplubix
3c53d47840
Merge pull request #16189 from ClickHouse/fix_assertion_table_function_file 
Fix assertion in table function file()
 2020-10-21 22:38:24 +03:00
Azat Khuzhin
60aae56266 Link dbms w/ atomic to fix undefined reference in unbundled build 
This will fix undefined reference for __atomic_load under clang10 and
unbundled build (libstdc++ shared linkage):

    clickhouse-server: symbol lookup error: /src/ch/clickhouse/.cmake/src/libclickhouse_disksd.so: undefined symbol: __atomic_load

From [1]:

  "libatomic (GNU)

   libgcc_s does not provide an implementation of an atomics library.
   Instead, GCC’s libatomic library can be used to supply these when using
   libgcc_s.

   Note

   Clang does not currently automatically link against libatomic when using
   libgcc_s. You may need to manually add -latomic to support this
   configuration when using non-native atomic operations (if you see link
   errors referring to __atomic_* functions)."

  [1]: https://clang.llvm.org/docs/Toolchain.html
 2020-10-21 22:33:53 +03:00
Alexander Tokmakov
ac42199ae5 fix race on StorageReplicatedMergeTree::data_parts_exchange_endpoint 2020-10-21 22:25:22 +03:00
Nikolai Kochetov
fd77ca8251 Fix tests. 2020-10-21 22:20:52 +03:00
Nikolai Kochetov
69ae6ace47 Add untuple. 2020-10-21 21:17:27 +03:00
Kruglov Pavel
0b75885c8a
Merge branch 'master' into select_final 2020-10-21 20:42:39 +03:00
Pavel Kruglov
89fdeb4e15 Fix style, move setting and add checking level>0 2020-10-21 20:35:31 +03:00
Nikolai Kochetov
a0da588f06 Merge branch 'master' into new-block-for-functions-4 2020-10-21 16:16:58 +03:00
Nikita Mikhaylov
ef5dd73ae0
Merge pull request #16155 from nikitamikhaylov/vladimir-golovchenko-fix-IPvXCIDRToRange 
Merging #15856
 2020-10-21 15:01:30 +03:00
alexey-milovidov
0b7430dda1
Merge pull request #16206 from ClickHouse/fix-memory-tracking 
Fix multiple issues with memory tracking
 2020-10-21 14:34:22 +03:00
alesapin
c53f59dece
Merge pull request #15984 from ClickHouse/fix_insert_mv_dangling_ref 
Fix possibly dangling reference to target table of MV
 2020-10-21 12:13:51 +03:00
alesapin
11ea6d7911 Merge branch 'blind_fix_of_read_in_order' into no_background_pool_no_more 2020-10-21 11:39:48 +03:00
alesapin
b45d42bb9c Maybe devirtualization can help 2020-10-21 11:35:36 +03:00
Nikolai Kochetov
42a90cf533 Fix special build. 2020-10-21 11:32:57 +03:00
alesapin
9f47c82bbd Sleep a little when pool is full 2020-10-21 11:31:57 +03:00
alesapin
b1a13d4884 Merge branch 'blind_fix_of_read_in_order' into no_background_pool_no_more 2020-10-21 10:30:09 +03:00
Nikolai Kochetov
c4c1446111 Fix build. 2020-10-21 09:22:20 +03:00
Nikolai Kochetov
68c9a57788 Merge branch 'master' into new-block-for-functions-4 2020-10-21 09:17:25 +03:00
alexey-milovidov
a7098c2557
Merge pull request #16154 from nvartolomei/nv/max_concurrent_queries_for_all_users 
Add max_concurrent_queries_for_all_users setting
 2020-10-21 04:35:57 +03:00
alexey-milovidov
2913a10fd3
Merge pull request #16198 from azat/fix-comment-in-query_log 
Fix query comments in query_log and server log (w/ enable_global_with_statement)
 2020-10-21 03:40:48 +03:00
alexey-milovidov
db481a33bd
Merge pull request #14135 from ClickHouse/simplify-init-script 
Simplify init script
 2020-10-21 03:37:50 +03:00
Alexey Milovidov
2619efadc8 Fix multiple issues with memory tracking 2020-10-21 03:31:34 +03:00
Nikolai Kochetov
6177996d5b Fix gcc build. 2020-10-21 00:27:01 +03:00
Azat Khuzhin
3559e3355c Do not cache dictionary for dictGet*/dictHas* 
There are places where ExpressionActionsPtr is cached
(StorageDistributed caching it for sharding_key_expr and
optimize_skip_unused_shards), and if the dictionary will be cached
within "query" then cached ExpressionActionsPtr will always have first
version of the query and the dictionary will not be updated after
reload.

For example this will fix dictGet in sharding_key (and similar places,
i.e. when the function context is stored permanently)

Fixes: 01527_dist_sharding_key_dictGet_reload
 2020-10-21 00:22:40 +03:00
alexey-milovidov
8084ce75cb
Merge pull request #16105 from azat/allow_nondeterministic_optimize_skip_unused_shards 
Add allow_nondeterministic_optimize_skip_unused_shards
 2020-10-21 00:16:26 +03:00
alesapin
c77b154398 Better locks in merge tree 2020-10-21 00:10:55 +03:00
alesapin
8097c696de Trying another fix 2020-10-20 23:05:20 +03:00
alexey-milovidov
2b00b5391a
Merge pull request #11844 from Enmk/AES_encrypt_decrypt 
encrypt and decrypt functions
 2020-10-20 22:57:35 +03:00
alexey-milovidov
8998829f66
Merge pull request #15685 from vivarum/enable-parsing-of-input-enum-values-by-id-10682 
Enable parsing enum values by their ids for CSV, TSV and JSON input formats
 2020-10-20 22:52:57 +03:00
Azat Khuzhin
e76066718d Fix query comments in query_log and server log (w/ enable_global_with_statement) 
Plus, I guess that enable_global_with_statement will be enabled by
default someday, so it may become significant.

The enable_global_with_statement had been introduced in #15451

Cc: @amosbird
 2020-10-20 21:10:36 +03:00
Alexey Milovidov
70bf613a28 Merge branch 'simplify-init-script' of github.com:yandex/ClickHouse into simplify-init-script 2020-10-20 21:10:01 +03:00
Alexey Milovidov
1ab9c7fbb7 Merge branch 'master' into simplify-init-script 2020-10-20 21:08:42 +03:00
alexey-milovidov
75a02112bc
Merge pull request #15592 from sundy-li/readonly-metrics 
sub ReadonlyReplica metric when detach readonly tables
 2020-10-20 19:17:52 +03:00
Nikolai Kochetov
19ccce0305 Fix gcc build. 2020-10-20 18:56:05 +03:00
alesapin
439bbd9861 Blind performance fix 2020-10-20 18:30:46 +03:00
Vladimir Chebotarev
aa5f207fd4
Added disable_merges option for volumes in multi-disk configuration (#13956) 
Co-authored-by: Alexander Kazakov <Akazz@users.noreply.github.com>
 2020-10-20 18:10:24 +03:00
Nikolai Kochetov
395b9293d5 Remove double space. 2020-10-20 17:03:54 +03:00
nikitamikhaylov
f33ae7f167 style 2020-10-20 16:34:57 +03:00
Nikolai Kochetov
a1d5adf8d5 Merge branch 'master' into new-block-for-functions-4 2020-10-20 16:16:08 +03:00
alesapin
30ca17b09b Comment to settings 2020-10-20 16:12:25 +03:00
Nikolai Kochetov
295e612343 Fix build and tests. 2020-10-20 16:11:57 +03:00
alesapin
7256d01579 Normal backoff value instead of 10 seconds 2020-10-20 16:11:01 +03:00
nikitamikhaylov
4ce2670ab1 Merge branch 'master' of github.com:ClickHouse/ClickHouse into welch-t-test 2020-10-20 15:59:24 +03:00
Alexander Tokmakov
62a0ee8255 fix assertion in table function file() 2020-10-20 15:29:46 +03:00
vladimir golovchenko
a64bc6c586 Fixed IPv4CIDRToRange/IPv6CIDRToRange functions to pass Const IP address. 2020-10-20 15:06:22 +03:00
Alexander Kuzmenkov
84908df6d8 fix setting parent from HTTP traceparent 2020-10-20 14:35:13 +03:00
alesapin
ce8ee01d75 Fix background moves start 2020-10-20 14:27:50 +03:00
Nicolae Vartolomei
65013fcbd1 Explain why max_concurrent_queries_for_all_users exists 2020-10-20 12:00:04 +01:00
alesapin
d126aa8a09 Merge branch 'master' into no_background_pool_no_more 2020-10-20 12:54:42 +03:00
alexey-milovidov
b4f0e08369
Merge pull request #16158 from ClickHouse/minimal-ui 
Added minimal web UI
 2020-10-20 11:57:56 +03:00
Alexander Kuzmenkov
f3abb76e57 disable traceparent header in Arcadia 
it interferes with the test_clickhouse.TestTracing.test_tracing_via_http_proxy[traceparent] test
 2020-10-20 11:13:21 +03:00
Alexey Milovidov
448c87363c Style 2020-10-20 04:29:34 +03:00
Alexey Milovidov
94592819ad Add comment 2020-10-20 04:29:13 +03:00
alexey-milovidov
5e46e7c670
Merge pull request #15723 from Jokser/idempotent-part-move 
Possibility to move part to another disk/volume if first attempt was failed
 2020-10-20 04:26:50 +03:00
alexey-milovidov
124379cccc
Update IMergeTreeDataPart.h 2020-10-20 04:24:30 +03:00
alexey-milovidov
26517ff08d
Update IMergeTreeDataPart.h 2020-10-20 04:23:23 +03:00
alexey-milovidov
14d9586735
Update AggregateFunctionRankCorrelation.h 2020-10-20 04:18:12 +03:00
Alexey Milovidov
a79460b644 Modify comment 2020-10-20 04:03:03 +03:00
Alexey Milovidov
a091892a13 Fix Arcadia 2020-10-20 04:01:47 +03:00
Alexey Milovidov
a554ca5e62 Added /play handler; added a test 2020-10-20 03:28:33 +03:00
Alexander Kuzmenkov
41ac15a71c fix initial query id 2020-10-20 00:26:10 +03:00
Nikolai Kochetov
9fe51524cc Part 9. 2020-10-20 00:21:10 +03:00
Vitaly Baranov
235a493a25
Merge pull request #12736 from traceon/ldap-any-user-authentication 
Add LDAP user directory support for locally non-existent users
 2020-10-19 23:58:35 +03:00
Nikolai Kochetov
bc58637ec2 Fixing build. 2020-10-19 21:37:44 +03:00
Alexander Kuzmenkov
6dcfd26b29 Merge remote-tracking branch 'origin/master' into tmp 2020-10-19 21:36:30 +03:00
alexey-milovidov
be7776608d
Merge pull request #15933 from ClickHouse/fix-global-in-result 
Fix wrong result in case of GLOBAL IN and PREWHERE
 2020-10-19 21:21:57 +03:00
nikitamikhaylov
7a97329209 Merge branch 'master' of github.com:ClickHouse/ClickHouse into welch-t-test 2020-10-19 18:54:26 +03:00
Nikolai Kochetov
384718e6c3 Part 8. 2020-10-19 18:27:41 +03:00
Nicolae Vartolomei
5a665d1d42 Add max_concurrent_queries_for_all_users setting 
Closes #6636.
 2020-10-19 15:51:28 +01:00
alesapin
e853af9b4f
Merge pull request #15823 from kitaisreal/parser-allow-specify-primary-key-in-column-list 
Parser allow specify primary key in column list
 2020-10-19 17:09:12 +03:00
Nikolai Kochetov
df1af1bd94 Part 7. 2020-10-19 16:42:14 +03:00
Alexander Kuzmenkov
defcd29b31
Merge pull request #16036 from ClickHouse/stress_test_improvemets 
Minor improvements of stress test
 2020-10-19 16:12:30 +03:00
Nicolae Vartolomei
af76ff1dbf RFC: Add metadata section to MergeTreeWriteAheadLog 
Current WAL format doesn't seem to be extendable without breaking
reverse compatibility.

This PR proposes to introduces a metadata section
for each action in the WAL to which optional fields can be added.

Adding new fields is trivial and doesn't have to break backwards
compatibility if these are not critical for correctness.

Metadata contains the minimum version of the reader allowed
to interpret it.

Removing fields is not supported.
 2020-10-19 12:16:31 +01:00
alesapin
514a95c292 Fixup 2020-10-19 12:06:51 +03:00
alesapin
cb139abe2a Better schedule after job already running 2020-10-19 11:47:15 +03:00
alesapin
e09713ece1 Merge branch 'master' into no_background_pool_no_more 2020-10-19 10:58:31 +03:00
alesapin
76a501d7c5 Merge branch 'master' into simplify-init-script 2020-10-19 10:56:40 +03:00
alesapin
963bc57835
Merge pull request #16011 from ClickHouse/fix_alter_add_and_modify_order_by 
Fix alter sorting key for ReplicatedVersionedCollapsingMergeTree
 2020-10-19 10:31:13 +03:00
hexiaoting
6ed6f4f7a2 Fix inconsistent behaviour of rankCorr function 2020-10-19 15:17:33 +08:00
Azat Khuzhin
6200783629 database_atomic_wait_for_drop_and_detach_synchronously/NO DELAY/SYNC for DROP DATABASE 2020-10-19 00:21:39 +03:00
Azat Khuzhin
32c449c34f Add IDatabaseTablesIterator::reset() interface 2020-10-19 00:16:10 +03:00
Nikolai Kochetov
740fad66f3 Part 6. 2020-10-18 22:00:13 +03:00
Nikolai Kochetov
50dcba6df4 Part 5. 2020-10-18 17:49:19 +03:00
feng lv
5254a5ded7 add setting aggregate_functions_null_for_empty 2020-10-18 20:18:31 +08:00
alexey-milovidov
6dc5cb166f
Merge pull request #16082 from CurtizJ/fix-bad-aggregation 
Fix segfault with wrong aggregation in lambdas
 2020-10-18 04:36:29 +03:00
Nikolai Kochetov
ce2f6a0560 Part 4. 2020-10-18 00:41:50 +03:00
Vasily Nemkov
4124538b56 Merge remote-tracking branch 'upstream/master' into AES_encrypt_decrypt 2020-10-18 00:00:13 +03:00
Vasily Nemkov
f0d5ade1c1 Fixed argument checks and updated tests accordingly 2020-10-17 19:50:58 +03:00
Nikolai Kochetov
142ce5ece0 Part 3. 2020-10-17 19:48:53 +03:00
Nikolai Kochetov
21c1a2e44d Part 2. 2020-10-17 18:22:42 +03:00
Nikolai Kochetov
139487a1a0 Part 1. 2020-10-17 17:23:37 +03:00
Azat Khuzhin
082f30a3a1 Introduce ThreadStatus::applyQuerySettings() to reduce copy-paste 2020-10-17 15:01:53 +03:00
Azat Khuzhin
c694bbe822 Read memory/thread related settings in ThreadStatus::attachQueryContext() 
Previous it was read only ThreadStatus::initializeQuery() but there is
no context there yet.
Plus executeQueryImpl() calls only attachQueryContext() and nothing
more.

This is an issue only for queries via HTTP, since via TCP there is
PullingAsyncPipelineExecutor which calls attachTo() by itself.
 2020-10-17 15:01:53 +03:00
Azat Khuzhin
fea788480f Fix QueryScope initialization for HTTPHandler 
This will fix incorrect query_id for the per-thread memory tracker (but
later there will be child tracker, so it is not a big deal).
 2020-10-17 08:55:02 +03:00
zhang2014
d084e05aba ISSUES-15883 support zero length argument with string type 2020-10-17 13:15:00 +08:00
zhang2014
5207be9b32 ISSUES-15883 try fix test failure 2020-10-17 12:36:08 +08:00
Azat Khuzhin
9b8abd44ab Add allow_nondeterministic_optimize_skip_unused_shards 2020-10-17 01:07:02 +03:00
Alexander Tokmakov
c19d2efd88 add more holders 2020-10-16 20:16:58 +03:00
alesapin
518ba2ceb2 Safe random generator 2020-10-16 16:48:12 +03:00
Anton Popov
0de364ec94 fix segfault with wrong aggregation in lambdas 2020-10-16 16:12:30 +03:00
Alexander Tokmakov
026896835c fixes 2020-10-16 15:20:30 +03:00
alesapin
dc1a5abea9 Remove cluster type check during alter 2020-10-16 14:59:58 +03:00
alesapin
c22c760ac1 Fix unit test build 2020-10-16 13:18:56 +03:00
alesapin
7edbe4d276 Add some comments 2020-10-16 13:12:31 +03:00
Pavel Kovalenko
a474bdcabf Merge remote-tracking branch 'origin/master' into idempotent-part-move 2020-10-16 13:02:40 +03:00
hcz
d95229317d
Change error message in function if & ifNull 2020-10-16 17:50:47 +08:00
Mike
e89a3b5d09
Fixing arrayIndex functions when right operand is LC but left is not (#16038) 2020-10-16 12:08:44 +03:00
vivarum
1d9df13b47
Merge branch 'master' into enable-parsing-of-input-enum-values-by-id-10682 2020-10-16 11:07:01 +03:00
alesapin
0fb1f74b2e Trying to schedule better 2020-10-16 11:00:15 +03:00
Vasily Kozhukhovskiy
bffa1ed28c small refactoring of parsing enum values by numeric enum ids 
(for CSV, TSV, JSON formats)
 2020-10-16 10:50:20 +03:00
alesapin
280d0c55c2 Merge branch 'master' into no_background_pool_no_more 2020-10-16 10:25:02 +03:00
alesapin
0bb4480fee
Merge pull request #16031 from ClickHouse/database_atomic_patch 
Minor fix for DatabaseAtomic
 2020-10-16 10:08:04 +03:00
alesapin
07c12116e2
Merge pull request #16007 from CurtizJ/fix-complex-key-direct 
Allow to use direct layout for dictionaries with complex keys
 2020-10-16 10:03:10 +03:00
zhang2014
4e285168df ISSUES-15883 try fix test failure 2020-10-16 09:11:05 +08:00
Maksim Kita
9bd30b041a Parser allow specify primary key in column list 2020-10-15 23:33:00 +03:00
Nikita Mikhaylov
6512d84b31
Merge pull request #15985 from CurtizJ/redis-cached-dict 
Add support of cache layout for Redis dictionaries with complex key
 2020-10-15 22:35:36 +03:00
alesapin
2b2a55a081 Add action lock only if table exists 2020-10-15 22:23:46 +03:00
Kruglov Pavel
5aba639430 Update test 2020-10-15 22:01:18 +03:00
sundy-li
153be93544 sub ReadonlyReplica when detach readonly tables 2020-10-15 22:01:18 +03:00
Alexander Tokmakov
95ad45a3b0 minor improvements of stress test 2020-10-15 21:14:04 +03:00
Alexander Kuzmenkov
41f1fd8fa0
Merge pull request #15822 from abyss7/fix-build 
Fix build without libraries
 2020-10-15 20:48:53 +03:00
Nikolai Kochetov
571a5fbff3 Update functions interface. 2020-10-15 19:52:25 +03:00
alesapin
4c1f5cab13 Sleep less in background task 2020-10-15 19:10:22 +03:00
Alexander Tokmakov
2f9611f1ae fix logical error with explicit UUIDs 2020-10-15 19:01:23 +03:00
Pavel Kruglov
ee8a9d2cf1 Don't touch MySQL database if it's unnecessary 2020-10-15 18:57:17 +03:00
Anton Popov
9c9ad2cc85
Merge branch 'master' into fix-complex-key-direct 2020-10-15 18:53:59 +03:00
Nikolai Kochetov
939d8edf33
Merge pull request #15999 from ClickHouse/fix-after-15437 
Continuation of 15437
 2020-10-15 18:20:48 +03:00
Alexander Kuzmenkov
bc7b5f6bb4 Merge remote-tracking branch 'origin/master' into tmp 2020-10-15 17:15:05 +03:00
Vitaly Baranov
5f261cec3c
Merge pull request #15199 from filimonov/non_delimited_protobuf 
ProtobufSingle format
 2020-10-15 16:58:39 +03:00
alesapin
629506445d Better backoff policy 2020-10-15 16:57:50 +03:00
Nikolai Kochetov
388f69b109
Merge pull request #15976 from ClickHouse/new-block-for-functions-3 
Use `ColumnsWithTypeAndName` instead of `Block` for function calls [part 3]
 2020-10-15 16:56:09 +03:00
Pavel Kovalenko
ed61c5681b Use 'moving' directory instead of 'detached' when move part to another disk/volume. 2020-10-15 16:55:13 +03:00
alesapin
60d14352f8 Merge branch 'master' into no_background_pool_no_more 2020-10-15 16:34:14 +03:00
Alexander Kuzmenkov
f7f59ca23f
Merge pull request #15982 from vitlibar/fix-ambiguity-in-parsing-of-settings-profiles 
Fix ambiguity in parsing of settings profiles.
 2020-10-15 16:23:32 +03:00
Alexander Kuzmenkov
f366b366ae
Merge pull request #15987 from filimonov/background-pool-count_no_work_done-bug 
Fix the bug when NOTHING_TO_DO events wrongly increment count_no_work_done
 2020-10-15 16:11:57 +03:00
alesapin
2002289003 Fix bug in alter primary key for replicated versioned collapsing merge tree 2020-10-15 16:02:39 +03:00
Alexander Kuzmenkov
b4378b004f Merge remote-tracking branch 'origin/master' into tmp 2020-10-15 16:01:41 +03:00
zhang2014
c8aa007a45 ISSUES-15883 modify comment 2020-10-15 20:42:10 +08:00
zhang2014
80f3de1359 ISSUES-15883 try fix collate name 2020-10-15 20:39:04 +08:00
Pavel Kruglov
f5fac575f4 don't postprocess single parts 2020-10-15 15:22:41 +03:00
feng lv
fabe86c6d3 fix 
fix
 2020-10-15 20:16:36 +08:00
tavplubix
1003de75ed
Update StorageMaterializedView.cpp 2020-10-15 15:06:44 +03:00
Nikolai Kochetov
963ce315b2
Merge pull request #15454 from azat/dict-prealloc 
Speedup hashed/sparse_hashed dictionary loading by preallocating the hash table
 2020-10-15 15:03:53 +03:00
Anton Popov
424dd3147c allow to use direct layout for dictionaries with complex keys 2020-10-15 14:59:41 +03:00
Nikolai Kochetov
ee7b32c283 Fix tests and build. 2020-10-15 14:52:25 +03:00
alesapin
dccf51b316 Remove redundant logging 2020-10-15 14:08:39 +03:00
tavplubix
6dc2f00347
Update StorageMaterializedView.cpp 2020-10-15 13:57:47 +03:00
alesapin
84b0c22044 fix possible deadlock 2020-10-15 13:54:50 +03:00
alesapin
374949051c Add thread safety 2020-10-15 13:41:36 +03:00
alexey-milovidov
af7d70c9bb
Merge pull request #15646 from excitoon-favorites/betters3storageinitialization 
Better initialization of S3 storage
 2020-10-15 13:31:43 +03:00
Nikolai Kochetov
40f62719ff Move event to stack. 2020-10-15 13:24:18 +03:00
alesapin
e84eda176a Add test and slightly refactored 2020-10-15 13:22:02 +03:00
alesapin
583d7042e9 Get rid of some deadlocks 2020-10-15 11:29:18 +03:00
feng lv
b931a3c9da fix 
update test

fix
 2020-10-15 16:14:28 +08:00
Nikolai Kochetov
e8038ae84f
Merge pull request #15857 from amosbird/e2 
Refactor processors.
 2020-10-15 10:45:00 +03:00
alesapin
c5419083e3 Better method name 2020-10-15 10:43:50 +03:00
alesapin
3394c22c03 Fix race and clang-tidy 2020-10-15 10:39:27 +03:00
Mikhail Filimonov
ace2e99cb3
Fix the bug when NOTHING_TO_DO events wrongly increment count_no_work_done 2020-10-14 23:08:47 +02:00
tavplubix
04206db7da
Merge pull request #15974 from ClickHouse/merging_14295 
Merging #14295
 2020-10-14 23:51:42 +03:00
Nikolai Kochetov
d0112c5dc4 Merge branch 'master' into new-block-for-functions-3 2020-10-14 23:37:10 +03:00
Nikolai Kochetov
04476c533e Fix ya.make 2020-10-14 23:33:25 +03:00
Anton Popov
3050b2e67b add support of cache layout for redis dictionaries with complex key 2020-10-14 22:57:07 +03:00
nikitamikhaylov
b1e1553061 style + docker + tests 2020-10-14 22:43:08 +03:00
Alexander Kuzmenkov
1cbb26e6e4 Merge remote-tracking branch 'origin/master' into HEAD 2020-10-14 22:41:25 +03:00
alesapin
3e3505258f No sleep when we have job 2020-10-14 22:33:36 +03:00
Nikolai Kochetov
26158ebc94 Fix tests 2020-10-14 22:25:36 +03:00
Alexander Tokmakov
de06a79738 fix possibly dangling reference when inserting into mv 2020-10-14 22:25:31 +03:00