Commit Graph

43777 Commits

Author SHA1 Message Date
Alexey Milovidov
0440dde315
Merge pull request #51873 from ClickHouse/remove-useless-system-query
Remove useless code
2023-07-08 21:11:41 +03:00
Alexey Milovidov
b44c582c40
Merge pull request #51951 from ClickHouse/more_logs_on_shutdown
Better logs on shutdown
2023-07-08 19:51:38 +03:00
Alexey Milovidov
a2d7f5e635
Merge pull request #46416 from azat/allocator-tunning
[TEST] Tune allocator
2023-07-08 19:45:01 +03:00
Alexey Milovidov
52277d6252
Merge pull request #51363 from azat/clickhouse-local-default-settings
Use separate default settings for clickhouse-local
2023-07-08 19:37:27 +03:00
Alexey Milovidov
b2fb5b20c8
Merge branch 'master' into dist/fix-selector-SIGSEGV 2023-07-08 19:32:59 +03:00
Alexey Milovidov
58ee566278
Merge pull request #51964 from ClickHouse/allow-parametric-udfs
Allow parametric UDFs
2023-07-08 19:12:48 +03:00
Alexander Tokmakov
44ae3a0986 fix a bug in projections 2023-07-08 16:13:07 +02:00
Alexander Tokmakov
df31034820 rollback merge tasks on exception 2023-07-08 14:03:08 +02:00
Alexey Milovidov
781d5e3aa3
Merge pull request #51922 from ClickHouse/fix-subquery-operators
Fix error in subquery operators
2023-07-08 10:37:47 +03:00
Alexey Milovidov
b958499c27
Merge pull request #51458 from ClickHouse/sunny19930321-fix-attach-table-function-name-normalizer
Merging #36384
2023-07-08 10:37:11 +03:00
Alexey Milovidov
3a48a7b872
Merge pull request #51492 from nickitat/fix_final_header_mismatch
Fix Block structure mismatch in Pipe::unitePipes for FINAL
2023-07-08 08:05:20 +03:00
Alexey Milovidov
0b0caec9c4
Update Context.cpp 2023-07-08 07:51:17 +03:00
Alexey Milovidov
b1d1918607
Merge branch 'master' into retry 2023-07-08 03:08:48 +03:00
Alexey Milovidov
e4dd603919
Merge pull request #51497 from ClickHouse/fix-shutdown-race
Fix possible race on shutdown wait
2023-07-08 03:03:45 +03:00
Alexey Milovidov
bc1f815b79
Merge pull request #51640 from alekar/fix-to-outfile
Ignore APPEND and TRUNCATE modifiers if file does not exist.
2023-07-08 02:56:59 +03:00
Alexey Milovidov
236ee81266
Merge pull request #51847 from canhld94/ch_fix_segfault
Fix segfault when create invalid EmbeddedRocksdb table
2023-07-08 02:50:11 +03:00
Alexey Milovidov
fbdb8f387e
Merge pull request #51857 from ljhcage/master
remove duplicate condition
2023-07-08 02:49:32 +03:00
Alexey Milovidov
0512169e19
Merge branch 'master' into remove-useless-system-query 2023-07-08 02:46:41 +03:00
Alexey Milovidov
5a8bdb1b9d Merge branch 'remove-useless-system-query' of github.com:ClickHouse/ClickHouse into remove-useless-system-query 2023-07-08 01:45:36 +02:00
Alexey Milovidov
933a92e176 Merge branch 'master' into remove-useless-system-query 2023-07-08 01:45:19 +02:00
Alexey Milovidov
25aa6fcff9
Merge pull request #51947 from ClickHouse/fix-50669
Do not remove inputs after ActionsDAG::merge
2023-07-08 02:42:14 +03:00
Alexey Milovidov
03d2606eb9
Merge pull request #49342 from ClickHouse/disks-space-improvement
Slight improvement in Disks interface
2023-07-08 02:24:57 +03:00
Alexey Milovidov
e56a5bbd8b
Merge pull request #51865 from ClickHouse/remove-useless-logs
Remove useless logs
2023-07-08 02:23:00 +03:00
Alexey Milovidov
583d48edcd
Merge pull request #51378 from ClickHouse/add-test-43358
Functions `hasToken*` were totally wrong. Add a test for #43358
2023-07-08 02:22:39 +03:00
Yakov Olkhovskiy
6990f078a0
cleaner way 2023-07-07 19:19:30 -04:00
Alexey Milovidov
c61f0bca65
Merge pull request #51931 from ClickHouse/better-current-thread-check
Fix segfault caused by `ThreadStatus`
2023-07-08 02:15:53 +03:00
Alexey Milovidov
f4696d762c Revert "Merge pull request #49419 from ClickHouse/fix-function-parameter-exception"
This reverts commit b921476a3b, reversing
changes made to 7896d30737.
2023-07-08 00:56:42 +02:00
Alexey Milovidov
a96874850e Revert "Merge pull request #48115 from save-my-heart/throw_non_parametric_function"
This reverts commit 5f930aeb26, reversing
changes made to 35572321a1.
2023-07-08 00:55:57 +02:00
Alexey Milovidov
10196ba902
Merge pull request #51932 from ClickHouse/short_fault_info
Print short fault info only from safe fields
2023-07-08 00:59:57 +03:00
Alexey Milovidov
1eaefd0318
Merge pull request #51905 from rschu1ze/varint
Allow full range for var-int encoded integers
2023-07-07 22:33:29 +03:00
Alexey Milovidov
520195f7ef
Merge pull request #51917 from ClickHouse/revert-system-drop-filesystem-cache-by-key
Revert system drop filesystem cache by key
2023-07-07 19:44:28 +03:00
vdimir
88911e1378
Check refcount in finalize for other RemoveObjectStorageOperations 2023-07-07 16:42:03 +00:00
Alexander Tokmakov
93b76c9321 better logs on shutdown 2023-07-07 18:40:43 +02:00
Alexey Milovidov
472d1343e7
Merge branch 'master' into fix-subquery-operators 2023-07-07 19:40:40 +03:00
Maksim Kita
8266067e1a Fixed style check 2023-07-07 19:09:55 +03:00
Alexander Tokmakov
152a4b9d4c
Merge pull request #51908 from ClickHouse/fix_deadlock_on_catalog_shutdown
Fix deadlock on DatabaseCatalog shutdown
2023-07-07 19:06:34 +03:00
vdimir
227e415d6d
Check refcount in RemoveManyObjectStorageOperation::finalize instead of execute 2023-07-07 15:08:21 +00:00
vdimir
eed1ecb6ba
Revert "Remove parts in order for object storage always"
This reverts commit c35294317d.
2023-07-07 15:01:23 +00:00
Nikolai Kochetov
82cbc4e6e3
Merge branch 'master' into fix-50669 2023-07-07 16:35:50 +02:00
Nikolai Kochetov
ee33000fc2 Fixing tests. 2023-07-07 14:08:54 +00:00
Ilya Yatsishin
7aacc35829
Merge branch 'master' into per-column-pk-syntax 2023-07-07 14:52:15 +02:00
Nikolai Kochetov
fa7fe5277c Better comment. 2023-07-07 12:25:13 +00:00
Sema Checherinda
87ef297c0c
Merge branch 'master' into less-logs-2 2023-07-07 14:23:26 +02:00
Sema Checherinda
5f73bec325
Merge branch 'master' into write-to-finalized 2023-07-07 14:22:49 +02:00
Nikolai Kochetov
1e0d97c282 Do not remove inputs after ActionsDAG::merge 2023-07-07 12:19:10 +00:00
Antonio Andelic
d9d0e9062a Remove maybe_unused 2023-07-07 11:41:01 +00:00
Antonio Andelic
cf50380ff8 Merge branch 'master' into better-current-thread-check 2023-07-07 11:40:04 +00:00
Antonio Andelic
6d798e0bde Better check for current_thread 2023-07-07 11:39:41 +00:00
Alexander Gololobov
05649c7b38 Removed duplicate header 2023-07-07 13:22:52 +02:00
Alexander Gololobov
d439db3139 Print just signal number first, and only then get its description 2023-07-07 13:15:31 +02:00
Alexey Milovidov
03c4a6e26c
Merge branch 'master' into sunny19930321-fix-attach-table-function-name-normalizer 2023-07-07 13:45:30 +03:00
Alexey Milovidov
7820876f2d
Merge branch 'master' into remove-useless-logs 2023-07-07 13:44:04 +03:00
Alexey Milovidov
4a6a6fc4f2
Merge branch 'master' into disks-space-improvement 2023-07-07 13:43:04 +03:00
Alexey Milovidov
69dc099dba
Merge branch 'master' into add-test-43358 2023-07-07 13:40:49 +03:00
Alexander Gololobov
602392bb62 Print short fault info only from safe fields 2023-07-07 12:37:16 +02:00
Alexey Milovidov
b5f9a170eb
Merge pull request #51848 from ClickHouse/many-fixes-3
Many fixes [3]
2023-07-07 13:29:49 +03:00
Maksim Kita
23bd23802f CacheDictionary request only unique keys from source 2023-07-07 12:26:15 +03:00
Duc Canh Le
5d6fb7b7b0
Merge branch 'master' into ch_fix_segfault 2023-07-07 13:13:33 +08:00
Alexey Milovidov
2246e86159 Fix error in subquery operators 2023-07-07 05:30:32 +02:00
xiaolei565
5f523e8376
Merge branch 'master' into xuelei_dev 2023-07-07 10:21:19 +08:00
Alexey Milovidov
7cece62d26 Revert "Merge pull request #51547 from kssenii/more-flexible-drop-cache"
This reverts commit 2ce7bcaa3d, reversing
changes made to e897207cd5.
2023-07-07 04:07:19 +02:00
Alexey Milovidov
f0cc90a7fb Revert "Merge pull request #51822 from kssenii/minor-changes"
This reverts commit 5ac85f4fa8, reversing
changes made to 376c903da9.
2023-07-07 04:07:03 +02:00
Nikolay Degterinsky
8da8b79cc4
Merge pull request #51854 from fky2015/master
fix: correct exception messages on policies comparison
2023-07-07 03:58:06 +02:00
xiaolei565
dd87269fc2
Merge branch 'master' into xuelei_dev 2023-07-07 09:49:34 +08:00
Alexander Tokmakov
fde44fe9f0
Merge branch 'master' into fix_deadlock_on_catalog_shutdown 2023-07-07 02:59:29 +03:00
Alexey Milovidov
685f2949b7
Revert "Fix build" 2023-07-07 02:53:13 +03:00
Alexey Milovidov
c47b32b17a Fix build 2023-07-07 01:52:18 +02:00
Alexey Milovidov
48eb30de51 Fix build 2023-07-07 01:42:29 +02:00
Alexander Tokmakov
fc19e74ba9 fix deadlock on DatabaseCatalog shutdown 2023-07-07 01:12:17 +02:00
Alexander Tokmakov
fdbd59ec6c
Merge pull request #51135 from ClickHouse/fix_trash_in_disks
Try to fix some trash in Disks and part moves
2023-07-07 02:02:17 +03:00
alekar
757aee1109
Merge branch 'master' into fix-to-outfile 2023-07-06 14:04:42 -07:00
vdimir
c35294317d
Remove parts in order for object storage always 2023-07-06 20:38:01 +00:00
Robert Schulze
271297823a
Allow var-int encoded 64-bit integers with MSB=1
Resolves: #51486

Until now, it was illegal to encode 64-bit (unsigned) integers with
MSB=1, i.e. values > (1ULL<<63) - 1, as var-int. In more detail, the
var-int code used by ClickHouse server and client spent at most 9 bytes
per value such that 9 * 7 = 63 bits could be encoded. Some 3rd party
clients (e.g. Rust clickhouse-rs) had the same limitation, whereas other
clients understand the full range (Python clickhouse-driver).

PRs #47608 and #48628 added sanity checks as asserts or exceptions
during var-int encoding on the server side. This was considered okay as
such huge integers so far occurred only during testing (usually fuzzing)
but not in practice.

Issue #51486 is a new fuzzing issue where the exception thrown from the
sanity check led to a half-baked progress packet and as a result, a
logical error / server crash.

The only fix which is not another bandaid is to allow the full range in
var-int coding. Clients will have to allow the full range too, a note
will be added to the changelog. (the alternative was to create another
protocol version but as var-int is used all over the place this was
considered infeasible)

Review note: this is the relevant commit.
2023-07-06 20:23:23 +00:00
Sema Checherinda
9c12994d94 initialize SeriesRecords for LogSeriesLimiter lazy 2023-07-06 19:49:22 +02:00
robot-clickhouse-ci-2
99c64971bd
Merge pull request #51737 from ClickHouse/fix_logical_error_grace_hash_join
Fix: logical error in grace hash join
2023-07-06 19:27:03 +02:00
Alexander Tokmakov
58793816a7 fix paranoid check 2023-07-06 19:06:35 +02:00
Nikita Taranov
63b9c1ac06 add test 2023-07-06 18:58:13 +02:00
lcjh
7321f7e9dc
Merge branch 'master' into master 2023-07-07 00:31:47 +08:00
Feng Kaiyu
bf4dbb842d
Merge branch 'master' into master 2023-07-06 23:47:41 +08:00
Igor Nikonov
83af43b8ba
Merge pull request #51852 from ClickHouse/fix-misleading-naming-in-joins
Change misleading name in joins: addJoinedBlock -> addBlockToJoin
2023-07-06 17:27:26 +02:00
Igor Nikonov
7c0e50c4d5
Merge branch 'master' into fix-misleading-naming-in-joins 2023-07-06 17:26:38 +02:00
Alexander Tokmakov
abf36065b7 fix 2023-07-06 17:24:06 +02:00
Robert Schulze
3f744c1e14
Cosmetics: rename template parameter 2023-07-06 14:47:40 +00:00
Robert Schulze
7644f0b37c
Cosmetics: move code around 2023-07-06 14:44:06 +00:00
Alexey Milovidov
6d8434c702 Merge branch 'master' into many-fixes-3 2023-07-06 16:17:32 +02:00
Alexey Milovidov
1fa21700ad Merge remote-tracking branch 'origin/less-flaky-test_start_stop_moves' into many-fixes-3 2023-07-06 16:17:13 +02:00
Nikita Taranov
aec7205636 rework pool usage 2023-07-06 14:41:09 +02:00
Nikita Taranov
c23e29d6aa don't account session's memory in thread/user mem tracker 2023-07-06 14:41:03 +02:00
Alexander Tokmakov
52a26a6653
Merge pull request #51708 from velavokr/velavokr-issue-51292
#51292 added default_temporary_table_engine setting
2023-07-06 15:18:14 +03:00
Dmitry Kardymon
86fc702236
Add skipWhitespacesAndTabs()
Co-authored-by: Kruglov Pavel <48961922+Avogar@users.noreply.github.com>
2023-07-06 15:14:18 +03:00
xiaolei565
0c3ce1f634
Merge branch 'master' into xuelei_dev 2023-07-06 19:47:07 +08:00
Yatsishin Ilya
12ebb30781 style 2023-07-06 10:34:34 +00:00
Kseniia Sumarokova
e97e107bcc
Merge branch 'master' into add-separate-access-for-use-named-collections 2023-07-06 12:16:53 +02:00
Kseniia Sumarokova
605e833576
Merge branch 'master' into minor-changes 2023-07-06 12:09:01 +02:00
Sema Checherinda
8f7381f0a2
Merge branch 'master' into less-logs-2 2023-07-06 12:07:58 +02:00
Yatsishin Ilya
24e77083b3 Commit tests 2023-07-06 09:50:44 +00:00
Dmitry Kardymon
32f5a78302 Fix setting name 2023-07-06 07:32:46 +00:00
Alexander Gololobov
1336a9ec67 Better naming 2023-07-06 09:09:55 +02:00
Dmitry Kardymon
24b5c9c204 Use one setting input_format_csv_allow_variable_number_of_colums and code in RowInput 2023-07-06 06:05:43 +00:00
alekar
f37e08a945
Merge branch 'master' into fix-to-outfile 2023-07-05 21:25:21 -07:00