Commit Graph

21717 Commits

Author SHA1 Message Date
alexey-milovidov
3270ad439a
Update compressed_buffer_fuzz.cpp 2019-09-23 00:18:14 +03:00
alexey-milovidov
6fa234cea4
Merge pull request #6894 from azat-archive/hashed-dict-memory-usage-v2
[RFC] Add sparsehash support for hashed dictionary (to reduce memory usage)
2019-09-22 15:55:36 +03:00
alexey-milovidov
8fd66ac4fd
Update compressed_buffer_fuzz.cpp 2019-09-22 15:52:33 +03:00
Vladimir Chebotarev
4608da1344 Minor tests improvement. 2019-09-22 11:03:02 +00:00
Vladimir Chebotarev
64d49e4565 Minor review fixes. 2019-09-22 10:42:47 +00:00
Eldar Zaitov
b174833bdf Initial fuzzing support with libfuzzer 2019-09-22 13:34:09 +03:00
Azat Khuzhin
52f14c1ead
Update HashedDictionary.cpp (fixed rename in return type for SFINAE) 2019-09-22 10:39:50 +03:00
fenglv
4465fdb8bf Add test
fix

fix

fix
2019-09-22 14:25:43 +08:00
alexey-milovidov
5970aafd9a
Merge pull request #7032 from azat-archive/distributed-directory-monitor-SIGSEGV
Avoid SIGSEGV on batch send failure (file with index XX is absent)
2019-09-22 05:12:55 +03:00
alexey-milovidov
a12cffee91
Update HashedDictionary.h 2019-09-22 05:11:08 +03:00
alexey-milovidov
ab9a7be45a
Comments are the must. 2019-09-22 05:09:40 +03:00
alexey-milovidov
9afea6f0b3
Update HashedDictionary.cpp 2019-09-22 05:04:49 +03:00
alexey-milovidov
67e02b4ea0
Merge pull request #6957 from infinivision/add_bitmapSubsetLimit
added bitmapSubsetLimit
2019-09-22 04:58:44 +03:00
alexey-milovidov
6020ba187e
Update AggregateFunctionGroupBitmapData.h 2019-09-22 04:58:21 +03:00
alexey-milovidov
816ac1ca8d
Merge pull request #7037 from silviucpp/silviu-fix-osx
Fix osx build
2019-09-22 04:53:36 +03:00
alexey-milovidov
d446205eec
Update QueryProfiler.cpp 2019-09-22 04:53:19 +03:00
Silviu Caragea
5a14d97587 Fix linking when __ELF__ is not defined 2019-09-22 01:04:17 +03:00
Silviu Caragea
1fbd2fb6a8 Fix osx build 2019-09-21 21:30:01 +03:00
Zhichang Yu
ab7ecd84a1 fix bitmapMin and bitmapMax doc 2019-09-21 23:34:44 +08:00
alesapin
4575b6e4ff
Merge pull request #7031 from yandex/rename-storage-policy-name
Renamed "storage_policy_name" to "storage_policy"
2019-09-21 17:03:19 +03:00
Azat Khuzhin
59763cbb3a
Add ability to send events with absolute values to graphite
<events> sends only deltas for events, while sometimes it is more
convenient to get absolute values (for example to calculate rate).

This patch introduces another directive -- <events_absolute> that will handle
this.

v0: use <events> as bool/string
v2: use <events_absolute>true</events_absolute> over <events>absolute</events>
2019-09-21 02:46:47 +03:00
Azat Khuzhin
420089c301
Add new dictionary layout (sparse_hashed) that is more memory efficient
With this new layout, sparsehash will be used over default HashMap,
sparsehash is more memory efficient but it is also slower.

So in a nutshell:
- HashMap uses ~2x more memory then sparse_hash_map
- HashMap ~2-2.5x faster then sparse_hash_map
(tested on lots of input, and the most close to production was
dictionary with 600KK hashes and UInt16 as value)

TODO:
- fix allocated memory calculation
- getBufferSizeInBytes/getBufferSizeInCells interface
- benchmarks

v0: replace HashMap with google::sparse_hash_map
v2: use google::sparse_hash_map only when <sparse> isset to true
v3: replace attributes with different layout
v4: use ch hash over std::hash
2019-09-21 02:22:40 +03:00
Azat Khuzhin
b22b65dd29
Avoid SIGSEGV on batch send failure (file with index XX is absent)
In case of the following error:
  Failed to send batch: file with index 23742 is absent

NULL dereference will occur for the "remote".
2019-09-21 02:22:25 +03:00
alexey-milovidov
f8d19f6bf3
Merge pull request #6968 from azat-archive/create_as_skip_indices
[RFC] Introduce create_as_skip_indices
2019-09-20 23:53:49 +03:00
alexey-milovidov
1dc58dcb15
Update InterpreterCreateQuery.cpp 2019-09-20 23:53:14 +03:00
alexey-milovidov
c3e0f1c9d3
Merge pull request #7020 from amosbird/check_settings
Outline methods to get needed instantiations.
2019-09-20 23:46:45 +03:00
alexey-milovidov
2432a68009
Merge pull request #7022 from 4ertus2/bugs
Fix "Unknown identifier" in ORDER BY and GROUP BY with Multiple Joins
2019-09-20 23:45:51 +03:00
alexey-milovidov
3f500aad4b
Merge pull request #6976 from sfod/issue-3571
Throw exceptions if WITH TOTALS/ROLLUP/CUBE are specified without agg…
2019-09-20 23:39:00 +03:00
Alexey Milovidov
42b739550b Renamed "storage_policy_name" to "storage_policy" 2019-09-20 23:35:50 +03:00
alexey-milovidov
5314088648
Merge pull request #6980 from filimonov/huge_pk_performance_test
Adding performance test for huge pk (issue #6924)
2019-09-20 23:29:56 +03:00
Ivan Lezhankin
9e46118edd Merge remote-tracking branch 'upstream/master' into issue-6459 2019-09-20 21:25:55 +03:00
Ivan Lezhankin
8cb0e58bc7 Fix build for all targets 2019-09-20 21:13:51 +03:00
alexey-milovidov
123b8cb43c
Merge pull request #6990 from Akazz/timeout_for_sync_replica_cmd
Fixed timeout mechanism for SYNC REPLICA command + simplified related code
2019-09-20 20:32:51 +03:00
alexey-milovidov
aabd6906f2
Merge pull request #6982 from 4ertus2/mjoin
PartialMergeJoin bugfixes
2019-09-20 20:19:00 +03:00
Ivan Lezhankin
967e00a8da It works!
if compiled with:

CC=clang CXX=clang++ cmake -Wno-dev . -Bbuild -GNinja -DCMAKE_AR:FILEPATH=x86_64-apple-darwin-ar -DCMAKE_RANLIB:FILEPATH=x86_64-apple-darwin-ranlib -DCMAKE_SYSTEM_NAME=Darwin -DSDK_PATH=MacOSX10.14.sdk -DLINKER_NAME=x86_64-apple-darwin-ld -DUSE_SNAPPY=OFF -DENABLE_SSL=OFF -DENABLE_PROTOBUF=OFF -DENABLE_PARQUET=OFF -DENABLE_READLINE=OFF -DENABLE_ICU=OFF -DENABLE_FASTOPS=OFF
2019-09-20 20:09:22 +03:00
millb
4f24512ba4 Test added. 2019-09-20 19:40:06 +03:00
millb
88adbb72d9 Fixed Function Hex for Float32 and Float64 2019-09-20 19:21:05 +03:00
chertus
7726130303 fix multiple joins aliasing for order by and group by 2019-09-20 19:01:19 +03:00
Amos Bird
b64bab29ed Outline methods to get needed instantiations. 2019-09-20 22:45:25 +08:00
sfod
bc9bcfdb7e Fix tests which use WITH TOTALS without aggregation 2019-09-20 17:42:30 +03:00
sfod
bf2654e093 Use sql file to test changes 2019-09-20 17:39:26 +03:00
maqroll
ca36e3f861 Attach error to force ip refresh 2019-09-20 12:36:09 +00:00
Ivan
cffc254922
Always read and insert Kafka messages as a whole (#6950)
* Always read and insert Kafka messages as a whole.
2019-09-20 15:12:32 +03:00
stavrolia
7309e813bc cleanup hdfs docs 2019-09-20 14:26:00 +03:00
Alexander Kazakov
2d807368e1 Adjusted timings in test + more verbose diagnostics 2019-09-20 00:20:58 +03:00
Azat Khuzhin
b2a3db1048
Ignore indices for CREATE TABLE .. AS .. if storage do not support them 2019-09-19 23:55:38 +03:00
chertus
0bc345fdc0 MergeJoin compare nullables 2019-09-19 20:09:59 +03:00
fenglv
2062bedaf0 Add repeat function 2019-09-20 00:46:41 +08:00
chertus
da14951ecd implement MergeJoin.joinTotals() 2019-09-19 17:53:03 +03:00
Alexander Kazakov
90c9d83fa5 Added missing newline at the EOF 2019-09-19 17:48:08 +03:00
alesapin
b289d7e6a5 Fix system contributors generating script 2019-09-19 17:41:49 +03:00
Alexander Kazakov
7a0f7a57e2 Chmod +x for test!!! 2019-09-19 15:48:18 +03:00
Akazz
4ae3db45c6 Fixed timeout reading in SYNC REPLICA 2019-09-19 14:04:57 +03:00
Vladimir Chebotarev
0ee6f6231a Added comments about redirecting requests and got rid of magic values. 2019-09-19 10:33:34 +00:00
Vladimir Chebotarev
12f7361095 Removed unused headers from ReadBufferFromS3.h 2019-09-19 10:25:31 +00:00
Vladimir Chebotarev
a5d6bd9e01 Proper passing of query parameters in initiate multipart upload. 2019-09-19 10:16:39 +00:00
Vladimir Chebotarev
a88d795f0f Proper passing of query parameters in initiate multipart upload. 2019-09-19 10:15:59 +00:00
Vladimir Chebotarev
283e09d2a5 Removed trash logging and fixed query parameters in multipart uploads. 2019-09-19 10:02:45 +00:00
Akazz
787a646680 Added a test to challenge timeout mechanism in SYNC REPLICA command 2019-09-19 13:00:44 +03:00
Vladimir Chebotarev
bd1ce56797 Tests decomposition. 2019-09-19 09:34:33 +00:00
maqroll
3765084358 Proper ReadWriteBufferFromHTTP constructor args 2019-09-19 07:33:54 +00:00
Zhichang Yu
0dc3866c36 added bitmapSubsetLimit 2019-09-19 10:15:36 +08:00
alexey-milovidov
1fe79ad43c
Merge pull request #6941 from dimarub2000/enums_in_section
IN with Enums numeric values
2019-09-19 02:24:34 +03:00
alexey-milovidov
9c675e50bb
Merge pull request #6963 from nicelulu/issue_6616
optimize limit 1,0 and test.
2019-09-19 02:23:56 +03:00
alexey-milovidov
01a1920e9b
Merge pull request #6970 from infinivision/add_bitmapMin_bitmapMax
added bitmapMin and bitmapMax
2019-09-19 02:01:16 +03:00
alexey-milovidov
1327e71d80
Changed C-style cast to constructor-style cast. 2019-09-19 02:01:06 +03:00
alexey-milovidov
7325f4a77b
Merge pull request #6974 from yandex/aku/mmap-linux
Use MAP_POPULATE only on Linux.
2019-09-19 01:58:40 +03:00
alexey-milovidov
bc1ecb0be5
Merge pull request #6951 from yandex/aku/alloc-continue
Make the quadratic Arena::allocContinue less bad.
2019-09-19 01:57:26 +03:00
alexey-milovidov
d7681d0239
Merge pull request #6977 from Akazz/minor_fixes_in_tests-2
Reworked flapping test - 00715_fetch_merged_or_mutated_part_zookeeper
2019-09-19 01:54:27 +03:00
alexey-milovidov
0bdb48ed65
Merge pull request #6966 from azat-archive/build--fixes
Add missing linking with jemalloc
2019-09-19 01:52:22 +03:00
alexey-milovidov
db470be077
Update merge_tree_huge_pk.xml 2019-09-18 23:07:23 +03:00
chertus
b8b6197288 partial_merge_join settings affects LEFT and INNER JOINs only 2019-09-18 22:12:53 +03:00
chertus
08a28d2dc2 fix pm join bug (wrong right equal range copy) 2019-09-18 21:44:44 +03:00
Azat Khuzhin
6cb5d0046b
Add missing linking with jemalloc for clickhouse_common_io
clickhouse_common_io incudes new_delete.cpp, that uses memory.h, which
uses sdallocx (jemalloc).

And since there is -Wl,--no-undefined every undefined symbols are not
allowed, hence clickhouse_common_io must know about sdallocx symbol.

For the default build (-DUNBUNDLED=OFF) everything is good, because
jemalloc is static, and clickhouse_common_io linked with libcommon
(which is linked with jemalloc)

But if jemalloc will be shared, and clickhouse_common_io and libcommon
is different shared libraries then clickhouse_common_io should be linked
with jemalloc, otherwise you will undefined reference to sdallocx error.

This can be reproduced using the following build configuration:
   -DUSE_STATIC_LIBRARIES=OFF -DCLICKHOUSE_SPLIT_BINARY=ON -DSPLIT_SHARED_LIBRARIES=ON -DUNBUNDLED=ON
Provided that you have systemd-wide jemalloc>=4 (see memory.h).

Refs: https://github.com/yandex/ClickHouse/pull/6878#discussion_r324902295
v2: do not link jemalloc if it is static
2019-09-18 21:26:23 +03:00
chertus
38a73fb551 add simple perf test for partial merge join 2019-09-18 20:04:10 +03:00
chertus
194e49e751 fix UB in MergeJoinCursor 2019-09-18 19:46:00 +03:00
Mikhail Filimonov
67e1cf9b73 Adding performance test for huge pk (issue #6924) 2019-09-18 17:35:45 +02:00
maqroll
952d9449a2 typo 2019-09-18 14:53:45 +00:00
root
8175d4c2d1 style checks
Committer: maqroll <loteroc@gmail.com>
2019-09-18 13:38:17 +00:00
Artem Zuikov
aae82eed5a
Merge pull request #6940 from 4ertus2/mjoin
PartialMergeJoin
2019-09-18 16:16:10 +03:00
Akazz
aa8ef05955 Reworked test 00715_fetch_merged_or_mutated_part_zookeeper 2019-09-18 16:14:56 +03:00
root
ea5480fd72 merge
Committer: maqroll <loteroc@gmail.com>
2019-09-18 13:13:40 +00:00
sfod
0bad4b4a05 Throw exceptions if WITH TOTALS/ROLLUP/CUBE are specified without aggregate functions 2019-09-18 16:08:51 +03:00
chertus
dd46c08e90 move JoinCommon funcs out of IJoin.h/cpp 2019-09-18 15:46:57 +03:00
Alexander Kuzmenkov
e3a9863260 Use MAP_POPULATE only on Linux. 2019-09-18 15:32:23 +03:00
chertus
0cf5bfdf44 fix typo 2019-09-18 15:24:35 +03:00
Alexander Kuzmenkov
e1898ca89a Make the quadratic Arena::allocContinue less bad.
Scenarios that use Arena::allocContinue may waste quadratically many
memory and perform quadratically many copying, when the memory range
size reaches Arena's linear allocation threshold. To alleviate this,
make sure that the next memory chunk allocated by allocContinue is at
least linear_growth_threshold bytes bigger than the previous one, so
that we don't reallocate and copy that often.
2019-09-18 15:04:56 +03:00
root
ee311ff03c style checks
Committer: maqroll <jluisoc@gmail.com>
2019-09-18 10:38:00 +00:00
CurtizJ
651f5b0e9f merging with master 2019-09-18 13:21:10 +03:00
CurtizJ
79a08ef8ea Merge remote-tracking branch 'upstream/master' into merging_redis 2019-09-18 12:58:22 +03:00
alexey-milovidov
fe9e110a6a
Merge pull request #6965 from azat-archive/sparsehash-c11
Replace libsparsehash with sparsehash-c11
2019-09-18 12:46:13 +03:00
Zhichang Yu
460ccb04a2 added bitmapMin and bitmapMax 2019-09-18 16:56:12 +08:00
root
392bdd6008 +UpdatableSessionBase
Committer: maqroll <jluisoc@gmail.com>
2019-09-18 08:49:46 +00:00
alexey-milovidov
03014fe920
Merge pull request #6944 from malkfilipp/add-limit-clause-to-show-queries
Add LIMIT clause to SHOW queries
2019-09-18 02:07:45 +03:00
alexey-milovidov
d8cd375c8b
Merge pull request #6958 from proller/fix25
Build fixes
2019-09-18 01:48:46 +03:00
Azat Khuzhin
780341060f
Replace libsparsehash with sparsehash-c11
- use sparsehash-c11 over libsparsehash
- fix typos in find_sparsehash and users of the vars (s/SPARCE/SPARSE/)
- drop libsparsehash-dev from docker images (but keep for unbunlded build)
- use ::google over GOOGLE_NAMESPACE
2019-09-18 00:08:20 +03:00
root
f4b7cae998 optimize limit 1,0 and test. 2019-09-18 02:55:59 +08:00
chertus
2b3a4b0650 support const and LC columns in partial merge-join 2019-09-17 21:53:52 +03:00
CurtizJ
7ccf04440a better code in Redis external dictionary 2019-09-17 20:57:48 +03:00
chertus
58fad78980 support MergeJoin nullable convertion (right side) 2019-09-17 19:55:11 +03:00
alesapin
110568f980
Merge pull request #6947 from yandex/add_gdb_index
Add gdb index to builds with debug info
2019-09-17 17:59:27 +03:00
CurtizJ
df82e4bde8 fix build 2019-09-17 17:55:09 +03:00
CurtizJ
4480e97f9f fix build 2019-09-17 17:16:07 +03:00
CurtizJ
4df1f1bb9a better integration test for redis dictionary (but still bad) 2019-09-17 16:35:19 +03:00
malkfilipp
aab95fd517 Bump the test number 2019-09-17 15:41:25 +03:00
proller
e7f069c78c fixes 2019-09-17 12:33:46 +00:00
akuzm
75dc7d331e
Merge pull request #6937 from amosbird/ubmemfix
In hash tables, properly initialize zero key cell.
2019-09-17 14:57:38 +03:00
alesapin
33c3f7a6a2 Add gdb-index for gold linker with gdb-add-index tool 2019-09-17 12:49:27 +03:00
Dmitry Rubashkin
2252ee5a90 Branch refactoring. 2019-09-17 11:17:46 +03:00
chertus
da5d35b34e partial merge join (minimal tested version) 2019-09-16 22:31:22 +03:00
root
5ec0005400 +UpdatableSessionBase
Committer: maqroll <loteroc@gmail.com>
2019-09-16 17:28:41 +00:00
CurtizJ
e9336c9166 improvements of redis external dictionary 2019-09-16 19:17:56 +03:00
Dmitry Rubashkin
6fa925c263 Typo. 2019-09-16 18:47:13 +03:00
Dmitry Rubashkin
6f68cfc45c Removed (most probably) redundant if branch. Fixed VALUES table funtion. 2019-09-16 18:44:12 +03:00
Amos Bird
1cf47da60d ubsan/memsan fix. 2019-09-16 21:20:17 +08:00
chertus
cbd96af079 fix use after free (change Join <-> AnalyzedJoin ownership) 2019-09-16 15:37:46 +03:00
alesapin
719854b49b
Merge pull request #6939 from dimarub2000/perfomance_test_all_of
all_of setting in performance-test now works properly
2019-09-16 13:04:23 +03:00
Vitaly Baranov
fae612c3e7
Merge pull request #6907 from PerformanceVision/dict_allow_databases
Whitelist for dictionary from the current connected database
2019-09-16 11:52:25 +03:00
malkfilipp
ed42b94af7 Add tests 2019-09-15 19:08:26 +03:00
malkfilipp
98050c108f Add LIMIT clause to SHOW queries 2019-09-15 19:07:27 +03:00
Ivan Lezhankin
8c356a3830 WIP 2019-09-15 18:20:31 +03:00
Ivan Lezhankin
787c2b8d83 WIP 2019-09-15 13:35:19 +03:00
Ivan Lezhankin
01fdb802d4 Useful changes 2019-09-15 13:35:12 +03:00
alexey-milovidov
831eebe4dc
Merge pull request #6934 from abyss7/CLICKHOUSE-4643
Name temporary external table with existing subquery alias
2019-09-15 09:46:10 +03:00
Vitaly Baranov
a2c9bec468
Fix typo 2019-09-15 01:56:37 +03:00
Vitaly Baranov
c17071caf0
Fix typo 2019-09-15 01:55:22 +03:00
Vitaly Baranov
0fb234c63e
Merge branch 'master' into dict_allow_databases 2019-09-15 01:51:44 +03:00
Alexey Milovidov
79a206b092 Fixed typo #6895 2019-09-14 18:41:47 +03:00
alexey-milovidov
6503369138
Merge pull request #6895 from azat-archive/distributed_directory_monitor_max_sleep_time-v2
[RFC] Drop max_sleep_time limit from StorageDistributedDirectoryMonitor
2019-09-14 18:39:27 +03:00
Vladimir Chebotarev
d53872c300 Tests improvement. 2019-09-14 07:44:46 +00:00
Ivan
66d6e0cbb3 Update 01009_global_array_join_names.reference 2019-09-14 01:03:44 +03:00
Ivan
8fcf490bd9
Update 01009_global_array_join_names.reference 2019-09-14 00:58:39 +03:00
Ivan
33e6681c90
Update 01009_global_array_join_names.sql 2019-09-13 23:00:28 +03:00
Dmitry Rubashkin
57eef84322 DROP 2019-09-13 22:09:00 +03:00
Dmitry Rubashkin
ea3f80460c Tests. 2019-09-13 22:07:22 +03:00
Dmitry Rubashkin
33e7e1ea93 Int64 added. 2019-09-13 21:25:53 +03:00
Dmitry Rubashkin
2705534be7 Merge branch 'enums_in_section' of github.com:dimarub2000/ClickHouse into enums_in_section 2019-09-13 20:50:53 +03:00
Dmitry Rubashkin
cd95e8e5e5 Fix inconsistent behaviour of IN with Enums 2019-09-13 20:49:53 +03:00
CurtizJ
ad986f285e fix redis with mixed keys 2019-09-13 20:38:56 +03:00
akuzm
e765733a26
Merge pull request #6925 from yandex/aku/msan
Some MemorySanitizer fixes
2019-09-13 20:26:48 +03:00
chertus
eb3d87032c all|any left|inner, not tested 2019-09-13 20:23:32 +03:00
alexey-milovidov
10e274213d
Merge pull request #6930 from filimonov/performance_test_lowcard_arr
performance test for lowcardinality array
2019-09-13 20:01:57 +03:00
dimarub2000
24d0055dc8 Typo 2019-09-13 19:24:59 +03:00
dimarub2000
26b1bc2093 all_of setting now works properly 2019-09-13 19:18:26 +03:00
chertus
bd957168d2 any left join (without use_nulls) 2019-09-13 19:17:37 +03:00
Ivan
d697f4a1d1
Update 01009_global_array_join_names.sql 2019-09-13 19:07:54 +03:00
Ivan Lezhankin
5b60053ef7 [WIP] 2019-09-13 17:56:27 +03:00
Ivan Lezhankin
e692a88196 CMake now works
Example: -DCMAKE_SYSTEM_NAME=Darwin -DSDK_PATH=${HOME}/stuff/MacOSX10.12.sdk -DLINKER_NAME=${HOME}/.local/bin/ld64
2019-09-13 17:56:27 +03:00
Ivan Lezhankin
1b5192706e Some fixes for OS X build. 2019-09-13 17:56:26 +03:00
Ivan
add919e922
Update 01009_global_array_join_names.sql 2019-09-13 17:44:04 +03:00