Commit Graph

22895 Commits

Author SHA1 Message Date
Alexey Milovidov
92824e14e7 Added a test 2019-11-05 01:18:59 +03:00
Alexey Milovidov
979db8c965 Improve "arrayCompact" function 2019-11-05 01:13:10 +03:00
alexey-milovidov
fbed472018
Update 00076_ip_coding_functions.sql 2019-11-05 00:53:35 +03:00
Azat Khuzhin
4dfffdd24a Write current batch for distributed send atomically (using .tmp + rename)
Otherwise the following can happen after reboot:

    2019.11.01 11:46:12.217143 [ 187 ] {} <Error> dist.Distributed.DirectoryMonitor: Code: 27, e.displayText() = DB::Exception: Cannot parse input: expected \n before: S\'^A\0^]\0\0<BE>4^A\0r<87>\0\0<A2><D7>^D^Y\0<F2>{^E<CD>\0\0Hy\0\0<F2>^_^C\0^_&\0\0<FF><D3>\0\0
    <8D><91>\0\0<C0>9\0\0<C0><B0>^A\0^G<AA>\0\0<B5><FE>^A\0<BF><A7>^A\0<9B><CB>^A\0I^R^A\0<B7><AB>^A\0<BC><8F>\0\0˲^B\0Zy\0\0<94><AA>\0\0<98>
    <8F>\0\0\f<A5>\0\0^QN\0\0<E3><C6>\0\0<B1>6^B\0ɳ\0\0W<99>\0\0<B9><A2>\0\0:<BB>\0\0)<B1>\0\0#<8B>\0\0aW\0\0<ED>#\0\0<F1>@\0\0ˀ^B\0<D7><FC>\0\0<DF>, Stack trace:

    0. 0x559e27222e60 StackTrace::StackTrace() /usr/bin/clickhouse
    1. 0x559e27222c45 DB::Exception::Exception(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, int) /usr/bin/clickhouse
    2. 0x559e26de4473 ? /usr/bin/clickhouse
    3. 0x559e272494b5 DB::assertString(char const*, DB::ReadBuffer&) /usr/bin/clickhouse
    4. 0x559e2a5dab45 DB::StorageDistributedDirectoryMonitor::processFilesWithBatching(std::map<unsigned long, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::less<unsigned long>, std::allocator<std::pair<unsigned long const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > > const&) /usr/bin/clickhouse
    5. 0x559e2a5db5fa DB::StorageDistributedDirectoryMonitor::processFiles() /usr/bin/clickhouse
    6. 0x559e2a5dba78 DB::StorageDistributedDirectoryMonitor::run() /usr/bin/clickhouse
    7. 0x559e2a5ddbbc ThreadFromGlobalPool::ThreadFromGlobalPool<void (DB::StorageDistributedDirectoryMonitor::*)(), DB::StorageDistributedDirectoryMonitor*>(void (DB::StorageDistributedDirectoryMonitor::*&&)(), DB::StorageDistributedDirectoryMonitor*&&)::{lambda()#1}::operator()() const /usr/bin/clickhouse
    8. 0x559e2726b07c ThreadPoolImpl<std::thread>::worker(std::_List_iterator<std::thread>) /usr/bin/clickhouse
    9. 0x559e2bbc3640 ? /usr/bin/clickhouse
    10. 0x7fbd62b3cfb7 start_thread /lib/x86_64-linux-gnu/libpthread-2.29.so
    11. 0x7fbd62a692ef __clone /lib/x86_64-linux-gnu/libc-2.29.so
     (version 19.17.1.1)

v2: remove fsync, to avoid possible stalls (https://github.com/ClickHouse/ClickHouse/pull/7600#discussion_r342010874)
2019-11-05 00:24:38 +03:00
alexey-milovidov
5aceca9e17
Merge pull request #7615 from amosbird/fix21
Global context should be unique.
2019-11-05 00:16:37 +03:00
Mikhail Korotov
0781065bd8 improved changes 2019-11-04 22:10:02 +03:00
Nicolae Vartolomei
ac6472b03f Try and enable test_replicated_alters 2019-11-04 17:15:28 +00:00
Mikhail Korotov
dd99468e7b Created integration test for part_log table 2019-11-04 20:13:49 +03:00
Vladimir Chebotarev
9869ee141c Fixed exception in case of using 1 argument while defining S3, URL and HDFS storages. 2019-11-04 20:11:50 +03:00
Amos Bird
e2cfc3ecab
Global context should be unique. 2019-11-04 23:43:13 +08:00
alexey-milovidov
81e33ca817
Merge pull request #7586 from 4ertus2/joins
Rewrite NonJoinedBlockInputStream
2019-11-04 14:49:47 +03:00
alexey-milovidov
b261e6033a
Merge pull request #7602 from excitoon-favorites/cloneAndLoadDataPartOnSameDisk
Made `MergeTreeData::cloneAndLoadDataPart` only work for the same disk.
2019-11-04 14:42:30 +03:00
alexey-milovidov
1354d1079a
Merge pull request #7605 from zhang2014/fix/is_local_show
fix cluster system is_local
2019-11-04 14:35:37 +03:00
alexey-milovidov
782e2f6c13
Merge pull request #7606 from amosbird/nullformat
Better Null format for tcp handler.
2019-11-04 14:27:27 +03:00
Zhichang Yu
da2d05802c added bitmapTransform 2019-11-04 14:55:31 +08:00
Amos Bird
8f902dc2a9
Better null format for tcp handler. 2019-11-04 11:53:26 +08:00
zhang2014
08894484ee fix cluster system is_local 2019-11-04 10:56:12 +08:00
alexey-milovidov
a8d6843723
Merge pull request #7599 from azat/__getScalar-fix
Check column for __getScalar() (avoids assertion)
2019-11-04 02:28:42 +03:00
Vladimir Chebotarev
e76bbfc5ad Made MergeTreeData::cloneAndLoadDataPart only work for the same disk. 2019-11-04 01:27:05 +03:00
Azat Khuzhin
920572915e Add regression test for the __getScalar() 2019-11-04 00:31:10 +03:00
alexey-milovidov
d9c02b652f
Merge pull request #7594 from amosbird/fix20
early constant folding improvement
2019-11-04 00:30:16 +03:00
chertus
b7b664845d return right x in RIGHT|FULL JOIN .. USING(x) from NonJoinedBlockInputStream if not qualified 2019-11-03 23:30:49 +03:00
chertus
d4e1468022 fix Join.saved_block_sample columns' nullability 2019-11-03 22:33:59 +03:00
Azat Khuzhin
842f4e2ca0 Check column for __getScalar() (avoids assertion)
Can be triggered using the following query:
  CREATE TABLE foo (key String, macro String MATERIALIZED __getScalar(key)) Engine=Null();

Trace:
    3. 0x00007ffff6d5d526 __assert_fail (libc.so.6)
    4. 0x00007ffff41fd931 boost::intrusive_ptr<DB::IColumn const>::operator*() const (libclickhouse_functionsd.so)
    5. 0x00007ffff41fcd64 COW<DB::IColumn>::IntrusivePtr<DB::IColumn const>::operator*() const & (libclickhouse_functionsd.so)
    6. 0x00007ffff4dc5944 DB::FunctionGetScalar::getReturnTypeImpl() const (libclickhouse_functionsd.so)

(Even though it is internal I guess it is better to fix it)

Refs: #7392
Cc: @amosbird
2019-11-03 21:44:56 +03:00
Amos Bird
f0b3c1f7c7
early constant folding improvement 2019-11-03 21:17:46 +08:00
alexey-milovidov
d08bfbd3e1
Merge pull request #7328 from Joeywzr/arrayCompact
implement arrayCompact
2019-11-03 01:07:19 +03:00
alexey-milovidov
fa0274e223
Merge pull request #7380 from hczhcz/patch-1018
Add function arrayFill and arrayReverseFill
2019-11-03 01:06:41 +03:00
alexey-milovidov
ada6ee4137
Merge pull request #7591 from ClickHouse/one-more-attempt-djvu-bugfix
One more attempt of bugfix of infinite loop in pretty space format
2019-11-02 23:40:53 +03:00
alexey-milovidov
15c4a19bb1
Merge pull request #7585 from ernestp/macos_catalina_2019_11_01
Fixed compile errors on macOS Catalina
2019-11-02 15:46:17 +03:00
alexey-milovidov
f5531fb436
Merge pull request #7590 from amosbird/typetrait
ubsan fix
2019-11-02 13:22:39 +03:00
proller
6a573b4092 Allow to use mysql format without ssl - try2 with mysql interface split (#7524)
* Allow use mysql format without ssl

* fix

* fix

*  fix

* Also disable poco's optional libraries

* clean

* fix

* fix

* Requested changes

* clean

* Requested fixes

* Update MySQLHandler.cpp
2019-11-02 13:20:46 +03:00
alexey-milovidov
6e4d63e394
Merge pull request #7575 from Alex-Burmak/escaping_fix
Fixed missing file name escaping in FREEZE command
2019-11-02 13:20:28 +03:00
Amos Bird
ad12099642
ubsan fix 2019-11-02 17:00:03 +08:00
stavrolia
e58aa4e579 One more attempt of bugfix of infinite loop in pretty space format 2019-11-02 11:53:35 +03:00
stavrolia
d503c38cac Revert "Merge pull request #7587 from ClickHouse/fix-nonsignificant-djvu-bug"
This reverts commit 102a76ab47, reversing
changes made to dea9220e3c.
2019-11-02 03:23:27 +03:00
Olga Khvostikova
102a76ab47
Merge pull request #7587 from ClickHouse/fix-nonsignificant-djvu-bug
Find and retrieve lost bug fix in pretty spaces
2019-11-02 02:46:24 +03:00
stavrolia
89d8e6de93 Fix 2019-11-02 02:39:43 +03:00
alexey-milovidov
dea9220e3c
Merge pull request #7542 from hczhcz/patch-1030
Fix "create as select" parsing
2019-11-02 00:58:09 +03:00
alexey-milovidov
ad01f7b1ac
Merge pull request #7552 from azat/do-not-account-memory-for-Buffer-in-max_memory_usage
[RFC] Do not account memory for Buffer engine in max_memory_usage limit
2019-11-02 00:57:24 +03:00
alexey-milovidov
dda93e2275
Merge pull request #7561 from ClickHouse/achimbab-master
Merge for #7363
2019-11-02 00:57:13 +03:00
alexey-milovidov
7de9fdc183
Merge pull request #7579 from amosbird/countperftest
Add perf test for early constant folding
2019-11-02 00:51:45 +03:00
alesapin
d388565d04
Add create database query in test. 2019-11-01 22:35:50 +03:00
Nikita Mikhaylov
3c57b8e9c2 test 2019-11-01 21:59:54 +03:00
chertus
334b91f351 revrite NonJoinedBlockInputStream (in progress) 2019-11-01 20:41:07 +03:00
Ernest Poletaev
de1e5d0e53 Fixed compile errors on macOS Catalina 2019-11-01 23:33:43 +07:00
Nikolai Kochetov
239d92a94c Code cleanup. 2019-11-01 18:31:02 +03:00
Amos Bird
9626e24206
Add perf test for early constant folding 2019-11-01 22:33:03 +08:00
Nikolai Kochetov
575eabd4ff Add flag to set that set is created. 2019-11-01 16:56:33 +03:00
alexey-milovidov
4081b0be90
Merge pull request #7497 from amosbird/countopt
Early constant folding.
2019-11-01 16:54:02 +03:00
Alexander Burmak
9b8fc9a899 Fixed missing file name escaping in FREEZE command 2019-11-01 16:17:08 +03:00
Nikita Mikhaylov
0e04d14b7d cancel 2019-11-01 15:31:48 +03:00
Ivan
21db9157f7
Don't initialize some constant blocks in a loop (#7475) 2019-11-01 14:34:29 +03:00
Nikolai Kochetov
388bbb950b Add flag to set that set is created. 2019-11-01 14:03:35 +03:00
Nikolai Kochetov
1f7a798c97 Add flag to set that set is created. 2019-11-01 13:58:29 +03:00
alesapin
6ef0a92535
Merge pull request #7558 from excitoon/patch-1
Made mutation to choose the same disk in `ReplicatedMergeTree`.
2019-11-01 13:52:45 +03:00
alexey-milovidov
b1fe128109
Merge pull request #7562 from amosbird/parser3
Complement to #7501
2019-11-01 13:15:36 +03:00
Nikolai Kochetov
ddcbc2f9d3 Enable processors by default. 2019-11-01 12:45:33 +03:00
Nikolai Kochetov
d31cac33b2 Small fixes. 2019-11-01 12:41:20 +03:00
Nikolai Kochetov
5bb47e2484
Merge pull request #7181 from ClickHouse/processors-and-storages
Processors and storages
2019-11-01 12:04:49 +03:00
Nikolai Kochetov
c0fccd5b87 Simplified code. 2019-11-01 11:32:41 +03:00
Amos Bird
5333258e7e
Complement to tuple parser 2019-11-01 10:48:15 +08:00
alexey-milovidov
30b2d85fb0
Merge pull request #7501 from amosbird/parser2
Some parser improvements.
2019-10-31 23:48:14 +03:00
Azat Khuzhin
dbe45800d9 Do not account memory for Buffer engine in max_memory_usage limit
Since background flush will not be accounted there, and it can be too
tricky to calclulate this limit, in case you have multiple materialized
views with Buffer engine.

v2: test adjustment
2019-10-31 22:26:50 +03:00
Nikolai Kochetov
9a5a0a2a3b Fix types for set elements. 2019-10-31 19:14:06 +03:00
Vitaly Baranov
56011d4649
Merge pull request #7553 from vitlibar/add-constraints-columns-to-table-system-settings
Add constraints columns to table system.settings
2019-10-31 19:06:46 +03:00
Amos Bird
e04cdd4ebb
Early constant folding. 2019-10-31 23:54:32 +08:00
Amos Bird
4aff9a20c6
Better parser 2019-10-31 23:22:48 +08:00
Nikita Mikhaylov
9d8bbeb473 bad fix for PrettyCompact 2019-10-31 17:31:19 +03:00
Vladimir Chebotarev
faf1b070ac
Typo was fixed. 2019-10-31 16:26:11 +03:00
Vladimir Chebotarev
0dea6f5458
Added comment for selecting disk for mutation. 2019-10-31 16:19:38 +03:00
Nikolai Kochetov
be1ccaa890 Fix clang build. 2019-10-31 16:18:21 +03:00
Vladimir Chebotarev
f44cee623a
Made mutation to choose the same disk in ReplicatedMergeTree. 2019-10-31 15:22:25 +03:00
Nikolai Kochetov
18378417df Fix build. 2019-10-31 14:48:35 +03:00
Nikolai Kochetov
a80338e066 Merged with master 2019-10-31 14:41:29 +03:00
Nikolai Kochetov
a38124c68e Review fixes. 2019-10-31 14:32:24 +03:00
Vitaly Baranov
272608762e Fix comment. 2019-10-31 11:45:14 +03:00
alexey-milovidov
417c008700
Update 01021_create_as_select.sql 2019-10-31 11:29:30 +03:00
hcz
134bc80940
Create array_fill.xml 2019-10-31 14:30:11 +08:00
sundy-li
17212afabb fix virtual call 2019-10-31 13:19:28 +08:00
sundy-li
d2a785f759 fix style 2019-10-31 12:59:50 +08:00
hcz
4c7a54113d Add tests 2019-10-31 11:33:23 +08:00
Vitaly Baranov
5601d6ae66 Add constraints columns to table system.settings 2019-10-31 01:45:57 +03:00
alexey-milovidov
194fd85f5c
Update arrayCompact.cpp 2019-10-31 00:29:15 +03:00
alexey-milovidov
0d2a2c332f
Merge pull request #7366 from achimbab/fixbug_inop
Made IN operator support Array(LowCardinality(Nullable(String)))
2019-10-31 00:26:22 +03:00
alexey-milovidov
88d43488e1
Merge pull request #7412 from 4ertus2/strange
merge_max_block_size in settings
2019-10-31 00:24:43 +03:00
alexey-milovidov
883c868b36
Merge pull request #7523 from ClickHouse/fix-thread-context-attach
Disable context replacement for internal queries
2019-10-31 00:07:13 +03:00
alexey-milovidov
8cfc70aad0
Merge pull request #7551 from ClickHouse/merge-fast-count
Improvements for fast count() after #7510
2019-10-30 23:55:58 +03:00
Nikita Mikhaylov
cb48ee42a3 enable feature 2019-10-30 23:51:23 +03:00
alexey-milovidov
1ec7cb3546
Update range.cpp 2019-10-30 23:39:29 +03:00
alexey-milovidov
bb75c7469a
Merge pull request #7545 from ClickHouse/fix_only_tuple_columns
Fix only tuple columns in table.
2019-10-30 23:34:23 +03:00
proller
0006f2a370 Fix build without submodules (#7295)
* Build fixes

*            fix

* Fix

* fix

* Fix install(export..

* Freebsd fixes

* Freebsd fixes

* Fix warning

* fix

* More PRIVATE linking

* Fix review

* Timmy

* Timmy

* fix

* Try fix jemalloc link

* style
2019-10-30 23:34:06 +03:00
Alexey Milovidov
fe73354320 Improvements after #7510 2019-10-30 22:15:55 +03:00
Amos Bird
4609ca3189
Enable bracketed paste if possible 2019-10-31 02:33:45 +08:00
alexey-milovidov
ddb58eeb8b
Merge pull request #7510 from amosbird/smartcount
Instant count() for MergeTree
2019-10-30 20:42:00 +03:00
alesapin
e2424bda4c Fix style 2019-10-30 19:00:40 +03:00
Nikita Mikhaylov
874f88e5a5 disable feature to test 2019-10-30 18:54:02 +03:00
Nikita Mikhaylov
b691cc744c comments and checks 2019-10-30 18:49:10 +03:00
alesapin
7f4e982d13 Add tests 2019-10-30 17:51:30 +03:00
alesapin
2b5ef8bdef Fix bug when table contains only tuple columns 2019-10-30 17:50:59 +03:00
hcz
4dca99fa65 Fix create as select parsing 2019-10-30 21:06:23 +08:00
Artem Zuikov
0f68c5a12a
Merge pull request #7530 from 4ertus2/joins
Fix right table key nullability (join_use_keys = 0)
2019-10-30 13:30:27 +03:00
Ivan
4f2f5cca84
Add support for cross-compiling to the CPU architecture AARCH64 (#7370) 2019-10-30 10:01:53 +03:00
sundy-li
7292748012 fix docs 2019-10-30 10:06:30 +08:00
sundy-li
be9da37720 fix zero divide 2019-10-30 09:36:50 +08:00
chertus
deb2406b30 fix JOIN right table keys nullability 2019-10-29 22:39:42 +03:00
Nikita Mikhaylov
5bcfee117a empty + master 2019-10-29 20:05:10 +03:00
Nikita Mikhaylov
08f1930e76 Merge branch 'master' of github.com:ClickHouse/ClickHouse into parallel_parsing 2019-10-29 20:04:32 +03:00
Olga Khvostikova
ff4d90f602
Add test for greatCircleDist 2019-10-29 19:49:37 +03:00
alexey-milovidov
6e837e86e6
Merge pull request #7500 from amosbird/parsernit
Fix DUMP debug.
2019-10-29 19:25:20 +03:00
Amos Bird
1eb44c6837
Add missing tests 2019-10-29 22:26:43 +08:00
chertus
12b57aedf0 remove error prone code 2019-10-29 16:52:05 +03:00
Alexander Kuzmenkov
55ec00977b
Update dbms/src/Functions/greatCircleDistance.cpp 2019-10-29 16:31:53 +03:00
sundy-li
6f2cce37d7 fix move 2019-10-29 19:22:00 +08:00
sundy-li
718fb99939 fix move 2019-10-29 19:20:35 +08:00
millb
c154675a17 fixed_merge_conflict:wq 2019-10-29 13:30:47 +03:00
Mikhail Korotov
57f6780136
Update ErrorCodes.cpp 2019-10-29 14:39:57 +03:00
alesapin
cde07dd620 Disable context replacement for internal queries 2019-10-29 13:27:19 +03:00
Amos Bird
2c75a51d4f
Instant count() for MergeTree
Use (Replicated)MergeTree's metadata to do trivial count()
2019-10-29 17:45:47 +08:00
sundy-li
00389a67a0 add more tests 2019-10-29 14:55:59 +08:00
sundy-li
66ffec32f7 improve range to support start,step args 2019-10-29 14:33:03 +08:00
sundy-li
9eb77a59e3 fix index 2019-10-29 13:20:18 +08:00
sundy-li
a653f50432 remove logs 2019-10-29 13:01:45 +08:00
sundy-li
dbd3227e5a fixup partial const column 2019-10-29 11:51:27 +08:00
sundy-li
3f1651fa29 improve range 2019-10-29 11:03:47 +08:00
memo
3449e8d107 fix 2019-10-29 10:27:54 +08:00
Nikita Mikhaylov
c5085b86aa max_threads limit 2019-10-29 02:43:22 +03:00
Nikita Mikhaylov
2bd79325d7 test kafka limit 2019-10-28 17:41:24 +03:00
Alexander Kuzmenkov
6e2af3db41
Merge pull request #7480 from azat/crc-v3
Add CRC32IEEE()/CRC64() support
2019-10-28 16:16:37 +03:00
Amos Bird
15d12db16a
Fix DUMP debug. 2019-10-28 19:39:51 +08:00
Nikita Mikhaylov
756a10707d Merge branch 'master' of github.com:ClickHouse/ClickHouse into parallel_parsing 2019-10-28 13:51:52 +03:00
Nikita Mikhaylov
206800b8fc add stderr configs to kafka test 2019-10-28 13:51:43 +03:00
Alexander Kuzmenkov
c3ea94209b
Merge pull request #7491 from traceon/odbc-bridge-type-mapping-fix
Add handling of SQL_TINYINT and SQL_BIGINT, fix SQL_FLOAT in ODBC Bridge
2019-10-28 13:30:18 +03:00
memo
3064e716db add line 2019-10-28 14:48:25 +08:00
memo
0f572e5d7d add line 2019-10-28 12:51:59 +08:00
memo
90333ac9aa modified getReturnType 2019-10-28 11:15:52 +08:00
sundy-li
538b77c123 functions: add char function as mysql behavior 2019-10-28 10:44:56 +08:00
Nikolai Kochetov
43c8d13de6
Merge pull request #7496 from amosbird/fix15
Fix HAVING without GROUP BY
2019-10-28 02:44:24 +03:00
Amos Bird
77bdfb3350
Fix HAVING without GROUP BY 2019-10-27 22:10:54 +08:00
Azat Khuzhin
04f1e6b2cc Use crc32_z() over crc32(), since it size_t for length 2019-10-25 23:32:29 +03:00
Nikita Mikhaylov
4fe0dda453 add cancel test 2019-10-25 21:03:38 +03:00
Denis Glazachev
8e48430159 Add handling of SQL_TINYINT and SQL_BIGINT
Fix handling of SQL_FLOAT
2019-10-25 21:49:49 +04:00
Nikita Mikhaylov
980528ed75 docs 2019-10-25 17:32:57 +03:00
Azat Khuzhin
2d2e738085 Add CRC32IEEE()/CRC64() support
zlib's implementation uses CRC-32-IEEE 802.3 polynomial (0xedb88320) but
with starting value 0xffffffff, so introduce another crc32
implementation - CRC32IEEE that has starting value - 0

Also add CRC64 with ECMA polynomial.

v2: s/crc*_data./crc*_data./ to avoid conflicts with other crc32.h in contrib
v3: join with existing CRC32()
2019-10-25 15:52:41 +03:00
Nikita Mikhaylov
60ee52cb8d remove unrelated changes in tests 2019-10-25 15:28:52 +03:00
Nikita Mikhaylov
682b9df17f remove SharedReadBuffer + remove lambdas 2019-10-25 15:28:24 +03:00
alesapin
04ca163518 Merge branch 'master' into dictionaries_ddl_loader 2019-10-25 10:58:04 +03:00
hcz
3767cb76de Improve style 2019-10-25 11:25:02 +08:00
Nikita Mikhaylov
78b6322797 empty commit 2 2019-10-25 00:17:00 +03:00
alesapin
8755f5ffa9 Add missed config 2019-10-24 23:08:36 +03:00
Nikita Mikhaylov
76e64d1c1b empty commit 2019-10-24 21:06:45 +03:00
Artem Zuikov
df32d92ee5
Merge pull request #7358 from 4ertus2/ast
Better ambiguous column detection
2019-10-24 20:56:23 +03:00
Nikita Mikhaylov
342f259a1c comments 2019-10-24 19:52:55 +03:00
alesapin
5d8d1df802
Merge pull request #7434 from excitoon-favorites/fix-7424
Allowed to have some parts on destination disk or volume in MOVE PARTITION
2019-10-24 19:45:22 +03:00
alexey-milovidov
e865136b2c
Merge pull request #7450 from excitoon-favorites/test-7414
Added integration test for #7414 (validation of `max_data_part_size_bytes`).
2019-10-24 19:23:21 +03:00
Nikita Mikhaylov
c7084ff5dc better 2019-10-24 17:00:51 +03:00
chertus
f2028e901d review related changes 2019-10-24 16:04:50 +03:00
chertus
12cd21f3c3 Merge branch 'master' into ast 2019-10-24 15:20:09 +03:00
Artem Zuikov
39b64dff87
Merge pull request #7454 from 4ertus2/refactoring
Refactoring: extract non aliases logic out of QueryNormalizer
2019-10-24 14:34:53 +03:00
Vladimir Chebotarev
64f158ff28 Fixed message for ALTER MOVE PART. 2019-10-24 13:56:32 +03:00
Alexander Kuzmenkov
29052b6a37
Merge pull request #7377 from azat/INSERT-Distributed-MATERIALIZED-cols
* Fix INSERT into Distributed non local node with MATERIALIZED columns

Previous patch e527def18a ("Fix INSERT
into Distributed() table with MATERIALIZED column") fixes it only for
cases when the node is local, i.e. direct insert.

This patch address the problem when the node is not local
(`is_local == false`), by erasing materialized columns on INSERT into
Distributed.

And this patch fixes two cases, depends on `insert_distributed_sync`
setting:

- `insert_distributed_sync=0`

    ```
    Not found column value in block. There are only columns: date. Stack trace:

    2. 0x7ffff7be92e0 DB::Exception::Exception() dbms/src/Common/Exception.h:27
    3. 0x7fffec5d6cf6 DB::Block::getByName(...) dbms/src/Core/Block.cpp:187
    4. 0x7fffec2fe067 DB::NativeBlockInputStream::readImpl() dbms/src/DataStreams/NativeBlockInputStream.cpp:159
    5. 0x7fffec2d223f DB::IBlockInputStream::read() dbms/src/DataStreams/IBlockInputStream.cpp:61
    6. 0x7ffff7c6d40d DB::TCPHandler::receiveData() dbms/programs/server/TCPHandler.cpp:971
    7. 0x7ffff7c6cc1d DB::TCPHandler::receivePacket() dbms/programs/server/TCPHandler.cpp:855
    8. 0x7ffff7c6a1ef DB::TCPHandler::readDataNext(unsigned long const&, int const&) dbms/programs/server/TCPHandler.cpp:406
    9. 0x7ffff7c6a41b DB::TCPHandler::readData(DB::Settings const&) dbms/programs/server/TCPHandler.cpp:437
    10. 0x7ffff7c6a5d9 DB::TCPHandler::processInsertQuery(DB::Settings const&) dbms/programs/server/TCPHandler.cpp:464
    11. 0x7ffff7c687b5 DB::TCPHandler::runImpl() dbms/programs/server/TCPHandler.cpp:257
    ```

- `insert_distributed_sync=1`

    ```
    2019.10.18 13:23:22.114578 [ 44 ] {a78f669f-0b08-4337-abf8-d31e958f6d12} <Error> executeQuery: Code: 171, e.displayText() = DB::Exception: Block structure mismatch in RemoteBlockOutputStream stream: different number of columns:
    date Date UInt16(size = 1), value Date UInt16(size = 1)
    date Date UInt16(size = 0): Insertion status:
    Wrote 1 blocks and 0 rows on shard 0 replica 0, 127.0.0.1:59000 (average 0 ms per block)
    Wrote 0 blocks and 0 rows on shard 1 replica 0, 127.0.0.2:59000 (average 2 ms per block)
     (version 19.16.1.1) (from [::1]:3624) (in query: INSERT INTO distributed_00952 VALUES ), Stack trace:

    2. 0x7ffff7be92e0 DB::Exception::Exception() dbms/src/Common/Exception.h:27
    3. 0x7fffec5da4e9 DB::checkBlockStructure<void>(...)::{...}::operator()(...) const dbms/src/Core/Block.cpp:460
    4. 0x7fffec5da671 void DB::checkBlockStructure<void>(...) dbms/src/Core/Block.cpp:467
    5. 0x7fffec5d8d58 DB::assertBlocksHaveEqualStructure(...) dbms/src/Core/Block.cpp:515
    6. 0x7fffec326630 DB::RemoteBlockOutputStream::write(DB::Block const&) dbms/src/DataStreams/RemoteBlockOutputStream.cpp:68
    7. 0x7fffe98bd154 DB::DistributedBlockOutputStream::runWritingJob(DB::DistributedBlockOutputStream::JobReplica&, DB::Block const&)::{lambda()#1}::operator()() const dbms/src/Storages/Distributed/DistributedBlockOutputStream.cpp:280
    <snip>
    ````

Fixes: #7365
Fixes: #5429
Refs: #6891

* Cover INSERT into Distributed with MATERIALIZED columns and !is_local node

I guess that adding new cluster into server-test.xml is not required,
but it won't harm.

* Update DistributedBlockOutputStream.cpp
2019-10-24 12:35:09 +03:00
Alexander Kuzmenkov
050de71ef4
Update DistributedBlockOutputStream.cpp 2019-10-24 12:33:45 +03:00
alesapin
a6199b7e69 Merge with master 2019-10-24 12:33:40 +03:00
alesapin
7edd80c9b7 Add test for existing dictionary 2019-10-24 12:25:28 +03:00
Vladimir Chebotarev
255da8f5e0 Fixed style. 2019-10-24 12:11:06 +03:00
Vladimir Chebotarev
3debdc2119 Added integration tests for ALTER MOVE PARTITION and fixed minor things. 2019-10-24 11:52:33 +03:00
Vladimir Chebotarev
e8e5cefc35 Fixed integration test for #7414. 2019-10-24 08:59:33 +03:00
chertus
9818eada69 rename: merge_max_block_size 2019-10-24 02:18:21 +03:00
Artem Zuikov
18a72fa91a
Merge pull request #7392 from amosbird/scalar
better scalar query
2019-10-23 22:54:30 +03:00
Azat Khuzhin
80cf86f100 Cover INSERT into Distributed with MATERIALIZED columns and !is_local node
I guess that adding new cluster into server-test.xml is not required,
but it won't harm.
2019-10-23 21:55:08 +03:00
Azat Khuzhin
ab9d9f8997 Fix INSERT into Distributed non local node with MATERIALIZED columns
Previous patch e527def18a ("Fix INSERT
into Distributed() table with MATERIALIZED column") fixes it only for
cases when the node is local, i.e. direct insert.

This patch address the problem when the node is not local
(`is_local == false`), by erasing materialized columns on INSERT into
Distributed.

And this patch fixes two cases, depends on `insert_distributed_sync`
setting:

- `insert_distributed_sync=0`

    ```
    Not found column value in block. There are only columns: date. Stack trace:

    2. 0x7ffff7be92e0 DB::Exception::Exception() dbms/src/Common/Exception.h:27
    3. 0x7fffec5d6cf6 DB::Block::getByName(...) dbms/src/Core/Block.cpp:187
    4. 0x7fffec2fe067 DB::NativeBlockInputStream::readImpl() dbms/src/DataStreams/NativeBlockInputStream.cpp:159
    5. 0x7fffec2d223f DB::IBlockInputStream::read() dbms/src/DataStreams/IBlockInputStream.cpp:61
    6. 0x7ffff7c6d40d DB::TCPHandler::receiveData() dbms/programs/server/TCPHandler.cpp:971
    7. 0x7ffff7c6cc1d DB::TCPHandler::receivePacket() dbms/programs/server/TCPHandler.cpp:855
    8. 0x7ffff7c6a1ef DB::TCPHandler::readDataNext(unsigned long const&, int const&) dbms/programs/server/TCPHandler.cpp:406
    9. 0x7ffff7c6a41b DB::TCPHandler::readData(DB::Settings const&) dbms/programs/server/TCPHandler.cpp:437
    10. 0x7ffff7c6a5d9 DB::TCPHandler::processInsertQuery(DB::Settings const&) dbms/programs/server/TCPHandler.cpp:464
    11. 0x7ffff7c687b5 DB::TCPHandler::runImpl() dbms/programs/server/TCPHandler.cpp:257
    ```

- `insert_distributed_sync=1`

    ```
    2019.10.18 13:23:22.114578 [ 44 ] {a78f669f-0b08-4337-abf8-d31e958f6d12} <Error> executeQuery: Code: 171, e.displayText() = DB::Exception: Block structure mismatch in RemoteBlockOutputStream stream: different number of columns:
    date Date UInt16(size = 1), value Date UInt16(size = 1)
    date Date UInt16(size = 0): Insertion status:
    Wrote 1 blocks and 0 rows on shard 0 replica 0, 127.0.0.1:59000 (average 0 ms per block)
    Wrote 0 blocks and 0 rows on shard 1 replica 0, 127.0.0.2:59000 (average 2 ms per block)
     (version 19.16.1.1) (from [::1]:3624) (in query: INSERT INTO distributed_00952 VALUES ), Stack trace:

    2. 0x7ffff7be92e0 DB::Exception::Exception() dbms/src/Common/Exception.h:27
    3. 0x7fffec5da4e9 DB::checkBlockStructure<void>(...)::{...}::operator()(...) const dbms/src/Core/Block.cpp:460
    4. 0x7fffec5da671 void DB::checkBlockStructure<void>(...) dbms/src/Core/Block.cpp:467
    5. 0x7fffec5d8d58 DB::assertBlocksHaveEqualStructure(...) dbms/src/Core/Block.cpp:515
    6. 0x7fffec326630 DB::RemoteBlockOutputStream::write(DB::Block const&) dbms/src/DataStreams/RemoteBlockOutputStream.cpp:68
    7. 0x7fffe98bd154 DB::DistributedBlockOutputStream::runWritingJob(DB::DistributedBlockOutputStream::JobReplica&, DB::Block const&)::{lambda()#1}::operator()() const dbms/src/Storages/Distributed/DistributedBlockOutputStream.cpp:280
    <snip>
    ````

Fixes: #7365
Fixes: #5429
Refs: #6891
2019-10-23 21:54:27 +03:00
Artem Zuikov
bb1c1d0ed9
Merge pull request #7431 from arenadata/master
fix aggregation (avg and quantiles) over empty decimal columns.
2019-10-23 20:28:35 +03:00
chertus
20093fa065 extract more logic out of QueryNormalizer 2019-10-23 16:59:03 +03:00
Amos Bird
295864e6e0
better scalar query 2019-10-23 21:37:54 +08:00
Nikita Mikhaylov
8b17ce492f remove unused mutex 2019-10-23 16:23:42 +03:00
Nikita Mikhaylov
c867d7a306 fix max_insert_block_size 2019-10-23 16:15:03 +03:00
alesapin
c3519ff376 Better check of dictionary lifetime for updates 2019-10-23 16:02:40 +03:00
Mikhail Korotov
09847b21f2
Update config_without_allowed_hosts.xml 2019-10-23 15:05:53 +03:00
Mikhail Korotov
868407d83f
Update config_with_only_regexp_hosts.xml 2019-10-23 15:05:32 +03:00
Mikhail Korotov
bdd505acbd
Update config_with_hosts.xml 2019-10-23 15:05:00 +03:00
Mikhail Korotov
3e53a9e78b
Update config_with_hosts.xml 2019-10-23 15:04:17 +03:00
Mikhail Korotov
895392668a
Update config_without_allowed_hosts.xml 2019-10-23 15:03:10 +03:00
Mikhail Korotov
b8763763f7
Update config_with_only_regexp_hosts.xml 2019-10-23 15:02:50 +03:00
Mikhail Korotov
c8220b7876
Update config_with_only_primary_hosts.xml 2019-10-23 15:02:19 +03:00
Mikhail Korotov
20caa8724c
Delete ReadWriteBufferFromHTTPWithHostFilter.h 2019-10-23 15:00:43 +03:00
Mikhail Korotov
717d88df45
Delete ReadWriteBufferFromHTTPWithHostFilter.cpp 2019-10-23 15:00:04 +03:00
millb
eca81dc32e Fixed bugs 2019-10-23 14:58:35 +03:00
Vladimir Chebotarev
7546c315a6 Added integration test for #7414. 2019-10-23 14:25:51 +03:00
stavrolia
22e960dbff Move initialisation of constants 2019-10-23 13:55:44 +03:00
Nikita Mikhaylov
31b69285fa fix data race on vector<bool> 2019-10-23 13:39:33 +03:00
Alexander Kuzmenkov
1a609c27bd
Merge pull request #6243 from ClickHouse/aku/hashtables
Introduce String Hash Map to speed up aggregation over short string keys.
2019-10-23 12:52:50 +03:00
alesapin
6a0246f58e Fix if 2019-10-23 12:40:09 +03:00
alesapin
0abb2e538b Remove strange logic 2019-10-23 12:36:20 +03:00
alesapin
fb349757ba Fix ubsan error 2019-10-23 12:27:34 +03:00
akonyaev
7426542b8b up precision for avg result to max of type 2019-10-23 11:22:51 +03:00
alexey-milovidov
5c73a75843
Merge pull request #7439 from volfco/master
Fixed spelling error in error message
2019-10-23 07:33:56 +03:00
alexey-milovidov
ffc2e4e149
Merge pull request #7396 from nvartolomei/nv/mv-extra-columns
Test materialized view pushing extra columns
2019-10-23 07:30:53 +03:00
alexey-milovidov
bd31ed3a20
Merge pull request #7418 from amosbird/addglob
Better add_globs
2019-10-23 07:28:13 +03:00
alexey-milovidov
44d2e1d27c
Merge pull request #7419 from amosbird/dump2
Resolve DUMP overload resolution ambiguity.
2019-10-23 07:19:38 +03:00
alexey-milovidov
f8d408e8f4
Merge pull request #7423 from excitoon/patch-1
Fixed erroneous warning `max_data_part_size is too low`
2019-10-23 07:17:33 +03:00
Nikolai Kochetov
9abab40512 Added more comments. 2019-10-23 06:45:43 +03:00
Nikita Mikhaylov
905a65b3d0 some changes after review 2019-10-22 21:01:44 +03:00
Colum
a413770a97 Fixed spelling error in error message 2019-10-22 10:02:51 -07:00
alesapin
c12014ca15 Fix shared build 2019-10-22 19:47:11 +03:00
alesapin
dfa9b0c149 Remove complex logic with lazy load 2019-10-22 19:26:15 +03:00
Nikolai Kochetov
e22b43c669
Merge pull request #7436 from amosbird/scalarperf
add perf test for subqueries with large scalars
2019-10-22 19:06:20 +03:00
Amos Bird
dd72f62f17
add perf test for subqueries with large scalars 2019-10-22 23:55:11 +08:00
akonyaev
6d0dbf7e95 add test returned datatype from quantile and median result for empty decimal data 2019-10-22 18:51:34 +03:00
akonyaev
71dd3a303e fix result type for avg aggregation 2019-10-22 18:31:56 +03:00
Vladimir Chebotarev
9446fd2c4d Allowed to have some parts on destination disk or volume in MOVE PARTITION. #7424 2019-10-22 17:45:01 +03:00
Nikolai Kochetov
bcc4c2f0af Disable processors by default. 2019-10-22 17:11:29 +03:00
Nikolai Kochetov
640da3f512 Try to fix AggregateFunctionGroupBitmap. 2019-10-22 16:59:13 +03:00
alesapin
dc6090a2ac More readable code in external loader 2019-10-22 16:41:17 +03:00
alesapin
ae42dd1cea Better doLoading locking logic 2019-10-22 15:57:58 +03:00
Nikita Mikhaylov
34d8ade4a0 Merge branch 'master' of github.com:ClickHouse/ClickHouse into parallel_parsing 2019-10-22 15:56:51 +03:00
akonyaev
6655eb6358 fix 2019-10-22 15:34:36 +03:00
akonyaev
dc7c4c1b9a add tests for aggregation over empty decimal table 2019-10-22 15:30:00 +03:00
alesapin
d3461f9d46 TODO comments 2019-10-22 14:03:16 +03:00
alesapin
99fac92b1d Fix comment 2019-10-22 13:49:11 +03:00
alesapin
4c5d150d7a Review fixes 2019-10-22 13:47:43 +03:00
Alexander Kuzmenkov
dfd9f26652 Port the latest dispatch() improvements. 2019-10-22 13:44:08 +03:00
Ivan
7ba4e36e73
Don't push to MVs when inserting into Kafka table (#7265)
* Do not insert values into MV when inserting directly to Kafka
* Add method noPushingToViews() to IStorage interface
  To separate InterpreterInsertQuery and StorageKafka
2019-10-22 13:31:28 +03:00
Vladimir Chebotarev
395e63ddf1
Fixed erroneous warning max_data_part_size is too low #7414 2019-10-22 12:24:30 +03:00
Alexander Kuzmenkov
be4618dd05
Merge pull request #7339 from amosbird/f10
Fix preciseExp10
2019-10-22 12:00:53 +03:00
Amos Bird
88834bd75a
Resolve DUMP overload resolution ambiguity. 2019-10-22 15:10:59 +08:00
Amos Bird
82d0dfa629
Better add_globs 2019-10-22 15:09:49 +08:00
hcz
d877ef6098 Merge remote-tracking branch 'hcz/patch-1018' into patch-1018 2019-10-22 11:31:23 +08:00
memo
645bcdacae add docs and simplify the code 2019-10-22 10:23:07 +08:00
Nikolai Kochetov
dad1e397e2 Fix build. 2019-10-22 02:51:36 +03:00
Nikolai Kochetov
e7ba48ee84 Fix build. 2019-10-22 02:49:44 +03:00
Artem Zuikov
21e4535fbd
Merge pull request #7411 from 4ertus2/some
Minor Visitors Improvement
2019-10-21 23:17:05 +03:00
Vitaly Baranov
f611fd4dfa
Merge pull request #7293 from Vdimir/feature/isvalidjson-5910
Add function isValidJSON
2019-10-21 21:24:18 +03:00
chertus
f024b007a2 default_merge_block_size setting 2019-10-21 20:57:26 +03:00
alesapin
83dbfe9634 New tests and fixes for them 2019-10-21 20:09:41 +03:00
Nikolai Kochetov
2b334a4adb Review fixes. 2019-10-21 19:26:29 +03:00
Mikhail Korotov
5d195ad233
Update ReadWriteBufferFromHTTPWithHostFilter.cpp 2019-10-21 19:24:39 +03:00
chertus
851b00c99f minor visitors improvement 2019-10-21 19:22:54 +03:00
Alexander Kuzmenkov
9c1f8109c7
Merge pull request #7402 from Enmk/odbc_bridge_nullable_fix
Fixed NULL-values in nullable columns through ODBC-bridge
2019-10-21 19:09:27 +03:00
Amos Bird
a860ee7891
Fix preciseExp10 2019-10-22 00:05:57 +08:00
alesapin
10f69eef03 Add tests for non standart dictionaries and fix bugs 2019-10-21 19:05:45 +03:00
Nikolai Kochetov
2893c35930 Merged with master. 2019-10-21 18:33:44 +03:00
Nikolai Kochetov
4ca83a8eb5 Disable processors by default. 2019-10-21 18:24:15 +03:00
Nikolai Kochetov
f7d2e1b758 Added Pipe class. Updated MergeTreeDataSelectExecutor. 2019-10-21 18:16:08 +03:00
alesapin
ff7850cfbd Remove strange code in favor of less strange code 2019-10-21 17:59:35 +03:00
Alexander Kuzmenkov
d865aeba9b Review fixes. 2019-10-21 17:54:53 +03:00
millb
8b8ca9a141 Support redirect improvement 2019-10-21 17:45:57 +03:00
alesapin
307f711500 Fix db mysql dictionaries iterator 2019-10-21 17:25:21 +03:00
alesapin
f7043c38bd Less diff 2019-10-21 17:20:42 +03:00
alesapin
fc05110d66 Better naming 2019-10-21 17:07:47 +03:00
alesapin
17c2f301e2 Remove accident cerr 2019-10-21 17:00:18 +03:00
alesapin
e4a936cf41 Fix add and reload 2019-10-21 16:54:23 +03:00
Vitaly Baranov
a0ca932035
Fix build and add comments. 2019-10-21 16:39:55 +03:00
Amos Bird
a864447802 Introduce String Hash Map.
It speeds up aggregation over short string keys. Use it as a default
aggregation method for string keys.
2019-10-21 16:27:35 +03:00
akonyaev
f6bb52637d return for empty avg result over decimal 0 in ResultT type 2019-10-21 16:05:32 +03:00
robot-clickhouse
7381489d5d Auto version update to [19.17.1.1] [54428] 2019-10-21 15:48:00 +03:00
robot-clickhouse
c70cd3dd17 Auto version update to [19.16.1.1532] [54427] 2019-10-21 15:47:27 +03:00
akonyaev
28710b7e42 unexpected behaviour for avg and quantile functions over empty decimal column without group by 2019-10-21 15:46:47 +03:00
chertus
4f0859a5fa Merge branch 'master' into ast 2019-10-21 15:08:05 +03:00
chertus
0d708569e3 fix test result (disabled push down) 2019-10-21 14:31:16 +03:00
chertus
5ef7376cbf fix distributed join on 2019-10-21 14:22:22 +03:00
millb
e6d0c2a66c Redirect support added 2019-10-21 12:42:28 +03:00
stavrolia
fdaacb5645 Fix test 2019-10-21 12:37:50 +03:00
Vasily Nemkov
e080324fd0 Fixed NULL-values in nullable columns through ODBC-bridge 2019-10-21 12:13:33 +03:00
alesapin
26c87e46c9 Merge branch 'master' into dictionaries_ddl_loader 2019-10-21 11:46:49 +03:00
alesapin
35e66d6696 Merge with master 2019-10-21 11:46:11 +03:00
millb
f64f6658ce Merge branch 'master' into url_engine_problem 2019-10-21 11:44:31 +03:00
millb
2a183c3d07 Merge branch 'master' into decimal_hex_function 2019-10-21 11:13:51 +03:00
hcz
79a27ece1a Flip the condition column in arrayFill 2019-10-21 11:19:11 +08:00
stavrolia
40688294b0 another attempt to fix clang warning 2019-10-21 01:56:22 +03:00
alexey-milovidov
61125e536b
Update 01019_materialized_view_select_extra_columns.sql 2019-10-20 17:59:26 +03:00
alexey-milovidov
8b8cc67873
Merge pull request #7390 from azat/processlist-log-queue_max_wait_ms
Add a message in case of queue_wait_max_ms wait takes place
2019-10-20 17:55:36 +03:00
Nicolae Vartolomei
b0f2f23a38 Test materialized view pushing extra columns
This test exists to prevent unintended changes to existing behaviour.

Although this behaviour might not be ideal it is can be exploited for 0-downtime changes to materialized views.

Step 1: Add new column to source table.
Step 2: Create new view reading source column.
Step 3: Swap views using `RENAME TABLE`.
Step 4: Add new column to destination table as well.
2019-10-20 10:26:44 +01:00
Aleksey Akulovich
a019e45093 fix typos in docs and comment (#7385) 2019-10-20 12:43:54 +08:00
philip.han
5e32bf1ae7 Removed unchecked type-casting 2019-10-19 21:42:08 +09:00
VDimir
797f76a187 Separate class for IsValidJSONImpl 2019-10-19 07:26:19 +00:00
alexey-milovidov
52bfa9927c
Merge pull request #7384 from ClickHouse/fix_ub_in_system_parts
Fix UB in StoragesInfoStream
2019-10-19 09:59:39 +03:00
VDimir
f1630b4e2e Merge branch 'master' into feature/isvalidjson-5910 2019-10-19 06:21:21 +00:00
Azat Khuzhin
260a9fba2b StorageDistributed: Drop extra inclusion of materializeBlock.h 2019-10-18 23:38:33 +03:00
Azat Khuzhin
94948c2579 Add a message in case of queue_wait_max_ms wait takes place
Since there no information about this, while this can be interesting,
for example to tune max_concurrent_queries in some cases.
2019-10-18 23:36:12 +03:00
chertus
c5a850240c better ambiguous column detection in multiple join rewriter 2019-10-18 20:09:17 +03:00
chertus
37f07213ee better test 2019-10-18 19:45:59 +03:00
chertus
1bb8174285 disable push down for CROSS JOIN tests 2019-10-18 19:34:06 +03:00
chertus
2533652847 columns match priority: table alias > table name> aliased table name 2019-10-18 19:16:57 +03:00
alesapin
a014924c19 Remove wrong tests 2019-10-18 19:04:12 +03:00
alesapin
cdc195727e Fix some races from lazy load and add ugly interface to loader (need to be refactored) 2019-10-18 19:04:09 +03:00
Alexander Kuzmenkov
5e2cc37381
Distinguish Array and Tuple field types when creating from array of Fields. (#7179) 2019-10-18 18:57:05 +03:00
stavrolia
1397a90324 Fix test and clang warning 2019-10-18 18:03:15 +03:00
hcz
2be06255b1
Update arrayFill.cpp 2019-10-18 21:31:18 +08:00
Alexander Tokmakov
06b28f9fe3 fix uninitialized offset for Lazy db 2019-10-18 16:09:24 +03:00
Alexander Kuzmenkov
3143fa37d7
Merge pull request #7371 from CurtizJ/fix-optimize-read-in-order
Fix optimize_read_in_order with IN and a subquery.
2019-10-18 15:55:53 +03:00
philip.han
5f1b14e313 Remove a dynamically sized array in BloomFilterHash.h 2019-10-18 19:39:10 +09:00
hcz
502672c973 Add aggregate function combinators: -OrNull & -OrDefault (#7331) 2019-10-18 12:25:39 +03:00
alesapin
71cbe878fc
Merge pull request #7374 from millb/fixed_getMultipleValuesFromConfig
Fixed function getMultipleValuesFromConfig
2019-10-18 11:55:41 +03:00
hcz
b87fe27cd6 Add tests 2019-10-18 16:45:56 +08:00
hcz
124ea9699a Add arrayFill 2019-10-18 16:45:39 +08:00
hcz
decd555317 Cleanup, keep function names consistent 2019-10-18 15:30:41 +08:00
alexey-milovidov
3803d94db6
Merge pull request #7376 from amosbird/helpakuzm
Fix ubsan introduced by Field refactoring.
2019-10-18 06:29:27 +03:00
philip.han
1d423fad73 Blocked "nested-array-type" for the bloom_filter 2019-10-18 11:55:01 +09:00
chertus
0f6176cc2d throw on ambiguous qualified column 2019-10-18 00:08:28 +03:00
Mikhail Korotov
a1f417a537
Update gtest_getMultipleValuesFromConfig.cpp 2019-10-18 00:07:27 +03:00
Amos Bird
16d1b4472e Fix ubsan introduced by Field refactoring. 2019-10-18 04:30:33 +08:00
alesapin
b222ec1209 Fix segmentation fault 2019-10-17 20:53:08 +03:00
alesapin
c29b39002d Fix race condition, add test 2019-10-17 20:36:53 +03:00
alesapin
05392fd882 Fix deadlock, add test and refactoring 2019-10-17 20:18:54 +03:00
millb
26d9ee3ae5 Fixed bug with function getMultipleValuesFromConfig and added test which confirms this. 2019-10-17 19:52:47 +03:00
vzakaznikov
66675edf2d Fixing data race with no_users_thread. (#7353) 2019-10-17 17:47:36 +03:00
vzakaznikov
ee1a2ce027 Fixing AddressSanitizer error in the LIVE VIEW getHeader() method. (#7271) 2019-10-17 17:43:11 +03:00
tavplubix
0046b9f137 Wait for jobs to finish on exception (fixes rare segfaults) (#7350) 2019-10-17 17:41:27 +03:00
Alexander Kuzmenkov
b62c9e729d
Merge pull request #7215 from ClickHouse/formats_improvements
Miscellaneous formats improvements
2019-10-17 17:37:38 +03:00
Alexander Kuzmenkov
3e662da6f4
Merge pull request #7351 from Enmk/http_keep_alive_timeout
Fixed issue of using HTTP timeout as TCP timeout value.
2019-10-17 16:14:29 +03:00
CurtizJ
546414c015 fix optimize_read_in_order with in subquery 2019-10-17 16:11:27 +03:00
akonyaev
22429a699e unexpected behaviour for avg over empty decimal column without group by 2019-10-17 16:08:04 +03:00
alesapin
6dfe5c7142 Better introspection 2019-10-17 16:05:12 +03:00
Ivan
e595df05d9
Fix CREATE TABLE AS from table with virtual columns (#7183)
* Disable undefined instrumentation for rdkafka
2019-10-17 14:12:35 +03:00
philip.han
8aac4d04de Fixed weird type-casting for IN-operator in bloom_filter 2019-10-17 19:53:41 +09:00
Alexander Kuzmenkov
e9d7da3dd4
Merge pull request #7359 from amosbird/joingetconst
Constness-aware JoinGet.
2019-10-17 13:35:37 +03:00
philip.han
08a348fbd1 Made IN operator support Array(LowCardinality(Nullable(String))) 2019-10-17 19:08:36 +09:00
alesapin
3987a45ea2 Fix build and style 2019-10-17 12:05:48 +03:00
stavrolia
688ec20de1 Fix style from clang warnings 2019-10-17 09:28:26 +03:00
memo
ef09cedbb8 fix test bug 2019-10-17 11:38:49 +08:00
Amos Bird
89247deb64 Constness-aware JoinGet. 2019-10-17 08:52:28 +08:00
tavplubix
c4b46e113e
Merge branch 'master' into formats_improvements 2019-10-16 23:00:17 +03:00
Alexander Tokmakov
e9e8d055af null_as_default for Values 2019-10-16 22:55:24 +03:00
stavrolia
65efaf7ac7 Delete macros 2019-10-16 22:52:35 +03:00
Alexander Tokmakov
102cbfd25a fix old bug with default values 2019-10-16 22:27:33 +03:00
Vladimir Chebotarev
512e97ddb3
Improved readability a little bit (MergeTreeData::getActiveContainingPart). 2019-10-16 22:01:50 +03:00
alesapin
842a31be8b More tests 2019-10-16 20:59:10 +03:00
alesapin
a19a699bef Fix confused variables 2019-10-16 20:52:56 +03:00
stavrolia
fdad33fcd0 Fix style 2019-10-16 20:43:44 +03:00
chertus
483108f46f column to table matching refactoring 2019-10-16 20:33:53 +03:00
stavrolia
ae2f5ad7d2 Speedup 2019-10-16 20:25:46 +03:00
alesapin
51de7a1cd1 Better tests 2019-10-16 20:12:53 +03:00
alesapin
fa557ab80d Better tests 2019-10-16 20:11:19 +03:00
alesapin
01e23f0a22 Better load of dictionaries 2019-10-16 20:06:52 +03:00
Alexander Tokmakov
5f6703130e fixes 2019-10-16 18:28:48 +03:00
millb
19a54a59bb Created: function hex for Decimal32, Decimal64, Decimal128 2019-10-16 18:28:10 +03:00
alesapin
b4e0ded048 Almost working 2019-10-16 17:59:52 +03:00
chertus
e6e88241fc SyntaxAnalyzer refactoring: better getTablesWithColumns() 2019-10-16 17:47:58 +03:00
Alexander Tokmakov
aa9d29d6ae Merge branch 'master' into formats_improvements 2019-10-16 17:15:13 +03:00
Alexander Kuzmenkov
91b995212f
Merge pull request #7343 from amosbird/bf10
Build fix
2019-10-16 16:59:46 +03:00
Vasily Nemkov
94095fcb92 Fixed issue of using HTTP timeout as TCP timeout value. 2019-10-16 16:04:26 +03:00
Alexander Kuzmenkov
16f252dce9
Merge pull request #7332 from Enmk/More_Date_and_DateTime_performance_tests
More performance test for Date and DateTime
2019-10-16 16:03:54 +03:00
Artem Zuikov
b70ca30447
Merge pull request #7335 from 4ertus2/ast
Remove asterisk_left_columns_only setting
2019-10-16 13:57:17 +03:00
Artem Zuikov
3ceeb95145
Merge pull request #7282 from 4ertus2/asof
ASOF JOIN inequalities
2019-10-16 13:46:52 +03:00
philip.han
a2bf848e12 Made bloom_filter type of index supporting LowCardinality and Nullable 2019-10-16 15:22:56 +09:00
memo
947c345eda style: Normalize the format 2019-10-16 14:05:43 +08:00
Amos Bird
dd128e9e1d Build fix 2019-10-16 10:49:29 +08:00
alesapin
e690a3ca32 Half working code 2019-10-15 21:04:17 +03:00
chertus
ccc8c1ad2a restore logic for array join (it's probably a hidden error) 2019-10-15 20:39:23 +03:00
Artem Zuikov
cf99f88bc4 PartialMergeJoin flush data on disk (#7186) 2019-10-15 19:31:49 +03:00
chertus
c727777a9c resolve some for review sentences 2019-10-15 18:49:00 +03:00
chertus
9667e54201 remove asterisk_left_columns_only setting 2019-10-15 17:42:57 +03:00
alesapin
3e068b81de Add loading of external dictionaries 2019-10-15 17:09:57 +03:00
Vasily Nemkov
48b3c21aaa More performance test for Date and DateTime
Added cases for:
 * binary operations: -,+,>,>=,<,<=,==,!=
 * previously-missing functions: timeSlot, toRelativeQuarterNum, toStartOfTenMinutes, toUnixTimestamp, addYears (and alike).
2019-10-15 15:20:54 +03:00
alesapin
f850408ae4 Convert AST to Abstract configuration 2019-10-15 15:16:19 +03:00
memo
8b1b7f2a5f add arrayCompact test 2019-10-15 16:09:10 +08:00
memo
d1fb238820 implement arrayCompact 2019-10-15 15:50:10 +08:00
alexey-milovidov
6a44336b86
Merge pull request #7304 from sundy-li/ttl_check
Check TTL in StorageFactory
2019-10-14 20:11:37 +03:00
Alexander Kuzmenkov
831fb2cbfd
Merge pull request #7283 from ClickHouse/aku/in-unconvertible
Ignore non-convertible values at any depth on the right side of the IN operator
2019-10-14 18:32:22 +03:00
Nikolai Kochetov
5364f76625 Fix build. 2019-10-14 16:50:16 +03:00
Alexander Kuzmenkov
160d8a6416 Ignore non-convertible values at any depth on the right side of IN
operator.

The values that are not convertible to the left argument type can't
match anyway, so it is safe to discard them.
2019-10-14 14:25:03 +03:00
stavrolia
5c15594672 Add performance test 2019-10-14 13:13:32 +03:00
alesapin
1ce0eb6e63 Appropriate error codes numbers 2019-10-14 13:04:10 +03:00
alesapin
ecde224692 More tests 2019-10-14 12:52:43 +03:00
alexey-milovidov
f0409348a1
Merge pull request #7294 from hczhcz/patch-1013
Add arraySplit
2019-10-14 12:32:09 +03:00
alesapin
67ea66604f Fix segmentation fault in database factory 2019-10-14 12:21:29 +03:00
sundy-li
b2109e4ece Check TTL in StorageFactory 2019-10-14 17:03:39 +08:00
Danila Kutenin
19ecc3e6cf
Merge pull request #7299 from ClickHouse/multi_match_all_indices
Add multi{Fuzzy}MatchAllIndices functions
2019-10-14 10:58:27 +02:00
Danila Kutenin
60d273a65d Get better message for non hyperscan supported platforms 2019-10-14 10:58:05 +02:00
alesapin
155731a676 Merge branch 'master' into dictionaries_ddl_interpreter 2019-10-14 11:49:18 +03:00
alexey-milovidov
323a756115
Merge pull request #7298 from Vdimir/feature/count-arity-validation-7095
Add missing arity validation for count/counIf
2019-10-14 08:52:58 +03:00
Danila Kutenin
7527896f1a Unused variables 2019-10-13 21:40:07 +02:00
VDimir
7adad4251f Remove AggregateFunctionCountNotNullVariadic 2019-10-13 18:42:39 +00:00
VDimir
99f531c58f Fix spelling require -> requires 2019-10-13 18:37:01 +00:00
Danila Kutenin
57f20ba17e All multi{Fuzzy}MatchAllIndices functions 2019-10-13 15:22:09 +02:00
hcz
c8c40e159d Add arraySplit 2019-10-13 16:06:57 +08:00
Nikolai Kochetov
7c2575542b Fix build. 2019-10-12 21:52:20 +03:00
Nikolai Kochetov
22dfc611c9 Remove comments from test. 2019-10-12 21:49:25 +03:00
alexey-milovidov
4dffc67434
Merge pull request #7291 from sundy-li/FQDN
Function FQDN, fullHostName
2019-10-12 20:02:22 +03:00
alexey-milovidov
62c7c50aba
Update FunctionsJSON.h 2019-10-12 20:00:32 +03:00
Nikolai Kochetov
757488369f Merge branch 'master' into processors-3 2019-10-12 19:24:02 +03:00
Nikolai Kochetov
51bce40d5e
Merge pull request #7284 from ClickHouse/fix-7216
Fix for #7216
2019-10-12 19:20:33 +03:00
VDimir
0230aca903 Remove tests with count accepting 2 args 2019-10-12 15:44:14 +00:00
VDimir
853322503f Allow count function arity at most one 2019-10-12 15:15:16 +00:00
Nikolai Kochetov
6f758babf6
Merge pull request #7289 from infinivision/fix_pull_7109
Fixed #7109 groupBitmapOr(31) segfault
2019-10-12 16:42:11 +03:00
Alexander Kuzmenkov
31bd359100
Merge pull request #7231 from ClickHouse/aku/podarray-includes
Include PODArray.h into fewer files.
2019-10-12 15:08:41 +03:00
VDimir
1174fc346b Add isValidJSON function 2019-10-12 11:42:43 +00:00
Nikolai Kochetov
25510e3d38 Try to fix perftests. 2019-10-12 13:06:07 +03:00
sundy-li
4e48992397 fullHostName by function getFQDNOrHostName 2019-10-12 17:21:30 +08:00
sundy-li
59d2989826 Function FQDN,fullHostName 2019-10-12 15:17:30 +08:00
Zhichang Yu
679db35ed3 Fixed #7109 groupBitmapOr(31) segfault 2019-10-12 10:36:52 +08:00
alesapin
aeb7504570
Merge pull request #7277 from ClickHouse/client-params-for-tests
Client parameters for clickhouse-test
2019-10-11 22:33:32 +03:00
Nikolai Kochetov
8186644562 Update test. 2019-10-11 21:04:58 +03:00
Nikolai Kochetov
4967bcdbd0 Fix test. 2019-10-11 21:02:34 +03:00
chertus
91c7ae83a3 asof join inequalities 2019-10-11 20:56:26 +03:00
Nikolai Kochetov
217eab0cfa Fix test. 2019-10-11 20:55:33 +03:00
Nikolai Kochetov
2684bd0d5e Fixes for 7216 2019-10-11 20:27:54 +03:00
Nikolai Kochetov
e5c8a62142 Fix tests. 2019-10-11 20:24:18 +03:00
Nikolai Kochetov
bf794a8260 Fix tests. 2019-10-11 18:59:27 +03:00
alesapin
653aa7c005 Fix unit tests and segfault 2019-10-11 18:41:52 +03:00
alesapin
967fe64793 Add simpliest tests 2019-10-11 18:22:30 +03:00
Vitaly Baranov
8c24d5e66a
Merge pull request #7235 from vitlibar/RBAC-1
RBAC-1
2019-10-11 17:16:32 +03:00
alesapin
dca0798d4d Compilable code 2019-10-11 16:51:31 +03:00
Nikolai Kochetov
10366f79ae Update url params in shell_config and tests.] 2019-10-11 16:34:26 +03:00
alesapin
ae42dc0d4c Attach detach and introspection queries for dictionaries 2019-10-11 16:21:52 +03:00
Nikolai Kochetov
2ecf7abf6c Update url params in shell_config. 2019-10-11 15:08:11 +03:00
Alexander Kuzmenkov
57b5592236 Work around garbage in roaring.h to fix Mac OS build. 2019-10-11 14:28:16 +03:00
Alexander Kuzmenkov
8a1d57bddb Include PODArray.h into fewer files. 2019-10-11 14:28:16 +03:00
Nikolai Kochetov
48bfcab428 Add ability to specify arguments to client in functional tests. 2019-10-11 13:30:32 +03:00
Vitaly Baranov
9e3815ccef Fix ubsan issue. 2019-10-11 12:53:10 +03:00
alesapin
3dfe961291 Merge branch 'master' into dictionaries_ddl_interpreter 2019-10-11 12:14:07 +03:00
alesapin
7159cde160 Remove accident change 2019-10-11 12:07:44 +03:00
alesapin
77c6d4d48f Changes 2019-10-11 12:05:12 +03:00
Nikolai Kochetov
89dfe7882d Enable processors by default. 2019-10-11 11:55:00 +03:00
Vitaly Baranov
060257c8c5 Remove Authentication::setType() function and fix comments. 2019-10-11 00:48:36 +03:00
Nikolai Kochetov
e48755d045 Merge branch 'master' into processors-and-storages 2019-10-11 00:46:37 +03:00
Nikolai Kochetov
9a89ee8eab
Merge pull request #7264 from ClickHouse/disable-memory-tracker-for-stack-trace
Disable memory tracker for exception stack.
2019-10-11 00:45:36 +03:00
Vitaly Baranov
18ccb4d64d Move backQuote() and quoteString() to a separate file, use StringRefs. 2019-10-11 00:18:52 +03:00
Vitaly Baranov
9f6d9d6130 Move the code which checks client host to a separate class. 2019-10-11 00:18:52 +03:00
Vitaly Baranov
12d1d87d64 Move authentication code to a separate class. 2019-10-11 00:18:52 +03:00
Nikolai Kochetov
a15d8f36d5
Merge pull request #7270 from azat/uniqCombined-memory-usage-tests-fixes
uniqCombined memory usage tests fixes
2019-10-10 23:53:55 +03:00
alesapin
2a5713e6e4 Compilable code 2019-10-10 23:47:47 +03:00
Nikolai Kochetov
0ce86e1f8f Disable memory tracker for exception stack. 2019-10-10 21:55:16 +03:00
Azat Khuzhin
e25bdc8d25 tests/00212_shard_aggregate_function_uniq: adjust values for uniqCombined(12)(String)
In e373862c83 the maxium size for HashTable in
CombinedCardinalityEstimator had been reduced for power of 2 for String
(since otherwise the size of the hashtable becames bigger then the
sizeof HLL).

Refs: https://github.com/ClickHouse/ClickHouse/pull/7236#issuecomment-540496270
Fixes: e373862c83 ("Do not use more then 98K of memory for uniqCombined*")
2019-10-10 21:47:51 +03:00
Azat Khuzhin
eb7d4797e3 tests/00212_shard_aggregate_function_uniq: break into sections 2019-10-10 21:47:51 +03:00
Azat Khuzhin
495d1de46f clickhouse-test: introduce -U/--unified option (pass to diff(1)) 2019-10-10 21:47:51 +03:00
alexey-milovidov
9c1c596146
Merge pull request #7252 from ClickHouse/fix-bad-code-in-transform-query-for-external-database
Fix bad code in transforming query for external database.
2019-10-10 21:10:36 +03:00
Nikolai Kochetov
f011c1020e Disable memory tracker for exception stack. 2019-10-10 20:37:34 +03:00
alesapin
67fc3347c2 Preparing databases for dictionaries 2019-10-10 20:33:01 +03:00
Nikolai Kochetov
742b948156 Disable memory tracker for exception stack. 2019-10-10 19:30:33 +03:00
Alexander Kazakov
03c7b7ff8d
Prevent from using non-deterministic functions in mutations of replicated tables (#7247)
* Added isDeterministic() to IFunctionBuilder i-face
* A test for non-deterministic mutations
* In MutationsInterpreter::validate() ensure deterministic functions
* Adjusted nondeterministic mutation tests
* Moved around some code in MutationsInterpreter::validate()
* Dropped unnecessary check in findFirstNonDeterministicFuncName()
* Corrections to IFunction{Base,Builder} interface
2019-10-10 17:38:08 +03:00
Nikolai Kochetov
ef14df4632 Added more comments. 2019-10-10 17:16:15 +03:00
Mikhail Korotov
7b62fc68cf
Update RemoteHostFilter.cpp 2019-10-10 16:53:52 +03:00
Mikhail Korotov
375866936d
Update RemoteHostFilter.h 2019-10-10 16:53:26 +03:00
millb
350f0b8a1c Merge remote-tracking branch 'origin/url_engine_problem' into url_engine_problem 2019-10-10 16:47:17 +03:00
Mikhail Korotov
70234975d1
Delete StorageOfAllowedURL.h 2019-10-10 16:13:44 +03:00
Mikhail Korotov
7f73af0cc9
Delete StorageOfAllowedURL.cpp 2019-10-10 16:13:33 +03:00
millb
a00089f0b4 Renamed StorageOfAllowedURL -> RemoteHostFilter 2019-10-10 15:58:06 +03:00
Nikolai Kochetov
378052743d Fix MergeTreeSequentialBlockInputStream. 2019-10-10 14:24:29 +03:00
Nikolai Kochetov
4728bdfccd Fix MergeTreeSequentialBlockInputStream. 2019-10-10 14:20:25 +03:00
alesapin
51c8188903
Merge pull request #7253 from ClickHouse/dictionaries_ddl_parser
Refactor parser create query
2019-10-10 11:34:21 +03:00
Mikhail Korotov
8d675ad2b4
Update TableFunctionRemote.cpp 2019-10-10 01:25:39 +03:00
Mikhail Korotov
b1c6fb571e
Update TableFunctionRemote.cpp 2019-10-10 01:25:17 +03:00
Mikhail Korotov
4710d2184c
Update Context.cpp 2019-10-10 01:24:27 +03:00
Mikhail Korotov
af8b20f0af
Update StorageOfAllowedURL.h 2019-10-10 01:23:31 +03:00
Mikhail Korotov
56cdc03b0b
Update StorageOfAllowedURL.cpp 2019-10-10 01:23:12 +03:00
Mikhail Korotov
769ec9ea6c
Update config.xml 2019-10-10 01:22:05 +03:00
alesapin
777ba2e47e Remove some code 2019-10-10 00:31:29 +03:00
millb
a97739f67f Created class StorageOfAllowedURL
Created test for table function remote and remoteSecure
Created check allowed url in remote and remoteSecure
Fixed tests
2019-10-09 23:29:41 +03:00
Alexey Milovidov
3fbac60328 Added a test 2019-10-09 23:16:17 +03:00
Alexey Milovidov
e65b57369e transformQueryForExternalDatabase: fixed constant folding for Date and DateTime 2019-10-09 23:13:34 +03:00
alesapin
fae3f85a0f Refactor parser create query 2019-10-09 23:09:10 +03:00
Alexey Milovidov
b302fec362 Fixed bad code in transformQueryForExternalDatabase 2019-10-09 22:58:50 +03:00
alexey-milovidov
689411abe0
Merge pull request #7222 from azat/uniqCombined64
[RFC] Introduce uniqCombined64() to get sane results for cardinality > UINT_MAX
2019-10-09 20:29:56 +03:00
alexey-milovidov
6cd3e9a458
Update AggregateFunctionUniqCombined.h 2019-10-09 20:26:01 +03:00
alexey-milovidov
81a9c81ba7
Merge pull request #7236 from azat/uniqCombined-memory-usage
Do not use more then 98K of memory for uniqCombined*
2019-10-09 20:19:30 +03:00
alexey-milovidov
e3861e0e88
Merge pull request #7242 from azat/sparse_hashed-name
Return SparseHashed name (system.dictionaries:type) for the sparse_hashed layout
2019-10-09 20:12:24 +03:00
Nikolai Kochetov
dea89cfc11 Disable processors by default. 2019-10-09 19:42:13 +03:00
alexey-milovidov
01e08a23c2
Merge pull request #7240 from ClickHouse/function-get-macro
Added function `getMacro`
2019-10-09 15:28:54 +03:00
Alexander Kuzmenkov
1965c612ab Fix sorting in clickhouse-test. 2019-10-09 14:56:51 +03:00
millb
fec1c6deba Fixed Error message and error code 2019-10-09 14:16:14 +03:00
Nikolai Kochetov
9c5ae5f536 Merge branch 'master' into processors-and-storages 2019-10-09 14:12:47 +03:00
Alexander Kuzmenkov
89ebd4885f Fix test filtering in clickhouse-test. 2019-10-09 13:51:59 +03:00
alesapin
ef0b2f5936
Merge pull request #7209 from ClickHouse/dictionaries_ddl_parser
Dictionaries ddl parser
2019-10-09 12:51:08 +03:00
Nikolai Kochetov
eb2677c94e Try fix progressbar. 2019-10-09 12:44:24 +03:00
Nikolai Kochetov
ea27918de8 Try fix progressbar. 2019-10-09 12:40:30 +03:00
Nikolai Kochetov
c7bb83262e Fix progress callback for processors pipeline. 2019-10-09 12:33:16 +03:00
Azat Khuzhin
0ff823b574 Return SparseHashed name (system.dictionaries:type) for the sparse_hashed layout
Due to tons of rebasing this bit had been forgotten.

Refs: 420089c301 ("Add new dictionary layout (sparse_hashed) that is more memory efficient")
2019-10-09 11:11:41 +03:00
alexey-milovidov
9b2e025918
Merge pull request #7234 from ClickHouse/aku/null-field-serialization
Serialize Null Fields correctly in DataTypeNullable.
2019-10-09 04:30:37 +03:00
Alexey Milovidov
6d2a79e832 Added a test 2019-10-09 04:18:12 +03:00
Alexey Milovidov
552e4b4be2 Added example config with macros for tests 2019-10-09 04:16:34 +03:00
Alexey Milovidov
a19f6513ce Added example config with macros 2019-10-09 04:15:23 +03:00
Alexey Milovidov
9f8d562543 Add function "getMacro" #7239 2019-10-09 04:14:57 +03:00
Azat Khuzhin
e373862c83 Do not use more then 98K of memory for uniqCombined*
uniqCombined() uses hashtable for medium cardinality, and since
HashTable resize by the power of 2 (well actually HashTableGrower grows
double by the power of 2, hence HashTableGrower::increaseSize() should
be overwritten to change this), with 1<<13 (default for uniqCombined)
and UInt64 HashValueType, the HashTable will takes:

  getBufferSizeInBytes() == 131072

While it should be not greater then sizeof(HLL) ~= 98K, so reduce the
maximum cardinality for hashtable to 1<<12 with UInt64 HashValueType and
to 1<13 with UInt32, overwrite HashTableGrower::increaseSize() and cover
this using max_memory_usage.

Refs: https://github.com/ClickHouse/ClickHouse/pull/7221#issuecomment-539672742

v2: cover uniqCombined() with non-default K
2019-10-09 02:39:23 +03:00
alexey-milovidov
4c1f0177b6
Merge pull request #7109 from infinivision/aggBitmapAnd
added groupBitmapAnd, groupBitmapOr, groupBitmapXor
2019-10-08 22:51:46 +03:00
alexey-milovidov
5c2d478543
Merge pull request #7212 from ClickHouse/aku/field-includes
Include Field.h and FieldVisitor.h into fewer files.
2019-10-08 22:40:30 +03:00
alesapin
5296be18f3 Fix desc table query 2019-10-08 22:39:20 +03:00
alexey-milovidov
b9aa5d812d
Merge pull request #7171 from nikvas0/nikvas0/lazy_db
Lazy Database
2019-10-08 22:15:55 +03:00
Azat Khuzhin
f46c5a47c0 Introduce uniqCombined64() to get sane results for cardinality > UINT_MAX
By default uniqCombined() uses 32-bit hash for all types except String,
so this means that you cannot use uniqCombined() with i.e UInt64 and
cardinality > UINT_MAX, although you can use uniqCombined(toString())
and this will lead to 64-bit hash, but will not have good performance.

So uniqCombined64() had been introduced to fix this.

Requires: #7213
2019-10-08 21:59:35 +03:00
alexey-milovidov
ddc2299901
Update 01016_null_part_minmax.sql 2019-10-08 21:52:48 +03:00
alexey-milovidov
d8b3db65f7
Merge pull request #7213 from azat/fix-uniqCombined-approximation
Fix uniqCombined() result for >UINT_MAX values (return UInt64 to avoid overflow)
2019-10-08 21:45:23 +03:00
alexey-milovidov
e619304b2c
Merge pull request #7216 from ClickHouse/nicelulu-issue-6615
Merging "Optimize empty IN subquery and empty INNER/RIGHT JOIN"
2019-10-08 21:36:57 +03:00
Alexander Kuzmenkov
a5b1496fe9 Serialize Null Fields correctly in DataTypeNullable. 2019-10-08 21:21:24 +03:00
alesapin
5ea1a12c05 Refactoring and comments 2019-10-08 16:26:15 +03:00
Alexander Kuzmenkov
2b30f2696c Include Field.h in less files. 2019-10-08 16:23:24 +03:00
alesapin
7b545f9b18 Fix style 2019-10-08 15:35:17 +03:00
alesapin
cd05564b17 Add show create dictionary 2019-10-08 15:34:04 +03:00
Alexander Kuzmenkov
46f5115601 Accept many test name regexes in clickhouse-test.
Sometimes it is more convenient to supply space-separated test names
without having to concatenate them into one regex with pipes.
2019-10-08 14:32:03 +03:00
alesapin
0883b3f8a9 Parser for drop dictionary query 2019-10-08 14:10:29 +03:00
alesapin
db20681207 Better declaration and lifetime parser 2019-10-08 13:50:57 +03:00
alesapin
5f81f47637 Add recursive parsing of pairs 2019-10-08 12:47:17 +03:00
Vasilyev Nikita
21b2b20729 Merge branch 'nikvas0/lazy_db' of https://github.com/nikvas0/ClickHouse into nikvas0/lazy_db 2019-10-08 11:15:12 +03:00
Vasilyev Nikita
030aa1cf10 fix 2019-10-08 11:10:55 +03:00
alexey-milovidov
3bd59edc3c
Update StorageSystemTables.cpp 2019-10-08 03:31:50 +03:00
alexey-milovidov
c92fc70f66
Update StorageSystemTables.cpp 2019-10-08 03:29:41 +03:00
alexey-milovidov
704529801e
Update StorageSystemColumns.cpp 2019-10-08 03:27:57 +03:00
alexey-milovidov
20f5b27b8b
Update DatabaseOnDisk.h 2019-10-08 03:24:26 +03:00
Alexey Milovidov
15bba8b498 Updated test 2019-10-07 22:16:45 +03:00
alexey-milovidov
bcc4e3f0ba
Merge branch 'master' into issue-6615 2019-10-07 22:12:25 +03:00
Alexander Tokmakov
1c5ee018df update docs 2019-10-07 21:55:12 +03:00
Azat Khuzhin
92c88248a1 Fix uniqCombined() result for >UINT_MAX values (return UInt64 to avoid overflow)
uniqCombined() return type is UInt64, but uniqCombined() uses
CombinedCardinalityEstimator, and CombinedCardinalityEstimator::size()
return type is UInt32, while the underlying HyperLogLog::size() is
UInt64.

So after this patch uniqCombined() can be used for >UINT_MAX values, the
outcome is not ideal (#2073) but at least sane.
2019-10-07 21:38:58 +03:00
Alexander Kuzmenkov
56b065881a Include FieldVisitors.h in less files. 2019-10-07 20:23:05 +03:00
Alexander Kuzmenkov
367c537106 Do not include Field.h everywhere through SettingsCommon.h.
Move the methods of SettingsCollection<> that are dependent on Field to
a separate file, and include it once for each instantiation. This allows
to work on Field without always recompiling the entire project.
2019-10-07 20:23:05 +03:00
Alexander Tokmakov
73aa1d1518 diagnostic info for bad csv delimiters 2019-10-07 19:47:25 +03:00
alesapin
0e664807e9 Additional test 2019-10-07 19:46:35 +03:00
Alexander Tokmakov
a2c83ac82e add tests 2019-10-07 19:31:30 +03:00
alesapin
cec3af45e5 First working version of parser 2019-10-07 19:23:16 +03:00
Alexander Tokmakov
32b0b8272c setup csv delimiter in Template format 2019-10-07 19:03:01 +03:00
Alexander Tokmakov
b4d9dc2a90 query parameters in evaluateConstantExpression 2019-10-07 18:46:50 +03:00
alesapin
369a7d262c Merge branch 'master' into dictionaries_ddl_parser 2019-10-07 12:46:08 +03:00
millb
c5ba58f243 Fixed tests 2019-10-06 18:49:51 +03:00
millb
7ab1804ebb Fixed codestyle and changed Error message. 2019-10-06 18:33:25 +03:00
millb
31a422fdff Fixed test codestyle 2019-10-06 18:01:05 +03:00
millb
5c272df15f Add integration tests. 2019-10-06 17:52:41 +03:00
alexey-milovidov
d096119529
Merge pull request #7156 from ClickHouse/fix-header-for-now
Fix header for function 'now'
2019-10-05 22:35:23 +03:00
alexey-milovidov
ce12fb6b3c
Update ExpressionAnalyzer.cpp 2019-10-05 22:34:57 +03:00
alexey-milovidov
40b22061f0
Update InterpreterSelectQuery.cpp 2019-10-05 22:34:25 +03:00
proller
594c535bd4 Build fixes (#7063)
* Build fixes

*            fix

* Fix

* fix

* Fix install(export..

* Freebsd fixes

* Freebsd fixes

* Fix warning

* fix

* More PRIVATE linking

* Fix review

* Timmy

* fix

* fix
2019-10-05 22:25:31 +03:00
alexey-milovidov
acbadfefbf
Merge pull request #7200 from azat-archive/unbundled-build-fix
Add missing linking with PocoXML for clickhouse_common_io
2019-10-05 21:54:24 +03:00
alexey-milovidov
bb8414bdeb
Merge pull request #7201 from vzakaznikov/enabling_again_live_view_tests
A quick fix to resolve crash in LIVE VIEW table and re-enabling all LIVE VIEW tests.
2019-10-05 20:47:34 +03:00
Vitaliy Zakaznikov
6b8e61737a * Fixing crash in LIVE VIEW
* Re-enabling all LIVE VIEW tests
2019-10-05 08:05:24 -04:00
Vasilyev Nikita
5fb84b55a6 fix nl 2019-10-05 13:21:47 +03:00
Vasilyev Nikita
b8647f49b5 fix 2019-10-05 13:21:04 +03:00
Alexander Tokmakov
a90d126b93 support defaults_for_omitted_fields in TSV 2019-10-04 22:44:48 +03:00
Alexander Tokmakov
d936cee836 support null_as_default in most text formats 2019-10-04 22:42:35 +03:00
Nikolai Kochetov
95ec0f7c2d Merged with master. 2019-10-04 20:53:21 +03:00
Nikolai Kochetov
d4f11af817 Update QueryPipeline. 2019-10-04 20:49:14 +03:00
Nikolai Kochetov
23069ca6d0 Progress for MergeTreeSelectProcessor. 2019-10-04 20:50:07 +03:00
Nikolai Kochetov
627d48c19a Added ExecutionSpeedLimits. 2019-10-04 20:49:57 +03:00
Nikolai Kochetov
e48f7faebc Fix MergeTreeRangeReader.
Fix MergeTreeReader.

Fix MergeTreeBaseSelectProcessor.

Better exception message for TreeExecutor.

Added header_without_virtual_columns to MergeTreeBaseSelectProcessor.

Fix MergeTreeReverseSelectProcessor.

Fix MergeTreeDataSelectExecutor.
2019-10-04 20:49:29 +03:00
Nikolai Kochetov
54d32da5a1 Update TreeExecutor. 2019-10-04 20:49:24 +03:00
Nikolai Kochetov
1689576770 Update MergeTreeDataSelectExecutor. 2019-10-04 20:49:14 +03:00
Alexander Tokmakov
ec79e5aa5b refactor null_as_default 2019-10-04 20:19:49 +03:00
Azat Khuzhin
4b9d711f07 Add missing linking with PocoXML for clickhouse_common_io
Otherwise unbundled build fail with:
  FAILED: dbms/libclickhouse_common_iod.so
  ...
  ../dbms/src/IO/WriteBufferFromS3.cpp:143: error: undefined reference to 'Poco::XML::InputSource::InputSource(std::istream&)'
  ../dbms/src/IO/WriteBufferFromS3.cpp:144: error: undefined reference to 'Poco::XML::DOMParser::DOMParser(Poco::XML::NamePool*)'
  ../dbms/src/IO/WriteBufferFromS3.cpp:145: error: undefined reference to 'Poco::XML::DOMParser::parse(Poco::XML::InputSource*)'
  ../dbms/src/IO/WriteBufferFromS3.cpp:146: error: undefined reference to 'Poco::XML::Document::getElementsByTagName(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) const'
  ../dbms/src/IO/WriteBufferFromS3.cpp:144: error: undefined reference to 'Poco::XML::DOMParser::~DOMParser()'
  ../dbms/src/IO/WriteBufferFromS3.cpp:143: error: undefined reference to 'Poco::XML::InputSource::~InputSource()'
  ../dbms/src/IO/WriteBufferFromS3.cpp:144: error: undefined reference to 'Poco::XML::DOMParser::~DOMParser()'
  ../dbms/src/IO/WriteBufferFromS3.cpp:143: error: undefined reference to 'Poco::XML::InputSource::~InputSource()'
  collect2: error: ld returned 1 exit status
2019-10-04 19:48:10 +03:00
alexey-milovidov
9c2f3ba41a
Merge pull request #6984 from achimbab/pr_bf
Made bloom_filter type of index supporting arrays
2019-10-04 18:08:42 +03:00
tavplubix
d73db7f779
Merge pull request #6781 from ClickHouse/merging_values_with_expressions
Merging Values with expressions
2019-10-04 12:51:22 +03:00
Nikolai Kochetov
90472293fd Added test with function randConstant. 2019-10-04 12:22:07 +03:00
alexey-milovidov
fadd003f5b
Merge pull request #7185 from ClickHouse/fix_bug_with_alter_attach_part
Fix bug with segmentation fault in ATTACH PART query
2019-10-04 01:18:42 +03:00
alesapin
4e83f65089 Fix bug with segmentation fault in ATTACH PART query 2019-10-03 21:07:47 +03:00
alesapin
cf094cd62b
Merge pull request #7155 from ClickHouse/dictionaries_ddl
Preparation of ExternalLoader for Dictionaries DDL
2019-10-03 20:12:19 +03:00
Nikolai Kochetov
76d1412953 Fix actions for distributed. 2019-10-03 18:47:42 +03:00
Vasilyev Nikita
d6490892a7 fix metadata time 2019-10-03 17:18:17 +03:00
Vasilyev Nikita
66506e26d0 fix 2019-10-03 16:40:53 +03:00
Vasilyev Nikita
6b1a1b5b5f fix 2019-10-03 15:49:22 +03:00
Nikolai Kochetov
e5c1df010f Remove allow_different_constant_values from InterpreterSelectQuery. 2019-10-03 15:02:30 +03:00
Nikolai Kochetov
a706cc47cf Remove setting allow_different_constant_values from ConvertingTransform and ConvertingBlockInputStream. 2019-10-03 14:59:45 +03:00
Nikolai Kochetov
3142955e6c InterpreterSelectQuery: reuse actions from getSampleBlock in readImpl. 2019-10-03 14:58:52 +03:00
Vasilyev Nikita
f0f5134759 fixed includes 2019-10-03 12:31:59 +03:00
Vasilyev Nikita
c27ce44d19 set -> list 2019-10-03 12:20:21 +03:00
Vasilyev Nikita
2f4e7bbe7f get rid of copy-paste 2019-10-03 11:35:58 +03:00
Vasilyev Nikita
7ac9fadc0d reduce copy-paste 2019-10-03 11:27:43 +03:00