Commit Graph

168 Commits

Author SHA1 Message Date
Vitaly Baranov
5cd7b58499 Fix reusing connection after changing user's default settings via ALTER USER or ALTER SETTINGS PROFILE.
This fixes integration test "test_settings_constraints_distributed".
2020-03-31 18:08:01 +03:00
alexey-milovidov
9a2760d914
Merge pull request #9673 from azat/processors-max_distributed_connections
Fix max_distributed_connections
2020-03-24 08:32:15 +03:00
Vitaly Baranov
4af36ee5a4 Fix updating of the access rights after changing of the readonly setting. Remove non-const function Context::getSettingsRef(). 2020-03-22 11:08:08 +03:00
Alexey Milovidov
a5e3d4efb7 Added most of clang-static-analyzer checks 2020-03-20 21:53:35 +03:00
Azat Khuzhin
b40eac426f Fix max_distributed_connections w/ Processors
With Processors max_distributed_connections does not used anymore, since
it always uses not more then max_threads (see
TCPHandler::processOrdinaryQueryWithProcessors()/
QueryPipeline::execute()/PipelineExecutor::execute())

So just use QueryPipeline::getNumThreads(), that takes
max_distributed_connections into account.
2020-03-20 20:51:37 +03:00
Nikolai Kochetov
5d763dead0 Change the way how rows_before_limit_at_least is calculated for processors pipeline. 2020-03-19 14:45:52 +03:00
Alexander Tokmakov
cf28bfe8a7 Merge branch 'master' into split_databases_from_context 2020-03-12 15:09:41 +03:00
Alexander Tokmakov
8b3a245a1d improve temporary tables 2020-03-10 22:36:17 +03:00
Alexander Tokmakov
c7468d2502 Merge branch 'master' into split_databases_from_context 2020-03-10 13:15:27 +03:00
Alexey Milovidov
b53ec30978 clang-tidy, part 3 2020-03-09 00:29:00 +03:00
Alexander Tokmakov
2d5ed7832b remove tryGetTable 2020-03-04 23:29:52 +03:00
Alexander Tokmakov
67c63a72c7 Merge branch 'master' into split_databases_from_context 2020-03-04 19:24:05 +03:00
alexey-milovidov
3ae13f646a
Merge pull request #9495 from azat/progress-on-tcp
Fix progress over tcp
2020-03-04 19:19:54 +03:00
Alexey Milovidov
7ca1dff219 Merge branch 'master' of github.com:yandex/ClickHouse 2020-03-04 18:16:48 +03:00
Alexey Milovidov
06c8e04998 Fixed comment #4215 2020-03-04 18:16:32 +03:00
Azat Khuzhin
8adcbc7952 Send progress after final update (like logs)
Otherwise you will get non completed progress on TCP, HTTP does not
affected.

Final updateProgress called from the executeQueryImpl::finish_callback:
  (gdb) bt
  0  DB::TCPHandler::updateProgress (this=0x7fffb581e000, value=...) at TCPHandler.cpp:1178
  1  0x00007ffff7c62038 in DB::TCPHandler::<lambda(const DB::Progress&)>::operator()(const DB::Progress &) const (...) at TCPHandler.cpp:127
  4  0x00007fffe9a86671 in DB::<lambda(DB::IBlockInputStream*, DB::IBlockOutputStream*)>::operator()(DB::IBlockInputStream *, DB::IBlockOutputStream *) (__closure=0x7fffb588f300,
     stream_in=0x7fffb5800290, stream_out=0x0) at executeQuery.cpp:450
  5  0x00007fffe9a8b948 in std::_Function_handler<void(DB::IBlockInputStream*, DB::IBlockOutputStream*), DB::executeQueryImpl(...)::<lambda(DB::IBlockInputStream*, DB::IBlockOutputStream*)> >::_M_invoke(const std::_Any_data &, DB::IBlockInputStream *&&, DB::IBlockOutputStream *&&) (...) at std_function.h:300
  6  0x00007ffff7c7482f in std::function<>::operator()(DB::IBlockInputStream*, DB::IBlockOutputStream*) const (..) at std_function.h:688
  7  0x00007ffff7c6f82b in DB::BlockIO::onFinish (this=0x7fffb5820738) at BlockIO.h:43
  8  0x00007ffff7c65eb0 in DB::TCPHandler::processOrdinaryQuery (this=0x7fffb581e000) at TCPHandler.cpp:540
  9  0x00007ffff7c63a50 in DB::TCPHandler::runImpl (this=0x7fffb581e000) at TCPHandler.cpp:269
  10 0x00007ffff7c6a6fd in DB::TCPHandler::run (this=0x7fffb581e000) at TCPHandler.cpp:1226
  ...
2020-03-04 11:31:47 +03:00
Nikolai Kochetov
72fe21c5ae Better calculation for recommended number of threads to execute query pipeline. 2020-03-03 13:28:37 +03:00
Alexander Tokmakov
70dc82f9aa add StorageID to ASTInsertQuery 2020-03-02 23:23:58 +03:00
Alexander Tokmakov
a4d12b31a1 Merge branch 'master' into split_databases_from_context 2020-03-02 17:57:54 +03:00
Vitaly Baranov
fc0376a170 Shard now clamps the settings got from the initiator to the shard's constaints instead of throwing an exception. 2020-03-01 02:18:49 +03:00
Alexey Milovidov
766ae8261a Added some missing ErrorCodes 2020-02-25 21:02:41 +03:00
Alexey Milovidov
3602126a1e Remove unused ErrorCodes 2020-02-25 17:35:37 +03:00
Alexander Tokmakov
8548089e00 Merge branch 'master' into split_databases_from_context 2020-02-25 15:47:19 +03:00
Vitaly Baranov
5849dd2236 Slightly better solution for checking row policy for distributed tables,
now it checks both current user's and initial user's filters.
2020-02-21 00:57:42 +03:00
Alexander Tokmakov
d710bd1812 better get... methods 2020-02-17 16:52:59 +03:00
Alexander Tokmakov
c479bbe9f9 make Context::getLock() private 2020-02-14 00:00:03 +03:00
Alexander Tokmakov
b6039f8c50 remove tryGetExternalTable 2020-02-12 21:14:12 +03:00
Alexander Tokmakov
869e20d207 move databases from Context to DatabaseCatalog 2020-02-10 17:49:44 +03:00
Ivan
1b55150701
Add row-level filter support to Distributed engine (#8926)
* Add tests
* Implement support for initial user on remote side.
2020-02-07 22:31:09 +03:00
Nikolai Kochetov
f431b10e38 Update TCPHandler. 2020-01-23 13:04:18 +03:00
Nikolai Kochetov
c28e224e24
Merge pull request #8735 from ClickHouse/processors-5.12
Processors 5.12
2020-01-21 11:51:07 +03:00
Nikolai Kochetov
7803e518c6 Remove query pipeline later. 2020-01-16 19:20:22 +03:00
Alexander Tokmakov
9b75ee2378 Merge branch 'master' into table_name_in_istorage 2020-01-09 17:33:58 +03:00
Nikolai Kochetov
833499cfb6 Merged with master. 2020-01-03 15:34:17 +03:00
Alexey Milovidov
67afaa9d93 Stack trace for every exception (experimental) 2020-01-02 09:56:53 +03:00
Nikolai Kochetov
65a00150b2 Update num threads in processors. 2020-01-01 13:42:46 +03:00
Alexander Tokmakov
2e5d61cd81 better constructors of storages 2019-12-26 20:04:08 +03:00
Alexey Milovidov
41ed1ed471 Added quoting of db and table names where appropriate 2019-12-20 19:53:37 +03:00
Alexey Milovidov
4cf540b621 Applied a patch from Nicolae Vartolomei 2019-12-16 22:03:03 +03:00
Alexander Kazakov
954d5072e9 Returned the terminating sendProgress() in processOrdinaryQuery 2019-12-12 07:46:39 +03:00
Alexander Kazakov
eb5040771b Minor correction 2019-12-11 17:54:19 +03:00
Alexander Kazakov
292e3a0d24 Reworked TCPHandler::processOrdinaryQuery() to resolve race condition 2019-12-11 16:30:27 +03:00
alexey-milovidov
9106b2854a
Merge pull request #8084 from azat/read-temporary-tables-on-failure
Read temporary tables on failure to avoid interpreting that bits as query
2019-12-09 13:49:09 +03:00
Azat Khuzhin
7b4fcc5fc5 Read temporary tables on failure to avoid interpreting that bits as query
Before this patch if the query failes (due to "Too many simultaneous
queries" for example) it will not read external tables info, and the
next request will interpret them as the query beginning at got:

  DB::Exception: Unknown packet 11861 from client

v2: reordering in the executeQuery() is not enough, since the query
    can fail in other places, before, i.e. quotas
v3: I cannot make non-intergration test (since there is no ability to
    receive "Unknown packet" via client, only from the server log),
    hence added one
2019-12-08 23:26:43 +03:00
Vitaly Baranov
0e21673271 Rework Quota based on IAccessEntity. 2019-12-05 21:03:57 +03:00
Vitaly Baranov
f3d72b9ec1 Skip unknown settings with warnings. 2019-11-17 03:51:58 +03:00
Nikolai Kochetov
3bde663681 Wailt for AsynchronousBlockInputStream inner thread before getting totals to avoid possible race. 2019-11-06 15:34:51 +03:00
Amos Bird
8f902dc2a9
Better null format for tcp handler. 2019-11-04 11:53:26 +08:00
Amos Bird
295864e6e0
better scalar query 2019-10-23 21:37:54 +08:00
tavplubix
0046b9f137 Wait for jobs to finish on exception (fixes rare segfaults) (#7350) 2019-10-17 17:41:27 +03:00