Commit Graph

71640 Commits

Author SHA1 Message Date
Azat Khuzhin
19458a0c61 Fix removing of parts in a Temporary state
Parts in a temporary state is not exists in data_parts_by_info, so do
not try to search there and throw LOGICAL_ERROR in case of failure:

<details>

```
    02:45:49.037546 [ 5890 ] {} <Error> test_iy9rta.concurrent_kill_4 (526aa7c8-db2a-4f0e-926a-a7c8db2a9f0e): Code: 40. DB::Exception: Part all_0_0_0_1 from r11 has different columns hash. (CHECKSUM_DOESNT_MATCH) (version 21.10.1.7910 (official build)). Data after mutation is not byte-identical to data on another replicas. We will download merged part from replica to force byte-identical result.
    02:45:49.049422 [ 5890 ] {} <Trace> test_iy9rta.concurrent_kill_4 (526aa7c8-db2a-4f0e-926a-a7c8db2a9f0e): Trying to immediately remove part all_0_0_0_1 (state Temporary)
    02:45:49.060210 [ 5890 ] {} <Fatal> : Logical error: 'Part all_0_0_0_1 doesn't exist'.
    02:47:01.572508 [ 29208 ] {} <Fatal> BaseDaemon: (version 21.10.1.7910 (official build), build id: 9309CECED9A0D32CBB00BB8EC77B91456679868E) (from thread 5890) (no query) Received signal Aborted (6)
    ...
    02:47:06.815000 [ 29208 ] {} <Fatal> BaseDaemon: 8. ./obj-x86_64-linux-gnu/../src/Storages/MergeTree/MergeTreeData.cpp:2593: DB::MergeTreeData::tryRemovePartImmediately(std::__1::shared_ptr<DB::IMergeTreeDataPart const>&&) @ 0x1f959e0d in /usr/bin/clickhouse
    02:47:06.816309 [ 29209 ] {} <Fatal> BaseDaemon: 8. ./obj-x86_64-linux-gnu/../src/Storages/MergeTree/MergeTreeData.cpp:2593: DB::MergeTreeData::tryRemovePartImmediately(std::__1::shared_ptr<DB::IMergeTreeDataPart const>&&) @ 0x1f959e0d in /usr/bin/clickhouse
    02:47:09.455665 [ 29208 ] {} <Fatal> BaseDaemon: 9. ./obj-x86_64-linux-gnu/../src/Storages/StorageReplicatedMergeTree.cpp:1939: DB::StorageReplicatedMergeTree::tryExecutePartMutation(DB::ReplicatedMergeTreeLogEntry const&) @ 0x1f5f2bf6 in /usr/bin/clickhouse
    02:47:09.468738 [ 29209 ] {} <Fatal> BaseDaemon: 9. ./obj-x86_64-linux-gnu/../src/Storages/StorageReplicatedMergeTree.cpp:1939: DB::StorageReplicatedMergeTree::tryExecutePartMutation(DB::ReplicatedMergeTreeLogEntry const&) @ 0x1f5f2bf6 in /usr/bin/clickhouse
    02:47:11.776857 [ 29208 ] {} <Fatal> BaseDaemon: 10. ./obj-x86_64-linux-gnu/../src/Storages/StorageReplicatedMergeTree.cpp:1581: DB::StorageReplicatedMergeTree::executeLogEntry(DB::ReplicatedMergeTreeLogEntry&) @ 0x1f5e484c in /usr/bin/clickhouse
    02:47:11.904232 [ 29209 ] {} <Fatal> BaseDaemon: 10. ./obj-x86_64-linux-gnu/../src/Storages/StorageReplicatedMergeTree.cpp:1581: DB::StorageReplicatedMergeTree::executeLogEntry(DB::ReplicatedMergeTreeLogEntry&) @ 0x1f5e484c in /usr/bin/clickhouse
    02:47:13.941811 [ 29208 ] {} <Fatal> BaseDaemon: 11. ./obj-x86_64-linux-gnu/../src/Storages/StorageReplicatedMergeTree.cpp:3176: DB::StorageReplicatedMergeTree::processQueueEntry(std::__1::shared_ptr<DB::ReplicatedMergeTreeQueue::SelectedEntry>)::$_18::operator() shared_ptr<DB::ReplicatedMergeTreeLogEntry>&) const @ 0x1f65faa5 in /usr/bin/clickhouse
    02:47:14.477158 [ 29209 ] {} <Fatal> BaseDaemon: 11. ./obj-x86_64-linux-gnu/../src/Storages/StorageReplicatedMergeTree.cpp:3176: DB::StorageReplicatedMergeTree::processQueueEntry(std::__1::shared_ptr<DB::ReplicatedMergeTreeQueue::SelectedEntry>)::$_18::operator() shared_ptr<DB::ReplicatedMergeTreeLogEntry>&) const @ 0x1f65faa5 in /usr/bin/clickhouse
    02:47:16.475373 [ 29208 ] {} <Fatal> BaseDaemon: 12. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/type_traits:3676: decltype(std::__1::forward<DB::StorageReplicatedMergeTree::processQueueEntry(std::__1::shared_ptr<DB::ReplicatedMergeTreeQueue::SelectedEntry>))(std::__1::forward<std::__1::shared_ptr<DB::ReplicatedMergeTreeLogEntry>&>(fp0))) std::__1::__invoke<DB::StorageReplicatedMergeTree::processQueueEntry(std::__1::shared_ptr<DB::ReplicatedMergeTreeQueue::SelectedEntry>)::$_18&, std::__1::shared_ptr<DB::ReplicatedMEntry>&>(DB::StorageReplicatedMergeTree::processQueueEntry(std::__1::shared_ptr<DB::ReplicatedMergeTreeQueue::SelectedEntry>)::$_18&, std::__1::shared_ptr<DB::ReplicatedMergeTreeLogEntry>&) @ 0x1f65fa32 in /usr/bin/clickhouse
    02:47:16.970325 [ 29209 ] {} <Fatal> BaseDaemon: 12. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/type_traits:3676: decltype(std::__1::forward<DB::StorageReplicatedMergeTree::processQueueEntry(std::__1::shared_ptr<DB::ReplicatedMergeTreeQueue::SelectedEntry>))(std::__1::forward<std::__1::shared_ptr<DB::ReplicatedMergeTreeLogEntry>&>(fp0))) std::__1::__invoke<DB::StorageReplicatedMergeTree::processQueueEntry(std::__1::shared_ptr<DB::ReplicatedMergeTreeQueue::SelectedEntry>)::$_18&, std::__1::shared_ptr<DB::ReplicatedMEntry>&>(DB::StorageReplicatedMergeTree::processQueueEntry(std::__1::shared_ptr<DB::ReplicatedMergeTreeQueue::SelectedEntry>)::$_18&, std::__1::shared_ptr<DB::ReplicatedMergeTreeLogEntry>&) @ 0x1f65fa32 in /usr/bin/clickhouse
    02:47:18.979481 [ 29208 ] {} <Fatal> BaseDaemon: 13. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/__functional_base:317: bool std::__1::__invoke_void_return_wrapper<bool>::__call<DB::StorageReplicatedMergeTree::processQueueEntry(std::__1::shared_ptr<DB::ReplireeQueue::SelectedEntry>)::$_18&, std::__1::shared_ptr<DB::ReplicatedMergeTreeLogEntry>&>(DB::StorageReplicatedMergeTree::processQueueEntry(std::__1::shared_ptr<DB::ReplicatedMergeTreeQueue::SelectedEntry>)::$_18&, std::__1::shared_ptr<DB::ReplicatedMergeTreeLogE x1f65f9f2 in /usr/bin/clickhouse
    02:47:19.450807 [ 29209 ] {} <Fatal> BaseDaemon: 13. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/__functional_base:317: bool std::__1::__invoke_void_return_wrapper<bool>::__call<DB::StorageReplicatedMergeTree::processQueueEntry(std::__1::shared_ptr<DB::ReplireeQueue::SelectedEntry>)::$_18&, std::__1::shared_ptr<DB::ReplicatedMergeTreeLogEntry>&>(DB::StorageReplicatedMergeTree::processQueueEntry(std::__1::shared_ptr<DB::ReplicatedMergeTreeQueue::SelectedEntry>)::$_18&, std::__1::shared_ptr<DB::ReplicatedMergeTreeLogE x1f65f9f2 in /usr/bin/clickhouse
    02:47:21.055007 [ 29208 ] {} <Fatal> BaseDaemon: 14. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/functional:1608: std::__1::__function::__default_alloc_func<DB::StorageReplicatedMergeTree::processQueueEntry(std::__1::shared_ptr<DB::ReplicatedMergeTreeQueue::ry>)::$_18, bool (std::__1::shared_ptr<DB::ReplicatedMergeTreeLogEntry>&)>::operator()(std::__1::shared_ptr<DB::ReplicatedMergeTreeLogEntry>&) @ 0x1f65f9b0 in /usr/bin/clickhouse
    02:47:23.546946 [ 413 ] {} <Fatal> Application: Child process was terminated by signal 6.
```

</details>

CI: https://clickhouse-test-reports.s3.yandex.net/0/4a8b82232c11512232df3ecdf4ffaec287116ad5/stress_test_(debug).html#fail1
2021-08-27 10:08:44 +03:00
Azat Khuzhin
44db6e2998 Mark 01158_zookeeper_log as long
According to one of flaky check (address) runs [1] it is possible for
this test to run out of 60 seconds.

  [1]: https://clickhouse-test-reports.s3.yandex.net/28212/a63ef6b8eb9d259b0dbb655ae2a9cba525db87e8/functional_stateless_tests_flaky_check_(address).html#fail1
2021-08-27 09:41:19 +03:00
Azat Khuzhin
124e252681 Avoid 01158_zookeeper_log depends on cleanup_delay_period
Like in [1].

  [1]: https://clickhouse-test-reports.s3.yandex.net/28212/a63ef6b8eb9d259b0dbb655ae2a9cba525db87e8/functional_stateless_tests_flaky_check_(address).html#fail1
2021-08-27 09:40:54 +03:00
zhongyuankai
ac0f606013 fix system views test 2021-08-27 14:14:07 +08:00
zhongyuankai
af3a1c30f7 fix system views test 2021-08-27 13:21:40 +08:00
zhongyuankai
3c19cd729f fix system views test 2021-08-27 12:27:33 +08:00
zhongyuankai
b57dff7157 update system views test 2021-08-27 11:32:17 +08:00
zhongyuankai
306da6f414 update system views test 2021-08-27 10:41:15 +08:00
zhongyuankai
5976869451 update system views test 2021-08-27 10:06:12 +08:00
Alexey Milovidov
b1478368cd Fix error 2021-08-27 04:45:14 +03:00
Alexey Milovidov
7df2532d60 Fix style 2021-08-27 04:29:37 +03:00
Alexey Milovidov
6f1789e9da Add missing file 2021-08-27 03:47:34 +03:00
Alexey Milovidov
864d01e564 Add pread_fake_async method 2021-08-27 03:35:04 +03:00
Alexey Milovidov
0316f1cc3e Even more instrumentation 2021-08-27 03:08:10 +03:00
Alexey Milovidov
f5ae8ef225 Instrumentation 2021-08-27 03:02:14 +03:00
Alexey Milovidov
91cef77edc Instrumentation 2021-08-27 03:01:07 +03:00
Alexey Milovidov
84a9be0b14 Move code to .cpp 2021-08-27 02:32:11 +03:00
Alexey Milovidov
46732e781f Merge branch 'master' of github.com:yandex/ClickHouse into async-reads 2021-08-27 01:57:48 +03:00
Alexey Milovidov
8fd643e22a Fix build 2021-08-27 01:57:34 +03:00
Maksim Kita
4a8b82232c
Merge pull request #28211 from azat/udf-lock
Guard UDF container with a lock
2021-08-27 01:33:21 +03:00
alexey-milovidov
3d38604c55
Update executeQuery.cpp 2021-08-27 00:59:58 +03:00
Azat Khuzhin
91621cfcd2 Fix reading of custom TLD w/o new line at EOF
Fixes: #28177
2021-08-27 00:43:21 +03:00
Azat Khuzhin
a63ef6b8eb Avoid excessive getpeername(2) calls for zookeeper_log 2021-08-27 00:41:06 +03:00
Azat Khuzhin
5bb0a91f83 Fix system.zookeeper_log.address (Before it always contains "::") 2021-08-27 00:41:06 +03:00
Azat Khuzhin
f342acc2ad Guard UDF container with a lock
Fixes TSAN report [1]:

    WARNING: ThreadSanitizer: data race (pid=436)
      Write of size 8 at 0x7b040076e450 by thread T240:
        ...
        3 DB::UserDefinedFunctionFactory::registerFunction() obj-x86_64-linux-gnu/../src/Interpreters/UserDefinedFunctionFactory.cpp:30:56 (clickhouse+0x1500727f)
        4 DB::InterpreterCreateFunctionQuery::execute() obj-x86_64-linux-gnu/../src/Interpreters/InterpreterCreateFunctionQuery.cpp:37:44 (clickhouse+0x14b1224a)
        5 DB::executeQueryImpl() obj-x86_64-linux-gnu/../src/Interpreters/executeQuery.cpp:573:32 (clickhouse+0x15039241)
        6 DB::executeQuery() obj-x86_64-linux-gnu/../src/Interpreters/executeQuery.cpp:934:30 (clickhouse+0x150376fa)
        7 DB::TCPHandler::runImpl() obj-x86_64-linux-gnu/../src/Server/TCPHandler.cpp:291:24 (clickhouse+0x15a7af2a)

      Previous read of size 8 at 0x7b040076e450 by thread T1370:
        ...
        2 DB::UserDefinedFunctionFactory::tryGet() const obj-x86_64-linux-gnu/../src/Interpreters/UserDefinedFunctionFactory.cpp:65:45 (clickhouse+0x150078a4)
        3 DB::UserDefinedFunctionsMatcher::tryToReplaceFunction() obj-x86_64-linux-gnu/../src/Interpreters/UserDefinedFunctionsVisitor.cpp:39:73 (clickhouse+0x15007cd0)
        4 DB::UserDefinedFunctionsMatcher::visit() obj-x86_64-linux-gnu/../src/Interpreters/UserDefinedFunctionsVisitor.cpp:27:19 (clickhouse+0x15007ba8)
        5 DB::InDepthNodeVisitor<>::visit() obj-x86_64-linux-gnu/../src/Interpreters/InDepthNodeVisitor.h:34:13 (clickhouse+0x14fbcba4)
        ..
        24 DB::executeQueryImpl() obj-x86_64-linux-gnu/../src/Interpreters/executeQuery.cpp:543:28 (clickhouse+0x15038f3b)

  [1]: https://clickhouse-test-reports.s3.yandex.net/0/df1fe27791f82c2a917390faa30716effbd32b8f/stress_test_(thread).html#fail1
2021-08-27 00:39:11 +03:00
Dmitriy
fc9d334d8d Translate to Russian
Перевел на русский язык.
2021-08-26 22:36:24 +03:00
Nikolai Kochetov
9c028be1e4 Fix insertion of fields with Infinity values in nullable low cardinality columns. 2021-08-26 21:19:12 +03:00
Dmitriy
7021d9bbe4
Update docs/en/sql-reference/dictionaries/external-dictionaries/external-dicts-dict-layout.md
Co-authored-by: Anna <42538400+adevyatova@users.noreply.github.com>
2021-08-26 19:47:21 +03:00
alesapin
1ff81b6678
Update network.py 2021-08-26 19:04:08 +03:00
alesapin
23325c3fa6 Fix rare case when watch response received before request response 2021-08-26 19:00:41 +03:00
alesapin
a6b4c28314
Update network.py 2021-08-26 18:27:14 +03:00
mergify[bot]
401b2f3b8f
Merge branch 'master' into json-as-string 2021-08-26 15:03:59 +00:00
Nikita Mikhaylov
e42b029155
Merge pull request #28191 from eltociear/patch-2
Fix typo in parametric-functions.md
2021-08-26 17:52:31 +03:00
Jakub Kuklis
c60e935830 Adding Format Null to performance test queries, style improvement for the test, additional comments in the code 2021-08-26 16:42:39 +02:00
Nikita Mikhaylov
fc37817ada
Merge pull request #28150 from FArthur-cmd/fix_compression_26149
Fix `Attempt to read after eof with enabled data compression`
2021-08-26 17:17:09 +03:00
Amos Bird
103e0abe1c
Reserve protocol number for ALTER PRIMARY KEY. 2021-08-26 22:08:58 +08:00
Nikolay Degterinsky
7c66ad051d Fix 2021-08-26 16:42:49 +03:00
Kruglov Pavel
5bc332c40c
Merge pull request #28054 from kssenii/mysql
Add test for #13398
2021-08-26 16:39:43 +03:00
Nikolay Degterinsky
75575505cf Merge branch 'master' into log_queries_probability 2021-08-26 16:32:49 +03:00
Kruglov Pavel
12b1e9ae6e
Merge pull request #27881 from azat/remote-query-cancel-fix
Fix remote query cancelation (in case of remote server abnormaly terminated)
2021-08-26 16:31:54 +03:00
Kruglov Pavel
3644f2a754
Merge pull request #28096 from CurtizJ/map-keys-conversion
Support implicit conversions between index in operator [] and key of Map
2021-08-26 16:31:12 +03:00
Kseniia Sumarokova
31afd7d09c
Merge pull request #28081 from kssenii/pg-conflict
Support `on conflict` for postgres engine
2021-08-26 16:30:30 +03:00
alexey-milovidov
25147d0c2d
Merge pull request #28186 from sdk2/patch-1
Update src/Functions/GatherUtils/Sources.h
2021-08-26 16:21:56 +03:00
Nikita Mikhaylov
349fa6c09f
Merge pull request #28157 from nikitamikhaylov/fix-arcadia-11
Updated ya.make files
2021-08-26 16:17:50 +03:00
zhongyuankai
15cbd7470a StorageSystemViews bug fix 2021-08-26 20:54:04 +08:00
Filatenkov Artur
eeeef3cc18
Update ZlibInflatingReadBuffer.cpp 2021-08-26 15:43:01 +03:00
Ikko Ashimine
abeb1d03f1
Fix typo in parametric-functions.md
occured -> occurred
2021-08-26 21:42:18 +09:00
Filatenkov Artur
a1240fd575
Update ZlibInflatingReadBuffer.cpp 2021-08-26 15:42:10 +03:00
zhongyuankai
042d17531c system.views add columns type 2021-08-26 20:05:01 +08:00
alesapin
ebfac8cfbb More correct list watches semantics in ClickHouse Keeper 2021-08-26 14:50:08 +03:00