One of such cases is 02479_race_condition_between_insert_and_droppin_mv
[1], yes it can be fixed (by using fixed number of iterations, or with
some bash trickery), but it is better to fix them completelly,
eventually such tests will be submitted and pass review anyway.
By allocating process group for each test we can kill all the processes
in this process group, and this what this patch does.
This will also fix some test hangs (like in [1]) as well as some
possible issues in stress tests.
[1]: https://s3.amazonaws.com/clickhouse-test-reports/0/e2c1230b00386c4d0096a245396ab3be7ce60950/stateless_tests__release__analyzer_/run.log
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Previously `CLICKHOUSE_BENCHMARK` was set simply as
`${CLICKHOUSE_BINARY}-benchmark` which is not applicable when testing a single
binary, e.g. downloaded via `curl https://clickhouse.com | sh`. This commit
adds support for `CLICKHOUSE_BENCHMARK_BINARY` (not exported from
`shell_config.sh`) that is set to `"$CLICKHOUSE_BINARY benchmark"` if
`CLICKHOUSE_BINARY` is set. This is the same behaviour that is already used for
`CLICKHOUSE_CLIENT_BINARY`.
Reverts: #54616
Resubmits: #54547
This reverts commit d23daca082, reversing
changes made to e111d4abd3.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Previosly only clickhouse-client binary was more or less detected, but
everything else does not, since "test -x clickhouse" does not work as
expected, "test -x" need a full path to the file, it does not search in
PATH.
Also improve clickhouse-test default --binary path, by properly search
in PATH.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
v2: add into skip_list
v3: print server log on error
v4: increase sleep time to trigger some issues under TSAN
v5: avoid ports overlaps
v6: avoid endless loops to print server log on failure
* [WIP]
* Update skip-list
* Update ci_config.json
* Do not sync inserts for test
* Fix more tests
* Fix another test
* Enable one more test
* More fixed tests
* More test fixes
* Do not absolutize server path for now
* More test fixes
* Unset CLICKHOUSE_LOG_COMMENT where necessary
* Remove debugging set -e
* Fix more tests
* Fix test reference
* Fix style check