Azat Khuzhin
4e76629aaf
Fixes for -Wshorten-64-to-32
...
- lots of static_cast
- add safe_cast
- types adjustments
- config
- IStorage::read/watch
- ...
- some TODO's (to convert types in future)
P.S. That was quite a journey...
v2: fixes after rebase
v3: fix conflicts after #42308 merged
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-10-21 13:25:19 +02:00
Robert Schulze
777b5bc15b
Don't let storages inherit from boost::noncopyable
...
... IStorage has deleted copy ctor / assignment already
2022-05-03 09:07:08 +02:00
Robert Schulze
330212e0f4
Remove inherited create() method + disallow copying
...
The original motivation for this commit was that shared_ptr_helper used
std::shared_ptr<>() which does two heap allocations instead of
make_shared<>() which does a single allocation. Turned out that
1. the affected code (--> Storages/) is not on a hot path (rendering the
performance argument moot ...)
2. yet copying Storage objects is potentially dangerous and was
previously allowed.
Hence, this change
- removes shared_ptr_helper and as a result all inherited create() methods,
- instead, Storage objects are now created using make_shared<>() by the
caller (for that to work, many constructors had to be made public), and
- all Storage classes were marked as noncopyable using boost::noncopyable.
In sum, we are (likely) not making things faster but the code becomes
cleaner and harder to misuse.
2022-05-02 08:46:52 +02:00
Anton Popov
0bc57da238
Merge remote-tracking branch 'upstream/master' into HEAD
2022-03-07 14:46:08 +00:00
kssenii
d19f199e93
Revert
2022-03-03 15:25:27 +01:00
kssenii
aa1c71a877
Merge master
2022-03-01 19:25:04 +01:00
Anton Popov
c1fdcf7a64
Merge remote-tracking branch 'upstream/master' into HEAD
2022-03-01 20:21:39 +03:00
Hongbin
99bd56e2de
Fix some code comments style
2022-02-28 08:15:37 +08:00
kssenii
2ba9010a34
Fix
2022-02-25 17:53:19 +01:00
kssenii
6c8401bfbd
Fix
2022-02-25 16:35:37 +01:00
Anton Popov
fcdebea925
Merge remote-tracking branch 'upstream/master' into HEAD
2022-02-25 13:41:30 +03:00
Alexander Tokmakov
5a26f856d9
remove trash that shouldn't have been merged
2022-02-22 23:41:33 +03:00
Anton Popov
99ebabd822
Merge remote-tracking branch 'upstream/master' into HEAD
2021-12-17 19:02:29 +03:00
kssenii
2ea4e7c4e7
Better
2021-11-29 15:05:02 +00:00
Anton Popov
a20922b2d3
Merge remote-tracking branch 'origin/sparse-serialization' into HEAD
2021-11-09 15:36:25 +03:00
feng lv
ab0d2504e5
fix
2021-10-18 15:44:54 +00:00
feng lv
6cf82f859c
fix
2021-10-18 07:27:37 +00:00
feng lv
074e02eb14
fix
2021-10-18 06:38:47 +00:00
feng lv
9378b93e41
fix
2021-10-17 14:49:27 +00:00
feng lv
045704274c
implement directory watcher
2021-10-10 16:31:32 +00:00
feng lv
bd1ea5cd16
try fix undefine in ifstream
2021-10-07 12:15:36 +00:00
feng lv
d9959a4f22
fix
2021-10-07 05:56:09 +00:00
feng lv
28f8e1c297
fix
...
update test
2021-10-07 05:33:12 +00:00
feng lv
c801fa65df
fix and add new test
...
fix
fix
2021-10-06 10:56:42 +00:00
feng lv
acdb8233c3
fix
...
fix
fix
2021-10-06 09:06:33 +00:00
feng lv
873805d4da
update poco
...
update
fix unbundled build
2021-10-04 13:55:49 +00:00
feng lv
9683513c52
fix build
2021-10-03 11:03:20 +00:00
feng lv
6eeade23fa
revert drop table immediately
...
remove unused code
fix pvs check
fix
2021-10-01 11:36:49 +00:00
feng lv
1758ff2d32
fix
2021-09-30 16:02:17 +00:00
feng lv
30428ad1b0
fix
2021-09-27 08:44:48 +00:00
feng lv
1eb96c2fce
fix
2021-09-27 04:39:50 +00:00
feng lv
6c4b0f2d37
drop table immediately
...
fix style
update
2021-09-26 14:13:12 +00:00
feng lv
7af96b12b1
add meta file
...
fix and update tests
2021-09-26 11:28:46 +00:00
feng lv
0009cab962
add virtual columns
2021-09-24 16:44:22 +00:00
feng lv
9456c67486
fix
...
fix test
fix
fix
fix
exception handle
2021-09-24 02:59:47 +00:00
feng lv
f637f4f2d1
remove unused variable
...
update test
update
2021-09-22 07:24:18 +00:00
feng lv
cd6f8078b5
refactor some code
2021-09-22 02:07:59 +00:00
feng lv
e3fa2e3634
fix
...
fix
update tests
update tests
2021-09-21 16:53:24 +00:00
feng lv
4fbc7c3f31
remove unused code
2021-09-18 03:01:25 +00:00
feng lv
cfa92a0c1e
fix
...
fix
2021-09-13 15:09:02 +00:00
feng lv
bd1990a67c
fix test and restrict path
2021-09-13 03:44:12 +00:00
feng lv
aa99516380
fix
...
fix
2021-09-12 16:43:34 +00:00
feng lv
810d180ce2
fix
2021-09-10 17:21:03 +00:00
feng lv
dfea640c67
fix
2021-09-05 11:41:13 +00:00
feng lv
09bc3d723a
refactor some code
2021-09-05 06:32:32 +00:00
feng lv
595005eb21
refactor some code
2021-09-04 17:04:35 +00:00
feng lv
fdc256e30d
fix build
2021-07-11 03:34:57 +00:00
feng lv
b15099fe6f
add directory watcher
2021-07-11 03:34:57 +00:00
feng lv
94011d91ba
initial implement
2021-07-11 03:34:56 +00:00